nativescript 9.0.4-dev.1 → 9.0.4-dev.3

package/lib/services/bundler/bundler-compiler-service.js

@@ -15,9 +15,11 @@ const decorators_1 = require("../../common/decorators");
 const constants_1 = require("../../constants");
 const yok_1 = require("../../common/yok");
 const package_path_helper_1 = require("../../helpers/package-path-helper");
+/* for specific bundling debugging separate from logger */
 const debugLog = false;
 class BundlerCompilerService extends events_1.EventEmitter {
-    constructor($options, $errors, $childProcess, $fs, $hooksService, $hostInfo, $logger, $mobileHelper, $cleanupService, $packageManager, $packageInstallationManager, $projectConfigService) {
+    constructor($options, $errors, $childProcess, $fs, $hooksService, $hostInfo, $logger, $mobileHelper, $cleanupService, $packageManager, $packageInstallationManager, // private $sharedEventBus: ISharedEventBus
+    $projectConfigService) {
         super();
         this.$options = $options;
         this.$errors = $errors;
@@ -44,6 +46,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
             prepareData.watch = true;
             try {
                 const childProcess = await this.startBundleProcess(platformData, projectData, prepareData);
+                // Handle Vite differently from webpack
                 const isVite = this.getBundler() === "vite";
                 childProcess.stdout.on("data", function (data) {
                     process.stdout.write(data);
@@ -51,8 +54,11 @@ class BundlerCompilerService extends events_1.EventEmitter {
                 childProcess.stderr.on("data", function (data) {
                     process.stderr.write(data);
                 });
+                // For both Vite and webpack, we wait for the first build to complete
+                // Don't resolve immediately for Vite - wait for first IPC message
                 childProcess.on("message", (message) => {
                     this.$logger.trace(`Message from ${projectData.bundler}`, message);
+                    // Handle Vite messages
                     if (isVite &&
                         message &&
                         message.emittedFiles) {
@@ -60,14 +66,17 @@ class BundlerCompilerService extends events_1.EventEmitter {
                         if (debugLog) {
                             console.log("Received Vite IPC message:", message);
                         }
+                        // Copy Vite output files directly to platform destination
                         const distOutput = path.join(projectData.projectDir, ".ns-vite-build");
                         const destDir = path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName);
                         if (debugLog) {
                             console.log(`Copying from ${distOutput} to ${destDir}.`);
                         }
+                        // Determine which files to copy based on build type and changes
                         if (message.buildType === "incremental" &&
                             message.emittedFiles &&
                             message.emittedFiles.length > 0) {
+                            // Incremental builds: only copy files that are likely affected by the changes
                             const filesToCopy = this.getIncrementalFilesToCopy(message.emittedFiles);
                             if (debugLog) {
                                 console.log("Incremental build - files to copy:", filesToCopy);
@@ -80,6 +89,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                             }
                             this.copyViteBundleToNative(distOutput, destDir);
                         }
+                        // Resolve the promise on first build completion
                         if (isFirstBundlerWatchCompilation) {
                             isFirstBundlerWatchCompilation = false;
                             if (debugLog) {
@@ -87,6 +97,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                             }
                             resolve(childProcess);
                         }
+                        // Transform Vite message to match webpack format
                         const files = message.emittedFiles.map((file) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, file));
                         const data = {
                             files,
@@ -104,14 +115,23 @@ class BundlerCompilerService extends events_1.EventEmitter {
                         this.emit(constants_1.BUNDLER_COMPILATION_COMPLETE, data);
                         return;
                     }
+                    // if we are on webpack5 - we handle HMR in a  slightly different way
                     if (typeof message === "object" &&
                         "version" in message &&
                         "type" in message) {
+                        // first compilation can be ignored because it will be synced regardless
+                        // handling it here would trigger 2 syncs
                         if (isFirstBundlerWatchCompilation) {
                             isFirstBundlerWatchCompilation = false;
                             resolve(childProcess);
                             return;
                         }
+                        // if ((message as IWebpackMessage).type === "hmr-status") {
+                        // 	// we pass message through our event-bus to be handled wherever needed
+                        // 	// in this case webpack-hmr-status-service listens for this event
+                        // 	this.$sharedEventBus.emit("webpack:hmr-status", message);
+                        // 	return;
+                        // }
                         return this.handleHMRMessage(message, platformData, projectData, prepareData);
                     }
                     if (message ===
@@ -127,6 +147,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                                 prepareData.hmr ? message.hash : "";
                             return;
                         }
+                        // Persist the previousHash value before calling `this.getUpdatedEmittedFiles` as it will modify the expectedHashes object with the current hash
                         const previousHash = this.expectedHashes[platformData.platformNameLowerCase];
                         let result;
                         if (prepareData.hmr) {
@@ -151,6 +172,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                             platform: platformData.platformNameLowerCase,
                         };
                         this.$logger.trace(`Generated data from ${projectData.bundler} message:`, data);
+                        // the hash of the compilation is the same as the previous one and there are only hot updates produced
                         if (data.hasOnlyHotUpdateFiles && previousHash === message.hash) {
                             return;
                         }
@@ -223,6 +245,9 @@ class BundlerCompilerService extends events_1.EventEmitter {
         }
     }
     async shouldUsePreserveSymlinksOption() {
+        // pnpm does not require symlink (https://github.com/nodejs/node-eps/issues/46#issuecomment-277373566)
+        // and it also does not work in some cases.
+        // Check https://github.com/NativeScript/nativescript-cli/issues/5259 for more information
         const currentPackageManager = await this.$packageManager.getPackageManagerName();
         const res = currentPackageManager !== constants_1.PackageManagers.pnpm;
         return res;
@@ -241,6 +266,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         const envData = this.buildEnvData(platformData.platformNameLowerCase, projectData, prepareData);
         const isVite = this.getBundler() === "vite";
         const cliArgs = await this.buildEnvCommandLineParams(envData, platformData, projectData, prepareData);
+        // Note: With Vite, we need `--` to prevent vite cli from erroring on unknown options.
         const envParams = isVite
             ? [
                 `--mode=${prepareData.release ? "production" : "development"}`,
@@ -308,16 +334,28 @@ class BundlerCompilerService extends events_1.EventEmitter {
         });
         envData.verbose = envData.verbose || this.$logger.isVerbose();
         envData.production = envData.production || prepareData.release;
+        // add the config file name to the env data so the webpack process can read the
+        // correct config file when resolving the CLI lib and the config service
+        // we are explicitly setting it to false to force using the defaults
         envData.config =
             (_b = (_a = process.env.NATIVESCRIPT_CONFIG_NAME) !== null && _a !== void 0 ? _a : this.$options.config) !== null && _b !== void 0 ? _b : "false";
+        // explicitly set the env variable
         process.env.NATIVESCRIPT_CONFIG_NAME = envData.config;
+        // The snapshot generation is wrongly located in the Webpack plugin.
+        // It should be moved in the Native Prepare of the CLI or a Gradle task in the Runtime.
+        // As a workaround, we skip the mksnapshot, xxd and android-ndk calls based on skipNativePrepare.
+        // In this way the plugin will prepare only the snapshot JS entry without any native prepare and
+        // we will able to execute cloud builds with snapshot without having any local snapshot or Docker setup.
+        // TODO: Remove this flag when we remove the native part from the plugin.
         envData.skipSnapshotTools =
             prepareData.nativePrepare && prepareData.nativePrepare.skipNativePrepare;
+        // only set sourceMap if not explicitly set through a flag
         if (typeof ((_c = prepareData === null || prepareData === void 0 ? void 0 : prepareData.env) === null || _c === void 0 ? void 0 : _c.sourceMap) === "undefined") {
             if (!prepareData.release) {
                 envData.sourceMap = true;
             }
         }
+        // convert string to boolean
         if (envData.sourceMap === "true" || envData.sourceMap === "false") {
             envData.sourceMap = envData.sourceMap === "true";
         }
@@ -338,6 +376,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
             }
             else if (this.$hostInfo.isWindows) {
                 if (projectData.bundler === "webpack") {
+                    //TODO: check this use case for webpack5 WEBPACK_PLUGIN_NAME
                     const minWebpackPluginWithWinSnapshotsVersion = "1.3.0";
                     const installedWebpackPluginVersion = await this.$packageInstallationManager.getInstalledDependencyVersion(constants_1.WEBPACK_PLUGIN_NAME, projectData.projectDir);
                     const hasWebpackPluginWithWinSnapshotsSupport = !!installedWebpackPluginVersion
@@ -371,6 +410,15 @@ class BundlerCompilerService extends events_1.EventEmitter {
     }
     getUpdatedEmittedFiles(allEmittedFiles, chunkFiles, nextHash, platform) {
         const currentHash = this.getCurrentHotUpdateHash(allEmittedFiles);
+        // This logic is needed as there are already cases when webpack doesn't emit any files physically.
+        // We've set noEmitOnErrors in webpack.config.js based on noEmitOnError from tsconfig.json,
+        // so webpack doesn't emit any files when noEmitOnErrors: true is set in webpack.config.js and
+        // there is a compilation error in the source code. On the other side, hmr generates new hot-update files
+        // on every change and the hash of the next hmr update is written inside hot-update.json file.
+        // Although webpack doesn't emit any files, hmr hash is still generated. The hash is generated per compilation no matter
+        // if files will be emitted or not. This way, the first successful compilation after fixing the compilation error generates
+        // a hash that is not the same as the one expected in the latest emitted hot-update.json file.
+        // As a result, the hmr chain is broken and the changes are not applied.
         const isHashValid = nextHash
             ? this.expectedHashes[platform] === currentHash
             : true;
@@ -389,6 +437,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         let hotHash;
         const hotUpdateScripts = emittedFiles.filter((x) => x.endsWith(".hot-update.js"));
         if (hotUpdateScripts && hotUpdateScripts.length) {
+            // the hash is the same for each hot update in the current compilation
             const hotUpdateName = hotUpdateScripts[0];
             const matcher = /^(.+)\.(.+)\.hot-update/gm;
             const matches = matcher.exec(hotUpdateName);
@@ -406,6 +455,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         }
     }
     handleHMRMessage(message, platformData, projectData, prepareData) {
+        // handle new bundler hmr packets
         this.$logger.trace(`Received message from ${projectData.bundler} process:`, message);
         if (message.type !== "compilation") {
             return;
@@ -413,6 +463,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         this.$logger.trace(`${capitalizeFirstLetter(projectData.bundler)} build done!`);
         const files = message.data.emittedAssets.map((asset) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, asset));
         const staleFiles = message.data.staleAssets.map((asset) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, asset));
+        // extract last hash from emitted filenames
         const lastHash = (() => {
             const absoluteFileNameWithLastHash = files.find((fileName) => fileName.endsWith("hot-update.js"));
             if (!absoluteFileNameWithLastHash) {
@@ -425,6 +476,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
             }
         })();
         if (!files.length) {
+            // ignore compilations if no new files are emitted
             return;
         }
         this.emit(constants_1.BUNDLER_COMPILATION_COMPLETE, {
@@ -488,20 +540,25 @@ class BundlerCompilerService extends events_1.EventEmitter {
         return this.$projectConfigService.getValue(`bundler`, "webpack");
     }
     copyViteBundleToNative(distOutput, destDir, specificFiles = null) {
+        // Clean and copy Vite output to native platform folder
         if (debugLog) {
             console.log(`Copying Vite bundle from "${distOutput}" to "${destDir}".`);
         }
         try {
             if (specificFiles) {
+                // Selective mode: only copy specific files (incremental)
                 if (debugLog) {
                     console.log("Selective copy - copying specific files:", specificFiles);
                 }
+                // Ensure destination directory exists
                 this.$fs.createDirectory(destDir);
+                // Copy only the specified files
                 for (const file of specificFiles) {
                     const srcPath = path.join(distOutput, file);
                     const destPath = path.join(destDir, file);
                     if (!this.$fs.exists(srcPath))
                         continue;
+                    // create parent dirs
                     this.$fs.createDirectory(path.dirname(destPath));
                     this.$fs.copyFile(srcPath, destPath);
                     if (debugLog) {
@@ -510,13 +567,16 @@ class BundlerCompilerService extends events_1.EventEmitter {
                 }
             }
             else {
+                // Full build mode: clean and copy everything
                 if (debugLog) {
                     console.log("Full build: Copying all files.");
                 }
+                // Clean destination directory
                 if (this.$fs.exists(destDir)) {
                     this.$fs.deleteDirectory(destDir);
                 }
                 this.$fs.createDirectory(destDir);
+                // Copy all files from dist to platform destination
                 if (this.$fs.exists(distOutput)) {
                     this.copyRecursiveSync(distOutput, destDir);
                 }
@@ -530,9 +590,12 @@ class BundlerCompilerService extends events_1.EventEmitter {
         }
     }
     getIncrementalFilesToCopy(emittedFiles) {
+        // For incremental builds, we need to determine which emitted files are likely affected
+        // by the source file changes
         const filesToCopy = [];
         const bundleFiles = emittedFiles.filter((file) => file.endsWith(".mjs") || file.endsWith(".js") || file.endsWith(".map"));
         filesToCopy.push(...bundleFiles);
+        // Only copy assets if there are explicit asset-related changes
         const assetFiles = emittedFiles.filter((file) => file.includes("assets/") ||
             file.includes("static/") ||
             file.includes("fonts/") ||
@@ -540,9 +603,11 @@ class BundlerCompilerService extends events_1.EventEmitter {
         if (assetFiles.length > 0) {
             filesToCopy.push(...assetFiles);
         }
+        // Remove duplicates and return
         return [...new Set(filesToCopy)];
     }
     copyRecursiveSync(src, dest) {
+        // Ensure destination exists
         this.$fs.createDirectory(dest);
         const entries = this.$fs.readDirectory(src);
         for (const name of entries) {
@@ -553,6 +618,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                 this.copyRecursiveSync(srcPath, destPath);
             }
             else if (lstats.isFile() || lstats.isSymbolicLink()) {
+                // create parent directory (copyFile will also ensure it, but keep explicit)
                 this.$fs.createDirectory(path.dirname(destPath));
                 this.$fs.copyFile(srcPath, destPath);
             }
@@ -567,3 +633,4 @@ function capitalizeFirstLetter(val) {
     return String(val).charAt(0).toUpperCase() + String(val).slice(1);
 }
 yok_1.injector.register("bundlerCompilerService", BundlerCompilerService);
+//# sourceMappingURL=bundler-compiler-service.js.map

package/lib/services/bundler/bundler.js

@@ -1,2 +1,3 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+//# sourceMappingURL=bundler.js.map

package/lib/services/cleanup-service.js

@@ -20,56 +20,56 @@ class CleanupService {
     async addCleanupCommand(commandInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddCleanCommand",
+            messageType: "AddCleanCommand" /* CleanupProcessMessage.AddCleanCommand */,
             commandInfo,
         });
     }
     async removeCleanupCommand(commandInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveCleanCommand",
+            messageType: "RemoveCleanCommand" /* CleanupProcessMessage.RemoveCleanCommand */,
             commandInfo,
         });
     }
     async addRequest(requestInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddRequest",
+            messageType: "AddRequest" /* CleanupProcessMessage.AddRequest */,
             requestInfo,
         });
     }
     async removeRequest(requestInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveRequest",
+            messageType: "RemoveRequest" /* CleanupProcessMessage.RemoveRequest */,
             requestInfo,
         });
     }
     async addCleanupDeleteAction(filePath) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddDeleteFileAction",
+            messageType: "AddDeleteFileAction" /* CleanupProcessMessage.AddDeleteFileAction */,
             filePath,
         });
     }
     async removeCleanupDeleteAction(filePath) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveDeleteFileAction",
+            messageType: "RemoveDeleteFileAction" /* CleanupProcessMessage.RemoveDeleteFileAction */,
             filePath,
         });
     }
     async addCleanupJS(jsCommand) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddJSFileToRequire",
+            messageType: "AddJSFileToRequire" /* CleanupProcessMessage.AddJSFileToRequire */,
             jsCommand,
         });
     }
     async removeCleanupJS(jsCommand) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveJSFileToRequire",
+            messageType: "RemoveJSFileToRequire" /* CleanupProcessMessage.RemoveJSFileToRequire */,
             jsCommand,
         });
     }
@@ -92,6 +92,8 @@ class CleanupService {
     setShouldDispose(shouldDispose) {
         this.shouldDispose = shouldDispose;
     }
+    // TODO: Consider extracting this method to a separate service
+    // as it has the same logic as the one used in analytics-service
     getCleanupProcess() {
         return new Promise((resolve, reject) => {
             const cleanupProcessArgs = this.getCleanupProcessArgs();
@@ -110,11 +112,12 @@ class CleanupService {
                 clearTimeout(timeoutId);
                 if (!isSettled) {
                     isSettled = true;
+                    // In case we throw error here, CLI will break its execution.
                     reject(err);
                 }
             });
             cleanupProcess.on("message", (data) => {
-                if (data === "ProcessReadyToReceive") {
+                if (data === "ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */) {
                     clearTimeout(timeoutId);
                     if (!isSettled) {
                         isSettled = true;
@@ -163,3 +166,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], CleanupService.prototype, "getCleanupProcess", null);
 yok_1.injector.register("cleanupService", CleanupService);
+//# sourceMappingURL=cleanup-service.js.map

package/lib/services/cocoapods-platform-manager.js

@@ -82,6 +82,7 @@ class CocoaPodsPlatformManager {
         _.each(allPodfiles, (podfileContent) => {
             const platformMatch = platformRowRegExp.exec(podfileContent);
             const podfilePathMatch = podfilePathRegExp.exec(podfileContent) || [];
+            // platform without version -> select it with highest priority
             if (platformMatch && platformMatch[0] && !platformMatch[2]) {
                 selectedPlatformData = {
                     version: null,
@@ -90,6 +91,7 @@ class CocoaPodsPlatformManager {
                 };
                 return false;
             }
+            // platform with version
             if (platformMatch && platformMatch[0] && platformMatch[2]) {
                 if (!selectedPlatformData ||
                     semver.gt(semver.coerce(platformMatch[2]), semver.coerce(selectedPlatformData.version))) {
@@ -104,6 +106,12 @@ class CocoaPodsPlatformManager {
         return selectedPlatformData;
     }
     shouldReplacePlatformSection(projectData, oldPodfilePlatformData, currentPodfilePlatformData) {
+        // The selected platform should be replaced in the following cases:
+        // 1. When the pod file is from App_Resources and the selected platform is not from App_Resources
+        // 2. When the pod file is from App_Resources, the selected platform is also from App_Resources
+        // and the pod's version is greater than the selected one
+        // 3. When the pod file doesn't have platform's version -> `platform :ios`
+        // 4. When the pod file has a version greater than the selected platform's version
         const appResourcesPodfilePath = path.join(projectData.getAppResourcesDirectoryPath(), "iOS", constants_1.PODFILE_NAME);
         const isFromAppResources = oldPodfilePlatformData.path !== appResourcesPodfilePath &&
             currentPodfilePlatformData.path === appResourcesPodfilePath;
@@ -135,3 +143,4 @@ class CocoaPodsPlatformManager {
 }
 exports.CocoaPodsPlatformManager = CocoaPodsPlatformManager;
 yok_1.injector.register("cocoaPodsPlatformManager", CocoaPodsPlatformManager);
+//# sourceMappingURL=cocoapods-platform-manager.js.map

package/lib/services/cocoapods-service.js

@@ -34,6 +34,12 @@ class CocoaPodsService {
         let podTool = this.$config.USE_POD_SANDBOX ? "sandbox-pod" : "pod";
         const args = ["install"];
         if (process.platform === "darwin" && process.arch === "arm64") {
+            // check if pod is installed as an x86_64 binary or a native arm64 one
+            // we run the following:
+            // arch -x86_64 pod --version
+            // if it's an arm64 binary, we'll get something like this as a result:
+            // arch: posix_spawnp: pod: Bad CPU type in executable
+            // in which case, we should run it natively.
             const res = await this.$childProcess
                 .exec("arch -x86_64 pod --version", null, {
                 showStderr: true,
@@ -47,8 +53,11 @@ class CocoaPodsService {
                 podTool = "arch";
             }
         }
+        // cocoapods print a lot of non-error information on stderr. Pipe the `stderr` to `stdout`, so we won't polute CLI's stderr output.
         const podInstallResult = await this.$childProcess.spawnFromEvent(podTool, args, "close", { cwd: projectRoot, stdio: ["pipe", process.stdout, process.stdout] }, { throwError: false });
         if (podInstallResult.exitCode !== 0) {
+            // https://github.com/CocoaPods/CocoaPods/blob/92aaf0f1120d32f3487960b485fb69fcaf61486c/lib/cocoapods/resolver.rb#L498
+            // TODO add article
             const versionResolutionHint = podInstallResult.exitCode === 31
                 ? `For more information on resolving CocoaPod issues in NativeScript read.`
                 : "";
@@ -80,6 +89,7 @@ ${versionResolutionHint}`);
     }
     async applyPodfileArchExclusions(projectData, platformData) {
         const xcodeVersionData = await this.$xcodeSelectService.getXcodeVersion();
+        // only apply EXCLUDED_ARCHS workaround on XCode 12
         if (+xcodeVersionData.major !== 12) {
             return;
         }
@@ -98,6 +108,7 @@ end`.trim();
             this.$fs.writeFile(exclusionsPodfile, exclusions);
         }
         await this.applyPodfileToProject("NativeScript-CLI-Architecture-Exclusions", exclusionsPodfile, projectData, platformData);
+        // clean up
         this.$fs.deleteFile(exclusionsPodfile);
     }
     async applyPodfileFromExtensions(projectData, platformData) {
@@ -120,6 +131,7 @@ end`.trim();
             podfilePath: path.join(extensionFolderPath, name, constants.PODFILE_NAME),
         }));
         extensionsPodfile.forEach(({ targetName, podfilePath }) => {
+            // Remove the data between #Begin Podfile and #EndPodfile
             const regExpToRemove = new RegExp(`${this.getExtensionPodfileHeader(podfilePath, targetName)}[\\s\\S]*?${this.getExtensionPodfileEnd()}`, "mg");
             projectPodFileContent = projectPodFileContent.replace(regExpToRemove, "");
             if (this.$fs.exists(podfilePath)) {
@@ -146,6 +158,7 @@ end`.trim();
             ? this.$fs.readText(pathToProjectPodfile).trim()
             : "";
         if (projectPodfileContent.indexOf(podfileContent) === -1) {
+            // Remove old occurences of the plugin from the project's Podfile.
             this.removePodfileFromProject(moduleName, podfilePath, projectData, nativeProjectPath);
             let finalPodfileContent = this.$fs.exists(pathToProjectPodfile)
                 ? this.getPodfileContentWithoutTarget(projectData, this.$fs.readText(pathToProjectPodfile))
@@ -163,6 +176,7 @@ end`.trim();
     removePodfileFromProject(moduleName, podfilePath, projectData, projectRoot) {
         if (this.$fs.exists(this.getProjectPodfilePath(projectRoot))) {
             let projectPodFileContent = this.$fs.readText(this.getProjectPodfilePath(projectRoot));
+            // Remove the data between #Begin Podfile and #EndPodfile
             const regExpToRemove = new RegExp(`${this.getPluginPodfileHeader(podfilePath)}[\\s\\S]*?${this.getPluginPodfileEnd()}`, "mg");
             projectPodFileContent = projectPodFileContent.replace(regExpToRemove, "");
             projectPodFileContent = this.removePostInstallHook(moduleName, projectPodFileContent);
@@ -183,7 +197,7 @@ end`.trim();
         }
     }
     getPluginPodfilePath(pluginData) {
-        const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath("ios");
+        const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath("ios" /* PlatformTypes.ios */);
         const pluginPodFilePath = path.join(pluginPlatformsFolderPath, constants_1.PODFILE_NAME);
         return pluginPodFilePath;
     }
@@ -219,6 +233,7 @@ end`.trim();
         if (_.startsWith(projectPodfileContent, podFileHeader)) {
             projectPodfileContent = projectPodfileContent.substr(podFileHeader.length);
             const podFileFooter = this.getPodfileFooter();
+            // Only remove the final end in case the file starts with the podFileHeader
             if (_.endsWith(projectPodfileContent, podFileFooter)) {
                 projectPodfileContent = projectPodfileContent.substr(0, projectPodfileContent.length - podFileFooter.length);
             }
@@ -239,6 +254,8 @@ end`.trim();
         return projectPodFileContent;
     }
     getHookBasicFuncNameForPlugin(hookName, pluginName) {
+        // nativescript-hook and nativescript_hook should have different names, so replace all _ with ___ first and then replace all special symbols with _
+        // This will lead to a clash in case plugins are called nativescript-hook and nativescript___hook
         const replacedPluginName = pluginName
             .replace(/_/g, "___")
             .replace(/[^A-Za-z0-9_]/g, "_");
@@ -252,6 +269,7 @@ end`.trim();
             const newFunctionName = `${this.getHookBasicFuncNameForPlugin(hookName, pluginName)}_${newFunctions.length}`;
             let newDefinition = `def ${newFunctionName}`;
             const rubyFunction = { functionName: newFunctionName };
+            // firstGroup is the block parameter, secondGroup is the block parameter name.
             if (firstGroup && secondGroup) {
                 newDefinition = `${newDefinition} (${secondGroup})`;
                 rubyFunction.functionParameters = secondGroup;
@@ -262,6 +280,7 @@ end`.trim();
         return { replacedContent, newFunctions };
     }
     getPluginPodfileHeader(pluginPodFilePath) {
+        // escape special + from the podfile path (pnpm)
         pluginPodFilePath = pluginPodFilePath.replace(/\+/g, "\\+");
         return `# Begin Podfile - ${pluginPodFilePath}`;
     }
@@ -331,3 +350,4 @@ exports.CocoaPodsService = CocoaPodsService;
 CocoaPodsService.PODFILE_POST_INSTALL_SECTION_NAME = "post_install";
 CocoaPodsService.INSTALLER_BLOCK_PARAMETER_NAME = "installer";
 yok_1.injector.register("cocoapodsService", CocoaPodsService);
+//# sourceMappingURL=cocoapods-service.js.map

package/lib/services/debug-data-service.js

@@ -19,3 +19,4 @@ class DebugDataService {
 }
 exports.DebugDataService = DebugDataService;
 yok_1.injector.register("debugDataService", DebugDataService);
+//# sourceMappingURL=debug-data-service.js.map

package/lib/services/debug-service-base.js

@@ -27,6 +27,12 @@ class DebugServiceBase extends events_1.EventEmitter {
         };
     }
     getChromeDebugUrl(debugOptions, port) {
+        // corresponds to 55.0.2883 Chrome version
+        // SHA is taken from https://chromium.googlesource.com/chromium/src/+/55.0.2883.100
+        // This SHA is old and does not support debugging with HMR.
+        // In case we want to stick with concrete SHA, get it from one of the tags https://chromium.googlesource.com/chromium/src/
+        // IMPORTANT: When you get the SHA, ensure you are using the `parent` commit, not the actual one.
+        // Using the actual commit will result in 404 error in the remote serve.
         const commitSHA = debugOptions.devToolsCommit || "02e6bde1bbe34e43b309d4ef774b1168d25fd024";
         const devToolsProtocol = `devtools`;
         let chromeDevToolsPrefix = `${devToolsProtocol}://devtools/remote/serve_file/@${commitSHA}`;
@@ -42,3 +48,4 @@ class DebugServiceBase extends events_1.EventEmitter {
     }
 }
 exports.DebugServiceBase = DebugServiceBase;
+//# sourceMappingURL=debug-service-base.js.map

package/lib/services/device/device-install-app-service.js

@@ -21,7 +21,7 @@ class DeviceInstallAppService {
         const projectData = this.$projectDataService.getProjectData(buildData.projectDir);
         const platformData = this.$platformsDataService.getPlatformData(platform, projectData);
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Deploy",
+            action: "Deploy" /* TrackActionNames.Deploy */,
             device,
             projectDir: projectData.projectDir,
         });
@@ -77,3 +77,4 @@ class DeviceInstallAppService {
 }
 exports.DeviceInstallAppService = DeviceInstallAppService;
 yok_1.injector.register("deviceInstallAppService", DeviceInstallAppService);
+//# sourceMappingURL=device-install-app-service.js.map

package/lib/services/doctor-service.js

@@ -52,9 +52,13 @@ class DoctorService {
             this.printPackageManagerTip();
         }
         if (!configOptions || configOptions.trackResult) {
+            // TODO(Analytics): Consider sending this information to Google Analytics
+            // await this.$analyticsService.track("DoctorEnvironmentSetup", hasWarnings ? "incorrect" : "correct");
         }
         if (hasWarnings) {
             this.$logger.info("There seem to be issues with your configuration.");
+            // cleanup the cache file as there seems to be issues with the current config
+            // all projects need to be rechecked
             this.$fs.deleteFile(this.jsonFileSettingsPath);
         }
         else {
@@ -68,6 +72,7 @@ class DoctorService {
         catch (err) {
             this.$logger.error("Cannot get the latest versions information from npm. Please try again later.");
         }
+        // todo: check for deprecated imports from `tns-core-modules`
         this.checkForDeprecatedShortImportsInAppDir(configOptions.projectDir);
         await this.$injector
             .resolve("platformEnvironmentRequirements")
@@ -80,12 +85,12 @@ class DoctorService {
     }
     async runSetupScript() {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Run Setup Script",
+            action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
             additionalData: "Starting",
         });
         if (this.$hostInfo.isLinux) {
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Run Setup Script",
+                action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
                 additionalData: "Skipped as OS is Linux",
             });
             return;
@@ -98,13 +103,13 @@ class DoctorService {
             await this.runSetupScriptCore(DoctorService.WindowsSetupScriptExecutable, DoctorService.WindowsSetupScriptArguments);
         }
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Run Setup Script",
+            action: "Run Setup Script" /* TrackActionNames.RunSetupScript */,
             additionalData: "Finished",
         });
     }
     async canExecuteLocalBuild(configuration) {
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Check Local Build Setup",
+            action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
             additionalData: "Starting",
         });
         const sysInfoConfig = {
@@ -116,9 +121,11 @@ class DoctorService {
         const warnings = this.filterInfosByType(infos, doctor_1.constants.WARNING_TYPE_NAME);
         const hasWarnings = warnings.length > 0;
         if (hasWarnings) {
+            // cleanup the cache file as there seems to be issues with the current config
+            // all projects need to be rechecked
             this.$fs.deleteFile(this.jsonFileSettingsPath);
             await this.$analyticsService.trackEventActionInGoogleAnalytics({
-                action: "Check Local Build Setup",
+                action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
                 additionalData: `Warnings:${warnings.map((w) => w.message).join("__")}`,
             });
             this.printInfosCore(infos);
@@ -128,7 +135,7 @@ class DoctorService {
             await this.$jsonFileSettingsService.saveSetting(this.getKeyForConfiguration(sysInfoConfig), infos);
         }
         await this.$analyticsService.trackEventActionInGoogleAnalytics({
-            action: "Check Local Build Setup",
+            action: "Check Local Build Setup" /* TrackActionNames.CheckLocalBuildSetup */,
             additionalData: `Finished: Is setup correct: ${!hasWarnings}`,
         });
         return !hasWarnings;
@@ -176,6 +183,13 @@ class DoctorService {
             .getFsStats(path.join(pathToTnsCoreModules, entry))
             .isDirectory());
         const stringRegularExpressionsPerDir = coreModulesSubDirs.map((c) => {
+            // require("text");
+            // require("text/smth");
+            // require(   "text/smth");
+            // require(   "text/smth"   );
+            // import * as text from "text";
+            // import { a } from "text";
+            // import {a } from "text/abc"
             const subDirPart = `[\"\']${c}[\"\'/]`;
             return `(\\brequire\\s*?\\(\\s*?${subDirPart})|(\\bimport\\b.*?from\\s*?${subDirPart})`;
         });
@@ -273,3 +287,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], DoctorService.prototype, "$jsonFileSettingsService", null);
 yok_1.injector.register("doctorService", DoctorService);
+//# sourceMappingURL=doctor-service.js.map