memory-journal-mcp 6.1.2 → 6.2.1

package/tests/github/pull-requests.test.ts

@@ -1,334 +0,0 @@
-/**
- * memory-journal-mcp — Pull Requests Manager Unit Tests
- *
- * Tests for PullRequestsManager: getPullRequests, getPullRequest,
- * getReviews, getReviewComments, getCopilotReviewSummary.
- */
-
-import { describe, it, expect, vi, beforeEach } from 'vitest'
-
-vi.mock('../../src/utils/logger.js', () => ({
-    logger: {
-        info: vi.fn(),
-        warning: vi.fn(),
-        error: vi.fn(),
-        debug: vi.fn(),
-    },
-}))
-
-import { PullRequestsManager } from '../../src/github/github-integration/pull-requests.js'
-
-// ============================================================================
-// Helpers
-// ============================================================================
-
-function createMockClient(overrides: Partial<Record<string, unknown>> = {}) {
-    const cache = new Map<string, unknown>()
-    return {
-        octokit: {
-            pulls: {
-                list: vi.fn().mockResolvedValue({
-                    data: [
-                        {
-                            number: 1,
-                            title: 'Feature A',
-                            html_url: 'https://github.com/x/1',
-                            state: 'open',
-                            merged_at: null,
-                        },
-                        {
-                            number: 2,
-                            title: 'Feature B',
-                            html_url: 'https://github.com/x/2',
-                            state: 'closed',
-                            merged_at: '2025-01-01',
-                        },
-                    ],
-                }),
-                get: vi.fn().mockResolvedValue({
-                    data: {
-                        number: 1,
-                        title: 'Feature A',
-                        html_url: 'https://github.com/x/1',
-                        state: 'open',
-                        merged_at: null,
-                        body: 'PR body',
-                        draft: false,
-                        head: { ref: 'feature-branch' },
-                        base: { ref: 'main' },
-                        user: { login: 'dev' },
-                        created_at: '2025-01-01T00:00:00Z',
-                        updated_at: '2025-01-02T00:00:00Z',
-                        closed_at: null,
-                        additions: 100,
-                        deletions: 50,
-                        changed_files: 5,
-                    },
-                }),
-            },
-            rest: {
-                pulls: {
-                    listReviews: vi.fn().mockResolvedValue({
-                        data: [
-                            {
-                                id: 1,
-                                user: { login: 'reviewer' },
-                                state: 'APPROVED',
-                                body: 'Looks good',
-                                submitted_at: '2025-01-01T12:00:00Z',
-                            },
-                            {
-                                id: 2,
-                                user: { login: 'copilot-pull-request-reviewer[bot]' },
-                                state: 'COMMENTED',
-                                body: 'Found issues',
-                                submitted_at: '2025-01-01T12:30:00Z',
-                            },
-                        ],
-                    }),
-                    listReviewComments: vi.fn().mockResolvedValue({
-                        data: [
-                            {
-                                id: 1,
-                                user: { login: 'copilot-pull-request-reviewer[bot]' },
-                                body: 'Fix this',
-                                path: 'src/index.ts',
-                                line: 42,
-                                side: 'RIGHT',
-                                created_at: '2025-01-01T12:30:00Z',
-                            },
-                        ],
-                    }),
-                },
-            },
-        },
-        getCached: vi.fn().mockImplementation((key: string) => cache.get(key)),
-        setCache: vi
-            .fn()
-            .mockImplementation((key: string, value: unknown) => cache.set(key, value)),
-        ...overrides,
-    }
-}
-
-// ============================================================================
-// Tests
-// ============================================================================
-
-describe('PullRequestsManager', () => {
-    beforeEach(() => {
-        vi.clearAllMocks()
-    })
-
-    // ========================================================================
-    // getPullRequests
-    // ========================================================================
-
-    describe('getPullRequests', () => {
-        it('should return empty array when no octokit', async () => {
-            const client = createMockClient({ octokit: null })
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getPullRequests('owner', 'repo')
-            expect(result).toEqual([])
-        })
-
-        it('should fetch and map PR states correctly', async () => {
-            const client = createMockClient()
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getPullRequests('owner', 'repo')
-
-            expect(result).toHaveLength(2)
-            expect(result[0]!.state).toBe('OPEN')
-            expect(result[1]!.state).toBe('MERGED') // merged_at is set
-        })
-
-        it('should return cached results on second call', async () => {
-            const client = createMockClient()
-            const mgr = new PullRequestsManager(client as never)
-
-            await mgr.getPullRequests('owner', 'repo')
-            const result = await mgr.getPullRequests('owner', 'repo')
-
-            expect(result).toHaveLength(2)
-            expect(client.octokit!.pulls.list).toHaveBeenCalledTimes(1)
-        })
-
-        it('should return empty array on API error', async () => {
-            const client = createMockClient()
-            client.octokit!.pulls.list.mockRejectedValue(new Error('API error'))
-            const mgr = new PullRequestsManager(client as never)
-
-            const result = await mgr.getPullRequests('owner', 'repo')
-            expect(result).toEqual([])
-        })
-    })
-
-    // ========================================================================
-    // getPullRequest
-    // ========================================================================
-
-    describe('getPullRequest', () => {
-        it('should return null when no octokit', async () => {
-            const client = createMockClient({ octokit: null })
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getPullRequest('owner', 'repo', 1)
-            expect(result).toBeNull()
-        })
-
-        it('should fetch and map PR detail fields', async () => {
-            const client = createMockClient()
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getPullRequest('owner', 'repo', 1)
-
-            expect(result).toBeDefined()
-            expect(result!.title).toBe('Feature A')
-            expect(result!.headBranch).toBe('feature-branch')
-            expect(result!.baseBranch).toBe('main')
-            expect(result!.additions).toBe(100)
-            expect(result!.deletions).toBe(50)
-        })
-
-        it('should return null on API error', async () => {
-            const client = createMockClient()
-            client.octokit!.pulls.get.mockRejectedValue(new Error('API error'))
-            const mgr = new PullRequestsManager(client as never)
-
-            const result = await mgr.getPullRequest('owner', 'repo', 1)
-            expect(result).toBeNull()
-        })
-    })
-
-    // ========================================================================
-    // getReviews
-    // ========================================================================
-
-    describe('getReviews', () => {
-        it('should return empty array when no octokit', async () => {
-            const client = createMockClient({ octokit: null })
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getReviews('owner', 'repo', 1)
-            expect(result).toEqual([])
-        })
-
-        it('should detect Copilot bot reviews', async () => {
-            const client = createMockClient()
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getReviews('owner', 'repo', 1)
-
-            expect(result).toHaveLength(2)
-            expect(result[0]!.isCopilot).toBe(false)
-            expect(result[1]!.isCopilot).toBe(true)
-        })
-
-        it('should return empty array on API error', async () => {
-            const client = createMockClient()
-            client.octokit!.rest.pulls.listReviews.mockRejectedValue(new Error('API error'))
-            const mgr = new PullRequestsManager(client as never)
-
-            const result = await mgr.getReviews('owner', 'repo', 1)
-            expect(result).toEqual([])
-        })
-    })
-
-    // ========================================================================
-    // getReviewComments
-    // ========================================================================
-
-    describe('getReviewComments', () => {
-        it('should return empty array when no octokit', async () => {
-            const client = createMockClient({ octokit: null })
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getReviewComments('owner', 'repo', 1)
-            expect(result).toEqual([])
-        })
-
-        it('should detect Copilot bot comments', async () => {
-            const client = createMockClient()
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getReviewComments('owner', 'repo', 1)
-
-            expect(result).toHaveLength(1)
-            expect(result[0]!.isCopilot).toBe(true)
-            expect(result[0]!.path).toBe('src/index.ts')
-        })
-    })
-
-    // ========================================================================
-    // getCopilotReviewSummary
-    // ========================================================================
-
-    describe('getCopilotReviewSummary', () => {
-        it('should aggregate Copilot review state from latest review', async () => {
-            const client = createMockClient()
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getCopilotReviewSummary('owner', 'repo', 1)
-
-            expect(result.prNumber).toBe(1)
-            expect(result.state).toBe('commented') // Latest Copilot review is COMMENTED
-            expect(result.commentCount).toBe(1)
-        })
-
-        it('should return state=none when no Copilot reviews', async () => {
-            const client = createMockClient()
-            client.octokit!.rest.pulls.listReviews.mockResolvedValue({
-                data: [
-                    {
-                        id: 1,
-                        user: { login: 'human' },
-                        state: 'APPROVED',
-                        body: '',
-                        submitted_at: '2025-01-01',
-                    },
-                ],
-            })
-            client.octokit!.rest.pulls.listReviewComments.mockResolvedValue({ data: [] })
-
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getCopilotReviewSummary('owner', 'repo', 1)
-
-            expect(result.state).toBe('none')
-            expect(result.commentCount).toBe(0)
-        })
-
-        it('should handle APPROVED Copilot review', async () => {
-            const client = createMockClient()
-            client.octokit!.rest.pulls.listReviews.mockResolvedValue({
-                data: [
-                    {
-                        id: 1,
-                        user: { login: 'copilot[bot]' },
-                        state: 'APPROVED',
-                        body: '',
-                        submitted_at: '2025-01-01',
-                    },
-                ],
-            })
-            client.octokit!.rest.pulls.listReviewComments.mockResolvedValue({ data: [] })
-
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getCopilotReviewSummary('owner', 'repo', 1)
-
-            expect(result.state).toBe('approved')
-        })
-
-        it('should handle CHANGES_REQUESTED Copilot review', async () => {
-            const client = createMockClient()
-            client.octokit!.rest.pulls.listReviews.mockResolvedValue({
-                data: [
-                    {
-                        id: 1,
-                        user: { login: 'github-copilot[bot]' },
-                        state: 'CHANGES_REQUESTED',
-                        body: '',
-                        submitted_at: '2025-01-01',
-                    },
-                ],
-            })
-            client.octokit!.rest.pulls.listReviewComments.mockResolvedValue({ data: [] })
-
-            const mgr = new PullRequestsManager(client as never)
-            const result = await mgr.getCopilotReviewSummary('owner', 'repo', 1)
-
-            expect(result.state).toBe('changes_requested')
-        })
-    })
-})

package/tests/handlers/analytics-branches.test.ts

@@ -1,222 +0,0 @@
-/**
- * memory-journal-mcp — Analytics Tools Branch Coverage Tests
- *
- * Targeted tests for uncovered branches in get_cross_project_insights:
- * date range filtering, empty results, tags, inactive detection, error paths.
- */
-
-import { describe, it, expect, vi, beforeEach } from 'vitest'
-
-vi.mock('../../src/utils/error-helpers.js', () => ({
-    formatHandlerError: vi.fn().mockImplementation((err: Error) => ({
-        success: false,
-        error: err.message,
-    })),
-}))
-
-import { getAnalyticsTools } from '../../src/handlers/tools/analytics.js'
-
-// ============================================================================
-// Helpers
-// ============================================================================
-
-function createMockDb(overrides: Partial<Record<string, unknown>> = {}) {
-    return {
-        getStatistics: vi.fn().mockReturnValue({
-            totalEntries: 100,
-            entriesByType: { note: 50, bug_fix: 30, planning: 20 },
-            entriesByPeriod: [{ period: '2025-W03', count: 10 }],
-            decisionDensity: [{ period: '2025-W03', significantCount: 2 }],
-            relationshipComplexity: { totalRelationships: 5, avgPerEntry: 0.05 },
-            activityTrend: {
-                currentPeriod: '2025-W03',
-                previousPeriod: '2025-W02',
-                growthPercent: 15,
-            },
-            causalMetrics: { blocked_by: 1, resolved: 2, caused: 3 },
-        }),
-        executeRawQuery: vi.fn(),
-        ...overrides,
-    }
-}
-
-function getInsightsHandler(db: ReturnType<typeof createMockDb>) {
-    const tools = getAnalyticsTools({ db, progress: null } as never)
-    return tools.find((t) => t.name === 'get_cross_project_insights')!.handler
-}
-
-function getStatisticsHandler(db: ReturnType<typeof createMockDb>) {
-    const tools = getAnalyticsTools({ db, progress: null } as never)
-    return tools.find((t) => t.name === 'get_statistics')!.handler
-}
-
-// ============================================================================
-// Tests
-// ============================================================================
-
-describe('analytics tools — branch coverage', () => {
-    beforeEach(() => {
-        vi.clearAllMocks()
-    })
-
-    // ========================================================================
-    // get_statistics branches
-    // ========================================================================
-
-    describe('get_statistics', () => {
-        it('should pass start_date and end_date to db.getStatistics', () => {
-            const db = createMockDb()
-            const handler = getStatisticsHandler(db)
-
-            handler({
-                group_by: 'month',
-                start_date: '2025-01-01',
-                end_date: '2025-01-31',
-                project_breakdown: true,
-            })
-
-            expect(db.getStatistics).toHaveBeenCalledWith('month', '2025-01-01', '2025-01-31', true)
-        })
-
-        it('should handle error with formatHandlerError', () => {
-            const db = createMockDb({
-                getStatistics: vi.fn().mockImplementation(() => {
-                    throw new Error('db error')
-                }),
-            })
-            const handler = getStatisticsHandler(db)
-
-            const result = handler({}) as Record<string, unknown>
-            expect(result['success']).toBe(false)
-        })
-    })
-
-    // ========================================================================
-    // get_cross_project_insights branches
-    // ========================================================================
-
-    describe('get_cross_project_insights', () => {
-        it('should return empty result when no projects match', () => {
-            const db = createMockDb({
-                executeRawQuery: vi.fn().mockReturnValue([{ columns: [], values: [] }]),
-            })
-            const handler = getInsightsHandler(db)
-
-            const result = handler({}) as Record<string, unknown>
-            expect(result['project_count']).toBe(0)
-            expect(result['message']).toContain('No projects found')
-        })
-
-        it('should filter by start_date and end_date', () => {
-            const db = createMockDb({
-                executeRawQuery: vi.fn().mockReturnValue([{ columns: [], values: [] }]),
-            })
-            const handler = getInsightsHandler(db)
-
-            handler({ start_date: '2025-01-01', end_date: '2025-03-31' })
-
-            // First call should include both date params
-            const firstCall = db.executeRawQuery.mock.calls[0] as [string, unknown[]]
-            expect(firstCall[0]).toContain('DATE(timestamp) >= DATE(?)')
-            expect(firstCall[0]).toContain('DATE(timestamp) <= DATE(?)')
-            expect(firstCall[1]).toContain('2025-01-01')
-            expect(firstCall[1]).toContain('2025-03-31')
-        })
-
-        it('should compute project data with tags and distribution', () => {
-            const db = createMockDb({
-                executeRawQuery: vi
-                    .fn()
-                    // 1st call: project stats
-                    .mockReturnValueOnce([
-                        {
-                            columns: [
-                                'project_number',
-                                'entry_count',
-                                'first_entry',
-                                'last_entry',
-                                'active_days',
-                            ],
-                            values: [
-                                [1, 10, '2025-01-01', '2025-01-10', 5],
-                                [2, 5, '2025-01-05', '2025-01-08', 3],
-                            ],
-                        },
-                    ])
-                    // 2nd call: tags per project
-                    .mockReturnValueOnce([
-                        {
-                            columns: ['project_number', 'name', 'count'],
-                            values: [
-                                [1, 'bug', 8],
-                                [1, 'feature', 4],
-                                [2, 'docs', 3],
-                            ],
-                        },
-                    ])
-                    // 3rd call: inactive projects
-                    .mockReturnValueOnce([
-                        {
-                            columns: ['project_number', 'last_entry_date'],
-                            values: [[2, '2025-01-08']],
-                        },
-                    ]),
-            })
-            const handler = getInsightsHandler(db)
-
-            const result = handler({}) as Record<string, unknown>
-
-            expect(result['project_count']).toBe(2)
-            expect(result['total_entries']).toBe(15)
-
-            const projects = result['projects'] as Record<string, unknown>[]
-            expect(projects[0]!['top_tags']).toHaveLength(2)
-
-            const distribution = result['time_distribution'] as Record<string, unknown>[]
-            expect(distribution[0]!['percentage']).toBe('66.7')
-
-            const inactive = result['inactive_projects'] as Record<string, unknown>[]
-            expect(inactive).toHaveLength(1)
-            expect(inactive[0]!['project_number']).toBe(2)
-        })
-
-        it('should handle missing tag results gracefully', () => {
-            const db = createMockDb({
-                executeRawQuery: vi
-                    .fn()
-                    .mockReturnValueOnce([
-                        {
-                            columns: [
-                                'project_number',
-                                'entry_count',
-                                'first_entry',
-                                'last_entry',
-                                'active_days',
-                            ],
-                            values: [[1, 10, '2025-01-01', '2025-01-10', 5]],
-                        },
-                    ])
-                    // Tags: no results
-                    .mockReturnValueOnce([])
-                    // Inactive: no results
-                    .mockReturnValueOnce([]),
-            })
-            const handler = getInsightsHandler(db)
-
-            const result = handler({}) as Record<string, unknown>
-
-            const projects = result['projects'] as Record<string, unknown>[]
-            expect(projects[0]!['top_tags']).toEqual([])
-            expect(result['inactive_projects']).toEqual([])
-        })
-
-        it('should handle Zod validation error', () => {
-            const db = createMockDb()
-            const handler = getInsightsHandler(db)
-
-            // Invalid date format triggers Zod error in handler
-            const result = handler({ start_date: 'not-a-date' }) as Record<string, unknown>
-            expect(result['success']).toBe(false)
-        })
-    })
-})