memory-journal-mcp 6.1.2 → 6.2.1

package/tests/e2e/tool-filtering.spec.ts

@@ -1,77 +0,0 @@
-/**
- * E2E Tests: Tool Filtering
- *
- * Launches a server with --tool-filter starter and validates that
- * only the expected subset of tools is exposed.
- *
- * Uses a dedicated server on port 3104.
- */
-
-import { test, expect } from '@playwright/test'
-import { Client } from '@modelcontextprotocol/sdk/client/index.js'
-import { StreamableHTTPClientTransport } from '@modelcontextprotocol/sdk/client/streamableHttp.js'
-import { startServer, stopServer } from './helpers.js'
-
-const FILTER_PORT = 3104
-
-test.describe('Tool Filtering', () => {
-    let client: Client
-
-    test.beforeAll(async () => {
-        await startServer(FILTER_PORT, ['--tool-filter', 'starter'], 'tool-filter')
-
-        const transport = new StreamableHTTPClientTransport(
-            new URL(`http://localhost:${FILTER_PORT}/mcp`)
-        )
-        client = new Client({ name: 'tool-filter-test', version: '1.0.0' }, { capabilities: {} })
-        await client.connect(transport)
-    })
-
-    test.afterAll(async () => {
-        await client.close()
-        stopServer(FILTER_PORT)
-    })
-
-    test('should expose only starter tools (not all 44)', async () => {
-        const response = await client.listTools()
-
-        expect(response.tools).toBeDefined()
-        expect(Array.isArray(response.tools)).toBe(true)
-        // Starter preset has ~11 tools (core+search+codemode), not the full 44+
-        expect(response.tools.length).toBeLessThan(20)
-        expect(response.tools.length).toBeGreaterThan(3)
-    })
-
-    test('should include core tools in starter preset', async () => {
-        const response = await client.listTools()
-        const names = response.tools.map((t) => t.name)
-
-        expect(names).toContain('create_entry')
-        expect(names).toContain('get_recent_entries')
-    })
-
-    test('should include codemode in starter preset', async () => {
-        const response = await client.listTools()
-        const names = response.tools.map((t) => t.name)
-
-        // starter = ['core', 'search', 'codemode'] — codemode is always auto-injected into shortcuts
-        expect(names).toContain('mj_execute_code')
-    })
-
-    test('should exclude github tools in starter preset', async () => {
-        const response = await client.listTools()
-        const names = response.tools.map((t) => t.name)
-
-        expect(names).not.toContain('get_github_issues')
-        expect(names).not.toContain('get_github_prs')
-        expect(names).not.toContain('get_kanban_board')
-    })
-
-    test('should exclude admin tools in starter preset', async () => {
-        const response = await client.listTools()
-        const names = response.tools.map((t) => t.name)
-
-        expect(names).not.toContain('delete_entry')
-        expect(names).not.toContain('rebuild_vector_index')
-    })
-})

package/tests/e2e/tools.spec.ts

@@ -1,111 +0,0 @@
-/**
- * E2E Tests: MCP Tool Execution via SDK Client
- *
- * Uses the official @modelcontextprotocol/sdk client to connect
- * via Streamable HTTP transport and execute tools end-to-end.
- */
-
-import { test, expect } from '@playwright/test'
-import { Client } from '@modelcontextprotocol/sdk/client/index.js'
-import { StreamableHTTPClientTransport } from '@modelcontextprotocol/sdk/client/streamableHttp.js'
-
-test.describe.configure({ mode: 'serial' })
-
-test.describe('E2E Tool Execution (via MCP SDK Client)', () => {
-    let client: Client
-
-    test.beforeAll(async () => {
-        const transport = new StreamableHTTPClientTransport(new URL('http://localhost:3100/mcp'))
-        client = new Client(
-            { name: 'playwright-tool-test', version: '1.0.0' },
-            { capabilities: {} }
-        )
-        await client.connect(transport)
-    })
-
-    test.afterAll(async () => {
-        await client.close()
-    })
-
-    test('should list available tools', async () => {
-        const listResponse = await client.listTools()
-
-        expect(listResponse.tools).toBeDefined()
-        expect(Array.isArray(listResponse.tools)).toBe(true)
-        expect(listResponse.tools.length).toBeGreaterThan(0)
-
-        const toolNames = listResponse.tools.map((t) => t.name)
-        expect(toolNames).toContain('create_entry')
-        expect(toolNames).toContain('search_entries')
-        expect(toolNames).toContain('test_simple')
-        expect(toolNames).toContain('get_recent_entries')
-    })
-
-    test('should execute test_simple tool', async () => {
-        const response = await client.callTool({
-            name: 'test_simple',
-            arguments: { message: 'Playwright E2E' },
-        })
-
-        expect(response.isError).toBeUndefined()
-        expect(Array.isArray(response.content)).toBe(true)
-        expect(response.content.length).toBeGreaterThan(0)
-        expect(response.content[0]).toHaveProperty('type', 'text')
-
-        const text = (response.content[0] as { type: string; text: string }).text
-        expect(text).toContain('Playwright E2E')
-    })
-
-    test('should execute create_entry_minimal and get structured response', async () => {
-        const response = await client.callTool({
-            name: 'create_entry_minimal',
-            arguments: { content: 'Playwright e2e test entry' },
-        })
-
-        expect(response.isError).toBeUndefined()
-        expect(Array.isArray(response.content)).toBe(true)
-        expect(response.content.length).toBeGreaterThan(0)
-
-        const text = (response.content[0] as { type: string; text: string }).text
-        const parsed = JSON.parse(text)
-        expect(parsed).toHaveProperty('success', true)
-        expect(parsed).toHaveProperty('entry')
-        expect(parsed.entry).toHaveProperty('id')
-    })
-
-    test('should execute get_recent_entries and return entries array', async () => {
-        const response = await client.callTool({
-            name: 'get_recent_entries',
-            arguments: { limit: 3 },
-        })
-
-        expect(response.isError).toBeUndefined()
-        expect(Array.isArray(response.content)).toBe(true)
-        expect(response.content.length).toBeGreaterThan(0)
-
-        const text = (response.content[0] as { type: string; text: string }).text
-        const parsed = JSON.parse(text)
-        expect(parsed).toHaveProperty('entries')
-        expect(Array.isArray(parsed.entries)).toBe(true)
-    })
-
-    test('should return structured error for invalid entry_type', async () => {
-        const response = await client.callTool({
-            name: 'create_entry',
-            arguments: {
-                content: 'test validation',
-                entry_type: 'invalid_type',
-            },
-        })
-
-        // Should NOT be a raw MCP error — should be structured handler error
-        expect(response.isError).toBeUndefined()
-        expect(Array.isArray(response.content)).toBe(true)
-
-        const text = (response.content[0] as { type: string; text: string }).text
-        const parsed = JSON.parse(text)
-        expect(parsed).toHaveProperty('success', false)
-        expect(parsed).toHaveProperty('error')
-        expect(parsed.error).toContain('entry_type')
-    })
-})

package/tests/filtering/tool-filter.test.ts

@@ -1,314 +0,0 @@
-/**
- * ToolFilter Tests
- *
- * Tests the tool filtering system: groups, meta-groups, parsing, filtering.
- */
-
-import { describe, it, expect, afterEach } from 'vitest'
-import {
-    TOOL_GROUPS,
-    META_GROUPS,
-    getAllToolNames,
-    getToolGroup,
-    parseToolFilter,
-    isToolEnabled,
-    filterTools,
-    getToolFilterFromEnv,
-    calculateTokenSavings,
-    getFilterSummary,
-} from '../../src/filtering/tool-filter.js'
-
-// ============================================================================
-// Constants
-// ============================================================================
-
-describe('TOOL_GROUPS', () => {
-    it('should contain all 8 groups', () => {
-        const groups = Object.keys(TOOL_GROUPS)
-        expect(groups).toContain('core')
-        expect(groups).toContain('search')
-        expect(groups).toContain('analytics')
-        expect(groups).toContain('relationships')
-        expect(groups).toContain('export')
-        expect(groups).toContain('admin')
-        expect(groups).toContain('github')
-        expect(groups).toContain('backup')
-    })
-
-    it('should have no duplicate tools across groups', () => {
-        const allTools = Object.values(TOOL_GROUPS).flat()
-        const unique = new Set(allTools)
-        expect(unique.size).toBe(allTools.length)
-    })
-})
-
-describe('META_GROUPS', () => {
-    it('should define starter as core + search + codemode', () => {
-        expect(META_GROUPS.starter).toEqual(['core', 'search', 'codemode'])
-    })
-
-    it('should define essential as core + codemode', () => {
-        expect(META_GROUPS.essential).toEqual(['core', 'codemode'])
-    })
-
-    it('should define full with all groups', () => {
-        expect(META_GROUPS.full).toContain('core')
-        expect(META_GROUPS.full).toContain('github')
-        expect(META_GROUPS.full).toContain('backup')
-    })
-
-    it('should define readonly without admin, github, backup', () => {
-        expect(META_GROUPS.readonly).not.toContain('admin')
-        expect(META_GROUPS.readonly).not.toContain('github')
-        expect(META_GROUPS.readonly).not.toContain('backup')
-    })
-})
-
-// ============================================================================
-// getAllToolNames
-// ============================================================================
-
-describe('getAllToolNames', () => {
-    it('should return all tools', () => {
-        const names = getAllToolNames()
-        expect(names.length).toBeGreaterThan(0)
-    })
-
-    it('should contain no duplicates', () => {
-        const names = getAllToolNames()
-        const unique = new Set(names)
-        expect(unique.size).toBe(names.length)
-    })
-
-    it('should include known tools', () => {
-        const names = getAllToolNames()
-        expect(names).toContain('create_entry')
-        expect(names).toContain('search_entries')
-        expect(names).toContain('backup_journal')
-    })
-})
-
-// ============================================================================
-// getToolGroup
-// ============================================================================
-
-describe('getToolGroup', () => {
-    it('should return correct group for known tools', () => {
-        expect(getToolGroup('create_entry')).toBe('core')
-        expect(getToolGroup('search_entries')).toBe('search')
-        expect(getToolGroup('backup_journal')).toBe('backup')
-    })
-
-    it('should return undefined for unknown tools', () => {
-        expect(getToolGroup('nonexistent_tool')).toBeUndefined()
-    })
-})
-
-// ============================================================================
-// Type guards
-// ============================================================================
-
-describe('group validation via getToolGroup', () => {
-    it('should identify valid groups from tool lookups', () => {
-        expect(getToolGroup('create_entry')).toBe('core')
-        expect(getToolGroup('search_entries')).toBe('search')
-        expect(getToolGroup('delete_entry')).toBe('admin')
-    })
-
-    it('should return undefined for non-tool strings', () => {
-        expect(getToolGroup('starter')).toBeUndefined() // meta-group, not a tool
-        expect(getToolGroup('nonexistent')).toBeUndefined()
-    })
-})
-
-// ============================================================================
-// parseToolFilter
-// ============================================================================
-
-describe('parseToolFilter', () => {
-    it('should parse a single group', () => {
-        const config = parseToolFilter('core')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('backup_journal')).toBe(false)
-    })
-
-    it('should parse multiple groups', () => {
-        const config = parseToolFilter('core,search')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('search_entries')).toBe(true)
-        expect(config.enabledTools.has('backup_journal')).toBe(false)
-    })
-
-    it('should parse meta-groups', () => {
-        const config = parseToolFilter('starter')
-        // starter = core + search + codemode
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('search_entries')).toBe(true)
-        expect(config.enabledTools.has('mj_execute_code')).toBe(true)
-    })
-
-    it('should parse group exclusion', () => {
-        const config = parseToolFilter('full,-admin')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        // Admin tools should be excluded
-        expect(config.enabledTools.has('delete_entry')).toBe(false)
-        expect(config.enabledTools.has('merge_tags')).toBe(false)
-    })
-
-    it('should parse tool exclusion', () => {
-        const config = parseToolFilter('core,-delete_entry')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('delete_entry')).toBe(false)
-    })
-
-    it('should parse tool addition with +', () => {
-        const config = parseToolFilter('core,+semantic_search')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('semantic_search')).toBe(true)
-    })
-
-    it('should store raw filter string', () => {
-        const config = parseToolFilter('starter,-delete_entry')
-        expect(config.raw).toBe('starter,-delete_entry')
-    })
-})
-
-// ============================================================================
-// isToolEnabled / filterTools
-// ============================================================================
-
-describe('isToolEnabled', () => {
-    it('should return true for enabled tools', () => {
-        const config = parseToolFilter('core')
-        expect(isToolEnabled('create_entry', config)).toBe(true)
-    })
-
-    it('should return false for disabled tools', () => {
-        const config = parseToolFilter('core')
-        expect(isToolEnabled('backup_journal', config)).toBe(false)
-    })
-})
-
-describe('filterTools', () => {
-    it('should filter tool objects by name', () => {
-        const tools = [
-            { name: 'create_entry', other: 'data' },
-            { name: 'backup_journal', other: 'data' },
-            { name: 'search_entries', other: 'data' },
-        ]
-        const config = parseToolFilter('core')
-        const filtered = filterTools(tools, config)
-
-        expect(filtered.some((t) => t.name === 'create_entry')).toBe(true)
-        expect(filtered.some((t) => t.name === 'backup_journal')).toBe(false)
-    })
-})
-
-// ============================================================================
-// getToolFilterFromEnv
-// ============================================================================
-
-describe('getToolFilterFromEnv', () => {
-    afterEach(() => {
-        delete process.env['MEMORY_JOURNAL_MCP_TOOL_FILTER']
-    })
-
-    it('should return null when env var not set', () => {
-        delete process.env['MEMORY_JOURNAL_MCP_TOOL_FILTER']
-        expect(getToolFilterFromEnv()).toBeNull()
-    })
-
-    it('should parse env var when set', () => {
-        process.env['MEMORY_JOURNAL_MCP_TOOL_FILTER'] = 'starter'
-        const config = getToolFilterFromEnv()
-
-        expect(config).not.toBeNull()
-        expect(config?.enabledTools.has('create_entry')).toBe(true)
-    })
-})
-
-// ============================================================================
-// calculateTokenSavings
-// ============================================================================
-
-describe('calculateTokenSavings', () => {
-    it('should calculate correct reduction percentage', () => {
-        const result = calculateTokenSavings(38, 10)
-        // (38-10)/38 ≈ 73.68%
-        expect(result.reduction).toBeGreaterThan(70)
-        expect(result.reduction).toBeLessThan(80)
-    })
-
-    it('should calculate saved tokens', () => {
-        const result = calculateTokenSavings(38, 10, 150)
-        // (38-10) * 150 = 4200
-        expect(result.savedTokens).toBe(4200)
-    })
-
-    it('should return 0 when no tools filtered', () => {
-        const result = calculateTokenSavings(38, 38)
-        expect(result.reduction).toBe(0)
-        expect(result.savedTokens).toBe(0)
-    })
-})
-
-// ============================================================================
-// getFilterSummary
-// ============================================================================
-
-describe('getFilterSummary', () => {
-    it('should return human-readable summary', () => {
-        const config = parseToolFilter('starter')
-        const summary = getFilterSummary(config)
-
-        expect(typeof summary).toBe('string')
-        expect(summary.length).toBeGreaterThan(0)
-    })
-})
-
-// ============================================================================
-// parseToolFilter edge cases
-// ============================================================================
-
-describe('parseToolFilter edge cases', () => {
-    it('should handle blacklist-first mode (-admin = all except admin)', () => {
-        const config = parseToolFilter('-admin')
-        // Should have all tools EXCEPT admin tools
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('search_entries')).toBe(true)
-        expect(config.enabledTools.has('backup_journal')).toBe(true)
-        // Admin tools should be excluded
-        expect(config.enabledTools.has('delete_entry')).toBe(false)
-    })
-
-    it('should handle single tool name whitelist', () => {
-        const config = parseToolFilter('create_entry')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.size).toBe(1)
-    })
-
-    it('should handle meta-group in non-first position', () => {
-        const config = parseToolFilter('backup,starter')
-        // starter = core + search + codemode, plus backup group
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('search_entries')).toBe(true)
-        expect(config.enabledTools.has('backup_journal')).toBe(true)
-        expect(config.enabledTools.has('mj_execute_code')).toBe(true)
-    })
-
-    it('should handle combined meta-group with tool exclusion', () => {
-        const config = parseToolFilter('starter,-create_entry_minimal')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('create_entry_minimal')).toBe(false)
-    })
-
-    it('should handle multiple exclusions', () => {
-        const config = parseToolFilter('full,-admin,-backup,-github')
-        expect(config.enabledTools.has('create_entry')).toBe(true)
-        expect(config.enabledTools.has('search_entries')).toBe(true)
-        // Excluded groups
-        expect(config.enabledTools.has('delete_entry')).toBe(false)
-        expect(config.enabledTools.has('backup_journal')).toBe(false)
-        expect(config.enabledTools.has('get_github_issues')).toBe(false)
-    })
-})