memory-journal-mcp 6.1.2 → 6.2.1

package/tests/handlers/targeted-gap-closure.test.ts

@@ -1,387 +0,0 @@
-/**
- * Additional Coverage Tests — Targeted Gap Closure
- *
- * Tests for remaining uncovered lines in:
- * - core.ts: resolveTeamAuthor fallback, list_tags/test_simple error paths
- * - backup.ts: backup_journal error, list_backups error
- * - team.ts: team_create_entry, team_get_recent, team_search without teamDb
- * - read-tools.ts: GitHub tools without integration
- * - kanban-tools.ts: empty kanban
- */
-
-import { describe, it, expect, beforeAll, afterAll, vi } from 'vitest'
-import { callTool } from '../../src/handlers/tools/index.js'
-import { DatabaseAdapter } from '../../src/database/sqlite-adapter/index.js'
-
-describe('Targeted Gap Closure', () => {
-    let db: DatabaseAdapter
-    let teamDb: DatabaseAdapter
-    const testDbPath = './test-gaps.db'
-    const teamDbPath = './test-gaps-team.db'
-
-    beforeAll(async () => {
-        db = new DatabaseAdapter(testDbPath)
-        await db.initialize()
-        teamDb = new DatabaseAdapter(teamDbPath)
-        await teamDb.initialize()
-
-        db.createEntry({
-            content: 'Gap closure test entry',
-            tags: ['gap-test'],
-            projectNumber: 1,
-        })
-    })
-
-    afterAll(() => {
-        db.close()
-        teamDb.close()
-        try {
-            const fs = require('node:fs')
-            for (const p of [testDbPath, teamDbPath]) {
-                if (fs.existsSync(p)) fs.unlinkSync(p)
-            }
-        } catch {
-            // Ignore cleanup errors
-        }
-    })
-
-    // ========================================================================
-    // core.ts — test_simple, list_tags error paths (lines 310, 327, 345)
-    // ========================================================================
-
-    describe('test_simple', () => {
-        it('should return default message when no param', async () => {
-            const result = (await callTool('test_simple', {}, db)) as { message: string }
-            expect(result.message).toContain('Test response: Hello')
-        })
-
-        it('should return custom message', async () => {
-            const result = (await callTool('test_simple', { message: 'World' }, db)) as {
-                message: string
-            }
-            expect(result.message).toContain('World')
-        })
-    })
-
-    describe('list_tags', () => {
-        it('should list tags with counts', async () => {
-            const result = (await callTool('list_tags', {}, db)) as {
-                tags: { name: string; count: number }[]
-                count: number
-            }
-            expect(result.count).toBeGreaterThan(0)
-            expect(result.tags[0]).toHaveProperty('name')
-            expect(result.tags[0]).toHaveProperty('count')
-        })
-    })
-
-    // ========================================================================
-    // core.ts — create_entry with vectorManager (fire-and-forget)
-    // ========================================================================
-
-    describe('create_entry_minimal with vectorManager', () => {
-        it('should auto-index entry to vector store', async () => {
-            const vectorManager = {
-                isInitialized: vi.fn().mockReturnValue(true),
-                initialize: vi.fn().mockResolvedValue(undefined),
-                search: vi.fn().mockResolvedValue([]),
-                addEntry: vi.fn().mockResolvedValue(true),
-                removeEntry: vi.fn().mockResolvedValue(true),
-                rebuildIndex: vi.fn().mockResolvedValue(0),
-                getStats: vi.fn().mockResolvedValue({ itemCount: 0, modelName: 'test' }),
-                generateEmbedding: vi.fn().mockResolvedValue([]),
-            } as any
-
-            const result = (await callTool(
-                'create_entry_minimal',
-                { content: 'Minimal entry with vector indexing' },
-                db,
-                vectorManager
-            )) as { success: boolean }
-
-            expect(result.success).toBe(true)
-            expect(vectorManager.addEntry).toHaveBeenCalled()
-        })
-    })
-
-    // ========================================================================
-    // core.ts — get_entry_by_id not found (line 266)
-    // ========================================================================
-
-    describe('get_entry_by_id not found', () => {
-        it('should return error for nonexistent entry', async () => {
-            const result = (await callTool('get_entry_by_id', { entry_id: 99999 }, db)) as {
-                error: string
-            }
-
-            expect(result.error).toContain('not found')
-        })
-    })
-
-    // ========================================================================
-    // core.ts — get_recent_entries error (line 284)
-    // ========================================================================
-
-    describe('get_recent_entries', () => {
-        it('should return entries with is_personal filter', async () => {
-            const result = (await callTool(
-                'get_recent_entries',
-                { limit: 5, is_personal: false },
-                db
-            )) as { entries: unknown[]; count: number }
-
-            expect(result.count).toBeGreaterThanOrEqual(0)
-        })
-    })
-
-    // ========================================================================
-    // backup.ts — backup_journal (line 102 error), list_backups (line 127 error)
-    // ========================================================================
-
-    describe('backup_journal', () => {
-        it('should create a backup with custom name', async () => {
-            const result = (await callTool('backup_journal', { name: 'test-gap-backup' }, db)) as {
-                success: boolean
-                filename: string
-            }
-
-            expect(result.success).toBe(true)
-            expect(result.filename).toContain('test-gap-backup')
-        })
-    })
-
-    describe('list_backups', () => {
-        it('should list available backups', async () => {
-            const result = (await callTool('list_backups', {}, db)) as {
-                total: number
-                backupsDirectory: string
-            }
-
-            expect(result.total).toBeGreaterThanOrEqual(0)
-            expect(result.backupsDirectory).toBeDefined()
-        })
-    })
-
-    // ========================================================================
-    // team.ts — tools without teamDb (lines 42, 185, 219, 268)
-    // ========================================================================
-
-    describe('team tools without teamDb', () => {
-        it('team_create_entry should return error', async () => {
-            const result = (await callTool('team_create_entry', { content: 'Test entry' }, db)) as {
-                success: boolean
-                error: string
-            }
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team database not configured')
-        })
-
-        it('team_get_recent should return error', async () => {
-            const result = (await callTool('team_get_recent', { limit: 5 }, db)) as {
-                success: boolean
-                error: string
-            }
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team database not configured')
-        })
-
-        it('team_search should return error', async () => {
-            const result = (await callTool('team_search', { query: 'test' }, db)) as {
-                success: boolean
-                error: string
-            }
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team database not configured')
-        })
-    })
-
-    // ========================================================================
-    // team.ts — team_create_entry with teamDb (lines 149-151)
-    // ========================================================================
-
-    describe('team_create_entry with teamDb', () => {
-        it('should create entry in team database', async () => {
-            const result = (await callTool(
-                'team_create_entry',
-                {
-                    content: 'Team collaboration entry',
-                    tags: ['team-test'],
-                },
-                db,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as { success: boolean; author: string }
-
-            // May fail at setting author column (no author column in schema)
-            // but should still attempt the code path
-            expect(result.success !== undefined || result.author !== undefined).toBe(true)
-        })
-
-        it('should handle invalid entry_type', async () => {
-            const result = (await callTool(
-                'team_create_entry',
-                {
-                    content: 'Bad type entry',
-                    entry_type: 'invalid_type_xyz',
-                },
-                db,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as { error: string }
-
-            expect(result.error).toBeDefined()
-        })
-    })
-
-    // ========================================================================
-    // team.ts — team_get_recent with teamDb
-    // ========================================================================
-
-    describe('team_get_recent with teamDb', () => {
-        it('should attempt to enrich entries with author', async () => {
-            teamDb.createEntry({ content: 'Team recent test entry' })
-
-            const result = (await callTool(
-                'team_get_recent',
-                { limit: 5 },
-                db,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as Record<string, unknown>
-
-            // May return error (no author column) or entries — covers the code path
-            expect(result).toBeDefined()
-        })
-    })
-
-    // ========================================================================
-    // team.ts — team_search with teamDb
-    // ========================================================================
-
-    describe('team_search with teamDb', () => {
-        it('should attempt search and author enrichment', async () => {
-            const result = (await callTool(
-                'team_search',
-                { query: 'Team recent', limit: 5 },
-                db,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as Record<string, unknown>
-
-            // Covers search path — may error at author enrichment
-            expect(result).toBeDefined()
-        })
-
-        it('should attempt tag-filtered search', async () => {
-            const result = (await callTool(
-                'team_search',
-                { tags: ['team-test'], limit: 5 },
-                db,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as Record<string, unknown>
-
-            expect(result).toBeDefined()
-        })
-
-        it('should attempt recent fallback (no query)', async () => {
-            const result = (await callTool(
-                'team_search',
-                { limit: 3 },
-                db,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as Record<string, unknown>
-
-            expect(result).toBeDefined()
-        })
-    })
-
-    // ========================================================================
-    // read-tools.ts — GitHub tools without integration (lines 49, 127, 188, etc.)
-    // ========================================================================
-
-    describe('GitHub read tools without integration', () => {
-        it('get_github_issues should return error', async () => {
-            const result = (await callTool('get_github_issues', {}, db)) as { error: string }
-
-            expect(result.error).toContain('not available')
-        })
-
-        it('get_github_prs should return error', async () => {
-            const result = (await callTool('get_github_prs', {}, db)) as { error: string }
-
-            expect(result.error).toContain('not available')
-        })
-
-        it('get_github_issue should return error', async () => {
-            const result = (await callTool('get_github_issue', { issue_number: 1 }, db)) as {
-                error: string
-            }
-
-            expect(result.error).toContain('not available')
-        })
-
-        it('get_github_pr should return error', async () => {
-            const result = (await callTool('get_github_pr', { pr_number: 1 }, db)) as {
-                error: string
-            }
-
-            expect(result.error).toContain('not available')
-        })
-
-        it('get_github_context should return error', async () => {
-            const result = (await callTool('get_github_context', {}, db)) as { error: string }
-
-            expect(result.error).toContain('not available')
-        })
-    })
-
-    // Note: GitHub write/mutation tools are only registered when `github`
-    // context is provided, so they can't be tested via callTool without it.
-
-    // ========================================================================
-    // kanban-tools.ts — without GitHub (lines 54-56, 129)
-    // ========================================================================
-
-    describe('kanban tools without integration', () => {
-        it('get_kanban_board should return error', async () => {
-            const result = (await callTool('get_kanban_board', { project_number: 1 }, db)) as {
-                error: string
-            }
-
-            expect(result.error).toContain('not available')
-        })
-
-        it('move_kanban_item should return error', async () => {
-            const result = (await callTool(
-                'move_kanban_item',
-                { project_number: 1, item_id: 'abc', target_status: 'Done' },
-                db
-            )) as { error: string }
-
-            expect(result.error).toContain('not available')
-        })
-    })
-})

package/tests/handlers/team-admin.test.ts

@@ -1,291 +0,0 @@
-/**
- * Team Admin Tool Handler Tests
- *
- * Tests the team admin tool group: team_update_entry, team_delete_entry, team_merge_tags
- */
-
-import { describe, it, expect, beforeAll, afterAll } from 'vitest'
-import { callTool } from '../../src/handlers/tools/index.js'
-import { DatabaseAdapter } from '../../src/database/sqlite-adapter/index.js'
-
-describe('Team Admin Tool Handlers', () => {
-    let personalDb: DatabaseAdapter
-    let teamDb: DatabaseAdapter
-    const personalDbPath = './test-team-admin-personal.db'
-    const teamDbPath = './test-team-admin-team.db'
-
-    beforeAll(async () => {
-        try {
-            const fs = require('node:fs')
-            if (fs.existsSync(personalDbPath)) fs.unlinkSync(personalDbPath)
-            if (fs.existsSync(teamDbPath)) fs.unlinkSync(teamDbPath)
-        } catch {}
-
-        personalDb = new DatabaseAdapter(personalDbPath)
-        await personalDb.initialize()
-
-        teamDb = new DatabaseAdapter(teamDbPath)
-        await teamDb.initialize()
-        teamDb.applyTeamSchema()
-    })
-
-    afterAll(() => {
-        personalDb.close()
-        teamDb.close()
-        try {
-            const fs = require('node:fs')
-            if (fs.existsSync(personalDbPath)) fs.unlinkSync(personalDbPath)
-            if (fs.existsSync(teamDbPath)) fs.unlinkSync(teamDbPath)
-        } catch {
-            // Ignore cleanup errors
-        }
-    })
-
-    describe('team_update_entry', () => {
-        it('should update an existing team entry', async () => {
-            const createResult = (await callTool(
-                'team_create_entry',
-                { content: 'Original content', entry_type: 'technical_note', tags: ['old-tag'] },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            console.error('DEBUG TEAM ADMIN CREATE ENTRY', JSON.stringify(createResult, null, 2))
-            expect(createResult.success).toBe(true)
-            const entryId = createResult.entry.id
-
-            const updateResult = (await callTool(
-                'team_update_entry',
-                {
-                    entry_id: entryId,
-                    content: 'Updated content',
-                    entry_type: 'bug_fix',
-                    tags: ['new-tag'],
-                },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(updateResult.success).toBe(true)
-            expect(updateResult.entry.content).toBe('Updated content')
-            expect(updateResult.entry.entryType).toBe('bug_fix')
-            expect(updateResult.entry.tags).toEqual(['new-tag'])
-        })
-
-        it('should return error if team DB is not configured', async () => {
-            const result = (await callTool(
-                'team_update_entry',
-                { entry_id: 999, content: 'test' },
-                personalDb
-            )) as any
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team database not configured')
-        })
-
-        it('should return error if entry is not found', async () => {
-            const result = (await callTool(
-                'team_update_entry',
-                { entry_id: 9999, content: 'test' },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team entry 9999 not found')
-            expect(result.code).toBe('RESOURCE_NOT_FOUND')
-        })
-    })
-
-    describe('team_delete_entry', () => {
-        it('should soft-delete an existing team entry', async () => {
-            const createResult = (await callTool(
-                'team_create_entry',
-                { content: 'To be deleted' },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            const entryId = createResult.entry.id
-
-            const deleteResult = (await callTool(
-                'team_delete_entry',
-                { entry_id: entryId },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(deleteResult.success).toBe(true)
-            expect(deleteResult.message).toContain('soft-deleted')
-
-            // Verify it cannot be updated
-            const updateResult = (await callTool(
-                'team_update_entry',
-                { entry_id: entryId, content: 'Cannot update deleted' },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(updateResult.success).toBe(false)
-            expect(updateResult.error).toContain('not found')
-        })
-
-        it('should return error if team DB is not configured', async () => {
-            const result = (await callTool(
-                'team_delete_entry',
-                { entry_id: 999 },
-                personalDb
-            )) as any
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team database not configured')
-        })
-
-        it('should return error if entry is not found', async () => {
-            const result = (await callTool(
-                'team_delete_entry',
-                { entry_id: 9999 },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('not found')
-        })
-    })
-
-    describe('team_merge_tags', () => {
-        it('should merge source tag into target tag for team entries', async () => {
-            // Create entries with source tag
-            await callTool(
-                'team_create_entry',
-                { content: '1', tags: ['merge-source-tag'] },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )
-            await callTool(
-                'team_create_entry',
-                { content: '2', tags: ['merge-source-tag', 'other-tag'] },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )
-            await callTool(
-                'team_create_entry',
-                { content: '3', tags: ['merge-target-tag'] },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )
-
-            const mergeResult = (await callTool(
-                'team_merge_tags',
-                { source_tag: 'merge-source-tag', target_tag: 'merge-target-tag' },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(mergeResult.success).toBe(true)
-            expect(mergeResult.entriesUpdated).toBeGreaterThanOrEqual(2)
-            expect(mergeResult.sourceDeleted).toBe(true)
-
-            // Verify search by source tag returns empty
-            const searchSource = (await callTool(
-                'team_search',
-                { tags: ['merge-source-tag'] },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(searchSource.count).toBe(0)
-
-            // Verify search by target tag returns at least 3
-            const searchTarget = (await callTool(
-                'team_search',
-                { tags: ['merge-target-tag'] },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(searchTarget.count).toBeGreaterThanOrEqual(3)
-        })
-
-        it('should return error if source and target are the same', async () => {
-            const result = (await callTool(
-                'team_merge_tags',
-                { source_tag: 'same-tag', target_tag: 'same-tag' },
-                personalDb,
-                undefined,
-                undefined,
-                undefined,
-                undefined,
-                teamDb
-            )) as any
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('must be different')
-            expect(result.code).toBe('VALIDATION_ERROR')
-        })
-
-        it('should return error if team DB is not configured', async () => {
-            const result = (await callTool(
-                'team_merge_tags',
-                { source_tag: 'a', target_tag: 'b' },
-                personalDb
-            )) as any
-
-            expect(result.success).toBe(false)
-            expect(result.error).toContain('Team database not configured')
-        })
-    })
-})