lighthouse 12.8.2-dev.20251005 → 12.8.2-dev.20251006

package/cli/test/smokehouse/config/exclusions.js

@@ -36,8 +36,6 @@ const exclusions = {
 for (const array of Object.values(exclusions)) {
   // https://github.com/GoogleChrome/lighthouse/issues/14271
   array.push('lantern-idle-callback-short');
-  // https://github.com/GoogleChrome/lighthouse/issues/16597
-  array.push('csp-block-all');
   // glitch is gone.
   array.push('issues-mixed-content');
   // works most of the time, but since it uses a live site it can be flaky

package/core/audits/audit.js

@@ -484,7 +484,6 @@ class Audit {
 
       details: product.details,
       guidanceLevel: audit.meta.guidanceLevel,
-      replacesAudits: audit.meta.replacesAudits,
     };
   }
 

package/core/audits/insights/cls-culprits-insight.js

@@ -38,7 +38,7 @@ class CLSCulpritsInsight extends Audit {
       description: insightStr_(InsightUIStrings.description),
       guidanceLevel: 3,
       requiredArtifacts: ['Trace', 'TraceElements', 'SourceMaps'],
-      replacesAudits: ['layout-shifts', 'non-composited-animations', 'unsized-images'],
+      replacesAudits: ['layout-shifts'],
     };
   }
 

package/core/audits/insights/dom-size-insight.js

@@ -59,21 +59,21 @@ class DOMSizeInsight extends Audit {
           },
         },
         {
-          statistic: str_(UIStrings.maxChildren),
-          node: makeNodeItemForNodeId(artifacts.TraceElements, maxChildren.nodeId),
+          statistic: str_(UIStrings.maxDOMDepth),
+          node: makeNodeItemForNodeId(artifacts.TraceElements, maxDepth.nodeId),
           value: {
             type: 'numeric',
             granularity: 1,
-            value: maxChildren.numChildren,
+            value: maxDepth.depth,
           },
         },
         {
-          statistic: str_(UIStrings.maxDOMDepth),
-          node: makeNodeItemForNodeId(artifacts.TraceElements, maxDepth.nodeId),
+          statistic: str_(UIStrings.maxChildren),
+          node: makeNodeItemForNodeId(artifacts.TraceElements, maxChildren.nodeId),
           value: {
             type: 'numeric',
             granularity: 1,
-            value: maxDepth.depth,
+            value: maxChildren.numChildren,
           },
         },
       ];

package/core/audits/redirects.js

@@ -89,6 +89,7 @@ class Redirects extends Audit {
     const gatherContext = artifacts.GatherContext;
     const {URL, SourceMaps} = artifacts;
 
+    // TODO(v13): use trace processor / network tree insight.
     const processedTrace = await ProcessedTrace.request(trace, context);
     const networkRecords = await NetworkRecords.request(devtoolsLog, context);
     const documentRequests = Redirects.getDocumentRequestChain(networkRecords, processedTrace);

package/core/audits/server-response-time.d.ts

@@ -1,10 +1,5 @@
 export default ServerResponseTime;
 declare class ServerResponseTime extends Audit {
-    /**
-     * @param {LH.Artifacts.NetworkRequest} record
-     * @return {number|null}
-     */
-    static calculateResponseTime(record: LH.Artifacts.NetworkRequest): number | null;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/server-response-time.js

@@ -6,7 +6,7 @@
 
 import {Audit} from './audit.js';
 import * as i18n from '../lib/i18n/i18n.js';
-import {MainResource} from '../computed/main-resource.js';
+import {NavigationInsights} from '../computed/navigation-insights.js';
 
 const UIStrings = {
   /** Title of a diagnostic audit that provides detail on how long it took from starting a request to when the server started responding. This descriptive title is shown to users when the amount is acceptable and no user action is required. */
@@ -21,9 +21,6 @@ const UIStrings = {
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
-// Due to the way that DevTools throttling works we cannot see if server response took less than ~570ms.
-// We set our failure threshold to 600ms to avoid those false positives but we want devs to shoot for 100ms.
-const TOO_SLOW_THRESHOLD_MS = 600;
 const TARGET_MS = 100;
 
 class ServerResponseTime extends Audit {
@@ -38,41 +35,30 @@ class ServerResponseTime extends Audit {
       description: str_(UIStrings.description),
       supportedModes: ['navigation'],
       guidanceLevel: 1,
-      requiredArtifacts: ['DevtoolsLog', 'URL', 'GatherContext'],
+      requiredArtifacts: ['Trace', 'SourceMaps'],
       scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
     };
   }
 
-  /**
-   * @param {LH.Artifacts.NetworkRequest} record
-   * @return {number|null}
-   */
-  static calculateResponseTime(record) {
-    // Lightrider does not have timings for sendEnd, but we do have this timing which should be
-    // close to the response time.
-    if (global.isLightrider && record.lrStatistics) return record.lrStatistics.requestMs;
-
-    if (!record.timing) return null;
-    return record.timing.receiveHeadersStart - record.timing.sendEnd;
-  }
-
   /**
    * @param {LH.Artifacts} artifacts
    * @param {LH.Audit.Context} context
    * @return {Promise<LH.Audit.Product>}
    */
   static async audit(artifacts, context) {
-    const devtoolsLog = artifacts.DevtoolsLog;
-
-    /** @type {LH.Artifacts.NetworkRequest} */
-    const mainResource = await MainResource.request({devtoolsLog, URL: artifacts.URL}, context);
+    const settings = context.settings;
+    const trace = artifacts.Trace;
+    const SourceMaps = artifacts.SourceMaps;
+    const navInsights = await NavigationInsights.request({trace, settings, SourceMaps}, context);
+    const responseTime = navInsights.model.DocumentLatency.data?.serverResponseTime;
+    const url = navInsights.model.DocumentLatency.data?.documentRequest?.args.data.url;
 
-    const responseTime = ServerResponseTime.calculateResponseTime(mainResource);
-    if (responseTime === null) {
+    if (responseTime === undefined || !url) {
       throw new Error('no timing found for main resource');
     }
 
-    const passed = responseTime < TOO_SLOW_THRESHOLD_MS;
+    const passed =
+      Boolean(navInsights.model.DocumentLatency.data?.checklist.serverResponseIsFast.value);
     const displayValue = str_(UIStrings.displayValue, {timeInMs: responseTime});
 
     /** @type {LH.Audit.Details.Opportunity['headings']} */
@@ -84,7 +70,7 @@ class ServerResponseTime extends Audit {
     const overallSavingsMs = Math.max(responseTime - TARGET_MS, 0);
     const details = Audit.makeOpportunityDetails(
       headings,
-      [{url: mainResource.url, responseTime}],
+      [{url, responseTime}],
       {overallSavingsMs}
     );
 

package/core/computed/metrics/lcp-breakdown.js

@@ -11,6 +11,7 @@ import {ProcessedNavigation} from '../processed-navigation.js';
 import {TimeToFirstByte} from './time-to-first-byte.js';
 import {LCPImageRecord} from '../lcp-image-record.js';
 
+// TODO(v13): should use LCPBreakdown insight
 class LCPBreakdown {
   /**
    * @param {LH.Artifacts.MetricComputationDataInput} data

package/core/config/default-config.js

@@ -147,7 +147,6 @@ const defaultConfig = {
   audits: [
     'is-on-https',
     'redirects-http',
-    'viewport',
     'metrics/first-contentful-paint',
     'metrics/largest-contentful-paint',
     'metrics/first-meaningful-paint',
@@ -162,7 +161,6 @@ const defaultConfig = {
     'server-response-time',
     'metrics/interactive',
     'user-timings',
-    'critical-request-chains',
     'redirects',
     'image-aspect-ratio',
     'image-size-responsive',
@@ -170,8 +168,6 @@ const defaultConfig = {
     'third-party-cookies',
     'mainthread-work-breakdown',
     'bootup-time',
-    'uses-rel-preconnect',
-    'font-display',
     'diagnostics',
     'network-requests',
     'network-rtt',
@@ -179,15 +175,11 @@ const defaultConfig = {
     'main-thread-tasks',
     'metrics',
     'resource-summary',
-    'third-party-summary',
-    'largest-contentful-paint-element',
-    'lcp-lazy-loaded',
     'layout-shifts',
     'long-tasks',
     'non-composited-animations',
     'unsized-images',
     'valid-source-maps',
-    'prioritize-lcp-image',
     'csp-xss',
     'has-hsts',
     'origin-isolation',
@@ -267,32 +259,20 @@ const defaultConfig = {
     'accessibility/manual/offscreen-content-hidden',
     'accessibility/manual/use-landmarks',
     'accessibility/manual/visual-order-follows-dom',
-    'byte-efficiency/uses-long-cache-ttl',
     'byte-efficiency/total-byte-weight',
     'byte-efficiency/offscreen-images',
-    'byte-efficiency/render-blocking-resources',
     'byte-efficiency/unminified-css',
     'byte-efficiency/unminified-javascript',
     'byte-efficiency/unused-css-rules',
     'byte-efficiency/unused-javascript',
-    'byte-efficiency/modern-image-formats',
-    'byte-efficiency/uses-optimized-images',
-    'byte-efficiency/uses-text-compression',
-    'byte-efficiency/uses-responsive-images',
-    'byte-efficiency/efficient-animated-content',
-    'byte-efficiency/duplicated-javascript',
-    'byte-efficiency/legacy-javascript',
-    'byte-efficiency/uses-responsive-images-snapshot',
     'dobetterweb/doctype',
     'dobetterweb/charset',
-    'dobetterweb/dom-size',
     'dobetterweb/geolocation-on-start',
     'dobetterweb/inspector-issues',
     'dobetterweb/no-document-write',
     'dobetterweb/js-libraries',
     'dobetterweb/notification-on-start',
     'dobetterweb/paste-preventing-inputs',
-    'dobetterweb/uses-http2',
     'dobetterweb/uses-passive-event-listeners',
     'seo/meta-description',
     'seo/http-status-code',
@@ -303,7 +283,6 @@ const defaultConfig = {
     'seo/hreflang',
     'seo/canonical',
     'seo/manual/structured-data',
-    'work-during-interaction',
     'bf-cache',
     'insights/cache-insight',
     'insights/cls-culprits-insight',
@@ -407,67 +386,43 @@ const defaultConfig = {
         {id: 'interaction-to-next-paint', weight: 0, group: 'metrics', acronym: 'INP'},
 
         // Insight audits.
-        {id: 'cache-insight', weight: 0, group: 'hidden'},
-        {id: 'cls-culprits-insight', weight: 0, group: 'hidden'},
-        {id: 'document-latency-insight', weight: 0, group: 'hidden'},
-        {id: 'dom-size-insight', weight: 0, group: 'hidden'},
-        {id: 'duplicated-javascript-insight', weight: 0, group: 'hidden'},
-        {id: 'font-display-insight', weight: 0, group: 'hidden'},
-        {id: 'forced-reflow-insight', weight: 0, group: 'hidden'},
-        {id: 'image-delivery-insight', weight: 0, group: 'hidden'},
-        {id: 'inp-breakdown-insight', weight: 0, group: 'hidden'},
-        {id: 'lcp-breakdown-insight', weight: 0, group: 'hidden'},
-        {id: 'lcp-discovery-insight', weight: 0, group: 'hidden'},
-        {id: 'legacy-javascript-insight', weight: 0, group: 'hidden'},
-        {id: 'modern-http-insight', weight: 0, group: 'hidden'},
-        {id: 'network-dependency-tree-insight', weight: 0, group: 'hidden'},
-        {id: 'render-blocking-insight', weight: 0, group: 'hidden'},
-        {id: 'third-parties-insight', weight: 0, group: 'hidden'},
-        {id: 'viewport-insight', weight: 0, group: 'hidden'},
+        {id: 'cache-insight', weight: 0, group: 'insights'},
+        {id: 'cls-culprits-insight', weight: 0, group: 'insights'},
+        {id: 'document-latency-insight', weight: 0, group: 'insights'},
+        {id: 'dom-size-insight', weight: 0, group: 'insights'},
+        {id: 'duplicated-javascript-insight', weight: 0, group: 'insights'},
+        {id: 'font-display-insight', weight: 0, group: 'insights'},
+        {id: 'forced-reflow-insight', weight: 0, group: 'insights'},
+        {id: 'image-delivery-insight', weight: 0, group: 'insights'},
+        {id: 'inp-breakdown-insight', weight: 0, group: 'insights'},
+        {id: 'lcp-breakdown-insight', weight: 0, group: 'insights'},
+        {id: 'lcp-discovery-insight', weight: 0, group: 'insights'},
+        {id: 'legacy-javascript-insight', weight: 0, group: 'insights'},
+        {id: 'modern-http-insight', weight: 0, group: 'insights'},
+        {id: 'network-dependency-tree-insight', weight: 0, group: 'insights'},
+        {id: 'render-blocking-insight', weight: 0, group: 'insights'},
+        {id: 'third-parties-insight', weight: 0, group: 'insights'},
+        {id: 'viewport-insight', weight: 0, group: 'insights'},
 
         // These are our "invisible" metrics. Not displayed, but still in the LHR.
         {id: 'interactive', weight: 0, group: 'hidden', acronym: 'TTI'},
         {id: 'max-potential-fid', weight: 0, group: 'hidden'},
         {id: 'first-meaningful-paint', weight: 0, acronym: 'FMP', group: 'hidden'},
 
-        {id: 'render-blocking-resources', weight: 0, group: 'diagnostics'},
-        {id: 'uses-responsive-images', weight: 0, group: 'diagnostics'},
         {id: 'offscreen-images', weight: 0, group: 'diagnostics'},
         {id: 'unminified-css', weight: 0, group: 'diagnostics'},
         {id: 'unminified-javascript', weight: 0, group: 'diagnostics'},
         {id: 'unused-css-rules', weight: 0, group: 'diagnostics'},
         {id: 'unused-javascript', weight: 0, group: 'diagnostics'},
-        {id: 'uses-optimized-images', weight: 0, group: 'diagnostics'},
-        {id: 'modern-image-formats', weight: 0, group: 'diagnostics'},
-        {id: 'uses-text-compression', weight: 0, group: 'diagnostics'},
-        {id: 'uses-rel-preconnect', weight: 0, group: 'diagnostics'},
-        {id: 'server-response-time', weight: 0, group: 'diagnostics'},
-        {id: 'redirects', weight: 0, group: 'diagnostics'},
-        {id: 'uses-http2', weight: 0, group: 'diagnostics'},
-        {id: 'efficient-animated-content', weight: 0, group: 'diagnostics'},
-        {id: 'duplicated-javascript', weight: 0, group: 'diagnostics'},
-        {id: 'legacy-javascript', weight: 0, group: 'diagnostics'},
-        {id: 'prioritize-lcp-image', weight: 0, group: 'diagnostics'},
         {id: 'total-byte-weight', weight: 0, group: 'diagnostics'},
-        {id: 'uses-long-cache-ttl', weight: 0, group: 'diagnostics'},
-        {id: 'dom-size', weight: 0, group: 'diagnostics'},
-        {id: 'critical-request-chains', weight: 0, group: 'diagnostics'},
         {id: 'user-timings', weight: 0, group: 'diagnostics'},
         {id: 'bootup-time', weight: 0, group: 'diagnostics'},
         {id: 'mainthread-work-breakdown', weight: 0, group: 'diagnostics'},
-        {id: 'font-display', weight: 0, group: 'diagnostics'},
-        {id: 'third-party-summary', weight: 0, group: 'diagnostics'},
-        {id: 'largest-contentful-paint-element', weight: 0, group: 'diagnostics'},
-        {id: 'lcp-lazy-loaded', weight: 0, group: 'diagnostics'},
-        {id: 'layout-shifts', weight: 0, group: 'diagnostics'},
         {id: 'uses-passive-event-listeners', weight: 0, group: 'diagnostics'},
         {id: 'no-document-write', weight: 0, group: 'diagnostics'},
         {id: 'long-tasks', weight: 0, group: 'diagnostics'},
         {id: 'non-composited-animations', weight: 0, group: 'diagnostics'},
         {id: 'unsized-images', weight: 0, group: 'diagnostics'},
-        {id: 'viewport', weight: 0, group: 'diagnostics'},
-        {id: 'uses-responsive-images-snapshot', weight: 0, group: 'diagnostics'},
-        {id: 'work-during-interaction', weight: 0, group: 'diagnostics'},
         {id: 'bf-cache', weight: 0, group: 'diagnostics'},
 
         // Audits past this point contain useful data but are not displayed with other audits.
@@ -481,6 +436,9 @@ const defaultConfig = {
         {id: 'final-screenshot', weight: 0, group: 'hidden'},
         {id: 'script-treemap-data', weight: 0, group: 'hidden'},
         {id: 'resource-summary', weight: 0, group: 'hidden'},
+        {id: 'redirects', weight: 0, group: 'hidden'},
+        {id: 'server-response-time', weight: 0, group: 'hidden'},
+        {id: 'layout-shifts', weight: 0, group: 'hidden'},
       ],
     },
     'accessibility': {
@@ -610,7 +568,6 @@ const defaultConfig = {
         {id: 'paste-preventing-inputs', weight: 3, group: 'best-practices-ux'},
         {id: 'image-aspect-ratio', weight: 1, group: 'best-practices-ux'},
         {id: 'image-size-responsive', weight: 1, group: 'best-practices-ux'},
-        {id: 'viewport', weight: 1, group: 'best-practices-ux'},
         // Browser Compatibility
         {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'},
         {id: 'charset', weight: 1, group: 'best-practices-browser-compat'},

package/core/config/experimental-config.js

@@ -16,32 +16,7 @@ const config = {
     'autocomplete',
   ],
   categories: {
-    // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
-    // config is awkward - easier to omit the property here. Will defer to default config.
-    'performance': {
-      auditRefs: [
-        // TODO: Remove this when insights aren't hidden by default
-        // Insight audits.
-        {id: 'cache-insight', weight: 0, group: 'insights'},
-        {id: 'cls-culprits-insight', weight: 0, group: 'insights'},
-        {id: 'document-latency-insight', weight: 0, group: 'insights'},
-        {id: 'dom-size-insight', weight: 0, group: 'insights'},
-        {id: 'duplicated-javascript-insight', weight: 0, group: 'insights'},
-        {id: 'font-display-insight', weight: 0, group: 'insights'},
-        {id: 'forced-reflow-insight', weight: 0, group: 'insights'},
-        {id: 'image-delivery-insight', weight: 0, group: 'insights'},
-        {id: 'inp-breakdown-insight', weight: 0, group: 'insights'},
-        {id: 'lcp-breakdown-insight', weight: 0, group: 'insights'},
-        {id: 'lcp-discovery-insight', weight: 0, group: 'insights'},
-        {id: 'legacy-javascript-insight', weight: 0, group: 'insights'},
-        {id: 'modern-http-insight', weight: 0, group: 'insights'},
-        {id: 'network-dependency-tree-insight', weight: 0, group: 'insights'},
-        {id: 'render-blocking-insight', weight: 0, group: 'insights'},
-        {id: 'third-parties-insight', weight: 0, group: 'insights'},
-        {id: 'viewport-insight', weight: 0, group: 'insights'},
-      ],
-    },
-    // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
+    // @ts-expect-error: `title` is required in CategoryJson. setting to the same value as the default
     // config is awkward - easier to omit the property here. Will defer to default config.
     'best-practices': {
       auditRefs: [

package/core/config/filters.js

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import log from 'lighthouse-logger';
-
 import {Audit} from '../audits/audit.js';
 
 /** @type {Record<keyof LH.BaseArtifacts, string>} */
@@ -176,20 +174,19 @@ function filterCategoriesByExplicitFilters(categories, onlyCategories) {
 }
 
 /**
- * Logs a warning if any specified onlyCategory is not a known category that can
+ * Throw an error if any specified onlyCategory is not a known category that can
  * be included.
  *
  * @param {LH.Config.ResolvedConfig['categories']} allCategories
  * @param {string[] | null} onlyCategories
  * @return {void}
  */
-function warnOnUnknownOnlyCategories(allCategories, onlyCategories) {
+function errorOnUnknownOnlyCategories(allCategories, onlyCategories) {
   if (!onlyCategories) return;
 
-  for (const onlyCategoryId of onlyCategories) {
-    if (!allCategories?.[onlyCategoryId]) {
-      log.warn('config', `unrecognized category in 'onlyCategories': ${onlyCategoryId}`);
-    }
+  const unknown = onlyCategories.filter(c => !allCategories?.[c]);
+  if (unknown.length) {
+    throw new Error(`unrecognized category in 'onlyCategories': ${unknown.join(', ')}`);
   }
 }
 
@@ -271,7 +268,7 @@ function filterConfigByExplicitFilters(resolvedConfig, filters) {
     throw new Error(`onlyCategories cannot be an empty array.`);
   }
 
-  warnOnUnknownOnlyCategories(resolvedConfig.categories, onlyCategories);
+  errorOnUnknownOnlyCategories(resolvedConfig.categories, onlyCategories);
 
   let baseAuditIds = getAuditIdsInCategories(resolvedConfig.categories, undefined);
   if (onlyCategories) {

package/core/config/lr-desktop-config.js

@@ -18,7 +18,6 @@ const config = {
     emulatedUserAgent: constants.userAgents.desktop,
     skipAudits: [
       // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
-      'uses-http2',
       'modern-http-insight',
       // There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
       'bf-cache',

package/core/config/lr-mobile-config.js

@@ -17,7 +17,6 @@ const config = {
     },
     skipAudits: [
       // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
-      'uses-http2',
       'modern-http-insight',
       // There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
       'bf-cache',

package/core/gather/gatherers/trace-elements.js

@@ -378,6 +378,7 @@ class TraceElements extends BaseGatherer {
     const animatedElementData = await this.getAnimatedElements(mainThreadEvents);
     const responsivenessElementData = await TraceElements.getResponsivenessElement(trace, context);
 
+    // TODO(v13): remove unnecessary entries.
     /** @type {Map<string, TraceElementData[]>} */
     const backendNodeDataMap = new Map([
       ['trace-engine', traceEngineData],

package/core/lib/proto-preprocessor.js

@@ -22,29 +22,12 @@ function processForProto(lhr) {
   /** @type {LH.Result} */
   const reportJson = JSON.parse(JSON.stringify(lhr));
 
-  // Clean up the configSettings
-  // Note: This is not strictly required for conversion if protobuf parsing is set to
-  // 'ignore unknown fields' in the language of conversion.
+  // Drop these fields as we've omitted them from the proto for simplicity
   if (reportJson.configSettings) {
-    // The settings that are in both proto and LHR
-    const {
-      formFactor,
-      locale,
-      onlyCategories,
-      channel,
-      throttling,
-      screenEmulation,
-      throttlingMethod} = reportJson.configSettings;
-
-    // @ts-expect-error - intentionally only a subset of settings.
-    reportJson.configSettings = {
-      formFactor,
-      locale,
-      onlyCategories,
-      channel,
-      throttling,
-      screenEmulation,
-      throttlingMethod};
+    // @ts-expect-error Removing non-optional field.
+    delete reportJson.configSettings.auditMode;
+    // @ts-expect-error Removing non-optional field.
+    delete reportJson.configSettings.gatherMode;
   }
 
   // Remove runtimeError if it is NO_ERROR