lighthouse 12.6.1 → 12.7.0-dev.20250628

package/eslint.config.mjs

@@ -0,0 +1,242 @@
+import path from 'node:path';
+import {fileURLToPath} from 'node:url';
+
+import localRules from 'eslint-plugin-local-rules';
+import _import from 'eslint-plugin-import';
+import {fixupPluginRules} from '@eslint/compat';
+import globals from 'globals';
+import tsParser from '@typescript-eslint/parser';
+import js from '@eslint/js';
+import {FlatCompat} from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+// See https://eslint.org/docs/latest/use/configure/configuration-files
+export default [{
+  files: [
+    '**/*.cjs',
+    '**/*.js',
+    '**/*.mjs',
+    '**/*.ts',
+    '**/*.tsx',
+  ],
+}, {
+  // Global ignores.
+  ignores: [
+    '.cz-config.js',
+    '**/.tmp',
+    '**/*.d.cts', // ignore d.ts files until we can properly lint them
+    '**/*.d.ts',
+    '**/dist',
+    '**/fixtures/**',
+    '**/node_modules/**',
+    '**/source-maps/**',
+    '**/third_party/**',
+    '**/third-party/**',
+    'build/test/page-functions-test-case*out*.js',
+    'core/scripts/legacy-javascript/variants/**',
+    'coverage/**',
+  ],
+}, ...compat.extends('eslint:recommended', 'google'), {
+  plugins: {
+    'local-rules': localRules,
+    'import': fixupPluginRules(_import),
+  },
+
+  languageOptions: {
+    globals: {
+      ...globals.node,
+    },
+
+    parser: tsParser,
+    ecmaVersion: 2020,
+    sourceType: 'module',
+
+    parserOptions: {
+      ecmaFeatures: {
+        globalReturn: true,
+        jsx: false,
+      },
+    },
+  },
+
+  rules: {
+    'import/order': [2, {
+      'groups': ['builtin', 'external', ['sibling', 'parent'], 'index', 'object', 'type'],
+      'newlines-between': 'always',
+    }],
+
+    'import/group-exports': 2,
+    'import/exports-last': 2,
+    'eqeqeq': 2,
+    'no-console': 2,
+
+    'indent': [2, 2, {
+      SwitchCase: 1,
+      VariableDeclarator: 2,
+
+      CallExpression: {
+        arguments: 'off',
+      },
+
+      MemberExpression: 'off',
+
+      FunctionExpression: {
+        body: 1,
+        parameters: 2,
+      },
+
+      ignoredNodes: [
+        'ConditionalExpression > :matches(.consequent, .alternate)',
+        'VariableDeclarator > ArrowFunctionExpression > :expression.body',
+        'CallExpression > ArrowFunctionExpression > :expression.body',
+      ],
+    }],
+
+    'no-floating-decimal': 2,
+
+    'max-len': [2, 100, {
+      ignorePattern: 'readJson\\(|^import ',
+      ignoreComments: true,
+      ignoreUrls: true,
+      tabWidth: 2,
+    }],
+
+    'no-empty': [2, {
+      allowEmptyCatch: true,
+    }],
+
+    'no-implicit-coercion': [2, {
+      boolean: false,
+      number: true,
+      string: true,
+    }],
+
+    'no-unused-expressions': [2, {
+      allowShortCircuit: true,
+      allowTernary: false,
+    }],
+
+    'no-unused-vars': [2, {
+      vars: 'all',
+      args: 'after-used',
+      caughtErrors: 'none', // TODO: remove for new "all" default.
+      argsIgnorePattern: '(^reject$|^_+$)',
+      varsIgnorePattern: '(^_$|^LH$|^Lantern$|^TraceEngine$|^Protocol$)',
+    }],
+
+    'no-cond-assign': 2,
+    'space-infix-ops': 2,
+    'strict': [2, 'global'],
+    'prefer-const': 2,
+    'curly': [2, 'multi-line'],
+
+    'comma-dangle': [2, {
+      arrays: 'always-multiline',
+      objects: 'always-multiline',
+      imports: 'always-multiline',
+      exports: 'always-multiline',
+      functions: 'never',
+    }],
+
+    'operator-linebreak': ['error', 'after', {
+      overrides: {
+        '?': 'ignore',
+        ':': 'ignore',
+      },
+    }],
+
+    'local-rules/require-file-extension': 2,
+    'require-jsdoc': 0,
+    'valid-jsdoc': 0,
+    'arrow-parens': 0,
+  },
+}, {
+  files: ['cli/test/smokehouse/test-definitions/**'],
+
+  rules: {
+    'max-len': 0,
+  },
+}, {
+  files: [
+    '**/build/**',
+    '**/scripts/**',
+    '**/test/**',
+  ],
+
+  rules: {
+    'no-console': 0,
+  },
+}, {
+  files: [
+    'docs/recipes/auth/**',
+  ],
+
+  rules: {
+    'new-cap': 0,
+    'no-console': 0,
+    'no-unused-vars': 0,
+  },
+}, {
+  files: [
+    '**/test/**',
+    'docs/recipes/**',
+  ],
+
+  languageOptions: {
+    globals: {
+      ...globals.jest,
+      ...globals.mocha,
+    },
+  },
+}, {
+  files: [
+    'clients/**',
+    'core/gather/gatherers/**',
+    'docs/recipes/auth/**',
+    'flow-report/**',
+    'report/**',
+    'treemap/**',
+    'viewer/**',
+  ],
+  ignores: [
+    'report/generator/**',
+    'report/test/generator/**',
+  ],
+
+  languageOptions: {
+    globals: {
+      ...globals.browser,
+    },
+  },
+}, {
+  files: [
+    'clients/**',
+  ],
+
+  languageOptions: {
+    globals: {
+      chrome: true,
+      __lighthouse: true,
+    },
+  },
+}, {
+  files: ['flow-report/**'],
+
+  languageOptions: {
+    globals: {
+      ...globals.browser,
+      ...globals.node,
+    },
+  },
+
+  rules: {
+    'no-undef': 'off',
+  },
+}];

package/flow-report/src/common.tsx

@@ -88,6 +88,7 @@ const FlowStepThumbnail: FunctionComponent<{
   }
 
   if (!width || !height) {
+    // eslint-disable-next-line no-console
     console.warn(new Error('FlowStepThumbnail requested without any dimensions').stack);
     return <></>;
   }

package/flow-report/src/i18n/i18n.tsx

@@ -26,6 +26,7 @@ function useLhrLocale() {
   const locale = firstLhr.configSettings.locale;
 
   if (flowResult.steps.some(step => step.lhr.configSettings.locale !== locale)) {
+    // eslint-disable-next-line no-console
     console.warn('LHRs have inconsistent locales');
   }
 

package/flow-report/src/util.ts

@@ -97,12 +97,14 @@ function useHashState(): LH.HashState|null {
 
     const index = Number(indexString);
     if (!Number.isFinite(index)) {
+      // eslint-disable-next-line no-console
       console.warn(`Invalid hash index: ${indexString}`);
       return null;
     }
 
     const step = flowResult.steps[index];
     if (!step) {
+      // eslint-disable-next-line no-console
       console.warn(`No flow step at index ${index}`);
       return null;
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "12.6.1",
+  "version": "12.7.0-dev.20250628",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -105,16 +105,19 @@
     "@build-tracker/cli": "^1.0.0-beta.15",
     "@esbuild-kit/esm-loader": "^2.1.1",
     "@esbuild-plugins/node-modules-polyfill": "^0.1.4",
+    "@eslint/compat": "^1.3.0",
+    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/js": "^9.28.0",
     "@formatjs/icu-messageformat-parser": "^2.6.2",
-    "@jest/fake-timers": "^28.1.0",
+    "@jest/fake-timers": "^29.7.0",
     "@testing-library/preact": "^3.1.1",
     "@testing-library/preact-hooks": "^1.1.0",
     "@types/archiver": "^2.1.2",
     "@types/chrome": "^0.0.154",
-    "@types/configstore": "^4.0.0",
+    "@types/configstore": "^6.0.2",
     "@types/cpy": "^5.1.0",
     "@types/debug": "^4.1.7",
-    "@types/eslint": "^8.2.1",
+    "@types/eslint": "^9.6.1",
     "@types/estree": "^0.0.50",
     "@types/gh-pages": "^2.0.0",
     "@types/google.analytics": "0.0.39",
@@ -131,15 +134,15 @@
     "@types/ws": "^7.0.0",
     "@types/yargs": "^17.0.8",
     "@types/yargs-parser": "^20.2.1",
-    "@typescript-eslint/eslint-plugin": "^5.48.0",
-    "@typescript-eslint/parser": "^5.48.0",
+    "@typescript-eslint/eslint-plugin": "^8.34.0",
+    "@typescript-eslint/parser": "^8.34.0",
     "acorn": "^8.5.0",
     "angular": "^1.7.4",
     "archiver": "^3.0.0",
     "builtin-modules": "^3.3.0",
     "c8": "^7.11.3",
     "chalk": "^2.4.1",
-    "chrome-devtools-frontend": "1.0.1445635",
+    "chrome-devtools-frontend": "1.0.1473514",
     "colors": "^1.4.0",
     "concurrently": "^6.4.0",
     "conventional-changelog-cli": "^2.1.1",
@@ -149,7 +152,7 @@
     "csv-validator": "^0.0.3",
     "es-main": "^1.2.0",
     "esbuild": "0.19.11",
-    "eslint": "^8.4.1",
+    "eslint": "^9.28.0",
     "eslint-config-google": "^0.14.0",
     "eslint-formatter-codeframe": "^7.32.1",
     "eslint-plugin-import": "^2.25.3",
@@ -159,9 +162,10 @@
     "firebase": "^9.0.2",
     "gh-pages": "^2.0.1",
     "glob": "^7.1.3",
+    "globals": "^15.14.0",
     "idb-keyval": "2.2.0",
-    "jest-mock": "^27.3.0",
-    "jest-snapshot": "^28.1.0",
+    "jest-mock": "^29.7.0",
+    "jest-snapshot": "^29.7.0",
     "jsdom": "^12.2.0",
     "lighthouse-plugin-soft-navigation": "^1.0.1",
     "magic-string": "^0.25.7",
@@ -172,7 +176,7 @@
     "pako": "^2.0.3",
     "preact": "^10.7.2",
     "pretty-json-stringify": "^0.0.2",
-    "puppeteer": "^24.10.0",
+    "puppeteer": "^24.10.2",
     "resolve": "^1.22.1",
     "rollup": "^2.52.7",
     "rollup-plugin-polyfill-node": "^0.12.0",
@@ -185,13 +189,13 @@
     "webtreemap-cdt": "^3.2.1"
   },
   "dependencies": {
-    "@paulirish/trace_engine": "0.0.53",
-    "@sentry/node": "^7.0.0",
+    "@paulirish/trace_engine": "0.0.56",
+    "@sentry/node": "^9.28.1",
     "axe-core": "^4.10.3",
     "chrome-launcher": "^1.2.0",
-    "configstore": "^5.0.1",
+    "configstore": "^7.0.0",
     "csp_evaluator": "1.1.5",
-    "devtools-protocol": "0.0.1467305",
+    "devtools-protocol": "0.0.1478340",
     "enquirer": "^2.3.6",
     "http-link-header": "^1.1.1",
     "intl-messageformat": "^10.5.3",
@@ -204,19 +208,19 @@
     "metaviewport-parser": "0.3.0",
     "open": "^8.4.0",
     "parse-cache-control": "1.0.1",
-    "puppeteer-core": "^24.10.0",
+    "puppeteer-core": "^24.10.2",
     "robots-parser": "^3.0.1",
     "semver": "^5.3.0",
     "speedline-core": "^1.4.3",
-    "third-party-web": "^0.26.6",
+    "third-party-web": "^0.27.0",
     "tldts-icann": "^6.1.16",
     "ws": "^7.0.0",
     "yargs": "^17.3.1",
     "yargs-parser": "^21.0.0"
   },
   "resolutions": {
-    "puppeteer/**/devtools-protocol": "0.0.1467305",
-    "puppeteer-core/**/devtools-protocol": "0.0.1467305"
+    "puppeteer/**/devtools-protocol": "0.0.1478340",
+    "puppeteer-core/**/devtools-protocol": "0.0.1478340"
   },
   "repository": "GoogleChrome/lighthouse",
   "keywords": [

package/readme.md

@@ -52,7 +52,7 @@ The Chrome extension was available prior to Lighthouse being available in Chrome
 
 The Node CLI provides the most flexibility in how Lighthouse runs can be configured and reported. Users who want more advanced usage, or want to run Lighthouse in an automated fashion should use the Node CLI.
 
-> **Note**
+> [!NOTE]
 > Lighthouse requires Node 18.20 or later.
 
 **Installation**:
@@ -227,7 +227,8 @@ top of any Lighthouse HTML report and open the report in the
 In the Viewer, reports can be shared by clicking the share icon in the top
 right corner and signing in to GitHub.
 
-> **Note**: shared reports are stashed as a secret Gist in GitHub, under your account.
+> [!NOTE]
+>  shared reports are stashed as a secret Gist in GitHub, under your account.
 
 ## Docs & Recipes
 

package/report/assets/styles.css

@@ -353,14 +353,6 @@
   color: var(--report-text-color);
 }
 
-.lh-root :focus-visible {
-    outline: -webkit-focus-ring-color auto 3px;
-}
-.lh-root summary:focus {
-    outline: none;
-    box-shadow: 0 0 0 1px hsl(217, 89%, 61%);
-}
-
 .lh-root [hidden] {
   display: none !important;
 }
@@ -415,7 +407,7 @@
   color: var(--link-color);
 }
 
-.lh-audit__description, .lh-audit__stackpack {
+.lh-audit__description, .lh-audit__stackpack, .lh-list-section__description {
   --inner-audit-padding-right: var(--stackpack-padding-horizontal);
   padding-left: var(--audit-description-padding-left);
   padding-right: var(--inner-audit-padding-right);
@@ -1132,6 +1124,12 @@
   margin-bottom: calc(var(--default-padding) * 2);
   border-bottom: 1px solid #A8C7FA;
 }
+.lh-list-section {
+  padding: calc(var(--default-padding) * 2) 0;
+}
+.lh-list-section__title {
+  text-decoration: underline;
+}
 
 .lh-header-container {
   display: block;
@@ -1574,6 +1572,10 @@
   .lh-categories {
     margin-top: 0;
   }
+  .lh-buttons, .lh-highlighter {
+    /* hide stickyheader marker when printing. crbug.com/41486992 */
+    display: none;
+  }
 }
 
 .lh-table {

package/report/assets/templates.html

@@ -293,7 +293,7 @@ SPDX-License-Identifier: Apache-2.0
     }
     .lh-tool-locale__button.lh-active + .lh-tools-locale__selector-wrapper {
       opacity: 1;
-      clip: rect(-1px, 194px, 242px, -3px);
+      clip: rect(-1px, 255px, 242px, -3px);
       visibility: visible;
       margin: 0 4px;
     }

package/report/generator/file-namer.d.ts

@@ -7,6 +7,11 @@ export function getLhrFilenamePrefix(lhr: {
     finalDisplayedUrl: string;
     fetchTime: string;
 }): string;
+/**
+ * @license
+ * Copyright 2017 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
 /**
  * @fileoverview
  * @suppress {reportUnknownTypes}

package/report/generator/file-namer.js

@@ -3,7 +3,7 @@
  * Copyright 2017 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 /**
  * @fileoverview

package/report/generator/flow-report-assets.js

@@ -3,7 +3,7 @@
  * Copyright 2021 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 import fs from 'fs';
 

package/report/generator/report-assets.js

@@ -3,7 +3,7 @@
  * Copyright 2018 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 import fs from 'fs';
 

package/report/generator/report-generator.js

@@ -3,7 +3,7 @@
  * Copyright 2017 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
-'use strict';
+
 
 import {reportAssets} from './report-assets.js';
 
@@ -69,11 +69,11 @@ class ReportGenerator {
     // we want to generate a report without minification.
     const sanitizedJavascript = reportAssets.FLOW_REPORT_JAVASCRIPT.replace(/<\//g, '\\u003c/');
     return ReportGenerator.replaceStrings(reportAssets.FLOW_REPORT_TEMPLATE, [
-      /* eslint-disable max-len */
+
       {search: '%%LIGHTHOUSE_FLOW_JSON%%', replacement: sanitizedJson},
       {search: '%%LIGHTHOUSE_FLOW_JAVASCRIPT%%', replacement: sanitizedJavascript},
       {search: '/*%%LIGHTHOUSE_FLOW_CSS%%*/', replacement: reportAssets.FLOW_REPORT_CSS},
-      /* eslint-enable max-len */
+
     ]);
   }
 

package/report/renderer/api.js

@@ -21,6 +21,7 @@ function renderReport(lhr, opts = {}) {
 
   const dom = new DOM(rootEl.ownerDocument, rootEl);
   const renderer = new ReportRenderer(dom);
+  if (opts._onSwapHook) dom._onSwapHook = opts._onSwapHook;
 
   renderer.renderReport(lhr, rootEl, opts);