isaacscript-common 76.2.0 → 77.0.0

package/src/classes/features/other/ModdedElementSets.ts

@@ -26,6 +26,7 @@ import {
 } from "../../../core/constantsVanilla";
 import { Exported } from "../../../decorators";
 import { ISCFeature } from "../../../enums/ISCFeature";
+import { arrayRemove, getRandomArrayElement } from "../../../functions/array";
 import { getItemConfigCardType } from "../../../functions/cards";
 import { collectibleHasTag } from "../../../functions/collectibleTag";
 import {
@@ -36,12 +37,7 @@ import {
   isPassiveOrFamiliarCollectible,
 } from "../../../functions/collectibles";
 import { getFlagName } from "../../../functions/flag";
-import {
-  copySet,
-  deleteSetsFromSet,
-  getRandomSetElement,
-  getSortedSetValues,
-} from "../../../functions/set";
+import { getRandomSetElement } from "../../../functions/set";
 import { trinketHasCacheFlag } from "../../../functions/trinkets";
 import {
   asCardType,
@@ -50,9 +46,9 @@ import {
   asTrinketType,
 } from "../../../functions/types";
 import { assertDefined, iRange, repeat } from "../../../functions/utils";
-import { ITEM_CONFIG_CARD_TYPES_FOR_CARDS_SET } from "../../../sets/itemConfigCardTypesForCardsSet";
+import { ITEM_CONFIG_CARD_TYPES_FOR_CARDS } from "../../../sets/itemConfigCardTypesForCards";
 import { ReadonlyMap } from "../../../types/ReadonlyMap";
-import { ReadonlySet } from "../../../types/ReadonlySet";
+import type { ReadonlySet } from "../../../types/ReadonlySet";
 import { Feature } from "../../private/Feature";
 import type { ModdedElementDetection } from "./ModdedElementDetection";
 
@@ -125,23 +121,22 @@ export class ModdedElementSets extends Feature {
 
   private readonly cacheFlagToCollectibleTypesMap = new Map<
     CacheFlag,
-    Set<CollectibleType>
+    readonly CollectibleType[]
   >();
 
   private readonly cacheFlagToTrinketTypesMap = new Map<
     CacheFlag,
-    Set<TrinketType>
+    readonly TrinketType[]
   >();
 
-  private flyingCollectibleTypesSet = new Set<CollectibleType>();
-  private readonly permanentFlyingCollectibleTypesSet =
-    new Set<CollectibleType>();
+  private flyingCollectibleTypes: CollectibleType[] = [];
+  private permanentFlyingCollectibleTypes: CollectibleType[] = [];
 
-  private flyingTrinketTypesSet = new Set<TrinketType>();
+  private flyingTrinketTypes: TrinketType[] = [];
 
   private readonly tagToCollectibleTypesMap = new Map<
     ItemConfigTag,
-    Set<CollectibleType>
+    CollectibleType[]
   >();
 
   private readonly edenActiveCollectibleTypesSet = new Set<CollectibleType>();
@@ -149,21 +144,21 @@ export class ModdedElementSets extends Feature {
 
   private readonly qualityToCollectibleTypesMap = new Map<
     Quality,
-    Set<CollectibleType>
+    readonly CollectibleType[]
   >();
 
   private readonly itemConfigCardTypeToCardTypeMap = new Map<
     ItemConfigCardType,
-    Set<CardType>
+    CardType[]
   >();
 
   /**
-   * The set of card types that are not:
+   * The array of card types that are not:
    *
    * - ItemConfigCardType.RUNE
    * - ItemConfigCardType.SPECIAL_OBJECT
    */
-  private readonly cardSet = new Set<CardType>();
+  private readonly cardTypeCardArray: CardType[] = [];
 
   private readonly moddedElementDetection: ModdedElementDetection;
 
@@ -318,9 +313,9 @@ export class ModdedElementSets extends Feature {
 
   private lazyInitTagToCollectibleTypesMap() {
     // The tag to collectible types map should be valid for every tag, so we initialize it with
-    // empty sets.
+    // empty arrays.
     for (const itemConfigTag of ITEM_CONFIG_TAG_VALUES) {
-      this.tagToCollectibleTypesMap.set(itemConfigTag, new Set());
+      this.tagToCollectibleTypesMap.set(itemConfigTag, [] as CollectibleType[]);
     }
 
     for (const collectibleType of this.getCollectibleTypes()) {
@@ -329,92 +324,88 @@ export class ModdedElementSets extends Feature {
           continue;
         }
 
-        const collectibleTypesSet =
+        const collectibleTypes =
           this.tagToCollectibleTypesMap.get(itemConfigTag);
-        if (collectibleTypesSet === undefined) {
+        if (collectibleTypes === undefined) {
           const flagName = getFlagName(itemConfigTag, ItemConfigTag);
           error(
             `Failed to get the collectible types for item tag: ${flagName}`,
           );
         }
-        collectibleTypesSet.add(collectibleType);
+        collectibleTypes.push(collectibleType);
       }
     }
   }
 
   private lazyInitCacheFlagToCollectibleTypesMap() {
     for (const cacheFlag of CACHE_FLAG_VALUES) {
-      const collectibleTypeSet = new Set<CollectibleType>();
+      const collectibleTypes: CollectibleType[] = [];
 
       for (const collectibleType of this.getCollectibleTypes()) {
         if (collectibleHasCacheFlag(collectibleType, cacheFlag)) {
-          collectibleTypeSet.add(collectibleType);
+          collectibleTypes.push(collectibleType);
         }
       }
 
-      this.cacheFlagToCollectibleTypesMap.set(cacheFlag, collectibleTypeSet);
+      this.cacheFlagToCollectibleTypesMap.set(cacheFlag, collectibleTypes);
     }
   }
 
   private lazyInitCacheFlagToTrinketTypesMap() {
     for (const cacheFlag of CACHE_FLAG_VALUES) {
-      const trinketTypesSet = new Set<TrinketType>();
+      const trinketTypes: TrinketType[] = [];
 
       for (const trinketType of this.getTrinketTypes()) {
         if (trinketHasCacheFlag(trinketType, cacheFlag)) {
-          trinketTypesSet.add(trinketType);
+          trinketTypes.push(trinketType);
         }
       }
 
-      this.cacheFlagToTrinketTypesMap.set(cacheFlag, trinketTypesSet);
+      this.cacheFlagToTrinketTypesMap.set(cacheFlag, trinketTypes);
     }
   }
 
   private lazyInitFlyingCollectibleTypesSet() {
     // Instead of manually compiling a list of collectibles that grant flying, we can instead
-    // dynamically look for collectibles that have `CacheFlag.FLYING`.
-    this.flyingCollectibleTypesSet = copySet(
-      this.getCollectibleTypesWithCacheFlag(CacheFlag.FLYING),
-    );
-
-    // None of the collectibles with a cache of "all" grant flying (including all of the 3 Dollar
-    // Bill collectibles and all of the Birthright effects), so we can safely remove them from the
-    // list.
-    const collectiblesWithAllCacheFlag = this.getCollectibleTypesWithCacheFlag(
-      CacheFlag.ALL,
-    );
-    deleteSetsFromSet(
-      this.flyingCollectibleTypesSet,
-      collectiblesWithAllCacheFlag,
+    // dynamically look for collectibles that have `CacheFlag.FLYING`. But none of the collectibles
+    // with a cache of "all" grant flying (including all of the 3 Dollar Bill collectibles and all
+    // of the Birthright effects), so we can safely remove them from the list.
+    const collectibleTypesWithFlyingCacheFlag =
+      this.getCollectibleTypesWithCacheFlag(CacheFlag.FLYING);
+    const collectibleTypesWithAllCacheFlag =
+      this.getCollectibleTypesWithCacheFlag(CacheFlag.ALL);
+    this.flyingCollectibleTypes = arrayRemove(
+      collectibleTypesWithFlyingCacheFlag,
+      ...collectibleTypesWithAllCacheFlag,
     );
 
     // Additionally, create a second set that represents the collectible types that grant flying
     // non-conditionally.
-    const permanentFlyingCollectibleTypes = copySet(
-      this.flyingCollectibleTypesSet,
+    this.permanentFlyingCollectibleTypes = arrayRemove(
+      this.flyingCollectibleTypes,
+      ...CONDITIONAL_FLYING_COLLECTIBLE_TYPES,
     );
-    for (const collectibleType of CONDITIONAL_FLYING_COLLECTIBLE_TYPES) {
-      permanentFlyingCollectibleTypes.delete(collectibleType);
-    }
-    for (const collectibleType of permanentFlyingCollectibleTypes) {
-      this.permanentFlyingCollectibleTypesSet.add(collectibleType);
-    }
   }
 
   private lazyInitFlyingTrinketTypesSet() {
     // Instead of manually compiling a list of trinkets that grant flying, we can instead
-    // dynamically look for collectibles that have `CacheFlag.FLYING`.
-    this.flyingTrinketTypesSet = copySet(
-      this.getTrinketsTypesWithCacheFlag(CacheFlag.FLYING),
+    // dynamically look for collectibles that have `CacheFlag.FLYING`. But none of the trinkets with
+    // `CacheFlag.ALL` grant flying except for Azazel's Stump, so we can safely remove them from the
+    // list.
+    const trinketTypesWithFlyingCacheFlag = this.getTrinketsTypesWithCacheFlag(
+      CacheFlag.FLYING,
     );
-
-    // None of the trinkets with `CacheFlag.ALL` grant flying except for Azazel's Stump, so we can
-    // safely remove them from the list.
-    const trinketsWithAllCacheFlag = copySet(
-      this.getTrinketsTypesWithCacheFlag(CacheFlag.ALL),
+    const trinketTypesWithAllCacheFlag = this.getTrinketsTypesWithCacheFlag(
+      CacheFlag.ALL,
+    );
+    const trinketTypesWithAllCacheFlagThatDontGrantFlying = arrayRemove(
+      trinketTypesWithAllCacheFlag,
+      TrinketType.AZAZELS_STUMP,
+    );
+    this.flyingTrinketTypes = arrayRemove(
+      trinketTypesWithFlyingCacheFlag,
+      ...trinketTypesWithAllCacheFlagThatDontGrantFlying,
     );
-    trinketsWithAllCacheFlag.delete(TrinketType.AZAZELS_STUMP);
-    deleteSetsFromSet(this.flyingTrinketTypesSet, trinketsWithAllCacheFlag);
   }
 
   private lazyInitEdenCollectibleTypesSet() {
@@ -438,43 +429,43 @@ export class ModdedElementSets extends Feature {
 
   private lazyInitQualityToCollectibleTypesMap() {
     for (const quality of QUALITIES) {
-      const collectibleTypesSet = new Set<CollectibleType>();
+      const collectibleTypes: CollectibleType[] = [];
 
       for (const collectibleType of this.getCollectibleTypes()) {
         const collectibleTypeQuality = getCollectibleQuality(collectibleType);
         if (collectibleTypeQuality === quality) {
-          collectibleTypesSet.add(collectibleType);
+          collectibleTypes.push(collectibleType);
         }
       }
 
-      this.qualityToCollectibleTypesMap.set(quality, collectibleTypesSet);
+      this.qualityToCollectibleTypesMap.set(quality, collectibleTypes);
     }
   }
 
   private lazyInitCardTypes() {
     // The card type to cards map should be valid for every card type, so we initialize it with
-    // empty sets.
+    // empty arrays.
     for (const itemConfigCardType of ITEM_CONFIG_CARD_TYPE_VALUES) {
       this.itemConfigCardTypeToCardTypeMap.set(
         itemConfigCardType,
-        new Set<CardType>(),
+        [] as CardType[],
       );
     }
 
     for (const cardType of this.getCardTypes()) {
       const itemConfigCardType = getItemConfigCardType(cardType);
       if (itemConfigCardType !== undefined) {
-        const cardTypeSet =
+        const cardTypes =
           this.itemConfigCardTypeToCardTypeMap.get(itemConfigCardType);
         assertDefined(
-          cardTypeSet,
-          `Failed to get the card set for item config card type: ${itemConfigCardType}`,
+          cardTypes,
+          `Failed to get the card types for item config card type: ${itemConfigCardType}`,
         );
 
-        cardTypeSet.add(cardType);
+        cardTypes.push(cardType);
 
-        if (ITEM_CONFIG_CARD_TYPES_FOR_CARDS_SET.has(itemConfigCardType)) {
-          this.cardSet.add(cardType);
+        if (ITEM_CONFIG_CARD_TYPES_FOR_CARDS.has(itemConfigCardType)) {
+          this.cardTypeCardArray.push(cardType);
         }
       }
     }
@@ -496,6 +487,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCollectibleTypes(): readonly CollectibleType[] {
@@ -515,6 +508,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCollectibleTypeSet(): ReadonlySet<CollectibleType> {
@@ -533,6 +528,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedCollectibleTypes(): readonly CollectibleType[] {
@@ -551,6 +548,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedCollectibleTypesSet(): ReadonlySet<CollectibleType> {
@@ -569,6 +568,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPlayerCollectibleMap(
@@ -624,6 +625,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getTrinketTypes(): readonly TrinketType[] {
@@ -642,6 +645,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getTrinketTypesSet(): ReadonlySet<TrinketType> {
@@ -660,6 +665,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedTrinketTypes(): readonly TrinketType[] {
@@ -678,6 +685,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedTrinketTypesSet(): ReadonlySet<TrinketType> {
@@ -699,6 +708,8 @@ export class ModdedElementSets extends Feature {
    * not all card types will necessarily be present when a mod first loads (due to mod load order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCardTypes(): readonly CardType[] {
@@ -716,6 +727,8 @@ export class ModdedElementSets extends Feature {
    * not all card types will necessarily be present when a mod first loads (due to mod load order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCardTypesSet(): ReadonlySet<CardType> {
@@ -733,6 +746,8 @@ export class ModdedElementSets extends Feature {
    * not all card types will necessarily be present when a mod first loads (due to mod load order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedCardTypes(): readonly CardType[] {
@@ -750,6 +765,8 @@ export class ModdedElementSets extends Feature {
    * not all card types will necessarily be present when a mod first loads (due to mod load order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedCardTypesSet(): ReadonlySet<CardType> {
@@ -772,6 +789,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPillEffects(): readonly PillEffect[] {
@@ -790,6 +809,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPillEffectsSet(): ReadonlySet<PillEffect> {
@@ -808,6 +829,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedPillEffects(): readonly PillEffect[] {
@@ -826,6 +849,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getModdedPillEffectsSet(): ReadonlySet<PillEffect> {
@@ -846,16 +871,18 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCollectibleTypesWithCacheFlag(
     cacheFlag: CacheFlag,
-  ): ReadonlySet<CollectibleType> {
+  ): readonly CollectibleType[] {
     this.lazyInit();
 
     const collectiblesSet = this.cacheFlagToCollectibleTypesMap.get(cacheFlag);
     if (collectiblesSet === undefined) {
-      return new ReadonlySet();
+      return [];
     }
 
     return collectiblesSet;
@@ -870,19 +897,21 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getTrinketsTypesWithCacheFlag(
     cacheFlag: CacheFlag,
-  ): ReadonlySet<TrinketType> {
+  ): readonly TrinketType[] {
     this.lazyInit();
 
-    const trinketsSet = this.cacheFlagToTrinketTypesMap.get(cacheFlag);
-    if (trinketsSet === undefined) {
-      return new ReadonlySet();
+    const trinketTypes = this.cacheFlagToTrinketTypesMap.get(cacheFlag);
+    if (trinketTypes === undefined) {
+      return [];
     }
 
-    return trinketsSet;
+    return trinketTypes;
   }
 
   /**
@@ -908,19 +937,19 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPlayerCollectiblesWithCacheFlag(
     player: EntityPlayer,
     cacheFlag: CacheFlag,
-  ): CollectibleType[] {
+  ): readonly CollectibleType[] {
     const collectiblesWithCacheFlag =
       this.getCollectibleTypesWithCacheFlag(cacheFlag);
 
     const playerCollectibles: CollectibleType[] = [];
-    for (const collectibleType of getSortedSetValues(
-      collectiblesWithCacheFlag,
-    )) {
+    for (const collectibleType of collectiblesWithCacheFlag) {
       // We specify "true" as the second argument to filter out things like Lilith's Incubus.
       const numCollectibles = player.GetCollectibleNum(collectibleType, true);
       repeat(numCollectibles, () => {
@@ -940,6 +969,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPlayerTrinketsWithCacheFlag(
@@ -980,16 +1011,17 @@ export class ModdedElementSets extends Feature {
    *
    * @param includeConditionalItems Whether collectibles that only grant flight conditionally should
    *                                be included in the set (like Empty Vessel).
+   * @public
    */
   @Exported
   public getFlyingCollectibleTypes(
     includeConditionalItems: boolean,
-  ): ReadonlySet<CollectibleType> {
+  ): readonly CollectibleType[] {
     this.lazyInit();
 
     return includeConditionalItems
-      ? this.flyingCollectibleTypesSet
-      : this.permanentFlyingCollectibleTypesSet;
+      ? this.flyingCollectibleTypes
+      : this.permanentFlyingCollectibleTypes;
   }
 
   /**
@@ -1005,11 +1037,13 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
-  public getFlyingTrinketTypes(): ReadonlySet<TrinketType> {
+  public getFlyingTrinketTypes(): readonly TrinketType[] {
     this.lazyInit();
-    return this.flyingTrinketTypesSet;
+    return this.flyingTrinketTypes;
   }
 
   // ----------------
@@ -1031,11 +1065,13 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCollectibleTypesWithTag(
     itemConfigTag: ItemConfigTag,
-  ): ReadonlySet<CollectibleType> {
+  ): readonly CollectibleType[] {
     this.lazyInit();
 
     const collectibleTypes = this.tagToCollectibleTypesMap.get(itemConfigTag);
@@ -1055,17 +1091,19 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPlayerCollectiblesWithTag(
     player: EntityPlayer,
     itemConfigTag: ItemConfigTag,
-  ): CollectibleType[] {
+  ): readonly CollectibleType[] {
     const collectibleTypesWithTag =
       this.getCollectibleTypesWithTag(itemConfigTag);
 
     const playerCollectibles: CollectibleType[] = [];
-    for (const collectibleType of getSortedSetValues(collectibleTypesWithTag)) {
+    for (const collectibleType of collectibleTypesWithTag) {
       // We specify "true" as the second argument to filter out things like Lilith's Incubus.
       const numCollectibles = player.GetCollectibleNum(collectibleType, true);
       repeat(numCollectibles, () => {
@@ -1091,11 +1129,13 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCollectibleTypesForTransformation(
     playerForm: PlayerForm,
-  ): ReadonlySet<CollectibleType> {
+  ): readonly CollectibleType[] {
     const itemConfigTag = TRANSFORMATION_TO_TAG_MAP.get(playerForm);
     assertDefined(
       itemConfigTag,
@@ -1114,19 +1154,19 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPlayerCollectiblesForTransformation(
     player: EntityPlayer,
     playerForm: PlayerForm,
-  ): CollectibleType[] {
+  ): readonly CollectibleType[] {
     const collectibleForTransformation =
       this.getCollectibleTypesForTransformation(playerForm);
 
     const playerCollectibles: CollectibleType[] = [];
-    for (const collectibleType of getSortedSetValues(
-      collectibleForTransformation,
-    )) {
+    for (const collectibleType of collectibleForTransformation) {
       // We specify "true" as the second argument to filter out things like Lilith's Incubus.
       const numCollectibles = player.GetCollectibleNum(collectibleType, true);
       repeat(numCollectibles, () => {
@@ -1148,6 +1188,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getEdenActiveCollectibleTypes(): ReadonlySet<CollectibleType> {
@@ -1166,6 +1208,8 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getEdenPassiveCollectibleTypes(): ReadonlySet<CollectibleType> {
@@ -1189,6 +1233,7 @@ export class ModdedElementSets extends Feature {
    *                  `RNG.Next` method will be called. If `undefined` is provided, it will default
    *                  to a random seed.
    * @param exceptions Optional. An array of runes to not select.
+   * @public
    */
   @Exported
   public getRandomEdenActiveCollectibleType(
@@ -1221,6 +1266,7 @@ export class ModdedElementSets extends Feature {
    *                  `RNG.Next` method will be called. If `undefined` is provided, it will default
    *                  to a random seed.
    * @param exceptions Optional. An array of runes to not select.
+   * @public
    */
   @Exported
   public getRandomEdenPassiveCollectibleType(
@@ -1241,18 +1287,20 @@ export class ModdedElementSets extends Feature {
   // -------------------
 
   /**
-   * Returns a set containing every collectible type with the given quality.
+   * Returns an array containing every collectible type with the given quality.
    *
    * This function can only be called if at least one callback has been executed. This is because
    * not all collectible types will necessarily be present when a mod first loads (due to mod load
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCollectibleTypesOfQuality(
     quality: Quality,
-  ): ReadonlySet<CollectibleType> {
+  ): readonly CollectibleType[] {
     this.lazyInit();
 
     const collectibleTypes = this.qualityToCollectibleTypesMap.get(quality);
@@ -1272,27 +1320,27 @@ export class ModdedElementSets extends Feature {
    * order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getPlayerCollectiblesOfQuality(
     player: EntityPlayer,
     quality: Quality,
-  ): CollectibleType[] {
+  ): readonly CollectibleType[] {
     const collectibleTypesOfQuality =
       this.getCollectibleTypesOfQuality(quality);
 
-    const playerCollectibles: CollectibleType[] = [];
-    for (const collectibleType of getSortedSetValues(
-      collectibleTypesOfQuality,
-    )) {
+    const playerCollectibleTypes: CollectibleType[] = [];
+    for (const collectibleType of collectibleTypesOfQuality) {
       // We specify "true" as the second argument to filter out things like Lilith's Incubus.
       const numCollectibles = player.GetCollectibleNum(collectibleType, true);
       repeat(numCollectibles, () => {
-        playerCollectibles.push(collectibleType);
+        playerCollectibleTypes.push(collectibleType);
       });
     }
 
-    return playerCollectibles;
+    return playerCollectibleTypes;
   }
 
   // ----------------------
@@ -1300,33 +1348,35 @@ export class ModdedElementSets extends Feature {
   // ----------------------
 
   /**
-   * Helper function to get a set of card types matching the `ItemConfigCardType`.
+   * Helper function to get an array of card types matching the `ItemConfigCardType`.
    *
-   * This function is variadic, meaning that you can you can specify N card types to get a set
+   * This function is variadic, meaning that you can you can specify N card types to get an array
    * containing cards that match any of the specified types.
    *
    * This function can only be called if at least one callback has been executed. This is because
    * not all card types will necessarily be present when a mod first loads (due to mod load order).
    *
    * In order to use this function, you must upgrade your mod with `ISCFeature.MODDED_ELEMENT_SETS`.
+   *
+   * @public
    */
   @Exported
   public getCardTypesOfType(
     ...itemConfigCardTypes: ItemConfigCardType[]
-  ): Set<CardType> {
+  ): readonly CardType[] {
     this.lazyInit();
 
-    const matchingCardTypes = new Set<CardType>();
+    const matchingCardTypes: CardType[] = [];
     for (const itemConfigCardType of itemConfigCardTypes) {
-      const cardTypeSet =
+      const cardTypes =
         this.itemConfigCardTypeToCardTypeMap.get(itemConfigCardType);
       assertDefined(
-        cardTypeSet,
-        `Failed to get the card type set for item config type: ${itemConfigCardType}`,
+        cardTypes,
+        `Failed to get the card types for item config type: ${itemConfigCardType}`,
       );
 
-      for (const cardType of cardTypeSet) {
-        matchingCardTypes.add(cardType);
+      for (const cardType of cardTypes) {
+        matchingCardTypes.push(cardType);
       }
     }
 
@@ -1350,6 +1400,7 @@ export class ModdedElementSets extends Feature {
    *                  `RNG.Next` method will be called. If `undefined` is provided, it will default
    *                  to a random seed.
    * @param exceptions Optional. An array of cards to not select.
+   * @public
    */
   @Exported
   public getRandomCardTypeOfType(
@@ -1357,8 +1408,8 @@ export class ModdedElementSets extends Feature {
     seedOrRNG: Seed | RNG | undefined,
     exceptions: CardType[] = [],
   ): CardType {
-    const cardTypeSet = this.getCardTypesOfType(itemConfigCardType);
-    return getRandomSetElement(cardTypeSet, seedOrRNG, exceptions);
+    const cardTypes = this.getCardTypesOfType(itemConfigCardType);
+    return getRandomArrayElement(cardTypes, seedOrRNG, exceptions);
   }
 
   /**
@@ -1380,6 +1431,7 @@ export class ModdedElementSets extends Feature {
    *                  `RNG.Next` method will be called. If `undefined` is provided, it will default
    *                  to a random seed.
    * @param exceptions Optional. An array of cards to not select.
+   * @public
    */
   @Exported
   public getRandomCard(
@@ -1387,7 +1439,7 @@ export class ModdedElementSets extends Feature {
     exceptions: CardType[] = [],
   ): CardType {
     this.lazyInit();
-    return getRandomSetElement(this.cardSet, seedOrRNG, exceptions);
+    return getRandomArrayElement(this.cardTypeCardArray, seedOrRNG, exceptions);
   }
 
   /**
@@ -1406,14 +1458,15 @@ export class ModdedElementSets extends Feature {
    *                  `RNG.Next` method will be called. If `undefined` is provided, it will default
    *                  to a random seed.
    * @param exceptions Optional. An array of runes to not select.
+   * @public
    */
   @Exported
   public getRandomRune(
     seedOrRNG: Seed | RNG | undefined,
     exceptions: CardType[] = [],
   ): CardType {
-    const runesSet = this.getCardTypesOfType(ItemConfigCardType.RUNE);
-    runesSet.delete(CardType.RUNE_SHARD);
-    return getRandomSetElement(runesSet, seedOrRNG, exceptions);
+    const runeCardTypes = this.getCardTypesOfType(ItemConfigCardType.RUNE);
+    exceptions.push(CardType.RUNE_SHARD);
+    return getRandomArrayElement(runeCardTypes, seedOrRNG, exceptions);
   }
 }