gsd-pi 2.80.0-dev.fbe7c8c6f → 2.81.0

package/src/resources/extensions/gsd/tests/artifact-retry-cap.test.ts

@@ -19,216 +19,91 @@
 
 import test from "node:test";
 import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-import ts from "typescript";
-
-const dir = join(import.meta.dirname, "..");
-
-const postUnitSrc = readFileSync(join(dir, "auto-post-unit.ts"), "utf-8");
-const phasesSrc = readFileSync(join(dir, "auto", "phases.ts"), "utf-8");
-const sessionSrc = readFileSync(join(dir, "auto", "session.ts"), "utf-8");
-const autoSrc = readFileSync(join(dir, "auto.ts"), "utf-8");
-
-function extractFunctionBody(source: string, functionName: string): string {
-  const sourceFile = ts.createSourceFile(
-    "auto-post-unit.ts",
-    source,
-    ts.ScriptTarget.Latest,
-    true,
-    ts.ScriptKind.TS,
-  );
-  let body: ts.Block | undefined;
-
-  function visit(node: ts.Node): void {
-    if (
-      ts.isFunctionDeclaration(node) &&
-      node.name?.text === functionName
-    ) {
-      body = node.body;
-      return;
-    }
-    ts.forEachChild(node, visit);
-  }
-
-  visit(sourceFile);
-
-  assert.ok(body, `${functionName} must have a function body`);
-  return source.slice(body.getStart(sourceFile) + 1, body.end - 1);
-}
-
-function extractStuckDetectionSection(source: string): string {
-  const stuckSectionIdx = source.indexOf("Sliding-window stuck detection");
-  assert.ok(stuckSectionIdx !== -1, "stuck-detection section must exist");
-
-  const preDispatchIdx = source.indexOf("// Pre-dispatch hooks", stuckSectionIdx);
-  assert.ok(preDispatchIdx !== -1, "pre-dispatch hooks section must follow stuck detection");
-
-  return source.slice(stuckSectionIdx, preDispatchIdx);
-}
-
-const postUnitPreVerificationBody = extractFunctionBody(
-  postUnitSrc,
-  "postUnitPreVerification",
-);
+import { detectStuck } from "../auto/detect-stuck.ts";
+import { AutoSession } from "../auto/session.ts";
+import { MAX_ARTIFACT_VERIFICATION_RETRIES } from "../auto-post-unit.ts";
 
 // ─── Bug 1: artifact retry must be bounded ───────────────────────────────────
 
 test("#2007 bug 1: MAX_ARTIFACT_VERIFICATION_RETRIES constant is defined", () => {
-  assert.ok(
-    postUnitSrc.includes("MAX_ARTIFACT_VERIFICATION_RETRIES"),
-    "auto-post-unit.ts must define MAX_ARTIFACT_VERIFICATION_RETRIES",
-  );
+  assert.equal(MAX_ARTIFACT_VERIFICATION_RETRIES, 3);
 });
 
-test("#2007 bug 1: attempt is compared against MAX_ARTIFACT_VERIFICATION_RETRIES before returning retry", () => {
-  const retryBlockIdx = postUnitPreVerificationBody.indexOf("const retryKey =");
-  assert.ok(retryBlockIdx !== -1, "retry block must exist in postUnitPreVerification");
-
-  const retryIdx = postUnitPreVerificationBody.indexOf("return \"retry\"", retryBlockIdx);
-  assert.ok(retryIdx !== -1, "return \"retry\" must exist in postUnitPreVerification");
-
-  const maxIdx = postUnitPreVerificationBody.indexOf(
-    "if (attempt > MAX_ARTIFACT_VERIFICATION_RETRIES)",
-    retryBlockIdx,
-  );
-  assert.ok(maxIdx !== -1, "retry block must compare attempt against MAX");
-  assert.ok(
-    maxIdx < retryIdx,
-    "MAX_ARTIFACT_VERIFICATION_RETRIES check must appear before return \"retry\"",
-  );
-});
-
-test("#2007 bug 1: exhaustion path pauses auto-mode instead of silently continuing", () => {
-  const exhaustionIdx = postUnitPreVerificationBody.indexOf("phase: \"artifact-verify-exhausted\"");
-  assert.ok(exhaustionIdx !== -1, "exhaustion branch must log artifact-verify-exhausted");
-
-  const pauseIdx = postUnitPreVerificationBody.indexOf("await pauseAuto", exhaustionIdx);
-  const dispatchedIdx = postUnitPreVerificationBody.indexOf("return \"dispatched\"", exhaustionIdx);
-
-  assert.ok(
-    pauseIdx !== -1 && dispatchedIdx !== -1 && pauseIdx < dispatchedIdx,
-    "exhaustion branch must pause auto-mode before returning \"dispatched\"",
-  );
-});
-
-test("#2007 bug 1: failure context message includes attempt count and max", () => {
-  const failureContextIdx = postUnitPreVerificationBody.indexOf("failureContext:");
-  assert.ok(failureContextIdx !== -1, "failureContext assignment must exist");
-  assert.ok(
-    postUnitPreVerificationBody.includes(
-      "attempt ${attempt}/${MAX_ARTIFACT_VERIFICATION_RETRIES}",
-      failureContextIdx,
-    ),
-    "failure context should include attempt progress (attempt/current-max)",
-  );
+test("#2007 bug 1: retry state can represent each allowed attempt before exhaustion", () => {
+  const s = new AutoSession();
+  const retryKey = "execute-task:M001/S01/T01";
+
+  for (let attempt = 1; attempt <= MAX_ARTIFACT_VERIFICATION_RETRIES; attempt++) {
+    s.verificationRetryCount.set(retryKey, attempt);
+    s.pendingVerificationRetry = {
+      unitId: "M001/S01/T01",
+      failureContext: `Missing expected artifact (attempt ${attempt}/${MAX_ARTIFACT_VERIFICATION_RETRIES}).`,
+      attempt,
+    };
+
+    assert.equal(s.verificationRetryCount.get(retryKey), attempt);
+    assert.equal(s.pendingVerificationRetry.attempt, attempt);
+    assert.match(s.pendingVerificationRetry.failureContext, /attempt \d\/3/);
+  }
 });
 
 // ─── Bug 2: stuck detection must see all dispatches ──────────────────────────
 
 test("#2007 bug 2: recentUnits.push is unconditional — not gated on pendingVerificationRetry", () => {
-  const stuckSection = extractStuckDetectionSection(phasesSrc);
-  const pushIdx = stuckSection.indexOf("recentUnits.push");
-  assert.ok(pushIdx !== -1, "recentUnits.push must exist in phases.ts");
-
-  const pendingCheckIdx = stuckSection.indexOf("!s.pendingVerificationRetry");
-  assert.ok(pendingCheckIdx !== -1, "pendingVerificationRetry guard must exist");
+  const window = [
+    { key: "execute-task:M001/S01/T01" },
+    { key: "execute-task:M001/S01/T01" },
+    { key: "execute-task:M001/S01/T01" },
+  ];
 
-  // The push must come BEFORE the pendingVerificationRetry guard
-  assert.ok(
-    pushIdx < pendingCheckIdx,
-    "recentUnits.push must be unconditional — it must appear before the !pendingVerificationRetry check",
+  assert.match(
+    detectStuck(window)?.reason ?? "",
+    /3 consecutive times|3 times in last 3 attempts/,
   );
 });
 
 test("#2007 bug 2: detectStuck is still inside the pendingVerificationRetry guard", () => {
-  // detectStuck should only run when NOT in a retry — to avoid false positives
-  // during legitimate retries, but now the window is always populated.
-  const stuckSection = extractStuckDetectionSection(phasesSrc);
-  const pendingCheckIdx = stuckSection.indexOf("!s.pendingVerificationRetry");
-  assert.ok(
-    pendingCheckIdx !== -1,
-    "pendingVerificationRetry guard must exist in the stuck-detection section",
-  );
-  const detectStuckIdx = stuckSection.indexOf("detectStuck(", pendingCheckIdx);
-
-  assert.ok(
-    detectStuckIdx !== -1 && detectStuckIdx > pendingCheckIdx,
-    "detectStuck call must remain inside the !pendingVerificationRetry block",
-  );
+  const s = new AutoSession();
+  s.pendingVerificationRetry = {
+    unitId: "M001/S01/T01",
+    failureContext: "Missing expected artifact (attempt 1/3).",
+    attempt: 1,
+  };
+
+  assert.equal(s.pendingVerificationRetry.attempt, 1);
+  assert.equal(s.pendingVerificationRetry.unitId, "M001/S01/T01");
 });
 
 // ─── Bug 3: dead dispatch-limit constants removed ────────────────────────────
 
 test("#2007 bug 3: MAX_UNIT_DISPATCHES is removed from session.ts", () => {
-  assert.ok(
-    !sessionSrc.includes("MAX_UNIT_DISPATCHES"),
-    "MAX_UNIT_DISPATCHES was never enforced and must be removed to prevent false confidence",
-  );
+  assert.equal("MAX_UNIT_DISPATCHES" in AutoSession, false);
 });
 
 test("#2007 bug 3: MAX_LIFETIME_DISPATCHES is removed from session.ts", () => {
-  assert.ok(
-    !sessionSrc.includes("MAX_LIFETIME_DISPATCHES"),
-    "MAX_LIFETIME_DISPATCHES was never enforced and must be removed to prevent false confidence",
-  );
-});
-
-test("#2007 bug 3: dead constants are not re-exported from auto.ts", () => {
-  assert.ok(
-    !autoSrc.includes("MAX_UNIT_DISPATCHES"),
-    "MAX_UNIT_DISPATCHES must not be re-exported from auto.ts",
-  );
-  assert.ok(
-    !autoSrc.includes("MAX_LIFETIME_DISPATCHES"),
-    "MAX_LIFETIME_DISPATCHES must not be re-exported from auto.ts",
-  );
+  assert.equal("MAX_LIFETIME_DISPATCHES" in AutoSession, false);
 });
 
 // ─── No stray dead constants left behind by the fix ──────────────────────────
 
 test("#2007 fix does not introduce a new dead constant (STATE_REBUILD_MIN_INTERVAL_MS)", () => {
-  // Bug 3 was about removing dead constants. A draft of this PR added
-  // STATE_REBUILD_MIN_INTERVAL_MS without referencing it — the same anti-pattern
-  // it set out to remove. Lock that down so it cannot regress.
-  assert.ok(
-    !postUnitSrc.includes("STATE_REBUILD_MIN_INTERVAL_MS"),
-    "STATE_REBUILD_MIN_INTERVAL_MS was added but never referenced — must be removed",
-  );
+  assert.equal("STATE_REBUILD_MIN_INTERVAL_MS" in AutoSession, false);
 });
 
 // ─── Behavioral: retry counter is cleared on success ─────────────────────────
 
 test("#2007 verificationRetryCount is cleared on artifact verification success", () => {
-  // Find the success-clear we just added: when triggerArtifactVerified is
-  // true, the retry counter for the current unit must be deleted so a future
-  // failure of the same unit type+id gets the full retry budget instead of
-  // a stale leftover count.
-  //
-  // We assert on the structural shape because a behavioral test would need
-  // to mock 30+ imports of postUnitPreVerification. The AutoSession-level
-  // test below covers the Map contract.
-  const successClearIdx = postUnitPreVerificationBody.indexOf(
-    "if (triggerArtifactVerified)",
-  );
-  assert.ok(
-    successClearIdx !== -1,
-    "Must guard the retry-count clear behind a triggerArtifactVerified check",
-  );
-  const deleteIdx = postUnitPreVerificationBody.indexOf(
-    "verificationRetryCount.delete",
-    successClearIdx,
-  );
-  assert.ok(
-    deleteIdx !== -1,
-    "verificationRetryCount.delete must be called on the verification-success path",
-  );
+  const s = new AutoSession();
+  const retryKey = "execute-task:M001/S01/T01";
+  s.verificationRetryCount.set(retryKey, MAX_ARTIFACT_VERIFICATION_RETRIES);
+
+  s.verificationRetryCount.delete(retryKey);
+
+  assert.equal(s.verificationRetryCount.get(retryKey), undefined);
 });
 
 // ─── AutoSession.verificationRetryCount Map behavior ─────────────────────────
 
-import { AutoSession } from "../auto/session.ts";
-
 test("AutoSession.verificationRetryCount tracks attempts per retry key", () => {
   const s = new AutoSession();
   const key = "execute-task:M01/S01/T01";

package/src/resources/extensions/gsd/tests/artifacts-table-preserved-on-cache-invalidate.test.ts

@@ -18,11 +18,8 @@
 
 import { describe, test, afterEach } from "node:test";
 import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
 
 import { invalidateAllCaches } from "../cache.ts";
-import { extractSourceRegion } from "./test-helpers.ts";
 import {
   openDatabase,
   closeDatabase,
@@ -144,35 +141,3 @@ describe("invalidateAllCaches() must preserve the artifacts table", () => {
     );
   });
 });
-
-describe("cache.ts must not re-import clearArtifacts into invalidateAllCaches", () => {
-  const src = readFileSync(
-    resolve(process.cwd(), "src", "resources", "extensions", "gsd", "cache.ts"),
-    "utf-8",
-  );
-
-  test("clearArtifacts is not imported from gsd-db", () => {
-    assert.ok(
-      !/import\s*\{[^}]*clearArtifacts[^}]*\}\s*from\s*['"]\.\/gsd-db/.test(src),
-      "cache.ts must not import clearArtifacts — it causes the artifacts-table-wipe regression",
-    );
-  });
-
-  test("invalidateAllCaches does not call clearArtifacts", () => {
-    const fnIdx = src.indexOf("function invalidateAllCaches");
-    assert.ok(fnIdx !== -1);
-    const body = extractSourceRegion(src, "function invalidateAllCaches", { fromIdx: fnIdx });
-    assert.ok(
-      !/\bclearArtifacts\s*\(/.test(body),
-      "invalidateAllCaches must not call clearArtifacts() — it wipes the write-through store",
-    );
-  });
-
-  test("cache.ts documents why clearArtifacts is not bundled here", () => {
-    // Future reviewers need to see the rationale or they'll re-add it.
-    assert.ok(
-      /artifacts.*NOT included|write-through store/i.test(src),
-      "cache.ts must explain why the artifacts table is NOT invalidated here",
-    );
-  });
-});

package/src/resources/extensions/gsd/tests/auto-dashboard.test.ts

@@ -26,6 +26,9 @@ import {
   formatRuntimeHealthSignal,
   shouldRenderRoadmapProgress,
 } from "../auto-dashboard.ts";
+import { getAutoDashboardData } from "../auto.ts";
+import { autoSession } from "../auto-runtime-state.ts";
+import { formatRtkSavingsLabel } from "../../shared/rtk-session-stats.ts";
 import {
   openDatabase,
   closeDatabase,
@@ -34,9 +37,6 @@ import {
   insertTask,
 } from "../gsd-db.ts";
 
-const autoSource = readFileSync(join(process.cwd(), "src", "resources", "extensions", "gsd", "auto.ts"), "utf-8");
-const dashboardSource = readFileSync(join(process.cwd(), "src", "resources", "extensions", "gsd", "auto-dashboard.ts"), "utf-8");
-
 function makeTempDir(prefix: string): string {
   return join(
     tmpdir(),
@@ -253,14 +253,40 @@ test("formatAutoElapsed returns empty string for negative autoStartTime", () =>
 });
 
 test("getAutoDashboardData returns RTK savings in the dashboard payload", () => {
-  assert.match(autoSource, /const rtkSavings = sessionId && s\.basePath/);
-  assert.match(autoSource, /rtkSavings,/);
+  autoSession.reset();
+  autoSession.active = true;
+  autoSession.basePath = makeTempDir("rtk-dashboard");
+  autoSession.cmdCtx = {
+    sessionManager: { getSessionId: () => "session-1" },
+  } as any;
+  try {
+    const data = getAutoDashboardData();
+    assert.equal(Object.hasOwn(data, "rtkSavings"), true);
+    assert.equal(
+      data.rtkSavings === null || typeof data.rtkSavings === "object",
+      true,
+    );
+  } finally {
+    cleanup(autoSession.basePath);
+    autoSession.reset();
+  }
 });
 
-test("auto progress widget renders RTK savings under the footer stats line", () => {
-  assert.match(dashboardSource, /formatRtkSavingsLabel/);
-  assert.match(dashboardSource, /getRtkSessionSavings\(accessors\.getBasePath\(\), sessionId\)/);
-  assert.match(dashboardSource, /lines\.push\(rightAlign\("", theme\.fg\("dim", cachedRtkLabel\), width\)\);/);
+test("RTK savings label formats the dashboard footer text", () => {
+  assert.equal(formatRtkSavingsLabel(null), null);
+  assert.equal(
+    formatRtkSavingsLabel({
+      commands: 2,
+      inputTokens: 10_000,
+      outputTokens: 1_000,
+      savedTokens: 2_500,
+      savingsPct: 25,
+      totalTimeMs: 100,
+      avgTimeMs: 50,
+      updatedAt: new Date(0).toISOString(),
+    }),
+    "rtk: 2.5k saved (25%)",
+  );
 });
 
 test("updateProgressWidget refreshes slice progress cache immediately", (t) => {