gsd-pi 2.80.0-dev.fbe7c8c6f → 2.81.0

package/src/resources/extensions/gsd/tests/visualizer-data.test.ts

@@ -1,444 +1,84 @@
-// Tests for GSD visualizer data loader.
-// Verifies the VisualizerData interface shape and source-file contracts.
-
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-import { test } from 'node:test';
-import assert from 'node:assert/strict';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-const dataPath = join(__dirname, "..", "visualizer-data.ts");
-const dataSrc = readFileSync(dataPath, "utf-8");
-
-console.log("\n=== visualizer-data.ts source contracts ===");
-
-// Interface exports
-assert.ok(
-  dataSrc.includes("export interface VisualizerData"),
-  "exports VisualizerData interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerMilestone"),
-  "exports VisualizerMilestone interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerSlice"),
-  "exports VisualizerSlice interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerTask"),
-  "exports VisualizerTask interface",
-);
-
-// New interfaces
-assert.ok(
-  dataSrc.includes("export interface CriticalPathInfo"),
-  "exports CriticalPathInfo interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface AgentActivityInfo"),
-  "exports AgentActivityInfo interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface ChangelogEntry"),
-  "exports ChangelogEntry interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface ChangelogInfo"),
-  "exports ChangelogInfo interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface SliceVerification"),
-  "exports SliceVerification interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface KnowledgeInfo"),
-  "exports KnowledgeInfo interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface CapturesInfo"),
-  "exports CapturesInfo interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface HealthInfo"),
-  "exports HealthInfo interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerDiscussionState"),
-  "exports VisualizerDiscussionState interface",
-);
-
-assert.ok(
-  dataSrc.includes("export type DiscussionState"),
-  "exports DiscussionState type",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerSliceRef"),
-  "exports VisualizerSliceRef interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerSliceActivity"),
-  "exports VisualizerSliceActivity interface",
-);
-
-assert.ok(
-  dataSrc.includes("export interface VisualizerStats"),
-  "exports VisualizerStats interface",
-);
-
-// Function export
-assert.ok(
-  dataSrc.includes("export async function loadVisualizerData"),
-  "exports loadVisualizerData function",
-);
-
-assert.ok(
-  dataSrc.includes("export function computeCriticalPath"),
-  "exports computeCriticalPath function",
-);
-
-// Data source usage
-assert.ok(
-  dataSrc.includes("deriveState"),
-  "uses deriveState for state derivation",
-);
-
-assert.ok(
-  dataSrc.includes("findMilestoneIds"),
-  "uses findMilestoneIds to enumerate milestones",
-);
-
-assert.ok(
-  dataSrc.includes("parseRoadmap"),
-  "uses parseRoadmap for roadmap parsing",
-);
-
-assert.ok(
-  dataSrc.includes("parsePlan"),
-  "uses parsePlan for plan parsing",
-);
-
-assert.ok(
-  dataSrc.includes("parseSummary"),
-  "uses parseSummary for changelog parsing",
-);
-
-assert.ok(
-  dataSrc.includes("getLedger"),
-  "uses getLedger for in-memory metrics",
-);
-
-assert.ok(
-  dataSrc.includes("loadLedgerFromDisk"),
-  "uses loadLedgerFromDisk as fallback",
-);
-
-assert.ok(
-  dataSrc.includes("getProjectTotals"),
-  "uses getProjectTotals for aggregation",
-);
-
-assert.ok(
-  dataSrc.includes("aggregateByPhase"),
-  "uses aggregateByPhase",
-);
-
-assert.ok(
-  dataSrc.includes("aggregateBySlice"),
-  "uses aggregateBySlice",
-);
-
-assert.ok(
-  dataSrc.includes("aggregateByModel"),
-  "uses aggregateByModel",
-);
-
-assert.ok(
-  dataSrc.includes("aggregateByTier"),
-  "uses aggregateByTier",
-);
-
-assert.ok(
-  dataSrc.includes("formatTierSavings"),
-  "uses formatTierSavings",
-);
-
-assert.ok(
-  dataSrc.includes("loadAllCaptures"),
-  "uses loadAllCaptures",
-);
-
-assert.ok(
-  dataSrc.includes("countPendingCaptures"),
-  "uses countPendingCaptures",
-);
-
-assert.ok(
-  dataSrc.includes("loadEffectiveGSDPreferences"),
-  "uses loadEffectiveGSDPreferences",
-);
-
-assert.ok(
-  dataSrc.includes("resolveGsdRootFile"),
-  "uses resolveGsdRootFile for KNOWLEDGE path",
-);
-
-// Interface fields
-assert.ok(
-  dataSrc.includes("dependsOn: string[]"),
-  "VisualizerMilestone has dependsOn field",
-);
-
-assert.ok(
-  dataSrc.includes("depends: string[]"),
-  "VisualizerSlice has depends field",
-);
-
-assert.ok(
-  dataSrc.includes("totals: ProjectTotals | null"),
-  "VisualizerData has nullable totals",
-);
-
-assert.ok(
-  dataSrc.includes("units: UnitMetrics[]"),
-  "VisualizerData has units array",
-);
-
-assert.ok(
-  dataSrc.includes("estimate?: string"),
-  "VisualizerTask has optional estimate field",
-);
-
-// New data model fields
-assert.ok(
-  dataSrc.includes("criticalPath: CriticalPathInfo"),
-  "VisualizerData has criticalPath field",
-);
-
-assert.ok(
-  dataSrc.includes("remainingSliceCount: number"),
-  "VisualizerData has remainingSliceCount field",
-);
-
-assert.ok(
-  dataSrc.includes("agentActivity: AgentActivityInfo | null"),
-  "VisualizerData has agentActivity field",
-);
-
-assert.ok(
-  dataSrc.includes("changelog: ChangelogInfo"),
-  "VisualizerData has changelog field",
-);
-
-assert.ok(
-  dataSrc.includes("sliceVerifications: SliceVerification[]"),
-  "VisualizerData has sliceVerifications field",
-);
-
-assert.ok(
-  dataSrc.includes("knowledge: KnowledgeInfo"),
-  "VisualizerData has knowledge field",
-);
-
-assert.ok(
-  dataSrc.includes("captures: CapturesInfo"),
-  "VisualizerData has captures field",
-);
-
-assert.ok(
-  dataSrc.includes("health: HealthInfo"),
-  "VisualizerData has health field",
-);
-
-assert.ok(
-  dataSrc.includes("stats: VisualizerStats"),
-  "VisualizerData has stats field",
-);
-
-assert.ok(
-  dataSrc.includes("discussion: VisualizerDiscussionState[]"),
-  "VisualizerData has discussion field",
-);
-
-assert.ok(
-  dataSrc.includes("loadDiscussionState"),
-  "uses loadDiscussionState helper",
-);
-
-assert.ok(
-  dataSrc.includes("buildVisualizerStats"),
-  "uses buildVisualizerStats helper",
-);
-
-assert.ok(
-  dataSrc.includes("byTier: TierAggregate[]"),
-  "VisualizerData has byTier field",
-);
-
-assert.ok(
-  dataSrc.includes("tierSavingsLine: string"),
-  "VisualizerData has tierSavingsLine field",
-);
-
-// completedAt must be coerced to String() to handle YAML Date objects (issue #644)
-assert.ok(
-  dataSrc.includes("String(summary.frontmatter.completed_at"),
-  "completedAt assignment coerces to String() for YAML Date safety",
-);
-
-assert.ok(
-  dataSrc.includes("String(b.completedAt") && dataSrc.includes("String(a.completedAt"),
-  "changelog sort coerces completedAt to String() for YAML Date safety",
-);
-
-// Verify overlay source exists and imports data module
-const overlayPath = join(__dirname, "..", "visualizer-overlay.ts");
-const overlaySrc = readFileSync(overlayPath, "utf-8");
-
-console.log("\n=== visualizer-overlay.ts source contracts ===");
-
-assert.ok(
-  overlaySrc.includes("export class GSDVisualizerOverlay"),
-  "exports GSDVisualizerOverlay class",
-);
-
-assert.ok(
-  overlaySrc.includes("loadVisualizerData"),
-  "overlay uses loadVisualizerData",
-);
-
-assert.ok(
-  overlaySrc.includes("renderProgressView"),
-  "overlay delegates to renderProgressView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderDepsView"),
-  "overlay delegates to renderDepsView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderMetricsView"),
-  "overlay delegates to renderMetricsView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderTimelineView"),
-  "overlay delegates to renderTimelineView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderAgentView"),
-  "overlay delegates to renderAgentView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderChangelogView"),
-  "overlay delegates to renderChangelogView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderExportView"),
-  "overlay delegates to renderExportView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderKnowledgeView"),
-  "overlay delegates to renderKnowledgeView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderCapturesView"),
-  "overlay delegates to renderCapturesView",
-);
-
-assert.ok(
-  overlaySrc.includes("renderHealthView"),
-  "overlay delegates to renderHealthView",
-);
-
-assert.ok(
-  overlaySrc.includes("handleInput"),
-  "overlay has handleInput method",
-);
-
-assert.ok(
-  overlaySrc.includes("dispose"),
-  "overlay has dispose method",
-);
-
-assert.ok(
-  overlaySrc.includes("wrapInBox"),
-  "overlay has wrapInBox helper",
-);
-
-assert.ok(
-  overlaySrc.includes("activeTab"),
-  "overlay tracks active tab",
-);
-
-assert.ok(
-  overlaySrc.includes("scrollOffsets"),
-  "overlay tracks per-tab scroll offsets",
-);
-
-assert.ok(
-  overlaySrc.includes("filterMode"),
-  "overlay has filterMode state",
-);
-
-assert.ok(
-  overlaySrc.includes("filterText"),
-  "overlay has filterText state",
-);
-
-assert.ok(
-  overlaySrc.includes("filterField"),
-  "overlay has filterField state",
-);
-
-assert.ok(
-  overlaySrc.includes("TAB_COUNT"),
-  "overlay defines TAB_COUNT",
-);
-
-assert.ok(
-  overlaySrc.includes("0 Export"),
-  "overlay has 10 tab labels",
-);
-
-// Verify commands/handlers/core.ts integration
-const coreHandlerPath = join(__dirname, "..", "commands", "handlers", "core.ts");
-const coreHandlerSrc = readFileSync(coreHandlerPath, "utf-8");
-
-console.log("\n=== commands/handlers/core.ts integration ===");
-
-assert.ok(
-  coreHandlerSrc.includes('"visualize"'),
-  "core.ts has visualize in subcommands array",
-);
-
-assert.ok(
-  coreHandlerSrc.includes("GSDVisualizerOverlay"),
-  "core.ts imports GSDVisualizerOverlay",
-);
-
-assert.ok(
-  coreHandlerSrc.includes("handleVisualize"),
-  "core.ts has handleVisualize handler",
-);
+// GSD-2 — Visualizer data behavior tests.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+
+import {
+  computeCriticalPath,
+  loadVisualizerData,
+  type VisualizerMilestone,
+} from "../visualizer-data.ts";
+
+test("computeCriticalPath follows milestone dependencies", () => {
+  const milestones: VisualizerMilestone[] = [
+    {
+      id: "M001",
+      title: "Foundation",
+      status: "active",
+      dependsOn: [],
+      slices: [{ id: "S01", title: "Foundation", done: false, active: false, risk: "low", depends: [], tasks: [] }],
+    },
+    {
+      id: "M002",
+      title: "Feature",
+      status: "active",
+      dependsOn: ["M001"],
+      slices: [{ id: "S01", title: "Build", done: false, active: true, risk: "medium", depends: [], tasks: [] }],
+    },
+  ];
+
+  const path = computeCriticalPath(milestones);
+  assert.deepEqual(path.milestonePath, ["M001", "M002"]);
+  assert.equal(path.milestoneSlack.has("M001"), true);
+  assert.equal(path.milestoneSlack.has("M002"), true);
+});
+
+test("loadVisualizerData hydrates milestones, captures, stats, and health fields", async () => {
+  const base = mkdtempSync(join(tmpdir(), "gsd-visualizer-data-"));
+  try {
+    const msDir = join(base, ".gsd", "milestones", "M001");
+    const sliceDir = join(msDir, "slices", "S01");
+    mkdirSync(sliceDir, { recursive: true });
+    writeFileSync(
+      join(msDir, "M001-ROADMAP.md"),
+      [
+        "# M001: Visualizer",
+        "",
+        "## Slices",
+        "- [ ] **S01: Build UI** `risk:low` `depends:[]`",
+      ].join("\n"),
+    );
+    writeFileSync(
+      join(sliceDir, "S01-PLAN.md"),
+      "# S01 Plan\n\n## Tasks\n- [ ] **T01: Render data** `est:10m`\n",
+    );
+    writeFileSync(
+      join(base, ".gsd", "CAPTURES.md"),
+      [
+        "# Captures",
+        "",
+        "### CAP-visual",
+        "**Text:** Investigate visualizer state",
+        "**Captured:** 2026-01-01T00:00:00.000Z",
+        "**Status:** pending",
+        "",
+      ].join("\n"),
+    );
+
+    const data = await loadVisualizerData(base);
+
+    assert.equal(data.milestones.length, 1);
+    assert.equal(data.milestones[0]?.id, "M001");
+    assert.equal(data.milestones[0]?.slices[0]?.id, "S01");
+    assert.equal(data.remainingSliceCount, 1);
+    assert.equal(data.captures.pendingCount, 1);
+    assert.equal(data.stats.missingCount, 1);
+    assert.ok(data.health);
+    assert.ok(data.criticalPath.milestonePath.length >= 1);
+  } finally {
+    rmSync(base, { recursive: true, force: true });
+  }
+});

package/src/resources/extensions/gsd/tests/workflow-dispatch-claim.test.ts

@@ -7,7 +7,9 @@ import test from "node:test";
 import type { AutoSession } from "../auto/session.ts";
 import type { IterationData } from "../auto/types.ts";
 import {
+  ensureDispatchLease,
   openDispatchClaim,
+  type EnsureDispatchLeaseDeps,
   type OpenDispatchClaimDeps,
 } from "../auto/workflow-dispatch-claim.ts";
 
@@ -49,6 +51,25 @@ function makeDeps(overrides?: Partial<OpenDispatchClaimDeps>): OpenDispatchClaim
   };
 }
 
+function makeLeaseDeps(overrides?: Partial<EnsureDispatchLeaseDeps>): {
+  deps: EnsureDispatchLeaseDeps;
+  calls: unknown[];
+  failures: unknown[];
+} {
+  const calls: unknown[] = [];
+  const failures: unknown[] = [];
+  const deps: EnsureDispatchLeaseDeps = {
+    claimMilestoneLease: (workerId, milestoneId) => {
+      calls.push(["claim", workerId, milestoneId]);
+      return { ok: true, token: 8, expiresAt: "2030-01-01T00:00:00.000Z" };
+    },
+    logLeaseRecovered: details => calls.push(["recovered", details]),
+    logLeaseRecoveryFailed: details => failures.push(details),
+    ...overrides,
+  };
+  return { deps, calls, failures };
+}
+
 test("openDispatchClaim degrades when worker identity or lease token is missing", () => {
   assert.deepEqual(
     openDispatchClaim(makeSession({ workerId: null }), "flow", "turn", makeIterationData(), makeDeps({
@@ -156,3 +177,124 @@ test("openDispatchClaim degrades on claim write failures", () => {
   assert.deepEqual(outcome, { kind: "degraded" });
   assert.deepEqual(logged, [writeError]);
 });
+
+test("ensureDispatchLease degrades without worker identity or milestone id", () => {
+  const { deps, calls } = makeLeaseDeps({
+    claimMilestoneLease: () => assert.fail("claimMilestoneLease should not be called"),
+  });
+
+  assert.deepEqual(
+    ensureDispatchLease(makeSession({ workerId: null }), "M001", deps),
+    { kind: "degraded", reason: "missing-worker" },
+  );
+  assert.deepEqual(
+    ensureDispatchLease(makeSession(), undefined, deps),
+    { kind: "degraded", reason: "missing-milestone" },
+  );
+  assert.deepEqual(calls, []);
+});
+
+test("ensureDispatchLease reuses an existing numeric token", () => {
+  const { deps, calls } = makeLeaseDeps({
+    claimMilestoneLease: () => assert.fail("claimMilestoneLease should not be called"),
+  });
+
+  const session = makeSession({ milestoneLeaseToken: 7 });
+  const outcome = ensureDispatchLease(session, "M001", deps);
+
+  assert.deepEqual(outcome, { kind: "ready", token: 7, recovered: false });
+  assert.equal(session.milestoneLeaseToken, 7);
+  assert.deepEqual(calls, []);
+});
+
+test("ensureDispatchLease claims a lease when the session has no token", () => {
+  const { deps, calls, failures } = makeLeaseDeps();
+  const session = makeSession({
+    currentMilestoneId: "M001",
+    milestoneLeaseToken: null,
+  });
+
+  const outcome = ensureDispatchLease(session, "M001", deps);
+
+  assert.deepEqual(outcome, { kind: "ready", token: 8, recovered: false });
+  assert.equal(session.currentMilestoneId, "M001");
+  assert.equal(session.milestoneLeaseToken, 8);
+  assert.deepEqual(calls, [
+    ["claim", "worker-1", "M001"],
+    ["recovered", {
+      milestoneId: "M001",
+      workerId: "worker-1",
+      token: 8,
+      recovered: false,
+    }],
+  ]);
+  assert.deepEqual(failures, []);
+});
+
+test("ensureDispatchLease force-reclaims after a stale dispatch claim", () => {
+  const { deps, calls } = makeLeaseDeps({
+    claimMilestoneLease: (workerId, milestoneId) => {
+      calls.push(["claim", workerId, milestoneId]);
+      return { ok: true, token: 9, expiresAt: "2030-01-01T00:00:00.000Z" };
+    },
+  });
+  const session = makeSession({ milestoneLeaseToken: 7 });
+
+  const outcome = ensureDispatchLease(session, "M001", deps, { forceReclaim: true });
+
+  assert.deepEqual(outcome, { kind: "ready", token: 9, recovered: true });
+  assert.equal(session.milestoneLeaseToken, 9);
+  assert.deepEqual(calls, [
+    ["claim", "worker-1", "M001"],
+    ["recovered", {
+      milestoneId: "M001",
+      workerId: "worker-1",
+      token: 9,
+      recovered: true,
+    }],
+  ]);
+});
+
+test("ensureDispatchLease blocks when another worker holds the lease", () => {
+  const { deps, failures } = makeLeaseDeps({
+    claimMilestoneLease: () => ({
+      ok: false,
+      error: "held_by",
+      byWorker: "worker-2",
+      expiresAt: "2030-01-01T00:00:00.000Z",
+    }),
+  });
+  const session = makeSession({ milestoneLeaseToken: null });
+
+  const outcome = ensureDispatchLease(session, "M001", deps);
+
+  assert.deepEqual(outcome, {
+    kind: "blocked",
+    reason: "Milestone M001 is held by worker worker-2 until 2030-01-01T00:00:00.000Z.",
+  });
+  assert.equal(session.milestoneLeaseToken, null);
+  assert.deepEqual(failures, [{
+    milestoneId: "M001",
+    workerId: "worker-1",
+    reason: "Milestone M001 is held by worker worker-2 until 2030-01-01T00:00:00.000Z.",
+  }]);
+});
+
+test("ensureDispatchLease fails closed on claim errors", () => {
+  const { deps, failures } = makeLeaseDeps({
+    claimMilestoneLease: () => {
+      throw new Error("db unavailable");
+    },
+  });
+  const session = makeSession({ milestoneLeaseToken: null });
+
+  const outcome = ensureDispatchLease(session, "M001", deps);
+
+  assert.deepEqual(outcome, { kind: "failed", reason: "db unavailable" });
+  assert.equal(session.milestoneLeaseToken, null);
+  assert.deepEqual(failures, [{
+    milestoneId: "M001",
+    workerId: "worker-1",
+    reason: "db unavailable",
+  }]);
+});