gsd-pi 2.80.0-dev.fbe7c8c6f → 2.81.0

package/src/resources/extensions/gsd/tests/worktree-safety.test.ts

@@ -0,0 +1,327 @@
+// Project/App: GSD-2
+// File Purpose: Unit tests for the Worktree Safety module contract.
+
+import { afterEach, beforeEach, describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync, unlinkSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { execFileSync } from "node:child_process";
+
+import { createWorktreeSafetyModule } from "../worktree-safety.ts";
+import { createWorktree, worktreePath } from "../worktree-manager.ts";
+
+function runGit(args: string[], cwd: string): string {
+  return execFileSync("git", args, {
+    cwd,
+    stdio: ["ignore", "pipe", "pipe"],
+    encoding: "utf-8",
+  }).trim();
+}
+
+function makeBaseRepo(): string {
+  const base = mkdtempSync(join(tmpdir(), "gsd-wt-safety-repo-"));
+  runGit(["init", "-b", "main"], base);
+  runGit(["config", "user.name", "Test User"], base);
+  runGit(["config", "user.email", "test@example.com"], base);
+  writeFileSync(join(base, "README.md"), "# Test Project\n", "utf-8");
+  runGit(["add", "."], base);
+  runGit(["commit", "-m", "chore: init"], base);
+  return base;
+}
+
+describe("Worktree Safety module", () => {
+  let root: string;
+  let projectRoot: string;
+  let unitRoot: string;
+
+  beforeEach(() => {
+    root = mkdtempSync(join(tmpdir(), "gsd-worktree-safety-"));
+    projectRoot = join(root, "project");
+    unitRoot = join(projectRoot, ".gsd", "worktrees", "M001");
+    mkdirSync(unitRoot, { recursive: true });
+    writeFileSync(join(unitRoot, ".git"), "gitdir: ../../../.git/worktrees/M001\n", "utf-8");
+  });
+
+  afterEach(() => {
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  test("allows planning-only Units without requiring a source worktree", () => {
+    const safety = createWorktreeSafetyModule();
+
+    const result = safety.validateUnitRoot({
+      unitType: "plan-milestone",
+      unitId: "M001",
+      writeScope: "planning-only",
+      projectRoot,
+      unitRoot: projectRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, true);
+    assert.equal(result.kind, "not-required");
+  });
+
+  test("accepts a source-writing Unit with a registered worktree and expected branch", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => [{ path: unitRoot, branch: "milestone/M001" }],
+      getCurrentBranch: () => "milestone/M001",
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+      expectedBranch: "milestone/M001",
+    });
+
+    assert.equal(result.ok, true);
+    assert.equal(result.kind, "safe");
+    assert.equal(result.milestoneId, "M001");
+    assert.equal(result.branch, "milestone/M001");
+  });
+
+  test("rejects a source-writing Unit when the worktree root is missing", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: (path) => path !== unitRoot,
+      lstatSync: () => ({ isFile: () => true }),
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-missing");
+    assert.match(result.remediation, /Create or recover/);
+  });
+
+  test("rejects a source-writing Unit outside the expected milestone worktree root", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+    });
+
+    const outsideRoot = join(projectRoot, "src");
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot: outsideRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "invalid-root");
+    assert.equal(result.details?.unitRoot, outsideRoot);
+    assert.equal(result.details?.expectedRoot, unitRoot);
+  });
+
+  test("rejects a standalone repository masquerading as a worktree", () => {
+    unlinkSync(join(unitRoot, ".git"));
+    mkdirSync(join(unitRoot, ".git"), { recursive: true });
+    const safety = createWorktreeSafetyModule();
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-git-marker-not-file");
+  });
+
+  test("converts .git marker stat failures into typed failures", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => {
+        throw new Error("marker disappeared");
+      },
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-git-probe-failed");
+    assert.equal(result.details?.error, "marker disappeared");
+  });
+
+  test("rejects an unregistered worktree path", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => [],
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-unregistered");
+  });
+
+  test("converts registered worktree list failures into typed failures", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => {
+        throw new Error("worktree list unreadable");
+      },
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-git-probe-failed");
+    assert.equal(result.details?.error, "worktree list unreadable");
+  });
+
+  test("rejects a branch mismatch with a typed failure", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => [{ path: unitRoot, branch: "milestone/M001" }],
+      getCurrentBranch: () => "feature/unexpected",
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+      expectedBranch: "milestone/M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "branch-mismatch");
+    assert.equal(result.details?.branch, "feature/unexpected");
+  });
+
+  test("converts branch resolution failures into typed failures", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => [{ path: unitRoot, branch: "milestone/M001" }],
+      getCurrentBranch: () => {
+        throw new Error("branch unreadable");
+      },
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+      expectedBranch: "milestone/M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-git-probe-failed");
+    assert.equal(result.details?.expectedBranch, "milestone/M001");
+    assert.equal(result.details?.error, "branch unreadable");
+  });
+
+  test("fails closed when branch verification lacks a branch probe", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => [{ path: unitRoot, branch: "milestone/M001" }],
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+      expectedBranch: "milestone/M001",
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "worktree-git-probe-failed");
+    assert.equal(result.details?.error, "getCurrentBranch dep not provided");
+  });
+
+  test("rejects an empty worktree when the project root has content", () => {
+    const safety = createWorktreeSafetyModule({
+      existsSync: () => true,
+      lstatSync: () => ({ isFile: () => true }),
+      listRegisteredWorktrees: () => [{ path: unitRoot, branch: "milestone/M001" }],
+    });
+
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot,
+      unitRoot,
+      milestoneId: "M001",
+      emptyWorktreeWithProjectContent: true,
+    });
+
+    assert.equal(result.ok, false);
+    assert.equal(result.kind, "empty-worktree-with-project-content");
+  });
+
+  test("default adapter proves registered worktree and current branch", (t) => {
+    const base = makeBaseRepo();
+    t.after(() => rmSync(base, { recursive: true, force: true }));
+    createWorktree(base, "M001", { branch: "milestone/M001" });
+
+    const safety = createWorktreeSafetyModule();
+    const result = safety.validateUnitRoot({
+      unitType: "execute-task",
+      unitId: "M001/S01/T01",
+      writeScope: "source-writing",
+      projectRoot: base,
+      unitRoot: worktreePath(base, "M001"),
+      milestoneId: "M001",
+      expectedBranch: "milestone/M001",
+    });
+
+    assert.equal(result.ok, true);
+    assert.equal(result.kind, "safe");
+    assert.equal(result.branch, "milestone/M001");
+  });
+});

package/src/resources/extensions/gsd/tests/worktree-state-projection.test.ts

@@ -0,0 +1,120 @@
+// Project/App: GSD-2
+// File Purpose: Worktree State Projection Module — typed-Interface contract tests for projectRootToWorktree (ADR-016).
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync, mkdirSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { WorktreeStateProjection } from "../worktree-state-projection.js";
+import { createWorkspace, scopeMilestone } from "../workspace.js";
+
+// ─── Helpers ─────────────────────────────────────────────────────────────────
+
+function makeProjectRoot(): { dir: string; cleanup: () => void } {
+  const dir = mkdtempSync(join(tmpdir(), "gsd-projection-"));
+  // .gsd directory is required for the workspace contract resolution
+  mkdirSync(join(dir, ".gsd"), { recursive: true });
+  return {
+    dir,
+    cleanup: () => rmSync(dir, { recursive: true, force: true }),
+  };
+}
+
+// ─── projectRootToWorktree — Module contract ────────────────────────────────
+
+test("WorktreeStateProjection can be constructed without arguments", () => {
+  const projection = new WorktreeStateProjection();
+  assert.ok(projection);
+  assert.equal(typeof projection.projectRootToWorktree, "function");
+});
+
+test("projectRootToWorktree accepts a MilestoneScope without throwing on same-path scope", () => {
+  const { dir, cleanup } = makeProjectRoot();
+  try {
+    const workspace = createWorkspace(dir);
+    const scope = scopeMilestone(workspace, "M001");
+    const projection = new WorktreeStateProjection();
+
+    // When the scope's workspace has no worktreeRoot (project-only mode),
+    // the underlying syncProjectRootToWorktree fast-paths to a no-op when
+    // both endpoints resolve to the same path. The Module must accept
+    // this scope and complete silently.
+    assert.doesNotThrow(() => projection.projectRootToWorktree(scope));
+  } finally {
+    cleanup();
+  }
+});
+
+test("projectRootToWorktree is idempotent — repeated calls do not throw", () => {
+  const { dir, cleanup } = makeProjectRoot();
+  try {
+    const workspace = createWorkspace(dir);
+    const scope = scopeMilestone(workspace, "M001");
+    const projection = new WorktreeStateProjection();
+
+    projection.projectRootToWorktree(scope);
+    projection.projectRootToWorktree(scope);
+    assert.ok(true, "two calls did not throw");
+  } finally {
+    cleanup();
+  }
+});
+
+// ─── projectWorktreeToRoot — Module contract ────────────────────────────────
+
+test("projectWorktreeToRoot exists and accepts a MilestoneScope", () => {
+  const projection = new WorktreeStateProjection();
+  assert.equal(typeof projection.projectWorktreeToRoot, "function");
+});
+
+test("projectWorktreeToRoot is non-fatal on same-path scope (project-only mode)", () => {
+  const { dir, cleanup } = makeProjectRoot();
+  try {
+    const workspace = createWorkspace(dir);
+    const scope = scopeMilestone(workspace, "M001");
+    const projection = new WorktreeStateProjection();
+
+    // Same project root on both sides — sync helper fast-paths to no-op.
+    // Module must accept and complete silently.
+    assert.doesNotThrow(() => projection.projectWorktreeToRoot(scope));
+  } finally {
+    cleanup();
+  }
+});
+
+test("projectWorktreeToRoot is idempotent on repeated calls", () => {
+  const { dir, cleanup } = makeProjectRoot();
+  try {
+    const workspace = createWorkspace(dir);
+    const scope = scopeMilestone(workspace, "M001");
+    const projection = new WorktreeStateProjection();
+
+    projection.projectWorktreeToRoot(scope);
+    projection.projectWorktreeToRoot(scope);
+    assert.ok(true, "two calls did not throw");
+  } finally {
+    cleanup();
+  }
+});
+
+// ─── finalizeProjectionForMerge — Module contract ────────────────────────────
+
+test("finalizeProjectionForMerge exists and accepts a MilestoneScope", () => {
+  const projection = new WorktreeStateProjection();
+  assert.equal(typeof projection.finalizeProjectionForMerge, "function");
+});
+
+test("finalizeProjectionForMerge returns { synced } shape on same-path scope", () => {
+  const { dir, cleanup } = makeProjectRoot();
+  try {
+    const workspace = createWorkspace(dir);
+    const scope = scopeMilestone(workspace, "M001");
+    const projection = new WorktreeStateProjection();
+
+    // Project-only mode (no worktreeRoot) — finalize fast-paths to {synced: []}
+    const result = projection.finalizeProjectionForMerge(scope);
+    assert.ok(Array.isArray(result.synced));
+  } finally {
+    cleanup();
+  }
+});

package/src/resources/extensions/gsd/tests/write-gate.test.ts

@@ -1,3 +1,4 @@
+// GSD2 - Write gate regression tests.
 /**
  * Unit tests for the CONTEXT.md write-gate (D031 guard chain).
  *
@@ -11,7 +12,7 @@
 
 import test, { afterEach } from 'node:test';
 import assert from 'node:assert/strict';
-import { mkdirSync, writeFileSync, unlinkSync, existsSync, rmSync } from 'node:fs';
+import { mkdirSync, writeFileSync, unlinkSync, existsSync, rmSync, symlinkSync } from 'node:fs';
 import { join } from 'node:path';
 import { tmpdir } from 'node:os';
 import { randomUUID } from 'node:crypto';
@@ -685,3 +686,41 @@ test('write-gate: loadWriteGateSnapshot returns empty default when persist file
     } catch { /* swallow */ }
   }
 });
+
+// ─── Scenario 30: write-gate persistence recreates dangling external .gsd target ──
+
+test('write-gate: resetWriteGateState persists through dangling .gsd symlink', () => {
+  const base = join(tmpdir(), `gsd-write-gate-dangling-${randomUUID()}`);
+  const externalState = join(tmpdir(), `gsd-write-gate-external-${randomUUID()}`);
+  const stateFilePath = join(base, '.gsd', 'runtime', 'write-gate-state.json');
+  const originalEnv = process.env.GSD_PERSIST_WRITE_GATE_STATE;
+
+  try {
+    process.env.GSD_PERSIST_WRITE_GATE_STATE = '1';
+    mkdirSync(base, { recursive: true });
+    symlinkSync(externalState, join(base, '.gsd'), 'junction');
+    assert.strictEqual(existsSync(join(base, '.gsd')), false, 'precondition: .gsd symlink target is missing');
+
+    resetWriteGateState(base);
+
+    assert.ok(existsSync(externalState), 'missing external state target was recreated');
+    assert.ok(existsSync(stateFilePath), 'write-gate snapshot persisted under .gsd/runtime');
+    assert.deepEqual(loadWriteGateSnapshot(base), {
+      verifiedDepthMilestones: [],
+      verifiedApprovalGates: [],
+      activeQueuePhase: false,
+      pendingGateId: null,
+    });
+  } finally {
+    if (originalEnv === undefined) {
+      delete process.env.GSD_PERSIST_WRITE_GATE_STATE;
+    } else {
+      process.env.GSD_PERSIST_WRITE_GATE_STATE = originalEnv;
+    }
+    clearDiscussionFlowState(base);
+    try {
+      rmSync(base, { recursive: true, force: true });
+      rmSync(externalState, { recursive: true, force: true });
+    } catch { /* swallow */ }
+  }
+});

package/src/resources/extensions/gsd/tests/zero-slice-roadmap-guided.test.ts

@@ -1,19 +1,25 @@
-/**
- * Regression test for #3441: guided flow must treat a roadmap with zero
- * parseable slices the same as no roadmap — offer "Create roadmap" not "Go auto".
- */
+// GSD-2 — Guided roadmap slice detection regression tests.
+
 import { test } from "node:test";
 import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
 
-test("guided-flow checks roadmap slice count before offering auto (#3441)", () => {
-  const src = readFileSync(
-    join(import.meta.dirname, "..", "guided-flow.ts"),
-    "utf-8",
+import { _roadmapHasParseableSlicesForTest } from "../guided-flow.ts";
+
+test("guided flow treats placeholder roadmaps with zero slices as not runnable", () => {
+  assert.equal(
+    _roadmapHasParseableSlicesForTest("# M001 Roadmap\n\nPlanning notes only.\n"),
+    false,
   );
-  assert.ok(
-    src.includes("roadmapHasSlices") || src.includes("parseRoadmapSlices"),
-    "Guided flow must parse roadmap for slices before deciding which options to show",
+});
+
+test("guided flow accepts roadmaps with parseable slices", () => {
+  assert.equal(
+    _roadmapHasParseableSlicesForTest([
+      "# M001 Roadmap",
+      "",
+      "## Slices",
+      "- [ ] **S01: First slice** `risk:low` `depends:[]`",
+    ].join("\n")),
+    true,
   );
 });

package/src/resources/extensions/gsd/tool-contract.ts

@@ -0,0 +1,82 @@
+// Project/App: GSD-2
+// File Purpose: ADR-015 Tool Contract module for Unit prompt, policy, and tool parity.
+
+import {
+  resolveManifest,
+  type ArtifactKey,
+  type ContextModePolicy,
+  type ToolsPolicy,
+} from "./unit-context-manifest.js";
+import { getRequiredWorkflowToolsForAutoUnit } from "./workflow-mcp.js";
+
+export interface UnitToolContract {
+  unitType: string;
+  contextMode: ContextModePolicy;
+  toolsPolicy: ToolsPolicy;
+  requiredWorkflowTools: readonly string[];
+  promptObligations: readonly string[];
+  validationRules: readonly string[];
+  closeoutTools: readonly string[];
+  artifacts: {
+    inline: readonly ArtifactKey[];
+    excerpt: readonly ArtifactKey[];
+    onDemand: readonly ArtifactKey[];
+  };
+}
+
+export type ToolContractResult =
+  | { ok: true; contract: UnitToolContract }
+  | { ok: false; reason: "unknown-unit-type" | "missing-closeout-tool"; detail: string };
+
+export function compileUnitToolContract(unitType: string): ToolContractResult {
+  const manifest = resolveManifest(unitType);
+  if (!manifest) {
+    return {
+      ok: false,
+      reason: "unknown-unit-type",
+      detail: `No Unit manifest is registered for ${unitType}`,
+    };
+  }
+
+  const requiredWorkflowTools = getRequiredWorkflowToolsForAutoUnit(unitType);
+  const closeoutTools = requiredWorkflowTools.filter((tool) =>
+    /^gsd_(?:task|slice|milestone|complete|validate|save|summary)/.test(tool),
+  );
+
+  if (requiresCloseoutTool(unitType) && closeoutTools.length === 0) {
+    return {
+      ok: false,
+      reason: "missing-closeout-tool",
+      detail: `${unitType} has no closeout workflow tool`,
+    };
+  }
+
+  return {
+    ok: true,
+    contract: {
+      unitType,
+      contextMode: manifest.contextMode,
+      toolsPolicy: manifest.tools,
+      requiredWorkflowTools,
+      promptObligations: [
+        `context-mode:${manifest.contextMode}`,
+        `tools-policy:${manifest.tools.mode}`,
+      ],
+      validationRules: [
+        "unit-manifest-present",
+        "workflow-tool-surface-present",
+        ...(requiresCloseoutTool(unitType) ? ["closeout-tool-present"] : []),
+      ],
+      closeoutTools,
+      artifacts: {
+        inline: manifest.artifacts.inline,
+        excerpt: manifest.artifacts.excerpt,
+        onDemand: manifest.artifacts.onDemand,
+      },
+    },
+  };
+}
+
+function requiresCloseoutTool(unitType: string): boolean {
+  return /^(execute-task|reactive-execute|complete-slice|validate-milestone|complete-milestone|run-uat|gate-evaluate)$/.test(unitType);
+}