gloomberb 0.9.9 → 0.10.0

package/src/plugins/catalog-backend.ts

@@ -0,0 +1,42 @@
+import type { GloomPlugin } from "../types/plugin";
+import { aiPlugin } from "./builtin/ai";
+import { alertsPlugin } from "./builtin/alerts";
+import { gloomberbCloudPlugin } from "./builtin/cloud";
+import {
+  applicationPlugin,
+  brokerPlugin,
+  macroPlugin,
+  marketOverviewPlugin,
+  portfolioPlugin,
+} from "./builtin/composite-plugins";
+import { debugPlugin } from "./builtin/debug";
+import { newsPlugin } from "./builtin/news";
+import { notesPlugin } from "./builtin/notes";
+import { substackPlugin } from "./builtin/substack";
+import { tickerResearchBackendPlugin } from "./builtin/ticker-research-backend-plugin";
+import { yahooPlugin } from "./builtin/yahoo";
+import { ibkrPlugin } from "./ibkr";
+import { predictionMarketsBackendPlugin } from "./prediction-markets/backend-plugin";
+
+const desktopBackendPlugins: GloomPlugin[] = [
+  yahooPlugin,
+  gloomberbCloudPlugin,
+  portfolioPlugin,
+  tickerResearchBackendPlugin,
+  brokerPlugin,
+  ibkrPlugin,
+  applicationPlugin,
+  newsPlugin,
+  substackPlugin,
+  notesPlugin,
+  aiPlugin,
+  predictionMarketsBackendPlugin,
+  marketOverviewPlugin,
+  macroPlugin,
+  alertsPlugin,
+  debugPlugin,
+];
+
+export function getDesktopBackendPlugins(): GloomPlugin[] {
+  return desktopBackendPlugins;
+}

package/src/plugins/catalog-ui.ts

@@ -1,43 +1,35 @@
 import type { GloomPlugin } from "../types/plugin";
-import { portfolioListPlugin } from "./builtin/portfolio-list";
 import { newsPlugin } from "./builtin/news";
 import { notesPlugin } from "./builtin/notes";
 import { substackPlugin } from "./builtin/substack";
 import { aiPlugin } from "./builtin/ai";
 import { gloomberbCloudPlugin } from "./builtin/cloud";
-import { changelogPlugin } from "./builtin/changelog";
-import { helpPlugin } from "./builtin/help";
 import { ibkrPlugin } from "./ibkr";
-import { layoutManagerPlugin } from "./builtin/layout-manager";
 import { predictionMarketsPlugin } from "./prediction-markets";
-import { analyticsPlugin } from "./builtin/analytics";
 import { alertsPlugin } from "./builtin/alerts";
-import { kellySizerPlugin } from "./builtin/kelly-sizer";
 import {
+  applicationPlugin,
   brokerPlugin,
   macroPlugin,
   marketOverviewPlugin,
-  tickerResearchPlugin,
-} from "./builtin/plugin-groups";
+  portfolioPlugin,
+} from "./builtin/composite-plugins";
+import { tickerResearchPlugin } from "./builtin/ticker-research-plugin";
 
 export const uiBuiltinPlugins: GloomPlugin[] = [
   gloomberbCloudPlugin,
-  portfolioListPlugin,
+  portfolioPlugin,
   tickerResearchPlugin,
   brokerPlugin,
   ibkrPlugin,
-  layoutManagerPlugin,
+  applicationPlugin,
   newsPlugin,
   substackPlugin,
   notesPlugin,
   aiPlugin,
-  changelogPlugin,
-  helpPlugin,
   predictionMarketsPlugin,
   marketOverviewPlugin,
   macroPlugin,
-  analyticsPlugin,
-  kellySizerPlugin,
   alertsPlugin,
 ];
 

package/src/plugins/ibkr/instance-selection.test.ts

@@ -35,7 +35,6 @@ function createConfig(overrides: Partial<AppConfig> = {}): AppConfig {
     pluginConfig: {},
     theme: "amber",
     chartPreferences: {
-      defaultRenderMode: "area",
       renderer: "auto",
     },
     recentTickers: [],

package/src/plugins/ownership.ts

@@ -0,0 +1,143 @@
+const BUILTIN_PLUGIN_OWNER_ALIASES: Record<string, string> = {
+  analytics: "portfolio",
+  "broker-manager": "broker",
+  changelog: "application",
+  "company-research": "ticker-research",
+  "chart-composer": "ticker-research",
+  "comparison-chart": "ticker-research",
+  correlation: "market-overview",
+  "earnings-calendar": "macro",
+  "fear-greed": "market-overview",
+  "fx-matrix": "market-overview",
+  help: "application",
+  holders: "ticker-research",
+  insider: "ticker-research",
+  "kelly-sizer": "portfolio",
+  "layout-manager": "application",
+  "macro-tv": "macro",
+  "market-heatmap": "market-overview",
+  "market-movers": "market-overview",
+  options: "ticker-research",
+  "portfolio-list": "portfolio",
+  research: "ticker-research",
+  sectors: "market-overview",
+  sec: "ticker-research",
+  thirteenf: "ticker-research",
+  "ticker-detail": "ticker-research",
+  "world-indices": "market-overview",
+};
+
+const NON_TOGGLEABLE_BUILTIN_PLUGIN_IDS = new Set([
+  "application",
+  "changelog",
+  "help",
+  "layout-manager",
+]);
+
+const LEGACY_MODULE_IDS_BY_OWNER: Record<string, readonly string[]> = {
+  application: ["layout-manager", "help", "changelog"],
+  portfolio: ["portfolio-list", "analytics", "kelly-sizer"],
+};
+
+export function normalizeBuiltinPluginOwnerId(pluginId: string): string {
+  return BUILTIN_PLUGIN_OWNER_ALIASES[pluginId] ?? pluginId;
+}
+
+export function isReservedBuiltinPluginId(pluginId: string): boolean {
+  return Object.prototype.hasOwnProperty.call(BUILTIN_PLUGIN_OWNER_ALIASES, pluginId);
+}
+
+export function isNonToggleableBuiltinPluginId(pluginId: string): boolean {
+  return NON_TOGGLEABLE_BUILTIN_PLUGIN_IDS.has(pluginId);
+}
+
+export function normalizeBuiltinDisabledPluginIds(pluginIds: readonly string[]): string[] {
+  return [...new Set(
+    pluginIds
+      .filter((pluginId) => !isNonToggleableBuiltinPluginId(pluginId))
+      .map(normalizeBuiltinPluginOwnerId)
+      .filter((pluginId) => !isNonToggleableBuiltinPluginId(pluginId)),
+  )];
+}
+
+export function normalizeBuiltinPluginStateMap(
+  value: Record<string, Record<string, unknown>>,
+): Record<string, Record<string, unknown>> {
+  return Object.fromEntries(
+    Object.entries(value).reduce<Array<[string, Record<string, unknown>]>>((entries, [pluginId, state]) => {
+      const normalizedPluginId = normalizeBuiltinPluginOwnerId(pluginId);
+      const existing = entries.find(([entryPluginId]) => entryPluginId === normalizedPluginId);
+      if (existing) {
+        existing[1] = pluginId === normalizedPluginId
+          ? { ...existing[1], ...state }
+          : { ...state, ...existing[1] };
+      } else {
+        entries.push([normalizedPluginId, { ...state }]);
+      }
+      return entries;
+    }, []),
+  );
+}
+
+/**
+ * Keeps config snapshots readable by clients from before built-in modules were
+ * consolidated. Current clients normalize these aliases back to their owner.
+ */
+export function addLegacyBuiltinPluginOwnerAliases(
+  value: Record<string, Record<string, unknown>>,
+): Record<string, Record<string, unknown>> {
+  const output = Object.fromEntries(
+    Object.entries(value).map(([pluginId, state]) => [pluginId, { ...state }]),
+  );
+  for (const [ownerId, legacyIds] of Object.entries(LEGACY_MODULE_IDS_BY_OWNER)) {
+    const ownerState = value[ownerId];
+    if (!ownerState) continue;
+    for (const legacyId of legacyIds) {
+      output[legacyId] ??= { ...ownerState };
+    }
+  }
+  return output;
+}
+
+export function addLegacyBuiltinDisabledPluginAliases(pluginIds: readonly string[]): string[] {
+  const output = new Set(pluginIds);
+  for (const pluginId of pluginIds) {
+    for (const legacyId of LEGACY_MODULE_IDS_BY_OWNER[pluginId] ?? []) {
+      output.add(legacyId);
+    }
+  }
+  return [...output];
+}
+
+function isPluginStateMap(value: unknown): value is Record<string, Record<string, unknown>> {
+  return !!value
+    && typeof value === "object"
+    && !Array.isArray(value)
+    && Object.values(value).every((entry) => !!entry && typeof entry === "object" && !Array.isArray(entry));
+}
+
+export function normalizeBuiltinPaneStatePluginOwners(
+  paneState: Record<string, Record<string, unknown>>,
+): Record<string, Record<string, unknown>> {
+  return Object.fromEntries(
+    Object.entries(paneState).map(([paneId, state]) => [
+      paneId,
+      isPluginStateMap(state.pluginState)
+        ? { ...state, pluginState: normalizeBuiltinPluginStateMap(state.pluginState) }
+        : state,
+    ]),
+  );
+}
+
+export function addLegacyBuiltinPaneStatePluginAliases(
+  paneState: Record<string, Record<string, unknown>>,
+): Record<string, Record<string, unknown>> {
+  return Object.fromEntries(
+    Object.entries(paneState).map(([paneId, state]) => [
+      paneId,
+      isPluginStateMap(state.pluginState)
+        ? { ...state, pluginState: addLegacyBuiltinPluginOwnerAliases(state.pluginState) }
+        : state,
+    ]),
+  );
+}

package/src/plugins/prediction-markets/backend-plugin.ts

@@ -0,0 +1,19 @@
+import type { GloomPlugin } from "../../types/plugin";
+import {
+  attachPredictionMarketsPersistence,
+  resetPredictionMarketsPersistence,
+} from "./services/fetch";
+
+export const predictionMarketsBackendPlugin: GloomPlugin = {
+  id: "prediction-markets",
+  name: "Prediction Markets",
+  version: "1.0.0",
+  description: "Browse prediction markets (Polymarket and Kalshi).",
+  toggleable: true,
+  setup(ctx) {
+    attachPredictionMarketsPersistence(ctx.persistence);
+  },
+  dispose() {
+    resetPredictionMarketsPersistence();
+  },
+};

package/src/plugins/prediction-markets/chart.test.tsx

@@ -14,7 +14,6 @@ import { getNativeSurfaceManager } from "../../components/chart/native/surface/m
 import { PredictionMarketChart } from "./chart";
 
 const TEST_PANE_ID = "prediction-scroll:test";
-const SURFACE_ID = `chart-surface:${TEST_PANE_ID}:compact:base`;
 
 let testSetup: Awaited<ReturnType<typeof createTestRenderer>> | undefined;
 let root: ReturnType<typeof createRoot> | undefined;
@@ -96,10 +95,10 @@ describe("PredictionMarketChart kitty scrolling", () => {
   test("creates a native chart surface when scrolled into view", async () => {
     actEnvironment.IS_REACT_ACT_ENVIRONMENT = true;
     testSetup = await createTestRenderer({ width: 100, height: 24 });
-    (testSetup.renderer as { _capabilities: unknown })._capabilities = {
+    (testSetup.renderer as unknown as { _capabilities: unknown })._capabilities = {
       kitty_graphics: true,
     };
-    (testSetup.renderer as { _resolution: unknown })._resolution = {
+    (testSetup.renderer as unknown as { _resolution: unknown })._resolution = {
       width: 1000,
       height: 720,
     };
@@ -116,13 +115,16 @@ describe("PredictionMarketChart kitty scrolling", () => {
         string,
         {
           snapshot: {
+            paneId: string;
             visibleRect: { x: number; y: number; width: number; height: number } | null;
           };
         }
       >;
     };
 
-    const hiddenSurface = manager.surfaces.get(SURFACE_ID);
+    const findPredictionSurface = () => [...manager.surfaces.values()]
+      .find((surface) => surface.snapshot.paneId === TEST_PANE_ID);
+    const hiddenSurface = findPredictionSurface();
     expect(hiddenSurface).toBeUndefined();
 
     act(() => {
@@ -131,7 +133,7 @@ describe("PredictionMarketChart kitty scrolling", () => {
 
     await flushFrames();
 
-    const visibleSurface = manager.surfaces.get(SURFACE_ID);
+    const visibleSurface = findPredictionSurface();
     expect(visibleSurface).toBeDefined();
     expect(visibleSurface?.snapshot.visibleRect).not.toBeNull();
     expect(testSetup.captureCharFrame()).toContain("1M");

package/src/plugins/prediction-markets/chart.tsx

@@ -1,7 +1,11 @@
 import { Box, Text } from "../../ui";
 import { useMemo } from "react";
 import { TextAttributes } from "../../ui";
-import { StockChart } from "../../components/chart/stock-chart";
+import {
+  CompositeChart,
+  pricePointsToResolvedSeries,
+} from "../../components/chart/composite";
+import type { ChartMouseEvent } from "../../components/chart/core/pointer";
 import { EmptyState } from "../../components/ui/status";
 import { colors } from "../../theme/colors";
 import { formatNumber, formatPercentRaw } from "../../utils/format";
@@ -50,10 +54,13 @@ function PredictionRangeTabs({
         return (
           <Box
             key={entry}
-            onMouseDown={(event) => {
-              event.preventDefault();
+            onMouseDown={(event: ChartMouseEvent) => {
+              event.preventDefault?.();
               onRangeSelect(entry);
             }}
+            cursor="pointer"
+            data-gloom-interactive="true"
+            data-gloom-label={`${entry} prediction history`}
           >
             <Text
               fg={active ? colors.textBright : colors.textDim}
@@ -113,6 +120,15 @@ export function PredictionMarketChart({
   const delta = first && last ? last.close - first.close : 0;
   const deltaPct = first?.close ? (delta / first.close) * 100 : 0;
   const chartHeight = Math.max(height - 1, 2);
+  const priceSeries = pricePointsToResolvedSeries(pricePoints, {
+    id: "prediction-price",
+    label: "YES price",
+    color: delta > 0 ? colors.positive : delta < 0 ? colors.negative : colors.text,
+    unit: "USD",
+    style: "area",
+    axis: "right",
+    panelId: "price",
+  });
 
   return (
     <Box flexDirection="column" height={height}>
@@ -135,13 +151,15 @@ export function PredictionMarketChart({
         </Text>
       </Box>
 
-      <StockChart
+      <CompositeChart
         width={width}
         height={chartHeight}
         focused={false}
-        compact
-        historyOverride={pricePoints}
-        currencyOverride="USD"
+        interactive={false}
+        series={[priceSeries]}
+        panels={[{ id: "price" }]}
+        axisWidth={8}
+        showLegend={false}
       />
     </Box>
   );

package/src/plugins/registry/index.test.ts

@@ -5,6 +5,11 @@ import { createDefaultConfig } from "../../types/config";
 import type { DataProvider } from "../../types/data-provider";
 import type { GloomPlugin, GloomPluginContext } from "../../types/plugin";
 import { assetDataProvider } from "../../capabilities";
+import {
+  applicationPlugin,
+  macroPlugin,
+  portfolioPlugin,
+} from "../builtin/composite-plugins";
 import { PluginRegistry } from "./index";
 
 const dataProvider: DataProvider = {
@@ -71,6 +76,18 @@ afterEach(() => {
 });
 
 describe("PluginRegistry lifecycle", () => {
+  test("rejects retired built-in module ids", async () => {
+    const registry = createRegistry();
+
+    await expect(registry.register({
+      id: "analytics",
+      name: "Conflicting Analytics",
+      version: "1.0.0",
+    })).rejects.toThrow("Plugin id is reserved by a built-in module: analytics");
+
+    expect(registry.allPlugins.has("analytics")).toBe(false);
+  });
+
   test("rolls back rejected registrations and always removes owned contributions", async () => {
     const registry = createRegistry();
     const pane = {
@@ -113,6 +130,40 @@ describe("PluginRegistry lifecycle", () => {
   });
 });
 
+describe("built-in composite plugin ownership", () => {
+  test("registers modules through their one top-level owner", async () => {
+    const registry = createRegistry();
+    await registry.register(portfolioPlugin);
+    await registry.register(applicationPlugin);
+    await registry.register(macroPlugin);
+
+    expect(registry.getPluginPaneIds("portfolio")).toEqual(expect.arrayContaining([
+      "portfolio-list",
+      "analytics",
+      "kelly-sizer",
+    ]));
+    expect(registry.getPluginPaneIds("application")).toEqual(expect.arrayContaining([
+      "help",
+      "changelog",
+    ]));
+    expect(registry.getPluginPaneIds("macro")).toEqual(expect.arrayContaining([
+      "econ-calendar",
+      "yield-curve",
+      "earnings-calendar",
+      "macro-tv",
+    ]));
+    expect(registry.getPaneTemplatePluginId("macro-tv-pane")).toBe("macro");
+    expect(registry.getPanePluginId("analytics")).toBe("portfolio");
+    expect(registry.getPanePluginId("help")).toBe("application");
+    expect(registry.getPanePluginId("macro-tv")).toBe("macro");
+    expect(registry.getCommandPluginId("earnings-monitor-shortcut")).toBe("macro");
+    expect(registry.getCommandPluginId("gridlock-all")).toBe("application");
+    expect(registry.allPlugins.has("analytics")).toBe(false);
+    expect(registry.allPlugins.has("kelly-sizer")).toBe(false);
+    expect(registry.allPlugins.has("changelog")).toBe(false);
+  });
+});
+
 describe("PluginRegistry context menu providers", () => {
   test("registers and unregisters context menu providers", async () => {
     const registry = createRegistry();

package/src/plugins/registry/index.ts

@@ -56,6 +56,7 @@ import {
 } from "./shared";
 import { RegistryResumeStateListeners } from "./plugin-state";
 import { cloudSyncController } from "../../sync/controller";
+import { isReservedBuiltinPluginId } from "../ownership";
 
 interface PluginRegistryOptions {
   enableCapabilityHandlers?: boolean;
@@ -367,6 +368,10 @@ export class PluginRegistry implements PluginRuntimeAccess {
     return this.contributions.commandOwners.get(commandId);
   }
 
+  getPanePluginId(paneId: string): string | undefined {
+    return this.contributions.paneOwners.get(paneId);
+  }
+
   getPaneTemplatePluginId(templateId: string): string | undefined {
     return this.contributions.paneTemplateOwners.get(templateId);
   }
@@ -441,6 +446,9 @@ export class PluginRegistry implements PluginRuntimeAccess {
 
   async register(plugin: GloomPlugin): Promise<void> {
     this.registryLog.info(`Registering plugin: ${plugin.id} v${plugin.version ?? "?"}`);
+    if (isReservedBuiltinPluginId(plugin.id)) {
+      throw new Error(`Plugin id is reserved by a built-in module: ${plugin.id}`);
+    }
     if (this.plugins.has(plugin.id)) throw new Error(`Plugin already registered: ${plugin.id}`);
     this.plugins.set(plugin.id, plugin);
     try {

package/src/plugins/registry/pane-settings.ts

@@ -82,7 +82,7 @@ export function resolveRegistryPaneSettings({
   };
   if (pluginId) {
     for (const field of settingsDef.fields) {
-      if (field.storage !== "plugin") continue;
+      if (field.type === "action" || field.storage !== "plugin") continue;
       const configValue = getConfigState(pluginId, field.key);
       if (configValue === null) {
         delete resolvedSettings[field.key];

package/src/plugins/runtime/index.test.tsx

@@ -223,7 +223,7 @@ describe("plugin runtime hooks", () => {
     }
 
     testSetup = await testRender(
-      <PluginRenderProvider pluginId="help" runtime={runtime}>
+      <PluginRenderProvider pluginId="application" runtime={runtime}>
         <HookProbe />
       </PluginRenderProvider>,
       { width: 40, height: 5 },
@@ -267,7 +267,7 @@ describe("plugin runtime hooks", () => {
 
     testSetup = await testRender(
       <PaneInstanceProvider paneId="comparison-chart:main">
-        <PluginRenderProvider pluginId="comparison-chart" runtime={runtime}>
+        <PluginRenderProvider pluginId="market-overview" runtime={runtime}>
           <HookProbe />
         </PluginRenderProvider>
       </PaneInstanceProvider>,

package/src/remote/app-host.tsx

@@ -1,5 +1,5 @@
-import { useEffect, useMemo } from "react";
-import type { Dispatch } from "react";
+import { createContext, useContext, useEffect, useMemo } from "react";
+import type { Dispatch, ReactNode } from "react";
 import type { PluginRegistry } from "../plugins/registry";
 import type { AppAction, AppState } from "../state/app/context";
 import type { DesktopWindowBridge } from "../types/desktop-window";
@@ -9,13 +9,21 @@ import type { RemoteControlRequest, RemoteControlResponse } from "./types";
 
 export type RemoteControlHandler = (request: RemoteControlRequest) => Promise<RemoteControlResponse>;
 
+const RemoteControlHandlerContext = createContext<RemoteControlHandler | null>(null);
+
+export function useRemoteControlHandler(): RemoteControlHandler | null {
+  return useContext(RemoteControlHandlerContext);
+}
+
 export interface RemoteControlAdapter {
+  handleRequest?: RemoteControlHandler;
   startServer?(options: { dataDir: string; handle: RemoteControlHandler }): void | (() => void | Promise<void>);
   registerHandler?(handler: RemoteControlHandler | null): void | (() => void);
 }
 
 interface RemoteControlHostProps {
   adapter?: RemoteControlAdapter;
+  children: ReactNode;
   dispatch: Dispatch<AppAction>;
   getState: () => AppState;
   pluginRegistry: PluginRegistry;
@@ -24,6 +32,7 @@ interface RemoteControlHostProps {
 
 export function RemoteControlHost({
   adapter,
+  children,
   dispatch,
   getState,
   pluginRegistry,
@@ -73,5 +82,9 @@ export function RemoteControlHost({
     };
   }, [adapter, controller]);
 
-  return null;
+  return (
+    <RemoteControlHandlerContext value={adapter?.handleRequest ?? (adapter ? controller.handle : null)}>
+      {children}
+    </RemoteControlHandlerContext>
+  );
 }