gloomberb 0.9.9 → 0.10.0

package/src/plugins/builtin/chat/message/terminal.tsx

@@ -1,4 +1,5 @@
 import { Box, Text } from "../../../../ui";
+import { t } from "../../../../i18n";
 import { MESSAGE_ACTION_WIDTH, formatInlinePreview, getMessageBodyTokenLines } from "../layout";
 import { ChatActionChip } from "./action-chip";
 import { ResponsiveTickerBadgeText } from "./inline-tokens";
@@ -38,6 +39,7 @@ export function TerminalChatMessage({
   const showInlineEditAction = !state.grouped && state.showReplyAction && canEditMessage;
   const showGroupedReplyAction = state.grouped && state.showReplyAction;
   const showGroupedEditAction = state.grouped && state.showReplyAction && canEditMessage;
+  const authorLabel = msg.user.username ?? "anon";
   const groupedActionWidth = MESSAGE_ACTION_WIDTH * Number(showGroupedReplyAction) + MESSAGE_ACTION_WIDTH * Number(showGroupedEditAction);
   const setHovered = () => setHoveredIdx((current) => (current === index ? current : index));
   const clearHovered = () => setHoveredIdx((current) => (current === index ? null : current));
@@ -60,7 +62,7 @@ export function TerminalChatMessage({
             if (msg.replyToId) jumpToMessage(msg.replyToId);
           }}
         >
-          <Text fg={state.replyMetaColor}>reply </Text>
+          <Text fg={state.replyMetaColor}>{`${t("reply")} `}</Text>
           <Text fg={state.replyAuthorColor}>{msg.replyTo.user.username}: </Text>
           <Text fg={state.replyMetaColor}>
             {formatInlinePreview(
@@ -77,14 +79,21 @@ export function TerminalChatMessage({
           height={1}
           paddingLeft={1}
         >
-          <Text
-            fg={state.authorColor}
-            attributes={state.authorAttributes}
+          <Box
+            width={authorLabel.length}
+            height={1}
             onMouseOver={() => onUserHover(msg.user)}
+            onMouseMove={() => onUserHover(msg.user)}
             onMouseOut={onUserHoverEnd}
+            style={{ cursor: "pointer" }}
           >
-            {msg.user.username ?? "anon"}
-          </Text>
+            <Text
+              fg={state.authorColor}
+              attributes={state.authorAttributes}
+            >
+              {authorLabel}
+            </Text>
+          </Box>
           <Text fg={state.headerStatusColor}> {state.headerStatus}</Text>
           {(showInlineReplyAction || showInlineEditAction) && (
             <>
@@ -92,7 +101,7 @@ export function TerminalChatMessage({
               {showInlineReplyAction && (
                 <Box width={MESSAGE_ACTION_WIDTH} height={1}>
                   <ChatActionChip
-                    label="Reply"
+                    label={t("Reply")}
                     width={MESSAGE_ACTION_WIDTH}
                     emphasized={state.isSelected}
                     onPress={() => beginReplyTo(index)}
@@ -102,7 +111,7 @@ export function TerminalChatMessage({
               {showInlineEditAction && (
                 <Box width={MESSAGE_ACTION_WIDTH} height={1}>
                   <ChatActionChip
-                    label="Edit"
+                    label={t("Edit")}
                     width={MESSAGE_ACTION_WIDTH}
                     emphasized={state.isSelected}
                     onPress={() => beginEditMessage(index)}
@@ -138,7 +147,7 @@ export function TerminalChatMessage({
             <Box position="absolute" top={0} right={0} width={groupedActionWidth} height={1} flexDirection="row">
               {showGroupedReplyAction && (
                 <ChatActionChip
-                  label="Reply"
+                  label={t("Reply")}
                   width={MESSAGE_ACTION_WIDTH}
                   emphasized={state.isSelected}
                   onPress={() => beginReplyTo(index)}
@@ -146,7 +155,7 @@ export function TerminalChatMessage({
               )}
               {showGroupedEditAction && (
                 <ChatActionChip
-                  label="Edit"
+                  label={t("Edit")}
                   width={MESSAGE_ACTION_WIDTH}
                   emphasized={state.isSelected}
                   onPress={() => beginEditMessage(index)}

package/src/plugins/builtin/chat/pane-state.test.ts

@@ -0,0 +1,31 @@
+import { describe, expect, test } from "bun:test";
+import {
+  clearChatPaneTargetMessage,
+  setChatPaneChannel,
+} from "./pane-state";
+
+describe("chat pane state", () => {
+  test("preserves an exact-message target while the current channel metadata updates", () => {
+    expect(setChatPaneChannel({
+      channelId: "direct:vincent:mika",
+      targetMessageId: "message-42",
+    }, "direct:vincent:mika")).toEqual({
+      channelId: "direct:vincent:mika",
+      targetMessageId: "message-42",
+    });
+  });
+
+  test("clears an exact-message target when the user changes channels", () => {
+    expect(setChatPaneChannel({
+      channelId: "direct:vincent:mika",
+      targetMessageId: "message-42",
+    }, "everyone")).toEqual({ channelId: "everyone" });
+  });
+
+  test("clears the target only after the message jump is handled", () => {
+    expect(clearChatPaneTargetMessage({
+      channelId: "direct:vincent:mika",
+      targetMessageId: "message-42",
+    })).toEqual({ channelId: "direct:vincent:mika" });
+  });
+});

package/src/plugins/builtin/chat/pane-state.ts

@@ -0,0 +1,30 @@
+import { normalizeChannelId } from "./channels";
+
+type ChatPaneSettings = Record<string, unknown>;
+
+export function setChatPaneChannel(
+  settings: ChatPaneSettings | undefined,
+  nextChannelId: string,
+): ChatPaneSettings {
+  const normalizedNextChannelId = normalizeChannelId(nextChannelId);
+  const currentChannelId = typeof settings?.channelId === "string"
+    ? normalizeChannelId(settings.channelId)
+    : null;
+  const nextSettings = {
+    ...(settings ?? {}),
+    channelId: normalizedNextChannelId,
+  };
+
+  if (!currentChannelId || currentChannelId === normalizedNextChannelId) {
+    return nextSettings;
+  }
+
+  return clearChatPaneTargetMessage(nextSettings);
+}
+
+export function clearChatPaneTargetMessage(
+  settings: ChatPaneSettings | undefined,
+): ChatPaneSettings {
+  const { targetMessageId: _targetMessageId, ...nextSettings } = settings ?? {};
+  return nextSettings;
+}

package/src/plugins/builtin/chat/pane.tsx

@@ -16,6 +16,7 @@ import {
   LAST_VISITED_CHAT_CHANNEL_KEY,
   normalizeChannelId,
 } from "./channels";
+import { clearChatPaneTargetMessage, setChatPaneChannel } from "./pane-state";
 
 interface ChatPaneContentProps {
   width: number;
@@ -24,6 +25,8 @@ interface ChatPaneContentProps {
   channelId?: string;
   onChannelChange?: (channelId: string) => void;
   onChannelTitleChange?: (title: string) => void;
+  targetMessageId?: string;
+  onTargetMessageHandled?: () => void;
 }
 
 export function createChatPane(ChatContent: (props: ChatPaneContentProps) => ReactNode) {
@@ -33,6 +36,9 @@ export function createChatPane(ChatContent: (props: ChatPaneContentProps) => Rea
     const paneId = usePaneInstanceId();
     const pane = usePaneInstance();
     const rawPaneChannelId = typeof pane?.settings?.channelId === "string" ? pane.settings.channelId : null;
+    const targetMessageId = typeof pane?.settings?.targetMessageId === "string"
+      ? pane.settings.targetMessageId
+      : undefined;
     const lastVisitedChannelId = useAppSelector((state) => (
       (state.config.pluginConfig["gloomberb-cloud"]?.[LAST_VISITED_CHAT_CHANNEL_KEY] as string | undefined) ??
       DEFAULT_CHAT_CHANNEL_ID
@@ -58,10 +64,7 @@ export function createChatPane(ChatContent: (props: ChatPaneContentProps) => Rea
       const layout = updatePaneInstance(currentState.config.layout, paneId, (instance) => ({
         ...instance,
         title: nextTitleValue ?? instance.title,
-        settings: {
-          ...(instance.settings ?? {}),
-          channelId: nextChannelId,
-        },
+        settings: setChatPaneChannel(instance.settings, nextChannelId),
       }));
       const pluginConfig = {
         ...currentState.config.pluginConfig,
@@ -114,6 +117,24 @@ export function createChatPane(ChatContent: (props: ChatPaneContentProps) => Rea
       persistChatPaneState(channelId, nextTitle);
     }, [channelId, persistChatPaneState]);
 
+    const clearTargetMessage = useCallback(() => {
+      if (!targetMessageId) return;
+      const currentState = stateRef.current;
+      const layout = updatePaneInstance(currentState.config.layout, paneId, (instance) => ({
+        ...instance,
+        settings: clearChatPaneTargetMessage(instance.settings),
+      }));
+      const nextConfig = { ...currentState.config, layout };
+      const syncedConfig = syncConfigActiveLayoutState(
+        nextConfig,
+        currentState.paneState,
+        currentState.focusedPaneId,
+        currentState.activePanel,
+      );
+      dispatch({ type: "SET_CONFIG", config: syncedConfig });
+      scheduleConfigSave(syncedConfig);
+    }, [dispatch, paneId, stateRef, targetMessageId]);
+
     return (
       <ChatContent
         width={width}
@@ -122,6 +143,8 @@ export function createChatPane(ChatContent: (props: ChatPaneContentProps) => Rea
         channelId={channelId}
         onChannelChange={setChannelId}
         onChannelTitleChange={setChannelTitle}
+        targetMessageId={targetMessageId}
+        onTargetMessageHandled={clearTargetMessage}
       />
     );
   };

package/src/plugins/builtin/chat/profile-popover.ts

@@ -1,13 +1,35 @@
 import { useCallback, useEffect, useRef, useState } from "react";
-import type { ChatUserSummary } from "../../../api-client";
+import {
+  apiClient,
+  type AccountProfile,
+  type ChatUserSummary,
+} from "../../../api-client";
 import {
   PROFILE_POPOVER_CLOSE_DELAY_MS,
   hasPublicChatProfileInfo,
 } from "./message/profile-popover";
 
+function accountProfileToChatUser(profile: AccountProfile): ChatUserSummary {
+  return {
+    id: profile.id,
+    username: profile.username,
+    displayName: profile.name,
+    bio: profile.bio,
+    company: profile.company,
+    title: profile.title,
+    profilePublic: profile.profilePublic,
+    acceptUnknownDms: profile.acceptUnknownDms,
+    portfolioAnalytics: profile.portfolioAnalytics,
+  };
+}
+
 export function useChatProfilePopover() {
   const [profilePopoverUser, setProfilePopoverUser] = useState<ChatUserSummary | null>(null);
   const profilePopoverCloseTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
+  const ownProfileRef = useRef<ChatUserSummary | null>(null);
+  const ownProfileRequestRef = useRef<Promise<void> | null>(null);
+  const ownProfileLoadedAtRef = useRef(0);
+  const activeRef = useRef(true);
 
   const cancelProfilePopoverClose = useCallback(() => {
     if (profilePopoverCloseTimerRef.current == null) return;
@@ -28,16 +50,51 @@ export function useChatProfilePopover() {
     }, PROFILE_POPOVER_CLOSE_DELAY_MS);
   }, [cancelProfilePopoverClose]);
 
-  const showProfilePopover = useCallback((targetUser: ChatUserSummary) => {
-    if (!hasPublicChatProfileInfo(targetUser)) {
+  const showProfilePopover = useCallback((
+    targetUser: ChatUserSummary,
+    options?: { ownProfile?: boolean },
+  ) => {
+    const ownProfile = options?.ownProfile === true;
+    const cachedUser = ownProfile && ownProfileRef.current?.id === targetUser.id
+      ? ownProfileRef.current
+      : targetUser;
+    if (!ownProfile && !hasPublicChatProfileInfo(cachedUser)) {
       closeProfilePopover();
       return;
     }
     cancelProfilePopoverClose();
-    setProfilePopoverUser(targetUser);
+    setProfilePopoverUser(cachedUser);
+
+    if (
+      !ownProfile
+      || !apiClient.getSessionToken()
+      || ownProfileRequestRef.current
+      || (ownProfileRef.current?.id === targetUser.id && Date.now() - ownProfileLoadedAtRef.current < 10_000)
+    ) return;
+    const request = apiClient.getAccountProfile()
+      .then((profile) => {
+        if (!activeRef.current || profile.id !== targetUser.id) return;
+        const nextUser = accountProfileToChatUser(profile);
+        ownProfileRef.current = nextUser;
+        ownProfileLoadedAtRef.current = Date.now();
+        setProfilePopoverUser((current) => current?.id === targetUser.id ? nextUser : current);
+      })
+      .catch(() => {})
+      .finally(() => {
+        if (ownProfileRequestRef.current === request) {
+          ownProfileRequestRef.current = null;
+        }
+      });
+    ownProfileRequestRef.current = request;
   }, [cancelProfilePopoverClose, closeProfilePopover]);
 
-  useEffect(() => () => cancelProfilePopoverClose(), [cancelProfilePopoverClose]);
+  useEffect(() => {
+    activeRef.current = true;
+    return () => {
+      activeRef.current = false;
+      cancelProfilePopoverClose();
+    };
+  }, [cancelProfilePopoverClose]);
 
   return {
     cancelProfilePopoverClose,

package/src/plugins/builtin/chat/sidebar.test.tsx

@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { act, type ReactElement, useCallback, useMemo, useRef, useState } from "react";
+import { act, useCallback, useMemo, useRef, useState } from "react";
 import { testRender } from "../../../renderers/opentui/test-utils";
 import { AppContext, appReducer, createInitialState, PaneInstanceProvider } from "../../../state/app/context";
 import { createConfigBackedTestPluginRuntime, createTestPluginRuntime } from "../../../test-support/plugin-runtime";
@@ -475,17 +475,14 @@ describe("ChatContent channel sidebar", () => {
   });
 
   test("persists a pane channel selection without the last-visited write reverting it", async () => {
-    const registeredPanes: Array<{ id: string; component: (props: any) => ReactElement | null }> = [];
-    gloomberbCloudPlugin.setup!({
+    await gloomberbCloudPlugin.setup!({
       persistence: new MemoryPersistence(),
       resume: {
         getState: () => null,
         setState: () => {},
         deleteState: () => {},
       },
-      registerPane: (pane: { id: string; component: (props: any) => ReactElement | null }) => {
-        registeredPanes.push(pane);
-      },
+      registerPane: () => {},
       registerPaneTemplate: () => {},
       registerTickerResearchTab: () => {},
       registerSyncTransport: () => {},
@@ -495,7 +492,7 @@ describe("ChatContent channel sidebar", () => {
       hidePane: () => {},
       notify: () => {},
     } as any);
-    const ChatPaneComponent = registeredPanes.find((pane) => pane.id === "chat")?.component;
+    const ChatPaneComponent = gloomberbCloudPlugin.panes?.find((pane) => pane.id === "chat")?.component;
     expect(ChatPaneComponent).toBeDefined();
     const ResolvedChatPaneComponent = ChatPaneComponent!;