gloomberb 0.5.1 → 0.6.0

package/src/plugins/builtin/comparison-chart.test.tsx

@@ -1,24 +1,25 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act, type ReactElement } from "react";
 import { createTestRenderer } from "@opentui/core/testing";
-import { createRoot } from "@opentui/react";
+import { createOpenTuiTestRoot as createRoot } from "../../renderers/opentui/test-utils";
 import { MarketDataCoordinator, setSharedMarketDataCoordinator } from "../../market-data/coordinator";
+import { PaneFooterBar, PaneFooterProvider } from "../../components/layout/pane-footer";
 import {
   AppContext,
   createInitialState,
   PaneInstanceProvider,
 } from "../../state/app-context";
+import { Box } from "../../ui";
 import { cloneLayout, createDefaultConfig } from "../../types/config";
+import { createTestPluginRuntime } from "../../test-support/plugin-runtime";
 import type { DataProvider } from "../../types/data-provider";
 import type { TickerFinancials } from "../../types/financials";
 import type { PluginRegistry } from "../../plugins/registry";
-import { setSharedDataProviderForTests, setSharedRegistryForTests } from "../../plugins/registry";
+import { PluginRenderProvider, type PluginRuntimeAccess } from "../../plugins/plugin-runtime";
+import { setSharedMarketDataForTests, setSharedRegistryForTests } from "../../plugins/registry";
 import type { TickerRecord } from "../../types/ticker";
 import {
-  buildComparisonChartPaneTitle,
   comparisonChartPlugin,
-  COMPARISON_CHART_PANE_ID,
-  COMPARISON_CHART_TEMPLATE_ID,
   getComparisonChartPaneSettings,
 } from "./comparison-chart";
 
@@ -99,23 +100,33 @@ function createProvider(historyBySymbol: Record<string, number[]>, currencyBySym
 
 function createRegistrySpy(spy: { selected: string[]; focused: string[] }): PluginRegistry {
   return {
-    navigateTickerFn: (symbol: string) => {
+    selectTicker: (symbol: string) => { spy.selected.push(symbol); },
+    focusPaneFn: (paneId: string) => { spy.focused.push(paneId); },
+    navigateTicker: (symbol: string) => {
       spy.selected.push(symbol);
       spy.focused.push("ticker-detail");
     },
-    selectTickerFn: (symbol: string) => { spy.selected.push(symbol); },
-    focusPaneFn: (paneId: string) => { spy.focused.push(paneId); },
-    navigateTickerFn: (symbol: string) => {
+  } as unknown as PluginRegistry;
+}
+
+function createRuntimeSpy(spy: { selected: string[]; focused: string[] }): PluginRuntimeAccess {
+  return createTestPluginRuntime({
+    pinTicker: (symbol: string) => {
       spy.selected.push(symbol);
       spy.focused.push("ticker-detail");
     },
-  } as unknown as PluginRegistry;
+    navigateTicker: (symbol: string) => {
+      spy.selected.push(symbol);
+      spy.focused.push("ticker-detail");
+    },
+  });
 }
 
 function createComparisonHarness(
   settings: Record<string, unknown>,
   tickers: TickerRecord[],
   financials: Array<[string, TickerFinancials]>,
+  runtime: PluginRuntimeAccess,
 ) {
   const config = createDefaultConfig("/tmp/gloomberb-compare");
   const layout = {
@@ -126,6 +137,7 @@ function createComparisonHarness(
       settings,
     }],
     floating: [],
+    detached: [],
   };
   const nextConfig = {
     ...config,
@@ -148,13 +160,22 @@ function createComparisonHarness(
   return (
     <AppContext value={{ state, dispatch: () => {} }}>
       <PaneInstanceProvider paneId={TEST_PANE_ID}>
-        <ComparisonPane
-          paneId={TEST_PANE_ID}
-          paneType="comparison-chart"
-          focused
-          width={120}
-          height={20}
-        />
+        <PluginRenderProvider pluginId="comparison-chart" runtime={runtime}>
+          <PaneFooterProvider>
+            {(footer) => (
+              <Box flexDirection="column" width={120} height={20}>
+                <ComparisonPane
+                  paneId={TEST_PANE_ID}
+                  paneType="comparison-chart"
+                  focused
+                  width={120}
+                  height={19}
+                />
+                <PaneFooterBar footer={footer} focused width={120} />
+              </Box>
+            )}
+          </PaneFooterProvider>
+        </PluginRenderProvider>
       </PaneInstanceProvider>
     </AppContext>
   );
@@ -175,13 +196,14 @@ async function mountComparisonHarness(
   settings: Record<string, unknown>,
   tickers: TickerRecord[],
   financials: Array<[string, TickerFinancials]>,
+  spy: { selected: string[]; focused: string[] } = { selected: [], focused: [] },
 ) {
   actEnvironment.IS_REACT_ACT_ENVIRONMENT = true;
   testSetup = await createTestRenderer({ width: 120, height: 20 });
   root = createRoot(testSetup.renderer);
   await act(async () => {
     root!.render(
-      createComparisonHarness(settings, tickers, financials),
+      createComparisonHarness(settings, tickers, financials, createRuntimeSpy(spy)),
     );
     await Promise.resolve();
     await new Promise((resolve) => setTimeout(resolve, 0));
@@ -212,37 +234,10 @@ afterEach(async () => {
   sharedCoordinator = null;
   setSharedMarketDataCoordinator(null);
   setSharedRegistryForTests(undefined);
-  setSharedDataProviderForTests(undefined);
+  setSharedMarketDataForTests(undefined);
 });
 
 describe("comparisonChartPlugin", () => {
-  test("creates a configured comparison pane with percent as the default axis", () => {
-    const template = comparisonChartPlugin.paneTemplates?.find((entry) => entry.id === COMPARISON_CHART_TEMPLATE_ID);
-    const paneDef = comparisonChartPlugin.panes?.find((entry) => entry.id === COMPARISON_CHART_PANE_ID);
-
-    expect(template).toBeDefined();
-    expect(paneDef?.defaultMode).toBe("floating");
-    expect(template?.createInstance?.({
-      config: createDefaultConfig("/tmp/gloomberb-compare"),
-      layout: createDefaultConfig("/tmp/gloomberb-compare").layout,
-      focusedPaneId: "ticker-detail:main",
-      activeTicker: null,
-      activeCollectionId: null,
-    }, {
-      symbols: ["AAPL", "MSFT", "NVDA"],
-    })).toEqual({
-      placement: "floating",
-      title: "AAPL · MSFT · NVDA",
-      settings: {
-        axisMode: "percent",
-        rangePreset: "1Y",
-        chartResolution: "1d",
-        symbols: ["AAPL", "MSFT", "NVDA"],
-        symbolsText: "AAPL, MSFT, NVDA",
-      },
-    });
-  });
-
   test("parses stored pane settings and backfills the text form", () => {
     expect(getComparisonChartPaneSettings({
       axisMode: "percent",
@@ -264,7 +259,7 @@ describe("comparisonChartPlugin", () => {
       AAPL: "USD",
       "7203": "JPY",
     });
-    setSharedDataProviderForTests(provider);
+    setSharedMarketDataForTests(provider);
     sharedCoordinator = new MarketDataCoordinator(provider);
     setSharedMarketDataCoordinator(sharedCoordinator);
     setSharedRegistryForTests(createRegistrySpy({ selected: [], focused: [] }));
@@ -291,7 +286,7 @@ describe("comparisonChartPlugin", () => {
     expect(frame).toContain("view:");
     expect(frame).toContain("[m]ode");
     expect(frame).toContain("[r]es");
-    expect(frame).toContain("[up/down]legend");
+    expect(frame).not.toContain("[up/down]legend");
     expect(frame).not.toContain("arrows legend");
     expect(frame).not.toContain("wheel pan");
     expect(frame).not.toContain("wheel zoom");
@@ -306,7 +301,7 @@ describe("comparisonChartPlugin", () => {
       AAPL: "USD",
       MSFT: "USD",
     });
-    setSharedDataProviderForTests(provider);
+    setSharedMarketDataForTests(provider);
     sharedCoordinator = new MarketDataCoordinator(provider);
     setSharedMarketDataCoordinator(sharedCoordinator);
     setSharedRegistryForTests(createRegistrySpy({ selected: [], focused: [] }));
@@ -343,7 +338,7 @@ describe("comparisonChartPlugin", () => {
       MSFT: "USD",
       NVDA: "USD",
     });
-    setSharedDataProviderForTests(provider);
+    setSharedMarketDataForTests(provider);
     sharedCoordinator = new MarketDataCoordinator(provider);
     setSharedMarketDataCoordinator(sharedCoordinator);
     setSharedRegistryForTests(createRegistrySpy(spy));
@@ -360,7 +355,7 @@ describe("comparisonChartPlugin", () => {
       ["AAPL", makeFinancials("AAPL", "USD", [100, 102, 104])],
       ["MSFT", makeFinancials("MSFT", "USD", [200, 202, 204])],
       ["NVDA", makeFinancials("NVDA", "USD", [300, 305, 310])],
-    ]);
+    ], spy);
 
     await flushFrames();
     await pressComparisonInput(() => testSetup!.mockInput.pressArrow("right"));
@@ -370,9 +365,3 @@ describe("comparisonChartPlugin", () => {
     expect(spy.focused).toEqual(["ticker-detail"]);
   });
 });
-
-describe("buildComparisonChartPaneTitle", () => {
-  test("summarizes longer symbol lists", () => {
-    expect(buildComparisonChartPaneTitle(["AAPL", "MSFT", "NVDA", "META"])).toBe("AAPL · MSFT +2");
-  });
-});

package/src/plugins/builtin/comparison-chart.tsx

@@ -1,3 +1,4 @@
+import { Box } from "../../ui";
 import { useCallback, useMemo } from "react";
 import { EmptyState } from "../../components";
 import { ComparisonStockChart } from "../../components/chart/comparison-stock-chart";
@@ -7,8 +8,8 @@ import {
   DEFAULT_COMPARISON_CHART_RESOLUTION,
   normalizeChartResolution,
 } from "../../components/chart/chart-resolution";
-import { getSharedRegistry } from "../../plugins/registry";
-import { useAppState } from "../../state/app-context";
+import { usePluginTickerActions } from "../../plugins/plugin-runtime";
+import { usePaneInstance } from "../../state/app-context";
 import { colors } from "../../theme/colors";
 import type { GloomPlugin, PaneProps, PaneSettingsDef } from "../../types/plugin";
 import { formatTickerListInput, MAX_TICKER_LIST_SIZE, parseTickerListInput } from "../../utils/ticker-list";
@@ -100,25 +101,24 @@ export function buildComparisonChartPaneTitle(symbols: string[]): string {
   return `${symbols.slice(0, 2).join(" · ")} +${symbols.length - 2}`;
 }
 function ComparisonChartPane({ paneId, focused, width, height }: PaneProps) {
-  const registry = getSharedRegistry();
-  const { state } = useAppState();
-  const pane = state.config.layout.instances.find((instance) => instance.instanceId === paneId);
+  const { navigateTicker } = usePluginTickerActions();
+  const pane = usePaneInstance();
   const settings = useMemo(() => getComparisonChartPaneSettings(pane?.settings), [pane?.settings]);
 
   const openTicker = useCallback((symbol: string) => {
-    registry?.navigateTickerFn(symbol);
-  }, [registry]);
+    navigateTicker(symbol);
+  }, [navigateTicker]);
 
   if (settings.symbols.length === 0) {
     return (
-      <box flexDirection="column" flexGrow={1} padding={1}>
+      <Box flexDirection="column" flexGrow={1} padding={1}>
         <EmptyState title="No comparison tickers configured." message="Open pane settings to add up to 10 tickers." />
-      </box>
+      </Box>
     );
   }
 
   return (
-    <box flexDirection="column" flexGrow={1} paddingX={1} backgroundColor={colors.panel}>
+    <Box flexDirection="column" flexGrow={1} paddingX={1} backgroundColor={colors.panel}>
       <ComparisonStockChart
         paneId={paneId}
         width={Math.max(width - 2, 20)}
@@ -128,7 +128,7 @@ function ComparisonChartPane({ paneId, focused, width, height }: PaneProps) {
         axisMode={settings.axisMode}
         onOpenSymbol={openTicker}
       />
-    </box>
+    </Box>
   );
 }
 

package/src/plugins/builtin/correlation/compute.test.ts

@@ -4,7 +4,6 @@ import {
   computeDatedReturns,
   computeReturns,
   correlateDatedReturns,
-  formatCorrelation,
   pearsonCorrelation,
 } from "./compute";
 
@@ -17,10 +16,6 @@ describe("computeReturns", () => {
     expect(returns[2]).toBeCloseTo(0.0952, 3);
   });
 
-  test("returns empty for single value", () => {
-    expect(computeReturns([100])).toEqual([]);
-  });
-
   test("skips zero or invalid previous closes", () => {
     expect(computeReturns([0, 10, 20, Number.NaN, 30])).toEqual([1]);
   });
@@ -133,15 +128,3 @@ describe("correlateDatedReturns", () => {
     )).toEqual({ correlation: null, sampleSize: 2 });
   });
 });
-
-describe("formatCorrelation", () => {
-  test("formats positive", () => {
-    expect(formatCorrelation(0.85)).toContain("0.85");
-  });
-  test("formats negative", () => {
-    expect(formatCorrelation(-0.42)).toContain("-0.42");
-  });
-  test("formats null as dash", () => {
-    expect(formatCorrelation(null)).toContain("—");
-  });
-});

package/src/plugins/builtin/correlation/index.tsx

@@ -1,9 +1,11 @@
+import { Box, ScrollBox, Text } from "../../../ui";
 import { useMemo } from "react";
-import { TextAttributes } from "@opentui/core";
+import { TextAttributes } from "../../../ui";
+import { usePaneFooter } from "../../../components";
 import type { GloomPlugin, PaneProps } from "../../../types/plugin";
 import { colors } from "../../../theme/colors";
-import { getSharedRegistry } from "../../registry";
-import { useAppSelector } from "../../../state/app-context";
+import { usePluginTickerActions } from "../../plugin-runtime";
+import { useAppSelector, usePaneInstance } from "../../../state/app-context";
 import { useChartQueries } from "../../../market-data/hooks";
 import { buildChartKey } from "../../../market-data/selectors";
 import type { PricePoint } from "../../../types/financials";
@@ -145,21 +147,22 @@ function buildCorrelationPaneTitle(symbols: string[], rangePreset: CorrelationRa
   return `${symbols.slice(0, 2).join(" · ")} +${symbols.length - 2} ${rangePreset}`;
 }
 
-export function CorrelationMatrixPane({ paneId, width, height }: PaneProps) {
-  const state = useAppSelector((s) => s);
-  const pane = state.config.layout.instances.find((instance) => instance.instanceId === paneId);
+export function CorrelationMatrixPane({ width, height }: PaneProps) {
+  const pane = usePaneInstance();
+  const { navigateTicker } = usePluginTickerActions();
+  const tickers = useAppSelector((state) => state.tickers);
   const settings = useMemo(() => getCorrelationPaneSettings(pane?.settings), [pane?.settings]);
 
   const instruments = useMemo(() => {
     if (settings.symbolsError) return [];
     return settings.symbols.map((symbol) => {
-      const ticker = state.tickers.get(symbol);
+      const ticker = tickers.get(symbol);
       return {
         symbol,
         exchange: ticker?.metadata.exchange ?? "",
       };
     });
-  }, [state.tickers, settings.symbols.join(","), settings.symbolsError]);
+  }, [settings.symbols.join(","), settings.symbolsError, tickers]);
 
   const instrumentKey = instruments.map((instrument) => `${instrument.symbol}|${instrument.exchange}`).join(",");
 
@@ -226,20 +229,30 @@ export function CorrelationMatrixPane({ paneId, width, height }: PaneProps) {
     [symbolsKey, seriesBySymbol, matrix.sampleMin, matrix.sampleMax],
   );
 
+  usePaneFooter("correlation", () => ({
+    info: [
+      { id: "tickers", parts: [{ text: `${symbols.length} tickers`, tone: symbols.length >= 2 ? "value" : "warning", bold: symbols.length >= 2 }] },
+      { id: "range", parts: [{ text: settings.rangePreset, tone: "muted" }] },
+      ...(settings.symbolsError
+        ? [{ id: "error", parts: [{ text: settings.symbolsError, tone: "warning" as const }] }]
+        : [{ id: "status", parts: [{ text: statusSummary, tone: "muted" as const }] }]),
+    ],
+  }), [settings.rangePreset, settings.symbolsError, statusSummary, symbols.length]);
+
   if (settings.symbolsError) {
     return (
-      <box flexDirection="column" width={width} height={height} paddingX={2} paddingY={1}>
-        <text fg={colors.negative}>Invalid CORR tickers: {settings.symbolsError}</text>
-        <text fg={colors.textMuted}>Open pane settings and enter tickers like AAPL, MSFT, NVDA.</text>
-      </box>
+      <Box flexDirection="column" width={width} height={height} paddingX={2} paddingY={1}>
+        <Text fg={colors.negative}>Invalid CORR tickers: {settings.symbolsError}</Text>
+        <Text fg={colors.textMuted}>Open pane settings and enter tickers like AAPL, MSFT, NVDA.</Text>
+      </Box>
     );
   }
 
   if (symbols.length < 2) {
     return (
-      <box flexDirection="column" width={width} height={height} paddingX={2} paddingY={1}>
-        <text fg={colors.textMuted}>Enter at least 2 tickers in pane settings</text>
-      </box>
+      <Box flexDirection="column" width={width} height={height} paddingX={2} paddingY={1}>
+        <Text fg={colors.textMuted}>Enter at least 2 tickers in pane settings</Text>
+      </Box>
     );
   }
 
@@ -252,46 +265,38 @@ export function CorrelationMatrixPane({ paneId, width, height }: PaneProps) {
   const cellWidth = Math.max(MIN_MATRIX_CELL_WIDTH, Math.min(MATRIX_CELL_WIDTH, availableCellWidth));
 
   return (
-    <box flexDirection="column" width={width} height={height}>
-      {/* Title */}
-      <box flexDirection="row" height={1} paddingX={1}>
-        <text fg={colors.textMuted}>{symbols.length} tickers · {settings.rangePreset} daily returns</text>
-      </box>
-      <box flexDirection="row" height={1} paddingX={1}>
-        <text fg={colors.textDim}>{statusSummary}</text>
-      </box>
-
+    <Box flexDirection="column" width={width} height={height}>
       {/* Column header row */}
-      <box flexDirection="row" paddingX={1} height={1} backgroundColor={headerBg}>
-        <box width={rowHeaderWidth} flexShrink={0} />
+      <Box flexDirection="row" paddingX={1} height={1} backgroundColor={headerBg}>
+        <Box width={rowHeaderWidth} flexShrink={0} />
         {symbols.map((sym) => (
-          <box key={sym} width={cellWidth} justifyContent="flex-end" paddingRight={1} overflow="hidden">
-            <text fg={colors.textDim} attributes={TextAttributes.BOLD}>
+          <Box key={sym} width={cellWidth} justifyContent="flex-end" paddingRight={1} overflow="hidden">
+            <Text fg={colors.textDim} attributes={TextAttributes.BOLD}>
               {displaySymbol(sym)}
-            </text>
-          </box>
+            </Text>
+          </Box>
         ))}
-      </box>
+      </Box>
 
       {/* Matrix rows */}
-      <scrollbox flexGrow={1} scrollY focusable={false}>
-        <box flexDirection="column">
+      <ScrollBox flexGrow={1} scrollY focusable={false}>
+        <Box flexDirection="column">
           {symbols.map((rowSym, rowIndex) => (
-            <box key={rowSym} flexDirection="row" paddingX={1} backgroundColor={rowIndex % 2 === 0 ? colors.bg : undefined}>
+            <Box key={rowSym} flexDirection="row" paddingX={1} backgroundColor={rowIndex % 2 === 0 ? colors.bg : undefined}>
               {/* Row header */}
-              <box
+              <Box
                 width={rowHeaderWidth}
                 flexShrink={0}
                 overflow="hidden"
-                onMouseDown={() => getSharedRegistry()?.navigateTickerFn(rowSym)}
+                onMouseDown={() => navigateTicker(rowSym)}
               >
-                <text
+                <Text
                   fg={rowHeaderColor(seriesBySymbol.get(rowSym)?.status ?? "loading")}
                   attributes={TextAttributes.BOLD | TextAttributes.UNDERLINE}
                 >
                   {displaySymbol(rowSym)}
-                </text>
-              </box>
+                </Text>
+              </Box>
               {/* Cells */}
               {symbols.map((colSym) => {
                 const isDiag = rowSym === colSym;
@@ -306,23 +311,23 @@ export function CorrelationMatrixPane({ paneId, width, height }: PaneProps) {
                   : correlationColor(r, colors.positive, colors.negative, colors.textMuted);
                 const text = isDiag ? " 1.00" : formatCorrelation(r);
                 return (
-                  <box
+                  <Box
                     key={colSym}
                     width={cellWidth}
                     justifyContent="flex-end"
                     paddingRight={1}
                     backgroundColor={isDiag ? headerBg : undefined}
                   >
-                    <text fg={cellColor}>{text}</text>
-                  </box>
+                    <Text fg={cellColor}>{text}</Text>
+                  </Box>
                 );
               })}
-            </box>
+            </Box>
           ))}
-        </box>
-      </scrollbox>
+        </Box>
+      </ScrollBox>
 
-    </box>
+    </Box>
   );
 }
 

package/src/plugins/builtin/correlation/settings.ts

@@ -24,7 +24,7 @@ export function normalizeCorrelationRange(value: unknown): CorrelationRangePrese
   return isCorrelationRangePreset(value) ? value : DEFAULT_CORRELATION_RANGE;
 }
 
-export function parseCorrelationSymbolsInput(raw: string, maxTickers = MAX_CORRELATION_TICKERS): string[] {
+function parseCorrelationSymbolsInput(raw: string, maxTickers = MAX_CORRELATION_TICKERS): string[] {
   return parseTickerListInput(raw, maxTickers);
 }
 
@@ -83,7 +83,6 @@ export function buildCorrelationSettingsDef(): PaneSettingsDef {
       {
         key: "rangePreset",
         label: "Range",
-        description: "Use daily closes over this range.",
         type: "select",
         options: CORRELATION_RANGE_OPTIONS.map((range) => ({
           value: range,