gloomberb 0.5.1 → 0.6.0

package/src/plugins/builtin/ai/settings.ts

@@ -64,7 +64,6 @@ export function buildAiScreenerPaneSettingsDef(settings: AiScreenerPaneSettings)
       {
         key: "columnIds",
         label: "Columns",
-        description: "Choose which columns this screener shows and in what order.",
         type: "ordered-multi-select",
         options: AI_SCREENER_COLUMN_DEFS.map((column) => ({
           value: column.id,

package/src/plugins/builtin/ai/utils.ts

@@ -1,71 +1 @@
-export function truncateWithEllipsis(text: string, width: number): string {
-  if (width <= 0) return "";
-  if (text.length <= width) return text;
-  if (width <= 3) return text.slice(0, width);
-  return `${text.slice(0, width - 3)}...`;
-}
-
-export function wrapTextLines(text: string, width: number, maxLines = Number.MAX_SAFE_INTEGER): string[] {
-  if (width <= 0) return [];
-
-  const paragraphs = text
-    .split(/\r?\n/)
-    .map((paragraph) => paragraph.replace(/\s+/g, " ").trim());
-  const lines: string[] = [];
-
-  const pushLine = (line: string) => {
-    if (lines.length >= maxLines) return;
-    lines.push(line);
-  };
-
-  for (let paragraphIndex = 0; paragraphIndex < paragraphs.length; paragraphIndex += 1) {
-    const paragraph = paragraphs[paragraphIndex]!;
-    if (!paragraph) {
-      pushLine("");
-      continue;
-    }
-
-    let current = "";
-    for (const rawWord of paragraph.split(" ")) {
-      let word = rawWord;
-      while (word.length > width) {
-        const available = current ? width - current.length - 1 : width;
-        if (available <= 0) {
-          pushLine(current);
-          current = "";
-          continue;
-        }
-        if (word.length <= available) break;
-        const piece = word.slice(0, available);
-        word = word.slice(available);
-        pushLine(current ? `${current} ${piece}` : piece);
-        current = "";
-      }
-
-      if (!current) {
-        current = word;
-        continue;
-      }
-
-      if ((current.length + 1 + word.length) <= width) {
-        current = `${current} ${word}`;
-      } else {
-        pushLine(current);
-        current = word;
-      }
-    }
-
-    if (current) pushLine(current);
-    if (paragraphIndex < (paragraphs.length - 1)) pushLine("");
-    if (lines.length >= maxLines) break;
-  }
-
-  if (lines.length > maxLines) {
-    lines.length = maxLines;
-  }
-  if (lines.length === maxLines && paragraphs.join(" ").length > lines.join(" ").length) {
-    lines[maxLines - 1] = truncateWithEllipsis(lines[maxLines - 1] ?? "", width);
-  }
-
-  return lines;
-}
+export { truncateWithEllipsis, wrapTextLines } from "../../../utils/text-wrap";

package/src/plugins/builtin/alerts/alert-engine.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, test } from "bun:test";
-import { evaluateAlert, createAlert, formatAlertDescription, serializeAlerts, deserializeAlerts } from "./alert-engine";
+import { evaluateAlert, createAlert, serializeAlerts, deserializeAlerts } from "./alert-engine";
 
 describe("evaluateAlert", () => {
   test("above: triggers when price exceeds target", () => {
@@ -41,33 +41,6 @@ describe("evaluateAlert", () => {
   });
 });
 
-describe("createAlert", () => {
-  test("creates alert with active status", () => {
-    const alert = createAlert("TSLA", "below", 100);
-    expect(alert.symbol).toBe("TSLA");
-    expect(alert.condition).toBe("below");
-    expect(alert.targetPrice).toBe(100);
-    expect(alert.status).toBe("active");
-    expect(alert.id).toBeTruthy();
-  });
-
-  test("uppercases symbol", () => {
-    expect(createAlert("aapl", "above", 200).symbol).toBe("AAPL");
-  });
-});
-
-describe("formatAlertDescription", () => {
-  test("formats above", () => {
-    expect(formatAlertDescription(createAlert("AAPL", "above", 200))).toBe("AAPL > 200");
-  });
-  test("formats below", () => {
-    expect(formatAlertDescription(createAlert("AAPL", "below", 150))).toBe("AAPL < 150");
-  });
-  test("formats crosses", () => {
-    expect(formatAlertDescription(createAlert("AAPL", "crosses", 180))).toBe("AAPL ↕ 180");
-  });
-});
-
 describe("serializeAlerts / deserializeAlerts", () => {
   test("roundtrips alerts", () => {
     const alerts = [createAlert("AAPL", "above", 200), createAlert("TSLA", "below", 100)];
@@ -77,14 +50,4 @@ describe("serializeAlerts / deserializeAlerts", () => {
     expect(restored[0]!.symbol).toBe("AAPL");
     expect(restored[1]!.symbol).toBe("TSLA");
   });
-
-  test("handles invalid JSON", () => {
-    expect(deserializeAlerts("not json")).toEqual([]);
-    expect(deserializeAlerts("null")).toEqual([]);
-    expect(deserializeAlerts("[]")).toEqual([]);
-  });
-
-  test("filters invalid entries", () => {
-    expect(deserializeAlerts('[{"bad": true}]')).toEqual([]);
-  });
 });

package/src/plugins/builtin/alerts/index.test.tsx

@@ -1,6 +1,6 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act, useReducer } from "react";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../../../renderers/opentui/test-utils";
 import {
   AppContext,
   PaneInstanceProvider,
@@ -10,7 +10,9 @@ import {
 } from "../../../state/app-context";
 import { cloneLayout, createDefaultConfig, type AppConfig } from "../../../types/config";
 import { PluginRenderProvider, type PluginRuntimeAccess } from "../../plugin-runtime";
-import { setSharedRegistryForTests } from "../../registry";
+import { PaneFooterBar, PaneFooterProvider } from "../../../components/layout/pane-footer";
+import { createConfigBackedTestPluginRuntime } from "../../../test-support/plugin-runtime";
+import { Box } from "../../../ui";
 import { deserializeAlerts, serializeAlerts } from "./alert-engine";
 import { AlertsPane, alertsPlugin } from "./index";
 import type { AlertCondition, AlertRule, AlertStatus } from "./types";
@@ -37,6 +39,8 @@ function makeAlert(
     status,
     triggeredAt: status === "triggered" ? Date.now() - 30_000 : undefined,
     lastCheckedPrice: status === "triggered" ? targetPrice + 1 : undefined,
+    lastCheckedAt: status === "triggered" ? Date.now() - 30_000 : undefined,
+    lastQuoteUpdatedAt: status === "triggered" ? Date.now() - 30_000 : undefined,
   };
 }
 
@@ -50,6 +54,7 @@ function createAlertsConfig(alerts: AlertRule[]): AppConfig {
       binding: { kind: "none" },
     }],
     floating: [],
+    detached: [],
   };
 
   return {
@@ -65,80 +70,23 @@ function createAlertsConfig(alerts: AlertRule[]): AppConfig {
   };
 }
 
-function makeRuntime(): PluginRuntimeAccess {
-  const resumeState = new Map<string, unknown>();
-  const listeners = new Map<string, Set<() => void>>();
-
-  return {
-    pinTicker() {},
-    navigateTicker() {},
-    subscribeResumeState(pluginId, key, listener) {
-      const storeKey = `${pluginId}:${key}`;
-      if (!listeners.has(storeKey)) listeners.set(storeKey, new Set());
-      listeners.get(storeKey)!.add(listener);
-      return () => listeners.get(storeKey)?.delete(listener);
-    },
-    getResumeState(pluginId, key) {
-      return (resumeState.get(`${pluginId}:${key}`) as any) ?? null;
-    },
-    setResumeState(pluginId, key, value) {
-      const storeKey = `${pluginId}:${key}`;
-      resumeState.set(storeKey, value);
-      for (const listener of listeners.get(storeKey) ?? []) listener();
-    },
-    deleteResumeState(pluginId, key) {
-      const storeKey = `${pluginId}:${key}`;
-      resumeState.delete(storeKey);
-      for (const listener of listeners.get(storeKey) ?? []) listener();
-    },
-    getConfigState(pluginId, key) {
-      return (harnessState?.config.pluginConfig[pluginId]?.[key] as any) ?? null;
-    },
-    async setConfigState(pluginId, key, value) {
-      const currentState = harnessState!;
-      harnessDispatch?.({
-        type: "SET_CONFIG",
-        config: {
-          ...currentState.config,
-          pluginConfig: {
-            ...currentState.config.pluginConfig,
-            [pluginId]: {
-              ...(currentState.config.pluginConfig[pluginId] ?? {}),
-              [key]: value,
-            },
-          },
-        },
-      });
-    },
-    async deleteConfigState(pluginId, key) {
-      const currentState = harnessState!;
-      const currentPluginConfig = { ...(currentState.config.pluginConfig[pluginId] ?? {}) };
-      delete currentPluginConfig[key];
-      const pluginConfig = { ...currentState.config.pluginConfig };
-      if (Object.keys(currentPluginConfig).length === 0) delete pluginConfig[pluginId];
-      else pluginConfig[pluginId] = currentPluginConfig;
-      harnessDispatch?.({
-        type: "SET_CONFIG",
-        config: {
-          ...currentState.config,
-          pluginConfig,
-        },
-      });
-    },
-    getConfigStateKeys(pluginId) {
-      return Object.keys(harnessState?.config.pluginConfig[pluginId] ?? {}).sort();
-    },
-  };
+function makeRuntime(overrides: Partial<PluginRuntimeAccess> = {}): PluginRuntimeAccess {
+  return createConfigBackedTestPluginRuntime({
+    getConfig: () => harnessState?.config,
+    setConfig: (config) => harnessDispatch?.({ type: "SET_CONFIG", config }),
+  }, overrides);
 }
 
 function AlertsHarness({
   alerts,
   width = 110,
   height = 12,
+  runtime = makeRuntime(),
 }: {
   alerts: AlertRule[];
   width?: number;
   height?: number;
+  runtime?: PluginRuntimeAccess;
 }) {
   const initialState = createInitialState(createAlertsConfig(alerts));
   initialState.focusedPaneId = TEST_PANE_ID;
@@ -149,8 +97,21 @@ function AlertsHarness({
   return (
     <AppContext value={{ state, dispatch }}>
       <PaneInstanceProvider paneId={TEST_PANE_ID}>
-        <PluginRenderProvider pluginId="alerts" runtime={makeRuntime()}>
-          <AlertsPane focused width={width} height={height} />
+        <PluginRenderProvider pluginId="alerts" runtime={runtime}>
+          <PaneFooterProvider>
+            {(footer) => (
+              <Box flexDirection="column" width={width} height={height}>
+                <AlertsPane
+                  paneId={TEST_PANE_ID}
+                  paneType="alerts"
+                  focused
+                  width={width}
+                  height={Math.max(1, height - 1)}
+                />
+                <PaneFooterBar footer={footer} focused width={width} />
+              </Box>
+            )}
+          </PaneFooterProvider>
         </PluginRenderProvider>
       </PaneInstanceProvider>
     </AppContext>
@@ -187,7 +148,6 @@ function storedAlerts(): AlertRule[] {
 }
 
 afterEach(() => {
-  setSharedRegistryForTests(undefined);
   harnessState = null;
   harnessDispatch = null;
   if (testSetup) {
@@ -211,9 +171,10 @@ describe("AlertsPane", () => {
     await renderSettled();
     const frame = testSetup.captureCharFrame();
 
-    expect(frame).toContain("Status");
+    expect(frame).toContain("State");
     expect(frame).toContain("Symbol");
-    expect(frame).toContain("Condition");
+    expect(frame).toContain("Current");
+    expect(frame).toContain("Away");
     expect(frame).toContain("AAPL");
     expect(frame).toContain("MSFT");
     expect(frame).toContain("[a]dd alert");
@@ -230,32 +191,32 @@ describe("AlertsPane", () => {
   test("keeps alert targets visible at the default floating pane width", async () => {
     testSetup = await testRender(
       <AlertsHarness
-        width={65}
+        width={82}
         height={8}
         alerts={[makeAlert("alert-aapl", "AAPL", "above", 200)]}
       />,
-      { width: 65, height: 8 },
+      { width: 82, height: 8 },
     );
 
     await renderSettled();
     const frame = testSetup.captureCharFrame();
 
-    expect(frame).toContain("Status");
-    expect(frame).toContain("Condition");
+    expect(frame).toContain("State");
+    expect(frame).toContain("Current");
     expect(frame).toContain("Target");
     expect(frame).toContain("200");
     expect(frame).toContain("[a]dd alert");
   });
 
-  test("opens the command-bar alert workflow from keyboard and mouse", async () => {
+  test("opens the shared alert workflow from keyboard and mouse", async () => {
     const workflowCalls: string[] = [];
-    setSharedRegistryForTests({
+    const runtime = makeRuntime({
       openPluginCommandWorkflow(commandId: string) {
         workflowCalls.push(commandId);
       },
-    } as any);
+    });
 
-    testSetup = await testRender(<AlertsHarness alerts={[]} />, {
+    testSetup = await testRender(<AlertsHarness alerts={[]} runtime={runtime} />, {
       width: 110,
       height: 12,
     });
@@ -265,6 +226,14 @@ describe("AlertsPane", () => {
       await testSetup!.mockInput.typeText("a");
       await testSetup!.renderOnce();
     });
+    expect(workflowCalls).toEqual(["set-alert"]);
+
+    testSetup.renderer.destroy();
+    testSetup = await testRender(<AlertsHarness alerts={[]} runtime={runtime} />, {
+      width: 110,
+      height: 12,
+    });
+    await renderSettled();
     await clickFrameText("[a]");
 
     expect(workflowCalls).toEqual(["set-alert", "set-alert"]);
@@ -311,8 +280,16 @@ describe("alertsPlugin command", () => {
           store.set(key, value);
         },
       },
-      dataProvider: {
-        getQuote: async () => null,
+      marketData: {
+        getQuote: async (symbol: string) => ({
+          symbol,
+          price: 201.5,
+          currency: "USD",
+          change: 1,
+          changePercent: 0.5,
+          lastUpdated: Date.now(),
+          dataSource: "live",
+        }),
       },
       notify(notification: any) {
         notifications.push(notification);
@@ -325,7 +302,7 @@ describe("alertsPlugin command", () => {
     };
 
     try {
-      alertsPlugin.setup(ctx as any);
+      await alertsPlugin.setup?.(ctx as any);
       const command = commands.find((entry) => entry.id === "set-alert");
 
       expect(command?.label).toBe("Add Alert");
@@ -333,6 +310,7 @@ describe("alertsPlugin command", () => {
       expect(command?.shortcut).toBe("SA");
       expect(command?.shortcutArg?.placeholder).toBe("symbol condition price");
       expect(command?.shortcutArg?.parse("AMD")).toEqual({ symbol: "AMD" });
+      expect(command?.shortcutArg?.parse("", { activeTicker: "MSFT" })).toEqual({ symbol: "MSFT" });
       expect(command?.shortcutArg?.parse("AMD above 200")).toEqual({
         symbol: "AMD",
         condition: "above",
@@ -347,6 +325,7 @@ describe("alertsPlugin command", () => {
         symbol: "AAPL",
         condition: "above",
         targetPrice: 200,
+        lastCheckedPrice: 201.5,
         status: "active",
       });
       expect(notifications[0]?.body).toContain("AAPL");