gloomberb 0.5.1 → 0.6.0

package/src/state/app-bootstrap.ts

@@ -6,8 +6,10 @@ import type { TickerFinancials } from "../types/financials";
 import type { BrokerAccount } from "../types/trading";
 import type { TickerMetadata, TickerRecord } from "../types/ticker";
 import type { AppAction, PaneRuntimeState } from "./app-context";
-import type { AppSessionSnapshot } from "./session-persistence";
+import type { AppSessionSnapshot } from "../core/state/session-persistence";
 import { getDockedPaneIds } from "../plugins/pane-manager";
+import { debugLog } from "../utils/debug-log";
+import { measurePerf, measurePerfAsync } from "../utils/perf-marks";
 
 const DEFAULT_WATCHLIST_TICKERS: Array<Pick<TickerMetadata, "ticker" | "exchange" | "currency" | "name">> = [
   { ticker: "AAPL", exchange: "NASDAQ", currency: "USD", name: "Apple Inc." },
@@ -41,6 +43,7 @@ const PORTFOLIO_FINANCIAL_COLUMN_IDS = new Set([
   "forward_pe",
   "dividend_yield",
 ]);
+const startupLog = debugLog.createLogger("startup");
 
 export interface InitializeAppStateArgs {
   config: AppConfig;
@@ -252,57 +255,128 @@ export async function initializeAppState({
   autoImportBrokerPositions,
   persistedBrokerAccounts = {},
 }: InitializeAppStateArgs): Promise<void> {
-  let tickers = await tickerRepository.loadAllTickers();
+  startupLog.info("initialize start", {
+    layoutPaneCount: config.layout.instances.length,
+    dockedPaneCount: getDockedPaneIds(config.layout).length,
+    floatingPaneCount: config.layout.floating.length,
+    brokerInstanceCount: config.brokerInstances.length,
+    sessionHydrationTargetCount: sessionSnapshot?.hydrationTargets.length ?? 0,
+    recentTickerCount: config.recentTickers.length,
+  });
+
+  let tickers = await measurePerfAsync("startup.load-tickers", () => tickerRepository.loadAllTickers());
+  startupLog.info("tickers loaded", { count: tickers.length });
 
   // Seed default watchlist tickers on first run
   if (tickers.length === 0) {
     const defaultWatchlistId = config.watchlists[0]?.id ?? "watchlist";
-    for (const entry of DEFAULT_WATCHLIST_TICKERS) {
-      await tickerRepository.createTicker({
-        ...entry,
-        portfolios: [],
-        watchlists: [defaultWatchlistId],
-        positions: [],
-        broker_contracts: [],
-        custom: {},
-        tags: [],
-      });
-    }
-    tickers = await tickerRepository.loadAllTickers();
-  }
-
-  const tickerMap = new Map<string, TickerRecord>();
-  for (const ticker of tickers) {
-    tickerMap.set(ticker.metadata.ticker, ticker);
-  }
-  dispatch({ type: "SET_TICKERS", tickers: tickerMap });
-
-  for (const [instanceId, accounts] of Object.entries(persistedBrokerAccounts)) {
-    dispatch({ type: "SET_BROKER_ACCOUNTS", instanceId, accounts });
+    await measurePerfAsync("startup.seed-default-tickers", async () => {
+      for (const entry of DEFAULT_WATCHLIST_TICKERS) {
+        await tickerRepository.createTicker({
+          ...entry,
+          portfolios: [],
+          watchlists: [defaultWatchlistId],
+          positions: [],
+          broker_contracts: [],
+          custom: {},
+          tags: [],
+        });
+      }
+    }, { count: DEFAULT_WATCHLIST_TICKERS.length });
+    tickers = await measurePerfAsync("startup.reload-default-tickers", () => tickerRepository.loadAllTickers());
+    startupLog.info("default tickers seeded", {
+      defaultWatchlistId,
+      count: tickers.length,
+    });
   }
 
-  const paneStateSeed = buildPaneStateSeed(config, tickers, tickerMap, sessionSnapshot);
-  for (const [paneId, patch] of Object.entries(paneStateSeed) as Array<[string, PaneRuntimeState]>) {
-    dispatch({ type: "UPDATE_PANE_STATE", paneId, patch });
-  }
+  const tickerMap = measurePerf("startup.build-ticker-map", () => {
+    const nextTickerMap = new Map<string, TickerRecord>();
+    for (const ticker of tickers) {
+      nextTickerMap.set(ticker.metadata.ticker, ticker);
+    }
+    return nextTickerMap;
+  }, { tickerCount: tickers.length });
+  measurePerf("startup.dispatch-set-tickers", () => {
+    dispatch({ type: "SET_TICKERS", tickers: tickerMap });
+  }, { tickerCount: tickerMap.size });
+
+  measurePerf("startup.dispatch-broker-accounts", () => {
+    for (const [instanceId, accounts] of Object.entries(persistedBrokerAccounts)) {
+      dispatch({ type: "SET_BROKER_ACCOUNTS", instanceId, accounts });
+    }
+  }, {
+    instanceCount: Object.keys(persistedBrokerAccounts).length,
+    accountCount: Object.values(persistedBrokerAccounts).reduce((sum, accounts) => sum + accounts.length, 0),
+  });
+
+  const paneStateSeed = measurePerf(
+    "startup.build-pane-state-seed",
+    () => buildPaneStateSeed(config, tickers, tickerMap, sessionSnapshot),
+    { paneCount: config.layout.instances.length },
+  );
+  measurePerf("startup.dispatch-pane-state-seed", () => {
+    for (const [paneId, patch] of Object.entries(paneStateSeed) as Array<[string, PaneRuntimeState]>) {
+      dispatch({ type: "UPDATE_PANE_STATE", paneId, patch });
+    }
+  }, { paneStateSeedCount: Object.keys(paneStateSeed).length });
+
+  const refreshPlan = measurePerf(
+    "startup.build-refresh-plan",
+    () => buildRefreshPlan(config, tickerMap, paneStateSeed, sessionSnapshot),
+    {
+      tickerCount: tickerMap.size,
+      sessionHydrationTargetCount: sessionSnapshot?.hydrationTargets.length ?? 0,
+      recentTickerCount: config.recentTickers.length,
+    },
+  );
+  startupLog.info("refresh plan built", {
+    count: refreshPlan.length,
+    financials: refreshPlan.filter((entry) => entry.mode === "financials").length,
+    quotes: refreshPlan.filter((entry) => entry.mode === "quote").length,
+    priority0: refreshPlan.filter((entry) => entry.priority === 0).length,
+    priority1: refreshPlan.filter((entry) => entry.priority === 1).length,
+    priority2: refreshPlan.filter((entry) => entry.priority === 2).length,
+    symbols: refreshPlan.map((entry) => `${entry.mode}:${entry.ticker.metadata.ticker}`),
+  });
 
-  const refreshPlan = buildRefreshPlan(config, tickerMap, paneStateSeed, sessionSnapshot);
   if (primeCachedFinancials) {
-    const cachedPrimeEntries = resolveCachedFinancialPrimeEntries(refreshPlan, sessionSnapshot, dataProvider);
+    const cachedPrimeEntries = measurePerf(
+      "startup.resolve-cached-financial-prime",
+      () => resolveCachedFinancialPrimeEntries(refreshPlan, sessionSnapshot, dataProvider),
+      { financialRefreshCount: refreshPlan.filter((entry) => entry.mode === "financials").length },
+    );
     if (cachedPrimeEntries.length > 0) {
-      primeCachedFinancials(cachedPrimeEntries);
+      measurePerf("startup.prime-cached-financials", () => {
+        primeCachedFinancials(cachedPrimeEntries);
+      }, { count: cachedPrimeEntries.length });
+      startupLog.info("cached financials primed", {
+        count: cachedPrimeEntries.length,
+        symbols: cachedPrimeEntries.map((entry) => entry.ticker.metadata.ticker),
+      });
     }
   }
 
-  dispatch({ type: "SET_INITIALIZED" });
+  measurePerf("startup.dispatch-initialized", () => {
+    dispatch({ type: "SET_INITIALIZED" });
+  });
 
-  for (const entry of refreshPlan) {
-    if (entry.mode === "financials") {
-      refreshTicker(entry.ticker.metadata.ticker, entry.ticker.metadata.exchange, entry.ticker, entry.priority);
-    } else {
-      refreshQuote(entry.ticker.metadata.ticker, entry.ticker.metadata.exchange, entry.ticker, entry.priority);
+  measurePerf("startup.enqueue-refresh-plan", () => {
+    for (const entry of refreshPlan) {
+      if (entry.mode === "financials") {
+        refreshTicker(entry.ticker.metadata.ticker, entry.ticker.metadata.exchange, entry.ticker, entry.priority);
+      } else {
+        refreshQuote(entry.ticker.metadata.ticker, entry.ticker.metadata.exchange, entry.ticker, entry.priority);
+      }
     }
-  }
-
-  void autoImportBrokerPositions(tickerMap);
+  }, { count: refreshPlan.length });
+
+  void measurePerfAsync("startup.auto-import-broker-positions", () => autoImportBrokerPositions(tickerMap), {
+    brokerInstanceCount: config.brokerInstances.length,
+  }).catch((error) => {
+    startupLog.warn("auto import broker positions failed", {
+      message: error instanceof Error ? error.message : String(error),
+    });
+  });
+  startupLog.info("initialize complete");
 }

package/src/state/app-context-selector.test.tsx

@@ -1,6 +1,6 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act, useRef, type Dispatch } from "react";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../renderers/opentui/test-utils";
 import { AppProvider, PaneInstanceProvider, useAppDispatch, useAppSelector, usePaneTicker, type AppAction } from "./app-context";
 import { cloneLayout, createDefaultConfig, type AppConfig } from "../types/config";
 import { applyTheme, getCurrentThemeId } from "../theme/colors";
@@ -77,6 +77,29 @@ describe("pane selectors", () => {
     expect(testSetup.captureCharFrame()).toContain("AAPL:1");
   });
 
+  test("does not rerender pane-scoped ticker consumers when another pane receives focus", async () => {
+    testSetup = await testRender(
+      <AppProvider config={createTickerDetailConfig("AAPL")}>
+        <PaneInstanceProvider paneId={TEST_PANE_ID}>
+          <DispatchCapture />
+          <PaneTickerHarness />
+        </PaneInstanceProvider>
+      </AppProvider>,
+      { width: 24, height: 4 },
+    );
+
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain("AAPL:1");
+
+    await act(() => {
+      capturedDispatch?.({ type: "FOCUS_PANE", paneId: "portfolio-list:main" });
+    });
+
+    await testSetup.renderOnce();
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain("AAPL:1");
+  });
+
   test("rerenders selector consumers when the theme changes", async () => {
     testSetup = await testRender(
       <AppProvider config={createTickerDetailConfig("AAPL")}>
@@ -98,6 +121,52 @@ describe("pane selectors", () => {
     expect(testSetup.captureCharFrame()).toContain(`${TEST_PANE_ID}:green`);
   });
 
+  test("rerenders selector consumers when the theme preview changes", async () => {
+    testSetup = await testRender(
+      <AppProvider config={createTickerDetailConfig("AAPL")}>
+        <DispatchCapture />
+        <ThemeSelectorHarness />
+      </AppProvider>,
+      { width: 32, height: 4 },
+    );
+
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain(`${TEST_PANE_ID}:amber`);
+
+    await act(() => {
+      capturedDispatch?.({ type: "PREVIEW_THEME", theme: "green" });
+    });
+
+    await testSetup.renderOnce();
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain(`${TEST_PANE_ID}:green`);
+  });
+
+  test("falls back to the committed theme when theme preview clears", async () => {
+    testSetup = await testRender(
+      <AppProvider config={createTickerDetailConfig("AAPL")}>
+        <DispatchCapture />
+        <ThemeSelectorHarness />
+      </AppProvider>,
+      { width: 32, height: 4 },
+    );
+
+    await testSetup.renderOnce();
+    await act(() => {
+      capturedDispatch?.({ type: "PREVIEW_THEME", theme: "green" });
+    });
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain(`${TEST_PANE_ID}:green`);
+
+    await act(() => {
+      capturedDispatch?.({ type: "PREVIEW_THEME", theme: null });
+    });
+
+    await testSetup.renderOnce();
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain(`${TEST_PANE_ID}:amber`);
+  });
+
   test("uses the configured theme on the first provider render", async () => {
     const config = createTickerDetailConfig("AAPL");
     config.theme = "green";

package/src/state/app-context.test.ts

@@ -1,8 +1,9 @@
 import { describe, expect, test } from "bun:test";
 import { appReducer, createInitialState, resolveCollectionForPane, resolveTickerForPane } from "./app-context";
 import { cloneLayout, createDefaultConfig, createPaneInstance } from "../types/config";
-import type { AppSessionSnapshot } from "./session-persistence";
+import type { AppSessionSnapshot } from "../core/state/session-persistence";
 import { buildBrokerPortfolioId } from "../utils/broker-instances";
+import type { DesktopSharedStateSnapshot } from "../types/desktop-window";
 
 describe("resolveTickerForPane", () => {
   test("uses a portfolio pane cursor for inspector follow panes", () => {
@@ -75,6 +76,72 @@ describe("resolveTickerForPane", () => {
     expect(state.focusedPaneId).toBe("ticker-detail:main");
   });
 
+  test("raises the session-focused floating pane above stale saved z-order", () => {
+    const config = createDefaultConfig("/tmp/gloomberb-test");
+    config.layout = {
+      ...config.layout,
+      dockRoot: null,
+      floating: [
+        { instanceId: "ticker-detail:main", x: 4, y: 2, width: 60, height: 22, zIndex: 5 },
+        { instanceId: "chat:main", x: 8, y: 4, width: 48, height: 18, zIndex: 20 },
+      ],
+    };
+    config.layouts = config.layouts.map((entry, index) => (
+      index === config.activeLayoutIndex ? { ...entry, layout: cloneLayout(config.layout) } : entry
+    ));
+    const sessionSnapshot: AppSessionSnapshot = {
+      paneState: {},
+      focusedPaneId: "ticker-detail:main",
+      activePanel: "right",
+      statusBarVisible: true,
+      openPaneIds: ["ticker-detail:main", "chat:main"],
+      hydrationTargets: [],
+      exchangeCurrencies: ["USD"],
+      savedAt: Date.now(),
+    };
+
+    const state = createInitialState(config, sessionSnapshot);
+    const tickerEntry = state.config.layout.floating.find((entry) => entry.instanceId === "ticker-detail:main");
+    const chatEntry = state.config.layout.floating.find((entry) => entry.instanceId === "chat:main");
+
+    expect(tickerEntry?.zIndex).toBe(21);
+    expect((tickerEntry?.zIndex ?? 0) > (chatEntry?.zIndex ?? 0)).toBe(true);
+    expect(state.config.layouts[state.config.activeLayoutIndex]?.layout.floating.find(
+      (entry) => entry.instanceId === "ticker-detail:main",
+    )?.zIndex).toBe(21);
+  });
+
+  test("raises the desktop-snapshot focused floating pane during hydration", () => {
+    const config = createDefaultConfig("/tmp/gloomberb-test");
+    config.layout = {
+      ...config.layout,
+      dockRoot: null,
+      floating: [
+        { instanceId: "ticker-detail:main", x: 4, y: 2, width: 60, height: 22, zIndex: 5 },
+        { instanceId: "chat:main", x: 8, y: 4, width: 48, height: 18, zIndex: 20 },
+      ],
+    };
+    config.layouts = config.layouts.map((entry, index) => (
+      index === config.activeLayoutIndex ? { ...entry, layout: cloneLayout(config.layout) } : entry
+    ));
+    const initial = createInitialState(config);
+    const snapshot: DesktopSharedStateSnapshot = {
+      config,
+      paneState: {},
+      focusedPaneId: "ticker-detail:main",
+      activePanel: "right",
+      statusBarVisible: true,
+    };
+
+    const state = appReducer(initial, { type: "HYDRATE_DESKTOP_SNAPSHOT", snapshot });
+    const tickerEntry = state.config.layout.floating.find((entry) => entry.instanceId === "ticker-detail:main");
+    const chatEntry = state.config.layout.floating.find((entry) => entry.instanceId === "chat:main");
+
+    expect(state.focusedPaneId).toBe("ticker-detail:main");
+    expect(tickerEntry?.zIndex).toBe(21);
+    expect((tickerEntry?.zIndex ?? 0) > (chatEntry?.zIndex ?? 0)).toBe(true);
+  });
+
   test("preserves broker portfolio selection until broker portfolios are restored", () => {
     const config = createDefaultConfig("/tmp/gloomberb-test");
     const brokerPortfolioId = buildBrokerPortfolioId("ibkr-live", "DU12345");
@@ -356,12 +423,13 @@ describe("quote merging", () => {
       priceHistory: [],
       quote: {
         symbol: "IQE.L",
+        providerId: "yahoo",
         price: 0.245,
         currency: "GBP",
         change: -0.021,
         changePercent: -7.89,
         lastUpdated: Date.now() - 1000,
-        dataSource: "yahoo",
+        dataSource: "delayed",
       },
     });
 
@@ -382,7 +450,7 @@ describe("quote merging", () => {
 
     expect(next.financials.get("IQE")?.quote?.price).toBe(0.245);
     expect(next.financials.get("IQE")?.quote?.symbol).toBe("IQE.L");
-    expect(next.financials.get("IQE")?.quote?.dataSource).toBe("yahoo");
+    expect(next.financials.get("IQE")?.quote?.dataSource).toBe("delayed");
   });
 });
 

package/src/state/app-context.test.tsx

@@ -86,6 +86,9 @@ describe("appReducer command bar state", () => {
 
   test("tracks layout undo and redo history", () => {
     const initial = createInitialState(createDefaultConfig("/tmp/gloomberb-test"));
+    const defaultRatio = initial.config.layout.dockRoot && initial.config.layout.dockRoot.kind === "split"
+      ? initial.config.layout.dockRoot.ratio
+      : null;
     const changedLayout = cloneLayout(initial.config.layout);
     if (!changedLayout.dockRoot || changedLayout.dockRoot.kind !== "split") {
       throw new Error("expected split dock root");
@@ -103,7 +106,7 @@ describe("appReducer command bar state", () => {
     const undone = appReducer(changed, { type: "UNDO_LAYOUT" });
     expect(undone.config.layout.dockRoot && undone.config.layout.dockRoot.kind === "split"
       ? undone.config.layout.dockRoot.ratio
-      : null).toBe(0.4);
+      : null).toBe(defaultRatio);
     expect(undone.layoutHistory[0]?.future).toHaveLength(1);
 
     const redone = appReducer(undone, { type: "REDO_LAYOUT" });
@@ -115,6 +118,10 @@ describe("appReducer command bar state", () => {
 
   test("keeps layout history isolated per saved layout", () => {
     const initial = createInitialState(createDefaultConfig("/tmp/gloomberb-test"));
+    const defaultRatio = initial.config.layout.dockRoot && initial.config.layout.dockRoot.kind === "split"
+      ? initial.config.layout.dockRoot.ratio
+      : null;
+    const newLayoutIndex = initial.config.layouts.length;
 
     const firstLayout = cloneLayout(initial.config.layout);
     if (!firstLayout.dockRoot || firstLayout.dockRoot.kind !== "split") {
@@ -126,10 +133,10 @@ describe("appReducer command bar state", () => {
     state = appReducer(state, { type: "NEW_LAYOUT", name: "Research" });
 
     const noUndoOnFreshLayout = appReducer(state, { type: "UNDO_LAYOUT" });
-    expect(noUndoOnFreshLayout.config.activeLayoutIndex).toBe(1);
+    expect(noUndoOnFreshLayout.config.activeLayoutIndex).toBe(newLayoutIndex);
     expect(noUndoOnFreshLayout.config.layout.dockRoot && noUndoOnFreshLayout.config.layout.dockRoot.kind === "split"
       ? noUndoOnFreshLayout.config.layout.dockRoot.ratio
-      : null).toBe(0.4);
+      : null).toBe(defaultRatio);
 
     const secondLayout = cloneLayout(noUndoOnFreshLayout.config.layout);
     if (!secondLayout.dockRoot || secondLayout.dockRoot.kind !== "split") {
@@ -144,14 +151,14 @@ describe("appReducer command bar state", () => {
     expect(firstUndone.config.activeLayoutIndex).toBe(0);
     expect(firstUndone.config.layout.dockRoot && firstUndone.config.layout.dockRoot.kind === "split"
       ? firstUndone.config.layout.dockRoot.ratio
-      : null).toBe(0.4);
+      : null).toBe(defaultRatio);
 
-    const backToSecond = appReducer(firstUndone, { type: "SWITCH_LAYOUT", index: 1 });
+    const backToSecond = appReducer(firstUndone, { type: "SWITCH_LAYOUT", index: newLayoutIndex });
     const secondUndone = appReducer(backToSecond, { type: "UNDO_LAYOUT" });
-    expect(secondUndone.config.activeLayoutIndex).toBe(1);
+    expect(secondUndone.config.activeLayoutIndex).toBe(newLayoutIndex);
     expect(secondUndone.config.layout.dockRoot && secondUndone.config.layout.dockRoot.kind === "split"
       ? secondUndone.config.layout.dockRoot.ratio
-      : null).toBe(0.4);
+      : null).toBe(defaultRatio);
   });
 
   test("tracks manual update-check feedback", () => {