gloomberb 0.5.1 → 0.6.0

package/src/components/command-bar/__snapshots__/command-bar.test.tsx.snap

@@ -16,7 +16,7 @@ exports[`CommandBar renders the default layout with opencode-style chrome 1`] =
                 Quote Monitor                           QQ                      
                                                                                 
                 Search                                                          
-                Search Ticker                           T                       
+                Description                             DES                     
                                                                                 
                 Navigation                                                      
                 Help                                    HELP                    
@@ -100,7 +100,7 @@ exports[`CommandBar collapses the trailing column on narrow terminals 1`] = `
        Quote Monitor               QQ     
                                           
        Search                             
-       Search Ticker               T      
+       Description                 DES    
                                           
                                           
                                           
@@ -112,8 +112,8 @@ exports[`CommandBar groups ticker search sections and keeps saved matches above
 "                                                                                
                                                                                 
                 Commands                                                        
-                T appl                                                          
-                Shortcut: Open APPL                                             
+                DES appl                                                        
+                Shortcut: DES APPL                                              
                 Saved                                                           
                 AAPL                                    NASDAQ                  
                                                                                 

package/src/components/command-bar/command-bar.test.tsx

@@ -1,9 +1,9 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act, useReducer } from "react";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../../renderers/opentui/test-utils";
 import { DialogProvider } from "@opentui-ui/dialog/react";
 import { CommandBar } from "./command-bar";
-import { AppContext, type AppState, appReducer, createInitialState } from "../../state/app-context";
+import { AppContext, type AppState, appReducer, createInitialState, getEffectiveThemeId } from "../../state/app-context";
 import { createTestDataProvider } from "../../test-support/data-provider";
 import { cloneLayout, createDefaultConfig, type AppConfig } from "../../types/config";
 import type { DataProvider } from "../../types/data-provider";
@@ -214,7 +214,7 @@ function makePluginRegistry(hasPaneSettings: (paneId: string) => boolean = () =>
     hasPaneSettings,
     events: { emit: () => {} },
     hideWidget: () => {},
-    pinTickerFn: () => {},
+    pinTicker: () => {},
     showWidget: () => {},
     updateLayoutFn: () => {},
     getTermSizeFn: () => ({ width: 80, height: 24 }),
@@ -305,7 +305,7 @@ function CommandBarHarness({
   return (
     <AppContext value={{ state: currentState, dispatch: currentDispatch }}>
       <DialogProvider dialogOptions={{ style: { backgroundColor: "#000000", borderColor: "#ffffff", borderStyle: "single" } }}>
-        {live && <text>{`theme:${currentState.config.theme}`}</text>}
+        {live && <text>{`theme:${getEffectiveThemeId(currentState)}`}</text>}
         {showQueryState && <text>{`query:${currentState.commandBarQuery}`}</text>}
         {currentState.commandBarOpen && (
           <CommandBar
@@ -537,6 +537,70 @@ describe("CommandBar", () => {
     expect(workflowFrame).toContain("AMD");
   });
 
+  test("prefills alert command targets from the resolved quote", async () => {
+    const quoteProvider = createTestDataProvider({
+      id: "test",
+      search: async () => [],
+      getQuote: async (symbol: string) => ({
+        symbol,
+        price: 201.5,
+        currency: "USD",
+        change: 1,
+        changePercent: 0.5,
+        name: "Advanced Micro Devices",
+        exchangeName: "NASDAQ",
+        lastUpdated: Date.now(),
+        dataSource: "live",
+      }),
+    });
+
+    testSetup = await testRender(<CommandBarHarness
+      query="SA AMD"
+      dataProvider={quoteProvider}
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("set-alert", {
+          id: "set-alert",
+          label: "Add Alert",
+          description: "Create a price alert from a symbol, condition, and target price",
+          keywords: ["add", "set", "alert", "price", "trigger"],
+          shortcut: "SA",
+          shortcutArg: {
+            placeholder: "symbol condition price",
+            kind: "ticker",
+            parse: (arg: string) => ({ symbol: arg.trim().toUpperCase() }),
+          },
+          category: "data",
+          wizardLayout: "form",
+          wizard: [
+            { key: "symbol", label: "Symbol", type: "text" },
+            {
+              key: "condition",
+              label: "Condition",
+              type: "select",
+              options: [{ label: "Above", value: "above" }],
+            },
+            { key: "price", label: "Target Price", type: "number" },
+          ],
+          execute: async () => {},
+        });
+      }}
+    />, {
+      width: 90,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+
+    const workflowFrame = await waitForFrameToContain("Advanced Micro Devices");
+    expect(workflowFrame).toContain("201.5");
+  });
+
   test("updates workflow select fields from the option picker", async () => {
     testSetup = await testRender(<CommandBarHarness
       query="SA AMD"
@@ -611,6 +675,8 @@ describe("CommandBar", () => {
   test("opens plugin command workflows from a launch request", async () => {
     testSetup = await testRender(<CommandBarHarness
       query=""
+      selectedTicker="AMD"
+      extraTickers={[makeTicker("AMD", "Advanced Micro Devices")]}
       configureState={(state) => ({
         ...state,
         commandBarLaunchRequest: {
@@ -625,6 +691,13 @@ describe("CommandBar", () => {
           label: "Set Alert",
           keywords: ["alert", "price", "trigger"],
           shortcut: "SA",
+          shortcutArg: {
+            placeholder: "symbol condition price",
+            kind: "ticker",
+            parse: (_arg: string, context?: { activeTicker: string | null }) => (
+              context?.activeTicker ? { symbol: context.activeTicker } : {}
+            ),
+          },
           category: "data",
           wizardLayout: "form",
           wizard: [
@@ -652,6 +725,7 @@ describe("CommandBar", () => {
     expect(frame).toContain("Set Alert");
     expect(frame).toContain("Symbol");
     expect(frame).toContain("Condition");
+    expect(frame).toContain("AMD");
   });
 
   test("renders theme prefix results in the root query", async () => {
@@ -727,6 +801,32 @@ describe("CommandBar", () => {
     expect(frame).toContain("theme:green");
   });
 
+  test("does not preview a theme from mouse hover alone", async () => {
+    testSetup = await testRender(<CommandBarHarness query="TH " live />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+    const frame = testSetup.captureCharFrame();
+    const rows = frame.split("\n");
+    const hoveredRow = rows.findIndex((line) => line.includes("Green"));
+    const hoveredCol = rows[hoveredRow]?.indexOf("Green") ?? -1;
+
+    expect(hoveredRow).toBeGreaterThanOrEqual(0);
+    expect(hoveredCol).toBeGreaterThanOrEqual(0);
+
+    await act(async () => {
+      await testSetup!.mockMouse.moveTo(hoveredCol + 1, hoveredRow);
+      await testSetup!.renderOnce();
+    });
+    await testSetup.renderOnce();
+
+    const hoveredFrame = testSetup.captureCharFrame();
+    expect(hoveredFrame).toContain("theme:amber");
+    expect(hoveredFrame).not.toContain("theme:green");
+  });
+
   test("keeps the selected theme after pressing enter in root theme mode", async () => {
     testSetup = await testRender(<CommandBarHarness query="TH " live />, {
       width: 80,
@@ -753,8 +853,51 @@ describe("CommandBar", () => {
     expect(frame).not.toContain("Commands");
   });
 
+  test("uses pending keyboard theme selection when enter follows before a repaint", async () => {
+    testSetup = await testRender(<CommandBarHarness query="TH " live />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+    await act(async () => {
+      testSetup!.mockInput.pressArrow("down");
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+    await testSetup.renderOnce();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("theme:green");
+    expect(frame).not.toContain("theme:amber");
+    expect(frame).not.toContain("Commands");
+  });
+
+  test("clears theme preview when leaving root theme mode", async () => {
+    testSetup = await testRender(<CommandBarHarness query="TH " live />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+    await act(async () => {
+      testSetup!.mockInput.pressArrow("down");
+      await testSetup!.renderOnce();
+    });
+    expect(testSetup.captureCharFrame()).toContain("theme:green");
+
+    await emitKeypress(testSetup, { name: "u", ctrl: true });
+    await testSetup.renderOnce();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("theme:amber");
+    expect(frame).not.toContain("theme:green");
+    expect(frame).toContain("Commands");
+  });
+
   test("keeps typed prefixes in the root query until a result is activated", async () => {
-    testSetup = await testRender(<CommandBarHarness query="T " />, {
+    testSetup = await testRender(<CommandBarHarness query="DES " />, {
       width: 80,
       height: 24,
     });
@@ -763,7 +906,7 @@ describe("CommandBar", () => {
 
     let frame = testSetup.captureCharFrame();
     expect(frame).toContain("Commands");
-    expect(frame).toContain("T");
+    expect(frame).toContain("DES");
     expect(frame).toContain("Type a ticker symbol");
     expect(frame).not.toContain("Back");
   });
@@ -785,7 +928,7 @@ describe("CommandBar", () => {
 
     const frame = testSetup.captureCharFrame();
     expect(frame).toContain("Back");
-    expect(frame).toContain("Search Ticker");
+    expect(frame).toContain("Security Description");
   });
 
   test("QQ with an active ticker shows ghost completion and tab inserts the symbol", async () => {
@@ -845,13 +988,13 @@ describe("CommandBar", () => {
   });
 
   test("clears the root query with cmd-backspace", async () => {
-    testSetup = await testRender(<CommandBarHarness query="T AMD" />, {
+    testSetup = await testRender(<CommandBarHarness query="DES AMD" />, {
       width: 80,
       height: 24,
     });
 
     await testSetup.renderOnce();
-    expect(testSetup.captureCharFrame()).toContain("T AMD");
+    expect(testSetup.captureCharFrame()).toContain("DES AMD");
 
     await act(async () => {
       testSetup!.mockInput.pressKey("backspace", { meta: true });
@@ -861,7 +1004,7 @@ describe("CommandBar", () => {
     const frame = testSetup.captureCharFrame();
     expect(frame).toContain("Commands");
     expect(frame).toContain("Search");
-    expect(frame).not.toContain("T AMD");
+    expect(frame).not.toContain("DES AMD");
   });
 
   test("pressing the close shortcut at the root closes the command bar", async () => {
@@ -883,7 +1026,7 @@ describe("CommandBar", () => {
   test("loads provider-backed ticker search results in the root command results", async () => {
     testSetup = await testRender(
       <CommandBarHarness
-        query="T appl"
+        query="DES appl"
         dataProvider={makeDataProvider(async () => [
           { providerId: "yahoo", symbol: "IVSX", name: "Invsivx Holdings", exchange: "NYSE", type: "ETF" },
           { providerId: "yahoo", symbol: "AAPL", name: "Apple Inc", exchange: "NASDAQ", type: "EQUITY" },
@@ -903,14 +1046,14 @@ describe("CommandBar", () => {
     expect(frame).toContain("AAOI");
   });
 
-  test("T MSFT opens an exact ticker directly", async () => {
+  test("DES MSFT opens an exact ticker directly", async () => {
     const pinned: string[] = [];
 
     testSetup = await testRender(
       <CommandBarHarness
-        query="T MSFT"
+        query="DES MSFT"
         configurePluginRegistry={(pluginRegistry) => {
-          pluginRegistry.pinTickerFn = (symbol) => {
+          pluginRegistry.pinTicker = (symbol) => {
             pinned.push(symbol);
           };
         }}
@@ -1445,7 +1588,7 @@ describe("CommandBar", () => {
       <CommandBarHarness
         query=""
         configurePluginRegistry={(pluginRegistry) => {
-          pluginRegistry.pinTickerFn = (symbol) => {
+          pluginRegistry.pinTicker = (symbol) => {
             pinned.push(symbol);
           };
         }}
@@ -1566,7 +1709,7 @@ describe("CommandBar", () => {
   test("moves through long result lists with the mouse wheel", async () => {
     testSetup = await testRender(
       <CommandBarHarness
-        query="NP scratch"
+        query="scratch"
         configurePluginRegistry={(pluginRegistry) => {
           const paneTemplates = pluginRegistry.paneTemplates as Map<string, any>;
           for (let index = 0; index < 20; index++) {
@@ -1684,8 +1827,8 @@ describe("CommandBar", () => {
     expect(frame).toContain("1c / 1d");
   });
 
-  test("renders new pane mode with plugin-defined pane templates", async () => {
-    testSetup = await testRender(<CommandBarHarness query="NP chat" />, {
+  test("filters plugin-defined pane templates directly from the root query", async () => {
+    testSetup = await testRender(<CommandBarHarness query="chat" />, {
       width: 100,
       height: 18,
     });
@@ -1724,6 +1867,80 @@ describe("CommandBar", () => {
     expect(frame).toContain("QQ");
   });
 
+  test("shows pane templates that share the same shortcut", async () => {
+    testSetup = await testRender(<CommandBarHarness
+      query="DUP"
+      configurePluginRegistry={(pluginRegistry) => {
+        const paneTemplates = pluginRegistry.paneTemplates as Map<string, any>;
+        paneTemplates.set("first-duplicate-pane", {
+          id: "first-duplicate-pane",
+          paneId: "first-duplicate",
+          label: "First Duplicate",
+          description: "First pane using a shared shortcut",
+          shortcut: { prefix: "DUP" },
+        });
+        paneTemplates.set("second-duplicate-pane", {
+          id: "second-duplicate-pane",
+          paneId: "second-duplicate",
+          label: "Second Duplicate",
+          description: "Second pane using a shared shortcut",
+          shortcut: { prefix: "DUP" },
+        });
+      }}
+    />, {
+      width: 100,
+      height: 18,
+    });
+
+    await testSetup.renderOnce();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("First Duplicate");
+    expect(frame).toContain("Second Duplicate");
+  });
+
+  test("does not treat no-argument shortcut prefixes as typed pane names", async () => {
+    const created: Array<{ templateId: string; options?: Record<string, unknown> }> = [];
+
+    testSetup = await testRender(<CommandBarHarness
+      query="Top News"
+      configurePluginRegistry={(pluginRegistry) => {
+        pluginRegistry.createPaneFromTemplateAsyncFn = async (templateId, options) => {
+          created.push({ templateId, options });
+        };
+        const paneTemplates = pluginRegistry.paneTemplates as Map<string, any>;
+        paneTemplates.set("market-movers-pane", {
+          id: "market-movers-pane",
+          paneId: "market-movers",
+          label: "Market Movers",
+          description: "Track market gainers and losers",
+          shortcut: { prefix: "MOST" },
+        });
+        paneTemplates.set("news-top-pane", {
+          id: "news-top-pane",
+          paneId: "news-top",
+          label: "Top News",
+          description: "Curated top market stories ranked by importance",
+          shortcut: { prefix: "TOP" },
+        });
+      }}
+    />, {
+      width: 100,
+      height: 18,
+    });
+
+    await testSetup.renderOnce();
+    expect(testSetup.captureCharFrame()).toContain("Top News");
+
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+
+    expect(created).toEqual([{ templateId: "news-top-pane", options: undefined }]);
+  });
+
   test("opens plugin command wizards inline inside the command bar", async () => {
     let submittedValues: Record<string, string> | undefined;
 
@@ -1794,6 +2011,38 @@ describe("CommandBar", () => {
     });
   });
 
+  test("does not duplicate placeholder text as workflow field help", async () => {
+    testSetup = await testRender(<CommandBarHarness
+      query="Duplicate Form"
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("plugin:duplicate-form", {
+          id: "plugin:duplicate-form",
+          label: "Duplicate Form",
+          description: "Check workflow field copy",
+          category: "config",
+          wizard: [
+            { key: "name", label: "Name", type: "text", placeholder: "Profile name" },
+            { key: "token", label: "Token", type: "text", placeholder: "repeat marker", body: ["repeat marker"] },
+          ],
+          execute: async () => {},
+        } as any);
+        pluginRegistry.getCommandPluginId = () => "notes";
+      }}
+    />, {
+      width: 100,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await testSetup!.renderOnce();
+    });
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame.match(/repeat marker/g)?.length ?? 0).toBe(1);
+  });
+
   test("does not treat backspace as Back inside workflow text fields", async () => {
     testSetup = await testRender(<CommandBarHarness
       query="Plugin Login"
@@ -1804,7 +2053,7 @@ describe("CommandBar", () => {
           description: "Authenticate without leaving the command bar",
           category: "config",
           wizard: [
-            { key: "username", label: "Username", type: "text", placeholder: "vince" },
+            { key: "username", label: "Username", type: "text" },
           ],
           execute: async () => {},
         } as any);
@@ -2402,7 +2651,7 @@ describe("CommandBar", () => {
   test("groups ticker search sections and keeps saved matches above looser provider results", async () => {
     testSetup = await testRender(
       <CommandBarHarness
-        query="T appl"
+        query="DES appl"
         dataProvider={makeDataProvider(async () => [
           { providerId: "yahoo", symbol: "IVSX", name: "Invsivx Holdings", exchange: "NYSE", type: "ETF" },
           { providerId: "yahoo", symbol: "AAPL", name: "Apple Inc", exchange: "NASDAQ", type: "EQUITY" },