gloomberb 0.5.0 → 0.6.0

package/src/plugins/builtin/portfolio-list/settings.ts

@@ -7,10 +7,8 @@ export interface PortfolioPaneSettings {
   columnIds: string[];
   collectionScope: CollectionScope;
   visibleCollectionIds: string[];
-  hideTabs: boolean;
   hideHeader: boolean;
   hideCash: boolean;
-  lockedCollectionId: string;
   showSparklines?: boolean;
 }
 
@@ -95,13 +93,6 @@ function resolveCollectionOptions(entries: CollectionEntry[]): PaneSettingOption
   }));
 }
 
-function resolveLockedCollectionId(settings: PortfolioPaneSettings, visibleCollections: CollectionEntry[]): string {
-  if (visibleCollections.some((entry) => entry.id === settings.lockedCollectionId)) {
-    return settings.lockedCollectionId;
-  }
-  return visibleCollections[0]?.id ?? "";
-}
-
 export function getPortfolioPaneSettings(settings: Record<string, unknown> | undefined): PortfolioPaneSettings {
   const columnIds = Array.isArray(settings?.columnIds)
     ? settings.columnIds.filter((value): value is string => typeof value === "string")
@@ -114,25 +105,20 @@ export function getPortfolioPaneSettings(settings: Record<string, unknown> | und
     columnIds: columnIds.length > 0 ? columnIds : DEFAULT_PORTFOLIO_COLUMN_IDS,
     collectionScope: isCollectionScope(settings?.collectionScope) ? settings.collectionScope : "all",
     visibleCollectionIds,
-    hideTabs: settings?.hideTabs === true,
     hideHeader: settings?.hideHeader === true,
     hideCash: settings?.hideCash === true,
-    lockedCollectionId: typeof settings?.lockedCollectionId === "string" ? settings.lockedCollectionId : "",
     showSparklines: settings?.showSparklines === true,
   };
 }
 
-export function createPortfolioPaneSettings(overrides: Partial<PortfolioPaneSettings> = {}): PortfolioPaneSettings {
-  return {
-    columnIds: [...(overrides.columnIds ?? DEFAULT_PORTFOLIO_COLUMN_IDS)],
-    collectionScope: overrides.collectionScope ?? "all",
-    visibleCollectionIds: [...(overrides.visibleCollectionIds ?? [])],
-    hideTabs: overrides.hideTabs ?? false,
-    hideHeader: overrides.hideHeader ?? false,
-    hideCash: overrides.hideCash ?? false,
-    lockedCollectionId: overrides.lockedCollectionId ?? "",
-    showSparklines: overrides.showSparklines ?? false,
-  };
+export function cleanPortfolioPaneSettings(settings: Record<string, unknown>): Record<string, unknown> {
+  const nextSettings = { ...settings };
+  delete nextSettings.hideTabs;
+  delete nextSettings.lockedCollectionId;
+  if (nextSettings.collectionScope !== "custom") {
+    delete nextSettings.visibleCollectionIds;
+  }
+  return nextSettings;
 }
 
 export function getCollectionEntries(config: AppConfig): CollectionEntry[] {
@@ -161,16 +147,22 @@ export function resolveScopedCollectionEntries(entries: CollectionEntry[], setti
 export function resolveActiveCollectionId(
   currentCollectionId: string,
   visibleCollections: CollectionEntry[],
-  settings: PortfolioPaneSettings,
 ): string {
   if (visibleCollections.length === 0) return "";
-  if (settings.hideTabs) {
-    return resolveLockedCollectionId(settings, visibleCollections);
-  }
   if (visibleCollections.some((entry) => entry.id === currentCollectionId)) {
     return currentCollectionId;
   }
-  return resolveLockedCollectionId(settings, visibleCollections);
+  return visibleCollections[0]?.id ?? "";
+}
+
+export function resolvePortfolioPaneCollectionId(
+  config: AppConfig,
+  rawSettings: Record<string, unknown> | undefined,
+  currentCollectionId: string,
+): string {
+  const settings = getPortfolioPaneSettings(rawSettings);
+  const visibleCollections = resolveScopedCollectionEntries(getCollectionEntries(config), settings);
+  return resolveActiveCollectionId(currentCollectionId, visibleCollections);
 }
 
 export function resolveVisibleColumns(columnIds: string[], isPortfolioTab: boolean): ColumnConfig[] {
@@ -188,15 +180,12 @@ export function resolveVisibleColumns(columnIds: string[], isPortfolioTab: boole
 
 export function buildPortfolioPaneSettingsDef(config: AppConfig, settings: PortfolioPaneSettings): PaneSettingsDef {
   const collectionEntries = getCollectionEntries(config);
-  const scopedEntries = resolveScopedCollectionEntries(collectionEntries, settings);
   const allCollectionOptions = resolveCollectionOptions(collectionEntries);
-  const lockedCollectionOptions = resolveCollectionOptions(scopedEntries.length > 0 ? scopedEntries : collectionEntries);
 
   const fields: PaneSettingsDef["fields"] = [
     {
       key: "columnIds",
       label: "Columns",
-      description: "Choose which columns this pane shows and in what order.",
       type: "ordered-multi-select",
       options: PORTFOLIO_COLUMN_DEFS.map((column) => ({
         value: column.id,
@@ -209,7 +198,6 @@ export function buildPortfolioPaneSettingsDef(config: AppConfig, settings: Portf
     {
       key: "collectionScope",
       label: "Collections",
-      description: "Control which portfolios or watchlists appear in this pane.",
       type: "select",
       options: COLLECTION_SCOPE_OPTIONS,
     },
@@ -219,47 +207,27 @@ export function buildPortfolioPaneSettingsDef(config: AppConfig, settings: Portf
     fields.push({
       key: "visibleCollectionIds",
       label: "Visible Collections",
-      description: "Pick the exact collections that should appear in this pane.",
       type: "multi-select",
       options: allCollectionOptions,
     });
   }
 
-  fields.push({
-    key: "hideTabs",
-    label: "Hide Tabs",
-    description: "Hide the collection tab bar and lock this pane to one collection.",
-    type: "toggle",
-  });
   fields.push({
     key: "hideHeader",
     label: "Hide Header Bar",
-    description: "Hide the summary bar showing portfolio value, P&L, and account metrics.",
     type: "toggle",
   });
   fields.push({
     key: "hideCash",
     label: "Hide Cash Positions",
-    description: "Hide the cash & margin drawer at the bottom of the pane.",
     type: "toggle",
   });
   fields.push({
     key: "showSparklines",
     label: "Sparklines",
-    description: "Show a tiny price history chart in each row.",
     type: "toggle",
   });
 
-  if (settings.hideTabs && lockedCollectionOptions.length > 0) {
-    fields.push({
-      key: "lockedCollectionId",
-      label: "Locked Collection",
-      description: "Choose which collection this pane should stay pinned to.",
-      type: "select",
-      options: lockedCollectionOptions,
-    });
-  }
-
   return {
     title: "Portfolio Pane Settings",
     fields,

package/src/plugins/builtin/portfolio-list/summary.tsx

@@ -1,11 +1,12 @@
-import { TextAttributes } from "@opentui/core";
+import { Box, Text } from "../../../ui";
+import { TextAttributes } from "../../../ui";
 import { colors, priceColor } from "../../../theme/colors";
 import type { AppState } from "../../../state/app-context";
+import type { BrokerConnectionStatus } from "../../../types/broker";
 import type { Portfolio } from "../../../types/ticker";
 import type { BrokerAccount, BrokerCashBalance } from "../../../types/trading";
 import { formatCompact, formatPercentRaw } from "../../../utils/format";
 import { getBrokerInstance } from "../../../utils/broker-instances";
-import type { IbkrSnapshot } from "../../ibkr/gateway-service";
 import type { PortfolioSummaryTotals } from "./metrics";
 
 export interface PortfolioSummarySegment {
@@ -29,6 +30,11 @@ export interface ResolvedPortfolioAccountState extends PortfolioSummaryAccountSt
   visibleCashBalances: BrokerCashBalance[];
 }
 
+export interface LiveBrokerAccountSnapshot {
+  status: BrokerConnectionStatus | null;
+  accounts: BrokerAccount[];
+}
+
 function createSummarySegment(
   id: string,
   parts: PortfolioSummarySegment["parts"],
@@ -101,7 +107,7 @@ function findPortfolioAccount(
 export function resolvePortfolioAccountState(
   portfolio: Portfolio | null,
   state: Pick<AppState, "config" | "brokerAccounts">,
-  liveSnapshot: IbkrSnapshot,
+  liveSnapshot: LiveBrokerAccountSnapshot,
 ): ResolvedPortfolioAccountState | null {
   if (!portfolio?.brokerInstanceId) return null;
 
@@ -109,9 +115,8 @@ export function resolvePortfolioAccountState(
   const cachedAccounts = state.brokerAccounts[portfolio.brokerInstanceId] ?? [];
   const cachedAccount = findPortfolioAccount(cachedAccounts, portfolio);
 
-  const liveAccount = brokerInstance?.brokerType === "ibkr"
-    && brokerInstance.connectionMode === "gateway"
-    && liveSnapshot.status.state === "connected"
+  const liveAccount = brokerInstance
+    && liveSnapshot.status?.state === "connected"
     ? findPortfolioAccount(liveSnapshot.accounts, portfolio)
     : undefined;
 
@@ -217,24 +222,24 @@ export function buildPortfolioSummarySegments({
 export function renderSummarySegments(segments: PortfolioSummarySegment[], width: number) {
   if (segments.length === 0) return null;
   return (
-    <box flexDirection="row" width={width} justifyContent="flex-start" overflow="hidden">
+    <Box flexDirection="row" width={width} justifyContent="flex-start" overflow="hidden">
       {segments.map((segment, segmentIndex) => (
-        <box key={segment.id} flexDirection="row">
-          {segmentIndex > 0 && <text fg={colors.textDim}>{"  "}</text>}
+        <Box key={segment.id} flexDirection="row">
+          {segmentIndex > 0 && <Text fg={colors.textDim}>{"  "}</Text>}
           {segment.parts.map((part, partIndex) => (
-            <box key={`${segment.id}:${partIndex}`} flexDirection="row">
-              {partIndex > 0 && <text fg={colors.textDim}>{" "}</text>}
-              <text
+            <Box key={`${segment.id}:${partIndex}`} flexDirection="row">
+              {partIndex > 0 && <Text fg={colors.textDim}>{" "}</Text>}
+              <Text
                 fg={part.color ?? (part.tone === "label" || part.tone === "muted" ? colors.textDim : colors.text)}
                 attributes={part.bold ? TextAttributes.BOLD : 0}
               >
                 {part.text}
-              </text>
-            </box>
+              </Text>
+            </Box>
           ))}
-        </box>
+        </Box>
       ))}
-    </box>
+    </Box>
   );
 }
 

package/src/plugins/builtin/portfolio-list/table.tsx

@@ -1,6 +1,11 @@
-import { useCallback, type RefObject } from "react";
-import type { ScrollBoxRenderable } from "@opentui/core";
-import { TickerListTable, type QuoteFlashDirection } from "../../../components/ticker-list-table";
+import { useCallback, useRef } from "react";
+import {
+  TickerListTableView,
+  type DataTableKeyEvent,
+  type QuoteFlashDirection,
+  type TickerListVisibleRange,
+} from "../../../components";
+import { createRowValueCache } from "../../../components/ui/row-value-cache";
 import type { ColumnConfig } from "../../../types/config";
 import type { TickerFinancials } from "../../../types/financials";
 import type { TickerRecord } from "../../../types/ticker";
@@ -8,69 +13,105 @@ import { getColumnValue, type ColumnContext } from "./metrics";
 
 export type { QuoteFlashDirection };
 
+const objectVersions = new WeakMap<object, number>();
+let nextObjectVersion = 1;
+
+function objectVersion(value: object | undefined): number {
+  if (!value) return 0;
+  const existing = objectVersions.get(value);
+  if (existing != null) return existing;
+  const next = nextObjectVersion;
+  nextObjectVersion += 1;
+  objectVersions.set(value, next);
+  return next;
+}
+
+function buildCellVersion(
+  column: ColumnConfig,
+  ticker: TickerRecord,
+  financials: TickerFinancials | undefined,
+  context: ColumnContext,
+): string {
+  const latencyNow = column.id === "latency" ? context.now : 0;
+  return [
+    column.id,
+    objectVersion(ticker),
+    objectVersion(financials),
+    objectVersion(context.exchangeRates),
+    context.activeTab ?? "",
+    context.baseCurrency,
+    latencyNow,
+  ].join("|");
+}
+
 export function PortfolioTickerTable({
   columns,
+  focused,
   sortColumnId,
   sortDirection,
   onHeaderClick,
-  headerScrollRef,
-  scrollRef,
-  syncHeaderScroll,
-  onBodyScrollActivity,
   sortedTickers,
   cursorSymbol,
-  hoveredIdx,
-  setHoveredIdx,
   setCursorSymbol,
   financialsMap,
   columnContext,
   flashSymbols,
   showSparklines,
+  onRootKeyDown,
+  onVisibleRangeChange,
+  visibleRangeBuffer,
+  resetScrollKey,
+  onRowActivate,
 }: {
   columns: ColumnConfig[];
+  focused?: boolean;
   sortColumnId: string | null;
   sortDirection: "asc" | "desc";
   onHeaderClick: (columnId: string) => void;
-  headerScrollRef: RefObject<ScrollBoxRenderable | null>;
-  scrollRef: RefObject<ScrollBoxRenderable | null>;
-  syncHeaderScroll: () => void;
-  onBodyScrollActivity: () => void;
   sortedTickers: TickerRecord[];
   cursorSymbol: string | null;
-  hoveredIdx: number | null;
-  setHoveredIdx: (index: number | null) => void;
   setCursorSymbol: (symbol: string) => void;
   financialsMap: Map<string, TickerFinancials>;
   columnContext: ColumnContext;
   flashSymbols: Map<string, QuoteFlashDirection>;
   showSparklines?: boolean;
+  onRootKeyDown?: (event: DataTableKeyEvent) => boolean | void;
+  onVisibleRangeChange?: (range: TickerListVisibleRange) => void;
+  visibleRangeBuffer?: number;
+  resetScrollKey?: unknown;
+  onRowActivate?: (ticker: TickerRecord) => void;
 }) {
+  const cellCacheRef = useRef(createRowValueCache<string, ReturnType<typeof getColumnValue>>(5000));
   const resolveCell = useCallback(
-    (column: ColumnConfig, ticker: TickerRecord, financials: TickerFinancials | undefined) => (
-      getColumnValue(column, ticker, financials, columnContext)
-    ),
+    (column: ColumnConfig, ticker: TickerRecord, financials: TickerFinancials | undefined) => {
+      const key = `${ticker.metadata.ticker}:${column.id}`;
+      const version = buildCellVersion(column, ticker, financials, columnContext);
+      return cellCacheRef.current.get(key, version, () => (
+        getColumnValue(column, ticker, financials, columnContext)
+      ));
+    },
     [columnContext],
   );
 
   return (
-    <TickerListTable
+    <TickerListTableView
+      focused={focused}
       columns={columns}
       tickers={sortedTickers}
       cursorSymbol={cursorSymbol}
-      hoveredIdx={hoveredIdx}
-      setHoveredIdx={setHoveredIdx}
       setCursorSymbol={setCursorSymbol}
       resolveCell={resolveCell}
       financialsMap={financialsMap}
-      headerScrollRef={headerScrollRef}
-      scrollRef={scrollRef}
-      syncHeaderScroll={syncHeaderScroll}
-      onBodyScrollActivity={onBodyScrollActivity}
       flashSymbols={flashSymbols}
       sortColumnId={sortColumnId}
       sortDirection={sortDirection}
       onHeaderClick={onHeaderClick}
       showSparklines={showSparklines}
+      onRootKeyDown={onRootKeyDown}
+      onVisibleRangeChange={onVisibleRangeChange}
+      visibleRangeBuffer={visibleRangeBuffer}
+      resetScrollKey={resetScrollKey}
+      onRowActivate={onRowActivate}
     />
   );
 }

package/src/plugins/builtin/portfolio-list/use-throttled-cursor-symbol.test.tsx

@@ -1,6 +1,6 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act, useState } from "react";
-import { testRender } from "@opentui/react/test-utils";
+import { testRender } from "../../../renderers/opentui/test-utils";
 import { useThrottledCursorSymbol } from "./use-throttled-cursor-symbol";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;

package/src/plugins/builtin/portfolio-list/use-throttled-cursor-symbol.ts

@@ -1,6 +1,6 @@
 import { useCallback, useEffect, useRef, useState } from "react";
 
-export const FOLLOW_CURSOR_THROTTLE_MS = 80;
+export const FOLLOW_CURSOR_THROTTLE_MS = 300;
 
 export function useThrottledCursorSymbol(
   committedCursorSymbol: string | null,

package/src/plugins/builtin/portfolio-list.test.ts

@@ -1,8 +1,27 @@
 import { describe, expect, test } from "bun:test";
+import { createDefaultConfig } from "../../types/config";
 import type { BrokerAccount } from "../../types/trading";
+import type { TickerRecord } from "../../types/ticker";
 import type { PortfolioSummaryTotals } from "./portfolio-list/metrics";
 import { buildPortfolioSummarySegments } from "./portfolio-list/summary";
-import { shouldToggleCashMarginDrawer } from "./portfolio-list";
+import { portfolioListPlugin, shouldToggleCashMarginDrawer } from "./portfolio-list";
+import { selectStreamTickers } from "./portfolio-list/pane";
+
+function ticker(symbol: string): TickerRecord {
+  return {
+    metadata: {
+      ticker: symbol,
+      exchange: "NASDAQ",
+      currency: "USD",
+      name: symbol,
+      portfolios: [],
+      watchlists: [],
+      positions: [],
+      custom: {},
+      tags: [],
+    },
+  };
+}
 
 describe("buildPortfolioSummarySegments", () => {
   const totals: PortfolioSummaryTotals = {
@@ -72,3 +91,43 @@ describe("buildPortfolioSummarySegments", () => {
     expect(shouldToggleCashMarginDrawer("j", true)).toBe(false);
   });
 });
+
+describe("selectStreamTickers", () => {
+  test("includes visible rows with overscan and clamps boundaries", () => {
+    const tickers = Array.from({ length: 20 }, (_, index) => ticker(`T${index}`));
+    expect(selectStreamTickers(tickers, { start: 3, end: 7 }).map((entry) => entry.metadata.ticker)).toEqual(
+      tickers.slice(0, 13).map((entry) => entry.metadata.ticker),
+    );
+    expect(selectStreamTickers(tickers, { start: 18, end: 20 }).map((entry) => entry.metadata.ticker)).toEqual(
+      tickers.slice(12, 20).map((entry) => entry.metadata.ticker),
+    );
+  });
+
+  test("includes selected ticker outside the visible streaming window", () => {
+    const tickers = Array.from({ length: 20 }, (_, index) => ticker(`T${index}`));
+    expect(selectStreamTickers(tickers, { start: 3, end: 7 }, "T19").map((entry) => entry.metadata.ticker)).toContain("T19");
+  });
+});
+
+describe("portfolio list pane templates", () => {
+  test("create panes with default all-collection settings", async () => {
+    const config = createDefaultConfig("/tmp/gloomberb-portfolio-list-template");
+    const context = {
+      config,
+      layout: config.layout,
+      focusedPaneId: "portfolio-list:main",
+      activeTicker: null,
+      activeCollectionId: "watchlist",
+    };
+
+    for (const templateId of ["new-collection-pane", "new-watchlist-pane"]) {
+      const template = portfolioListPlugin.paneTemplates?.find((entry) => entry.id === templateId);
+      const instance = await template?.createInstance?.(context);
+      expect(instance).toEqual({ params: { collectionId: "watchlist" } });
+    }
+
+    const portfolioTemplate = portfolioListPlugin.paneTemplates?.find((entry) => entry.id === "new-portfolio-pane");
+    const portfolioInstance = await portfolioTemplate?.createInstance?.(context);
+    expect(portfolioInstance).toEqual({ params: { collectionId: "main" } });
+  });
+});