gloomberb 0.5.0 → 0.6.0

package/src/sources/provider-router.test.ts

@@ -3,9 +3,12 @@ import { existsSync, rmSync } from "fs";
 import { tmpdir } from "os";
 import { join } from "path";
 import { AppPersistence } from "../data/app-persistence";
-import { ProviderRouter } from "./provider-router";
+import { AssetDataRouter } from "./provider-router";
+import { assetDataProvider } from "../capabilities";
 import type { BrokerAdapter } from "../types/broker";
 import type { DataProvider, QuoteSubscriptionTarget } from "../types/data-provider";
+import type { CapabilityRouteSource } from "../types/capability-route-source";
+import type { NewsArticle } from "../news/types";
 import { cloneLayout, CURRENT_CONFIG_VERSION, DEFAULT_LAYOUT } from "../types/config";
 
 const originalConsoleError = console.error;
@@ -46,9 +49,6 @@ const fallbackProvider: DataProvider = {
   async search() {
     return [];
   },
-  async getNews() {
-    return [];
-  },
   async getArticleSummary() {
     return null;
   },
@@ -57,9 +57,146 @@ const fallbackProvider: DataProvider = {
   },
 };
 
-describe("ProviderRouter", () => {
+function makeArticle(id: string): NewsArticle {
+  return {
+    id,
+    title: id,
+    url: `https://example.com/${id}`,
+    source: "Test",
+    publishedAt: new Date(),
+    topic: "general",
+    topics: ["general"],
+    sectors: [],
+    categories: [],
+    tickers: [],
+    scores: {
+      importance: 50,
+      urgency: 0,
+      marketImpact: 50,
+      novelty: 0,
+      confidence: 0,
+    },
+    importance: 50,
+    isBreaking: false,
+    isDeveloping: false,
+  };
+}
+
+describe("AssetDataRouter", () => {
+  test("routes market calls only through sources with market capability", async () => {
+    const newsOnlySource: CapabilityRouteSource = {
+      id: "news-only",
+      name: "News Only",
+      priority: 1,
+      news: {
+        fetchNews: async () => {
+          throw new Error("news-only source should not handle market requests");
+        },
+      },
+    };
+    const marketSource: CapabilityRouteSource = {
+      id: "market-source",
+      name: "Market Source",
+      priority: 10,
+      market: {
+        ...fallbackProvider,
+        id: "market-source",
+        name: "Market Source",
+        async getQuote(symbol) {
+          return {
+            symbol,
+            providerId: "market-source",
+            price: 250,
+            currency: "USD",
+            change: 1,
+            changePercent: 0.4,
+            lastUpdated: Date.now(),
+          };
+        },
+      },
+    };
+
+    const router = new AssetDataRouter(fallbackProvider, [newsOnlySource, marketSource]);
+
+    const quote = await router.getQuote("AAPL", "NASDAQ");
+
+    expect(quote.providerId).toBe("market-source");
+    expect(quote.price).toBe(250);
+  });
+
+  test("routes news calls only through sources with news capability", async () => {
+    const article = makeArticle("source-news");
+    const marketOnlySource: CapabilityRouteSource = {
+      id: "market-only",
+      name: "Market Only",
+      priority: 1,
+      market: {
+        ...fallbackProvider,
+        id: "market-only",
+        name: "Market Only",
+      },
+    };
+    const newsSource: CapabilityRouteSource = {
+      id: "news-source",
+      name: "News Source",
+      priority: 10,
+      news: {
+        fetchNews: async () => [article],
+      },
+    };
+    const router = new AssetDataRouter(null, [marketOnlySource, newsSource]);
+
+    const articles = await router.getNews({ feed: "latest", limit: 10 });
+
+    expect(articles).toEqual([article]);
+  });
+
+  test("falls back to later providers when holder data is empty", async () => {
+    const cloudProvider: DataProvider = {
+      ...fallbackProvider,
+      id: "cloud",
+      name: "Cloud",
+      priority: 100,
+      async getHolders(symbol) {
+        return {
+          providerId: "cloud",
+          symbol,
+          holders: [],
+        };
+      },
+    };
+    const yahooProvider: DataProvider = {
+      ...fallbackProvider,
+      id: "yahoo",
+      name: "Yahoo",
+      priority: 1000,
+      async getHolders(symbol) {
+        return {
+          providerId: "yahoo",
+          symbol,
+          currency: "USD",
+          holders: [{
+            providerId: "yahoo",
+            ownerType: "institution",
+            name: "Vanguard Group Inc",
+            shares: 1_200_000_000,
+            value: 250_000_000_000,
+            percentHeld: 0.08,
+            changePercent: 0.02,
+          }],
+        };
+      },
+    };
+
+    const router = new AssetDataRouter(yahooProvider, [cloudProvider]);
+    const holders = await router.getHolders("AAPL", "NASDAQ");
+
+    expect(holders.providerId).toBe("yahoo");
+    expect(holders.holders[0]?.name).toBe("Vanguard Group Inc");
+  });
+
   test("prefers broker quotes over fallback quotes", async () => {
-    const router = new ProviderRouter(fallbackProvider);
+    const router = new AssetDataRouter(fallbackProvider);
     const broker: BrokerAdapter = {
       id: "ibkr",
       name: "IBKR",
@@ -84,7 +221,7 @@ describe("ProviderRouter", () => {
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -120,7 +257,7 @@ describe("ProviderRouter", () => {
   });
 
   test("prefers the requested broker instance in search results", async () => {
-    const router = new ProviderRouter(fallbackProvider);
+    const router = new AssetDataRouter(fallbackProvider);
     const broker: BrokerAdapter = {
       id: "ibkr",
       name: "IBKR",
@@ -149,7 +286,7 @@ describe("ProviderRouter", () => {
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -239,11 +376,11 @@ describe("ProviderRouter", () => {
         }];
       },
     };
-    const router = new ProviderRouter(fallbackProvider, [provider]);
+    const router = new AssetDataRouter(fallbackProvider, [provider]);
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -280,46 +417,47 @@ describe("ProviderRouter", () => {
     expect(results[0]?.brokerContract?.localSymbol).toBe("AAPL");
   });
 
-  test("ignores disabled plugin providers when the registry filters them out", async () => {
-    const disabledProvider: DataProvider = {
-      id: "gloomberb-cloud",
+  test("ignores disabled plugin sources when the registry filters them out", async () => {
+    const router = new AssetDataRouter(fallbackProvider);
+    router.attachRegistry({
+      brokers: new Map(),
+      getEnabledCapabilities: () => [],
+    } as any);
+
+    const quote = await router.getQuote("AAPL", "NASDAQ");
+    expect(quote.price).toBe(100);
+    expect(quote.providerId).toBeUndefined();
+  });
+
+  test("routes through registered asset-data capabilities", async () => {
+    const cloudProvider: DataProvider = {
+      ...fallbackProvider,
+      id: "cloud",
       name: "Cloud",
       priority: 10,
-      async getTickerFinancials() {
-        throw new Error("disabled provider should not be used");
-      },
       async getQuote() {
-        throw new Error("disabled provider should not be used");
-      },
-      async getExchangeRate() {
-        throw new Error("disabled provider should not be used");
-      },
-      async search() {
-        throw new Error("disabled provider should not be used");
-      },
-      async getNews() {
-        throw new Error("disabled provider should not be used");
-      },
-      async getArticleSummary() {
-        throw new Error("disabled provider should not be used");
-      },
-      async getPriceHistory() {
-        throw new Error("disabled provider should not be used");
+        return {
+          symbol: "AAPL",
+          providerId: "cloud",
+          price: 125,
+          currency: "USD",
+          change: 1,
+          changePercent: 0.8,
+          lastUpdated: Date.now(),
+        };
       },
     };
-
-    const router = new ProviderRouter(fallbackProvider);
+    const router = new AssetDataRouter(fallbackProvider);
     router.attachRegistry({
       brokers: new Map(),
-      dataProviders: new Map([["gloomberb-cloud", disabledProvider]]),
-      getEnabledDataProviders() {
-        return [];
-      },
+      getEnabledCapabilities: (kind?: string) => (
+        kind === "asset-data" ? [assetDataProvider(cloudProvider)] : []
+      ),
     } as any);
 
     const quote = await router.getQuote("AAPL", "NASDAQ");
-    expect(quote.price).toBe(100);
-    expect(quote.providerId).toBeUndefined();
+    expect(quote.price).toBe(125);
+    expect(quote.providerId).toBe("cloud");
   });
 
   test("prefers provider quote streams when one is available", () => {
@@ -373,10 +511,10 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const router = new ProviderRouter(fallbackProvider, [streamingProvider]);
+    const router = new AssetDataRouter(fallbackProvider, [streamingProvider]);
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -476,10 +614,10 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const router = new ProviderRouter(fallbackProvider, [streamingProvider]);
+    const router = new AssetDataRouter(fallbackProvider, [streamingProvider]);
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -538,7 +676,7 @@ describe("ProviderRouter", () => {
     const dbPath = createTempDbPath("cache-merge");
     const persistence = new AppPersistence(dbPath);
     const providerCalls = { broker: 0, fallback: 0 };
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         providerCalls.fallback += 1;
@@ -581,7 +719,7 @@ describe("ProviderRouter", () => {
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -633,7 +771,7 @@ describe("ProviderRouter", () => {
   });
 
   test("keeps broker price authority when a fallback quote is off by a likely 100x unit mismatch", async () => {
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         return {
@@ -648,7 +786,7 @@ describe("ProviderRouter", () => {
             change: -0.021,
             changePercent: -7.89,
             lastUpdated: Date.now(),
-            dataSource: "yahoo",
+            dataSource: "delayed",
           },
           fundamentals: { revenue: 1000 },
         };
@@ -686,7 +824,7 @@ describe("ProviderRouter", () => {
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -729,7 +867,7 @@ describe("ProviderRouter", () => {
   });
 
   test("preserves fallback profile data when broker already has fundamentals", async () => {
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         return {
@@ -766,7 +904,7 @@ describe("ProviderRouter", () => {
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -857,7 +995,7 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const router = new ProviderRouter(yahooProvider, [cloudProvider]);
+    const router = new AssetDataRouter(yahooProvider, [cloudProvider]);
     const merged = await router.getTickerFinancials("AAPL", "NASDAQ");
 
     expect(merged.quote?.price).toBe(125);
@@ -924,13 +1062,13 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const seedRouter = new ProviderRouter(yahooProvider, [cloudProvider], persistence.resources);
+    const seedRouter = new AssetDataRouter(yahooProvider, [cloudProvider], persistence.resources);
     const seeded = await seedRouter.getTickerFinancials("AAPL", "NASDAQ");
     expect(seeded.quote?.marketCap).toBe(2_000_000_000);
 
     let cloudCalls = 0;
     let yahooCalls = 0;
-    const cachedRouter = new ProviderRouter({
+    const cachedRouter = new AssetDataRouter({
       ...yahooProvider,
       async getTickerFinancials() {
         yahooCalls += 1;
@@ -1011,7 +1149,7 @@ describe("ProviderRouter", () => {
       recentTickers: [],
     };
 
-    const seedRouter = new ProviderRouter({
+    const seedRouter = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         return {
@@ -1023,7 +1161,7 @@ describe("ProviderRouter", () => {
     }, [], persistence.resources);
     seedRouter.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     seedRouter.setConfigAccessor(() => config);
 
@@ -1033,7 +1171,7 @@ describe("ProviderRouter", () => {
     });
     expect(seeded.profile).toBeUndefined();
 
-    const refreshedRouter = new ProviderRouter({
+    const refreshedRouter = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         return {
@@ -1050,7 +1188,7 @@ describe("ProviderRouter", () => {
     }, [], persistence.resources);
     refreshedRouter.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     refreshedRouter.setConfigAccessor(() => config);
 
@@ -1067,7 +1205,7 @@ describe("ProviderRouter", () => {
   test("does not reuse another broker instance's financials when a specific instance is requested", async () => {
     const dbPath = createTempDbPath("instance-scoped-financials");
     const persistence = new AppPersistence(dbPath);
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         return {
@@ -1082,7 +1220,7 @@ describe("ProviderRouter", () => {
             change: 0,
             changePercent: 0,
             lastUpdated: Date.now(),
-            dataSource: "yahoo",
+            dataSource: "delayed",
           },
         };
       },
@@ -1121,7 +1259,7 @@ describe("ProviderRouter", () => {
 
     router.attachRegistry({
       brokers: new Map([["ibkr", broker]]),
-      dataProviders: new Map(),
+      getEnabledCapabilities: () => [],
     } as any);
     router.setConfigAccessor(() => ({
       dataDir: "",
@@ -1235,13 +1373,14 @@ describe("ProviderRouter", () => {
         priceHistory: [],
         quote: {
           symbol: "IQE.L",
+          providerId: "yahoo",
           price: 0.231,
           currency: "GBP",
           change: -0.014,
           changePercent: -5.71,
           previousClose: 0.245,
           lastUpdated: now,
-          dataSource: "yahoo",
+          dataSource: "delayed",
         },
         fundamentals: {
           revenue: 1000,
@@ -1271,7 +1410,7 @@ describe("ProviderRouter", () => {
         throw new Error("should not fetch cloud financials");
       },
     };
-    const router = new ProviderRouter(yahooProvider, [cloudProvider], persistence.resources);
+    const router = new AssetDataRouter(yahooProvider, [cloudProvider], persistence.resources);
 
     const financials = await router.getTickerFinancials("IQE", "LSE", {
       instrument: {
@@ -1356,7 +1495,7 @@ describe("ProviderRouter", () => {
           exchangeName: "FWB2",
           listingExchangeName: "FWB2",
           providerId: "yahoo",
-          dataSource: "yahoo",
+          dataSource: "delayed",
         },
       },
       {
@@ -1365,7 +1504,7 @@ describe("ProviderRouter", () => {
       },
     );
 
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       id: "yahoo",
       name: "Yahoo",
@@ -1398,7 +1537,7 @@ describe("ProviderRouter", () => {
   test("drops cached premarket cloud quotes that lack an active-session price", () => {
     const dbPath = createTempDbPath("stale-cloud-premarket-cache");
     const persistence = new AppPersistence(dbPath);
-    const now = Date.parse("2026-04-08T10:55:00Z");
+    const now = Date.now();
 
     persistence.resources.set(
       {
@@ -1457,7 +1596,7 @@ describe("ProviderRouter", () => {
           exchangeName: "NASDAQ",
           listingExchangeName: "NASDAQ",
           providerId: "yahoo",
-          dataSource: "yahoo",
+          dataSource: "delayed",
         },
       },
       {
@@ -1466,7 +1605,7 @@ describe("ProviderRouter", () => {
       },
     );
 
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       id: "yahoo",
       name: "Yahoo",
@@ -1503,7 +1642,7 @@ describe("ProviderRouter", () => {
         throw new Error('[404] {"chart":{"result":null,"error":{"code":"Not Found","description":"No data found, symbol may be delisted"}}}');
       },
     };
-    const router = new ProviderRouter(fallbackProvider, [noisyProvider]);
+    const router = new AssetDataRouter(fallbackProvider, [noisyProvider]);
     const logged: unknown[][] = [];
     console.error = (...args: unknown[]) => {
       logged.push(args);
@@ -1538,11 +1677,11 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const seedRouter = new ProviderRouter(yahooProvider, [cloudProvider], persistence.resources);
+    const seedRouter = new AssetDataRouter(yahooProvider, [cloudProvider], persistence.resources);
     const seeded = await seedRouter.getPriceHistory("AAPL", "NASDAQ", "1Y");
     expect(seeded[0]?.close).toBe(101);
 
-    const cachedRouter = new ProviderRouter(yahooProvider, [cloudProvider], persistence.resources);
+    const cachedRouter = new AssetDataRouter(yahooProvider, [cloudProvider], persistence.resources);
     const cached = await cachedRouter.getPriceHistory("AAPL", "NASDAQ", "1Y");
     expect(cached[0]?.close).toBe(101);
 
@@ -1550,7 +1689,7 @@ describe("ProviderRouter", () => {
   });
 
   test("sorts reversed chart history into chronological order", async () => {
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       id: "cloud",
       name: "Cloud",
@@ -1590,7 +1729,7 @@ describe("ProviderRouter", () => {
     );
 
     let providerCalls = 0;
-    const router = new ProviderRouter({
+    const router = new AssetDataRouter({
       ...fallbackProvider,
       id: "yahoo",
       name: "Yahoo",
@@ -1615,7 +1754,7 @@ describe("ProviderRouter", () => {
     const dbPath = createTempDbPath("forced-financial-refresh");
     const persistence = new AppPersistence(dbPath);
 
-    const seedRouter = new ProviderRouter({
+    const seedRouter = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         return {
@@ -1636,7 +1775,7 @@ describe("ProviderRouter", () => {
     await seedRouter.getTickerFinancials("AAPL", "NASDAQ");
 
     let providerCalls = 0;
-    const refreshRouter = new ProviderRouter({
+    const refreshRouter = new AssetDataRouter({
       ...fallbackProvider,
       async getTickerFinancials() {
         providerCalls += 1;
@@ -1669,7 +1808,7 @@ describe("ProviderRouter", () => {
     const dbPath = createTempDbPath("stale-chart-refresh");
     const persistence = new AppPersistence(dbPath);
 
-    const seedRouter = new ProviderRouter({
+    const seedRouter = new AssetDataRouter({
       ...fallbackProvider,
       async getPriceHistory() {
         return [{ date: new Date("2026-03-27T00:00:00Z"), close: 101 }];
@@ -1682,7 +1821,7 @@ describe("ProviderRouter", () => {
       .run(Date.now() - 1, "market", "price-history", "AAPL");
 
     let providerCalls = 0;
-    const refreshRouter = new ProviderRouter({
+    const refreshRouter = new AssetDataRouter({
       ...fallbackProvider,
       async getPriceHistory() {
         providerCalls += 1;
@@ -1718,7 +1857,7 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const router = new ProviderRouter(yahooProvider, [cloudProvider]);
+    const router = new AssetDataRouter(yahooProvider, [cloudProvider]);
     const history = await router.getPriceHistoryForResolution("AAPL", "NASDAQ", "1Y", "1d");
 
     expect(history[0]?.close).toBe(102);
@@ -1744,7 +1883,7 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const router = new ProviderRouter(yahooProvider, [cloudProvider]);
+    const router = new AssetDataRouter(yahooProvider, [cloudProvider]);
     expect(await router.getChartResolutionCapabilities("AAPL", "NASDAQ")).toEqual(["1d", "1wk"]);
   });
 
@@ -1768,7 +1907,7 @@ describe("ProviderRouter", () => {
       },
     };
 
-    const router = new ProviderRouter(yahooProvider, [cloudProvider]);
+    const router = new AssetDataRouter(yahooProvider, [cloudProvider]);
     const history = await router.getDetailedPriceHistory(
       "AAPL",
       "NASDAQ",