gloomberb 0.5.0 → 0.6.0

package/src/plugins/builtin/econ/types.ts

@@ -1,3 +1,4 @@
+
 export type EconImpact = "high" | "medium" | "low";
 
 export interface EconEvent {

package/src/plugins/builtin/fx-matrix/index.tsx

@@ -1,9 +1,11 @@
-import { useEffect, useRef, useState } from "react";
-import { TextAttributes } from "@opentui/core";
-import { useKeyboard } from "@opentui/react";
+import { Box, ScrollBox, Text } from "../../../ui";
+import { useCallback, useEffect, useRef, useState } from "react";
+import { TextAttributes } from "../../../ui";
+import { useShortcut } from "../../../react/input";
+import { usePaneFooter } from "../../../components";
 import type { GloomPlugin, PaneProps } from "../../../types/plugin";
 import { colors, blendHex } from "../../../theme/colors";
-import { getSharedDataProvider } from "../../registry";
+import { useAssetData } from "../../plugin-runtime";
 import { MAJOR_CURRENCIES, CURRENCY_FLAGS, formatRate, type MajorCurrency } from "./pairs";
 
 const REFRESH_INTERVAL_MS = 60_000;
@@ -17,15 +19,15 @@ function formatAge(ms: number): string {
 }
 
 export function FxMatrixPane({ focused, width, height }: PaneProps) {
+  const dataProvider = useAssetData();
   const [rates, setRates] = useState<Map<MajorCurrency, number>>(new Map());
   const [loading, setLoading] = useState(true);
   const [lastRefreshed, setLastRefreshed] = useState<number | null>(null);
   const [now, setNow] = useState(Date.now());
   const fetchGenRef = useRef(0);
 
-  const fetchRates = async () => {
-    const provider = getSharedDataProvider();
-    if (!provider) return;
+  const fetchRates = useCallback(async () => {
+    if (!dataProvider) return;
 
     fetchGenRef.current += 1;
     const gen = fetchGenRef.current;
@@ -34,7 +36,7 @@ export function FxMatrixPane({ focused, width, height }: PaneProps) {
       const results = await Promise.allSettled(
         MAJOR_CURRENCIES.map(async (currency) => {
           if (currency === "USD") return { currency, rate: 1 };
-          const rate = await provider.getExchangeRate(currency);
+          const rate = await dataProvider.getExchangeRate(currency);
           return { currency, rate };
         }),
       );
@@ -53,20 +55,20 @@ export function FxMatrixPane({ focused, width, height }: PaneProps) {
     } finally {
       if (fetchGenRef.current === gen) setLoading(false);
     }
-  };
+  }, [dataProvider]);
 
   useEffect(() => {
     fetchRates();
     const interval = setInterval(fetchRates, REFRESH_INTERVAL_MS);
     return () => clearInterval(interval);
-  }, []);
+  }, [fetchRates]);
 
   useEffect(() => {
     const interval = setInterval(() => setNow(Date.now()), 5_000);
     return () => clearInterval(interval);
   }, []);
 
-  useKeyboard((event) => {
+  useShortcut((event) => {
     if (!focused) return;
     if (event.name === "r") {
       fetchRates();
@@ -85,64 +87,60 @@ export function FxMatrixPane({ focused, width, height }: PaneProps) {
 
   const ageText = lastRefreshed ? `updated ${formatAge(now - lastRefreshed)}` : loading ? "loading…" : "";
 
+  usePaneFooter("fx-matrix", () => ({
+    info: ageText ? [{ id: "updated", parts: [{ text: ageText, tone: loading ? "muted" : "value" }] }] : [],
+    hints: [{ id: "refresh", key: "r", label: "efresh", onPress: fetchRates }],
+  }), [ageText, fetchRates, loading]);
+
   // Row header: just the 3-letter code, no emoji (keeps width predictable)
   // Rates use flexGrow so they fill available space dynamically
 
   return (
-    <box flexDirection="column" width={width} height={height}>
-      {/* Header */}
-      <box flexDirection="row" height={1} paddingX={1}>
-        <text fg={colors.textMuted}>{ageText}</text>
-      </box>
-
+    <Box flexDirection="column" width={width} height={height}>
       {/* Column header row */}
-      <box flexDirection="row" paddingX={1} height={1} backgroundColor={headerBg}>
-        <box width={5} flexShrink={0} />
+      <Box flexDirection="row" paddingX={1} height={1} backgroundColor={headerBg}>
+        <Box width={5} flexShrink={0} />
         {MAJOR_CURRENCIES.map((col) => (
-          <box key={col} flexGrow={1} justifyContent="flex-end" paddingRight={1}>
-            <text fg={colors.textDim} attributes={TextAttributes.BOLD}>{col}</text>
-          </box>
+          <Box key={col} flexGrow={1} justifyContent="flex-end" paddingRight={1}>
+            <Text fg={colors.textDim} attributes={TextAttributes.BOLD}>{col}</Text>
+          </Box>
         ))}
-      </box>
+      </Box>
 
       {/* Matrix rows */}
-      <scrollbox flexGrow={1} scrollY focusable={false}>
-        <box flexDirection="column">
+      <ScrollBox flexGrow={1} scrollY focusable={false}>
+        <Box flexDirection="column">
           {loading && rates.size === 0 ? (
-            <box paddingX={1} paddingY={1}>
-              <text fg={colors.textMuted}>Fetching rates…</text>
-            </box>
+            <Box paddingX={1} paddingY={1}>
+              <Text fg={colors.textMuted}>Fetching rates…</Text>
+            </Box>
           ) : (
             MAJOR_CURRENCIES.map((row) => (
-              <box key={row} flexDirection="row" paddingX={1}>
-                <box width={5} flexShrink={0}>
-                  <text fg={colors.textBright} attributes={TextAttributes.BOLD}>{row}</text>
-                </box>
+              <Box key={row} flexDirection="row" paddingX={1}>
+                <Box width={5} flexShrink={0}>
+                  <Text fg={colors.textBright} attributes={TextAttributes.BOLD}>{row}</Text>
+                </Box>
                 {MAJOR_CURRENCIES.map((col) => {
                   const rate = crossRate(row, col);
                   const isDiag = row === col;
                   return (
-                    <box key={col} flexGrow={1} justifyContent="flex-end" paddingRight={1}>
+                    <Box key={col} flexGrow={1} justifyContent="flex-end" paddingRight={1}>
                       {rate == null ? (
-                        <text fg={colors.textDim}>—</text>
+                        <Text fg={colors.textDim}>—</Text>
                       ) : (
-                        <text fg={isDiag ? colors.textDim : colors.text}>
+                        <Text fg={isDiag ? colors.textDim : colors.text}>
                           {formatRate(rate, col)}
-                        </text>
+                        </Text>
                       )}
-                    </box>
+                    </Box>
                   );
                 })}
-              </box>
+              </Box>
             ))
           )}
-        </box>
-      </scrollbox>
-
-      <box height={1} paddingX={1}>
-        <text fg={colors.textMuted}>[r]efresh</text>
-      </box>
-    </box>
+        </Box>
+      </ScrollBox>
+    </Box>
   );
 }
 

package/src/plugins/builtin/fx-matrix/pairs.ts

@@ -1,3 +1,4 @@
+
 export const MAJOR_CURRENCIES = ["USD", "EUR", "GBP", "JPY", "CHF", "CAD", "AUD", "NZD"] as const;
 export type MajorCurrency = typeof MAJOR_CURRENCIES[number];
 

package/src/plugins/builtin/help.test.tsx

@@ -1,8 +1,10 @@
 import { afterEach, describe, expect, test } from "bun:test";
 import { act } from "react";
-import { testRender } from "@opentui/react/test-utils";
-import { HelpPane } from "./help";
+import { testRender } from "../../renderers/opentui/test-utils";
+import { createTestPluginRuntime } from "../../test-support/plugin-runtime";
 import { setSharedRegistryForTests } from "../registry";
+import { PluginRenderProvider } from "../plugin-runtime";
+import { HelpPane } from "./help";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
 
@@ -14,80 +16,138 @@ afterEach(() => {
   setSharedRegistryForTests(undefined);
 });
 
+async function renderHelpPane(
+  runtime = createTestPluginRuntime(),
+  size = { width: 88, height: 36 },
+) {
+  testSetup = await testRender(
+    <PluginRenderProvider pluginId="help" runtime={runtime}>
+      <HelpPane
+        paneId="help:main"
+        paneType="help"
+        focused
+        width={size.width}
+        height={size.height}
+        close={() => {}}
+      />
+    </PluginRenderProvider>,
+    size,
+  );
+
+  await testSetup.renderOnce();
+  return testSetup;
+}
+
+function withoutScrollbar(line: string) {
+  const scrollThumb = String.fromCharCode(0x2588);
+  return (line.endsWith(scrollThumb) ? line.slice(0, -1) : line).trimEnd();
+}
+
 describe("HelpPane", () => {
-  test("renders shortcut, layout, and bug-report guidance", async () => {
+  test("puts section spacing before headings instead of after them", async () => {
+    await renderHelpPane();
+
+    const lines = testSetup!.captureCharFrame().split("\n").map(withoutScrollbar);
+    const commandBarRow = lines.findIndex((line) => line.includes("Command Bar"));
+    const templatesRow = lines.findIndex((line) => line.includes("Window Templates"));
+
+    expect(commandBarRow).toBeGreaterThan(0);
+    expect(templatesRow).toBeGreaterThan(commandBarRow);
+    expect(lines[commandBarRow - 1]?.trim()).toBe("");
+    expect(lines[commandBarRow + 1]).toContain("Open or toggle the command bar");
+    expect(lines[templatesRow - 1]?.trim()).toBe("");
+    expect(lines[templatesRow + 1]?.trim()).not.toBe("");
+  });
+
+  test("lists core, plugin command, template, and keyboard shortcuts", async () => {
     setSharedRegistryForTests({
-      paneTemplates: new Map([
-        ["quote-monitor-pane", {
-          id: "quote-monitor-pane",
-          paneId: "quote-monitor",
+      commands: new Map([[
+        "set-alert",
+        {
+          id: "set-alert",
+          label: "Add Alert",
+          description: "Create a price alert",
+          keywords: [],
+          category: "data",
+          shortcut: "SA",
+          shortcutArg: { placeholder: "symbol condition price" },
+          execute: () => {},
+        },
+      ]]),
+      paneTemplates: new Map([[
+        "quote",
+        {
+          id: "quote",
+          paneId: "ticker-detail",
           label: "Quote Monitor",
-          description: "Open a compact quote monitor",
+          description: "Open ticker detail",
           shortcut: { prefix: "QQ", argPlaceholder: "ticker" },
-        }],
-        ["notes-pane", {
-          id: "notes-pane",
-          paneId: "notes",
-          label: "Quick Notes",
-          description: "Open a notes window",
-          shortcut: { prefix: "NOTE" },
-        }],
-      ]),
+        },
+      ]]),
+      shortcuts: new Map([[
+        "toggle-chat",
+        {
+          id: "toggle-chat",
+          key: "c",
+          shift: true,
+          description: "Toggle chat",
+          execute: () => {},
+        },
+      ]]),
       allPlugins: new Map([
-        ["ticker-detail", { id: "ticker-detail", name: "Ticker Detail" }],
-        ["notes", { id: "notes", name: "Notes" }],
+        ["alerts", { name: "Alerts" }],
+        ["ticker-detail", { name: "Ticker Detail" }],
+        ["gloomberb-cloud", { name: "Gloomberb Cloud" }],
       ]),
-      getPaneTemplatePluginId: (templateId: string) => (
-        templateId === "quote-monitor-pane" ? "ticker-detail" : "notes"
-      ),
       getConfigFn: () => ({ disabledPlugins: [] }),
+      getCommandPluginId: () => "alerts",
+      getPaneTemplatePluginId: () => "ticker-detail",
+      getShortcutPluginId: () => "gloomberb-cloud",
     } as any);
 
-    testSetup = await testRender(
-      <HelpPane
-        paneId="help:main"
-        paneType="help"
-        focused
-        width={88}
-        height={36}
-        close={() => {}}
-      />,
-      { width: 88, height: 36 },
-    );
-
-    await testSetup.renderOnce();
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("How To Use Gloomberb");
-    expect(frame).toContain("Window Templates");
-    expect(frame).toContain("QQ");
-    expect(frame).toContain("Quote Monitor");
-    expect(frame).toContain("Layout System");
+    await renderHelpPane(createTestPluginRuntime(), { width: 88, height: 80 });
+
+    const frame = testSetup!.captureCharFrame();
+    expect(frame).toMatch(/AW\s+<ticker>/);
+    expect(frame).toMatch(/SA\s+<symbol condition price>/);
+    expect(frame).toMatch(/QQ\s+<ticker>/);
+    expect(frame).toContain("Add Alert (Alerts)");
+    expect(frame).toContain("Shift+C");
+    expect(frame).toContain("Toggle chat (Gloomberb Cloud)");
     expect(frame).toContain("Ctrl+W");
-    expect(frame).toContain("Open Debug Log");
+    expect(frame).toContain("Ctrl+,");
+    expect(frame).not.toContain("Ctrl+Shift+O");
+    expect(frame).not.toContain("Pop the focused pane");
+    expect(frame).not.toContain("Cmd+W");
+    expect(frame).not.toContain("Cmd+,");
+    expect(frame).not.toContain("Cmd+K");
+    expect(frame).not.toContain("Cmd/Ctrl");
+    expect(frame).not.toContain("CmdOrCtrl");
+  });
+
+  test("keeps shortcuts and descriptions on the same row when narrow", async () => {
+    await renderHelpPane(createTestPluginRuntime(), { width: 70, height: 80 });
+
+    const lines = testSetup!.captureCharFrame().split("\n").map(withoutScrollbar);
+    const closeCommandRow = lines.findIndex((line) => line.includes("Close the command bar."));
+    const securityDetailsRow = lines.findIndex((line) => line.includes("Open security details"));
+
+    expect(closeCommandRow).toBeGreaterThanOrEqual(0);
+    expect(lines[closeCommandRow]).toContain("Esc");
+    expect(lines[closeCommandRow]).toContain("`");
+    expect(securityDetailsRow).toBeGreaterThanOrEqual(0);
+    expect(lines[securityDetailsRow]).toContain("DES");
+    expect(lines[securityDetailsRow]).toContain("<ticker>");
   });
 
   test("opens the debug log from the mouse action", async () => {
     const calls: string[] = [];
-
-    setSharedRegistryForTests({
+    const runtime = createTestPluginRuntime({
+      openCommandBar: (query?: string) => calls.push(`command:${query ?? ""}`),
       showWidget: (paneId: string) => calls.push(`widget:${paneId}`),
-      openCommandBarFn: (query?: string) => calls.push(`command:${query ?? ""}`),
-    } as any);
-
-    testSetup = await testRender(
-      <HelpPane
-        paneId="help:main"
-        paneType="help"
-        focused
-        width={88}
-        height={36}
-        close={() => {}}
-      />,
-      { width: 88, height: 36 },
-    );
+    });
 
-    await testSetup.renderOnce();
+    await renderHelpPane(runtime);
 
     const lines = testSetup.captureCharFrame().split("\n");
     const row = lines.findIndex((line) => line.includes("Open Debug Log"));