gloomberb 0.5.0 → 0.6.0

package/src/plugins/builtin/ai/ask-ai-detail-tab.tsx

@@ -1,19 +1,19 @@
+import { Box, ScrollBox, Text, useUiCapabilities } from "../../../ui";
 import { useRef, useEffect, useState, useCallback } from "react";
-import { useKeyboard } from "@opentui/react";
-import { TextAttributes } from "@opentui/core";
-import type { InputRenderable, ScrollBoxRenderable } from "@opentui/core";
+import { useShortcut } from "../../../react/input";
+import { TextAttributes } from "../../../ui";
+import { type ScrollBoxRenderable, type TextareaRenderable } from "../../../ui";
 import type { DetailTabProps } from "../../../types/plugin";
-import { useAppState, usePaneTicker } from "../../../state/app-context";
+import { useAppSelector, usePaneTicker } from "../../../state/app-context";
 import { useFxRatesMap } from "../../../market-data/hooks";
 import { usePluginState } from "../../../plugins/plugin-runtime";
 import { useInlineTickers } from "../../../state/use-inline-tickers";
 import { MarkdownText } from "../../../components/markdown-text";
+import { getMessageComposerBlockHeight, MessageComposer, Spinner, usePaneFooter } from "../../../components";
 import { colors } from "../../../theme/colors";
-import { Spinner } from "../../../components/spinner";
 import { buildTickerAiContext } from "./ticker-context";
 import { detectProviders, getAvailableProviders, resolveDefaultAiProviderId, __setDetectedProvidersForTests, type AiProvider } from "./providers";
 import { runAiPrompt } from "./runner";
-import { truncateWithEllipsis } from "./utils";
 
 interface ChatMessage {
   role: "user" | "assistant";
@@ -41,45 +41,27 @@ export function __resetAskAiHistoryForTests(): void {
   chatHistories.clear();
 }
 
-function getProviderHeaderParts(providerName: string, canSwitch: boolean, width: number): { prefix: string; label: string } {
-  if (width <= 0) return { prefix: "", label: "" };
-
-  const variants = [
-    { prefix: "Provider: ", label: canSwitch ? `${providerName} (t to switch)` : providerName },
-    { prefix: "Provider: ", label: canSwitch ? `${providerName} (t)` : providerName },
-    { prefix: "", label: canSwitch ? `${providerName} (t to switch)` : providerName },
-    { prefix: "", label: canSwitch ? `${providerName} (t)` : providerName },
-    { prefix: "", label: providerName },
-  ];
-
-  for (const variant of variants) {
-    if (variant.prefix.length + variant.label.length <= width) {
-      return variant;
-    }
-  }
-
-  return { prefix: "", label: truncateWithEllipsis(providerName, width) };
-}
-
 export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabProps) {
-  const { state } = useAppState();
+  const { nativePaneChrome } = useUiCapabilities();
+  const baseCurrency = useAppSelector((state) => state.config.baseCurrency);
+  const cachedExchangeRates = useAppSelector((state) => state.exchangeRates);
   const { ticker, financials } = usePaneTicker();
   const exchangeRates = useFxRatesMap([
-    state.config.baseCurrency,
+    baseCurrency,
     ticker?.metadata.currency,
     financials?.quote?.currency,
     ...(ticker?.metadata.positions.map((position) => position.currency) ?? []),
   ]);
-  const effectiveExchangeRates = exchangeRates.size > 1 || state.exchangeRates.size === 0
+  const effectiveExchangeRates = exchangeRates.size > 1 || cachedExchangeRates.size === 0
     ? exchangeRates
-    : state.exchangeRates;
+    : cachedExchangeRates;
   const [providers] = useState(() => detectProviders());
   const defaultProviderId = resolveDefaultAiProviderId(providers);
   const [providerId, setProviderId] = usePluginState<string>("providerId", defaultProviderId);
   const [messages, setMessages] = useState<ChatMessage[]>([]);
   const [inputFocused, setInputFocused] = useState(false);
   const [inputValue, setInputValue] = useState("");
-  const inputRef = useRef<InputRenderable>(null);
+  const inputRef = useRef<TextareaRenderable>(null);
   const scrollRef = useRef<ScrollBoxRenderable>(null);
   const runRef = useRef<ReturnType<typeof runAiPrompt> | null>(null);
   const availableProviders = getAvailableProviders(providers);
@@ -170,7 +152,7 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
     const context = buildTickerAiContext(
       ticker,
       financials,
-      state.config.baseCurrency,
+      baseCurrency,
       effectiveExchangeRates,
     );
     const fullPrompt = `You are a financial analyst assistant. Here is the current financial data for the company being discussed:\n\n${context}\n\nUser question: ${text}`;
@@ -211,9 +193,18 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
     } finally {
       runRef.current = null;
     }
-  }, [currentProvider, effectiveExchangeRates, financials, state.config.baseCurrency, ticker]);
-
-  useKeyboard((event) => {
+  }, [baseCurrency, currentProvider, effectiveExchangeRates, financials, ticker]);
+
+  const submitInput = useCallback(() => {
+    const currentValue = inputRef.current?.editBuffer.getText() ?? inputValue;
+    const trimmed = currentValue.trim();
+    if (!trimmed) return;
+    void sendMessage(trimmed);
+    setInputValue("");
+    inputRef.current?.editBuffer.setText?.("");
+  }, [inputValue, sendMessage]);
+
+  useShortcut((event) => {
     if (!focused) return;
 
     const isEnter = event.name === "enter" || event.name === "return";
@@ -238,113 +229,112 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
   }, []);
 
   const { catalog, openTicker } = useInlineTickers(messages.map((message) => message.content));
-
-  if (!ticker) return <text fg={colors.textDim}>Select a ticker to ask AI.</text>;
+  const thinking = messages.some((message) => message.loading);
+
+  usePaneFooter("ask-ai", () => ({
+    info: [
+      ...(currentProvider ? [{
+        id: "provider",
+        parts: [
+          { text: "Provider", tone: "label" as const },
+          { text: currentProvider.name, tone: currentProvider.available ? "value" as const : "warning" as const, bold: true },
+        ],
+      }] : []),
+      { id: "messages", parts: [{ text: `${messages.length} messages`, tone: "muted" }] },
+      ...(thinking ? [{ id: "thinking", parts: [{ text: "thinking", tone: "muted" as const }] }] : []),
+    ],
+    hints: availableProviders.length > 1
+      ? [{ id: "provider", key: "t", label: "provider", onPress: cycleProvider }]
+      : [],
+  }), [availableProviders.length, currentProvider?.available, currentProvider?.name, cycleProvider, messages.length, thinking]);
+
+  if (!ticker) return <Text fg={colors.textDim}>Select a ticker to ask AI.</Text>;
 
   if (availableProviders.length === 0) {
     return (
-      <box flexDirection="column" padding={1} flexGrow={1}>
-        <box height={1}>
-          <text attributes={TextAttributes.BOLD} fg={colors.textBright}>Ask AI</text>
-        </box>
-        <box height={1} />
-        <text fg={colors.textDim}>No AI CLI tools detected. Install one of:</text>
-        <box height={1} />
-        <text fg={colors.text}>  claude  - Claude Code (claude.ai/claude-code)</text>
-        <text fg={colors.text}>  gemini  - Gemini CLI (github.com/google-gemini/gemini-cli)</text>
-        <text fg={colors.text}>  codex   - OpenAI Codex (github.com/openai/codex)</text>
-      </box>
+      <Box flexDirection="column" paddingX={1} flexGrow={1}>
+        <Text fg={colors.textDim}>No AI CLI tools detected. Install one of:</Text>
+        <Box height={1} />
+        <Text fg={colors.text}>  claude  - Claude Code (claude.ai/claude-code)</Text>
+        <Text fg={colors.text}>  gemini  - Gemini CLI (github.com/google-gemini/gemini-cli)</Text>
+        <Text fg={colors.text}>  codex   - OpenAI Codex (github.com/openai/codex)</Text>
+      </Box>
     );
   }
 
   const contentWidth = Math.max(width - 2, 0);
-  const dividerWidth = Math.max(contentWidth, 0);
-  const chatHeight = Math.max(height - 7, 4);
-  const providerHeader = getProviderHeaderParts(
-    currentProvider?.name || "None",
-    availableProviders.length > 1,
-    Math.max(contentWidth - "Ask AI".length - 1, 0),
-  );
+  const composerHeight = nativePaneChrome ? 2 : 1;
+  const terminalFooterClearance = nativePaneChrome ? 0 : 1;
+  const composerBlockHeight = getMessageComposerBlockHeight({
+    height: composerHeight,
+    nativePaneChrome,
+    terminalBottomInset: terminalFooterClearance,
+  });
+  const chatHeight = Math.max(height - composerBlockHeight, 0);
 
   return (
-    <box flexDirection="column" paddingX={1} paddingTop={1} height={height - 2}>
-      <box flexDirection="row" height={1}>
-        <text attributes={TextAttributes.BOLD} fg={colors.textBright}>Ask AI</text>
-        <box flexGrow={1} />
-        <box onMouseDown={cycleProvider}>
-          <text fg={colors.textMuted}>
-            {providerHeader.prefix}
-            <span fg={colors.textBright}>{providerHeader.label}</span>
-          </text>
-        </box>
-      </box>
-
-      <scrollbox ref={scrollRef} height={chatHeight} scrollY>
-        <box flexDirection="column">
-          {messages.length === 0 ? (
-            <box paddingTop={1}>
-              <text fg={colors.textDim}>
-                Ask questions about {ticker.metadata.ticker}. Financial data will be included as context.
-              </text>
-            </box>
-          ) : (
-            messages.map((message, index) => (
-              <box key={index} flexDirection="column" paddingTop={index > 0 ? 1 : 0}>
-                <box height={1}>
-                  <text
-                    attributes={TextAttributes.BOLD}
-                    fg={message.role === "user" ? colors.textBright : colors.positive}
-                  >
-                    {message.role === "user" ? "You" : currentProvider?.name || "AI"}
-                    {message.loading ? " (thinking...)" : ""}
-                  </text>
-                </box>
-                <box>
-                  {message.content ? (
-                    <MarkdownText
-                      text={message.content}
-                      lineWidth={contentWidth}
-                      catalog={catalog}
-                      textColor={colors.text}
-                      openTicker={openTicker}
-                    />
-                  ) : message.loading ? (
-                    <Spinner label="Generating..." />
-                  ) : (
-                    <text fg={colors.text}>{""}</text>
-                  )}
-                </box>
-              </box>
-            ))
-          )}
-        </box>
-      </scrollbox>
-
-      <box height={1}>
-        <text fg={colors.textDim}>{"\u2500".repeat(dividerWidth)}</text>
-      </box>
-
-      <box flexDirection="row" height={1} onMouseDown={focusInput}>
-        <text fg={colors.textMuted}>{"> "}</text>
-        <box flexGrow={1}>
-          <input
-            ref={inputRef}
-            placeholder={inputFocused ? "Ask a question..." : "Enter to start typing"}
-            focused={inputFocused && focused}
-            textColor={colors.text}
-            placeholderColor={colors.textDim}
-            backgroundColor={inputFocused && focused ? colors.panel : colors.bg}
-            onInput={(value) => setInputValue(value)}
-            onChange={(value) => setInputValue(value)}
-            onSubmit={() => {
-              if (!inputValue.trim()) return;
-              void sendMessage(inputValue.trim());
-              setInputValue("");
-              (inputRef.current as any)?.editBuffer?.setText?.("");
-            }}
-          />
-        </box>
-      </box>
-    </box>
+    <Box flexDirection="column" paddingX={nativePaneChrome ? 0 : 1} height={height} overflow="hidden">
+      {chatHeight > 0 && (
+        <ScrollBox ref={scrollRef} height={chatHeight} scrollY>
+          <Box flexDirection="column" paddingX={nativePaneChrome ? 1 : 0}>
+            {messages.length === 0 ? (
+              <Box paddingTop={1}>
+                <Text fg={colors.textDim}>
+                  Ask questions about {ticker.metadata.ticker}. Financial data will be included as context.
+                </Text>
+              </Box>
+            ) : (
+              messages.map((message, index) => (
+                <Box key={index} flexDirection="column" paddingTop={index > 0 ? 1 : 0}>
+                  <Box height={1}>
+                    <Text
+                      attributes={TextAttributes.BOLD}
+                      fg={message.role === "user" ? colors.textBright : colors.positive}
+                    >
+                      {message.role === "user" ? "You" : currentProvider?.name || "AI"}
+                      {message.loading ? " (thinking...)" : ""}
+                    </Text>
+                  </Box>
+                  <Box>
+                    {message.content ? (
+                      <MarkdownText
+                        text={message.content}
+                        lineWidth={contentWidth}
+                        catalog={catalog}
+                        textColor={colors.text}
+                        openTicker={openTicker}
+                      />
+                    ) : message.loading ? (
+                      <Spinner label="Generating..." />
+                    ) : (
+                      <Text fg={colors.text}>{""}</Text>
+                    )}
+                  </Box>
+                </Box>
+              ))
+            )}
+          </Box>
+        </ScrollBox>
+      )}
+
+      <MessageComposer
+        inputRef={inputRef}
+        initialValue={inputValue}
+        focused={inputFocused && focused}
+        placeholder="Ask a question..."
+        terminalPrefix=" > "
+        terminalBottomInset={terminalFooterClearance}
+        width={nativePaneChrome ? width : contentWidth}
+        height={composerHeight}
+        onFocusRequest={focusInput}
+        onInput={(value) => setInputValue(value)}
+        keyBindings={[
+          { name: "return", action: "submit" },
+          { name: "linefeed", action: "submit" },
+        ]}
+        onSubmit={submitInput}
+        wrapText={nativePaneChrome}
+      />
+    </Box>
   );
 }

package/src/plugins/builtin/ai/gloomberb-cli.ts

@@ -1,7 +1,3 @@
-import { existsSync } from "fs";
-import { resolve } from "path";
-import { execSync } from "child_process";
-
 export interface GloomberbCliCommand {
   argv: string[];
   display: string;
@@ -14,21 +10,26 @@ function commandExists(command: string): boolean {
       return !!Bun.which(command);
     }
   } catch {
-    // Fall back to shell lookup when Bun.which is unavailable.
+    return false;
   }
+  return false;
+}
 
-  try {
-    execSync(`command -v ${command}`, { stdio: "ignore" });
-    return true;
-  } catch {
-    return false;
+function resolvePath(cwd: string, ...parts: string[]): string {
+  const joined = [cwd, ...parts].join("/");
+  const segments: string[] = [];
+  for (const part of joined.replace(/\\/g, "/").split("/")) {
+    if (!part || part === ".") continue;
+    if (part === "..") segments.pop();
+    else segments.push(part);
   }
+  return joined.startsWith("/") ? `/${segments.join("/")}` : segments.join("/");
 }
 
 export function resolveGloomberbCliCommand({
-  cwd = process.cwd(),
+  cwd = typeof process !== "undefined" ? process.cwd() : ".",
   hasCommand = commandExists,
-  fileExists = existsSync,
+  fileExists = () => false,
 }: {
   cwd?: string;
   hasCommand?: (command: string) => boolean;
@@ -42,7 +43,7 @@ export function resolveGloomberbCliCommand({
     };
   }
 
-  const sourceEntry = resolve(cwd, "src", "index.tsx");
+  const sourceEntry = resolvePath(cwd, "src", "index.tsx");
   if (fileExists(sourceEntry)) {
     return {
       argv: ["bun", sourceEntry],

package/src/plugins/builtin/ai/providers.ts

@@ -1,5 +1,3 @@
-import { execSync } from "child_process";
-
 export interface AiProvider {
   id: string;
   name: string;
@@ -38,16 +36,10 @@ function commandExists(command: string): boolean {
     if (typeof Bun !== "undefined" && typeof Bun.which === "function") {
       return !!Bun.which(command);
     }
-  } catch {
-    // Fall back to shell lookup when Bun.which is unavailable.
-  }
-
-  try {
-    execSync(`command -v ${command}`, { stdio: "ignore" });
-    return true;
   } catch {
     return false;
   }
+  return false;
 }
 
 export function detectProviders(): AiProvider[] {

package/src/plugins/builtin/ai/runner.ts

@@ -1,4 +1,3 @@
-import { spawn, type Subprocess } from "bun";
 import type { AiProvider } from "./providers";
 
 export class AiRunCancelledError extends Error {
@@ -13,14 +12,29 @@ export interface AiRunController {
   cancel: () => void;
 }
 
+export interface AiRunHost {
+  run(options: {
+    provider: AiProvider;
+    prompt: string;
+    cwd?: string;
+    onChunk?: (output: string) => void;
+  }): AiRunController;
+}
+
+let configuredHost: AiRunHost | null = null;
+
+export function setAiRunHost(host: AiRunHost | null): void {
+  configuredHost = host;
+}
+
 export function isAiRunCancelled(error: unknown): boolean {
   return error instanceof AiRunCancelledError;
 }
 
-export function runAiPrompt({
+function runWithBun({
   provider,
   prompt,
-  cwd = process.cwd(),
+  cwd = typeof process !== "undefined" ? process.cwd() : ".",
   onChunk,
 }: {
   provider: AiProvider;
@@ -28,11 +42,19 @@ export function runAiPrompt({
   cwd?: string;
   onChunk?: (output: string) => void;
 }): AiRunController {
+  type BunSubprocess = ReturnType<typeof Bun.spawn>;
+  if (typeof Bun === "undefined" || typeof Bun.spawn !== "function") {
+    return {
+      done: Promise.reject(new Error("AI execution requires a native Bun host.")),
+      cancel: () => {},
+    };
+  }
+
   let cancelled = false;
-  let processRef: Subprocess | null = null;
+  let processRef: BunSubprocess | null = null;
 
   const done = (async () => {
-    const proc = spawn([provider.command, ...provider.buildArgs(prompt)], {
+    const proc = Bun.spawn([provider.command, ...provider.buildArgs(prompt)], {
       cwd,
       stdout: "pipe",
       stderr: "pipe",
@@ -80,3 +102,17 @@ export function runAiPrompt({
     },
   };
 }
+
+export function runAiPrompt({
+  provider,
+  prompt,
+  cwd,
+  onChunk,
+}: {
+  provider: AiProvider;
+  prompt: string;
+  cwd?: string;
+  onChunk?: (output: string) => void;
+}): AiRunController {
+  return (configuredHost ?? { run: runWithBun }).run({ provider, prompt, cwd, onChunk });
+}