gloomberb 0.13.2 → 0.14.0

package/src/plugins/builtin/portfolio-list/header.tsx

@@ -1,3 +1,4 @@
+import { ActionRow } from "../../../components/ui/action-row";
 import { Box, ScrollBox, Text } from "../../../ui";
 import { useEffect, useMemo, useState } from "react";
 import { t } from "../../../i18n";
@@ -18,11 +19,6 @@ import {
   type ResolvedPortfolioAccountState,
 } from "./summary";
 
-type CashDrawerPointerEvent = {
-  preventDefault(): void;
-  stopPropagation(): void;
-};
-
 export function shouldToggleCashMarginDrawer(key: string | undefined, showCashDrawer: boolean): boolean {
   return key === "c" && showCashDrawer;
 }
@@ -103,34 +99,19 @@ export function PortfolioCashMarginDrawer({
 }) {
   const convertAccountValue = (value: number) => convertCurrency(
     value,
-    accountState.account.currency || baseCurrency,
+    accountState.account.currency ?? "",
     baseCurrency,
     exchangeRates,
   );
-  const previewText = `${accountState.visibleCashBalances.length} ccy · Cash ${formatCompact(convertAccountValue(accountState.account.totalCashValue ?? 0))} · ${accountState.sourceLabel}`;
+  const previewText = `${accountState.visibleCashBalances.length} ccy · Cash ${formatCompact(convertAccountValue(accountState.account.totalCashValue ?? Number.NaN))} · ${accountState.sourceLabel}`;
   const drawerHeight = Math.max(1, height);
 
   if (!expanded) {
     return (
-      <Box
-        width={width}
-        height={drawerHeight}
-        flexDirection="row"
-        backgroundColor={colors.bg}
-        onMouseDown={(event: CashDrawerPointerEvent) => {
-          event.preventDefault();
-          event.stopPropagation();
-          onToggle();
-        }}
-        onMouseUp={(event: CashDrawerPointerEvent) => {
-          event.preventDefault();
-          event.stopPropagation();
-        }}
-      >
-        <Text fg={colors.textBright} attributes={TextAttributes.BOLD}>{`▸ ${t("Cash & Margin")}`}</Text>
+      <ActionRow label={t("Cash & Margin")} expanded={false} width={width} height={drawerHeight} onPress={onToggle}>
         <Box flexGrow={1} />
         <Text fg={colors.textDim}>{padTo(previewText, Math.max(0, width - 17), "right")}</Text>
-      </Box>
+      </ActionRow>
     );
   }
 
@@ -139,25 +120,10 @@ export function PortfolioCashMarginDrawer({
 
   return (
     <Box flexDirection="column" height={drawerHeight}>
-      <Box
-        width={width}
-        height={1}
-        flexDirection="row"
-        backgroundColor={colors.bg}
-        onMouseDown={(event: CashDrawerPointerEvent) => {
-          event.preventDefault();
-          event.stopPropagation();
-          onToggle();
-        }}
-        onMouseUp={(event: CashDrawerPointerEvent) => {
-          event.preventDefault();
-          event.stopPropagation();
-        }}
-      >
-        <Text fg={colors.textBright} attributes={TextAttributes.BOLD}>{`▾ ${t("Cash & Margin")}`}</Text>
+      <ActionRow label={t("Cash & Margin")} expanded width={width} onPress={onToggle}>
         <Box flexGrow={1} />
         <Text fg={colors.textDim}>{accountState.sourceLabel}</Text>
-      </Box>
+      </ActionRow>
       <Box height={1} overflow="hidden">
         {renderSummarySegments(metricSegments, width)}
       </Box>

package/src/plugins/builtin/portfolio-list/metrics.test.ts

@@ -4,6 +4,7 @@ import type { ColumnConfig } from "../../../types/config";
 import type { Quote, TickerFinancials } from "../../../types/financials";
 import type { TickerRecord } from "../../../types/ticker";
 import { blendHex, colors } from "../../../theme/colors";
+import { buildPortfolioSummarySegments } from "./summary";
 import {
   calculatePortfolioSummaryTotals,
   getColumnValue,
@@ -60,6 +61,50 @@ const defaultColumnContext: ColumnContext = {
 };
 
 describe("portfolio-metrics", () => {
+  test("withholds future holding age without changing the source date or same-day holdings", () => {
+    const context = { ...defaultColumnContext, now: Date.UTC(2026, 8, 12, 12) };
+    const column: ColumnConfig = { id: "held", label: "HELD", width: 8, align: "right" };
+    for (const [dateAcquired, text, sort] of [
+      ["2026-09-20", "—", null],
+      ["2026-09-13T01:00:00+02:00", "0d", 0],
+      ["2026-09-12T23:59:59Z", "0d", 0],
+      ["2026-09-11", "1d", 1],
+      ["not-a-date", "—", null],
+    ] as const) {
+      const ticker = createTicker({ positions: [
+        { portfolio: "main", shares: 10, avgCost: 100, broker: "manual", dateAcquired },
+        { portfolio: "other", shares: 1, avgCost: 1, broker: "manual", dateAcquired: "2020-01-02" },
+      ] });
+      expect(getColumnValue(column, ticker, undefined, context).text).toBe(text);
+      expect(getSortValue(column, ticker, undefined, context)).toBe(sort);
+      expect(ticker.metadata.positions[0]!.dateAcquired).toBe(dateAcquired);
+    }
+  });
+
+  test("withholds mixed-currency totals until FX is known, then restores complete values", () => {
+    const us = createTicker({ positions: [{ portfolio: "main", shares: 10, avgCost: 100, broker: "manual" }] });
+    const eur = createTicker({ ticker: "SAP", currency: "EUR", positions: [{ portfolio: "main", shares: 10, avgCost: 100, broker: "manual", currency: "EUR" }] });
+    const financials = new Map([
+      ["AAPL", createFinancials()],
+      ["SAP", createFinancials({ quote: { symbol: "SAP", currency: "EUR" } })],
+    ]);
+    const unavailable = calculatePortfolioSummaryTotals([us, eur], financials, "USD", new Map(), true, "main");
+    expect(unavailable.totalMktValue).toBeNaN();
+    expect(unavailable.unrealizedPnl).toBeNaN();
+    expect(unavailable.unavailableConversions).toEqual(["EUR/USD"]);
+    const segments = buildPortfolioSummarySegments({ totals: unavailable, accountState: null, widthBudget: 200 });
+    const rendered = segments.flatMap((segment) => segment.parts.map((part) => part.text)).join(" ");
+    expect(rendered).toContain("FX unavailable");
+    expect(rendered).toContain("Val —");
+    expect(rendered).not.toContain("NaN");
+    expect(rendered).not.toContain("2.4k");
+
+    const restored = calculatePortfolioSummaryTotals([us, eur], financials, "USD", new Map([["EUR", 1.2]]), true, "main");
+    expect(restored.totalMktValue).toBe(2640);
+    expect(restored.unrealizedPnl).toBe(440);
+    expect(restored.unavailableConversions).toBeUndefined();
+  });
+
   test("defaults portfolio tabs to market value descending", () => {
     expect(resolveCollectionSortPreference("main", true, {})).toEqual({
       columnId: "mkt_value",
@@ -164,7 +209,7 @@ describe("portfolio-metrics", () => {
     )).toMatchObject({
       totalMktValue: 1250,
       totalCostBasis: 1000,
-      dailyPnl: 0,
+      dailyPnl: Number.NaN,
       unrealizedPnl: 250,
       hasPositions: true,
     });
@@ -236,6 +281,7 @@ describe("portfolio-metrics", () => {
       text: "5,095.073",
     });
     expect(getColumnValue(pnlColumn, ticker, financials, defaultColumnContext)).toEqual({
+      pnlBasis: "quote-and-cost",
       text: "+7.9k",
       color: expect.any(String),
     });
@@ -268,6 +314,7 @@ describe("portfolio-metrics", () => {
     });
     expect(getSortValue(dayPnlColumn, ticker, financials, defaultColumnContext)).toBe(50);
     expect(getColumnValue(pnlColumn, ticker, financials, defaultColumnContext)).toEqual({
+      pnlBasis: "quote-and-cost",
       text: "+200",
       color: expect.any(String),
     });
@@ -290,6 +337,7 @@ describe("portfolio-metrics", () => {
     expect(getSortValue(dayPnlColumn, ticker, financials, defaultColumnContext)).toBe(200);
     expect(getSortValue(pnlColumn, ticker, financials, defaultColumnContext)).toBe(200);
     expect(getColumnValue(pnlColumn, ticker, financials, defaultColumnContext)).toEqual({
+      pnlBasis: "quote-and-cost",
       text: "+200",
       color: expect.any(String),
     });
@@ -400,3 +448,87 @@ describe("portfolio-metrics", () => {
     expect(getSortValue({ id: "target_pct", label: "TARGET%", width: 8, align: "right" }, ticker, financials, context)).toBe(25);
   });
 });
+
+
+describe("position aggregation across sides, currencies and broker coverage", () => {
+  const column = (id: string): ColumnConfig => ({ id, label: id, width: 12, align: "right" });
+  test("keeps offsetting long/short gross exposure and signed costs in summary, cells and sorts", () => {
+    const ticker = createTicker({ positions: [
+      { portfolio: "main", shares: 100, avgCost: 100, broker: "manual", side: "long" },
+      { portfolio: "main", shares: 100, avgCost: 110, broker: "manual", side: "short" },
+    ] });
+    const financials = createFinancials();
+    const totals = calculatePortfolioSummaryTotals([ticker], new Map([["AAPL", financials]]), "USD", new Map(), true, "main");
+    expect(totals).toMatchObject({ hasPositions: true, hasShorts: true, totalMktValue: 24000, netMktValue: 0, totalCostBasis: 21000, unrealizedPnl: 1000, dailyPnl: 0 });
+    expect(getSortValue(column("mkt_value"), ticker, financials, defaultColumnContext)).toBe(24000);
+    expect(getSortValue(column("pnl"), ticker, financials, defaultColumnContext)).toBe(1000);
+    expect(getSortValue(column("pnl_pct"), ticker, financials, defaultColumnContext)).toBeCloseTo(1000 / 21000 * 100);
+    expect(getColumnValue(column("shares"), ticker, financials, defaultColumnContext).text).toBe("0");
+    expect(getColumnValue(column("pnl"), ticker, financials, defaultColumnContext).text).toBe("+1k");
+    expect(buildPortfolioSummarySegments({ totals, accountState: null, widthBudget: 200 }).map(segment => segment.parts.map(part => part.text).join(" ")).join(" ")).toContain("Gross 24k Net 0");
+  });
+
+  test("converts each cost basis before summing and withholds averages across native currencies", () => {
+    const ticker = createTicker({ positions: [
+      { portfolio: "main", shares: 10, avgCost: 100, currency: "USD", broker: "manual" },
+      { portfolio: "main", shares: 10, avgCost: 80, currency: "EUR", broker: "manual" },
+    ] });
+    const financials = createFinancials();
+    const context = { ...defaultColumnContext, exchangeRates: new Map([["USD", 1], ["EUR", 1.25]]) };
+    const totals = calculatePortfolioSummaryTotals([ticker], new Map([["AAPL", financials]]), "USD", context.exchangeRates, true, "main");
+    expect(totals.totalCostBasis).toBe(2000);
+    expect(totals.unrealizedPnl).toBe(400);
+    expect(getSortValue(column("cost_basis"), ticker, financials, context)).toBe(2000);
+    expect(getSortValue(column("pnl"), ticker, financials, context)).toBe(400);
+    expect(getColumnValue(column("avg_cost"), ticker, financials, context).text).toBe("—");
+    const unavailable = calculatePortfolioSummaryTotals([ticker], new Map([["AAPL", financials]]), "USD", new Map(), true, "main");
+    expect(unavailable.unrealizedPnl).toBeNaN();
+    expect(unavailable.unavailableConversions).toEqual(["EUR/USD"]);
+  });
+
+  test("reconciles signed short broker values and contract-scaled costs without inventing daily P&L", () => {
+    const ticker = createTicker({ positions: [{ portfolio: "main", shares: -10, avgCost: 500, multiplier: 100, currency: "USD", broker: "ibkr", marketValue: -4000, unrealizedPnl: 1000 }] });
+    const totals = calculatePortfolioSummaryTotals([ticker], new Map(), "USD", new Map(), true, "main");
+    expect(totals).toMatchObject({ totalMktValue: 4000, netMktValue: -4000, totalCostBasis: 5000, unrealizedPnl: 1000 });
+    expect(totals.dailyPnl).toBeNaN();
+    expect(getColumnValue(column("side"), ticker, undefined, defaultColumnContext).text).toBe("SHORT");
+    ticker.metadata.positions[0]!.marketValue = undefined;
+    const fromPnl = calculatePortfolioSummaryTotals([createTicker({ positions: [{ portfolio: "main", shares: -10, avgCost: 100, broker: "ibkr", unrealizedPnl: 100 }] })], new Map(), "USD", new Map(), true, "main");
+    expect(fromPnl).toMatchObject({ totalMktValue: 900, netMktValue: -900, unrealizedPnl: 100 });
+  });
+
+  test("does not pass off one broker lot or one ticker as a complete portfolio valuation", () => {
+    const ticker = createTicker({ positions: [
+      { portfolio: "main", shares: 10, avgCost: 100, broker: "ibkr", marketValue: 1200, unrealizedPnl: 200 },
+      { portfolio: "main", shares: 10, avgCost: 110, broker: "manual" },
+    ] });
+    const totals = calculatePortfolioSummaryTotals([ticker], new Map(), "USD", new Map(), true, "main");
+    expect(totals.hasPositions).toBe(true);
+    expect(totals.totalCostBasis).toBe(2100);
+    expect(totals.totalMktValue).toBeNaN();
+    expect(totals.unrealizedPnl).toBeNaN();
+    expect(totals.unavailableSymbols).toEqual(["AAPL"]);
+    expect(getSortValue(column("mkt_value"), ticker, undefined, defaultColumnContext)).toBeNull();
+    expect(getSortValue(column("pnl"), ticker, undefined, defaultColumnContext)).toBeNull();
+  });
+});
+
+
+test("portfolio daily P&L and extended-hours returns use distinct reference closes", () => {
+  const ticker = createTicker({ positions: [{ portfolio: "main", shares: 10, avgCost: 200, broker: "manual" }] });
+  const financials = createFinancials({ quote: { price: 218.36, previousClose: 223.67,
+    change: -5.31, changePercent: -2.374, marketState: "POST", postMarketPrice: 218.47,
+    postMarketChange: 0.11, postMarketChangePercent: 0.0503755266532 } });
+  const column = (id: string): ColumnConfig => ({ id, label: id, width: 15, align: "right" });
+  expect(getSortValue(column("day_pnl"), ticker, financials, defaultColumnContext)).toBeCloseTo(-52, 8);
+  expect(getColumnValue(column("change_pct"), ticker, financials, defaultColumnContext).text).toBe("-2.32%");
+  expect(getColumnValue(column("ext_hours"), ticker, financials, defaultColumnContext).text).toBe("+0.05%");
+  expect(calculatePortfolioSummaryTotals([ticker], new Map([["AAPL", financials]]), "USD", new Map([["USD", 1]]), true, "main").dailyPnl).toBeCloseTo(-52, 8);
+  delete financials.quote!.previousClose;
+  expect(getColumnValue(column("day_pnl"), ticker, financials, defaultColumnContext).text).toBe("—");
+  expect(getSortValue(column("day_pnl"), ticker, financials, defaultColumnContext)).toBeNull();
+  expect(calculatePortfolioSummaryTotals([ticker], new Map([["AAPL", financials]]), "USD", new Map([["USD", 1]]), true, "main").dailyPnl).toBeNaN();
+  delete financials.quote!.postMarketChangePercent;
+  expect(getColumnValue(column("ext_hours"), ticker, financials, defaultColumnContext).text).toBe("—");
+  expect(getSortValue(column("ext_hours"), ticker, financials, defaultColumnContext)).toBeNull();
+});

package/src/plugins/builtin/portfolio-list/mutations.test.ts

@@ -176,6 +176,19 @@ describe("portfolio-list mutations", () => {
     }]);
   });
 
+  test("split reconciliation preserves a single acquisition date without retaining stale valuation", () => {
+    const position = { portfolio: "main", shares: 10, avgCost: 500, currency: "USD", broker: "manual", dateAcquired: "2024-01-02", marketValue: 10000, markPrice: 1000 };
+    const ticker = makeTicker({ portfolios: ["main"], positions: [position] });
+    const input = { shares: 100, avgCost: 50, currency: "USD" };
+    const reconciled = setManualPortfolioPosition(ticker, "main", input).ticker.metadata.positions[0]!;
+    expect(reconciled.dateAcquired).toBe("2024-01-02");
+    expect(reconciled.shares * reconciled.avgCost!).toBe(position.shares * position.avgCost);
+    expect(reconciled.marketValue).toBeUndefined();
+    expect(reconciled.markPrice).toBeUndefined();
+    ticker.metadata.positions.push({ ...position, dateAcquired: "2024-03-01" });
+    expect(setManualPortfolioPosition(ticker, "main", input).ticker.metadata.positions[0]!.dateAcquired).toBeUndefined();
+  });
+
   test("resolves position currency from explicit, ticker, portfolio, or base currency defaults", () => {
     const portfolio = { id: "research", name: "Research", currency: "EUR" };
 

package/src/plugins/builtin/portfolio-list/mutations.ts

@@ -180,7 +180,12 @@ export function setManualPortfolioPosition(
     throw new Error("Position currency is required.");
   }
 
-  const replacedPositionCount = ticker.metadata.positions.filter((position) => position.portfolio === portfolioId).length;
+  const replacedPositions = ticker.metadata.positions.filter((position) => position.portfolio === portfolioId);
+  const replacedPositionCount = replacedPositions.length;
+  // Editing a single snapshot (for example after a split) does not change its
+  // acquisition date. A consolidated replacement of several lots has no one date.
+  const dateAcquired = replacedPositions.length === 1 && replacedPositions[0]?.broker === "manual"
+    ? replacedPositions[0].dateAcquired : undefined;
   const nextPositions = ticker.metadata.positions.filter((position) => position.portfolio !== portfolioId);
   const addedMembership = !ticker.metadata.portfolios.includes(portfolioId);
 
@@ -190,6 +195,7 @@ export function setManualPortfolioPosition(
     avgCost: input.avgCost,
     currency: nextCurrency,
     broker: "manual",
+    ...(dateAcquired ? { dateAcquired } : {}),
   });
 
   return {

package/src/plugins/builtin/portfolio-list/pane/data.ts

@@ -3,6 +3,7 @@ import { PRICE_SPARKLINE_COLUMN_ID } from "../../../../components/price-sparklin
 import type { AppConfig, ColumnConfig } from "../../../../types/config";
 import type { TickerFinancials } from "../../../../types/financials";
 import type { TickerRecord } from "../../../../types/ticker";
+import { selectMarketCapitalization } from "../../../../utils/market-capitalization";
 import type { CollectionSortPreference } from "../../../../state/app/context";
 import { isQuoteStaleForCurrentSession } from "../../../../market-data/quotes/freshness";
 import { resolveQuoteAgeTimestamp } from "../../../../market-data/quotes/time";
@@ -135,6 +136,7 @@ export function buildTrackedCurrencies(
   baseCurrency: string,
 ): string[] {
   const currencies = new Set<string>([baseCurrency]);
+  if (accountState?.account.currency) currencies.add(accountState.account.currency);
 
   for (const ticker of tickers) {
     if (ticker.metadata.currency) {
@@ -149,6 +151,8 @@ export function buildTrackedCurrencies(
     if (financials?.quote?.currency) {
       currencies.add(financials.quote.currency);
     }
+    const cap = selectMarketCapitalization(financials?.quote, financials?.fundamentals);
+    if (cap) currencies.add(cap.currency);
   }
 
   for (const balance of accountState?.visibleCashBalances ?? []) {