gloomberb 0.13.2 → 0.14.0

package/src/plugins/builtin/econ-statistics/pane.test.tsx

@@ -0,0 +1,69 @@
+import { afterEach, expect, test } from "bun:test";
+import { act } from "react";
+import { PaneFooterProvider } from "../../../components/layout/pane/footer";
+import { emitKeypress, testRender } from "../../../renderers/opentui/test-utils";
+import { createInitialState } from "../../../state/app/context";
+import { createTestPaneConfig, TestPaneProvider } from "../../../test-support/pane";
+import { createTestPluginRuntime } from "../../../test-support/plugin-runtime";
+import { Box } from "../../../ui";
+import { statsCache } from "./cache";
+import { EconStatisticsPane } from "./pane";
+import { STATS } from "./stats";
+
+let setup: Awaited<ReturnType<typeof testRender>> | undefined;
+afterEach(async () => {
+  if (setup) await act(async () => { setup!.renderer.destroy(); });
+  setup = undefined;
+  statsCache.reset();
+});
+
+test.each([
+  { width: 48, partial: false },
+  { width: 120, partial: false },
+  { width: 48, partial: true },
+])("selected source and basis remain reachable at $width columns with partial=$partial", async ({ width, partial }) => {
+  // Hydrate the actual catalog loader without contacting a provider. Quarter and
+  // month series need enough calendar observations for their real transforms.
+  statsCache.hydrate(STATS.map((stat) => [stat.seriesId, partial && stat.seriesId === "CPIAUCNS" ? [] : Array.from({ length: 25 }, (_, index) => ({
+    date: new Date(Date.UTC(2019, index * (stat.transform === "qoq-annualized" ? 3 : 1), 1)).toISOString().slice(0, 10),
+    value: 100 + index,
+  }))] as const));
+  const state = createInitialState(createTestPaneConfig("/tmp/gloom-ecst-scroll", {
+    instanceId: "ecst:test", paneId: "econ-statistics", settings: { stat: "curve-spread" },
+  }));
+  await act(async () => {
+    setup = await testRender(
+      <TestPaneProvider state={state} paneId="ecst:test" pluginId="market-overview" runtime={createTestPluginRuntime()}>
+        <PaneFooterProvider>{() => <Box width={width} height={36}>
+          <EconStatisticsPane paneId="ecst:test" paneType="econ-statistics" width={width} height={36} focused />
+        </Box>}</PaneFooterProvider>
+      </TestPaneProvider>,
+      { width, height: 36 },
+    );
+  });
+  for (let frame = 0; frame < 4; frame++) await act(async () => {
+    await new Promise((resolve) => setTimeout(resolve, 0));
+    await setup!.renderOnce();
+  });
+  expect(setup!.captureCharFrame()).toContain("2s10s");
+  await act(async () => {
+    for (let tick = 0; tick < 8; tick++) await setup!.mockMouse.scroll(width - 1, 34, "down");
+    await setup!.renderOnce();
+  });
+  const scrolled = setup!.captureCharFrame();
+  expect(scrolled).toContain("FRED T10Y2Y");
+  expect(scrolled).toContain("10Y minus 2Y");
+  expect(scrolled).toContain("High 124.00% 2021-01-01");
+  expect(scrolled).toContain("Low 100.00% 2019-01-01");
+  expect(scrolled).toContain("20Y");
+  expect(scrolled).toContain("All");
+  if (partial) {
+    expect(scrolled).not.toContain("CPIAUCNS");
+    await emitKeypress(setup!, { name: "!", sequence: "!", shift: true }, { trackPropagation: true });
+    await act(async () => { await setup!.renderOnce(); });
+    expect(setup!.captureCharFrame()).toContain("CPIAUCNS");
+    await emitKeypress(setup!, { name: "escape" }, { trackPropagation: true });
+    await act(async () => { await setup!.renderOnce(); });
+    expect(setup!.captureCharFrame()).toContain("FRED T10Y2Y");
+  }
+});

package/src/plugins/builtin/econ-statistics/pane.tsx

@@ -1,32 +1,33 @@
-import { useCallback, useEffect, useMemo, useRef, useState } from "react";
+import { useCallback, useMemo, useRef, useState } from "react";
 import {
   DataTableView,
   EmptyState,
-  InputSearchBar,
-  SegmentedControl,
-  Spinner,
-  type DataTableCell,
+  InputSearchBar, PaneStatusBody, usePaneNoticeFooter, SegmentedControl, type DataTableCell,
   type DataTableColumn,
   type DataTableKeyEvent,
   type DataTableSelectionChangeReason,
-  type PaneFooterSegment,
+  type PaneFooterSegment
 } from "../../../components";
+import { useAsyncResource } from "../../../react/async-resource";
 import { useShortcut } from "../../../react/input";
 import { usePaneSettingValue } from "../../../state/app/context";
 import { colors } from "../../../theme/colors";
 import type { PaneProps } from "../../../types/plugin";
-import { Box, ScrollBox, Text, type InputRenderable } from "../../../ui";
+import { Box, ScrollBox, type InputRenderable } from "../../../ui";
 import { formatNumber } from "../../../utils/format";
 import { isPlainKey } from "../../../utils/keyboard";
 import { stopSearchFocusNavigation } from "../../../utils/search-focus-navigation";
 import { useAutoRefresh } from "../shared/auto-refresh";
 import { usePaneStatusFooter } from "../shared/pane-footer";
-import { getCachedStatsBundle, loadStatsBundle, type StatsBundle } from "./client";
+import { getCachedStatsBundle, loadStatsBundle } from "./client";
 import { categoryLabel, changeColor, type StatCategoryId } from "./defs";
 import { StatDetail } from "./detail";
 import { DEFAULT_STAT_ID } from "./stats";
 import { selectStatViews, type StatRangeId, type StatViewModel } from "./view";
 
+const loadBundle = (force: boolean) => loadStatsBundle({ force });
+const noop = () => {};
+
 const SPLIT_MIN_WIDTH = 108;
 const LIST_WIDTH = 46;
 
@@ -36,12 +37,6 @@ const RANGE_OPTIONS = [
   { value: "ALL" as const, label: "All" },
 ];
 
-type LoadState =
-  | { status: "idle" }
-  | { status: "loading"; previous: StatsBundle | null }
-  | { status: "ready"; bundle: StatsBundle }
-  | { status: "error"; message: string; previous: StatsBundle | null };
-
 type ColumnId = "name" | "latest" | "previous" | "percentile";
 interface Column extends DataTableColumn { id: ColumnId }
 
@@ -66,22 +61,6 @@ function withCategoryHeaders(views: readonly StatViewModel[]): Row[] {
   return rows;
 }
 
-function bundleOf(state: LoadState): StatsBundle | null {
-  switch (state.status) {
-    case "idle":
-      return null;
-    case "loading":
-    case "error":
-      return state.previous;
-    case "ready":
-      return state.bundle;
-    default: {
-      const _exhaustive: never = state;
-      return _exhaustive;
-    }
-  }
-}
-
 function matchesQuery(view: StatViewModel, query: string): boolean {
   if (!query) return true;
   const haystack = [
@@ -126,6 +105,19 @@ function cellsFor(view: StatViewModel): Record<ColumnId, DataTableCell> {
   };
 }
 
+// Module-level so the table's memoized rows keep their identity across pane
+// renders; an inline arrow would re-render every visible row on each keypress.
+const rowKey = (row: Row) => row.id;
+const isStatRow = (row: Row) => row.kind === "stat";
+function renderRowCell(row: Row, column: Column): DataTableCell {
+  return row.kind === "stat" ? cellsFor(row.view)[column.id] : { text: "" };
+}
+function renderRowSectionHeader(row: Row) {
+  return row.kind === "header"
+    ? { text: categoryLabel(row.category), color: colors.textMuted }
+    : null;
+}
+
 /**
  * A commit that arrives while the chosen row is filtered away comes from the
  * table's deferred index, not from the user, so it must not rewrite the setting.
@@ -148,37 +140,12 @@ export function shouldPersistStat({
 export function EconStatisticsPane({ focused, width, height }: PaneProps) {
   const [statId, setStatId] = usePaneSettingValue<string>("stat", DEFAULT_STAT_ID);
   const [range, setRange] = usePaneSettingValue<StatRangeId>("range", "20Y");
-  const [state, setState] = useState<LoadState>(() => {
-    const cached = getCachedStatsBundle();
-    return cached ? { status: "ready", bundle: cached } : { status: "idle" };
-  });
-  const [lastUpdated, setLastUpdated] = useState<number | null>(null);
+  const resource = useAsyncResource(loadBundle, { initialData: () => getCachedStatsBundle() });
+  const { data: bundle, load: refresh, reload, updatedAt: lastUpdated } = resource;
   const [query, setQuery] = useState("");
   const [searchFocused, setSearchFocused] = useState(false);
   const [searchFocusToken, setSearchFocusToken] = useState(0);
   const searchInputRef = useRef<InputRenderable | null>(null);
-  const generation = useRef(0);
-
-  const load = useCallback(async () => {
-    const current = ++generation.current;
-    setState((previous) => ({ status: "loading", previous: bundleOf(previous) }));
-    try {
-      const next = await loadStatsBundle();
-      if (generation.current !== current) return;
-      setState({ status: "ready", bundle: next });
-      setLastUpdated(Date.now());
-    } catch (error) {
-      if (generation.current !== current) return;
-      setState((previous) => ({
-        status: "error",
-        message: error instanceof Error ? error.message : String(error),
-        previous: bundleOf(previous),
-      }));
-    }
-  }, []);
-
-  useEffect(() => { void load(); }, [load]);
-  const refresh = useCallback(() => { void load(); }, [load]);
   useAutoRefresh(lastUpdated, refresh);
 
   const focusSearch = useCallback(() => {
@@ -195,20 +162,19 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
     }
     if (isPlainKey(event, "r")) {
       stopSearchFocusNavigation(event);
-      refresh();
+      reload();
       return true;
     }
     return false;
-  }, [focusSearch, refresh]);
+  }, [focusSearch, reload]);
 
   useShortcut((event) => {
     if (!focused || searchFocused || event.name !== "r") return;
     event.preventDefault?.();
     event.stopPropagation?.();
-    refresh();
+    reload();
   });
 
-  const bundle = bundleOf(state);
   const views = useMemo(
     () => (bundle ? selectStatViews(bundle.builds, range) : []),
     [bundle, range],
@@ -232,13 +198,13 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
     setStatId(id);
   }, [selectionOnScreen, setStatId, views]);
 
-  const error = state.status === "error" ? state.message : bundle?.errors[0] ?? null;
+  const error = resource.error ?? bundle?.errors[0] ?? null;
   const footerInfo = useMemo<PaneFooterSegment[]>(() => {
     if (!selected) return [];
     const info: PaneFooterSegment[] = [
       { id: "as-of", parts: [{ text: `as of ${selected.latest.date}`, tone: "muted" }] },
     ];
-    if (selected.observationStale) {
+    if (selected.observationStale || selected.cacheStale) {
       info.push({ id: "stale", parts: [{ text: "STALE", tone: "warning", bold: true }] });
     }
     if (normalizedQuery) {
@@ -249,23 +215,28 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
 
   usePaneStatusFooter({
     registrationId: "econ-statistics",
-    loading: state.status === "loading",
-    error,
+    loading: resource.loading,
+    error: selected ? null : error,
     info: footerInfo,
   });
+  usePaneNoticeFooter({
+    registrationId: "econ-statistics:notices",
+    notices: error ? [error] : [],
+    focused: focused && !searchFocused,
+    enabled: !!selected,
+    title: "Economic data",
+  });
 
-  if (!bundle && state.status !== "error") {
+  if (!bundle && resource.error === null) {
     return (
-      <Box width={width} height={height} justifyContent="center" alignItems="center">
-        <Spinner label="Loading economic statistics..." />
-      </Box>
+      <PaneStatusBody loading align="center" width={width} height={height} loadingLabel="Loading economic statistics..." />
     );
   }
 
   if (!selected) {
     return (
       <Box width={width} height={height} padding={1} flexDirection="column" gap={1}>
-        <EmptyState title="Economic statistics unavailable." message={error ?? undefined} />
+        <EmptyState status={error ? "error" : "empty"} title="Economic statistics unavailable." message={error ?? undefined} />
       </Box>
     );
   }
@@ -277,6 +248,10 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
   const tableHeight = split
     ? Math.max(3, height - 2)
     : Math.min(rows.length + 2, Math.max(3, height - 12));
+  // The stacked list consumes real rows. Giving its detail scroller the whole
+  // pane height leaves its lower content clipped outside the scroll viewport.
+  const bodyHeight = Math.max(1, height - (error ? 1 : 0));
+  const detailHeight = split ? bodyHeight : Math.max(1, bodyHeight - tableHeight - 1);
 
   return (
     <Box flexDirection="column" width={width} height={height}>
@@ -310,23 +285,18 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
                 getId: (row) => row.id,
                 onChange: (id, _item, _index, reason) => chooseStat(String(id), reason),
               }}
-              isNavigable={(row) => row.kind === "stat"}
-              onHeaderClick={() => {}}
+              isNavigable={isStatRow}
+              onHeaderClick={noop}
               onRootKeyDown={handlePaneKey}
-              getItemKey={(row) => row.id}
-              renderCell={(row, column) =>
-                row.kind === "stat"
-                  ? cellsFor(row.view)[column.id]
-                  : { text: "" }}
-              renderSectionHeader={(row) => (row.kind === "header"
-                ? { text: categoryLabel(row.category), color: colors.textMuted }
-                : null)}
+              getItemKey={rowKey}
+              renderCell={renderRowCell}
+              renderSectionHeader={renderRowSectionHeader}
               emptyStateTitle={normalizedQuery ? "No statistic matches." : error ?? "No statistics."}
             />
           </Box>
         </Box>
 
-        <Box flexDirection="column" flexGrow={1} width={detailWidth} overflow="hidden">
+        <Box flexDirection="column" flexGrow={1} width={detailWidth} height={detailHeight} overflow="hidden">
           <Box flexDirection="row" height={1} paddingX={1} overflow="hidden" justifyContent="flex-end">
             <SegmentedControl
               options={RANGE_OPTIONS}
@@ -334,7 +304,7 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
               onChange={(value) => setRange(value as StatRangeId)}
             />
           </Box>
-          <ScrollBox flexGrow={1} scrollY focusable={false}>
+          <ScrollBox height={Math.max(1, detailHeight - 1)} scrollY focusable={false}>
             <Box flexDirection="column" paddingBottom={1}>
               <StatDetail
                 view={selected}
@@ -346,11 +316,6 @@ export function EconStatisticsPane({ focused, width, height }: PaneProps) {
           </ScrollBox>
         </Box>
       </Box>
-      {error ? (
-        <Box height={1} paddingX={1} overflow="hidden">
-          <Text fg={colors.warning}>{error}</Text>
-        </Box>
-      ) : null}
     </Box>
   );
 }

package/src/plugins/builtin/econ-statistics/stats.ts

@@ -24,32 +24,34 @@ export const STATS: readonly StatDef[] = [
   // ---- Inflation -------------------------------------------------------
   stat({
     id: "cpi-yoy",
+    measurementBasis: "Not seasonally adjusted",
     label: "CPI",
     shortLabel: "CPI y/y",
     category: "inflation",
-    seriesId: "CPIAUCSL",
+    seriesId: "CPIAUCNS",
     transform: "yoy",
     direction: "higher-is-bad",
     axisUnit: "%",
     formatValue: pct,
     reference: { value: 2, label: "2%" },
     staleAfterMs: MONTHLY,
-    note: "Headline consumer prices against a year earlier, including food and energy.",
+    note: "Headline consumer prices against a year earlier, not seasonally adjusted, including food and energy.",
     limit: 900,
   }),
   stat({
     id: "core-cpi-yoy",
+    measurementBasis: "NSA · excludes food & energy",
     label: "Core CPI",
     shortLabel: "Core CPI y/y",
     category: "inflation",
-    seriesId: "CPILFESL",
+    seriesId: "CPILFENS",
     transform: "yoy",
     direction: "higher-is-bad",
     axisUnit: "%",
     formatValue: pct,
     reference: { value: 2, label: "2%" },
     staleAfterMs: MONTHLY,
-    note: "Consumer prices excluding food and energy, the slower-moving trend.",
+    note: "Consumer prices excluding food and energy against a year earlier, not seasonally adjusted.",
     limit: 900,
   }),
   stat({
@@ -69,6 +71,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "core-pce-yoy",
+    measurementBasis: "Excludes food & energy",
     label: "Core PCE Prices",
     shortLabel: "Core PCE y/y",
     category: "inflation",
@@ -77,24 +80,25 @@ export const STATS: readonly StatDef[] = [
     direction: "higher-is-bad",
     axisUnit: "%",
     formatValue: pct,
-    reference: { value: 2, label: "Fed target" },
+    reference: { value: 2, label: "2% reference" },
     staleAfterMs: MONTHLY,
-    note: "The measure the Federal Reserve actually targets at two percent.",
+    note: "Excludes food and energy to track underlying PCE inflation. The Fed target applies to overall PCE inflation.",
     limit: 900,
   }),
   stat({
     id: "ppi-yoy",
+    measurementBasis: "Final demand · not seasonally adjusted",
     label: "Producer Prices",
     shortLabel: "PPI y/y",
     category: "inflation",
-    seriesId: "PPIACO",
+    seriesId: "PPIFID",
     transform: "yoy",
     direction: "higher-is-bad",
     axisUnit: "%",
     formatValue: pct,
     reference: null,
     staleAfterMs: MONTHLY,
-    note: "What producers receive, which tends to lead consumer prices.",
+    note: "Final-demand producer prices against a year earlier, not seasonally adjusted.",
     limit: 900,
   }),
 
@@ -131,6 +135,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "initial-claims",
+    measurementBasis: "Weekly",
     label: "Initial Jobless Claims",
     shortLabel: "Claims",
     category: "labor",
@@ -163,6 +168,7 @@ export const STATS: readonly StatDef[] = [
   // ---- Growth ----------------------------------------------------------
   stat({
     id: "real-gdp",
+    measurementBasis: "q/q annualized",
     label: "Real GDP",
     shortLabel: "Real GDP q/q",
     category: "growth",
@@ -178,6 +184,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "industrial-production",
+    measurementBasis: "y/y",
     label: "Industrial Production",
     shortLabel: "Ind. prod.",
     category: "growth",
@@ -240,6 +247,7 @@ export const STATS: readonly StatDef[] = [
   // ---- Consumer --------------------------------------------------------
   stat({
     id: "retail-sales",
+    measurementBasis: "Not adjusted for prices",
     label: "Retail Sales",
     shortLabel: "Retail y/y",
     category: "consumer",
@@ -255,6 +263,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "core-retail-sales",
+    measurementBasis: "y/y · excludes motor vehicles",
     label: "Core Retail Sales",
     shortLabel: "Core retail",
     category: "consumer",
@@ -270,6 +279,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "consumer-sentiment",
+    measurementBasis: "Michigan survey",
     label: "Consumer Sentiment",
     shortLabel: "Sentiment",
     category: "consumer",
@@ -285,6 +295,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "personal-income",
+    measurementBasis: "Before tax",
     label: "Personal Income",
     shortLabel: "Income m/m",
     category: "consumer",
@@ -317,6 +328,7 @@ export const STATS: readonly StatDef[] = [
   // ---- Housing ---------------------------------------------------------
   stat({
     id: "housing-starts",
+    measurementBasis: "Annual rate",
     label: "Housing Starts",
     shortLabel: "Starts",
     category: "housing",
@@ -347,6 +359,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "new-home-sales",
+    measurementBasis: "Annual rate",
     label: "New Home Sales",
     shortLabel: "New homes",
     category: "housing",
@@ -363,8 +376,9 @@ export const STATS: readonly StatDef[] = [
   // ---- Rates & money ---------------------------------------------------
   stat({
     id: "fed-funds",
-    label: "Federal Funds Rate",
-    shortLabel: "Fed funds",
+    measurementBasis: "Monthly average · overnight",
+    label: "Effective Federal Funds Rate",
+    shortLabel: "Effective fed funds",
     category: "rates",
     seriesId: "FEDFUNDS",
     transform: "level",
@@ -373,7 +387,7 @@ export const STATS: readonly StatDef[] = [
     formatValue: pct2,
     reference: null,
     staleAfterMs: MONTHLY,
-    note: "The policy rate the Federal Reserve sets.",
+    note: "Monthly average effective overnight rate; the FOMC sets a separate target range.",
     limit: 900,
   }),
   stat({
@@ -408,6 +422,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "curve-spread",
+    measurementBasis: "10Y minus 2Y",
     label: "10Y minus 2Y Spread",
     shortLabel: "2s10s",
     category: "rates",
@@ -423,6 +438,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "real-ten-year",
+    measurementBasis: "Inflation-protected",
     label: "10-Year Real Yield",
     shortLabel: "10Y real",
     category: "rates",
@@ -455,6 +471,7 @@ export const STATS: readonly StatDef[] = [
   // ---- Trade & costs ---------------------------------------------------
   stat({
     id: "trade-balance",
+    measurementBasis: "Goods & services · exports minus imports",
     label: "Trade Balance",
     shortLabel: "Trade balance",
     category: "trade",
@@ -471,6 +488,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "productivity",
+    measurementBasis: "q/q annualized · output per hour",
     label: "Nonfarm Productivity",
     shortLabel: "Productivity",
     category: "trade",
@@ -486,6 +504,7 @@ export const STATS: readonly StatDef[] = [
   }),
   stat({
     id: "unit-labor-costs",
+    measurementBasis: "q/q annualized",
     label: "Unit Labor Costs",
     shortLabel: "Labor costs",
     category: "trade",

package/src/plugins/builtin/econ-statistics/transform.test.ts

@@ -83,4 +83,27 @@ describe("applyTransform", () => {
   test("a zero base cannot produce a percent change", () => {
     expect(applyTransform(monthly([0, 5]), "mom")).toHaveLength(0);
   });
+
+  test("missing months never shift year-over-year comparisons into different periods", () => {
+    const observations: Array<{ date: string; value: number | null }> = monthly([
+      100, 102, 104, 104, 104, 104, 104, 104, 104, 104, 104, 104, 110, 112,
+    ]);
+    observations[1]!.value = null;
+    expect(applyTransform(observations, "yoy")).toEqual([{ date: "2021-01-01", value: expect.closeTo(10, 6) }]);
+    const mom = applyTransform(observations, "mom");
+    expect(mom.some((point) => point.date === "2020-03-01")).toBe(false);
+  });
+
+  test("annualized GDP growth requires the immediately preceding quarter", () => {
+    const observations = [
+      { date: "2024-01-01", value: 100 },
+      { date: "2024-04-01", value: 101 },
+      { date: "2024-07-01", value: null },
+      { date: "2024-10-01", value: 104 },
+    ];
+    const result = applyTransform(observations, "qoq-annualized");
+    expect(result).toHaveLength(1);
+    expect(result[0]!.date).toBe("2024-04-01");
+    expect(result[0]!.value).toBeCloseTo((1.01 ** 4 - 1) * 100);
+  });
 });

package/src/plugins/builtin/econ-statistics/transform.ts

@@ -52,7 +52,7 @@ export function applyTransform(
 ): StatPoint[] {
   const clean = observations
     .filter((entry): entry is { date: string; value: number } =>
-      entry.value != null && Number.isFinite(entry.value))
+      entry.value != null && Number.isFinite(entry.value) && Number.isFinite(Date.parse(entry.date)))
     .slice()
     .sort((a, b) => a.date.localeCompare(b.date));
   if (clean.length === 0) return [];
@@ -61,12 +61,21 @@ export function applyTransform(
     return clean.map((entry) => ({ date: entry.date, value: entry.value }));
   }
 
-  const perYear = periodsPerYear(clean);
+  const perYear = transform === "qoq-annualized" ? 4 : periodsPerYear(clean);
   const lag = transform === "yoy" ? perYear : 1;
+  // FRED monthly/quarterly observations represent calendar periods. Removing a
+  // missing month before applying a positional lag turns y/y into a 13-month
+  // change, or reports a two-quarter GDP move as one quarter's annualized rate.
+  const calendarCadence = perYear === 12 || perYear === 4 || perYear === 1;
+  const byMonth = new Map(clean.map((point) => [point.date.slice(0, 7), point]));
+  const lagMonths = transform === "yoy" ? 12 : 12 / perYear;
   const out: StatPoint[] = [];
-  for (let i = lag; i < clean.length; i += 1) {
+  for (let i = 0; i < clean.length; i += 1) {
     const now = clean[i]!;
-    const before = clean[i - lag]!;
+    const before = calendarCadence
+      ? byMonth.get(new Date(Date.UTC(Number(now.date.slice(0, 4)), Number(now.date.slice(5, 7)) - 1 - lagMonths, 1)).toISOString().slice(0, 7))
+      : clean[i - lag];
+    if (!before) continue;
     if (transform === "change") {
       out.push({ date: now.date, value: now.value - before.value });
       continue;

package/src/plugins/builtin/econ-statistics/view.test.ts

@@ -0,0 +1,27 @@
+import { expect, test } from "bun:test";
+import { projectStat } from "./view";
+import { findStat } from "./stats";
+import { fitTrend } from "./trend";
+
+test("1Y ago matches calendar periods even when an intermediate month is missing", () => {
+  const points = Array.from({ length: 25 }, (_, index) => ({
+    date: new Date(Date.UTC(2024, 6 + index, 1)).toISOString().slice(0, 10),
+    value: index,
+  })).filter((point) => point.date !== "2025-10-01");
+  const view = projectStat({ stat: findStat("cpi-yoy"), points, trend: fitTrend(points) }, "5Y");
+  expect(view.latest.date).toBe("2026-07-01");
+  expect(view.yearAgo).toEqual({ date: "2025-07-01", value: 12 });
+  const missingBase = points.filter((point) => point.date !== "2025-07-01");
+  expect(projectStat({ stat: findStat("cpi-yoy"), points: missingBase, trend: fitTrend(missingBase) }, "5Y").yearAgo).toBeNull();
+});
+
+
+test("daily 1Y ago clamps February 29 to February 28 instead of looking forward into March", () => {
+  const points = [
+    { date: "2023-02-27", value: 4.1 }, { date: "2023-02-28", value: 4.2 },
+    { date: "2023-03-01", value: 4.3 }, { date: "2024-02-28", value: 4.4 },
+    { date: "2024-02-29", value: 4.5 },
+  ];
+  const view = projectStat({ stat: findStat("ten-year"), points, trend: fitTrend(points) }, "5Y");
+  expect(view.yearAgo).toEqual({ date: "2023-02-28", value: 4.2 });
+});