gloomberb 0.11.2 → 0.12.0

package/src/plugins/builtin/chart-composer/catalog-inventory.ts

@@ -10,6 +10,8 @@ import {
   FUTURES_CONTRACTS,
   FUTURES_SECTOR_LABELS,
 } from "../futures/contracts";
+import { INDICATORS as VALUATION_INDICATORS } from "../market-valuation/indicators";
+import { MARKET_VALUATION_CAPABILITY_ID } from "../market-valuation/chart-series";
 import { TREASURY_MATURITIES } from "../yield-curve/treasury-data";
 import { fieldCategory, type SeriesCatalogInstrument } from "./series-catalog";
 
@@ -23,7 +25,8 @@ export type CatalogSourceId =
   | "crypto"
   | "fred"
   | "futures"
-  | "treasury";
+  | "treasury"
+  | "valuation";
 
 export type CatalogFilterId =
   | "all"
@@ -31,7 +34,8 @@ export type CatalogFilterId =
   | "options"
   | "crypto"
   | "fred"
-  | "futures";
+  | "futures"
+  | "valuation";
 
 export interface CatalogSeriesRow {
   id: string;
@@ -53,6 +57,7 @@ export const CATALOG_FILTERS: ReadonlyArray<{ id: CatalogFilterId; label: string
   { id: "crypto", label: "Crypto" },
   { id: "fred", label: "FRED" },
   { id: "futures", label: "Futures" },
+  { id: "valuation", label: "Valuation" },
 ];
 
 const FILTER_SOURCES: Record<CatalogFilterId, ReadonlySet<CatalogSourceId> | null> = {
@@ -62,6 +67,7 @@ const FILTER_SOURCES: Record<CatalogFilterId, ReadonlySet<CatalogSourceId> | nul
   crypto: new Set(["crypto"]),
   fred: new Set(["fred", "treasury"]),
   futures: new Set(["futures"]),
+  valuation: new Set(["valuation"]),
 };
 
 const CRYPTO_CATALOG: ReadonlyArray<{ symbol: string; name: string }> = [
@@ -321,6 +327,14 @@ const STATIC_CATALOG_INVENTORY: readonly CatalogSeriesRow[] = [
     expression: `UST:${entry.maturity}`,
     url: `https://fred.stlouisfed.org/series/${entry.seriesId}`,
   })),
+  ...VALUATION_INDICATORS.map((entry) => row({
+    id: `valuation:${entry.id}`,
+    label: entry.label,
+    source: "Gloom Cloud",
+    sourceId: "valuation",
+    kind: "Valuation",
+    expression: `CAP:${MARKET_VALUATION_CAPABILITY_ID}:${entry.id}`,
+  })),
   ...FUTURES_CONTRACTS.map((entry) => row({
     id: `fut:${entry.code}`,
     label: `${entry.name} (${entry.code})`,

package/src/plugins/builtin/chart-composer/cli-options.ts

@@ -1,4 +1,10 @@
 import type { NormalizedPaneFunctionOptions } from "../../../cli/pane-functions/capabilities";
+import {
+  CHART_RESOLUTIONS,
+  TIME_RANGES,
+  type ChartResolution,
+  type TimeRange,
+} from "../../../time-series/range";
 import {
   coerceSeriesTransformForStyle,
   normalizeChartSpec,
@@ -7,20 +13,17 @@ import type { ChartSeriesSpec, ChartSpec, SeriesPeriod } from "../../../time-ser
 
 const PRICE_CAPABILITIES = new Set(["price-chart", "intraday-price-chart", "price-comparison"]);
 
-function chartRange(options: NormalizedPaneFunctionOptions): ChartSpec["viewport"]["range"] | null {
+function chartRange(options: NormalizedPaneFunctionOptions): TimeRange | null {
   const value = options.rangePreset ?? options.range;
-  return value === "1D" || value === "1W" || value === "1M" || value === "3M"
-    || value === "6M" || value === "1Y" || value === "5Y" || value === "ALL"
-    ? value
+  return typeof value === "string" && (TIME_RANGES as readonly string[]).includes(value)
+    ? value as TimeRange
     : null;
 }
 
-function chartResolution(options: NormalizedPaneFunctionOptions): ChartSpec["viewport"]["resolution"] | null {
+function chartResolution(options: NormalizedPaneFunctionOptions): ChartResolution | null {
   const value = options.chartResolution ?? options.resolution;
-  return value === "auto" || value === "1m" || value === "5m" || value === "15m"
-    || value === "30m" || value === "45m" || value === "1h" || value === "1d"
-    || value === "1wk" || value === "1mo"
-    ? value
+  return typeof value === "string" && (CHART_RESOLUTIONS as readonly string[]).includes(value)
+    ? value as ChartResolution
     : null;
 }
 

package/src/plugins/builtin/chart-composer/pane.tsx

@@ -14,7 +14,10 @@ import { CompositeChart } from "../../../components/chart/composite";
 import type { PaneProps, TickerResearchTabProps } from "../../../types/plugin";
 import type { ChartResolution, TimeRange } from "../../../components/chart/core/types";
 import type { ChartSpec, ResolvedSeries } from "../../../time-series/types";
-import { getSupportedChartResolutionsForViewport } from "../../../time-series/resolution";
+import {
+  getSupportedChartResolutionsForViewport,
+  type ManualChartResolution,
+} from "../../../time-series/resolution";
 import { useResolvedChartSpec } from "../../../time-series/hooks";
 import { chartSeriesSourceKey } from "../../../capabilities";
 import { useShortcut } from "../../../react/input";
@@ -68,6 +71,9 @@ import { isPlainKey } from "../../../utils/keyboard";
 
 const RANGE_TABS = RANGES.map((range, index) => ({ label: `${index + 1}:${range}`, value: range }));
 const AUTO_VIEWPORT_DEBOUNCE_MS = 350;
+/** Bar pitch AUTO aims for; the coarser neighbour wins ties so bars stay readable. */
+const AUTO_RESOLUTION_BAR_PIXELS = 7;
+const MINIMUM_AUTO_RESOLUTION_POINTS = 60;
 
 interface RuntimeChartViewport {
   start: Date;
@@ -137,7 +143,7 @@ function ChartComposerSurface({
   const dialog = useDialog();
   const dispatch = useAppDispatch();
   const isDesktopWeb = useUiHost().kind === "desktop-web";
-  const { publicSharing } = useUiCapabilities();
+  const { publicSharing, cellWidthPx = 8 } = useUiCapabilities();
   const paneId = usePaneInstanceId();
   const liveStreaming = useLiveStreamingSetting();
   const dialogOpen = useDialogState((state) => state.isOpen);
@@ -179,15 +185,24 @@ function ChartComposerSurface({
   const activeRuntimeViewport = runtimeViewportState?.key === authoredViewportKey
     ? runtimeViewportState
     : null;
-  const targetPointCount = Math.max(60, Math.floor(width * 1.25));
+  const targetPointCount = Math.max(
+    MINIMUM_AUTO_RESOLUTION_POINTS,
+    Math.round((width * cellWidthPx) / AUTO_RESOLUTION_BAR_PIXELS),
+  );
+  // The loaded resolution is the tie-breaker for the next AUTO pick, so a
+  // small zoom keeps the bars it already has. Read from the previous render:
+  // the resolver only consults it when the viewport moves.
+  const currentResolutionRef = useRef<ManualChartResolution | null>(null);
   const resolution = useResolvedChartSpec(spec, {
     autoViewport: spec.viewport.resolution === "auto"
       ? activeRuntimeViewport?.adaptiveViewport
       : null,
     requestViewport: activeRuntimeViewport?.requestViewport,
     targetPointCount,
+    currentResolution: currentResolutionRef.current,
     liveStreaming: liveStreaming && (liveWhenUnfocused || focused),
   });
+  currentResolutionRef.current = resolution.resolution ?? currentResolutionRef.current;
   const availableResolutions = useMemo<ChartResolution[]>(() => {
     if (!resolution.resolutionSupport) {
       if (!resolution.loading) return RESOLUTIONS;
@@ -320,9 +335,8 @@ function ChartComposerSurface({
   }, [authoredViewportKey, persistedInteractionViewport, setStoredInteractionViewport]);
   const handleChartViewportChange = useCallback((
     next: { start: Date; end: Date } | null,
-    interaction: "pan" | "reset" | "sync" | "zoom",
+    _interaction: "pan" | "reset" | "zoom",
   ) => {
-    if (interaction === "sync") return;
     if (runtimeViewportTimerRef.current !== null) {
       clearTimeout(runtimeViewportTimerRef.current);
       runtimeViewportTimerRef.current = null;
@@ -339,9 +353,9 @@ function ChartComposerSurface({
     if (!Number.isFinite(start) || !Number.isFinite(end) || start > end) return;
     const viewport = { start: new Date(start), end: new Date(end) };
     requestViewportRef.current = viewport;
-    if (interaction === "zoom" && spec.viewport.resolution === "auto") {
-      adaptiveViewportRef.current = viewport;
-    }
+    // A pan can leave the window a provider serves at the current resolution
+    // just as a zoom can, so both re-pick.
+    if (spec.viewport.resolution === "auto") adaptiveViewportRef.current = viewport;
     runtimeViewportTimerRef.current = globalThis.setTimeout(() => {
       runtimeViewportTimerRef.current = null;
       const requestViewport = requestViewportRef.current;

package/src/plugins/builtin/chart-composer/settings.ts

@@ -1,4 +1,5 @@
 import type { ChartResolution, TimeRange } from "../../../components/chart/core/types";
+import { CHART_RESOLUTIONS, TIME_RANGES as CHART_RANGES } from "../../../time-series/range";
 import type {
   PaneSettingField,
   PaneSettingOption,
@@ -33,19 +34,7 @@ import {
   parseChartSpecOr,
 } from "./chart-spec";
 
-export const CHART_RANGES: TimeRange[] = ["1D", "1W", "1M", "3M", "6M", "1Y", "5Y", "ALL"];
-export const CHART_RESOLUTIONS: ChartResolution[] = [
-  "auto",
-  "1m",
-  "5m",
-  "15m",
-  "30m",
-  "45m",
-  "1h",
-  "1d",
-  "1wk",
-  "1mo",
-];
+export { CHART_RANGES, CHART_RESOLUTIONS };
 
 export const CHART_STUDY_OPTIONS: Array<PaneSettingOption & { value: BuiltinStudySelection }> = [
   { value: "volume", label: "Volume", description: "Volume columns in a lower panel." },

package/src/plugins/builtin/chat/content/composer.tsx

@@ -1,7 +1,7 @@
-import { Box, Text, TextAttributes, type TextareaRenderable } from "../../../../ui";
+import { Box, Text, TextAttributes, useCommandBarShortcut, type TextareaRenderable } from "../../../../ui";
 import { getMessageComposerBlockHeight, MessageComposer } from "../../../../components/ui";
 import { colors } from "../../../../theme/colors";
-import { t } from "../../../../i18n";
+import { t, tf } from "../../../../i18n";
 import { truncateToDisplayWidth } from "../../../../utils/format";
 import type { ChatMessage } from "../../../../api-client";
 import { InlineAuthActions } from "../../cloud/auth-actions";
@@ -130,8 +130,10 @@ export function ChatComposerArea({
   onMentionSelect,
   user,
 }: ChatComposerAreaProps) {
+  const commandBarShortcut = useCommandBarShortcut();
   if (!canSend) {
-    const fitLine = (value: string) => truncateToDisplayWidth(t(value), contentWidth);
+    const fitText = (value: string) => truncateToDisplayWidth(value, contentWidth);
+    const fitLine = (value: string) => fitText(t(value));
     return (
       <Box width={contentWidth} height={2} flexDirection="column">
         {!user && !hasSavedSession ? (
@@ -147,7 +149,9 @@ export function ChatComposerArea({
         ) : (
           <>
             <Text fg={colors.positive}>{fitLine("Verify your email to send messages.")}</Text>
-            <Text fg={colors.textDim}>{fitLine("Ctrl+P, then Resend Verification Email")}</Text>
+            <Text fg={colors.textDim}>
+              {fitText(tf("{shortcut}, then Resend Verification Email", { shortcut: commandBarShortcut }))}
+            </Text>
           </>
         )}
       </Box>

package/src/plugins/builtin/cloud/auth-dialog.tsx

@@ -2,34 +2,16 @@
  * Shared email/password auth dialog plus the request bridge that lets commands
  * (which run outside the React tree) open it. `AuthDialogHost` is mounted by
  * the shell for the life of the app and owns the actual dialog, mirroring the
- * QR sign-in dialog host.
+ * QR sign-in dialog host. The form body itself lives in `auth-form`, which the
+ * hosted terminal's sign-in gate reuses.
  */
-import { useCallback, useState } from "react";
-import { apiClient, type AuthUser } from "../../../api-client";
-import { Button, Spinner, TextField } from "../../../components";
+import { useEffect, useRef, useState } from "react";
+import type { AuthUser } from "../../../api-client";
 import { DialogFrame } from "../../../components/ui/frame";
-import { t, tf } from "../../../i18n";
 import { useAppLanguage } from "../../../i18n/react";
-import { colors } from "../../../theme/colors";
-import { Box, Text, TextAttributes } from "../../../ui";
-import { useDialog, useDialogKeyboard, type PromptContext } from "../../../ui/dialog";
-import { isPlainKey } from "../../../utils/keyboard";
-import { useEffect, useRef } from "react";
-import {
-  advanceAccountField,
-  classifyAccountError,
-  performEmailAuth,
-  validateAccountEmail,
-  validateAccountPassword,
-  type AccountMode,
-  type AccountSubmitError,
-} from "./auth-model";
-
-const FIELD_WIDTH = 42;
-
-type AuthField = "email" | "password";
-
-type ResetState = "idle" | "sending" | "sent";
+import { useDialog, type PromptContext } from "../../../ui/dialog";
+import { AuthForm, authFormTitle } from "./auth-form";
+import type { AccountMode } from "./auth-model";
 
 export function AuthDialog({
   initialMode,
@@ -38,211 +20,15 @@ export function AuthDialog({
 }: PromptContext<AuthUser | undefined> & { initialMode: AccountMode }) {
   useAppLanguage();
   const [mode, setMode] = useState<AccountMode>(initialMode);
-  const [email, setEmail] = useState("");
-  const [password, setPassword] = useState("");
-  const [activeField, setActiveField] = useState<AuthField>("email");
-  const [showPassword, setShowPassword] = useState(false);
-  const [submitting, setSubmitting] = useState(false);
-  const [validationError, setValidationError] = useState<string | null>(null);
-  const [submitError, setSubmitError] = useState<AccountSubmitError | null>(null);
-  const [resetState, setResetState] = useState<ResetState>("idle");
-  const attemptRef = useRef(0);
-
-  const clearErrors = useCallback(() => {
-    setValidationError(null);
-    setSubmitError(null);
-  }, []);
-
-  useEffect(() => () => {
-    // Unmounting abandons any in-flight attempt so a late response can't set state.
-    attemptRef.current += 1;
-  }, []);
-
-  const switchMode = useCallback((nextMode: AccountMode) => {
-    attemptRef.current += 1;
-    setMode(nextMode);
-    setSubmitting(false);
-    setPassword("");
-    setResetState("idle");
-    clearErrors();
-    setActiveField(email.trim() ? "password" : "email");
-  }, [clearErrors, email]);
-
-  const requestReset = useCallback(() => {
-    if (submitting || resetState === "sending") return;
-    const trimmedEmail = email.trim();
-    const emailError = validateAccountEmail(trimmedEmail);
-    if (emailError) {
-      setActiveField("email");
-      setValidationError(emailError);
-      return;
-    }
-    setResetState("sending");
-    clearErrors();
-    void apiClient.requestPasswordReset(trimmedEmail)
-      .then(() => setResetState("sent"))
-      .catch(() => {
-        setResetState("idle");
-        setSubmitError({ message: t("Could not send the reset email."), kind: "retry" });
-      });
-  }, [clearErrors, email, resetState, submitting]);
-
-  const submit = useCallback(() => {
-    if (submitting) return;
-    const trimmedEmail = email.trim();
-    const emailError = validateAccountEmail(trimmedEmail);
-    if (emailError) {
-      setActiveField("email");
-      setValidationError(emailError);
-      return;
-    }
-    const passwordError = validateAccountPassword(password, mode);
-    if (passwordError) {
-      setActiveField("password");
-      setValidationError(passwordError);
-      return;
-    }
-
-    const attemptId = attemptRef.current + 1;
-    attemptRef.current = attemptId;
-    setSubmitting(true);
-    clearErrors();
-    void (async () => {
-      try {
-        const user = await performEmailAuth(mode, trimmedEmail, password);
-        if (attemptRef.current !== attemptId) return;
-        resolve(user);
-      } catch (error) {
-        if (attemptRef.current !== attemptId) return;
-        setSubmitting(false);
-        setSubmitError(classifyAccountError(error, mode));
-      }
-    })();
-  }, [clearErrors, email, mode, password, resolve, submitting]);
-
-  const submitField = useCallback(() => {
-    const advance = advanceAccountField({
-      mode,
-      email: email.trim(),
-      password,
-      fieldIdx: activeField === "email" ? 0 : 1,
-    });
-    if (advance.action === "invalid") {
-      setValidationError(advance.message);
-      return;
-    }
-    if (advance.action === "next-field") {
-      setValidationError(null);
-      setActiveField("password");
-      return;
-    }
-    submit();
-  }, [activeField, email, mode, password, submit]);
-
-  useDialogKeyboard((event) => {
-    if (event.name === "escape") {
-      event.stopPropagation?.();
-      dismiss();
-      return;
-    }
-    const forward = isPlainKey(event, "tab") || (!event.targetEditable && isPlainKey(event, "down", "j"));
-    const backward = !event.targetEditable && isPlainKey(event, "up", "k");
-    if (forward || backward) {
-      event.preventDefault?.();
-      event.stopPropagation?.();
-      setActiveField(forward ? "password" : "email");
-    }
-  }, { allowEditable: true });
-
-  const switchToLogin = submitError?.kind === "switch-to-login";
-  const error = validationError ?? submitError?.message ?? null;
 
   return (
-    <DialogFrame title={mode === "login" ? t("Log in to Gloom Cloud") : t("Create your free Gloom Cloud account")}>
-      <Box flexDirection="column" gap={1}>
-        <TextField
-          label={t("Email")}
-          value={email}
-          placeholder="email@example.com"
-          focused={activeField === "email" && !submitting}
-          width={FIELD_WIDTH}
-          type="email"
-          autoComplete="email"
-          onMouseDown={() => setActiveField("email")}
-          onChange={(value) => {
-            setEmail(value);
-            setResetState("idle");
-            clearErrors();
-          }}
-          onSubmit={submitField}
-        />
-        <Box flexDirection="column">
-          <Box height={1} width={FIELD_WIDTH} flexDirection="row" justifyContent="space-between">
-            <Text
-              fg={activeField === "password" ? colors.textBright : colors.textDim}
-              attributes={activeField === "password" ? TextAttributes.BOLD : 0}
-            >
-              {t("Password")}
-            </Text>
-            <Box onMouseDown={() => setShowPassword((current) => !current)}>
-              <Text fg={colors.textMuted}>{showPassword ? t("hide") : t("show")}</Text>
-            </Box>
-          </Box>
-          <TextField
-            value={password}
-            placeholder={mode === "signup" ? t("At least 8 characters") : t("Your password")}
-            focused={activeField === "password" && !submitting}
-            width={FIELD_WIDTH}
-            type={showPassword ? "text" : "password"}
-            autoComplete={mode === "signup" ? "new-password" : "current-password"}
-            onMouseDown={() => setActiveField("password")}
-            onChange={(value) => {
-              setPassword(value);
-              clearErrors();
-            }}
-            onSubmit={submitField}
-          />
-        </Box>
-        <Box flexDirection="column" minHeight={2} width={FIELD_WIDTH}>
-          {submitting ? (
-            <Spinner label={mode === "signup" ? t("Creating your account...") : t("Signing you in...")} />
-          ) : resetState === "sending" ? (
-            <Spinner label={t("Sending reset link...")} />
-          ) : error ? (
-            <Text fg={colors.negative} wrapText>{error}</Text>
-          ) : resetState === "sent" ? (
-            <Text fg={colors.positive} wrapText>
-              {tf("Reset link sent to {email}. Check your inbox.", { email: email.trim() })}
-            </Text>
-          ) : mode === "signup" ? (
-            <Text fg={colors.textMuted} wrapText>{t("We'll email you a verification link.")}</Text>
-          ) : null}
-        </Box>
-        <Box flexDirection="row" justifyContent="space-between" width={FIELD_WIDTH}>
-          <Button
-            label={switchToLogin || mode === "signup" ? t("Log in instead") : t("Sign up instead")}
-            variant="ghost"
-            disabled={submitting}
-            onPress={() => switchMode(mode === "login" ? "signup" : "login")}
-          />
-          <Button
-            label={mode === "login" ? t("Log In") : t("Create Account")}
-            variant="primary"
-            disabled={submitting}
-            onPress={submit}
-          />
-        </Box>
-        {mode === "login" && (
-          <Box flexDirection="row" width={FIELD_WIDTH}>
-            <Button
-              label={t("Forgot password?")}
-              variant="ghost"
-              disabled={submitting || resetState === "sending"}
-              onPress={requestReset}
-            />
-          </Box>
-        )}
-      </Box>
+    <DialogFrame title={authFormTitle(mode)}>
+      <AuthForm
+        initialMode={initialMode}
+        onModeChange={setMode}
+        onSignedIn={resolve}
+        onEscape={dismiss}
+      />
     </DialogFrame>
   );
 }