gloomberb 0.11.2 → 0.12.0

package/src/app/pane-runtime/index.tsx

@@ -9,6 +9,7 @@ import {
   isPaneInLayout,
 } from "../../plugins/pane-manager";
 import type { PluginRegistry } from "../../plugins/registry";
+import type { LoadedExternalPlugin } from "../../plugins/loader";
 import {
   getFocusedCollectionId,
   resolveTickerForPane,
@@ -19,7 +20,6 @@ import {
 import { scheduleConfigSave } from "../../state/config-save-scheduler";
 import {
   createPaneInstance,
-  findPaneInstance,
   isTickerPaneId,
   normalizePaneId,
   normalizePaneLayout,
@@ -36,6 +36,7 @@ import type {
 import type { DialogApi } from "../../ui/dialog";
 import {
   resolvePanelForPane,
+  resolvePaneShowTarget,
   resolvePaneTarget as resolvePaneTargetInLayout,
   selectEdgeAnchor,
 } from "./layout-placement";
@@ -50,8 +51,10 @@ interface AppPaneRuntimeArgs {
   detachedPaneId: string | null;
   dialog: DialogApi;
   dispatch: Dispatch<AppAction>;
+  externalPlugins: readonly LoadedExternalPlugin[];
   isDetachedWindow: boolean;
   notify: (body: string, options?: { type?: "info" | "success" | "error" }) => void;
+  persistConfig: (nextConfig: AppState["config"]) => void;
   pluginRegistry: PluginRegistry;
   state: AppState;
   stateRef: { current: AppState };
@@ -63,8 +66,10 @@ export function useAppPaneRuntime({
   detachedPaneId,
   dialog,
   dispatch,
+  externalPlugins,
   isDetachedWindow,
   notify,
+  persistConfig,
   pluginRegistry,
   state,
   stateRef,
@@ -204,26 +209,23 @@ export function useAppPaneRuntime({
   ]);
 
   const showPane = useCallback((paneId: string) => {
-    const normalizedPaneId = normalizePaneId(paneId);
-    const paneDef = pluginRegistry.panes.get(normalizedPaneId);
+    const target = resolvePaneShowTarget(state.config.layout, paneId);
+    const paneDef = pluginRegistry.panes.get(target.paneType);
     if (!paneDef) return;
 
-    if (normalizedPaneId === TICKER_RESEARCH_PANE_ID) {
+    if (target.paneType === TICKER_RESEARCH_PANE_ID) {
       showTickerResearchPane();
       return;
     }
 
-    const existingInstanceId = resolvePaneTarget(normalizedPaneId);
-    if (existingInstanceId && isPaneInLayout(state.config.layout, existingInstanceId)) {
-      pluginRegistry.focusPaneFn(existingInstanceId);
+    if (target.instance && isPaneInLayout(state.config.layout, target.instance.instanceId)) {
+      pluginRegistry.focusPaneFn(target.instance.instanceId);
       return;
     }
 
-    const instance = existingInstanceId
-      ? findPaneInstance(state.config.layout, existingInstanceId)
-      : buildPaneInstance(normalizedPaneId);
+    const instance = target.instance ?? buildPaneInstance(target.paneType);
     if (!instance) {
-      if (isTickerPaneId(paneId)) {
+      if (isTickerPaneId(target.paneType)) {
         notify("Open a ticker or collection context first.");
       }
       return;
@@ -234,7 +236,6 @@ export function useAppPaneRuntime({
     notify,
     placePaneInstance,
     pluginRegistry,
-    resolvePaneTarget,
     showTickerResearchPane,
     state.config.layout,
   ]);
@@ -286,10 +287,12 @@ export function useAppPaneRuntime({
     dataProvider,
     detachedPaneId,
     dispatch,
+    externalPlugins,
     focusVisiblePane,
     isDetachedWindow,
     openPaneSettings,
     openPinnedTicker,
+    persistConfig,
     persistLayout,
     placePaneInstance,
     placePinnedTickerTarget,

package/src/app/pane-runtime/layout-placement.test.ts

@@ -0,0 +1,27 @@
+import { describe, expect, test } from "bun:test";
+import type { LayoutConfig } from "../../types/config";
+import { resolvePaneShowTarget } from "./layout-placement";
+
+describe("resolvePaneShowTarget", () => {
+  test("resolves a hidden pane by its exact instance id", () => {
+    const hiddenPane = {
+      instanceId: "news-top:stored",
+      paneId: "news-top",
+      binding: { kind: "none" as const },
+      placementMemory: {
+        floating: { x: 12, y: 4, width: 90, height: 30 },
+      },
+    };
+    const layout: LayoutConfig = {
+      dockRoot: null,
+      instances: [hiddenPane],
+      floating: [],
+      detached: [],
+    };
+
+    expect(resolvePaneShowTarget(layout, hiddenPane.instanceId)).toEqual({
+      paneType: "news-top",
+      instance: hiddenPane,
+    });
+  });
+});

package/src/app/pane-runtime/layout-placement.ts

@@ -28,6 +28,19 @@ export function resolvePaneTarget(layout: LayoutConfig, paneId: string): string
     ?? null;
 }
 
+/** Resolve an instance id before looking up its registered pane type. */
+export function resolvePaneShowTarget(
+  layout: LayoutConfig,
+  paneId: string,
+): { paneType: string; instance: PaneInstanceConfig | null } {
+  const instanceId = resolvePaneTarget(layout, paneId);
+  const instance = instanceId ? findPaneInstance(layout, instanceId) ?? null : null;
+  return {
+    paneType: normalizePaneId(instance?.paneId ?? paneId),
+    instance,
+  };
+}
+
 export function resolvePanelForPane({
   layout,
   paneId,

package/src/app/pane-runtime/plugin-bindings.ts

@@ -5,6 +5,9 @@ import {
 } from "../../components/command-bar/workflow/ops";
 import type { AppTickerRepositoryPort } from "../../core/app-service-ports";
 import { setLayoutManagerDispatch } from "../../plugins/builtin/layout-manager";
+import { setMarketplaceHost } from "../../plugins/builtin/plugin-marketplace/store";
+import type { InstalledPlugin } from "../../plugins/builtin/plugin-marketplace/model";
+import type { LoadedExternalPlugin } from "../../plugins/loader";
 import { materializeMarketplaceLayout } from "../../layout-marketplace/payload";
 import {
   isPaneInLayout,
@@ -46,10 +49,12 @@ interface BindAppPanePluginRegistryOptions {
   dataProvider: DataProvider;
   detachedPaneId: string | null;
   dispatch: Dispatch<AppAction>;
+  externalPlugins: readonly LoadedExternalPlugin[];
   focusVisiblePane: (paneId: string, layout?: LayoutConfig) => void;
   isDetachedWindow: boolean;
   openPaneSettings: (paneId?: string) => Promise<void>;
   openPinnedTicker: (rawSymbol: string, options?: PinTickerOptions) => Promise<void>;
+  persistConfig: (nextConfig: AppState["config"]) => void;
   persistLayout: (layout: LayoutConfig, options?: { pushHistory?: boolean }) => void;
   placePaneInstance: (
     instance: PaneInstanceConfig,
@@ -76,10 +81,12 @@ export function bindAppPanePluginRegistry({
   dataProvider,
   detachedPaneId,
   dispatch,
+  externalPlugins,
   focusVisiblePane,
   isDetachedWindow,
   openPaneSettings,
   openPinnedTicker,
+  persistConfig,
   persistLayout,
   placePaneInstance,
   placePinnedTickerTarget,
@@ -249,4 +256,59 @@ export function bindAppPanePluginRegistry({
     termHeight: pluginRegistry.getTermSizeFn().height,
     focusedPaneId: state.focusedPaneId,
   }));
+
+  setMarketplaceHost({
+    listInstalled: () => {
+      const disabled = new Set(stateRef.current.config.disabledPlugins ?? []);
+      const externalById = new Map(externalPlugins.map((entry) => [entry.plugin.id, entry]));
+      const installed: InstalledPlugin[] = [];
+
+      for (const plugin of pluginRegistry.allPlugins.values()) {
+        const external = externalById.get(plugin.id);
+        externalById.delete(plugin.id);
+        installed.push({
+          id: plugin.id,
+          name: plugin.name,
+          version: plugin.version,
+          ...(plugin.description ? { description: plugin.description } : {}),
+          toggleable: plugin.toggleable === true,
+          enabled: !disabled.has(plugin.id),
+          source: external ? "external" : "builtin",
+        });
+      }
+
+      // Entries that never registered — a broken import, or a plugin this
+      // renderer cannot run. They are invisible everywhere else, which is
+      // exactly why the marketplace has to show them.
+      for (const entry of externalById.values()) {
+        installed.push({
+          id: entry.plugin.id,
+          name: entry.plugin.name,
+          version: entry.plugin.version ?? "0.0.0",
+          ...(entry.plugin.description ? { description: entry.plugin.description } : {}),
+          toggleable: true,
+          enabled: !disabled.has(entry.plugin.id),
+          source: "external",
+          ...(entry.unsupportedTarget ? { unsupportedTarget: entry.unsupportedTarget } : {}),
+          ...(entry.error ? { loadError: entry.error } : {}),
+        });
+      }
+
+      return installed;
+    },
+    setPluginEnabled: (pluginId, enabled) => {
+      const current = stateRef.current.config;
+      if (!enabled) {
+        for (const paneId of pluginRegistry.getPluginPaneIds(pluginId)) pluginRegistry.hidePane(paneId);
+      }
+      dispatch({ type: "TOGGLE_PLUGIN", pluginId });
+      const disabled = current.disabledPlugins ?? [];
+      persistConfig({
+        ...current,
+        disabledPlugins: enabled
+          ? disabled.filter((entry) => entry !== pluginId)
+          : [...disabled, pluginId],
+      });
+    },
+  });
 }

package/src/app.tsx

@@ -17,6 +17,7 @@ import { DetachedPaneShell } from "./components/layout/detached-pane-shell";
 import { TransientLayoutProvider } from "./components/layout/transient-layout";
 import { CommandBar } from "./components/command-bar/surface";
 import { OnboardingWizard } from "./components/onboarding/onboarding-wizard";
+import { SignInGate } from "./components/sign-in-gate";
 import { useDialog } from "./ui/dialog";
 import { PluginRegistry } from "./plugins/registry";
 import type { LoadedExternalPlugin } from "./plugins/loader";
@@ -55,10 +56,12 @@ import { measurePerf } from "./utils/perf-marks";
 import { useAppLanguage } from "./i18n/react";
 import { AppLanguageConfigObserver } from "./app/language-observer";
 import { isPaneShareHandoff } from "./shares/location";
+import { apiClient } from "./api-client";
 
 const EMPTY_EXTERNAL_PLUGINS: LoadedExternalPlugin[] = [];
 
 interface AppInnerProps {
+  externalPlugins: readonly LoadedExternalPlugin[];
   pluginRegistry: PluginRegistry;
   tickerRepository: AppTickerRepositoryPort;
   dataProvider: DataProvider;
@@ -71,6 +74,8 @@ interface AppInnerProps {
   updatesEnabled?: boolean;
   onboardingActive?: boolean;
   onOnboardingComplete?: (config: AppConfig) => void | Promise<void>;
+  /** Hosted browser terminal: nothing is reachable until a session exists. */
+  signInGateActive?: boolean;
 }
 
 function ThemedAppRoot({ children }: { children: ReactNode }) {
@@ -92,6 +97,7 @@ function ThemedAppRoot({ children }: { children: ReactNode }) {
 }
 
 function AppInner({
+  externalPlugins,
   pluginRegistry,
   tickerRepository,
   dataProvider,
@@ -104,6 +110,7 @@ function AppInner({
   updatesEnabled = true,
   onboardingActive = false,
   onOnboardingComplete,
+  signInGateActive = false,
 }: AppInnerProps) {
   const dispatch = useAppDispatch();
   const stateRef = useAppStateRef();
@@ -158,6 +165,13 @@ function AppInner({
     renderToast: (notification) => {
       const type = notification.type ?? "info";
       let toastId: string | number | undefined;
+      const dismissAfter = (run: () => void) => () => {
+        try {
+          run();
+        } finally {
+          if (toastId != null) toast.dismiss(toastId);
+        }
+      };
       const options = {
         title: notification.title,
         subtitle: notification.subtitle,
@@ -165,13 +179,13 @@ function AppInner({
         action: notification.action
           ? {
             label: notification.action.label,
-            onClick: () => {
-              try {
-                notification.action?.onClick();
-              } finally {
-                if (toastId != null) toast.dismiss(toastId);
-              }
-            },
+            onClick: dismissAfter(() => notification.action?.onClick()),
+          }
+          : undefined,
+        secondaryAction: notification.secondaryAction
+          ? {
+            label: notification.secondaryAction.label,
+            onClick: dismissAfter(() => notification.secondaryAction?.onClick()),
           }
           : undefined,
       };
@@ -249,7 +263,10 @@ function AppInner({
     desktopDeepLinkBridge,
     desktopWindowKind: desktopWindowBridge?.kind,
     dispatch,
-    initialized: state.initialized,
+    // The browser bridge re-emits from the URL on subscribe and nothing rewrites
+    // it, so a `?layout=` / `?share=` intent survives the gate and lands once a
+    // session exists. Running it earlier would only 401 behind the scrim.
+    initialized: state.initialized && !signInGateActive,
     pluginRegistry,
     stateRef,
   });
@@ -294,16 +311,23 @@ function AppInner({
     // onboarding finishes, the normal pull-before-push sync starts immediately.
     initialized: state.initialized
       && desktopWindowBridge?.kind !== "detached"
-      && !onboardingActive,
+      && !onboardingActive
+      && !signInGateActive,
   });
 
+  const persistConfig = useCallback((nextConfig: AppState["config"]) => {
+    scheduleConfigSave(nextConfig);
+  }, []);
+
   useAppPaneRuntime({
     dataProvider,
     detachedPaneId,
     dialog,
     dispatch,
+    externalPlugins,
     isDetachedWindow,
     notify,
+    persistConfig,
     pluginRegistry,
     state,
     stateRef,
@@ -376,14 +400,7 @@ function AppInner({
         desktopWindowBridge={desktopWindowBridge}
       >
         <ThemedAppRoot>
-          <Header
-            onOpenHelp={() => pluginRegistry.showPane("help")}
-            onOpenChangelog={(version) => {
-              void pluginRegistry.createPaneFromTemplateAsyncFn("changelog-pane", {
-                values: { version },
-              }).catch(() => {});
-            }}
-          />
+          <Header onOpenHelp={() => pluginRegistry.showPane("help")} />
           <TransientLayoutProvider>
             <Shell
               pluginRegistry={pluginRegistry}
@@ -391,7 +408,13 @@ function AppInner({
               desktopDockPreview={desktopDockPreview}
               commandBarNativeOccluder={commandBarNativeOccluder}
             />
-            <StatusBar />
+            <StatusBar
+              onOpenChangelog={(version) => {
+                void pluginRegistry.createPaneFromTemplateAsyncFn("changelog-pane", {
+                  values: { version },
+                }).catch(() => {});
+              }}
+            />
           </TransientLayoutProvider>
           {onboardingActive && onOnboardingComplete ? (
             <OnboardingWizard
@@ -400,6 +423,7 @@ function AppInner({
               onComplete={onOnboardingComplete}
             />
           ) : null}
+          {signInGateActive ? <SignInGate /> : null}
           {state.commandBarOpen && (
             <CommandBar
               dataProvider={dataProvider}
@@ -430,6 +454,11 @@ interface AppProps {
   desktopThemePreview?: DesktopThemePreviewState | null;
   remoteControlAdapter?: RemoteControlAdapter;
   updatesEnabled?: boolean;
+  /**
+   * Requires a Gloom Cloud session before the app is usable. The hosted browser
+   * terminal sets this; desktop and the TUI keep sign-in optional.
+   */
+  requireSignIn?: boolean;
 }
 
 export function App({
@@ -445,6 +474,7 @@ export function App({
   desktopThemePreview = null,
   remoteControlAdapter,
   updatesEnabled = true,
+  requireSignIn = false,
 }: AppProps) {
   useAppLanguage();
   const externalPlugins = providedExternalPlugins ?? EMPTY_EXTERNAL_PLUGINS;
@@ -469,6 +499,16 @@ export function App({
   const [config, setConfig] = useState(() => {
     return initialCliLaunch.config;
   });
+  // Only the surfaces that require a session subscribe, so desktop and the
+  // terminal keep their current render profile.
+  const [signedIn, setSignedIn] = useState(() => !requireSignIn || apiClient.isSignedIn());
+  useEffect(() => {
+    if (!requireSignIn) return;
+    const sync = () => setSignedIn(apiClient.isSignedIn());
+    sync();
+    return apiClient.subscribeCurrentUser(sync);
+  }, [requireSignIn]);
+  const signInGateActive = requireSignIn && !signedIn;
   const shareHandoff = isPaneShareHandoff();
   const [showOnboarding, setShowOnboarding] = useState(() => (
     desktopWindowBridge?.kind !== "detached"
@@ -518,6 +558,7 @@ export function App({
       >
         <AppLanguageConfigObserver />
         <AppInner
+          externalPlugins={externalPlugins}
           pluginRegistry={services.pluginRegistry}
           tickerRepository={services.tickerRepository}
           dataProvider={services.dataProvider}
@@ -529,6 +570,7 @@ export function App({
           remoteControlAdapter={remoteControlAdapter}
           updatesEnabled={updatesEnabled}
           onboardingActive={showOnboarding}
+          signInGateActive={signInGateActive}
           onOnboardingComplete={(updatedConfig) => {
             setConfig(updatedConfig);
             setShowOnboarding(false);

package/src/architecture/browser-entry-graph.test.ts

@@ -0,0 +1,96 @@
+import { describe, expect, test } from "bun:test";
+import { existsSync } from "fs";
+import { dirname, join, relative, resolve } from "path";
+
+const SOURCE_ROOT = process.cwd();
+const IMPORT_PATTERN = /\b(?:import|export)\s+(?:[^'"]*?\s+from\s+)?["']([^"']+)["']|import\(["']([^"']+)["']\)/g;
+const TYPE_ONLY_PATTERN = /\b(?:import|export)\s+type\s/;
+
+/**
+ * Entry points that run in a browser context: the Electrobun desktop view and
+ * the hosted web app. Neither has `process`, a filesystem, or a Bun runtime.
+ */
+const BROWSER_ENTRIES = [
+  "src/renderers/electrobun/view/main.tsx",
+  "src/renderers/browser/main.tsx",
+];
+
+/**
+ * Modules that only work under Bun. Each reads the filesystem or the process
+ * environment at module scope, so merely importing one from a browser bundle
+ * throws on load — the bundle still builds, which is exactly what makes this
+ * worth a test.
+ *
+ * `plugins/loader` reaching the desktop view through `plugins/bundle` shipped a
+ * broken desktop build: the view crashed with "Can't find variable: process"
+ * before rendering anything, while `desktop:view:build` reported success.
+ */
+const BUN_ONLY_MODULES = [
+  "src/plugins/loader.ts",
+  "src/plugins/bundle.ts",
+  "src/plugins/seed.ts",
+  "src/plugins/host-link.ts",
+  "src/cli/restore-plugins.ts",
+];
+
+const EXTENSIONS = [".ts", ".tsx", ".js", ".jsx"];
+
+function resolveSpecifier(fromFile: string, specifier: string): string | null {
+  if (!specifier.startsWith(".")) return null;
+  const base = resolve(dirname(fromFile), specifier);
+  for (const candidate of [base, ...EXTENSIONS.map((ext) => `${base}${ext}`), ...EXTENSIONS.map((ext) => join(base, `index${ext}`))]) {
+    if (existsSync(candidate) && !candidate.endsWith("/")) {
+      try {
+        if (Bun.file(candidate).size >= 0 && !candidate.match(/\/$/)) return candidate;
+      } catch {
+        // Directory or unreadable entry: keep trying the other candidates.
+      }
+    }
+  }
+  return null;
+}
+
+/** Walks runtime imports only; `import type` is erased and cannot pull code in. */
+async function reachableFrom(entry: string): Promise<Map<string, string[]>> {
+  const seen = new Map<string, string[]>();
+  const queue: Array<{ file: string; path: string[] }> = [{ file: resolve(SOURCE_ROOT, entry), path: [entry] }];
+
+  while (queue.length > 0) {
+    const current = queue.shift()!;
+    const key = relative(SOURCE_ROOT, current.file);
+    if (seen.has(key)) continue;
+    seen.set(key, current.path);
+
+    let source: string;
+    try {
+      source = await Bun.file(current.file).text();
+    } catch {
+      continue;
+    }
+
+    for (const line of source.split("\n")) {
+      if (TYPE_ONLY_PATTERN.test(line)) continue;
+      for (const match of line.matchAll(IMPORT_PATTERN)) {
+        const specifier = match[1] ?? match[2] ?? "";
+        const resolved = resolveSpecifier(current.file, specifier);
+        if (resolved) queue.push({ file: resolved, path: [...current.path, relative(SOURCE_ROOT, resolved)] });
+      }
+    }
+  }
+
+  return seen;
+}
+
+describe("browser entry import graph", () => {
+  for (const entry of BROWSER_ENTRIES) {
+    test(`${entry} does not reach a Bun-only module`, async () => {
+      const reachable = await reachableFrom(entry);
+
+      const violations = BUN_ONLY_MODULES
+        .filter((module) => reachable.has(module))
+        .map((module) => `${module} via ${reachable.get(module)!.slice(-3).join(" -> ")}`);
+
+      expect(violations).toEqual([]);
+    });
+  }
+});

package/src/brokers/profile-form.test.ts

@@ -1,62 +1,60 @@
 import { describe, expect, test } from "bun:test";
 import type { BrokerAdapter } from "../types/broker";
 import type { BrokerInstanceConfig } from "../types/config";
-import { ibkrBroker } from "../plugins/ibkr/broker-adapter";
+import { testBroker } from "./test-broker";
 import {
   buildBrokerProfileConfig,
   createBrokerProfileDraft,
   validateBrokerProfileValues,
 } from "./profile-form";
 
-function createFlexInstance(): BrokerInstanceConfig {
+function createSavedInstance(): BrokerInstanceConfig {
   return {
-    id: "ibkr-flex",
-    brokerType: "ibkr",
-    label: "IBKR Flex",
-    connectionMode: "flex",
+    id: "saved-profile",
+    brokerType: "test-broker",
+    label: "Saved Profile",
+    connectionMode: "token",
     config: {
-      connectionMode: "flex",
-      gatewaySetupMode: "auto",
-      flex: { token: "saved-token", queryId: "123", endpoint: "https://example.test/flex" },
-      gateway: { host: "127.0.0.1", marketDataType: "auto" },
+      connectionMode: "token",
+      credentials: { token: "saved-token", accountId: "123" },
+      host: "127.0.0.1",
     },
     enabled: true,
   };
 }
 
 describe("broker profile form helpers", () => {
-  test("builds canonical IBKR Flex config from flat values", () => {
-    const config = buildBrokerProfileConfig(ibkrBroker, {
-      connectionMode: "flex",
+  test("builds a nested broker config from flat form values", () => {
+    const config = buildBrokerProfileConfig(testBroker, {
+      connectionMode: "token",
       token: "token",
-      queryId: "456",
-      endpoint: "",
-      gatewaySetupMode: "auto",
+      accountId: "456",
+      host: "",
     });
 
     expect(config).toMatchObject({
-      connectionMode: "flex",
-      flex: { token: "token", queryId: "456" },
+      connectionMode: "token",
+      credentials: { token: "token", accountId: "456" },
     });
   });
 
   test("preserves saved password fields when editing leaves them blank", () => {
-    const previous = createFlexInstance();
-    const draft = createBrokerProfileDraft(ibkrBroker, previous);
+    const previous = createSavedInstance();
+    const draft = createBrokerProfileDraft(testBroker, previous);
     draft.values.token = "";
 
-    expect(validateBrokerProfileValues(ibkrBroker, draft.values, previous)).toBeNull();
-    expect(buildBrokerProfileConfig(ibkrBroker, draft.values, previous)).toMatchObject({
-      flex: { token: "saved-token" },
+    expect(validateBrokerProfileValues(testBroker, draft.values, previous)).toBeNull();
+    expect(buildBrokerProfileConfig(testBroker, draft.values, previous)).toMatchObject({
+      credentials: { token: "saved-token" },
     });
   });
 
   test("requires password fields for new profiles", () => {
-    expect(validateBrokerProfileValues(ibkrBroker, {
-      connectionMode: "flex",
+    expect(validateBrokerProfileValues(testBroker, {
+      connectionMode: "token",
       token: "",
-      queryId: "123",
-    })).toBe("Flex Token is required.");
+      accountId: "123",
+    })).toBe("API Token is required.");
   });
 
   test("falls back to raw values for generic brokers", () => {