gloomberb 0.11.2 → 0.12.0

package/src/components/command-bar/routes/ticker-search/actions.ts

@@ -12,6 +12,7 @@ import type { ResultItem } from "../../list/model";
 import {
   buildTickerSearchCacheKey,
   createQuickLookTickerCandidates,
+  formatInstrumentBadge,
 } from "./results";
 
 interface UseCommandBarTickerSearchActionsOptions {
@@ -47,13 +48,20 @@ export function useCommandBarTickerSearchActions({
 
   const mapTickerSearchCandidateToResultItem = useCallback((candidate: TickerSearchCandidate): ResultItem => {
     const detail = formatTickerSearchDetail(candidate);
-    const right = formatTickerSearchRight(candidate);
+    // The class lives in the badge, so the trailing text carries only the
+    // venue rather than saying "Equity" twice on one row. An unclassified
+    // instrument has no class to show, so the badge column lifts its venue
+    // instead (a short exchange code qualifies on its own) and the trailing
+    // text goes quiet rather than repeating it.
+    const badge = formatInstrumentBadge(candidate);
+    const right = candidate.exchangeLabel || candidate.primaryExchangeLabel || candidate.right || undefined;
 
     if (candidate.kind === "ticker" && candidate.ticker) {
       return {
         id: candidate.id,
         label: candidate.label,
         detail,
+        badge,
         right,
         category: candidate.category,
         kind: "ticker",
@@ -72,6 +80,7 @@ export function useCommandBarTickerSearchActions({
       id: candidate.id,
       label: candidate.label,
       detail,
+      badge,
       right,
       category: candidate.category,
       kind: "search",
@@ -145,14 +154,6 @@ export function useCommandBarTickerSearchActions({
   };
 }
 
-function formatTickerSearchRight(candidate: TickerSearchCandidate): string | undefined {
-  const assetClass = formatInstrumentClass(candidate.instrumentClass);
-  const exchange = candidate.exchangeLabel || candidate.primaryExchangeLabel || candidate.right || "";
-  if (!exchange) return assetClass;
-  if (assetClass === "Other") return exchange;
-  return `${assetClass} ${exchange}`;
-}
-
 function formatTickerSearchDetail(candidate: TickerSearchCandidate): string {
   const metadata = [
     formatInstrumentClass(candidate.instrumentClass),

package/src/components/command-bar/routes/ticker-search/results.test.ts

@@ -1,6 +1,6 @@
 import { expect, test } from "bun:test";
 import type { ResultItem } from "../../list/model";
-import { mergeTickerSearchResultItems } from "./results";
+import { formatInstrumentBadge, mergePlainRootTickerResults, mergeTickerSearchResultItems } from "./results";
 
 function resultItem(id: string, label: string, right: string, kind: ResultItem["kind"] = "ticker"): ResultItem {
   return {
@@ -32,3 +32,56 @@ test("keeps completed ticker-search results authoritative over provisional rows"
   const noResults = resultItem("no-results", "No matches for Apple", "", "info");
   expect(mergeTickerSearchResultItems("Apple", [noResults], [])).toEqual([noResults]);
 });
+
+test("folds a plain query's symbol hits into one capped Instruments section behind the local rows", () => {
+  const pane: ResultItem = {
+    id: "pane:news",
+    label: "News",
+    detail: "",
+    category: "Panes",
+    kind: "action",
+    action: () => {},
+  };
+  const providerItems = [
+    resultItem("search:NVDA", "NVDA", "Equity NASDAQ", "search"),
+    // The saved row for the same symbol carries a different badge; one row per symbol.
+    resultItem("goto:NVDA", "NVDA", "NASDAQ"),
+    resultItem("search:NVDA.MX", "NVDA.MX", "Equity BMV", "search"),
+    resultItem("search:NVD.DE", "NVD.DE", "Equity XETRA", "search"),
+    resultItem("search:NVDL", "NVDL", "Fund NASDAQ", "search"),
+    resultItem("search:NVDS", "NVDS", "Fund NASDAQ", "search"),
+    resultItem("search:NVDX", "NVDX", "Fund NASDAQ", "search"),
+    resultItem("search-error", "Search failed", "", "info"),
+  ];
+
+  const merged = mergePlainRootTickerResults("nvda", providerItems, [pane]);
+
+  expect(merged.map((item) => [item.id, item.category])).toEqual([
+    ["search:NVDA", "Exact Match"],
+    ["pane:news", "Panes"],
+    ["search:NVDA.MX", "Instruments"],
+    ["search:NVD.DE", "Instruments"],
+    ["search:NVDL", "Instruments"],
+    ["search:NVDS", "Instruments"],
+  ]);
+  expect(merged.find((item) => item.id === "search:NVDA.MX")?.right).toBe("Equity BMV");
+});
+
+/**
+ * The class tag is what the eye sorts instruments by, so the mapping from a
+ * provider's type strings has to stay put: an exchange-traded fund is not a
+ * mutual fund, and an unclassified instrument gets no tag rather than a stand-in.
+ */
+test("names the instrument class for the badge column", () => {
+  const search = (type: string) => ({ providerId: "yahoo", symbol: "X", name: "X", exchange: "NYQ", type });
+  expect(formatInstrumentBadge({ instrumentClass: "equity" })).toBe("EQ");
+  expect(formatInstrumentBadge({ instrumentClass: "fund", result: search("ETF") })).toBe("ETF");
+  expect(formatInstrumentBadge({ instrumentClass: "fund", result: search("ETN") })).toBe("ETF");
+  expect(formatInstrumentBadge({ instrumentClass: "fund", result: search("MUTUALFUND") })).toBe("FUND");
+  expect(formatInstrumentBadge({
+    instrumentClass: "fund",
+    ticker: { metadata: { ticker: "VTI", assetCategory: "ETF" } } as never,
+  })).toBe("ETF");
+  expect(formatInstrumentBadge({ instrumentClass: "derivative" })).toBe("DERIV");
+  expect(formatInstrumentBadge({ instrumentClass: "other", result: search("INDEX") })).toBeUndefined();
+});

package/src/components/command-bar/routes/ticker-search/results.ts

@@ -19,6 +19,33 @@ export function createQuickLookTickerCandidates(tickers: Iterable<TickerRecord>)
   return createLocalTickerSearchCandidates(tickers, new Map(), QUICK_LOOK_TICKER_SEARCH_OPTIONS);
 }
 
+/** Provider type or saved asset category, whichever classified the candidate. */
+function rawInstrumentType(candidate: Pick<TickerSearchCandidate, "result" | "ticker">): string {
+  return candidate.result?.brokerContract?.secType
+    || candidate.result?.type
+    || candidate.ticker?.metadata.assetCategory
+    || "";
+}
+
+/**
+ * Class tag for the badge column. An unclassified instrument gets none: the
+ * row lifts its exchange code there instead when the code is short enough.
+ */
+export function formatInstrumentBadge(
+  candidate: Pick<TickerSearchCandidate, "instrumentClass" | "result" | "ticker">,
+): string | undefined {
+  switch (candidate.instrumentClass) {
+    case "equity":
+      return "EQ";
+    case "fund":
+      return /\bET[FNP]\b/i.test(rawInstrumentType(candidate)) ? "ETF" : "FUND";
+    case "derivative":
+      return "DERIV";
+    case "other":
+      return undefined;
+  }
+}
+
 export function normalizeCommandTickerSearchText(value: string): string {
   return value.trim().toUpperCase().replace(/[^A-Z0-9]+/g, "");
 }
@@ -53,29 +80,43 @@ export function mergeTickerSearchResultItems(
       : item);
 }
 
+export const ROOT_INSTRUMENTS_CATEGORY = "Instruments";
+
+/** Enough to surface the listing the user means without burying the sections below. */
+const ROOT_INSTRUMENTS_LIMIT = 5;
+
+function isInstrumentItem(item: ResultItem): boolean {
+  return item.kind === "ticker" || item.kind === "search";
+}
+
+/**
+ * Fold symbol-search rows into a plain root query's list. An exact symbol hit
+ * is promoted ahead of everything; the rest collapse into one Instruments
+ * section with one row per symbol, since the listing split of the DES route
+ * is noise next to panes and commands. Info rows ("no matches", "search
+ * failed") are dropped: the instruments are an extra here, never the answer.
+ */
 export function mergePlainRootTickerResults(
   query: string,
   providerItems: ResultItem[],
   rootItems: ResultItem[],
 ): ResultItem[] {
-  const merged: ResultItem[] = [];
-  const seen = new Set<string>();
-  const addItem = (item: ResultItem, options?: { skipInfo?: boolean }) => {
-    if (options?.skipInfo && item.kind === "info") return;
-    const key = (item.kind === "ticker" || item.kind === "search")
-      ? `${item.kind}:${item.label.trim().toUpperCase()}:${(item.right || "").trim().toUpperCase()}`
-      : `${item.kind}:${item.id}`;
-    if (seen.has(key)) return;
-    seen.add(key);
-    merged.push(item);
-  };
+  const seenSymbols = new Set<string>();
+  const instruments: ResultItem[] = [];
+  for (const item of providerItems) {
+    if (!isInstrumentItem(item)) continue;
+    const symbol = item.label.trim().toUpperCase();
+    if (seenSymbols.has(symbol)) continue;
+    seenSymbols.add(symbol);
+    instruments.push(item);
+    if (instruments.length >= ROOT_INSTRUMENTS_LIMIT) break;
+  }
+  if (instruments.length === 0) return rootItems;
 
-  providerItems
-    .filter((item) => item.category === "Exact Match" || isExactTickerResultMatch(item, query))
-    .forEach((item) => addItem(item, { skipInfo: true }));
-  rootItems.forEach((item) => addItem(item));
-  providerItems
-    .filter((item) => item.category !== "Exact Match" && !isExactTickerResultMatch(item, query))
-    .forEach((item) => addItem(item, { skipInfo: true }));
-  return merged.length > 0 ? merged : rootItems;
+  const isExact = (item: ResultItem) => item.category === "Exact Match" || isExactTickerResultMatch(item, query);
+  return [
+    ...instruments.filter(isExact).map((item) => ({ ...item, category: "Exact Match" })),
+    ...rootItems,
+    ...instruments.filter((item) => !isExact(item)).map((item) => ({ ...item, category: ROOT_INSTRUMENTS_CATEGORY })),
+  ];
 }

package/src/components/command-bar/routes/ticker-search/route.ts

@@ -95,6 +95,7 @@ export function useTickerSearchRouteResults(options: {
           dataProvider,
           searchContext: {
             preferBroker: true,
+            interactive: true,
             brokerId: brokerId ?? undefined,
             brokerInstanceId: brokerInstanceId ?? undefined,
           },

package/src/components/command-bar/routing/actions.ts

@@ -26,7 +26,7 @@ import type {
 type CloseAll = (options?: { revertThemePreview?: boolean }) => void;
 type Notify = (body: string, options?: { type?: "info" | "success" | "error" }) => void;
 type OpenModeRoute = (
-  screen: "ticker-search" | "plugins" | "layout",
+  screen: "ticker-search" | "layout",
   initialQuery?: string,
   payload?: Record<string, unknown>,
 ) => void;
@@ -80,15 +80,6 @@ export function useCommandBarRouteActions({
   stateRef,
   updateTopRoute,
 }: UseCommandBarRouteActionsOptions) {
-  const buildPluginItems = useCallback((query: string): ResultItem[] => buildPluginToggleItems({
-    disabledPlugins: state.config.disabledPlugins || [],
-    dispatch,
-    getConfig: () => stateRef.current.config,
-    persistConfig,
-    pluginRegistry,
-    query,
-  }), [dispatch, persistConfig, pluginRegistry, state.config.disabledPlugins, stateRef]);
-
   const buildWindowModeItems = useCallback((arg: string): ResultItem[] => buildWindowModeResultItems({
     arg,
     closeAll,
@@ -235,7 +226,6 @@ export function useCommandBarRouteActions({
     activatePaneSettingField,
     buildLayoutItems,
     buildPaneSettingItems,
-    buildPluginItems,
     buildWindowModeItems,
     executeCollectionCommand,
     openPaneSettingsRoute,
@@ -243,73 +233,3 @@ export function useCommandBarRouteActions({
   };
 }
 
-function buildPluginToggleItems({
-  disabledPlugins,
-  dispatch,
-  getConfig,
-  persistConfig,
-  pluginRegistry,
-  query,
-}: {
-  disabledPlugins: readonly string[];
-  dispatch: Dispatch<AppAction>;
-  getConfig: () => AppState["config"];
-  persistConfig: (nextConfig: AppState["config"]) => void;
-  pluginRegistry: PluginRegistry;
-  query: string;
-}): ResultItem[] {
-  const normalizedQuery = query.trim().toLowerCase();
-  const pluginQuery = normalizedQuery === "plugin" || normalizedQuery === "plugins"
-    ? ""
-    : normalizedQuery;
-  const toggleable = [...pluginRegistry.allPlugins.values()].filter((plugin) => plugin.toggleable);
-  const filtered = pluginQuery
-    ? toggleable.filter((plugin) => (
-      [
-        plugin.name,
-        plugin.id,
-        plugin.description,
-        ...pluginRegistry.getPluginPaneIds(plugin.id).flatMap((paneId) => [
-          paneId,
-          pluginRegistry.panes.get(paneId)?.name,
-        ]),
-        ...pluginRegistry.getPluginPaneTemplateIds(plugin.id).flatMap((templateId) => {
-          const template = pluginRegistry.paneTemplates.get(templateId);
-          return [
-            templateId,
-            template?.label,
-            template?.description,
-            ...(template?.keywords ?? []),
-          ];
-        }),
-      ].some((term) => typeof term === "string" && term.toLowerCase().includes(pluginQuery))
-    ))
-    : toggleable;
-
-  return filtered.map((plugin): ResultItem => {
-    const enabled = !disabledPlugins.includes(plugin.id);
-    const toggleAction = () => {
-      dispatch({ type: "TOGGLE_PLUGIN", pluginId: plugin.id });
-      const currentConfig = getConfig();
-      const nextDisabled = enabled
-        ? [...disabledPlugins, plugin.id]
-        : disabledPlugins.filter((entry) => entry !== plugin.id);
-      if (enabled) {
-        for (const paneId of pluginRegistry.getPluginPaneIds(plugin.id)) {
-          pluginRegistry.hidePane(paneId);
-        }
-      }
-      persistConfig({ ...currentConfig, disabledPlugins: nextDisabled });
-    };
-    return {
-      id: `plugin:${plugin.id}`,
-      label: plugin.name,
-      detail: plugin.description || "",
-      category: "Plugins",
-      kind: "plugin",
-      checked: enabled,
-      pluginToggle: toggleAction,
-      action: toggleAction,
-    };
-  });
-}

package/src/components/command-bar/routing/launch-request.ts

@@ -8,7 +8,7 @@ interface UseCommandBarLaunchRequestOptions {
   commandBarLaunchRequest: AppState["commandBarLaunchRequest"];
   commandBarOpen: boolean;
   openModeRoute: (
-    screen: "ticker-search" | "plugins" | "layout",
+    screen: "ticker-search" | "layout",
     initialQuery?: string,
     payload?: Record<string, unknown>,
   ) => void;

package/src/components/command-bar/routing/list-state.ts

@@ -2,6 +2,7 @@ import { useMemo } from "react";
 import type { PluginRegistry } from "../../../plugins/registry";
 import {
   getEmptyState,
+  type CommandBarCategoryPriorities,
   type CommandBarMode,
   type CommandBarSectionOrder,
 } from "../view-model";
@@ -33,13 +34,13 @@ interface BuildRouteListStateOptions {
     query: string,
     options?: { keepRouteOpen?: boolean },
   ) => ResultItem[];
-  buildPluginItems: (query: string) => ResultItem[];
   currentRoute: CommandBarRoute | null;
   orderedRootResults: ResultItem[];
   pluginRegistry: Pick<PluginRegistry, "resolvePaneSettings">;
   rootHoveredIdx: number | null;
   rootModeKind: CommandBarMode;
   rootQuery: string;
+  rootCategoryPriorities?: CommandBarCategoryPriorities;
   rootSearching: boolean;
   rootSectionOrder: CommandBarSectionOrder;
   rootSelectedIdx: number;
@@ -53,12 +54,12 @@ function buildRouteListState(options: BuildRouteListStateOptions): ListScreenSta
     adaptTickerSearchRouteResult,
     buildLayoutItems,
     buildPaneSettingItems,
-    buildPluginItems,
     currentRoute,
     orderedRootResults,
     pluginRegistry,
     rootHoveredIdx,
     rootModeKind,
+    rootCategoryPriorities,
     rootQuery,
     rootSearching,
     rootSectionOrder,
@@ -86,28 +87,12 @@ function buildRouteListState(options: BuildRouteListStateOptions): ListScreenSta
       footerLeft: getScreenFooterLeft(null),
       footerRight: getScreenFooterRight(null),
       sectionOrder: rootSectionOrder,
+      categoryPriorities: rootCategoryPriorities,
     };
   }
 
   if (currentRoute.kind === "mode") {
     switch (currentRoute.screen) {
-      case "plugins": {
-        const results = buildPluginItems(currentRoute.query);
-        return {
-          kind: "mode",
-          title: "Manage Plugins",
-          subtitle: "Toggle optional plugins without leaving the command bar.",
-          query: currentRoute.query,
-          selectedIdx: currentRoute.selectedIdx,
-          hoveredIdx: currentRoute.hoveredIdx,
-          results: orderListResults(results),
-          searching: false,
-          emptyLabel: getEmptyState("plugins", currentRoute.query).label,
-          emptyDetail: getEmptyState("plugins", currentRoute.query).detail,
-          footerLeft: getScreenFooterLeft(currentRoute),
-          footerRight: getScreenFooterRight(currentRoute),
-        };
-      }
       case "layout": {
         const results = buildLayoutItems(currentRoute.query);
         return {
@@ -207,10 +192,10 @@ export function useRouteListState(options: BuildRouteListStateOptions): ListScre
     adaptTickerSearchRouteResult,
     buildLayoutItems,
     buildPaneSettingItems,
-    buildPluginItems,
     currentRoute,
     orderedRootResults,
     pluginRegistry,
+    rootCategoryPriorities,
     rootHoveredIdx,
     rootModeKind,
     rootQuery,
@@ -226,10 +211,10 @@ export function useRouteListState(options: BuildRouteListStateOptions): ListScre
     adaptTickerSearchRouteResult,
     buildLayoutItems,
     buildPaneSettingItems,
-    buildPluginItems,
     currentRoute,
     orderedRootResults,
     pluginRegistry,
+    rootCategoryPriorities,
     rootHoveredIdx,
     rootModeKind,
     rootQuery,

package/src/components/command-bar/selection-runtime.ts

@@ -28,7 +28,7 @@ import type { OpenInlineConfirm } from "./routing/confirm";
 import { activatePickerSelectionAction } from "./picker-activation";
 
 type OpenModeRouteFn = (
-  screen: "ticker-search" | "plugins" | "layout",
+  screen: "ticker-search" | "layout",
   initialQuery?: string,
   payload?: Record<string, unknown>,
 ) => void;

package/src/components/command-bar/surface/assist.test.tsx

@@ -120,7 +120,8 @@ describe("CommandBar AI assist", () => {
         query="new chat pane"
         configurePluginRegistry={configureEarningsRegistry(created)}
       />,
-      { width: 100, height: 20 },
+      // Wide enough for the answer's label and its title to share one row.
+      { width: 120, height: 20 },
     );
 
     await testSetup.renderOnce();
@@ -131,12 +132,14 @@ describe("CommandBar AI assist", () => {
     expect(sentCommandCount).toBeGreaterThan(0);
 
     releaseResponse();
-    const answered = await waitForFrameToContain("CHAT #general — Open the general channel", ASSIST_WAIT_ATTEMPTS);
+    const answered = await waitForFrameToContain("#general · Open the general channel", ASSIST_WAIT_ATTEMPTS);
     expect(answered).not.toContain("Thinking…");
     expect(requests).toHaveLength(1);
-    // Above the local matches, and holding the selection an untouched query
-    // never moved: plain Enter runs the AI's best guess.
+    // Above the local matches, laid out like any other row with the prefix in
+    // the badge column, and holding the selection an untouched query never
+    // moved: plain Enter runs the AI's best guess.
     expect(answered.indexOf("Ask AI")).toBeLessThan(answered.indexOf("Panes"));
+    expect(answered).toMatch(/CHAT\s+#general · Open the general channel/);
 
     await emitKeypress(testSetup, { name: "return", sequence: "\r" });
     expect(created).toEqual([{ templateId: "new-chat-pane", options: { arg: "#general" } }]);
@@ -162,7 +165,8 @@ describe("CommandBar AI assist", () => {
         query="new chat pane"
         configurePluginRegistry={configureEarningsRegistry(created)}
       />,
-      { width: 100, height: 20 },
+      // Wide enough for the answers' labels and titles to share one row.
+      { width: 120, height: 20 },
     );
 
     await testSetup.renderOnce();
@@ -170,9 +174,9 @@ describe("CommandBar AI assist", () => {
     // Down lands on the local match while a single "Thinking…" row sits above.
     await emitKeypress(testSetup, { name: "down" });
     releaseResponse();
-    await waitForFrameToContain("CHAT #random — Open the random channel", ASSIST_WAIT_ATTEMPTS);
+    await waitForFrameToContain("#random · Open the random channel", ASSIST_WAIT_ATTEMPTS);
 
-    // Two answers replaced that one row, so the chosen row moved down by one —
+    // Two answers replaced that one row, so the chosen row moved down by one;
     // Enter still runs it rather than whatever now sits at its old index.
     await emitKeypress(testSetup, { name: "return", sequence: "\r" });
     expect(created).toEqual([{ templateId: "new-chat-pane", options: undefined }]);
@@ -196,7 +200,7 @@ describe("CommandBar AI assist", () => {
     );
 
     await testSetup.renderOnce();
-    await waitForFrameToContain("ERN NVDA — Earnings Calendar for NVDA", ASSIST_WAIT_ATTEMPTS);
+    await waitForFrameToContain("NVDA · Earnings Calendar", ASSIST_WAIT_ATTEMPTS);
 
     await emitKeypress(testSetup, { name: "return", sequence: "\r" });
     expect(created).toEqual([{ templateId: "earnings-calendar-pane", options: undefined }]);
@@ -275,8 +279,8 @@ describe("CommandBar AI assist", () => {
     await testSetup.renderOnce();
     expect(requests).toEqual([]);
 
-    // The offer leads the list but never takes the Enter that belongs to the
-    // local match the user was already looking at.
+    // The offer sits under the list and never takes the Enter that belongs to
+    // the local match the user was already looking at.
     await emitKeypress(testSetup, { name: "return", sequence: "\r" });
     expect(created).toEqual([{ templateId: "new-chat-pane", options: undefined }]);
   });

package/src/components/command-bar/surface/environment.ts

@@ -82,7 +82,13 @@ export function useCommandBarEnvironment() {
   }, []);
   const { symbol: activeTickerSymbol, ticker: activeTickerData, financials: activeFinancials } = useFocusedTicker();
   const { width: termWidth, height: termHeight } = useViewport();
-  const { nativePaneChrome: nativePaneChromeCapability, cellWidthPx = 8, cellHeightPx = 18, titleBarOverlay } = useUiCapabilities();
+  const {
+    nativePaneChrome: nativePaneChromeCapability,
+    cellWidthPx = 8,
+    cellHeightPx = 18,
+    nativeWindowChrome,
+    titleBarOverlay,
+  } = useUiCapabilities();
   const nativePaneChrome = nativePaneChromeCapability === true;
   const availableCommands = useMemo(
     () => nativePaneChrome
@@ -111,6 +117,7 @@ export function useCommandBarEnvironment() {
     getCommittedThemeId,
     nativeListScrollRef,
     nativePaneChrome,
+    nativeWindowChrome,
     persistConfig,
     skipTickerSearchDebounceRef,
     state,