eslint 8.57.1 → 9.39.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +165 -115
- package/bin/eslint.js +112 -89
- package/conf/default-cli-options.js +22 -22
- package/conf/ecma-version.js +16 -0
- package/conf/globals.js +109 -94
- package/conf/replacements.json +24 -20
- package/conf/rule-type-list.json +89 -26
- package/lib/api.js +16 -20
- package/lib/cli-engine/cli-engine.js +841 -810
- package/lib/cli-engine/file-enumerator.js +384 -390
- package/lib/cli-engine/formatters/formatters-meta.json +17 -45
- package/lib/cli-engine/formatters/html.js +110 -102
- package/lib/cli-engine/formatters/json-with-metadata.js +5 -5
- package/lib/cli-engine/formatters/json.js +2 -2
- package/lib/cli-engine/formatters/stylish.js +97 -76
- package/lib/cli-engine/hash.js +1 -1
- package/lib/cli-engine/index.js +1 -1
- package/lib/cli-engine/lint-result-cache.js +165 -148
- package/lib/cli-engine/load-rules.js +17 -17
- package/lib/cli.js +481 -399
- package/lib/config/config-loader.js +816 -0
- package/lib/config/config.js +674 -0
- package/lib/config/default-config.js +57 -46
- package/lib/config/flat-config-array.js +170 -333
- package/lib/config/flat-config-schema.js +389 -389
- package/lib/config-api.js +12 -0
- package/lib/eslint/eslint-helpers.js +1196 -663
- package/lib/eslint/eslint.js +1262 -607
- package/lib/eslint/index.js +3 -3
- package/lib/eslint/legacy-eslint.js +786 -0
- package/lib/eslint/worker.js +173 -0
- package/lib/languages/js/index.js +336 -0
- package/lib/languages/js/source-code/index.js +7 -0
- package/lib/languages/js/source-code/source-code.js +1364 -0
- package/lib/languages/js/source-code/token-store/backward-token-comment-cursor.js +61 -0
- package/lib/languages/js/source-code/token-store/backward-token-cursor.js +57 -0
- package/lib/{source-code → languages/js/source-code}/token-store/cursor.js +36 -36
- package/lib/languages/js/source-code/token-store/cursors.js +120 -0
- package/lib/{source-code → languages/js/source-code}/token-store/decorative-cursor.js +17 -18
- package/lib/{source-code → languages/js/source-code}/token-store/filter-cursor.js +19 -20
- package/lib/languages/js/source-code/token-store/forward-token-comment-cursor.js +65 -0
- package/lib/languages/js/source-code/token-store/forward-token-cursor.js +62 -0
- package/lib/languages/js/source-code/token-store/index.js +721 -0
- package/lib/{source-code → languages/js/source-code}/token-store/limit-cursor.js +17 -18
- package/lib/languages/js/source-code/token-store/padded-token-cursor.js +45 -0
- package/lib/{source-code → languages/js/source-code}/token-store/skip-cursor.js +19 -20
- package/lib/languages/js/source-code/token-store/utils.js +110 -0
- package/lib/languages/js/validate-language-options.js +196 -0
- package/lib/linter/apply-disable-directives.js +490 -371
- package/lib/linter/code-path-analysis/code-path-analyzer.js +650 -674
- package/lib/linter/code-path-analysis/code-path-segment.js +215 -216
- package/lib/linter/code-path-analysis/code-path-state.js +2118 -2096
- package/lib/linter/code-path-analysis/code-path.js +307 -317
- package/lib/linter/code-path-analysis/debug-helpers.js +183 -163
- package/lib/linter/code-path-analysis/fork-context.js +297 -272
- package/lib/linter/code-path-analysis/id-generator.js +22 -23
- package/lib/linter/esquery.js +332 -0
- package/lib/linter/file-context.js +144 -0
- package/lib/linter/file-report.js +608 -0
- package/lib/linter/index.js +3 -5
- package/lib/linter/interpolate.js +38 -16
- package/lib/linter/linter.js +2328 -1785
- package/lib/linter/rule-fixer.js +136 -107
- package/lib/linter/rules.js +37 -46
- package/lib/linter/source-code-fixer.js +96 -94
- package/lib/linter/source-code-traverser.js +333 -0
- package/lib/linter/source-code-visitor.js +81 -0
- package/lib/linter/timing.js +145 -97
- package/lib/linter/vfile.js +115 -0
- package/lib/options.js +464 -326
- package/lib/rule-tester/index.js +3 -1
- package/lib/rule-tester/rule-tester.js +1371 -998
- package/lib/rules/accessor-pairs.js +333 -259
- package/lib/rules/array-bracket-newline.js +250 -220
- package/lib/rules/array-bracket-spacing.js +286 -229
- package/lib/rules/array-callback-return.js +401 -354
- package/lib/rules/array-element-newline.js +358 -295
- package/lib/rules/arrow-body-style.js +400 -278
- package/lib/rules/arrow-parens.js +206 -155
- package/lib/rules/arrow-spacing.js +169 -145
- package/lib/rules/block-scoped-var.js +125 -123
- package/lib/rules/block-spacing.js +186 -158
- package/lib/rules/brace-style.js +262 -181
- package/lib/rules/callback-return.js +203 -174
- package/lib/rules/camelcase.js +403 -380
- package/lib/rules/capitalized-comments.js +253 -228
- package/lib/rules/class-methods-use-this.js +231 -168
- package/lib/rules/comma-dangle.js +379 -328
- package/lib/rules/comma-spacing.js +193 -177
- package/lib/rules/comma-style.js +375 -298
- package/lib/rules/complexity.js +180 -144
- package/lib/rules/computed-property-spacing.js +236 -193
- package/lib/rules/consistent-return.js +181 -170
- package/lib/rules/consistent-this.js +167 -141
- package/lib/rules/constructor-super.js +418 -411
- package/lib/rules/curly.js +407 -468
- package/lib/rules/default-case-last.js +39 -32
- package/lib/rules/default-case.js +89 -83
- package/lib/rules/default-param-last.js +69 -53
- package/lib/rules/dot-location.js +122 -92
- package/lib/rules/dot-notation.js +193 -153
- package/lib/rules/eol-last.js +122 -102
- package/lib/rules/eqeqeq.js +191 -155
- package/lib/rules/for-direction.js +150 -122
- package/lib/rules/func-call-spacing.js +261 -213
- package/lib/rules/func-name-matching.js +294 -209
- package/lib/rules/func-names.js +165 -164
- package/lib/rules/func-style.js +209 -86
- package/lib/rules/function-call-argument-newline.js +152 -111
- package/lib/rules/function-paren-newline.js +349 -273
- package/lib/rules/generator-star-spacing.js +229 -192
- package/lib/rules/getter-return.js +208 -170
- package/lib/rules/global-require.js +85 -58
- package/lib/rules/grouped-accessor-pairs.js +201 -148
- package/lib/rules/guard-for-in.js +72 -63
- package/lib/rules/handle-callback-err.js +108 -87
- package/lib/rules/id-blacklist.js +182 -187
- package/lib/rules/id-denylist.js +174 -179
- package/lib/rules/id-length.js +197 -157
- package/lib/rules/id-match.js +350 -286
- package/lib/rules/implicit-arrow-linebreak.js +102 -61
- package/lib/rules/indent-legacy.js +1345 -1102
- package/lib/rules/indent.js +2272 -1741
- package/lib/rules/index.js +320 -294
- package/lib/rules/init-declarations.js +139 -106
- package/lib/rules/jsx-quotes.js +94 -64
- package/lib/rules/key-spacing.js +750 -615
- package/lib/rules/keyword-spacing.js +648 -587
- package/lib/rules/line-comment-position.js +143 -108
- package/lib/rules/linebreak-style.js +115 -88
- package/lib/rules/lines-around-comment.js +540 -430
- package/lib/rules/lines-around-directive.js +233 -185
- package/lib/rules/lines-between-class-members.js +305 -216
- package/lib/rules/logical-assignment-operators.js +582 -398
- package/lib/rules/max-classes-per-file.js +69 -68
- package/lib/rules/max-depth.js +146 -143
- package/lib/rules/max-len.js +473 -416
- package/lib/rules/max-lines-per-function.js +201 -176
- package/lib/rules/max-lines.js +158 -162
- package/lib/rules/max-nested-callbacks.js +102 -104
- package/lib/rules/max-params.js +102 -75
- package/lib/rules/max-statements-per-line.js +205 -180
- package/lib/rules/max-statements.js +168 -164
- package/lib/rules/multiline-comment-style.js +638 -460
- package/lib/rules/multiline-ternary.js +241 -158
- package/lib/rules/new-cap.js +233 -232
- package/lib/rules/new-parens.js +88 -61
- package/lib/rules/newline-after-var.js +287 -233
- package/lib/rules/newline-before-return.js +229 -204
- package/lib/rules/newline-per-chained-call.js +142 -109
- package/lib/rules/no-alert.js +90 -79
- package/lib/rules/no-array-constructor.js +175 -113
- package/lib/rules/no-async-promise-executor.js +30 -24
- package/lib/rules/no-await-in-loop.js +79 -70
- package/lib/rules/no-bitwise.js +113 -87
- package/lib/rules/no-buffer-constructor.js +61 -37
- package/lib/rules/no-caller.js +39 -33
- package/lib/rules/no-case-declarations.js +61 -45
- package/lib/rules/no-catch-shadow.js +76 -62
- package/lib/rules/no-class-assign.js +51 -48
- package/lib/rules/no-compare-neg-zero.js +62 -48
- package/lib/rules/no-cond-assign.js +148 -132
- package/lib/rules/no-confusing-arrow.js +98 -63
- package/lib/rules/no-console.js +202 -188
- package/lib/rules/no-const-assign.js +58 -41
- package/lib/rules/no-constant-binary-expression.js +501 -407
- package/lib/rules/no-constant-condition.js +158 -131
- package/lib/rules/no-constructor-return.js +49 -49
- package/lib/rules/no-continue.js +25 -26
- package/lib/rules/no-control-regex.js +125 -121
- package/lib/rules/no-debugger.js +28 -30
- package/lib/rules/no-delete-var.js +29 -29
- package/lib/rules/no-div-regex.js +47 -40
- package/lib/rules/no-dupe-args.js +79 -69
- package/lib/rules/no-dupe-class-members.js +102 -89
- package/lib/rules/no-dupe-else-if.js +100 -77
- package/lib/rules/no-dupe-keys.js +133 -110
- package/lib/rules/no-duplicate-case.js +50 -43
- package/lib/rules/no-duplicate-imports.js +266 -188
- package/lib/rules/no-else-return.js +430 -385
- package/lib/rules/no-empty-character-class.js +57 -50
- package/lib/rules/no-empty-function.js +197 -128
- package/lib/rules/no-empty-pattern.js +63 -56
- package/lib/rules/no-empty-static-block.js +61 -35
- package/lib/rules/no-empty.js +135 -85
- package/lib/rules/no-eq-null.js +37 -32
- package/lib/rules/no-eval.js +258 -249
- package/lib/rules/no-ex-assign.js +42 -39
- package/lib/rules/no-extend-native.js +161 -160
- package/lib/rules/no-extra-bind.js +201 -190
- package/lib/rules/no-extra-boolean-cast.js +398 -295
- package/lib/rules/no-extra-label.js +150 -130
- package/lib/rules/no-extra-parens.js +1654 -1307
- package/lib/rules/no-extra-semi.js +146 -126
- package/lib/rules/no-fallthrough.js +200 -136
- package/lib/rules/no-floating-decimal.js +74 -48
- package/lib/rules/no-func-assign.js +54 -55
- package/lib/rules/no-global-assign.js +78 -72
- package/lib/rules/no-implicit-coercion.js +350 -262
- package/lib/rules/no-implicit-globals.js +174 -133
- package/lib/rules/no-implied-eval.js +150 -112
- package/lib/rules/no-import-assign.js +145 -159
- package/lib/rules/no-inline-comments.js +101 -96
- package/lib/rules/no-inner-declarations.js +115 -78
- package/lib/rules/no-invalid-regexp.js +223 -174
- package/lib/rules/no-invalid-this.js +145 -117
- package/lib/rules/no-irregular-whitespace.js +266 -250
- package/lib/rules/no-iterator.js +29 -33
- package/lib/rules/no-label-var.js +59 -61
- package/lib/rules/no-labels.js +138 -131
- package/lib/rules/no-lone-blocks.js +127 -123
- package/lib/rules/no-lonely-if.js +105 -67
- package/lib/rules/no-loop-func.js +245 -184
- package/lib/rules/no-loss-of-precision.js +236 -201
- package/lib/rules/no-magic-numbers.js +339 -217
- package/lib/rules/no-misleading-character-class.js +548 -253
- package/lib/rules/no-mixed-operators.js +188 -164
- package/lib/rules/no-mixed-requires.js +253 -224
- package/lib/rules/no-mixed-spaces-and-tabs.js +135 -103
- package/lib/rules/no-multi-assign.js +46 -47
- package/lib/rules/no-multi-spaces.js +163 -125
- package/lib/rules/no-multi-str.js +42 -40
- package/lib/rules/no-multiple-empty-lines.js +196 -140
- package/lib/rules/no-native-reassign.js +90 -74
- package/lib/rules/no-negated-condition.js +79 -74
- package/lib/rules/no-negated-in-lhs.js +45 -32
- package/lib/rules/no-nested-ternary.js +33 -31
- package/lib/rules/no-new-func.js +71 -62
- package/lib/rules/no-new-native-nonconstructor.js +43 -39
- package/lib/rules/no-new-object.js +48 -39
- package/lib/rules/no-new-require.js +48 -31
- package/lib/rules/no-new-symbol.js +61 -43
- package/lib/rules/no-new-wrappers.js +43 -41
- package/lib/rules/no-new.js +28 -29
- package/lib/rules/no-nonoctal-decimal-escape.js +149 -121
- package/lib/rules/no-obj-calls.js +66 -53
- package/lib/rules/no-object-constructor.js +104 -97
- package/lib/rules/no-octal-escape.js +40 -43
- package/lib/rules/no-octal.js +29 -32
- package/lib/rules/no-param-reassign.js +236 -218
- package/lib/rules/no-path-concat.js +66 -51
- package/lib/rules/no-plusplus.js +60 -63
- package/lib/rules/no-process-env.js +49 -32
- package/lib/rules/no-process-exit.js +48 -28
- package/lib/rules/no-promise-executor-return.js +205 -204
- package/lib/rules/no-proto.js +26 -29
- package/lib/rules/no-prototype-builtins.js +146 -124
- package/lib/rules/no-redeclare.js +154 -155
- package/lib/rules/no-regex-spaces.js +183 -161
- package/lib/rules/no-restricted-exports.js +208 -174
- package/lib/rules/no-restricted-globals.js +254 -112
- package/lib/rules/no-restricted-imports.js +824 -384
- package/lib/rules/no-restricted-modules.js +222 -186
- package/lib/rules/no-restricted-properties.js +218 -153
- package/lib/rules/no-restricted-syntax.js +56 -52
- package/lib/rules/no-return-assign.js +56 -49
- package/lib/rules/no-return-await.js +147 -120
- package/lib/rules/no-script-url.js +53 -46
- package/lib/rules/no-self-assign.js +148 -145
- package/lib/rules/no-self-compare.js +63 -46
- package/lib/rules/no-sequences.js +135 -115
- package/lib/rules/no-setter-return.js +176 -178
- package/lib/rules/no-shadow-restricted-names.js +84 -36
- package/lib/rules/no-shadow.js +598 -310
- package/lib/rules/no-spaced-func.js +82 -60
- package/lib/rules/no-sparse-arrays.js +46 -28
- package/lib/rules/no-sync.js +61 -44
- package/lib/rules/no-tabs.js +83 -54
- package/lib/rules/no-template-curly-in-string.js +33 -32
- package/lib/rules/no-ternary.js +25 -28
- package/lib/rules/no-this-before-super.js +332 -298
- package/lib/rules/no-throw-literal.js +31 -36
- package/lib/rules/no-trailing-spaces.js +208 -174
- package/lib/rules/no-unassigned-vars.js +80 -0
- package/lib/rules/no-undef-init.js +86 -60
- package/lib/rules/no-undef.js +52 -47
- package/lib/rules/no-undefined.js +73 -74
- package/lib/rules/no-underscore-dangle.js +370 -322
- package/lib/rules/no-unexpected-multiline.js +112 -102
- package/lib/rules/no-unmodified-loop-condition.js +254 -254
- package/lib/rules/no-unneeded-ternary.js +212 -146
- package/lib/rules/no-unreachable-loop.js +145 -140
- package/lib/rules/no-unreachable.js +255 -248
- package/lib/rules/no-unsafe-finally.js +93 -85
- package/lib/rules/no-unsafe-negation.js +105 -81
- package/lib/rules/no-unsafe-optional-chaining.js +193 -177
- package/lib/rules/no-unused-expressions.js +199 -158
- package/lib/rules/no-unused-labels.js +139 -124
- package/lib/rules/no-unused-private-class-members.js +206 -182
- package/lib/rules/no-unused-vars.js +1708 -687
- package/lib/rules/no-use-before-define.js +327 -229
- package/lib/rules/no-useless-assignment.js +654 -0
- package/lib/rules/no-useless-backreference.js +212 -143
- package/lib/rules/no-useless-call.js +58 -53
- package/lib/rules/no-useless-catch.js +40 -40
- package/lib/rules/no-useless-computed-key.js +144 -108
- package/lib/rules/no-useless-concat.js +65 -59
- package/lib/rules/no-useless-constructor.js +160 -97
- package/lib/rules/no-useless-escape.js +364 -291
- package/lib/rules/no-useless-rename.js +183 -153
- package/lib/rules/no-useless-return.js +344 -307
- package/lib/rules/no-var.js +245 -212
- package/lib/rules/no-void.js +51 -46
- package/lib/rules/no-warning-comments.js +191 -183
- package/lib/rules/no-whitespace-before-property.js +131 -97
- package/lib/rules/no-with.js +24 -26
- package/lib/rules/nonblock-statement-body-position.js +149 -112
- package/lib/rules/object-curly-newline.js +306 -247
- package/lib/rules/object-curly-spacing.js +360 -296
- package/lib/rules/object-property-newline.js +137 -88
- package/lib/rules/object-shorthand.js +632 -500
- package/lib/rules/one-var-declaration-per-line.js +104 -82
- package/lib/rules/one-var.js +686 -536
- package/lib/rules/operator-assignment.js +219 -158
- package/lib/rules/operator-linebreak.js +295 -233
- package/lib/rules/padded-blocks.js +346 -290
- package/lib/rules/padding-line-between-statements.js +443 -421
- package/lib/rules/prefer-arrow-callback.js +371 -315
- package/lib/rules/prefer-const.js +418 -373
- package/lib/rules/prefer-destructuring.js +309 -278
- package/lib/rules/prefer-exponentiation-operator.js +176 -132
- package/lib/rules/prefer-named-capture-group.js +160 -141
- package/lib/rules/prefer-numeric-literals.js +121 -112
- package/lib/rules/prefer-object-has-own.js +116 -82
- package/lib/rules/prefer-object-spread.js +214 -193
- package/lib/rules/prefer-promise-reject-errors.js +140 -118
- package/lib/rules/prefer-reflect.js +126 -103
- package/lib/rules/prefer-regex-literals.js +561 -463
- package/lib/rules/prefer-rest-params.js +79 -80
- package/lib/rules/prefer-spread.js +47 -43
- package/lib/rules/prefer-template.js +266 -194
- package/lib/rules/preserve-caught-error.js +535 -0
- package/lib/rules/quote-props.js +373 -289
- package/lib/rules/quotes.js +374 -308
- package/lib/rules/radix.js +152 -134
- package/lib/rules/require-atomic-updates.js +316 -282
- package/lib/rules/require-await.js +153 -82
- package/lib/rules/require-unicode-regexp.js +296 -108
- package/lib/rules/require-yield.js +53 -54
- package/lib/rules/rest-spread-spacing.js +128 -98
- package/lib/rules/semi-spacing.js +281 -232
- package/lib/rules/semi-style.js +176 -116
- package/lib/rules/semi.js +456 -418
- package/lib/rules/sort-imports.js +307 -229
- package/lib/rules/sort-keys.js +219 -181
- package/lib/rules/sort-vars.js +127 -91
- package/lib/rules/space-before-blocks.js +199 -171
- package/lib/rules/space-before-function-paren.js +186 -148
- package/lib/rules/space-in-parens.js +359 -270
- package/lib/rules/space-infix-ops.js +237 -183
- package/lib/rules/space-unary-ops.js +356 -280
- package/lib/rules/spaced-comment.js +363 -301
- package/lib/rules/strict.js +266 -229
- package/lib/rules/switch-colon-spacing.js +130 -104
- package/lib/rules/symbol-description.js +45 -48
- package/lib/rules/template-curly-spacing.js +148 -124
- package/lib/rules/template-tag-spacing.js +98 -70
- package/lib/rules/unicode-bom.js +54 -54
- package/lib/rules/use-isnan.js +237 -110
- package/lib/rules/utils/ast-utils.js +2139 -1688
- package/lib/rules/utils/char-source.js +247 -0
- package/lib/rules/utils/fix-tracker.js +99 -88
- package/lib/rules/utils/keywords.js +59 -59
- package/lib/rules/utils/lazy-loading-rule-map.js +81 -78
- package/lib/rules/utils/regular-expressions.js +35 -19
- package/lib/rules/utils/unicode/index.js +9 -4
- package/lib/rules/utils/unicode/is-combining-character.js +1 -1
- package/lib/rules/utils/unicode/is-emoji-modifier.js +1 -1
- package/lib/rules/utils/unicode/is-regional-indicator-symbol.js +1 -1
- package/lib/rules/utils/unicode/is-surrogate-pair.js +1 -1
- package/lib/rules/valid-typeof.js +153 -109
- package/lib/rules/vars-on-top.js +152 -144
- package/lib/rules/wrap-iife.js +204 -173
- package/lib/rules/wrap-regex.js +77 -47
- package/lib/rules/yield-star-spacing.js +145 -116
- package/lib/rules/yoda.js +283 -274
- package/lib/services/parser-service.js +65 -0
- package/lib/services/processor-service.js +101 -0
- package/lib/services/suppressions-service.js +302 -0
- package/lib/services/warning-service.js +98 -0
- package/lib/shared/ajv.js +14 -14
- package/lib/shared/assert.js +21 -0
- package/lib/shared/ast-utils.js +7 -6
- package/lib/shared/deep-merge-arrays.js +62 -0
- package/lib/shared/directives.js +3 -2
- package/lib/shared/flags.js +108 -0
- package/lib/shared/logging.js +24 -16
- package/lib/shared/naming.js +109 -0
- package/lib/shared/option-utils.js +63 -0
- package/lib/shared/relative-module-resolver.js +18 -40
- package/lib/shared/runtime-info.js +138 -128
- package/lib/shared/serialization.js +78 -0
- package/lib/shared/severity.js +22 -22
- package/lib/shared/stats.js +30 -0
- package/lib/shared/string-utils.js +19 -21
- package/lib/shared/text-table.js +68 -0
- package/lib/shared/translate-cli-options.js +281 -0
- package/lib/shared/traverser.js +153 -146
- package/lib/types/config-api.d.ts +12 -0
- package/lib/types/index.d.ts +1473 -0
- package/lib/types/rules.d.ts +5589 -0
- package/lib/types/universal.d.ts +6 -0
- package/lib/types/use-at-your-own-risk.d.ts +87 -0
- package/lib/universal.js +10 -0
- package/lib/unsupported-api.js +8 -9
- package/messages/all-files-ignored.js +3 -3
- package/messages/all-matched-files-ignored.js +21 -0
- package/messages/config-file-missing.js +16 -0
- package/messages/config-plugin-missing.js +14 -0
- package/messages/config-serialize-function.js +30 -0
- package/messages/eslintrc-incompat.js +35 -16
- package/messages/eslintrc-plugins.js +8 -5
- package/messages/extend-config-missing.js +3 -3
- package/messages/failed-to-read-json.js +3 -3
- package/messages/file-not-found.js +3 -3
- package/messages/invalid-rule-options.js +2 -2
- package/messages/invalid-rule-severity.js +2 -2
- package/messages/no-config-found.js +4 -4
- package/messages/plugin-conflict.js +9 -9
- package/messages/plugin-invalid.js +4 -4
- package/messages/plugin-missing.js +4 -4
- package/messages/print-config-with-directory-path.js +2 -2
- package/messages/shared.js +6 -1
- package/messages/whitespace-found.js +3 -3
- package/package.json +105 -60
- package/conf/config-schema.js +0 -93
- package/lib/cli-engine/formatters/checkstyle.js +0 -60
- package/lib/cli-engine/formatters/compact.js +0 -60
- package/lib/cli-engine/formatters/jslint-xml.js +0 -41
- package/lib/cli-engine/formatters/junit.js +0 -82
- package/lib/cli-engine/formatters/tap.js +0 -95
- package/lib/cli-engine/formatters/unix.js +0 -58
- package/lib/cli-engine/formatters/visualstudio.js +0 -63
- package/lib/cli-engine/xml-escape.js +0 -34
- package/lib/config/flat-config-helpers.js +0 -111
- package/lib/config/rule-validator.js +0 -158
- package/lib/eslint/flat-eslint.js +0 -1159
- package/lib/linter/config-comment-parser.js +0 -185
- package/lib/linter/node-event-generator.js +0 -354
- package/lib/linter/report-translator.js +0 -369
- package/lib/linter/safe-emitter.js +0 -52
- package/lib/rule-tester/flat-rule-tester.js +0 -1131
- package/lib/rules/require-jsdoc.js +0 -122
- package/lib/rules/utils/patterns/letters.js +0 -36
- package/lib/rules/valid-jsdoc.js +0 -516
- package/lib/shared/config-validator.js +0 -347
- package/lib/shared/deprecation-warnings.js +0 -58
- package/lib/shared/types.js +0 -216
- package/lib/source-code/index.js +0 -5
- package/lib/source-code/source-code.js +0 -1055
- package/lib/source-code/token-store/backward-token-comment-cursor.js +0 -57
- package/lib/source-code/token-store/backward-token-cursor.js +0 -58
- package/lib/source-code/token-store/cursors.js +0 -90
- package/lib/source-code/token-store/forward-token-comment-cursor.js +0 -57
- package/lib/source-code/token-store/forward-token-cursor.js +0 -63
- package/lib/source-code/token-store/index.js +0 -627
- package/lib/source-code/token-store/padded-token-cursor.js +0 -38
- package/lib/source-code/token-store/utils.js +0 -107
|
@@ -9,23 +9,27 @@
|
|
|
9
9
|
// Typedefs
|
|
10
10
|
//------------------------------------------------------------------------------
|
|
11
11
|
|
|
12
|
-
/** @typedef {import("../
|
|
12
|
+
/** @typedef {import("../types").Linter.LintMessage} LintMessage */
|
|
13
|
+
/** @typedef {import("@eslint/core").Language} Language */
|
|
14
|
+
/** @typedef {import("@eslint/core").Position} Position */
|
|
15
|
+
/** @typedef {import("@eslint/core").RulesConfig} RulesConfig */
|
|
13
16
|
|
|
14
17
|
//------------------------------------------------------------------------------
|
|
15
18
|
// Module Definition
|
|
16
19
|
//------------------------------------------------------------------------------
|
|
17
20
|
|
|
18
21
|
const escapeRegExp = require("escape-string-regexp");
|
|
22
|
+
const { Config } = require("../config/config.js");
|
|
19
23
|
|
|
20
24
|
/**
|
|
21
25
|
* Compares the locations of two objects in a source file
|
|
22
|
-
* @param {
|
|
23
|
-
* @param {
|
|
26
|
+
* @param {Position} itemA The first object
|
|
27
|
+
* @param {Position} itemB The second object
|
|
24
28
|
* @returns {number} A value less than 1 if itemA appears before itemB in the source file, greater than 1 if
|
|
25
29
|
* itemA appears after itemB in the source file, or 0 if itemA and itemB have the same location.
|
|
26
30
|
*/
|
|
27
31
|
function compareLocations(itemA, itemB) {
|
|
28
|
-
|
|
32
|
+
return itemA.line - itemB.line || itemA.column - itemB.column;
|
|
29
33
|
}
|
|
30
34
|
|
|
31
35
|
/**
|
|
@@ -33,170 +37,180 @@ function compareLocations(itemA, itemB) {
|
|
|
33
37
|
* @param {Iterable<Directive>} directives Unused directives to be removed.
|
|
34
38
|
* @returns {Directive[][]} Directives grouped by their parent comment.
|
|
35
39
|
*/
|
|
36
|
-
function
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
|
|
48
|
-
|
|
49
|
-
|
|
40
|
+
function groupByParentDirective(directives) {
|
|
41
|
+
const groups = new Map();
|
|
42
|
+
|
|
43
|
+
for (const directive of directives) {
|
|
44
|
+
const {
|
|
45
|
+
unprocessedDirective: { parentDirective },
|
|
46
|
+
} = directive;
|
|
47
|
+
|
|
48
|
+
if (groups.has(parentDirective)) {
|
|
49
|
+
groups.get(parentDirective).push(directive);
|
|
50
|
+
} else {
|
|
51
|
+
groups.set(parentDirective, [directive]);
|
|
52
|
+
}
|
|
53
|
+
}
|
|
54
|
+
|
|
55
|
+
return [...groups.values()];
|
|
50
56
|
}
|
|
51
57
|
|
|
52
58
|
/**
|
|
53
59
|
* Creates removal details for a set of directives within the same comment.
|
|
54
60
|
* @param {Directive[]} directives Unused directives to be removed.
|
|
55
|
-
* @param {Token}
|
|
61
|
+
* @param {{node: Token, value: string}} parentDirective Data about the backing directive.
|
|
62
|
+
* @param {SourceCode} sourceCode The source code object for the file being linted.
|
|
56
63
|
* @returns {{ description, fix, unprocessedDirective }[]} Details for later creation of output Problems.
|
|
57
64
|
*/
|
|
58
|
-
function createIndividualDirectivesRemoval(
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
|
|
62
|
-
|
|
63
|
-
|
|
64
|
-
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
|
|
87
|
-
|
|
88
|
-
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
115
|
-
|
|
116
|
-
|
|
117
|
-
|
|
118
|
-
|
|
119
|
-
|
|
120
|
-
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
|
|
124
|
-
|
|
125
|
-
|
|
126
|
-
|
|
127
|
-
|
|
128
|
-
|
|
129
|
-
|
|
130
|
-
|
|
131
|
-
|
|
132
|
-
|
|
133
|
-
|
|
134
|
-
|
|
135
|
-
|
|
136
|
-
|
|
137
|
-
|
|
138
|
-
|
|
139
|
-
|
|
140
|
-
|
|
141
|
-
|
|
142
|
-
|
|
143
|
-
|
|
144
|
-
|
|
145
|
-
|
|
146
|
-
|
|
147
|
-
|
|
148
|
-
],
|
|
149
|
-
text: ""
|
|
150
|
-
},
|
|
151
|
-
unprocessedDirective: directive.unprocessedDirective
|
|
152
|
-
};
|
|
153
|
-
});
|
|
65
|
+
function createIndividualDirectivesRemoval(
|
|
66
|
+
directives,
|
|
67
|
+
parentDirective,
|
|
68
|
+
sourceCode,
|
|
69
|
+
) {
|
|
70
|
+
/*
|
|
71
|
+
* Get the list of the rules text without any surrounding whitespace. In order to preserve the original
|
|
72
|
+
* formatting, we don't want to change that whitespace.
|
|
73
|
+
*
|
|
74
|
+
* // eslint-disable-line rule-one , rule-two , rule-three -- comment
|
|
75
|
+
* ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
76
|
+
*/
|
|
77
|
+
const listText = parentDirective.value.trim();
|
|
78
|
+
|
|
79
|
+
// Calculate where it starts in the source code text
|
|
80
|
+
const listStart = sourceCode.text.indexOf(
|
|
81
|
+
listText,
|
|
82
|
+
sourceCode.getRange(parentDirective.node)[0],
|
|
83
|
+
);
|
|
84
|
+
|
|
85
|
+
/*
|
|
86
|
+
* We can assume that `listText` contains multiple elements.
|
|
87
|
+
* Otherwise, this function wouldn't be called - if there is
|
|
88
|
+
* only one rule in the list, then the whole comment must be removed.
|
|
89
|
+
*/
|
|
90
|
+
|
|
91
|
+
return directives.map(directive => {
|
|
92
|
+
const { ruleId } = directive;
|
|
93
|
+
|
|
94
|
+
const regex = new RegExp(
|
|
95
|
+
String.raw`(?:^|\s*,\s*)(?<quote>['"]?)${escapeRegExp(ruleId)}\k<quote>(?:\s*,\s*|$)`,
|
|
96
|
+
"u",
|
|
97
|
+
);
|
|
98
|
+
const match = regex.exec(listText);
|
|
99
|
+
const matchedText = match[0];
|
|
100
|
+
const matchStart = listStart + match.index;
|
|
101
|
+
const matchEnd = matchStart + matchedText.length;
|
|
102
|
+
|
|
103
|
+
const firstIndexOfComma = matchedText.indexOf(",");
|
|
104
|
+
const lastIndexOfComma = matchedText.lastIndexOf(",");
|
|
105
|
+
|
|
106
|
+
let removalStart, removalEnd;
|
|
107
|
+
|
|
108
|
+
if (firstIndexOfComma !== lastIndexOfComma) {
|
|
109
|
+
/*
|
|
110
|
+
* Since there are two commas, this must one of the elements in the middle of the list.
|
|
111
|
+
* Matched range starts where the previous rule name ends, and ends where the next rule name starts.
|
|
112
|
+
*
|
|
113
|
+
* // eslint-disable-line rule-one , rule-two , rule-three -- comment
|
|
114
|
+
* ^^^^^^^^^^^^^^
|
|
115
|
+
*
|
|
116
|
+
* We want to remove only the content between the two commas, and also one of the commas.
|
|
117
|
+
*
|
|
118
|
+
* // eslint-disable-line rule-one , rule-two , rule-three -- comment
|
|
119
|
+
* ^^^^^^^^^^^
|
|
120
|
+
*/
|
|
121
|
+
removalStart = matchStart + firstIndexOfComma;
|
|
122
|
+
removalEnd = matchStart + lastIndexOfComma;
|
|
123
|
+
} else {
|
|
124
|
+
/*
|
|
125
|
+
* This is either the first element or the last element.
|
|
126
|
+
*
|
|
127
|
+
* If this is the first element, matched range starts where the first rule name starts
|
|
128
|
+
* and ends where the second rule name starts. This is exactly the range we want
|
|
129
|
+
* to remove so that the second rule name will start where the first one was starting
|
|
130
|
+
* and thus preserve the original formatting.
|
|
131
|
+
*
|
|
132
|
+
* // eslint-disable-line rule-one , rule-two , rule-three -- comment
|
|
133
|
+
* ^^^^^^^^^^^
|
|
134
|
+
*
|
|
135
|
+
* Similarly, if this is the last element, we've already matched the range we want to
|
|
136
|
+
* remove. The previous rule name will end where the last one was ending, relative
|
|
137
|
+
* to the content on the right side.
|
|
138
|
+
*
|
|
139
|
+
* // eslint-disable-line rule-one , rule-two , rule-three -- comment
|
|
140
|
+
* ^^^^^^^^^^^^^
|
|
141
|
+
*/
|
|
142
|
+
removalStart = matchStart;
|
|
143
|
+
removalEnd = matchEnd;
|
|
144
|
+
}
|
|
145
|
+
|
|
146
|
+
return {
|
|
147
|
+
description: `'${ruleId}'`,
|
|
148
|
+
fix: {
|
|
149
|
+
range: [removalStart, removalEnd],
|
|
150
|
+
text: "",
|
|
151
|
+
},
|
|
152
|
+
unprocessedDirective: directive.unprocessedDirective,
|
|
153
|
+
};
|
|
154
|
+
});
|
|
154
155
|
}
|
|
155
156
|
|
|
156
157
|
/**
|
|
157
|
-
* Creates a description of deleting an entire unused disable
|
|
158
|
+
* Creates a description of deleting an entire unused disable directive.
|
|
158
159
|
* @param {Directive[]} directives Unused directives to be removed.
|
|
159
|
-
* @param {Token}
|
|
160
|
-
* @
|
|
160
|
+
* @param {Token} node The backing Comment token.
|
|
161
|
+
* @param {SourceCode} sourceCode The source code object for the file being linted.
|
|
162
|
+
* @returns {{ description, fix, unprocessedDirective }} Details for later creation of an output problem.
|
|
161
163
|
*/
|
|
162
|
-
function
|
|
163
|
-
|
|
164
|
-
|
|
165
|
-
|
|
166
|
-
|
|
167
|
-
|
|
168
|
-
|
|
169
|
-
|
|
170
|
-
|
|
171
|
-
|
|
172
|
-
|
|
173
|
-
|
|
174
|
-
|
|
175
|
-
|
|
164
|
+
function createDirectiveRemoval(directives, node, sourceCode) {
|
|
165
|
+
const range = sourceCode.getRange(node);
|
|
166
|
+
const ruleIds = directives
|
|
167
|
+
.filter(directive => directive.ruleId)
|
|
168
|
+
.map(directive => `'${directive.ruleId}'`);
|
|
169
|
+
|
|
170
|
+
return {
|
|
171
|
+
description:
|
|
172
|
+
ruleIds.length <= 2
|
|
173
|
+
? ruleIds.join(" or ")
|
|
174
|
+
: `${ruleIds.slice(0, ruleIds.length - 1).join(", ")}, or ${ruleIds.at(-1)}`,
|
|
175
|
+
fix: {
|
|
176
|
+
range,
|
|
177
|
+
text: " ",
|
|
178
|
+
},
|
|
179
|
+
unprocessedDirective: directives[0].unprocessedDirective,
|
|
180
|
+
};
|
|
176
181
|
}
|
|
177
182
|
|
|
178
183
|
/**
|
|
179
184
|
* Parses details from directives to create output Problems.
|
|
180
185
|
* @param {Iterable<Directive>} allDirectives Unused directives to be removed.
|
|
186
|
+
* @param {SourceCode} sourceCode The source code object for the file being linted.
|
|
181
187
|
* @returns {{ description, fix, unprocessedDirective }[]} Details for later creation of output Problems.
|
|
182
188
|
*/
|
|
183
|
-
function processUnusedDirectives(allDirectives) {
|
|
184
|
-
|
|
185
|
-
|
|
186
|
-
|
|
187
|
-
|
|
188
|
-
|
|
189
|
-
|
|
190
|
-
|
|
191
|
-
|
|
192
|
-
|
|
193
|
-
|
|
194
|
-
|
|
195
|
-
|
|
196
|
-
|
|
197
|
-
|
|
198
|
-
|
|
199
|
-
|
|
189
|
+
function processUnusedDirectives(allDirectives, sourceCode) {
|
|
190
|
+
const directiveGroups = groupByParentDirective(allDirectives);
|
|
191
|
+
|
|
192
|
+
return directiveGroups.flatMap(directives => {
|
|
193
|
+
const { parentDirective } = directives[0].unprocessedDirective;
|
|
194
|
+
const remainingRuleIds = new Set(parentDirective.ruleIds);
|
|
195
|
+
|
|
196
|
+
for (const directive of directives) {
|
|
197
|
+
remainingRuleIds.delete(directive.ruleId);
|
|
198
|
+
}
|
|
199
|
+
|
|
200
|
+
return remainingRuleIds.size
|
|
201
|
+
? createIndividualDirectivesRemoval(
|
|
202
|
+
directives,
|
|
203
|
+
parentDirective,
|
|
204
|
+
sourceCode,
|
|
205
|
+
)
|
|
206
|
+
: [
|
|
207
|
+
createDirectiveRemoval(
|
|
208
|
+
directives,
|
|
209
|
+
parentDirective.node,
|
|
210
|
+
sourceCode,
|
|
211
|
+
),
|
|
212
|
+
];
|
|
213
|
+
});
|
|
200
214
|
}
|
|
201
215
|
|
|
202
216
|
/**
|
|
@@ -205,87 +219,83 @@ function processUnusedDirectives(allDirectives) {
|
|
|
205
219
|
* @returns {Set<Directive>} The used eslint-enable comments
|
|
206
220
|
*/
|
|
207
221
|
function collectUsedEnableDirectives(directives) {
|
|
208
|
-
|
|
209
|
-
|
|
210
|
-
|
|
211
|
-
|
|
212
|
-
|
|
213
|
-
|
|
214
|
-
|
|
215
|
-
|
|
216
|
-
|
|
217
|
-
|
|
218
|
-
|
|
219
|
-
|
|
220
|
-
|
|
221
|
-
|
|
222
|
-
|
|
223
|
-
|
|
224
|
-
|
|
225
|
-
|
|
226
|
-
|
|
227
|
-
|
|
228
|
-
|
|
229
|
-
|
|
230
|
-
|
|
231
|
-
|
|
232
|
-
|
|
233
|
-
|
|
234
|
-
|
|
235
|
-
|
|
236
|
-
|
|
237
|
-
|
|
238
|
-
|
|
239
|
-
|
|
240
|
-
|
|
241
|
-
|
|
242
|
-
|
|
243
|
-
|
|
244
|
-
|
|
245
|
-
|
|
246
|
-
|
|
247
|
-
|
|
248
|
-
|
|
249
|
-
|
|
250
|
-
|
|
251
|
-
|
|
252
|
-
|
|
253
|
-
|
|
254
|
-
|
|
255
|
-
|
|
256
|
-
|
|
257
|
-
|
|
258
|
-
|
|
259
|
-
|
|
260
|
-
|
|
261
|
-
|
|
262
|
-
|
|
263
|
-
|
|
264
|
-
|
|
265
|
-
|
|
266
|
-
|
|
267
|
-
|
|
268
|
-
|
|
269
|
-
|
|
270
|
-
|
|
271
|
-
|
|
272
|
-
|
|
273
|
-
|
|
274
|
-
|
|
275
|
-
|
|
276
|
-
|
|
277
|
-
|
|
278
|
-
|
|
279
|
-
|
|
280
|
-
|
|
281
|
-
|
|
282
|
-
|
|
283
|
-
|
|
284
|
-
|
|
285
|
-
}
|
|
286
|
-
}
|
|
287
|
-
}
|
|
288
|
-
return usedEnableDirectives;
|
|
222
|
+
/**
|
|
223
|
+
* A Map of `eslint-enable` keyed by ruleIds that may be marked as used.
|
|
224
|
+
* If `eslint-enable` does not have a ruleId, the key will be `null`.
|
|
225
|
+
* @type {Map<string|null, Directive>}
|
|
226
|
+
*/
|
|
227
|
+
const enabledRules = new Map();
|
|
228
|
+
|
|
229
|
+
/**
|
|
230
|
+
* A Set of `eslint-enable` marked as used.
|
|
231
|
+
* It is also the return value of `collectUsedEnableDirectives` function.
|
|
232
|
+
* @type {Set<Directive>}
|
|
233
|
+
*/
|
|
234
|
+
const usedEnableDirectives = new Set();
|
|
235
|
+
|
|
236
|
+
/*
|
|
237
|
+
* Checks the directives backwards to see if the encountered `eslint-enable` is used by the previous `eslint-disable`,
|
|
238
|
+
* and if so, stores the `eslint-enable` in `usedEnableDirectives`.
|
|
239
|
+
*/
|
|
240
|
+
for (let index = directives.length - 1; index >= 0; index--) {
|
|
241
|
+
const directive = directives[index];
|
|
242
|
+
|
|
243
|
+
if (directive.type === "disable") {
|
|
244
|
+
if (enabledRules.size === 0) {
|
|
245
|
+
continue;
|
|
246
|
+
}
|
|
247
|
+
if (directive.ruleId === null) {
|
|
248
|
+
// If encounter `eslint-disable` without ruleId,
|
|
249
|
+
// mark all `eslint-enable` currently held in enabledRules as used.
|
|
250
|
+
// e.g.
|
|
251
|
+
// /* eslint-disable */ <- current directive
|
|
252
|
+
// /* eslint-enable rule-id1 */ <- used
|
|
253
|
+
// /* eslint-enable rule-id2 */ <- used
|
|
254
|
+
// /* eslint-enable */ <- used
|
|
255
|
+
for (const enableDirective of enabledRules.values()) {
|
|
256
|
+
usedEnableDirectives.add(enableDirective);
|
|
257
|
+
}
|
|
258
|
+
enabledRules.clear();
|
|
259
|
+
} else {
|
|
260
|
+
const enableDirective = enabledRules.get(directive.ruleId);
|
|
261
|
+
|
|
262
|
+
if (enableDirective) {
|
|
263
|
+
// If encounter `eslint-disable` with ruleId, and there is an `eslint-enable` with the same ruleId in enabledRules,
|
|
264
|
+
// mark `eslint-enable` with ruleId as used.
|
|
265
|
+
// e.g.
|
|
266
|
+
// /* eslint-disable rule-id */ <- current directive
|
|
267
|
+
// /* eslint-enable rule-id */ <- used
|
|
268
|
+
usedEnableDirectives.add(enableDirective);
|
|
269
|
+
} else {
|
|
270
|
+
const enabledDirectiveWithoutRuleId =
|
|
271
|
+
enabledRules.get(null);
|
|
272
|
+
|
|
273
|
+
if (enabledDirectiveWithoutRuleId) {
|
|
274
|
+
// If encounter `eslint-disable` with ruleId, and there is no `eslint-enable` with the same ruleId in enabledRules,
|
|
275
|
+
// mark `eslint-enable` without ruleId as used.
|
|
276
|
+
// e.g.
|
|
277
|
+
// /* eslint-disable rule-id */ <- current directive
|
|
278
|
+
// /* eslint-enable */ <- used
|
|
279
|
+
usedEnableDirectives.add(enabledDirectiveWithoutRuleId);
|
|
280
|
+
}
|
|
281
|
+
}
|
|
282
|
+
}
|
|
283
|
+
} else if (directive.type === "enable") {
|
|
284
|
+
if (directive.ruleId === null) {
|
|
285
|
+
// If encounter `eslint-enable` without ruleId, the `eslint-enable` that follows it are unused.
|
|
286
|
+
// So clear enabledRules.
|
|
287
|
+
// e.g.
|
|
288
|
+
// /* eslint-enable */ <- current directive
|
|
289
|
+
// /* eslint-enable rule-id *// <- unused
|
|
290
|
+
// /* eslint-enable */ <- unused
|
|
291
|
+
enabledRules.clear();
|
|
292
|
+
enabledRules.set(null, directive);
|
|
293
|
+
} else {
|
|
294
|
+
enabledRules.set(directive.ruleId, directive);
|
|
295
|
+
}
|
|
296
|
+
}
|
|
297
|
+
}
|
|
298
|
+
return usedEnableDirectives;
|
|
289
299
|
}
|
|
290
300
|
|
|
291
301
|
/**
|
|
@@ -299,105 +309,140 @@ function collectUsedEnableDirectives(directives) {
|
|
|
299
309
|
* of problems (including suppressed ones) and unused eslint-disable directives
|
|
300
310
|
*/
|
|
301
311
|
function applyDirectives(options) {
|
|
302
|
-
|
|
303
|
-
|
|
304
|
-
|
|
305
|
-
|
|
306
|
-
|
|
307
|
-
|
|
308
|
-
|
|
309
|
-
|
|
310
|
-
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
317
|
-
|
|
318
|
-
|
|
319
|
-
|
|
320
|
-
|
|
321
|
-
|
|
322
|
-
|
|
323
|
-
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
|
|
336
|
-
|
|
337
|
-
|
|
338
|
-
|
|
339
|
-
|
|
340
|
-
|
|
341
|
-
|
|
342
|
-
|
|
343
|
-
|
|
344
|
-
|
|
345
|
-
|
|
346
|
-
|
|
347
|
-
|
|
348
|
-
|
|
349
|
-
|
|
350
|
-
|
|
351
|
-
|
|
352
|
-
|
|
353
|
-
|
|
354
|
-
|
|
355
|
-
|
|
356
|
-
|
|
357
|
-
|
|
358
|
-
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
|
|
363
|
-
|
|
364
|
-
|
|
365
|
-
|
|
366
|
-
|
|
367
|
-
|
|
368
|
-
|
|
369
|
-
|
|
370
|
-
|
|
371
|
-
|
|
372
|
-
|
|
373
|
-
|
|
374
|
-
|
|
375
|
-
|
|
376
|
-
|
|
377
|
-
|
|
378
|
-
|
|
379
|
-
|
|
380
|
-
|
|
381
|
-
|
|
382
|
-
|
|
383
|
-
|
|
384
|
-
|
|
385
|
-
|
|
386
|
-
|
|
387
|
-
|
|
388
|
-
|
|
389
|
-
|
|
390
|
-
|
|
391
|
-
|
|
392
|
-
|
|
393
|
-
|
|
394
|
-
|
|
312
|
+
const problems = [];
|
|
313
|
+
const usedDisableDirectives = new Set();
|
|
314
|
+
const { sourceCode } = options;
|
|
315
|
+
|
|
316
|
+
for (const problem of options.problems) {
|
|
317
|
+
let disableDirectivesForProblem = [];
|
|
318
|
+
let nextDirectiveIndex = 0;
|
|
319
|
+
|
|
320
|
+
while (
|
|
321
|
+
nextDirectiveIndex < options.directives.length &&
|
|
322
|
+
compareLocations(options.directives[nextDirectiveIndex], problem) <=
|
|
323
|
+
0
|
|
324
|
+
) {
|
|
325
|
+
const directive = options.directives[nextDirectiveIndex++];
|
|
326
|
+
|
|
327
|
+
if (
|
|
328
|
+
directive.ruleId === null ||
|
|
329
|
+
directive.ruleId === problem.ruleId
|
|
330
|
+
) {
|
|
331
|
+
switch (directive.type) {
|
|
332
|
+
case "disable":
|
|
333
|
+
disableDirectivesForProblem.push(directive);
|
|
334
|
+
break;
|
|
335
|
+
|
|
336
|
+
case "enable":
|
|
337
|
+
disableDirectivesForProblem = [];
|
|
338
|
+
break;
|
|
339
|
+
|
|
340
|
+
// no default
|
|
341
|
+
}
|
|
342
|
+
}
|
|
343
|
+
}
|
|
344
|
+
|
|
345
|
+
if (disableDirectivesForProblem.length > 0) {
|
|
346
|
+
const suppressions = disableDirectivesForProblem.map(directive => ({
|
|
347
|
+
kind: "directive",
|
|
348
|
+
justification: directive.unprocessedDirective.justification,
|
|
349
|
+
}));
|
|
350
|
+
|
|
351
|
+
if (problem.suppressions) {
|
|
352
|
+
problem.suppressions =
|
|
353
|
+
problem.suppressions.concat(suppressions);
|
|
354
|
+
} else {
|
|
355
|
+
problem.suppressions = suppressions;
|
|
356
|
+
usedDisableDirectives.add(disableDirectivesForProblem.at(-1));
|
|
357
|
+
}
|
|
358
|
+
}
|
|
359
|
+
|
|
360
|
+
problems.push(problem);
|
|
361
|
+
}
|
|
362
|
+
|
|
363
|
+
const unusedDisableDirectivesToReport = options.directives.filter(
|
|
364
|
+
directive =>
|
|
365
|
+
directive.type === "disable" &&
|
|
366
|
+
!usedDisableDirectives.has(directive) &&
|
|
367
|
+
!options.rulesToIgnore.has(directive.ruleId),
|
|
368
|
+
);
|
|
369
|
+
|
|
370
|
+
const unusedEnableDirectivesToReport = new Set(
|
|
371
|
+
options.directives.filter(
|
|
372
|
+
directive =>
|
|
373
|
+
directive.unprocessedDirective.type === "enable" &&
|
|
374
|
+
!options.rulesToIgnore.has(directive.ruleId),
|
|
375
|
+
),
|
|
376
|
+
);
|
|
377
|
+
|
|
378
|
+
/*
|
|
379
|
+
* If directives has the eslint-enable directive,
|
|
380
|
+
* check whether the eslint-enable comment is used.
|
|
381
|
+
*/
|
|
382
|
+
if (unusedEnableDirectivesToReport.size > 0) {
|
|
383
|
+
for (const directive of collectUsedEnableDirectives(
|
|
384
|
+
options.directives,
|
|
385
|
+
)) {
|
|
386
|
+
unusedEnableDirectivesToReport.delete(directive);
|
|
387
|
+
}
|
|
388
|
+
}
|
|
389
|
+
|
|
390
|
+
const processed = processUnusedDirectives(
|
|
391
|
+
unusedDisableDirectivesToReport,
|
|
392
|
+
sourceCode,
|
|
393
|
+
).concat(
|
|
394
|
+
processUnusedDirectives(unusedEnableDirectivesToReport, sourceCode),
|
|
395
|
+
);
|
|
396
|
+
const columnOffset = options.language.columnStart === 1 ? 0 : 1;
|
|
397
|
+
const lineOffset = options.language.lineStart === 1 ? 0 : 1;
|
|
398
|
+
|
|
399
|
+
const unusedDirectives = processed.map(
|
|
400
|
+
({ description, fix, unprocessedDirective }) => {
|
|
401
|
+
const { parentDirective, type, line, column } =
|
|
402
|
+
unprocessedDirective;
|
|
403
|
+
|
|
404
|
+
let message;
|
|
405
|
+
|
|
406
|
+
if (type === "enable") {
|
|
407
|
+
message = description
|
|
408
|
+
? `Unused eslint-enable directive (no matching eslint-disable directives were found for ${description}).`
|
|
409
|
+
: "Unused eslint-enable directive (no matching eslint-disable directives were found).";
|
|
410
|
+
} else {
|
|
411
|
+
message = description
|
|
412
|
+
? `Unused eslint-disable directive (no problems were reported from ${description}).`
|
|
413
|
+
: "Unused eslint-disable directive (no problems were reported).";
|
|
414
|
+
}
|
|
415
|
+
|
|
416
|
+
const loc = sourceCode.getLoc(parentDirective.node);
|
|
417
|
+
|
|
418
|
+
return {
|
|
419
|
+
ruleId: null,
|
|
420
|
+
message,
|
|
421
|
+
line:
|
|
422
|
+
type === "disable-next-line"
|
|
423
|
+
? loc.start.line + lineOffset
|
|
424
|
+
: line,
|
|
425
|
+
column:
|
|
426
|
+
type === "disable-next-line"
|
|
427
|
+
? loc.start.column + columnOffset
|
|
428
|
+
: column,
|
|
429
|
+
severity:
|
|
430
|
+
options.reportUnusedDisableDirectives === "warn" ? 1 : 2,
|
|
431
|
+
nodeType: null,
|
|
432
|
+
...(options.disableFixes ? {} : { fix }),
|
|
433
|
+
};
|
|
434
|
+
},
|
|
435
|
+
);
|
|
436
|
+
|
|
437
|
+
return { problems, unusedDirectives };
|
|
395
438
|
}
|
|
396
439
|
|
|
397
440
|
/**
|
|
398
441
|
* Given a list of directive comments (i.e. metadata about eslint-disable and eslint-enable comments) and a list
|
|
399
442
|
* of reported problems, adds the suppression information to the problems.
|
|
400
443
|
* @param {Object} options Information about directives and problems
|
|
444
|
+
* @param {Language} options.language The language being linted.
|
|
445
|
+
* @param {SourceCode} options.sourceCode The source code object for the file being linted.
|
|
401
446
|
* @param {{
|
|
402
447
|
* type: ("disable"|"enable"|"disable-line"|"disable-next-line"),
|
|
403
448
|
* ruleId: (string|null),
|
|
@@ -410,56 +455,130 @@ function applyDirectives(options) {
|
|
|
410
455
|
* @param {{ruleId: (string|null), line: number, column: number}[]} options.problems
|
|
411
456
|
* A list of problems reported by rules, sorted by increasing location in the file, with one-based columns.
|
|
412
457
|
* @param {"off" | "warn" | "error"} options.reportUnusedDisableDirectives If `"warn"` or `"error"`, adds additional problems for unused directives
|
|
458
|
+
* @param {RulesConfig} options.configuredRules The rules configuration.
|
|
459
|
+
* @param {Function} options.ruleFilter A predicate function to filter which rules should be executed.
|
|
413
460
|
* @param {boolean} options.disableFixes If true, it doesn't make `fix` properties.
|
|
414
461
|
* @returns {{ruleId: (string|null), line: number, column: number, suppressions?: {kind: string, justification: string}}[]}
|
|
415
462
|
* An object with a list of reported problems, the suppressed of which contain the suppression information.
|
|
416
463
|
*/
|
|
417
|
-
module.exports = ({
|
|
418
|
-
|
|
419
|
-
|
|
420
|
-
|
|
421
|
-
|
|
422
|
-
|
|
423
|
-
|
|
424
|
-
|
|
425
|
-
|
|
426
|
-
|
|
427
|
-
|
|
428
|
-
|
|
429
|
-
|
|
430
|
-
|
|
431
|
-
|
|
432
|
-
|
|
433
|
-
|
|
434
|
-
|
|
435
|
-
|
|
436
|
-
|
|
437
|
-
|
|
438
|
-
|
|
439
|
-
|
|
440
|
-
|
|
441
|
-
|
|
442
|
-
|
|
443
|
-
|
|
444
|
-
|
|
445
|
-
|
|
446
|
-
|
|
447
|
-
|
|
448
|
-
|
|
449
|
-
|
|
450
|
-
|
|
451
|
-
|
|
452
|
-
|
|
453
|
-
|
|
454
|
-
|
|
455
|
-
|
|
456
|
-
|
|
457
|
-
|
|
458
|
-
|
|
459
|
-
|
|
460
|
-
|
|
461
|
-
|
|
462
|
-
|
|
463
|
-
|
|
464
|
-
|
|
464
|
+
module.exports = ({
|
|
465
|
+
language,
|
|
466
|
+
sourceCode,
|
|
467
|
+
directives,
|
|
468
|
+
disableFixes,
|
|
469
|
+
problems,
|
|
470
|
+
configuredRules,
|
|
471
|
+
ruleFilter,
|
|
472
|
+
reportUnusedDisableDirectives = "off",
|
|
473
|
+
}) => {
|
|
474
|
+
const blockDirectives = directives
|
|
475
|
+
.filter(
|
|
476
|
+
directive =>
|
|
477
|
+
directive.type === "disable" || directive.type === "enable",
|
|
478
|
+
)
|
|
479
|
+
.map(directive =>
|
|
480
|
+
Object.assign({}, directive, { unprocessedDirective: directive }),
|
|
481
|
+
)
|
|
482
|
+
.sort(compareLocations);
|
|
483
|
+
|
|
484
|
+
const lineDirectives = directives
|
|
485
|
+
.flatMap(directive => {
|
|
486
|
+
switch (directive.type) {
|
|
487
|
+
case "disable":
|
|
488
|
+
case "enable":
|
|
489
|
+
return [];
|
|
490
|
+
|
|
491
|
+
case "disable-line":
|
|
492
|
+
return [
|
|
493
|
+
{
|
|
494
|
+
type: "disable",
|
|
495
|
+
line: directive.line,
|
|
496
|
+
column: 1,
|
|
497
|
+
ruleId: directive.ruleId,
|
|
498
|
+
unprocessedDirective: directive,
|
|
499
|
+
},
|
|
500
|
+
{
|
|
501
|
+
type: "enable",
|
|
502
|
+
line: directive.line + 1,
|
|
503
|
+
column: 0,
|
|
504
|
+
ruleId: directive.ruleId,
|
|
505
|
+
unprocessedDirective: directive,
|
|
506
|
+
},
|
|
507
|
+
];
|
|
508
|
+
|
|
509
|
+
case "disable-next-line":
|
|
510
|
+
return [
|
|
511
|
+
{
|
|
512
|
+
type: "disable",
|
|
513
|
+
line: directive.line + 1,
|
|
514
|
+
column: 1,
|
|
515
|
+
ruleId: directive.ruleId,
|
|
516
|
+
unprocessedDirective: directive,
|
|
517
|
+
},
|
|
518
|
+
{
|
|
519
|
+
type: "enable",
|
|
520
|
+
line: directive.line + 2,
|
|
521
|
+
column: 0,
|
|
522
|
+
ruleId: directive.ruleId,
|
|
523
|
+
unprocessedDirective: directive,
|
|
524
|
+
},
|
|
525
|
+
];
|
|
526
|
+
|
|
527
|
+
default:
|
|
528
|
+
throw new TypeError(
|
|
529
|
+
`Unrecognized directive type '${directive.type}'`,
|
|
530
|
+
);
|
|
531
|
+
}
|
|
532
|
+
})
|
|
533
|
+
.sort(compareLocations);
|
|
534
|
+
|
|
535
|
+
// This determines a list of rules that are not being run by the given ruleFilter, if present.
|
|
536
|
+
const rulesToIgnore =
|
|
537
|
+
configuredRules && ruleFilter
|
|
538
|
+
? new Set(
|
|
539
|
+
Object.keys(configuredRules).filter(ruleId => {
|
|
540
|
+
const severity = Config.getRuleNumericSeverity(
|
|
541
|
+
configuredRules[ruleId],
|
|
542
|
+
);
|
|
543
|
+
|
|
544
|
+
// Ignore for disabled rules.
|
|
545
|
+
if (severity === 0) {
|
|
546
|
+
return false;
|
|
547
|
+
}
|
|
548
|
+
|
|
549
|
+
return !ruleFilter({ severity, ruleId });
|
|
550
|
+
}),
|
|
551
|
+
)
|
|
552
|
+
: new Set();
|
|
553
|
+
|
|
554
|
+
// If no ruleId is supplied that means this directive is applied to all rules, so we can't determine if it's unused if any rules are filtered out.
|
|
555
|
+
if (rulesToIgnore.size > 0) {
|
|
556
|
+
rulesToIgnore.add(null);
|
|
557
|
+
}
|
|
558
|
+
|
|
559
|
+
const blockDirectivesResult = applyDirectives({
|
|
560
|
+
language,
|
|
561
|
+
sourceCode,
|
|
562
|
+
problems,
|
|
563
|
+
directives: blockDirectives,
|
|
564
|
+
disableFixes,
|
|
565
|
+
reportUnusedDisableDirectives,
|
|
566
|
+
rulesToIgnore,
|
|
567
|
+
});
|
|
568
|
+
const lineDirectivesResult = applyDirectives({
|
|
569
|
+
language,
|
|
570
|
+
sourceCode,
|
|
571
|
+
problems: blockDirectivesResult.problems,
|
|
572
|
+
directives: lineDirectives,
|
|
573
|
+
disableFixes,
|
|
574
|
+
reportUnusedDisableDirectives,
|
|
575
|
+
rulesToIgnore,
|
|
576
|
+
});
|
|
577
|
+
|
|
578
|
+
return reportUnusedDisableDirectives !== "off"
|
|
579
|
+
? lineDirectivesResult.problems
|
|
580
|
+
.concat(blockDirectivesResult.unusedDirectives)
|
|
581
|
+
.concat(lineDirectivesResult.unusedDirectives)
|
|
582
|
+
.sort(compareLocations)
|
|
583
|
+
: lineDirectivesResult.problems;
|
|
465
584
|
};
|