eslint 8.57.0 → 9.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "8.57.0",
+  "version": "9.2.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "bin": {
@@ -17,20 +17,24 @@
     "build:site": "node Makefile.js gensite",
     "build:webpack": "node Makefile.js webpack",
     "build:readme": "node tools/update-readme.js",
+    "build:rules-index": "node Makefile.js generateRuleIndexPage",
     "lint": "node Makefile.js lint",
     "lint:docs:js": "node Makefile.js lintDocsJS",
     "lint:docs:rule-examples": "node Makefile.js checkRuleExamples",
     "lint:fix": "node Makefile.js lint -- fix",
     "lint:fix:docs:js": "node Makefile.js lintDocsJS -- fix",
+    "lint:unused": "knip",
     "release:generate:alpha": "node Makefile.js generatePrerelease -- alpha",
     "release:generate:beta": "node Makefile.js generatePrerelease -- beta",
     "release:generate:latest": "node Makefile.js generateRelease",
     "release:generate:rc": "node Makefile.js generatePrerelease -- rc",
     "release:publish": "node Makefile.js publishRelease",
     "test": "node Makefile.js test",
+    "test:browser": "node Makefile.js wdio",
     "test:cli": "mocha",
     "test:fuzz": "node Makefile.js fuzz",
-    "test:performance": "node Makefile.js perf"
+    "test:performance": "node Makefile.js perf",
+    "test:emfile": "node tools/check-emfile-handling.js"
   },
   "gitHooks": {
     "pre-commit": "lint-staged"
@@ -47,7 +51,7 @@
       "node tools/fetch-docs-links.js",
       "git add docs/src/_data/further_reading_links.json"
     ],
-    "docs/**/*.svg": "npx svgo -r --multipass"
+    "docs/**/*.svg": "npx -y svgo -r --multipass"
   },
   "files": [
     "LICENSE",
@@ -64,34 +68,30 @@
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.2.0",
     "@eslint-community/regexpp": "^4.6.1",
-    "@eslint/eslintrc": "^2.1.4",
-    "@eslint/js": "8.57.0",
-    "@humanwhocodes/config-array": "^0.11.14",
+    "@eslint/eslintrc": "^3.0.2",
+    "@eslint/js": "9.2.0",
+    "@humanwhocodes/config-array": "^0.13.0",
     "@humanwhocodes/module-importer": "^1.0.1",
+    "@humanwhocodes/retry": "^0.2.3",
     "@nodelib/fs.walk": "^1.2.8",
-    "@ungap/structured-clone": "^1.2.0",
     "ajv": "^6.12.4",
     "chalk": "^4.0.0",
     "cross-spawn": "^7.0.2",
     "debug": "^4.3.2",
-    "doctrine": "^3.0.0",
     "escape-string-regexp": "^4.0.0",
-    "eslint-scope": "^7.2.2",
-    "eslint-visitor-keys": "^3.4.3",
-    "espree": "^9.6.1",
+    "eslint-scope": "^8.0.1",
+    "eslint-visitor-keys": "^4.0.0",
+    "espree": "^10.0.1",
     "esquery": "^1.4.2",
     "esutils": "^2.0.2",
     "fast-deep-equal": "^3.1.3",
-    "file-entry-cache": "^6.0.1",
+    "file-entry-cache": "^8.0.0",
     "find-up": "^5.0.0",
     "glob-parent": "^6.0.2",
-    "globals": "^13.19.0",
-    "graphemer": "^1.4.0",
     "ignore": "^5.2.0",
     "imurmurhash": "^0.1.4",
     "is-glob": "^4.0.0",
     "is-path-inside": "^3.0.3",
-    "js-yaml": "^4.1.0",
     "json-stable-stringify-without-jsonify": "^1.0.1",
     "levn": "^0.4.1",
     "lodash.merge": "^4.6.2",
@@ -104,6 +104,9 @@
   "devDependencies": {
     "@babel/core": "^7.4.3",
     "@babel/preset-env": "^7.4.3",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
+    "@types/estree": "^1.0.5",
+    "@types/node": "^20.11.5",
     "@wdio/browser-runner": "^8.14.6",
     "@wdio/cli": "^8.14.6",
     "@wdio/concise-reporter": "^8.14.0",
@@ -118,28 +121,29 @@
     "ejs": "^3.0.2",
     "eslint": "file:.",
     "eslint-config-eslint": "file:packages/eslint-config-eslint",
-    "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-eslint-plugin": "^5.2.1",
+    "eslint-plugin-eslint-plugin": "^6.0.0",
     "eslint-plugin-internal-rules": "file:tools/internal-rules",
-    "eslint-plugin-jsdoc": "^46.2.5",
-    "eslint-plugin-n": "^16.6.0",
-    "eslint-plugin-unicorn": "^49.0.0",
-    "eslint-release": "^3.2.0",
+    "eslint-plugin-jsdoc": "^48.2.3",
+    "eslint-plugin-n": "^17.2.0",
+    "eslint-plugin-unicorn": "^52.0.0",
+    "eslint-release": "^3.2.2",
     "eslump": "^3.0.0",
     "esprima": "^4.0.1",
     "fast-glob": "^3.2.11",
     "fs-teardown": "^0.1.3",
-    "glob": "^7.1.6",
+    "glob": "^10.0.0",
+    "globals": "^15.0.0",
     "got": "^11.8.3",
     "gray-matter": "^4.0.3",
+    "js-yaml": "^4.1.0",
+    "knip": "^5.8.0",
     "lint-staged": "^11.0.0",
     "load-perf": "^0.2.0",
     "markdown-it": "^12.2.0",
     "markdown-it-container": "^3.0.0",
-    "markdownlint": "^0.32.0",
-    "markdownlint-cli": "^0.37.0",
+    "markdownlint": "^0.34.0",
+    "markdownlint-cli": "^0.39.0",
     "marked": "^4.0.8",
-    "memfs": "^3.0.1",
     "metascraper": "^5.25.7",
     "metascraper-description": "^5.25.7",
     "metascraper-image": "^5.29.3",
@@ -147,7 +151,6 @@
     "metascraper-logo-favicon": "^5.25.7",
     "metascraper-title": "^5.25.7",
     "mocha": "^8.3.2",
-    "mocha-junit-reporter": "^2.0.0",
     "node-polyfill-webpack-plugin": "^1.0.3",
     "npm-license": "^0.3.3",
     "pirates": "^4.0.5",
@@ -157,10 +160,10 @@
     "regenerator-runtime": "^0.14.0",
     "rollup-plugin-node-polyfills": "^0.2.1",
     "semver": "^7.5.3",
-    "shelljs": "^0.8.2",
+    "shelljs": "^0.8.5",
     "sinon": "^11.0.0",
+    "typescript": "^5.3.3",
     "vite-plugin-commonjs": "^0.10.0",
-    "webdriverio": "^8.14.6",
     "webpack": "^5.23.0",
     "webpack-cli": "^4.5.0",
     "yorkie": "^2.0.0"
@@ -174,6 +177,6 @@
   ],
   "license": "MIT",
   "engines": {
-    "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
+    "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
   }
 }

package/conf/config-schema.js

@@ -1,93 +0,0 @@
-/*
- * STOP!!! DO NOT MODIFY.
- *
- * This file is part of the ongoing work to move the eslintrc-style config
- * system into the @eslint/eslintrc package. This file needs to remain
- * unchanged in order for this work to proceed.
- *
- * If you think you need to change this file, please contact @nzakas first.
- *
- * Thanks in advance for your cooperation.
- */
-
-/**
- * @fileoverview Defines a schema for configs.
- * @author Sylvan Mably
- */
-
-"use strict";
-
-const baseConfigProperties = {
-    $schema: { type: "string" },
-    env: { type: "object" },
-    extends: { $ref: "#/definitions/stringOrStrings" },
-    globals: { type: "object" },
-    overrides: {
-        type: "array",
-        items: { $ref: "#/definitions/overrideConfig" },
-        additionalItems: false
-    },
-    parser: { type: ["string", "null"] },
-    parserOptions: { type: "object" },
-    plugins: { type: "array" },
-    processor: { type: "string" },
-    rules: { type: "object" },
-    settings: { type: "object" },
-    noInlineConfig: { type: "boolean" },
-    reportUnusedDisableDirectives: { type: "boolean" },
-
-    ecmaFeatures: { type: "object" } // deprecated; logs a warning when used
-};
-
-const configSchema = {
-    definitions: {
-        stringOrStrings: {
-            oneOf: [
-                { type: "string" },
-                {
-                    type: "array",
-                    items: { type: "string" },
-                    additionalItems: false
-                }
-            ]
-        },
-        stringOrStringsRequired: {
-            oneOf: [
-                { type: "string" },
-                {
-                    type: "array",
-                    items: { type: "string" },
-                    additionalItems: false,
-                    minItems: 1
-                }
-            ]
-        },
-
-        // Config at top-level.
-        objectConfig: {
-            type: "object",
-            properties: {
-                root: { type: "boolean" },
-                ignorePatterns: { $ref: "#/definitions/stringOrStrings" },
-                ...baseConfigProperties
-            },
-            additionalProperties: false
-        },
-
-        // Config in `overrides`.
-        overrideConfig: {
-            type: "object",
-            properties: {
-                excludedFiles: { $ref: "#/definitions/stringOrStrings" },
-                files: { $ref: "#/definitions/stringOrStringsRequired" },
-                ...baseConfigProperties
-            },
-            required: ["files"],
-            additionalProperties: false
-        }
-    },
-
-    $ref: "#/definitions/objectConfig"
-};
-
-module.exports = configSchema;

package/lib/cli-engine/formatters/checkstyle.js

@@ -1,60 +0,0 @@
-/**
- * @fileoverview CheckStyle XML reporter
- * @author Ian Christian Myers
- */
-"use strict";
-
-const xmlEscape = require("../xml-escape");
-
-//------------------------------------------------------------------------------
-// Helper Functions
-//------------------------------------------------------------------------------
-
-/**
- * Returns the severity of warning or error
- * @param {Object} message message object to examine
- * @returns {string} severity level
- * @private
- */
-function getMessageType(message) {
-    if (message.fatal || message.severity === 2) {
-        return "error";
-    }
-    return "warning";
-
-}
-
-//------------------------------------------------------------------------------
-// Public Interface
-//------------------------------------------------------------------------------
-
-module.exports = function(results) {
-
-    let output = "";
-
-    output += "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
-    output += "<checkstyle version=\"4.3\">";
-
-    results.forEach(result => {
-        const messages = result.messages;
-
-        output += `<file name="${xmlEscape(result.filePath)}">`;
-
-        messages.forEach(message => {
-            output += [
-                `<error line="${xmlEscape(message.line || 0)}"`,
-                `column="${xmlEscape(message.column || 0)}"`,
-                `severity="${xmlEscape(getMessageType(message))}"`,
-                `message="${xmlEscape(message.message)}${message.ruleId ? ` (${message.ruleId})` : ""}"`,
-                `source="${message.ruleId ? xmlEscape(`eslint.rules.${message.ruleId}`) : ""}" />`
-            ].join(" ");
-        });
-
-        output += "</file>";
-
-    });
-
-    output += "</checkstyle>";
-
-    return output;
-};

package/lib/cli-engine/formatters/compact.js

@@ -1,60 +0,0 @@
-/**
- * @fileoverview Compact reporter
- * @author Nicholas C. Zakas
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Helper Functions
-//------------------------------------------------------------------------------
-
-/**
- * Returns the severity of warning or error
- * @param {Object} message message object to examine
- * @returns {string} severity level
- * @private
- */
-function getMessageType(message) {
-    if (message.fatal || message.severity === 2) {
-        return "Error";
-    }
-    return "Warning";
-
-}
-
-
-//------------------------------------------------------------------------------
-// Public Interface
-//------------------------------------------------------------------------------
-
-module.exports = function(results) {
-
-    let output = "",
-        total = 0;
-
-    results.forEach(result => {
-
-        const messages = result.messages;
-
-        total += messages.length;
-
-        messages.forEach(message => {
-
-            output += `${result.filePath}: `;
-            output += `line ${message.line || 0}`;
-            output += `, col ${message.column || 0}`;
-            output += `, ${getMessageType(message)}`;
-            output += ` - ${message.message}`;
-            output += message.ruleId ? ` (${message.ruleId})` : "";
-            output += "\n";
-
-        });
-
-    });
-
-    if (total > 0) {
-        output += `\n${total} problem${total !== 1 ? "s" : ""}`;
-    }
-
-    return output;
-};

package/lib/cli-engine/formatters/jslint-xml.js

@@ -1,41 +0,0 @@
-/**
- * @fileoverview JSLint XML reporter
- * @author Ian Christian Myers
- */
-"use strict";
-
-const xmlEscape = require("../xml-escape");
-
-//------------------------------------------------------------------------------
-// Public Interface
-//------------------------------------------------------------------------------
-
-module.exports = function(results) {
-
-    let output = "";
-
-    output += "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
-    output += "<jslint>";
-
-    results.forEach(result => {
-        const messages = result.messages;
-
-        output += `<file name="${result.filePath}">`;
-
-        messages.forEach(message => {
-            output += [
-                `<issue line="${message.line}"`,
-                `char="${message.column}"`,
-                `evidence="${xmlEscape(message.source || "")}"`,
-                `reason="${xmlEscape(message.message || "")}${message.ruleId ? ` (${message.ruleId})` : ""}" />`
-            ].join(" ");
-        });
-
-        output += "</file>";
-
-    });
-
-    output += "</jslint>";
-
-    return output;
-};

package/lib/cli-engine/formatters/junit.js

@@ -1,82 +0,0 @@
-/**
- * @fileoverview jUnit Reporter
- * @author Jamund Ferguson
- */
-"use strict";
-
-const xmlEscape = require("../xml-escape");
-const path = require("path");
-
-//------------------------------------------------------------------------------
-// Helper Functions
-//------------------------------------------------------------------------------
-
-/**
- * Returns the severity of warning or error
- * @param {Object} message message object to examine
- * @returns {string} severity level
- * @private
- */
-function getMessageType(message) {
-    if (message.fatal || message.severity === 2) {
-        return "Error";
-    }
-    return "Warning";
-
-}
-
-/**
- * Returns a full file path without extension
- * @param {string} filePath input file path
- * @returns {string} file path without extension
- * @private
- */
-function pathWithoutExt(filePath) {
-    return path.join(path.dirname(filePath), path.basename(filePath, path.extname(filePath)));
-}
-
-//------------------------------------------------------------------------------
-// Public Interface
-//------------------------------------------------------------------------------
-
-module.exports = function(results) {
-
-    let output = "";
-
-    output += "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
-    output += "<testsuites>\n";
-
-    results.forEach(result => {
-
-        const messages = result.messages;
-        const classname = pathWithoutExt(result.filePath);
-
-        if (messages.length > 0) {
-            output += `<testsuite package="org.eslint" time="0" tests="${messages.length}" errors="${messages.length}" name="${result.filePath}">\n`;
-            messages.forEach(message => {
-                const type = message.fatal ? "error" : "failure";
-
-                output += `<testcase time="0" name="org.eslint.${message.ruleId || "unknown"}" classname="${classname}">`;
-                output += `<${type} message="${xmlEscape(message.message || "")}">`;
-                output += "<![CDATA[";
-                output += `line ${message.line || 0}, col `;
-                output += `${message.column || 0}, ${getMessageType(message)}`;
-                output += ` - ${xmlEscape(message.message || "")}`;
-                output += (message.ruleId ? ` (${message.ruleId})` : "");
-                output += "]]>";
-                output += `</${type}>`;
-                output += "</testcase>\n";
-            });
-            output += "</testsuite>\n";
-        } else {
-            output += `<testsuite package="org.eslint" time="0" tests="1" errors="0" name="${result.filePath}">\n`;
-            output += `<testcase time="0" name="${result.filePath}" classname="${classname}" />\n`;
-            output += "</testsuite>\n";
-        }
-
-    });
-
-    output += "</testsuites>\n";
-
-    return output;
-};

package/lib/cli-engine/formatters/tap.js

@@ -1,95 +0,0 @@
-/**
- * @fileoverview TAP reporter
- * @author Jonathan Kingston
- */
-"use strict";
-
-const yaml = require("js-yaml");
-
-//------------------------------------------------------------------------------
-// Helper Functions
-//------------------------------------------------------------------------------
-
-/**
- * Returns a canonical error level string based upon the error message passed in.
- * @param {Object} message Individual error message provided by eslint
- * @returns {string} Error level string
- */
-function getMessageType(message) {
-    if (message.fatal || message.severity === 2) {
-        return "error";
-    }
-    return "warning";
-}
-
-/**
- * Takes in a JavaScript object and outputs a TAP diagnostics string
- * @param {Object} diagnostic JavaScript object to be embedded as YAML into output.
- * @returns {string} diagnostics string with YAML embedded - TAP version 13 compliant
- */
-function outputDiagnostics(diagnostic) {
-    const prefix = "  ";
-    let output = `${prefix}---\n`;
-
-    output += prefix + yaml.dump(diagnostic).split("\n").join(`\n${prefix}`);
-    output += "...\n";
-    return output;
-}
-
-//------------------------------------------------------------------------------
-// Public Interface
-//------------------------------------------------------------------------------
-
-module.exports = function(results) {
-    let output = `TAP version 13\n1..${results.length}\n`;
-
-    results.forEach((result, id) => {
-        const messages = result.messages;
-        let testResult = "ok";
-        let diagnostics = {};
-
-        if (messages.length > 0) {
-            messages.forEach(message => {
-                const severity = getMessageType(message);
-                const diagnostic = {
-                    message: message.message,
-                    severity,
-                    data: {
-                        line: message.line || 0,
-                        column: message.column || 0,
-                        ruleId: message.ruleId || ""
-                    }
-                };
-
-                // This ensures a warning message is not flagged as error
-                if (severity === "error") {
-                    testResult = "not ok";
-                }
-
-                /*
-                 * If we have multiple messages place them under a messages key
-                 * The first error will be logged as message key
-                 * This is to adhere to TAP 13 loosely defined specification of having a message key
-                 */
-                if ("message" in diagnostics) {
-                    if (typeof diagnostics.messages === "undefined") {
-                        diagnostics.messages = [];
-                    }
-                    diagnostics.messages.push(diagnostic);
-                } else {
-                    diagnostics = diagnostic;
-                }
-            });
-        }
-
-        output += `${testResult} ${id + 1} - ${result.filePath}\n`;
-
-        // If we have an error include diagnostics
-        if (messages.length > 0) {
-            output += outputDiagnostics(diagnostics);
-        }
-
-    });
-
-    return output;
-};

package/lib/cli-engine/formatters/unix.js

@@ -1,58 +0,0 @@
-/**
- * @fileoverview unix-style formatter.
- * @author oshi-shinobu
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Helper Functions
-//------------------------------------------------------------------------------
-
-/**
- * Returns a canonical error level string based upon the error message passed in.
- * @param {Object} message Individual error message provided by eslint
- * @returns {string} Error level string
- */
-function getMessageType(message) {
-    if (message.fatal || message.severity === 2) {
-        return "Error";
-    }
-    return "Warning";
-
-}
-
-
-//------------------------------------------------------------------------------
-// Public Interface
-//------------------------------------------------------------------------------
-
-module.exports = function(results) {
-
-    let output = "",
-        total = 0;
-
-    results.forEach(result => {
-
-        const messages = result.messages;
-
-        total += messages.length;
-
-        messages.forEach(message => {
-
-            output += `${result.filePath}:`;
-            output += `${message.line || 0}:`;
-            output += `${message.column || 0}:`;
-            output += ` ${message.message} `;
-            output += `[${getMessageType(message)}${message.ruleId ? `/${message.ruleId}` : ""}]`;
-            output += "\n";
-
-        });
-
-    });
-
-    if (total > 0) {
-        output += `\n${total} problem${total !== 1 ? "s" : ""}`;
-    }
-
-    return output;
-};