eslint 8.57.0 → 9.2.0

package/lib/rules/no-implicit-coercion.js

@@ -12,7 +12,7 @@ const astUtils = require("./utils/ast-utils");
 //------------------------------------------------------------------------------
 
 const INDEX_OF_PATTERN = /^(?:i|lastI)ndexOf$/u;
-const ALLOWABLE_OPERATORS = ["~", "!!", "+", "*"];
+const ALLOWABLE_OPERATORS = ["~", "!!", "+", "- -", "-", "*"];
 
 /**
  * Parses and normalizes an option object.
@@ -188,6 +188,7 @@ function getNonEmptyOperand(node) {
 /** @type {import('../shared/types').Rule} */
 module.exports = {
     meta: {
+        hasSuggestions: true,
         type: "suggestion",
 
         docs: {
@@ -229,7 +230,8 @@ module.exports = {
         }],
 
         messages: {
-            useRecommendation: "use `{{recommendation}}` instead."
+            implicitCoercion: "Unexpected implicit coercion encountered. Use `{{recommendation}}` instead.",
+            useRecommendation: "Use `{{recommendation}}` instead."
         }
     },
 
@@ -241,32 +243,54 @@ module.exports = {
          * Reports an error and autofixes the node
          * @param {ASTNode} node An ast node to report the error on.
          * @param {string} recommendation The recommended code for the issue
+         * @param {bool} shouldSuggest Whether this report should offer a suggestion
          * @param {bool} shouldFix Whether this report should fix the node
          * @returns {void}
          */
-        function report(node, recommendation, shouldFix) {
+        function report(node, recommendation, shouldSuggest, shouldFix) {
+
+            /**
+             * Fix function
+             * @param {RuleFixer} fixer The fixer to fix.
+             * @returns {Fix} The fix object.
+             */
+            function fix(fixer) {
+                const tokenBefore = sourceCode.getTokenBefore(node);
+
+                if (
+                    tokenBefore?.range[1] === node.range[0] &&
+                    !astUtils.canTokensBeAdjacent(tokenBefore, recommendation)
+                ) {
+                    return fixer.replaceText(node, ` ${recommendation}`);
+                }
+
+                return fixer.replaceText(node, recommendation);
+            }
+
             context.report({
                 node,
-                messageId: "useRecommendation",
-                data: {
-                    recommendation
-                },
+                messageId: "implicitCoercion",
+                data: { recommendation },
                 fix(fixer) {
                     if (!shouldFix) {
                         return null;
                     }
 
-                    const tokenBefore = sourceCode.getTokenBefore(node);
-
-                    if (
-                        tokenBefore &&
-                        tokenBefore.range[1] === node.range[0] &&
-                        !astUtils.canTokensBeAdjacent(tokenBefore, recommendation)
-                    ) {
-                        return fixer.replaceText(node, ` ${recommendation}`);
+                    return fix(fixer);
+                },
+                suggest: [
+                    {
+                        messageId: "useRecommendation",
+                        data: { recommendation },
+                        fix(fixer) {
+                            if (shouldFix || !shouldSuggest) {
+                                return null;
+                            }
+
+                            return fix(fixer);
+                        }
                     }
-                    return fixer.replaceText(node, recommendation);
-                }
+                ]
             });
         }
 
@@ -278,8 +302,10 @@ module.exports = {
                 operatorAllowed = options.allow.includes("!!");
                 if (!operatorAllowed && options.boolean && isDoubleLogicalNegating(node)) {
                     const recommendation = `Boolean(${sourceCode.getText(node.argument.argument)})`;
+                    const variable = astUtils.getVariableByName(sourceCode.getScope(node), "Boolean");
+                    const booleanExists = variable?.identifiers.length === 0;
 
-                    report(node, recommendation, true);
+                    report(node, recommendation, true, booleanExists);
                 }
 
                 // ~foo.indexOf(bar)
@@ -290,7 +316,7 @@ module.exports = {
                     const comparison = node.argument.type === "ChainExpression" ? ">= 0" : "!== -1";
                     const recommendation = `${sourceCode.getText(node.argument)} ${comparison}`;
 
-                    report(node, recommendation, false);
+                    report(node, recommendation, false, false);
                 }
 
                 // +foo
@@ -298,7 +324,15 @@ module.exports = {
                 if (!operatorAllowed && options.number && node.operator === "+" && !isNumeric(node.argument)) {
                     const recommendation = `Number(${sourceCode.getText(node.argument)})`;
 
-                    report(node, recommendation, true);
+                    report(node, recommendation, true, false);
+                }
+
+                // -(-foo)
+                operatorAllowed = options.allow.includes("- -");
+                if (!operatorAllowed && options.number && node.operator === "-" && node.argument.type === "UnaryExpression" && node.argument.operator === "-" && !isNumeric(node.argument.argument)) {
+                    const recommendation = `Number(${sourceCode.getText(node.argument.argument)})`;
+
+                    report(node, recommendation, true, false);
                 }
             },
 
@@ -314,7 +348,15 @@ module.exports = {
                 if (nonNumericOperand) {
                     const recommendation = `Number(${sourceCode.getText(nonNumericOperand)})`;
 
-                    report(node, recommendation, true);
+                    report(node, recommendation, true, false);
+                }
+
+                // foo - 0
+                operatorAllowed = options.allow.includes("-");
+                if (!operatorAllowed && options.number && node.operator === "-" && node.right.type === "Literal" && node.right.value === 0 && !isNumeric(node.left)) {
+                    const recommendation = `Number(${sourceCode.getText(node.left)})`;
+
+                    report(node, recommendation, true, false);
                 }
 
                 // "" + foo
@@ -322,7 +364,7 @@ module.exports = {
                 if (!operatorAllowed && options.string && isConcatWithEmptyString(node)) {
                     const recommendation = `String(${sourceCode.getText(getNonEmptyOperand(node))})`;
 
-                    report(node, recommendation, true);
+                    report(node, recommendation, true, false);
                 }
             },
 
@@ -335,7 +377,7 @@ module.exports = {
                     const code = sourceCode.getText(getNonEmptyOperand(node));
                     const recommendation = `${code} = String(${code})`;
 
-                    report(node, recommendation, true);
+                    report(node, recommendation, true, false);
                 }
             },
 
@@ -373,7 +415,7 @@ module.exports = {
                 const code = sourceCode.getText(node.expressions[0]);
                 const recommendation = `String(${code})`;
 
-                report(node, recommendation, true);
+                report(node, recommendation, true, false);
             }
         };
     }

package/lib/rules/no-inner-declarations.js

@@ -49,13 +49,22 @@ module.exports = {
 
         docs: {
             description: "Disallow variable or `function` declarations in nested blocks",
-            recommended: true,
+            recommended: false,
             url: "https://eslint.org/docs/latest/rules/no-inner-declarations"
         },
 
         schema: [
             {
                 enum: ["functions", "both"]
+            },
+            {
+                type: "object",
+                properties: {
+                    blockScopedFunctions: {
+                        enum: ["allow", "disallow"]
+                    }
+                },
+                additionalProperties: false
             }
         ],
 
@@ -66,6 +75,10 @@ module.exports = {
 
     create(context) {
 
+        const sourceCode = context.sourceCode;
+        const ecmaVersion = context.languageOptions.ecmaVersion;
+        const blockScopedFunctions = context.options[1]?.blockScopedFunctions ?? "allow";
+
         /**
          * Ensure that a given node is at a program or function body's root.
          * @param {ASTNode} node Declaration node to check.
@@ -97,7 +110,15 @@ module.exports = {
 
         return {
 
-            FunctionDeclaration: check,
+            FunctionDeclaration(node) {
+                const isInStrictCode = sourceCode.getScope(node).upper.isStrict;
+
+                if (blockScopedFunctions === "allow" && ecmaVersion >= 2015 && isInStrictCode) {
+                    return;
+                }
+
+                check(node);
+            },
             VariableDeclaration(node) {
                 if (context.options[0] === "both" && node.kind === "var") {
                     check(node);

package/lib/rules/no-invalid-regexp.js

@@ -55,7 +55,7 @@ module.exports = {
             const temp = options.allowConstructorFlags.join("").replace(validFlags, "");
 
             if (temp) {
-                allowedFlags = new RegExp(`[${temp}]`, "giu");
+                allowedFlags = new RegExp(`[${temp}]`, "gu");
             }
         }
 

package/lib/rules/no-invalid-this.js

@@ -74,7 +74,7 @@ module.exports = {
          *   an object which has a flag that whether or not `this` keyword is valid.
          */
         stack.getCurrent = function() {
-            const current = this[this.length - 1];
+            const current = this.at(-1);
 
             if (!current.init) {
                 current.init = true;

package/lib/rules/no-lone-blocks.js

@@ -78,7 +78,7 @@ module.exports = {
 
             const block = node.parent;
 
-            if (loneBlocks[loneBlocks.length - 1] === block) {
+            if (loneBlocks.at(-1) === block) {
                 loneBlocks.pop();
             }
         }
@@ -101,7 +101,7 @@ module.exports = {
                     }
                 },
                 "BlockStatement:exit"(node) {
-                    if (loneBlocks.length > 0 && loneBlocks[loneBlocks.length - 1] === node) {
+                    if (loneBlocks.length > 0 && loneBlocks.at(-1) === node) {
                         loneBlocks.pop();
                         report(node);
                     } else if (
@@ -117,7 +117,7 @@ module.exports = {
             };
 
             ruleDef.VariableDeclaration = function(node) {
-                if (node.kind === "let" || node.kind === "const") {
+                if (node.kind !== "var") {
                     markLoneBlock(node);
                 }
             };

package/lib/rules/no-loss-of-precision.js

@@ -64,7 +64,7 @@ module.exports = {
          */
         function notBaseTenLosesPrecision(node) {
             const rawString = getRaw(node).toUpperCase();
-            let base = 0;
+            let base;
 
             if (rawString.startsWith("0B")) {
                 base = 2;

package/lib/rules/no-misleading-character-class.js

@@ -3,11 +3,18 @@
  */
 "use strict";
 
-const { CALL, CONSTRUCT, ReferenceTracker, getStringIfConstant } = require("@eslint-community/eslint-utils");
+const {
+    CALL,
+    CONSTRUCT,
+    ReferenceTracker,
+    getStaticValue,
+    getStringIfConstant
+} = require("@eslint-community/eslint-utils");
 const { RegExpParser, visitRegExpAST } = require("@eslint-community/regexpp");
 const { isCombiningCharacter, isEmojiModifier, isRegionalIndicatorSymbol, isSurrogatePair } = require("./utils/unicode");
 const astUtils = require("./utils/ast-utils.js");
 const { isValidWithUnicodeFlag } = require("./utils/regular-expressions");
+const { parseStringLiteral, parseTemplateToken } = require("./utils/char-source");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -62,7 +69,6 @@ function *iterateCharacterSequence(nodes) {
     }
 }
 
-
 /**
  * Checks whether the given character node is a Unicode code point escape or not.
  * @param {Character} char the character node to check.
@@ -73,80 +79,153 @@ function isUnicodeCodePointEscape(char) {
 }
 
 /**
- * Each function returns `true` if it detects that kind of problem.
- * @type {Record<string, (chars: Character[]) => boolean>}
+ * Each function returns matched characters if it detects that kind of problem.
+ * @type {Record<string, (chars: Character[]) => IterableIterator<Character[]>>}
  */
-const hasCharacterSequence = {
-    surrogatePairWithoutUFlag(chars) {
-        return chars.some((c, i) => {
-            if (i === 0) {
-                return false;
+const findCharacterSequences = {
+    *surrogatePairWithoutUFlag(chars) {
+        for (const [index, char] of chars.entries()) {
+            if (index === 0) {
+                continue;
+            }
+            const previous = chars[index - 1];
+
+            if (
+                isSurrogatePair(previous.value, char.value) &&
+                !isUnicodeCodePointEscape(previous) &&
+                !isUnicodeCodePointEscape(char)
+            ) {
+                yield [previous, char];
             }
-            const c1 = chars[i - 1];
-
-            return (
-                isSurrogatePair(c1.value, c.value) &&
-                !isUnicodeCodePointEscape(c1) &&
-                !isUnicodeCodePointEscape(c)
-            );
-        });
+        }
     },
 
-    surrogatePair(chars) {
-        return chars.some((c, i) => {
-            if (i === 0) {
-                return false;
+    *surrogatePair(chars) {
+        for (const [index, char] of chars.entries()) {
+            if (index === 0) {
+                continue;
             }
-            const c1 = chars[i - 1];
+            const previous = chars[index - 1];
 
-            return (
-                isSurrogatePair(c1.value, c.value) &&
+            if (
+                isSurrogatePair(previous.value, char.value) &&
                 (
-                    isUnicodeCodePointEscape(c1) ||
-                    isUnicodeCodePointEscape(c)
+                    isUnicodeCodePointEscape(previous) ||
+                    isUnicodeCodePointEscape(char)
                 )
-            );
-        });
+            ) {
+                yield [previous, char];
+            }
+        }
     },
 
-    combiningClass(chars) {
-        return chars.some((c, i) => (
-            i !== 0 &&
-            isCombiningCharacter(c.value) &&
-            !isCombiningCharacter(chars[i - 1].value)
-        ));
+    *combiningClass(chars) {
+        for (const [index, char] of chars.entries()) {
+            if (index === 0) {
+                continue;
+            }
+            const previous = chars[index - 1];
+
+            if (
+                isCombiningCharacter(char.value) &&
+                !isCombiningCharacter(previous.value)
+            ) {
+                yield [previous, char];
+            }
+        }
     },
 
-    emojiModifier(chars) {
-        return chars.some((c, i) => (
-            i !== 0 &&
-            isEmojiModifier(c.value) &&
-            !isEmojiModifier(chars[i - 1].value)
-        ));
+    *emojiModifier(chars) {
+        for (const [index, char] of chars.entries()) {
+            if (index === 0) {
+                continue;
+            }
+            const previous = chars[index - 1];
+
+            if (
+                isEmojiModifier(char.value) &&
+                !isEmojiModifier(previous.value)
+            ) {
+                yield [previous, char];
+            }
+        }
     },
 
-    regionalIndicatorSymbol(chars) {
-        return chars.some((c, i) => (
-            i !== 0 &&
-            isRegionalIndicatorSymbol(c.value) &&
-            isRegionalIndicatorSymbol(chars[i - 1].value)
-        ));
+    *regionalIndicatorSymbol(chars) {
+        for (const [index, char] of chars.entries()) {
+            if (index === 0) {
+                continue;
+            }
+            const previous = chars[index - 1];
+
+            if (
+                isRegionalIndicatorSymbol(char.value) &&
+                isRegionalIndicatorSymbol(previous.value)
+            ) {
+                yield [previous, char];
+            }
+        }
     },
 
-    zwj(chars) {
-        const lastIndex = chars.length - 1;
+    *zwj(chars) {
+        let sequence = null;
+
+        for (const [index, char] of chars.entries()) {
+            if (index === 0 || index === chars.length - 1) {
+                continue;
+            }
+            if (
+                char.value === 0x200d &&
+                chars[index - 1].value !== 0x200d &&
+                chars[index + 1].value !== 0x200d
+            ) {
+                if (sequence) {
+                    if (sequence.at(-1) === chars[index - 1]) {
+                        sequence.push(char, chars[index + 1]); // append to the sequence
+                    } else {
+                        yield sequence;
+                        sequence = chars.slice(index - 1, index + 2);
+                    }
+                } else {
+                    sequence = chars.slice(index - 1, index + 2);
+                }
+            }
+        }
 
-        return chars.some((c, i) => (
-            i !== 0 &&
-            i !== lastIndex &&
-            c.value === 0x200d &&
-            chars[i - 1].value !== 0x200d &&
-            chars[i + 1].value !== 0x200d
-        ));
+        if (sequence) {
+            yield sequence;
+        }
     }
 };
 
-const kinds = Object.keys(hasCharacterSequence);
+const kinds = Object.keys(findCharacterSequences);
+
+/**
+ * Gets the value of the given node if it's a static value other than a regular expression object,
+ * or the node's `regex` property.
+ * The purpose of this method is to provide a replacement for `getStaticValue` in environments where certain regular expressions cannot be evaluated.
+ * A known example is Node.js 18 which does not support the `v` flag.
+ * Calling `getStaticValue` on a regular expression node with the `v` flag on Node.js 18 always returns `null`.
+ * A limitation of this method is that it can only detect a regular expression if the specified node is itself a regular expression literal node.
+ * @param {ASTNode | undefined} node The node to be inspected.
+ * @param {Scope} initialScope Scope to start finding variables. This function tries to resolve identifier references which are in the given scope.
+ * @returns {{ value: any } | { regex: { pattern: string, flags: string } } | null} The static value of the node, or `null`.
+ */
+function getStaticValueOrRegex(node, initialScope) {
+    if (!node) {
+        return null;
+    }
+    if (node.type === "Literal" && node.regex) {
+        return { regex: node.regex };
+    }
+
+    const staticValue = getStaticValue(node, initialScope);
+
+    if (staticValue?.value instanceof RegExp) {
+        return null;
+    }
+    return staticValue;
+}
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -180,6 +259,7 @@ module.exports = {
     create(context) {
         const sourceCode = context.sourceCode;
         const parser = new RegExpParser();
+        const checkedPatternNodes = new Set();
 
         /**
          * Verify a given regular expression.
@@ -208,21 +288,70 @@ module.exports = {
                 return;
             }
 
-            const foundKinds = new Set();
+            const foundKindMatches = new Map();
 
             visitRegExpAST(patternNode, {
                 onCharacterClassEnter(ccNode) {
                     for (const chars of iterateCharacterSequence(ccNode.elements)) {
                         for (const kind of kinds) {
-                            if (hasCharacterSequence[kind](chars)) {
-                                foundKinds.add(kind);
+                            if (foundKindMatches.has(kind)) {
+                                foundKindMatches.get(kind).push(...findCharacterSequences[kind](chars));
+                            } else {
+                                foundKindMatches.set(kind, [...findCharacterSequences[kind](chars)]);
                             }
                         }
                     }
                 }
             });
 
-            for (const kind of foundKinds) {
+            let codeUnits = null;
+
+            /**
+             * Finds the report loc(s) for a range of matches.
+             * Only literals and expression-less templates generate granular errors.
+             * @param {Character[][]} matches Lists of individual characters being reported on.
+             * @returns {Location[]} locs for context.report.
+             * @see https://github.com/eslint/eslint/pull/17515
+             */
+            function getNodeReportLocations(matches) {
+                if (!astUtils.isStaticTemplateLiteral(node) && node.type !== "Literal") {
+                    return matches.length ? [node.loc] : [];
+                }
+                return matches.map(chars => {
+                    const firstIndex = chars[0].start;
+                    const lastIndex = chars.at(-1).end - 1;
+                    let start;
+                    let end;
+
+                    if (node.type === "TemplateLiteral") {
+                        const source = sourceCode.getText(node);
+                        const offset = node.range[0];
+
+                        codeUnits ??= parseTemplateToken(source);
+                        start = offset + codeUnits[firstIndex].start;
+                        end = offset + codeUnits[lastIndex].end;
+                    } else if (typeof node.value === "string") { // String Literal
+                        const source = node.raw;
+                        const offset = node.range[0];
+
+                        codeUnits ??= parseStringLiteral(source);
+                        start = offset + codeUnits[firstIndex].start;
+                        end = offset + codeUnits[lastIndex].end;
+                    } else { // RegExp Literal
+                        const offset = node.range[0] + 1; // Add 1 to skip the leading slash.
+
+                        start = offset + firstIndex;
+                        end = offset + lastIndex + 1;
+                    }
+
+                    return {
+                        start: sourceCode.getLocFromIndex(start),
+                        end: sourceCode.getLocFromIndex(end)
+                    };
+                });
+            }
+
+            for (const [kind, matches] of foundKindMatches) {
                 let suggest;
 
                 if (kind === "surrogatePairWithoutUFlag") {
@@ -232,16 +361,24 @@ module.exports = {
                     }];
                 }
 
-                context.report({
-                    node,
-                    messageId: kind,
-                    suggest
-                });
+                const locs = getNodeReportLocations(matches);
+
+                for (const loc of locs) {
+                    context.report({
+                        node,
+                        loc,
+                        messageId: kind,
+                        suggest
+                    });
+                }
             }
         }
 
         return {
             "Literal[regex]"(node) {
+                if (checkedPatternNodes.has(node)) {
+                    return;
+                }
                 verify(node, node.regex.pattern, node.regex.flags, fixer => {
                     if (!isValidWithUnicodeFlag(context.languageOptions.ecmaVersion, node.regex.pattern)) {
                         return null;
@@ -262,12 +399,31 @@ module.exports = {
                 for (const { node: refNode } of tracker.iterateGlobalReferences({
                     RegExp: { [CALL]: true, [CONSTRUCT]: true }
                 })) {
+                    let pattern, flags;
                     const [patternNode, flagsNode] = refNode.arguments;
-                    const pattern = getStringIfConstant(patternNode, scope);
-                    const flags = getStringIfConstant(flagsNode, scope);
+                    const evaluatedPattern = getStaticValueOrRegex(patternNode, scope);
+
+                    if (!evaluatedPattern) {
+                        continue;
+                    }
+                    if (flagsNode) {
+                        if (evaluatedPattern.regex) {
+                            pattern = evaluatedPattern.regex.pattern;
+                            checkedPatternNodes.add(patternNode);
+                        } else {
+                            pattern = String(evaluatedPattern.value);
+                        }
+                        flags = getStringIfConstant(flagsNode, scope);
+                    } else {
+                        if (evaluatedPattern.regex) {
+                            continue;
+                        }
+                        pattern = String(evaluatedPattern.value);
+                        flags = "";
+                    }
 
-                    if (typeof pattern === "string") {
-                        verify(refNode, pattern, flags || "", fixer => {
+                    if (typeof flags === "string") {
+                        verify(patternNode, pattern, flags, fixer => {
 
                             if (!isValidWithUnicodeFlag(context.languageOptions.ecmaVersion, pattern)) {
                                 return null;

package/lib/rules/no-mixed-spaces-and-tabs.js

@@ -18,7 +18,7 @@ module.exports = {
 
         docs: {
             description: "Disallow mixed spaces and tabs for indentation",
-            recommended: true,
+            recommended: false,
             url: "https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs"
         },