eslint 8.57.0 → 9.2.0

package/lib/rules/key-spacing.js

@@ -28,7 +28,7 @@ function containsLineTerminator(str) {
  * @returns {any} Last element of arr.
  */
 function last(arr) {
-    return arr[arr.length - 1];
+    return arr.at(-1);
 }
 
 /**
@@ -489,7 +489,7 @@ module.exports = {
                     }
                 }
 
-                let messageId = "";
+                let messageId;
 
                 if (isExtra) {
                     messageId = side === "key" ? "extraKey" : "extraValue";

package/lib/rules/line-comment-position.js

@@ -68,7 +68,7 @@ module.exports = {
             above = !options.position || options.position === "above";
             ignorePattern = options.ignorePattern;
 
-            if (Object.prototype.hasOwnProperty.call(options, "applyDefaultIgnorePatterns")) {
+            if (Object.hasOwn(options, "applyDefaultIgnorePatterns")) {
                 applyDefaultIgnorePatterns = options.applyDefaultIgnorePatterns;
             } else {
                 applyDefaultIgnorePatterns = options.applyDefaultPatterns !== false;

package/lib/rules/lines-around-directive.js

@@ -166,7 +166,7 @@ module.exports = {
                 reportError(firstDirective, "before", false);
             }
 
-            const lastDirective = directives[directives.length - 1];
+            const lastDirective = directives.at(-1);
             const statements = node.type === "Program" ? node.body : node.body.body;
 
             /*
@@ -174,7 +174,7 @@ module.exports = {
              * contains a directive prologue and isn't followed by a comment to ensure
              * this rule behaves well with padded-blocks.
              */
-            if (lastDirective === statements[statements.length - 1] && !lastDirective.trailingComments) {
+            if (lastDirective === statements.at(-1) && !lastDirective.trailingComments) {
                 return;
             }
 

package/lib/rules/max-depth.js

@@ -61,7 +61,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             maxDepth = option.maximum || option.max;
         }

package/lib/rules/max-len.js

@@ -124,7 +124,7 @@ module.exports = {
         }
 
         // The options object must be the last option specified…
-        const options = Object.assign({}, context.options[context.options.length - 1]);
+        const options = Object.assign({}, context.options.at(-1));
 
         // …but max code length…
         if (typeof context.options[0] === "number") {
@@ -290,7 +290,7 @@ module.exports = {
                     if (isJSXEmptyExpressionInSingleLineContainer(containingNode)) {
 
                         // push a unique node only
-                        if (comments[comments.length - 1] !== containingNode.parent) {
+                        if (comments.at(-1) !== containingNode.parent) {
                             comments.push(containingNode.parent);
                         }
                     } else {
@@ -344,7 +344,7 @@ module.exports = {
                  * comments to check.
                  */
                 if (commentsIndex < comments.length) {
-                    let comment = null;
+                    let comment;
 
                     // iterate over comments until we find one past the current line
                     do {

package/lib/rules/max-lines.js

@@ -77,7 +77,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            Object.prototype.hasOwnProperty.call(option, "max")
+            Object.hasOwn(option, "max")
         ) {
             max = option.max;
         } else if (typeof option === "number") {
@@ -148,7 +148,7 @@ module.exports = {
                  * If file ends with a linebreak, `sourceCode.lines` will have one extra empty line at the end.
                  * That isn't a real line, so we shouldn't count it.
                  */
-                if (lines.length > 1 && lines[lines.length - 1].text === "") {
+                if (lines.length > 1 && lines.at(-1).text === "") {
                     lines.pop();
                 }
 
@@ -174,7 +174,7 @@ module.exports = {
                         },
                         end: {
                             line: sourceCode.lines.length,
-                            column: sourceCode.lines[sourceCode.lines.length - 1].length
+                            column: sourceCode.lines.at(-1).length
                         }
                     };
 

package/lib/rules/max-nested-callbacks.js

@@ -59,7 +59,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             THRESHOLD = option.maximum || option.max;
         } else if (typeof option === "number") {

package/lib/rules/max-params.js

@@ -63,7 +63,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             numParams = option.maximum || option.max;
         }

package/lib/rules/max-statements.js

@@ -79,7 +79,7 @@ module.exports = {
 
         if (
             typeof option === "object" &&
-            (Object.prototype.hasOwnProperty.call(option, "maximum") || Object.prototype.hasOwnProperty.call(option, "max"))
+            (Object.hasOwn(option, "maximum") || Object.hasOwn(option, "max"))
         ) {
             maxStatements = option.maximum || option.max;
         } else if (typeof option === "number") {

package/lib/rules/multiline-comment-style.js

@@ -113,7 +113,7 @@ module.exports = {
 
             return /^\*\s*$/u.test(lines[0]) &&
                 lines.slice(1, -1).every(line => /^\s* /u.test(line)) &&
-                /^\s*$/u.test(lines[lines.length - 1]);
+                /^\s*$/u.test(lines.at(-1));
         }
 
         /**
@@ -272,11 +272,11 @@ module.exports = {
                     context.report({
                         loc: {
                             start: firstComment.loc.start,
-                            end: commentGroup[commentGroup.length - 1].loc.end
+                            end: commentGroup.at(-1).loc.end
                         },
                         messageId: "expectedBlock",
                         fix(fixer) {
-                            const range = [firstComment.range[0], commentGroup[commentGroup.length - 1].range[1]];
+                            const range = [firstComment.range[0], commentGroup.at(-1).range[1]];
 
                             return commentLines.some(value => value.startsWith("/"))
                                 ? null
@@ -301,7 +301,7 @@ module.exports = {
                         });
                     }
 
-                    if (!/^\s*$/u.test(lines[lines.length - 1])) {
+                    if (!/^\s*$/u.test(lines.at(-1))) {
                         context.report({
                             loc: {
                                 start: { line: firstComment.loc.end.line, column: firstComment.loc.end.column - 2 },
@@ -408,12 +408,12 @@ module.exports = {
                     context.report({
                         loc: {
                             start: firstComment.loc.start,
-                            end: commentGroup[commentGroup.length - 1].loc.end
+                            end: commentGroup.at(-1).loc.end
                         },
                         messageId: "expectedBlock",
                         fix(fixer) {
                             return fixer.replaceTextRange(
-                                [firstComment.range[0], commentGroup[commentGroup.length - 1].range[1]],
+                                [firstComment.range[0], commentGroup.at(-1).range[1]],
                                 convertToBlock(firstComment, commentLines)
                             );
                         }
@@ -459,7 +459,7 @@ module.exports = {
                             tokenBefore && tokenBefore.loc.end.line === comment.loc.start.line - 1 &&
                             tokenBefore === commentList[index - 1]
                         ) {
-                            commentGroups[commentGroups.length - 1].push(comment);
+                            commentGroups.at(-1).push(comment);
                         } else {
                             commentGroups.push([comment]);
                         }

package/lib/rules/new-cap.js

@@ -40,7 +40,7 @@ const CAPS_ALLOWED = [
 function checkArray(obj, key, fallback) {
 
     /* c8 ignore start */
-    if (Object.prototype.hasOwnProperty.call(obj, key) && !Array.isArray(obj[key])) {
+    if (Object.hasOwn(obj, key) && !Array.isArray(obj[key])) {
         throw new TypeError(`${key}, if provided, must be an Array`);
     }/* c8 ignore stop */
     return obj[key] || fallback;

package/lib/rules/newline-after-var.js

@@ -215,7 +215,7 @@ module.exports = {
                     fix(fixer) {
                         const linesBetween = sourceCode.getText().slice(lastToken.range[1], nextToken.range[0]).split(astUtils.LINEBREAK_MATCHER);
 
-                        return fixer.replaceTextRange([lastToken.range[1], nextToken.range[0]], `${linesBetween.slice(0, -1).join("")}\n${linesBetween[linesBetween.length - 1]}`);
+                        return fixer.replaceTextRange([lastToken.range[1], nextToken.range[0]], `${linesBetween.slice(0, -1).join("")}\n${linesBetween.at(-1)}`);
                     }
                 });
             }

package/lib/rules/newline-before-return.js

@@ -166,7 +166,7 @@ module.exports = {
          */
         function canFix(node) {
             const leadingComments = sourceCode.getCommentsBefore(node);
-            const lastLeadingComment = leadingComments[leadingComments.length - 1];
+            const lastLeadingComment = leadingComments.at(-1);
             const tokenBefore = sourceCode.getTokenBefore(node);
 
             if (leadingComments.length === 0) {

package/lib/rules/no-case-declarations.js

@@ -19,9 +19,12 @@ module.exports = {
             url: "https://eslint.org/docs/latest/rules/no-case-declarations"
         },
 
+        hasSuggestions: true,
+
         schema: [],
 
         messages: {
+            addBrackets: "Add {} brackets around the case block.",
             unexpected: "Unexpected lexical declaration in case block."
         }
     },
@@ -53,7 +56,16 @@ module.exports = {
                     if (isLexicalDeclaration(statement)) {
                         context.report({
                             node: statement,
-                            messageId: "unexpected"
+                            messageId: "unexpected",
+                            suggest: [
+                                {
+                                    messageId: "addBrackets",
+                                    fix: fixer => [
+                                        fixer.insertTextBefore(node.consequent[0], "{ "),
+                                        fixer.insertTextAfter(node.consequent.at(-1), " }")
+                                    ]
+                                }
+                            ]
                         });
                     }
                 }

package/lib/rules/no-constant-binary-expression.js

@@ -5,8 +5,7 @@
 
 "use strict";
 
-const globals = require("globals");
-const { isNullLiteral, isConstant, isReferenceToGlobalVariable, isLogicalAssignmentOperator } = require("./utils/ast-utils");
+const { isNullLiteral, isConstant, isReferenceToGlobalVariable, isLogicalAssignmentOperator, ECMASCRIPT_GLOBALS } = require("./utils/ast-utils");
 
 const NUMERIC_OR_STRING_BINARY_OPERATORS = new Set(["+", "-", "*", "/", "%", "|", "^", "&", "**", "<<", ">>", ">>>"]);
 
@@ -103,7 +102,7 @@ function hasConstantNullishness(scope, node, nonNullish) {
 
             return true;
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return hasConstantNullishness(scope, last, nonNullish);
         }
@@ -248,7 +247,7 @@ function hasConstantLooseBooleanComparison(scope, node) {
              */
             return false;
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return hasConstantLooseBooleanComparison(scope, last);
         }
@@ -299,7 +298,7 @@ function hasConstantStrictBooleanComparison(scope, node) {
             return true;
         }
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return hasConstantStrictBooleanComparison(scope, last);
         }
@@ -376,7 +375,7 @@ function isAlwaysNew(scope, node) {
              * Catching these is especially useful for primitive constructors
              * which return boxed values, a surprising gotcha' in JavaScript.
              */
-            return Object.hasOwnProperty.call(globals.builtin, node.callee.name) &&
+            return Object.hasOwn(ECMASCRIPT_GLOBALS, node.callee.name) &&
               isReferenceToGlobalVariable(scope, node.callee);
         }
         case "Literal":
@@ -384,7 +383,7 @@ function isAlwaysNew(scope, node) {
             // Regular expressions are objects, and thus always new
             return typeof node.regex === "object";
         case "SequenceExpression": {
-            const last = node.expressions[node.expressions.length - 1];
+            const last = node.expressions.at(-1);
 
             return isAlwaysNew(scope, last);
         }
@@ -440,7 +439,7 @@ module.exports = {
         type: "problem",
         docs: {
             description: "Disallow expressions where the operation doesn't affect the value",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/latest/rules/no-constant-binary-expression"
         },
         schema: [],

package/lib/rules/no-constant-condition.js

@@ -31,8 +31,7 @@ module.exports = {
                 type: "object",
                 properties: {
                     checkLoops: {
-                        type: "boolean",
-                        default: true
+                        enum: ["all", "allExceptWhileTrue", "none", true, false]
                     }
                 },
                 additionalProperties: false
@@ -45,11 +44,17 @@ module.exports = {
     },
 
     create(context) {
-        const options = context.options[0] || {},
-            checkLoops = options.checkLoops !== false,
-            loopSetStack = [];
+        const options = context.options[0] || {};
+        let checkLoops = options.checkLoops ?? "allExceptWhileTrue";
+        const loopSetStack = [];
         const sourceCode = context.sourceCode;
 
+        if (options.checkLoops === true) {
+            checkLoops = "all";
+        } else if (options.checkLoops === false) {
+            checkLoops = "none";
+        }
+
         let loopsInCurrentScope = new Set();
 
         //--------------------------------------------------------------------------
@@ -120,7 +125,7 @@ module.exports = {
          * @private
          */
         function checkLoop(node) {
-            if (checkLoops) {
+            if (checkLoops === "all" || checkLoops === "allExceptWhileTrue") {
                 trackConstantConditionLoop(node);
             }
         }
@@ -132,7 +137,13 @@ module.exports = {
         return {
             ConditionalExpression: reportIfConstant,
             IfStatement: reportIfConstant,
-            WhileStatement: checkLoop,
+            WhileStatement(node) {
+                if (node.test.type === "Literal" && node.test.value === true && checkLoops === "allExceptWhileTrue") {
+                    return;
+                }
+
+                checkLoop(node);
+            },
             "WhileStatement:exit": checkConstantConditionLoopInSet,
             DoWhileStatement: checkLoop,
             "DoWhileStatement:exit": checkConstantConditionLoopInSet,

package/lib/rules/no-constructor-return.js

@@ -20,7 +20,7 @@ module.exports = {
             url: "https://eslint.org/docs/latest/rules/no-constructor-return"
         },
 
-        schema: {},
+        schema: [],
 
         fixable: null,
 
@@ -40,7 +40,7 @@ module.exports = {
                 stack.pop();
             },
             ReturnStatement(node) {
-                const last = stack[stack.length - 1];
+                const last = stack.at(-1);
 
                 if (!last.parent) {
                     return;

package/lib/rules/no-dupe-class-members.js

@@ -42,7 +42,7 @@ module.exports = {
          *   - retv.set {boolean} A flag which shows the name is declared as setter.
          */
         function getState(name, isStatic) {
-            const stateMap = stack[stack.length - 1];
+            const stateMap = stack.at(-1);
             const key = `$${name}`; // to avoid "__proto__".
 
             if (!stateMap[key]) {
@@ -82,7 +82,7 @@ module.exports = {
                 }
 
                 const state = getState(name, node.static);
-                let isDuplicate = false;
+                let isDuplicate;
 
                 if (kind === "get") {
                     isDuplicate = (state.init || state.get);

package/lib/rules/no-else-return.js

@@ -270,7 +270,7 @@ module.exports = {
         function naiveHasReturn(node) {
             if (node.type === "BlockStatement") {
                 const body = node.body,
-                    lastChildNode = body[body.length - 1];
+                    lastChildNode = body.at(-1);
 
                 return lastChildNode && checkForReturn(lastChildNode);
             }

package/lib/rules/no-empty-function.js

@@ -40,7 +40,7 @@ const ALLOW_OPTIONS = Object.freeze([
  */
 function getKind(node) {
     const parent = node.parent;
-    let kind = "";
+    let kind;
 
     if (node.type === "ArrowFunctionExpression") {
         return "arrowFunctions";
@@ -73,7 +73,7 @@ function getKind(node) {
     }
 
     // Detects prefix.
-    let prefix = "";
+    let prefix;
 
     if (node.generator) {
         prefix = "generator";

package/lib/rules/no-empty-static-block.js

@@ -15,7 +15,7 @@ module.exports = {
 
         docs: {
             description: "Disallow empty static blocks",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/latest/rules/no-empty-static-block"
         },
 

package/lib/rules/no-extend-native.js

@@ -10,7 +10,6 @@
 //------------------------------------------------------------------------------
 
 const astUtils = require("./utils/ast-utils");
-const globals = require("globals");
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -54,7 +53,7 @@ module.exports = {
         const sourceCode = context.sourceCode;
         const exceptions = new Set(config.exceptions || []);
         const modifiedBuiltins = new Set(
-            Object.keys(globals.builtin)
+            Object.keys(astUtils.ECMASCRIPT_GLOBALS)
                 .filter(builtin => builtin[0].toUpperCase() === builtin[0])
                 .filter(builtin => !exceptions.has(builtin))
         );

package/lib/rules/no-extra-semi.js

@@ -26,7 +26,7 @@ module.exports = {
 
         docs: {
             description: "Disallow unnecessary semicolons",
-            recommended: true,
+            recommended: false,
             url: "https://eslint.org/docs/latest/rules/no-extra-semi"
         },
 

package/lib/rules/no-fallthrough.js

@@ -48,9 +48,9 @@ function isFallThroughComment(comment, fallthroughCommentPattern) {
  * @param {ASTNode} subsequentCase The case after caseWhichFallsThrough.
  * @param {RuleContext} context A rule context which stores comments.
  * @param {RegExp} fallthroughCommentPattern A pattern to match comment to.
- * @returns {boolean} `true` if the case has a valid fallthrough comment.
+ * @returns {null | object} the comment if the case has a valid fallthrough comment, otherwise null
  */
-function hasFallthroughComment(caseWhichFallsThrough, subsequentCase, context, fallthroughCommentPattern) {
+function getFallthroughComment(caseWhichFallsThrough, subsequentCase, context, fallthroughCommentPattern) {
     const sourceCode = context.sourceCode;
 
     if (caseWhichFallsThrough.consequent.length === 1 && caseWhichFallsThrough.consequent[0].type === "BlockStatement") {
@@ -58,13 +58,17 @@ function hasFallthroughComment(caseWhichFallsThrough, subsequentCase, context, f
         const commentInBlock = sourceCode.getCommentsBefore(trailingCloseBrace).pop();
 
         if (commentInBlock && isFallThroughComment(commentInBlock.value, fallthroughCommentPattern)) {
-            return true;
+            return commentInBlock;
         }
     }
 
     const comment = sourceCode.getCommentsBefore(subsequentCase).pop();
 
-    return Boolean(comment && isFallThroughComment(comment.value, fallthroughCommentPattern));
+    if (comment && isFallThroughComment(comment.value, fallthroughCommentPattern)) {
+        return comment;
+    }
+
+    return null;
 }
 
 /**
@@ -103,12 +107,17 @@ module.exports = {
                     allowEmptyCase: {
                         type: "boolean",
                         default: false
+                    },
+                    reportUnusedFallthroughComment: {
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
             }
         ],
         messages: {
+            unusedFallthroughComment: "Found a comment that would permit fallthrough, but case cannot fall through.",
             case: "Expected a 'break' statement before 'case'.",
             default: "Expected a 'break' statement before 'default'."
         }
@@ -120,12 +129,13 @@ module.exports = {
         let currentCodePathSegments = new Set();
         const sourceCode = context.sourceCode;
         const allowEmptyCase = options.allowEmptyCase || false;
+        const reportUnusedFallthroughComment = options.reportUnusedFallthroughComment || false;
 
         /*
          * We need to use leading comments of the next SwitchCase node because
          * trailing comments is wrong if semicolons are omitted.
          */
-        let fallthroughCase = null;
+        let previousCase = null;
         let fallthroughCommentPattern = null;
 
         if (options.commentPattern) {
@@ -168,13 +178,23 @@ module.exports = {
                  * And reports the previous fallthrough node if that does not exist.
                  */
 
-                if (fallthroughCase && (!hasFallthroughComment(fallthroughCase, node, context, fallthroughCommentPattern))) {
-                    context.report({
-                        messageId: node.test ? "case" : "default",
-                        node
-                    });
+                if (previousCase && previousCase.node.parent === node.parent) {
+                    const previousCaseFallthroughComment = getFallthroughComment(previousCase.node, node, context, fallthroughCommentPattern);
+
+                    if (previousCase.isFallthrough && !(previousCaseFallthroughComment)) {
+                        context.report({
+                            messageId: node.test ? "case" : "default",
+                            node
+                        });
+                    } else if (reportUnusedFallthroughComment && !previousCase.isSwitchExitReachable && previousCaseFallthroughComment) {
+                        context.report({
+                            messageId: "unusedFallthroughComment",
+                            node: previousCaseFallthroughComment
+                        });
+                    }
+
                 }
-                fallthroughCase = null;
+                previousCase = null;
             },
 
             "SwitchCase:exit"(node) {
@@ -185,11 +205,16 @@ module.exports = {
                  * `break`, `return`, or `throw` are unreachable.
                  * And allows empty cases and the last case.
                  */
-                if (isAnySegmentReachable(currentCodePathSegments) &&
-                    (node.consequent.length > 0 || (!allowEmptyCase && hasBlankLinesBetween(node, nextToken))) &&
-                    node.parent.cases[node.parent.cases.length - 1] !== node) {
-                    fallthroughCase = node;
-                }
+                const isSwitchExitReachable = isAnySegmentReachable(currentCodePathSegments);
+                const isFallthrough = isSwitchExitReachable && (node.consequent.length > 0 || (!allowEmptyCase && hasBlankLinesBetween(node, nextToken))) &&
+                    node.parent.cases.at(-1) !== node;
+
+                previousCase = {
+                    node,
+                    isSwitchExitReachable,
+                    isFallthrough
+                };
+
             }
         };
     }