claude-flow-novice 2.15.2 → 2.15.4

package/claude-assets/skills/cfn-redis-coordination/agent-log.sh.bak

@@ -0,0 +1,124 @@
+#!/usr/bin/env bash
+
+# Agent Logging Utility - Dual output (terminal + Redis)
+#
+# Usage:
+#   source agent-log.sh
+#   agent_log "info" "Message here"
+#   agent_log "error" "Error occurred"
+#
+# Or as standalone:
+#   ./agent-log.sh "info" "Agent started" --agent-id "researcher-1" --task-id "task-123"
+
+set -euo pipefail
+
+# Color codes for terminal output
+COLOR_RESET="\033[0m"
+COLOR_DEBUG="\033[0;36m"   # Cyan
+COLOR_INFO="\033[0;32m"    # Green
+COLOR_WARN="\033[0;33m"    # Yellow
+COLOR_ERROR="\033[0;31m"   # Red
+COLOR_AGENT="\033[0;35m"   # Magenta
+
+# Get color for log level
+get_log_color() {
+  local level="$1"
+  case "$level" in
+    debug) echo "$COLOR_DEBUG" ;;
+    info)  echo "$COLOR_INFO" ;;
+    warn)  echo "$COLOR_WARN" ;;
+    error) echo "$COLOR_ERROR" ;;
+    *) echo "$COLOR_RESET" ;;
+  esac
+}
+
+# Main logging function
+# Usage: agent_log <level> <message> [--agent-id <id>] [--task-id <id>] [--no-terminal] [--no-redis]
+agent_log() {
+  local LEVEL="${1:-info}"
+  local MESSAGE="${2:-}"
+  local AGENT_ID="${AGENT_ID:-unknown}"
+  local TASK_ID="${TASK_ID:-unknown}"
+  local REPOSITORY=$(basename "$(pwd)")
+  local NO_TERMINAL=false
+  local NO_REDIS=false
+
+  # Parse optional arguments
+  shift 2 || true
+  while [[ $# -gt 0 ]]; do
+    case "$1" in
+      --agent-id)
+        AGENT_ID="$2"
+        shift 2
+        ;;
+      --task-id)
+        TASK_ID="$2"
+        shift 2
+        ;;
+      --no-terminal)
+        NO_TERMINAL=true
+        shift
+        ;;
+      --no-redis)
+        NO_REDIS=true
+        shift
+        ;;
+      *)
+        shift
+        ;;
+    esac
+  done
+
+  local TIMESTAMP=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
+  local COLOR=$(get_log_color "$LEVEL")
+
+  # 1. Terminal output (with colors)
+  if [ "$NO_TERMINAL" = false ]; then
+    echo -e "${COLOR}[${LEVEL^^}]${COLOR_RESET} ${COLOR_AGENT}[${AGENT_ID}]${COLOR_RESET} ${MESSAGE}"
+  fi
+
+  # 2. File output (no colors, in /tmp)
+  local LOG_FILE="/tmp/agent-${AGENT_ID}.log"
+  echo "[${TIMESTAMP}] [${LEVEL^^}] [${AGENT_ID}] ${MESSAGE}" >> "$LOG_FILE"
+
+  # 3. Redis pub/sub (for portal)
+  if [ "$NO_REDIS" = false ]; then
+    local LOG_PAYLOAD=$(cat <<EOF
+{
+  "level": "${LEVEL}",
+  "message": "${MESSAGE}",
+  "agentId": "${AGENT_ID}",
+  "taskId": "${TASK_ID}",
+  "repository": "${REPOSITORY}",
+  "timestamp": "${TIMESTAMP}"
+}
+EOF
+)
+
+    # Publish to Redis channel: swarm:<task-id>:logs
+    redis-cli publish "swarm:${TASK_ID}:logs" "$LOG_PAYLOAD" > /dev/null 2>&1 || true
+
+    # Also add to sorted set for persistence (with timestamp as score)
+    local SCORE=$(date +%s)
+    redis-cli zadd "swarm:${TASK_ID}:logs:history" "$SCORE" "$LOG_PAYLOAD" > /dev/null 2>&1 || true
+
+    # Set TTL on history (7 days)
+    redis-cli expire "swarm:${TASK_ID}:logs:history" 604800 > /dev/null 2>&1 || true
+  fi
+}
+
+# If script is executed directly (not sourced)
+if [ "${BASH_SOURCE[0]}" = "${0}" ]; then
+  if [ $# -lt 2 ]; then
+    echo "Usage: $0 <level> <message> [--agent-id <id>] [--task-id <id>]"
+    echo ""
+    echo "Levels: debug, info, warn, error"
+    echo ""
+    echo "Examples:"
+    echo "  $0 info \"Agent started\" --agent-id researcher-1 --task-id task-123"
+    echo "  $0 error \"Connection failed\" --agent-id reviewer-2 --task-id task-456"
+    exit 1
+  fi
+
+  agent_log "$@"
+fi

package/claude-assets/skills/cfn-redis-coordination/agent-recovery.sh

@@ -1,75 +1,75 @@
-#!/bin/bash
-# Redis Coordination Skill - Agent Emergency Recovery
-# Version: 1.0.0
-# Last Updated: 2025-10-19
-
-# Strict error handling
-set -euo pipefail
-
-# Default values
-TASK_ID=""
-AGENT_ID=""
-RECOVERY_MODE="soft"  # Options: soft, hard
-
-# Parse command-line arguments
-while [[ $# -gt 0 ]]; do
-    case "$1" in
-        --task-id)
-            TASK_ID="$2"
-            shift 2
-            ;;
-        --agent-id)
-            AGENT_ID="$2"
-            shift 2
-            ;;
-        --mode)
-            RECOVERY_MODE="$2"
-            shift 2
-            ;;
-        *)
-            echo "Unknown parameter: $1"
-            exit 1
-            ;;
-    esac
-done
-
-# Validate required parameters
-if [[ -z "$TASK_ID" || -z "$AGENT_ID" ]]; then
-    echo "Error: task-id and agent-id are required"
-    exit 1
-fi
-
-# Log recovery attempt
-echo "[$(date -u)] Attempting ${RECOVERY_MODE} recovery for agent: ${AGENT_ID}" >> /var/log/claude-flow/agent-recovery.log
-
-# Retrieve agent context before recovery
-AGENT_CONTEXT=$(redis-cli get "swarm:${TASK_ID}:${AGENT_ID}:context")
-
-# Recovery actions based on mode
-case "$RECOVERY_MODE" in
-    "soft")
-        # Soft recovery: Spawn new agent with previous context
-        npx claude-flow@alpha spawn "$AGENT_ID" \
-            --task-id "$TASK_ID" \
-            --recovery-context "$AGENT_CONTEXT"
-        ;;
-    "hard")
-        # Hard recovery: Full agent replacement
-        npx claude-flow@alpha spawn "$AGENT_ID" \
-            --task-id "$TASK_ID" \
-            --mode replace \
-            --recovery-context "$AGENT_CONTEXT"
-        ;;
-    *)
-        echo "Invalid recovery mode: ${RECOVERY_MODE}"
-        exit 1
-        ;;
-esac
-
-# Update active agents set
-redis-cli sadd "swarm:${TASK_ID}:active-agents" "$AGENT_ID"
-
-# Log recovery completion
-echo "[$(date -u)] Recovery completed for agent: ${AGENT_ID}" >> /var/log/claude-flow/agent-recovery.log
-
+#!/bin/bash
+# Redis Coordination Skill - Agent Emergency Recovery
+# Version: 1.0.0
+# Last Updated: 2025-10-19
+
+# Strict error handling
+set -euo pipefail
+
+# Default values
+TASK_ID=""
+AGENT_ID=""
+RECOVERY_MODE="soft"  # Options: soft, hard
+
+# Parse command-line arguments
+while [[ $# -gt 0 ]]; do
+    case "$1" in
+        --task-id)
+            TASK_ID="$2"
+            shift 2
+            ;;
+        --agent-id)
+            AGENT_ID="$2"
+            shift 2
+            ;;
+        --mode)
+            RECOVERY_MODE="$2"
+            shift 2
+            ;;
+        *)
+            echo "Unknown parameter: $1"
+            exit 1
+            ;;
+    esac
+done
+
+# Validate required parameters
+if [[ -z "$TASK_ID" || -z "$AGENT_ID" ]]; then
+    echo "Error: task-id and agent-id are required"
+    exit 1
+fi
+
+# Log recovery attempt
+echo "[$(date -u)] Attempting ${RECOVERY_MODE} recovery for agent: ${AGENT_ID}" >> /var/log/claude-flow/agent-recovery.log
+
+# Retrieve agent context before recovery
+AGENT_CONTEXT=$(redis-cli get "swarm:${TASK_ID}:${AGENT_ID}:context")
+
+# Recovery actions based on mode
+case "$RECOVERY_MODE" in
+    "soft")
+        # Soft recovery: Spawn new agent with previous context
+        cfn-spawn agent "$AGENT_ID" \
+            --task-id "$TASK_ID" \
+            --recovery-context "$AGENT_CONTEXT"
+        ;;
+    "hard")
+        # Hard recovery: Full agent replacement
+        cfn-spawn agent "$AGENT_ID" \
+            --task-id "$TASK_ID" \
+            --mode replace \
+            --recovery-context "$AGENT_CONTEXT"
+        ;;
+    *)
+        echo "Invalid recovery mode: ${RECOVERY_MODE}"
+        exit 1
+        ;;
+esac
+
+# Update active agents set
+redis-cli sadd "swarm:${TASK_ID}:active-agents" "$AGENT_ID"
+
+# Log recovery completion
+echo "[$(date -u)] Recovery completed for agent: ${AGENT_ID}" >> /var/log/claude-flow/agent-recovery.log
+
 exit 0

package/claude-assets/skills/cfn-redis-coordination/collect-confidence-scores.sh

@@ -18,6 +18,36 @@
 
 set -euo pipefail
 
+# Validate required tools are available
+MISSING_TOOLS=()
+for TOOL in redis-cli jq bc; do
+    if ! command -v "$TOOL" >/dev/null 2>&1; then
+        MISSING_TOOLS+=("$TOOL")
+    fi
+done
+
+if [ ${#MISSING_TOOLS[@]} -gt 0 ]; then
+    echo "❌ ERROR: Required tools not found: ${MISSING_TOOLS[*]}" >&2
+    echo "   Install missing tools and retry" >&2
+    exit 1
+fi
+
+# Source centralized Redis functions (provides graceful fallback for Task mode)
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+
+# Verify redis-functions.sh exists and is readable before sourcing
+REDIS_FUNCTIONS="${SCRIPT_DIR}/redis-functions.sh"
+if [ ! -r "$REDIS_FUNCTIONS" ]; then
+    echo "❌ ERROR: Cannot read redis-functions.sh at: $REDIS_FUNCTIONS" >&2
+    exit 1
+fi
+
+# Source with explicit error handling
+if ! source "$REDIS_FUNCTIONS"; then
+    echo "❌ ERROR: Failed to source redis-functions.sh" >&2
+    exit 1
+fi
+
 # Debug mode (set DEBUG=true for verbose output)
 DEBUG="${DEBUG:-false}"
 

package/claude-assets/skills/cfn-redis-coordination/get-context.sh

@@ -1,113 +1,146 @@
-#!/bin/bash
-# Retrieve CFN Loop task context from Redis
-# Used by CLI-spawned agents to get structured context from orchestrator
-#
-# Usage:
-#   get-context.sh --task-id <id> [--namespace <ns>]
-#   get-context.sh --task-id <id> --key <key> [--namespace <ns>]
-#   get-context.sh <task_id> (legacy mode)
-
-set -euo pipefail
-
-# Initialize variables
-TASK_ID=""
-KEY=""
-NAMESPACE="swarm"
-FORMAT="json"  # json or raw
-
-# Parse arguments
-while [[ $# -gt 0 ]]; do
-  case $1 in
-    --task-id)
-      TASK_ID="$2"
-      shift 2
-      ;;
-    --key)
-      KEY="$2"
-      shift 2
-      ;;
-    --namespace)
-      NAMESPACE="$2"
-      shift 2
-      ;;
-    --format)
-      FORMAT="$2"
-      shift 2
-      ;;
-    *)
-      # Legacy mode: positional argument
-      if [ -z "$TASK_ID" ]; then
-        TASK_ID="$1"
-      fi
-      shift
-      ;;
-  esac
-done
-
-# Validate required arguments
-if [ -z "$TASK_ID" ]; then
-    echo "Error: --task-id or TASK_ID required" >&2
-    echo "Usage: $0 --task-id <id> [--key <key>] [--namespace <ns>] [--format <json|raw>]" >&2
-    echo "   or: $0 <task_id> (legacy)" >&2
-    exit 1
-fi
-
-REDIS_KEY="${NAMESPACE}:${TASK_ID}:context"
-
-# Check if context exists
-if ! redis-cli EXISTS "$REDIS_KEY" >/dev/null 2>&1; then
-    echo "⚠️  No context found for task: $TASK_ID" >&2
-    exit 1
-fi
-
-# Handle specific key retrieval
-if [ -n "$KEY" ]; then
-  VALUE=$(redis-cli HGET "$REDIS_KEY" "$KEY" 2>/dev/null || echo "")
-  if [ -z "$VALUE" ]; then
-    echo "⚠️  Key '$KEY' not found in context for task: $TASK_ID" >&2
-    exit 1
-  fi
-
-  if [ "$FORMAT" = "raw" ]; then
-    echo "$VALUE"
-  else
-    echo "{\"$KEY\":$VALUE}"
-  fi
-  exit 0
-fi
-
-# Handle full context retrieval
-ALL_FIELDS=$(redis-cli HGETALL "$REDIS_KEY" 2>/dev/null || echo "")
-
-if [ -z "$ALL_FIELDS" ]; then
-    echo "⚠️  Empty context for task: $TASK_ID" >&2
-    exit 1
-fi
-
-# Format as JSON
-if [ "$FORMAT" = "json" ]; then
-  echo "{"
-  first=true
-  while IFS= read -r field; do
-    if [ -z "$field" ]; then continue; fi
-    if [ "$first" = true ]; then
-      first=false
-    else
-      echo ","
-    fi
-    # Skip empty lines and properly format JSON values
-    if [[ $field =~ ^[0-9]+$ ]]; then
-      # Numeric value
-      echo -n "  \"$field\": $(redis-cli HGET "$REDIS_KEY" "$field")"
-    else
-      # String value
-      value=$(redis-cli HGET "$REDIS_KEY" "$field" | sed 's/"/\\"/g')
-      echo -n "  \"$field\": \"$value\""
-    fi
-  done <<< "$ALL_FIELDS"
-  echo ""
-  echo "}"
-else
-  # Raw format
-  redis-cli HGETALL "$REDIS_KEY"
+#!/bin/bash
+# Retrieve CFN Loop task context from Redis
+# Used by CLI-spawned agents to get structured context from orchestrator
+#
+# Usage:
+#   get-context.sh --task-id <id> [--namespace <ns>]
+#   get-context.sh --task-id <id> --key <key> [--namespace <ns>]
+#   get-context.sh <task_id> (legacy mode)
+
+set -euo pipefail
+
+# Source centralized Redis functions with defensive fallback
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REDIS_FUNCTIONS="${SCRIPT_DIR}/redis-functions.sh"
+
+# Check if redis-functions.sh exists and is readable
+if [ ! -r "$REDIS_FUNCTIONS" ]; then
+    echo "⚠️  WARNING: Cannot read redis-functions.sh at: $REDIS_FUNCTIONS" >&2
+    echo "   Operating in Task mode-only (no Redis coordination)" >&2
+    # Define minimal fallback stubs for Task mode
+    redis-cli() {
+        echo "⚠️  Redis unavailable in Task mode - no-op" >&2
+        return 0
+    }
+    export -f redis-cli
+else
+    # Attempt to source with controlled error handling
+    set +e  # Temporarily disable errexit
+    source "$REDIS_FUNCTIONS" 2>/dev/null
+    SOURCE_STATUS=$?
+    set -e  # Re-enable errexit
+
+    if [ $SOURCE_STATUS -ne 0 ]; then
+        echo "⚠️  WARNING: Failed to source redis-functions.sh (exit code: $SOURCE_STATUS)" >&2
+        echo "   Operating in Task mode-only (no Redis coordination)" >&2
+        # Define minimal fallback stubs
+        redis-cli() {
+            echo "⚠️  Redis unavailable - no-op" >&2
+            return 0
+        }
+        export -f redis-cli
+    fi
+fi
+
+# Initialize variables
+TASK_ID=""
+KEY=""
+NAMESPACE="swarm"
+FORMAT="json"  # json or raw
+
+# Parse arguments
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --task-id)
+      TASK_ID="$2"
+      shift 2
+      ;;
+    --key)
+      KEY="$2"
+      shift 2
+      ;;
+    --namespace)
+      NAMESPACE="$2"
+      shift 2
+      ;;
+    --format)
+      FORMAT="$2"
+      shift 2
+      ;;
+    *)
+      # Legacy mode: positional argument
+      if [ -z "$TASK_ID" ]; then
+        TASK_ID="$1"
+      fi
+      shift
+      ;;
+  esac
+done
+
+# Validate required arguments
+if [ -z "$TASK_ID" ]; then
+    echo "Error: --task-id or TASK_ID required" >&2
+    echo "Usage: $0 --task-id <id> [--key <key>] [--namespace <ns>] [--format <json|raw>]" >&2
+    echo "   or: $0 <task_id> (legacy)" >&2
+    exit 1
+fi
+
+REDIS_KEY="${NAMESPACE}:${TASK_ID}:context"
+
+# Check if context exists
+if ! redis-cli EXISTS "$REDIS_KEY" >/dev/null 2>&1; then
+    echo "⚠️  No context found for task: $TASK_ID" >&2
+    exit 1
+fi
+
+# Handle specific key retrieval
+if [ -n "$KEY" ]; then
+  VALUE=$(redis-cli HGET "$REDIS_KEY" "$KEY" 2>/dev/null || echo "")
+  if [ -z "$VALUE" ]; then
+    echo "⚠️  Key '$KEY' not found in context for task: $TASK_ID" >&2
+    exit 1
+  fi
+
+  if [ "$FORMAT" = "raw" ]; then
+    echo "$VALUE"
+  else
+    echo "{\"$KEY\":$VALUE}"
+  fi
+  exit 0
+fi
+
+# Handle full context retrieval
+ALL_FIELDS=$(redis-cli HGETALL "$REDIS_KEY" 2>/dev/null || echo "")
+
+if [ -z "$ALL_FIELDS" ]; then
+    echo "⚠️  Empty context for task: $TASK_ID" >&2
+    exit 1
+fi
+
+# Format as JSON
+if [ "$FORMAT" = "json" ]; then
+  echo "{"
+  first=true
+  while IFS= read -r field; do
+    if [ -z "$field" ]; then continue; fi
+    if [ "$first" = true ]; then
+      first=false
+    else
+      echo ","
+    fi
+    # Skip empty lines and properly format JSON values
+    if [[ $field =~ ^[0-9]+$ ]]; then
+      # Numeric value
+      echo -n "  \"$field\": $(redis-cli HGET "$REDIS_KEY" "$field")"
+    else
+      # String value
+      value=$(redis-cli HGET "$REDIS_KEY" "$field" | sed 's/"/\\"/g')
+      echo -n "  \"$field\": \"$value\""
+    fi
+  done <<< "$ALL_FIELDS"
+  echo ""
+  echo "}"
+else
+  # Raw format
+  redis-cli HGETALL "$REDIS_KEY"
 fi

package/claude-assets/skills/cfn-redis-coordination/get-success-criteria.sh

@@ -0,0 +1,54 @@
+#!/bin/bash
+set -euo pipefail
+
+# Retrieve success criteria from Redis
+# Usage: get-success-criteria.sh --task-id TASK_ID
+# Output: JSON string (stdout) or error message (stderr)
+
+TASK_ID=""
+
+# Parse arguments
+while [[ $# -gt 0 ]]; do
+    case "$1" in
+        --task-id)
+            TASK_ID="$2"
+            shift 2
+            ;;
+        *)
+            echo "❌ Unknown option: $1" >&2
+            echo "Usage: get-success-criteria.sh --task-id TASK_ID" >&2
+            exit 1
+            ;;
+    esac
+done
+
+# Validate input
+if [[ -z "$TASK_ID" ]]; then
+    echo "❌ --task-id required" >&2
+    exit 1
+fi
+
+# SECURITY FIX: Validate TASK_ID format (prevent Redis key injection)
+if ! [[ "$TASK_ID" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+    echo "❌ Invalid TASK_ID format: $TASK_ID (must be alphanumeric, dash, underscore only)" >&2
+    exit 1
+fi
+
+# Retrieve from Redis
+REDIS_KEY="swarm:${TASK_ID}:config:success_criteria"
+CRITERIA=$(redis-cli GET "$REDIS_KEY" 2>/dev/null || echo "")
+
+# Check if criteria exists
+if [[ -z "$CRITERIA" ]] || [[ "$CRITERIA" == "null" ]]; then
+    echo "⚠️  No success criteria found for task $TASK_ID" >&2
+    exit 1
+fi
+
+# Validate JSON before output
+if ! echo "$CRITERIA" | jq empty 2>/dev/null; then
+    echo "❌ Invalid JSON in stored criteria" >&2
+    exit 1
+fi
+
+# Output to stdout (clean output for piping)
+echo "$CRITERIA"

package/claude-assets/skills/cfn-redis-coordination/invoke-waiting-mode.sh

@@ -7,7 +7,10 @@
 
 set -euo pipefail
 
+# Source centralized Redis functions (provides graceful fallback for Task mode)
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+source "${SCRIPT_DIR}/redis-functions.sh"
+
 REDIS_COORD_SKILL="$SCRIPT_DIR"
 
 # Parse arguments

package/claude-assets/skills/cfn-redis-coordination/redis-cli-wrapper.sh

@@ -1,9 +1,30 @@
 #!/bin/bash
-# Wrapper for redis-cli that enforces environment variable usage
-# This ensures all Redis commands use REDIS_HOST/REDIS_PORT instead of hardcoded localhost:6379
+# Wrapper for redis-cli with graceful fallback for Task mode
+# Enforces environment variable usage and handles Redis unavailability
+#
+# ANTI-023 Memory Leak Protection:
+# - Task mode: Redis unavailable → soft fail (exit 0)
+# - CLI/Docker mode: Redis available → normal execution
 set -euo pipefail
 
 REDIS_HOST="${REDIS_HOST:-localhost}"
 REDIS_PORT="${REDIS_PORT:-6379}"
+REDIS_PASSWORD="${REDIS_PASSWORD:-${CFN_REDIS_PASSWORD:-}}"  # Support both env vars
 
-exec redis-cli -h "$REDIS_HOST" -p "$REDIS_PORT" "$@"
+# Build auth arguments for redis-cli
+AUTH_ARGS=()
+if [ -n "$REDIS_PASSWORD" ]; then
+    AUTH_ARGS=("-a" "$REDIS_PASSWORD")
+fi
+
+# Graceful Redis availability check (1 second timeout, with auth if provided)
+if ! timeout 1 redis-cli -h "$REDIS_HOST" -p "$REDIS_PORT" "${AUTH_ARGS[@]}" ping &>/dev/null; then
+    # Redis unavailable - likely Task mode or Redis service down
+    echo "⚠️ Redis unavailable - command skipped (soft fail)" >&2
+    echo "💡 This is expected in Task mode (Main Chat coordination)" >&2
+    echo "🔧 Agents should output JSON directly instead of Redis coordination" >&2
+    exit 0  # Soft fail - don't break agent execution
+fi
+
+# Redis available - execute command normally (CLI/Docker mode, with auth if provided)
+exec redis-cli -h "$REDIS_HOST" -p "$REDIS_PORT" "${AUTH_ARGS[@]}" "$@"