claude-flow-novice 2.15.2 → 2.15.4

package/claude-assets/skills/cfn-transparency-middleware/tests/input-validation.sh

@@ -1,93 +1,108 @@
-#!/usr/bin/env bash
-# Input Validation and Security Test Suite
-# Validates input handling and prevents potential injection scenarios
-
-set -euo pipefail
-
-# Source the main script to access validation functions
-source "$(dirname "$0")/.claude/skills/cfn-cfn-test-integration.sh"
-
-# Test Cases for validate_input function
-test_input_validation() {
-    local test_cases=(
-        "valid_task_id:integration-test-task:task_id:pass"
-        "valid_agent_id:test-agent-1:agent_id:pass"
-        "invalid_task_id_with_space:test task:task_id:fail"
-        "invalid_task_id_with_special_chars:test@task:task_id:fail"
-        "invalid_agent_id_with_special_chars:test!agent:agent_id:fail"
-    )
-
-    for test_case in "${test_cases[@]}"; do
-        local name=$(echo "$test_case" | cut -d: -f1)
-        local input=$(echo "$test_case" | cut -d: -f2)
-        local input_type=$(echo "$test_case" | cut -d: -f3)
-        local expected=$(echo "$test_case" | cut -d: -f4)
-
-        echo "Running test case: $name"
-
-        if [[ "$expected" == "pass" ]]; then
-            validate_input "$input" "$input_type"
-            echo "✅ PASS: $name - Successfully validated"
-        else
-            set +e
-            validate_input "$input" "$input_type" 2>/dev/null
-            local exit_code=$?
-            set -e
-
-            if [ "$exit_code" -ne 0 ]; then
-                echo "✅ PASS: $name - Correctly rejected invalid input"
-            else
-                echo "❌ FAIL: $name - Failed to reject invalid input"
-                exit 1
-            fi
-        fi
-    done
-}
-
-# Test SQLite Query Safety
-test_sqlite_query_safety() {
-    local db_file=$(mktemp)
-    local bad_input="'; DROP TABLE agent_memory; --"
-
-    # Setup test database
-    sqlite3 "$db_file" <<EOF
-CREATE TABLE agent_memory (
-    task_id TEXT,
-    event_data TEXT
-);
-INSERT INTO agent_memory VALUES ('test-task', 'sample data');
-EOF
-
-    # Attempt query with malicious input
-    set +e
-    local query_result=$(sqlite3 "$db_file" \
-        "SELECT COUNT(*) FROM agent_memory WHERE task_id = '$bad_input';" 2>/dev/null)
-    local exit_code=$?
-    set -e
-
-    # Verify query did not modify the database
-    local row_count=$(sqlite3 "$db_file" "SELECT COUNT(*) FROM agent_memory;")
-
-    if [ "$row_count" -eq 1 ] && [ "$exit_code" -eq 0 ]; then
-        echo "✅ PASS: SQLite query safety - Malicious input contained"
-    else
-        echo "❌ FAIL: SQLite query safety - Potential vulnerability"
-        exit 1
-    fi
-
-    # Cleanup
-    rm -f "$db_file"
-}
-
-# Main test runner
-main() {
-    echo "=== Input Validation Security Tests ==="
-
-    test_input_validation
-    test_sqlite_query_safety
-
-    echo "=== All Security Tests Passed ==="
-}
-
-# Run tests
+#!/usr/bin/env bash
+# Input Validation and Security Test Suite
+# Validates input handling and prevents potential injection scenarios
+
+set -euo pipefail
+
+# Input validation (SQL injection prevention)
+validate_identifier() {
+    local input="$1"
+    local max_length="${2:-255}"
+    if ! [[ "$input" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+        echo "ERROR: Invalid identifier (alphanumeric + underscore/hyphen only): $input" >&2
+        return 1
+    fi
+    if [ ${#input} -gt $max_length ]; then
+        echo "ERROR: Identifier exceeds max length ($max_length chars)" >&2
+        return 1
+    fi
+    return 0
+}
+
+# Source the main script to access validation functions
+source "$(dirname "$0")/.claude/skills/cfn-cfn-test-integration.sh"
+
+# Test Cases for validate_input function
+test_input_validation() {
+    local test_cases=(
+        "valid_task_id:integration-test-task:task_id:pass"
+        "valid_agent_id:test-agent-1:agent_id:pass"
+        "invalid_task_id_with_space:test task:task_id:fail"
+        "invalid_task_id_with_special_chars:test@task:task_id:fail"
+        "invalid_agent_id_with_special_chars:test!agent:agent_id:fail"
+    )
+
+    for test_case in "${test_cases[@]}"; do
+        local name=$(echo "$test_case" | cut -d: -f1)
+        local input=$(echo "$test_case" | cut -d: -f2)
+        local input_type=$(echo "$test_case" | cut -d: -f3)
+        local expected=$(echo "$test_case" | cut -d: -f4)
+
+        echo "Running test case: $name"
+
+        if [[ "$expected" == "pass" ]]; then
+            validate_input "$input" "$input_type"
+            echo "✅ PASS: $name - Successfully validated"
+        else
+            set +e
+            validate_input "$input" "$input_type" 2>/dev/null
+            local exit_code=$?
+            set -e
+
+            if [ "$exit_code" -ne 0 ]; then
+                echo "✅ PASS: $name - Correctly rejected invalid input"
+            else
+                echo "❌ FAIL: $name - Failed to reject invalid input"
+                exit 1
+            fi
+        fi
+    done
+}
+
+# Test SQLite Query Safety
+test_sqlite_query_safety() {
+    local db_file=$(mktemp)
+    local bad_input="'; DROP TABLE agent_memory; --"
+
+    # Setup test database
+    sqlite3 "$db_file" <<EOF
+CREATE TABLE agent_memory (
+    task_id TEXT,
+    event_data TEXT
+);
+INSERT INTO agent_memory VALUES ('test-task', 'sample data');
+EOF
+
+    # Attempt query with malicious input
+    set +e
+    local query_result=$(sqlite3 "$db_file" \
+        "SELECT COUNT(*) FROM agent_memory WHERE task_id = '$bad_input';" 2>/dev/null)
+    local exit_code=$?
+    set -e
+
+    # Verify query did not modify the database
+    local row_count=$(sqlite3 "$db_file" "SELECT COUNT(*) FROM agent_memory;")
+
+    if [ "$row_count" -eq 1 ] && [ "$exit_code" -eq 0 ]; then
+        echo "✅ PASS: SQLite query safety - Malicious input contained"
+    else
+        echo "❌ FAIL: SQLite query safety - Potential vulnerability"
+        exit 1
+    fi
+
+    # Cleanup
+    rm -f "$db_file"
+}
+
+# Main test runner
+main() {
+    echo "=== Input Validation Security Tests ==="
+
+    test_input_validation
+    test_sqlite_query_safety
+
+    echo "=== All Security Tests Passed ==="
+}
+
+# Run tests
 main

package/claude-assets/skills/cfn-transparency-middleware/wrap-agent.sh

@@ -1,132 +1,132 @@
-#!/usr/bin/env bash
-# Transparency Middleware Wrapper
-# Wraps agent execution with automatic memory capture
-
-# Strict error handling
-set -euo pipefail
-
-# Logging configuration
-LOG_DIR="/var/log/claude-flow/transparency-middleware"
-TIMESTAMP=$(date +"%Y%m%d_%H%M%S")
-
-# Validate input arguments
-if [[ $# -lt 3 ]]; then
-    echo "Error: Insufficient arguments" >&2
-    echo "Usage: $0 <AGENT_ROLE> <AGENT_ID> <TASK_ID> [ADDITIONAL_ARGS...]" >&2
-    exit 1
-fi
-
-# Parse arguments
-AGENT_ROLE="$1"
-AGENT_ID="$2"
-TASK_ID="$3"
-shift 3  # Remove first three arguments, leaving any additional args
-
-# Create log directory if it doesn't exist
-mkdir -p "${LOG_DIR}/${TASK_ID}"
-
-# Initialize middleware and pre-execution hooks
-initialize_middleware() {
-    node -e "
-    import {TransparencyMiddleware} from '.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-src/middleware/transparency-middleware.js';
-    const middleware = new TransparencyMiddleware();
-    await middleware.initialize({
-        agentRole: '${AGENT_ROLE}',
-        agentId: '${AGENT_ID}',
-        taskId: '${TASK_ID}'
-    });
-    await middleware.preExecutionHook();
-    " || {
-        echo "Middleware initialization failed" >&2
-        exit 2
-    }
-}
-
-# Capture execution metrics
-execute_agent() {
-    local log_file="${LOG_DIR}/${TASK_ID}/${AGENT_ID}_${TIMESTAMP}.log"
-    local metrics_file="${LOG_DIR}/${TASK_ID}/${AGENT_ID}_${TIMESTAMP}_metrics.json"
-
-    # Start time capture
-    local start_time=$(date +%s.%N)
-
-    # Execute the actual agent command with all remaining arguments
-    # Redirect output to log file
-    if ! "$@" 2>&1 | tee "${log_file}"; then
-        local exit_code=${PIPESTATUS[0]}
-
-        # Capture error metrics
-        node -e "
-        import fs from 'fs';
-        import {TransparencyMiddleware} from '.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-src/middleware/transparency-middleware.js';
-        const middleware = new TransparencyMiddleware();
-
-        const metrics = {
-            taskId: '${TASK_ID}',
-            agentId: '${AGENT_ID}',
-            agentRole: '${AGENT_ROLE}',
-            startTime: ${start_time},
-            endTime: $(date +%s.%N),
-            exitCode: ${exit_code},
-            status: 'FAILED'
-        };
-
-        await middleware.postExecutionHook(metrics);
-        fs.writeFileSync('${metrics_file}', JSON.stringify(metrics, null, 2));
-        " || echo "Error tracking failed"
-
-        return ${exit_code}
-    fi
-
-    # Capture successful execution metrics
-    node -e "
-    import fs from 'fs';
-    import {TransparencyMiddleware} from '.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-src/middleware/transparency-middleware.js';
-    const middleware = new TransparencyMiddleware();
-
-    const metrics = {
-        taskId: '${TASK_ID}',
-        agentId: '${AGENT_ID}',
-        agentRole: '${AGENT_ROLE}',
-        startTime: ${start_time},
-        endTime: $(date +%s.%N),
-        exitCode: 0,
-        status: 'SUCCESS'
-    };
-
-    await middleware.postExecutionHook(metrics);
-    fs.writeFileSync('${metrics_file}', JSON.stringify(metrics, null, 2));
-    " || echo "Metrics tracking failed"
-}
-
-# Main execution flow
-main() {
-    # Initialize middleware before execution
-    initialize_middleware
-
-    # Execute agent with remaining arguments
-    execute_agent "$@"
-}
-
-# Execute main function and capture its exit status
-main "$@"
-exit_status=$?
-
-# Signal completion to Redis coordination
-redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete" > /dev/null
-
-# Invoke waiting mode report
-./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
-  --task-id "${TASK_ID}" \
-  --agent-id "${AGENT_ID}" \
-  --confidence 0.80 \
-  --iteration 1
-
-# Enter waiting mode
-./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh enter \
-  --task-id "${TASK_ID}" \
-  --agent-id "${AGENT_ID}" \
-  --context "iteration-1-complete"
-
-# Exit with original command's exit status
+#!/usr/bin/env bash
+# Transparency Middleware Wrapper
+# Wraps agent execution with automatic memory capture
+
+# Strict error handling
+set -euo pipefail
+
+# Logging configuration
+LOG_DIR="/var/log/claude-flow/transparency-middleware"
+TIMESTAMP=$(date +"%Y%m%d_%H%M%S")
+
+# Validate input arguments
+if [[ $# -lt 3 ]]; then
+    echo "Error: Insufficient arguments" >&2
+    echo "Usage: $0 <AGENT_ROLE> <AGENT_ID> <TASK_ID> [ADDITIONAL_ARGS...]" >&2
+    exit 1
+fi
+
+# Parse arguments
+AGENT_ROLE="$1"
+AGENT_ID="$2"
+TASK_ID="$3"
+shift 3  # Remove first three arguments, leaving any additional args
+
+# Create log directory if it doesn't exist
+mkdir -p "${LOG_DIR}/${TASK_ID}"
+
+# Initialize middleware and pre-execution hooks
+initialize_middleware() {
+    node -e "
+    import {TransparencyMiddleware} from '.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-src/middleware/transparency-middleware.js';
+    const middleware = new TransparencyMiddleware();
+    await middleware.initialize({
+        agentRole: '${AGENT_ROLE}',
+        agentId: '${AGENT_ID}',
+        taskId: '${TASK_ID}'
+    });
+    await middleware.preExecutionHook();
+    " || {
+        echo "Middleware initialization failed" >&2
+        exit 2
+    }
+}
+
+# Capture execution metrics
+execute_agent() {
+    local log_file="${LOG_DIR}/${TASK_ID}/${AGENT_ID}_${TIMESTAMP}.log"
+    local metrics_file="${LOG_DIR}/${TASK_ID}/${AGENT_ID}_${TIMESTAMP}_metrics.json"
+
+    # Start time capture
+    local start_time=$(date +%s.%N)
+
+    # Execute the actual agent command with all remaining arguments
+    # Redirect output to log file
+    if ! "$@" 2>&1 | tee "${log_file}"; then
+        local exit_code=${PIPESTATUS[0]}
+
+        # Capture error metrics
+        node -e "
+        import fs from 'fs';
+        import {TransparencyMiddleware} from '.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-src/middleware/transparency-middleware.js';
+        const middleware = new TransparencyMiddleware();
+
+        const metrics = {
+            taskId: '${TASK_ID}',
+            agentId: '${AGENT_ID}',
+            agentRole: '${AGENT_ROLE}',
+            startTime: ${start_time},
+            endTime: $(date +%s.%N),
+            exitCode: ${exit_code},
+            status: 'FAILED'
+        };
+
+        await middleware.postExecutionHook(metrics);
+        fs.writeFileSync('${metrics_file}', JSON.stringify(metrics, null, 2));
+        " || echo "Error tracking failed"
+
+        return ${exit_code}
+    fi
+
+    # Capture successful execution metrics
+    node -e "
+    import fs from 'fs';
+    import {TransparencyMiddleware} from '.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-.claude/skills/cfn-cfn-src/middleware/transparency-middleware.js';
+    const middleware = new TransparencyMiddleware();
+
+    const metrics = {
+        taskId: '${TASK_ID}',
+        agentId: '${AGENT_ID}',
+        agentRole: '${AGENT_ROLE}',
+        startTime: ${start_time},
+        endTime: $(date +%s.%N),
+        exitCode: 0,
+        status: 'SUCCESS'
+    };
+
+    await middleware.postExecutionHook(metrics);
+    fs.writeFileSync('${metrics_file}', JSON.stringify(metrics, null, 2));
+    " || echo "Metrics tracking failed"
+}
+
+# Main execution flow
+main() {
+    # Initialize middleware before execution
+    initialize_middleware
+
+    # Execute agent with remaining arguments
+    execute_agent "$@"
+}
+
+# Execute main function and capture its exit status
+main "$@"
+exit_status=$?
+
+# Signal completion to Redis coordination
+redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete" > /dev/null
+
+# Invoke waiting mode report
+./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
+  --task-id "${TASK_ID}" \
+  --agent-id "${AGENT_ID}" \
+  --confidence 0.80 \
+  --iteration 1
+
+# Enter waiting mode
+./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh enter \
+  --task-id "${TASK_ID}" \
+  --agent-id "${AGENT_ID}" \
+  --context "iteration-1-complete"
+
+# Exit with original command's exit status
 exit ${exit_status}