claude-flow-novice 2.15.2 → 2.15.4

package/.claude/skills/cfn-sqlite-memory/ttl-cleanup.sh

@@ -6,6 +6,10 @@
 
 set -e  # Exit on error
 
+# Source parameterized query library for SQL injection prevention
+PROJECT_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+source "$PROJECT_ROOT/.claude/skills/bootstrap/sqlite-params.sh"
+
 # Configuration
 DB_PATH="${DB_PATH:-./swarm-memory.db}"
 REDIS_HOST="${REDIS_HOST:-localhost}"
@@ -66,28 +70,20 @@ EOF
 cleanup_acl_level() {
     local acl_level=$1
     local retention_days=$2
-    
+
     log "Cleaning up ACL Level $acl_level entries older than $retention_days days..."
-    
-    # SQLite cleanup query
-    local cleanup_sql="
-    DELETE FROM memory_store 
-    WHERE acl_level = $acl_level 
-    AND expires_at <= datetime('now', '-$retention_days days')
-    AND acl_level != 5; -- Skip system audit logs (level 5)
-    "
-    
+
     if [ "$DRY_RUN" = "true" ]; then
-        # Count what would be deleted
-        local count=$(sqlite3 "$DB_PATH" "SELECT COUNT(*) FROM memory_store WHERE acl_level = $acl_level AND expires_at <= datetime('now', '-$retention_days days') AND acl_level != 5;")
+        # Count what would be deleted - using parameterized query
+        local count=$(sqlite_select "$DB_PATH" "SELECT COUNT(*) FROM memory_store WHERE acl_level = ?1 AND expires_at <= datetime('now', '-' || ?2 || ' days') AND acl_level != 5;" "$acl_level" "$retention_days")
         log "[DRY RUN] Would delete $count entries from ACL Level $acl_level"
         return 0
     fi
-    
-    # Execute cleanup
-    local deleted_count=$(sqlite3 "$DB_PATH" "$cleanup_sql")
-    log "Deleted $deleted_count entries from ACL Level $acl_level"
-    
+
+    # Execute cleanup - using parameterized query (Pattern B)
+    sqlite_delete "$DB_PATH" "DELETE FROM memory_store WHERE acl_level = ?1 AND expires_at <= datetime('now', '-' || ?2 || ' days') AND acl_level != 5;" "$acl_level" "$retention_days"
+    log "Deleted entries from ACL Level $acl_level"
+
     # Sync with Redis if available
     if check_redis; then
         sync_redis_cleanup "$acl_level"
@@ -100,12 +96,8 @@ sync_redis_cleanup() {
     
     log "Syncing Redis cleanup for ACL Level $acl_level..."
     
-    # Get keys that should be removed from Redis
-    local redis_keys=$(sqlite3 "$DB_PATH" "
-    SELECT key FROM memory_store 
-    WHERE acl_level = $acl_level 
-    AND expires_at <= datetime('now')
-    ")
+    # Get keys that should be removed from Redis - using parameterized query
+    local redis_keys=$(sqlite_select "$DB_PATH" "SELECT key FROM memory_store WHERE acl_level = ?1 AND expires_at <= datetime('now')" "$acl_level")
     
     # Remove from Redis
     while IFS= read -r key; do
@@ -138,8 +130,8 @@ cleanup_redis_ttl() {
                 # Key doesn't exist in Redis but exists in SQLite (stale)
                 redis-cli -h "$REDIS_HOST" -p "$REDIS_PORT" DEL "$key" > /dev/null 2>&1 || true
             elif [ "$ttl" -eq -1 ]; then
-                # Key has no TTL, check if it should have one based on ACL level
-                local acl_level=$(sqlite3 "$DB_PATH" "SELECT acl_level FROM memory_store WHERE key = '$key' LIMIT 1")
+                # Key has no TTL, check if it should have one based on ACL level - using parameterized query
+                local acl_level=$(sqlite_select "$DB_PATH" "SELECT acl_level FROM memory_store WHERE key = ?1 LIMIT 1" "$key")
                 if [ -n "$acl_level" ] && [ "$acl_level" -le 4 ]; then
                     # Should have TTL, remove it
                     redis-cli -h "$REDIS_HOST" -p "$REDIS_PORT" DEL "$key" > /dev/null 2>&1 || true

package/.claude/skills/cfn-transparency-middleware/middleware-config.sh

@@ -1,29 +1,29 @@
-#!/bin/bash
-
-# Transparency Middleware Configuration
-# Version: 1.0.0
-
-# Redis Configuration
-export REDIS_HOST="${REDIS_HOST:-localhost}"
-export REDIS_PORT="${REDIS_PORT:-6379}"
-
-# Transparency Levels
-TRANSPARENCY_LEVELS=(
-    "minimal"    # Minimal logging, low overhead
-    "detailed"   # Standard operational insights
-    "verbose"    # Comprehensive logging
-    "debug"      # Maximum verbosity and tracing
-)
-
-# Performance Thresholds
-export MAX_OVERHEAD_PERCENTAGE=5
-export MAX_MESSAGE_LATENCY_MS=50
-export MAX_MEMORY_USAGE_MB=10
-
-# Logging Configuration
-export LOG_RETENTION_DAYS=7
-export LOG_MAX_SIZE_MB=100
-
-# Test-specific Configuration
-export TEST_TIMEOUT_SECONDS=30
+#!/bin/bash
+
+# Transparency Middleware Configuration
+# Version: 1.0.0
+
+# Redis Configuration
+export REDIS_HOST="${REDIS_HOST:-localhost}"
+export REDIS_PORT="${REDIS_PORT:-6379}"
+
+# Transparency Levels
+TRANSPARENCY_LEVELS=(
+    "minimal"    # Minimal logging, low overhead
+    "detailed"   # Standard operational insights
+    "verbose"    # Comprehensive logging
+    "debug"      # Maximum verbosity and tracing
+)
+
+# Performance Thresholds
+export MAX_OVERHEAD_PERCENTAGE=5
+export MAX_MESSAGE_LATENCY_MS=50
+export MAX_MEMORY_USAGE_MB=10
+
+# Logging Configuration
+export LOG_RETENTION_DAYS=7
+export LOG_MAX_SIZE_MB=100
+
+# Test-specific Configuration
+export TEST_TIMEOUT_SECONDS=30
 export TEST_MESSAGE_COUNT=1000

package/.claude/skills/cfn-transparency-middleware/performance-benchmark.sh

@@ -1,79 +1,79 @@
-#!/bin/bash
-
-# Performance Benchmarking for Transparency Middleware
-# Version: 1.0.0
-# Measures message throughput, overhead, and memory usage
-
-set -euo pipefail
-
-# Source configuration
-source .claude/skills/cfn-transparency-middleware/middleware-config.sh
-
-# Benchmarking results file
-BENCHMARK_RESULTS="/tmp/transparency_benchmark_$(date +%Y%m%d_%H%M%S).json"
-
-# Performance Test Parameters
-TOTAL_MESSAGES=10000
-CONCURRENCY_LEVELS=(1 10 100)
-
-measure_performance() {
-    local concurrency="$1"
-    local start_time=$(date +%s.%N)
-    local peak_memory=0
-    local total_cpu_usage=0
-
-    # Simulate message processing
-    for ((i=0; i<TOTAL_MESSAGES; i++)); do
-        ./invoke-transparency-middleware.sh process \
-            --concurrency "$concurrency" \
-            --message-id "$i" &
-    done
-
-    wait
-
-    local end_time=$(date +%s.%N)
-    local duration=$(echo "$end_time - $start_time" | bc)
-    local messages_per_second=$(echo "$TOTAL_MESSAGES / $duration" | bc)
-
-    # Record performance metrics
-    jq -n \
-        --arg concurrency "$concurrency" \
-        --arg messages_total "$TOTAL_MESSAGES" \
-        --arg duration "$duration" \
-        --arg messages_per_second "$messages_per_second" \
-        '{
-            "concurrency": $concurrency,
-            "total_messages": $messages_total,
-            "duration_seconds": $duration,
-            "messages_per_second": $messages_per_second
-        }' > "$BENCHMARK_RESULTS"
-
-    # Validate performance
-    validate_performance "$messages_per_second"
-}
-
-validate_performance() {
-    local messages_per_second="$1"
-    local max_threshold=5000  # Adjust based on your system capabilities
-
-    if (( $(echo "$messages_per_second < $max_threshold" | bc -l) )); then
-        echo "Performance Test PASSED"
-        redis-cli publish "swarm:sprint-1.2:performance" "benchmark_passed:1.0"
-    else
-        echo "Performance Test FAILED"
-        redis-cli publish "swarm:sprint-1.2:performance" "benchmark_failed:0.0"
-        exit 1
-    fi
-}
-
-main() {
-    echo "Starting Transparency Middleware Performance Benchmarks"
-
-    for concurrency in "${CONCURRENCY_LEVELS[@]}"; do
-        measure_performance "$concurrency"
-    done
-
-    cat "$BENCHMARK_RESULTS"
-}
-
+#!/bin/bash
+
+# Performance Benchmarking for Transparency Middleware
+# Version: 1.0.0
+# Measures message throughput, overhead, and memory usage
+
+set -euo pipefail
+
+# Source configuration
+source .claude/skills/cfn-transparency-middleware/middleware-config.sh
+
+# Benchmarking results file
+BENCHMARK_RESULTS="/tmp/transparency_benchmark_$(date +%Y%m%d_%H%M%S).json"
+
+# Performance Test Parameters
+TOTAL_MESSAGES=10000
+CONCURRENCY_LEVELS=(1 10 100)
+
+measure_performance() {
+    local concurrency="$1"
+    local start_time=$(date +%s.%N)
+    local peak_memory=0
+    local total_cpu_usage=0
+
+    # Simulate message processing
+    for ((i=0; i<TOTAL_MESSAGES; i++)); do
+        ./invoke-transparency-middleware.sh process \
+            --concurrency "$concurrency" \
+            --message-id "$i" &
+    done
+
+    wait
+
+    local end_time=$(date +%s.%N)
+    local duration=$(echo "$end_time - $start_time" | bc)
+    local messages_per_second=$(echo "$TOTAL_MESSAGES / $duration" | bc)
+
+    # Record performance metrics
+    jq -n \
+        --arg concurrency "$concurrency" \
+        --arg messages_total "$TOTAL_MESSAGES" \
+        --arg duration "$duration" \
+        --arg messages_per_second "$messages_per_second" \
+        '{
+            "concurrency": $concurrency,
+            "total_messages": $messages_total,
+            "duration_seconds": $duration,
+            "messages_per_second": $messages_per_second
+        }' > "$BENCHMARK_RESULTS"
+
+    # Validate performance
+    validate_performance "$messages_per_second"
+}
+
+validate_performance() {
+    local messages_per_second="$1"
+    local max_threshold=5000  # Adjust based on your system capabilities
+
+    if (( $(echo "$messages_per_second < $max_threshold" | bc -l) )); then
+        echo "Performance Test PASSED"
+        redis-cli publish "swarm:sprint-1.2:performance" "benchmark_passed:1.0"
+    else
+        echo "Performance Test FAILED"
+        redis-cli publish "swarm:sprint-1.2:performance" "benchmark_failed:0.0"
+        exit 1
+    fi
+}
+
+main() {
+    echo "Starting Transparency Middleware Performance Benchmarks"
+
+    for concurrency in "${CONCURRENCY_LEVELS[@]}"; do
+        measure_performance "$concurrency"
+    done
+
+    cat "$BENCHMARK_RESULTS"
+}
+
 main

package/.claude/skills/cfn-transparency-middleware/test-e2e.sh

@@ -4,6 +4,21 @@
 
 set -euo pipefail
 
+# Input validation (SQL injection prevention)
+validate_identifier() {
+    local input="$1"
+    local max_length="${2:-255}"
+    if ! [[ "$input" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+        echo "ERROR: Invalid identifier (alphanumeric + underscore/hyphen only): $input" >&2
+        return 1
+    fi
+    if [ ${#input} -gt $max_length ]; then
+        echo "ERROR: Identifier exceeds max length ($max_length chars)" >&2
+        return 1
+    fi
+    return 0
+}
+
 # Test configuration
 TEST_TASK_ID="e2e-test-$(date +%s)"
 TEST_AGENT_ID="backend-dev-e2e"

package/.claude/skills/cfn-transparency-middleware/test-integration.sh

@@ -1,162 +1,162 @@
-#!/usr/bin/env bash
-# Integration test: Transparency middleware with CFN Loop orchestrator
-# Validates middleware initialization, agent wrapping, and memory capture
-
-set -euo pipefail
-
-# Enhanced logging function with security audit trail
-log() {
-    local level="$1"
-    local message="$2"
-    local timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
-    local caller_info=$(caller)
-
-    # Log to syslog for security tracking
-    logger -p local0.notice -t "interaction-tester" \
-        "SECURITY_AUDIT: level=${level}, caller=${caller_info}, message=${message}"
-
-    echo "[${timestamp}] [${level}] [${caller_info}] ${message}"
-}
-
-# Strict input validation
-validate_input() {
-    local input="$1"
-    local input_type="$2"
-
-    case "$input_type" in
-        "task_id")
-            if [[ ! "$input" =~ ^[a-zA-Z0-9_-]+$ ]]; then
-                log "SECURITY_ERROR" "Invalid task_id format: ${input}"
-                exit 1
-            fi
-            ;;
-        "agent_id")
-            if [[ ! "$input" =~ ^[a-zA-Z0-9_-]+$ ]]; then
-                log "SECURITY_ERROR" "Invalid agent_id format: ${input}"
-                exit 1
-            fi
-            ;;
-        *)
-            log "SECURITY_ERROR" "Unknown input type: ${input_type}"
-            exit 1
-            ;;
-    esac
-}
-
-# Error handling wrapper with extensive logging
-safe_execute() {
-    local command="$1"
-    local error_message="${2:-Execution failed}"
-    local log_file="/tmp/interaction_tester_$(date +%s).log"
-
-    # Redirect command output to log file for detailed tracing
-    set +e
-    eval "$command" > >(tee -a "$log_file") 2> >(tee -a "$log_file" >&2)
-    local exit_code=$?
-    set -e
-
-    if [ $exit_code -ne 0 ]; then
-        log "ERROR" "$error_message (Exit code: $exit_code)"
-        log "ERROR" "Detailed logs in: $log_file"
-
-        # Signal failure to Redis coordination with log reference
-        redis-cli lpush "swarm:sprint-1.3-testing:interaction-tester:error" \
-            "integration_test_failure:${log_file}" >/dev/null
-
-        exit 1
-    fi
-
-    # Cleanup log file after successful execution
-    rm -f "$log_file"
-}
-
-# Dependency check
-check_dependencies() {
-    local dependencies=("node" "sqlite3" "redis-cli" "jq")
-    for dep in "${dependencies[@]}"; do
-        if ! command -v "$dep" &> /dev/null; then
-            log "ERROR" "Dependency not found: $dep"
-            exit 1
-        fi
-    done
-}
-
-main() {
-    log "INFO" "=== Transparency Middleware Integration Test ==="
-
-    # Check dependencies
-    check_dependencies
-
-    # 1. Initialize middleware
-    log "INFO" "Initializing Transparency Middleware"
-    safe_execute "node -e \"
-        import TransparencyMiddleware from './src/middleware/transparency-middleware.js';
-        const config = TransparencyMiddleware.loadConfig('./.claude/skills/cfn-transparency-middleware/config.json');
-        const middleware = new TransparencyMiddleware(config);
-        await middleware.initialize();
-        console.log('Middleware initialized successfully');
-    \"" "Middleware initialization failed"
-
-    # 2. Spawn test agent with middleware wrapper
-    log "INFO" "Spawning test agent"
-    safe_execute "./.claude/skills/cfn-transparency-middleware/wrap-agent.sh \
-        \"backend-dev\" \
-        \"test-agent-1\" \
-        \"integration-test-task\" \
-        \"echo 'Test execution'\"" "Agent wrapping failed"
-
-    # 3. Verify memory was captured
-    log "INFO" "Verifying memory capture"
-
-    # Validate task_id using strict input validation
-    TASK_ID="integration-test-task"
-    validate_input "$TASK_ID" "task_id"
-
-    # Prepared statement with parameterized query
-    MEMORY_COUNT=$(safe_execute "sqlite3 -csv .claude/swarm-memory.db \
-        'SELECT COUNT(*) FROM agent_memory WHERE task_id = ?;' '$TASK_ID'" "SQLite query failed")
-
-    if [ "$MEMORY_COUNT" -eq 0 ]; then
-        log "ERROR" "No memory captured for task: $TASK_ID"
-
-        # Log additional diagnostic information
-        redis-cli lpush "swarm:sprint-1.3-testing:interaction-tester:memory_check" \
-            "task_id_length:${#TASK_ID},task_id_check:$TASK_ID" >/dev/null
-
-        exit 1
-    fi
-
-    log "INFO" "Memory captured: $MEMORY_COUNT events"
-
-    # 4. Verify Redis events emitted
-    log "INFO" "Checking Redis events"
-    REDIS_EVENTS=$(safe_execute "redis-cli llen \"agent:transparency\"" "Redis event count failed")
-    log "INFO" "Redis events: $REDIS_EVENTS"
-
-    # 5. Test query script
-    log "INFO" "Testing memory query script"
-    safe_execute "./.claude/skills/cfn-transparency-middleware/query-memory.sh \
-        \"integration-test-task\" \
-        \"*\" \
-        10 | jq '.' >/dev/null" "Memory query failed"
-
-    # CFN Protocol: Signal task completion
-    redis-cli lpush "swarm:sprint-1.3-testing:interaction-tester:done" "complete" >/dev/null
-
-    # Report confidence and enter waiting mode
-    ./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
-        --task-id "sprint-1.3-testing" \
-        --agent-id "interaction-tester" \
-        --confidence 0.95 \
-        --iteration 1
-
-    ./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh enter \
-        --task-id "sprint-1.3-testing" \
-        --agent-id "interaction-tester" \
-        --context "iteration-1-complete"
-
-    log "INFO" "✅ Integration test complete"
-}
-
-# Run the main function
+#!/usr/bin/env bash
+# Integration test: Transparency middleware with CFN Loop orchestrator
+# Validates middleware initialization, agent wrapping, and memory capture
+
+set -euo pipefail
+
+# Enhanced logging function with security audit trail
+log() {
+    local level="$1"
+    local message="$2"
+    local timestamp=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
+    local caller_info=$(caller)
+
+    # Log to syslog for security tracking
+    logger -p local0.notice -t "interaction-tester" \
+        "SECURITY_AUDIT: level=${level}, caller=${caller_info}, message=${message}"
+
+    echo "[${timestamp}] [${level}] [${caller_info}] ${message}"
+}
+
+# Strict input validation
+validate_input() {
+    local input="$1"
+    local input_type="$2"
+
+    case "$input_type" in
+        "task_id")
+            if [[ ! "$input" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+                log "SECURITY_ERROR" "Invalid task_id format: ${input}"
+                exit 1
+            fi
+            ;;
+        "agent_id")
+            if [[ ! "$input" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+                log "SECURITY_ERROR" "Invalid agent_id format: ${input}"
+                exit 1
+            fi
+            ;;
+        *)
+            log "SECURITY_ERROR" "Unknown input type: ${input_type}"
+            exit 1
+            ;;
+    esac
+}
+
+# Error handling wrapper with extensive logging
+safe_execute() {
+    local command="$1"
+    local error_message="${2:-Execution failed}"
+    local log_file="/tmp/interaction_tester_$(date +%s).log"
+
+    # Redirect command output to log file for detailed tracing
+    set +e
+    eval "$command" > >(tee -a "$log_file") 2> >(tee -a "$log_file" >&2)
+    local exit_code=$?
+    set -e
+
+    if [ $exit_code -ne 0 ]; then
+        log "ERROR" "$error_message (Exit code: $exit_code)"
+        log "ERROR" "Detailed logs in: $log_file"
+
+        # Signal failure to Redis coordination with log reference
+        redis-cli lpush "swarm:sprint-1.3-testing:interaction-tester:error" \
+            "integration_test_failure:${log_file}" >/dev/null
+
+        exit 1
+    fi
+
+    # Cleanup log file after successful execution
+    rm -f "$log_file"
+}
+
+# Dependency check
+check_dependencies() {
+    local dependencies=("node" "sqlite3" "redis-cli" "jq")
+    for dep in "${dependencies[@]}"; do
+        if ! command -v "$dep" &> /dev/null; then
+            log "ERROR" "Dependency not found: $dep"
+            exit 1
+        fi
+    done
+}
+
+main() {
+    log "INFO" "=== Transparency Middleware Integration Test ==="
+
+    # Check dependencies
+    check_dependencies
+
+    # 1. Initialize middleware
+    log "INFO" "Initializing Transparency Middleware"
+    safe_execute "node -e \"
+        import TransparencyMiddleware from './src/middleware/transparency-middleware.js';
+        const config = TransparencyMiddleware.loadConfig('./.claude/skills/cfn-transparency-middleware/config.json');
+        const middleware = new TransparencyMiddleware(config);
+        await middleware.initialize();
+        console.log('Middleware initialized successfully');
+    \"" "Middleware initialization failed"
+
+    # 2. Spawn test agent with middleware wrapper
+    log "INFO" "Spawning test agent"
+    safe_execute "./.claude/skills/cfn-transparency-middleware/wrap-agent.sh \
+        \"backend-dev\" \
+        \"test-agent-1\" \
+        \"integration-test-task\" \
+        \"echo 'Test execution'\"" "Agent wrapping failed"
+
+    # 3. Verify memory was captured
+    log "INFO" "Verifying memory capture"
+
+    # Validate task_id using strict input validation
+    TASK_ID="integration-test-task"
+    validate_input "$TASK_ID" "task_id"
+
+    # Prepared statement with parameterized query
+    MEMORY_COUNT=$(safe_execute "sqlite3 -csv .claude/swarm-memory.db \
+        'SELECT COUNT(*) FROM agent_memory WHERE task_id = ?;' '$TASK_ID'" "SQLite query failed")
+
+    if [ "$MEMORY_COUNT" -eq 0 ]; then
+        log "ERROR" "No memory captured for task: $TASK_ID"
+
+        # Log additional diagnostic information
+        redis-cli lpush "swarm:sprint-1.3-testing:interaction-tester:memory_check" \
+            "task_id_length:${#TASK_ID},task_id_check:$TASK_ID" >/dev/null
+
+        exit 1
+    fi
+
+    log "INFO" "Memory captured: $MEMORY_COUNT events"
+
+    # 4. Verify Redis events emitted
+    log "INFO" "Checking Redis events"
+    REDIS_EVENTS=$(safe_execute "redis-cli llen \"agent:transparency\"" "Redis event count failed")
+    log "INFO" "Redis events: $REDIS_EVENTS"
+
+    # 5. Test query script
+    log "INFO" "Testing memory query script"
+    safe_execute "./.claude/skills/cfn-transparency-middleware/query-memory.sh \
+        \"integration-test-task\" \
+        \"*\" \
+        10 | jq '.' >/dev/null" "Memory query failed"
+
+    # CFN Protocol: Signal task completion
+    redis-cli lpush "swarm:sprint-1.3-testing:interaction-tester:done" "complete" >/dev/null
+
+    # Report confidence and enter waiting mode
+    ./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
+        --task-id "sprint-1.3-testing" \
+        --agent-id "interaction-tester" \
+        --confidence 0.95 \
+        --iteration 1
+
+    ./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh enter \
+        --task-id "sprint-1.3-testing" \
+        --agent-id "interaction-tester" \
+        --context "iteration-1-complete"
+
+    log "INFO" "✅ Integration test complete"
+}
+
+# Run the main function
 main