chrome-devtools-frontend 1.0.981537 → 1.0.995491

package/scripts/eslint_rules/tests/inject_checkbox_styles_test.js

@@ -0,0 +1,127 @@
+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+const rule = require('../lib/inject_checkbox_styles.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+  parser: require.resolve('@typescript-eslint/parser'),
+});
+
+ruleTester.run('inject_checkbox_styles', rule, {
+  valid: [
+    {
+      code: `import * as Input from '../../input/input.js';
+      export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        connectedCallback() {
+          this.shadow.adoptedStyleSheets = [Input.checkboxStyles];
+        }
+
+        render() {
+          LitHtml.render(LitHtml.html\`<input type="checkbox" />\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/ui/components/datagrid/datagrid.ts',
+    },
+    // Nothing to do with checkboxes, so this rule should not apply.
+    {
+      code: `import * as Input from '../../input/input.js';
+      import {Foo} from './bar.js';
+
+      export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        connectedCallback() {
+          this.shadow.adoptedStyleSheets = [Input.textStyles, Foo.somethingElse];
+        }
+
+        render() {
+          LitHtml.render(LitHtml.html\`<input type="text" />\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/ui/components/datagrid/datagrid.ts',
+    },
+  ],
+  invalid: [
+    // No styles imported or adopted.
+    {
+      code: `export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        render() {
+          LitHtml.render(LitHtml.html\`<input type="checkbox" />\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/components/datagrid.ts',
+      errors: [{messageId: 'missingCheckboxStylesImport'}],
+    },
+
+    // Ensure we get one error per checkbox found in the LitHtml call.
+    {
+      code: `export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        render() {
+          LitHtml.render(LitHtml.html\`<div><input type="checkbox" /><input value=\${this.foo} type="checkbox" /></div>\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/components/datagrid.ts',
+      errors: [{messageId: 'missingCheckboxStylesImport'}, {messageId: 'missingCheckboxStylesImport'}],
+    },
+
+    // Importing not the right styles.
+    {
+      code: `import * as NotInputStyles from '../../wrong-import-path/input/input.js';
+      export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        connectedCallback() {
+          this.shadow.adoptedStylesheets = [NotInputStyles.NotCheckboxStyles];
+        }
+
+        render() {
+          LitHtml.render(LitHtml.html\`<input type="checkbox" />\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/ui/components/datagrid/datagrid.ts',
+      errors: [{messageId: 'missingCheckboxStylesImport'}],
+    },
+
+    // No adopting of the styles.
+    {
+      code: `import * as Input from '../../input/input.js';
+      export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        render() {
+          LitHtml.render(LitHtml.html\`<input type="checkbox" />\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/ui/components/datagrid/datagrid.ts',
+      errors: [{messageId: 'missingCheckboxStylesAdoption'}],
+    },
+
+    // Adopting the wrong styles
+    {
+      code: `import * as Input from '../../input/input.js';
+      import {fooStyles} from './who-knows.js';
+
+      export class Test extends HTMLElement {
+        private readonly shadow = this.attachShadow({mode: 'open'});
+
+        connectedCallback() {
+          this.shadow.adoptedStyleSheets = [fooStyles];
+        }
+
+        render() {
+          LitHtml.render(LitHtml.html\`<input type="checkbox" />\`, this.shadow, {host:this});
+        }
+      }`,
+      filename: 'front_end/ui/components/datagrid/datagrid.ts',
+      errors: [{messageId: 'missingCheckboxStylesAdoption'}],
+    },
+  ]
+});

package/front_end/models/issues_manager/descriptions/arAttributionEventSourceTriggerDataTooLarge.md

@@ -1,4 +0,0 @@
-# Ensure the event source trigger data doesn't exceed the 1-bit limit
-
-The `event-source-trigger-data` query parameter of an attribution redirect was truncated to the lowest 1 bit, because it was exceeding the limit.
-Replace the `event-source-trigger-data` parameter with an integer that respects the 1-bit limit, that is a number between 0 and 1.

package/front_end/models/issues_manager/descriptions/arAttributionTriggerDataTooLarge.md

@@ -1,4 +0,0 @@
-# Ensure the trigger data doesn't exceed the 3-bit limit
-
-The `trigger-data` query parameter of an attribution redirect was truncated to the lowest 3 bits, because it was exceeding the limit.
-Replace the `trigger-data` parameter with an integer that respects the 3-bit limit, that is a number between 0 and 7.

package/front_end/models/issues_manager/descriptions/arInvalidAttributionData.md

@@ -1,8 +0,0 @@
-# Ensure the "trigger-data" query parameter for an attribution redirect is a valid number
-
-The data associated with an attribution was defaulted to `0`.
-This happens if the `trigger-data` query parameter provided in the `.well-known` redirect
-is not a valid integer.
-
-Note that even if a valid integer is provided, only the lowest 3-bits of the `trigger-data` query parameter
-are recorded, with a 5% chance of the 3-bits being noised.

package/front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md

@@ -1,9 +0,0 @@
-# Ensure the "event-source-trigger-data" query parameter for an attribution redirect is a valid number
-
-The event-source trigger data associated with an attribution was defaulted to `0`.
-This happens if the `event-source-trigger-data` query parameter provided in the `.well-known`
-redirect is not a valid 64-bit unsigned integer.
-
-Note that even if a valid integer is provided, only the lowest 1-bit of the
-`event-source-trigger-data` query parameter is recorded, with a 5% chance of the 1 bit being
-noised.

package/front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md

@@ -1,5 +0,0 @@
-# Ensure the "dedup-key" query parameter for an attribution redirect is a valid number
-
-The dedup key associated with an attribution was defaulted to `null`.
-This happens if the `dedup-key` query parameter provided in the `.well-known` redirect is not a
-valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md

@@ -1,5 +0,0 @@
-# Ensure the "priority" query parameter for an attribution redirect is a valid number
-
-The priority associated with an attribution was defaulted to `0`.
-This happens if the `priority` query parameter provided in the `.well-known` redirect is not a
-valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arMissingAttributionData.md

@@ -1,7 +0,0 @@
-# Ensure the "trigger-data" query parameter for an attribution redirect is included
-
-The data associated with an attribution was defaulted to `0` because no `trigger-data`
-query parameter in the `.well-known` redirect was provided.
-
-Note that the `trigger-data` query parameter must be a valid integer and only the lowest 3-bits
-are recorded with a 5% chance of being noised.