chrome-devtools-frontend 1.0.1733843 → 1.0.1736236
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/tests/test-view-and-presenter-isolation.md +4 -4
- package/.agents/rules/ui-and-widgets/ui-declarative-tree-and-prompt-patterns.md +61 -0
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +11 -7
- package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +13 -4
- package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +31 -2
- package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +23 -4
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +34 -3
- package/.agents/skills/code-review/SKILL.md +27 -0
- package/.agents/skills/devtools-uistrings/SKILL.md +147 -0
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -1
- package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +100 -0
- package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +16 -0
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +13 -2
- package/.agents/skills/ui-widgets/SKILL.md +25 -25
- package/DIR_METADATA +8 -1
- package/docs/cookbook/localization.md +1 -1
- package/docs/ui_engineering.md +24 -0
- package/eslint.config.mjs +0 -1
- package/front_end/application_tokens.css +1 -1
- package/front_end/core/host/AidaClient.ts +147 -202
- package/front_end/core/host/AidaClientTypes.ts +9 -0
- package/front_end/core/host/AidaErrors.ts +416 -0
- package/front_end/core/host/AidaGcaTranslation.ts +11 -0
- package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -2
- package/front_end/core/host/UserMetrics.ts +25 -0
- package/front_end/core/host/UserMetricsEnums.ts +25 -0
- package/front_end/core/host/host.ts +3 -1
- package/front_end/core/i18n/collect-ui-strings.js +20 -0
- package/front_end/core/root/Runtime.ts +12 -0
- package/front_end/core/sdk/CPUThrottlingManager.ts +3 -0
- package/front_end/core/sdk/EnhancedTracesParser.ts +8 -4
- package/front_end/core/sdk/NetworkManager.ts +0 -6
- package/front_end/core/sdk/OverlayModel.ts +0 -6
- package/front_end/core/sdk/PreloadingModel.ts +30 -13
- package/front_end/core/sdk/PrivateVerificationTokensModel.ts +0 -18
- package/front_end/core/sdk/RehydratingConnection.ts +5 -2
- package/front_end/core/sdk/ResourceTreeModel.ts +0 -42
- package/front_end/core/sdk/ScreenCaptureModel.ts +0 -84
- package/front_end/core/sdk/ServiceWorkerCacheModel.ts +0 -15
- package/front_end/core/sdk/StorageBucketsModel.ts +0 -15
- package/front_end/devtools_compatibility.js +57 -2
- package/front_end/entrypoints/formatter_worker/ScopeParser.ts +4 -2
- package/front_end/entrypoints/inspector_main/RenderingOptions.ts +203 -127
- package/front_end/entrypoints/inspector_main/renderingOptions.css +5 -0
- package/front_end/entrypoints/node_app/app/NodeMain.ts +0 -9
- package/front_end/entrypoints/node_app/app/nodeConnectionsPanel.css +0 -22
- package/front_end/generated/InspectorBackendCommands.ts +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +0 -136
- package/front_end/generated/protocol-proxy-api.d.ts +231 -231
- package/front_end/generated/protocol.ts +1 -0
- package/front_end/models/ai_assistance/AiAgent2.ts +4 -1
- package/front_end/models/ai_assistance/ChangeManager.ts +3 -1
- package/front_end/models/ai_assistance/DOMHelpers.ts +118 -3
- package/front_end/models/ai_assistance/ExtensionScope.ts +31 -24
- package/front_end/models/ai_assistance/agents/AiAgent.ts +6 -0
- package/front_end/models/ai_assistance/agents/PerformanceAgent.snapshot.txt +13 -13
- package/front_end/models/ai_assistance/agents/PerformanceAgent.ts +1 -1
- package/front_end/models/ai_assistance/ai_assistance.ts +2 -0
- package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt +18 -8
- package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.ts +2 -2
- package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt +103 -81
- package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +15 -203
- package/front_end/models/ai_assistance/injected.ts +6 -1
- package/front_end/models/ai_assistance/skills/lighthouse.md +1 -1
- package/front_end/models/ai_assistance/skills/styling.md +8 -10
- package/front_end/models/ai_assistance/tools/GetTraceEventByKey.ts +1 -1
- package/front_end/models/ai_assistance/tools/SetElementStyles.ts +288 -0
- package/front_end/models/ai_assistance/tools/Tool.ts +1 -0
- package/front_end/models/ai_assistance/tools/ToolRegistry.ts +3 -0
- package/front_end/models/bindings/ResourceScriptMapping.ts +64 -16
- package/front_end/models/comment_manager/CD4ABridge.ts +12 -2
- package/front_end/models/comment_manager/CommentManager.ts +24 -4
- package/front_end/models/javascript_metadata/NativeFunctions.ts +41 -1
- package/front_end/models/project_settings/ProjectSettingsModel.ts +1 -1
- package/front_end/models/trace/handlers/FlowsHandler.ts +10 -0
- package/front_end/models/trace/handlers/SamplesHandler.ts +3 -2
- package/front_end/models/trace/handlers/ScriptsHandler.ts +25 -26
- package/front_end/models/trace/helpers/TreeHelpers.ts +4 -0
- package/front_end/models/trace/insights/DuplicatedJavaScript.ts +1 -2
- package/front_end/models/trace/types/TraceEvents.ts +21 -22
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +9 -1
- package/front_end/panels/ai_assistance/components/chatInput.css +4 -4
- package/front_end/panels/animation/AnimationTimeline.ts +3 -3
- package/front_end/panels/animation/animationTimeline.css +6 -4
- package/front_end/panels/application/IndexedDBModel.ts +0 -15
- package/front_end/panels/application/appManifestView.css +2 -5
- package/front_end/panels/application/components/backForwardCacheView.css +1 -5
- package/front_end/panels/application/components/serviceWorkerRouterView.css +2 -2
- package/front_end/panels/application/preloading/components/PreloadingString.ts +7 -0
- package/front_end/panels/comments/CommentsPane.ts +12 -7
- package/front_end/panels/comments/commentsPane.css +16 -2
- package/front_end/panels/common/CommentsOverlayWidget.ts +16 -10
- package/front_end/panels/common/CommentsStatusBarPill.ts +12 -5
- package/front_end/panels/common/commentsOverlay.css +7 -1
- package/front_end/panels/common/commentsStatusBarPill.css +30 -0
- package/front_end/panels/console/consolePrompt.css +0 -12
- package/front_end/panels/console/consoleView.css +2 -2
- package/front_end/panels/developer_resources/developerResourcesView.css +4 -3
- package/front_end/panels/elements/DOMTreeWidget.ts +29 -9
- package/front_end/panels/elements/StylePropertyTreeElement.ts +2 -1
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +12 -5
- package/front_end/panels/elements/components/cssVariableValueView.css +1 -1
- package/front_end/panels/elements/components/elementsBreadcrumbs.css +2 -2
- package/front_end/panels/elements/domTreeWidget.css +6 -1
- package/front_end/panels/elements/elementsPanel.css +0 -6
- package/front_end/panels/elements/layoutPane.css +1 -1
- package/front_end/panels/elements/metricsSidebarPane.css +1 -1
- package/front_end/panels/elements/platformFontsWidget.css +1 -1
- package/front_end/panels/elements/stylesSidebarPane.css +0 -10
- package/front_end/panels/emulation/deviceModeView.css +6 -7
- package/front_end/panels/explain/components/consoleInsight.css +4 -4
- package/front_end/panels/issues/issuesTree.css +1 -26
- package/front_end/panels/lighthouse/lighthouseStartView.css +2 -2
- package/front_end/panels/linear_memory_inspector/components/linearMemoryInspector.css +1 -1
- package/front_end/panels/media/TickingFlameChart.ts +20 -3
- package/front_end/panels/media/playerMessagesView.css +2 -2
- package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +24 -5
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +1 -6
- package/front_end/panels/network/networkLogView.css +2 -2
- package/front_end/panels/network/networkTimingTable.css +1 -1
- package/front_end/panels/performance_monitor/performanceMonitor.css +0 -4
- package/front_end/panels/protocol_monitor/JSONEditor.css +1 -1
- package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -2
- package/front_end/panels/recorder/recorderPanel.css +3 -3
- package/front_end/panels/recorder/recordingListView.css +1 -1
- package/front_end/panels/screencast/screencastView.css +1 -1
- package/front_end/panels/search/searchResultsPane.css +1 -1
- package/front_end/panels/security/SecurityModel.ts +0 -6
- package/front_end/panels/security/SecurityPanel.ts +120 -108
- package/front_end/panels/security/originView.css +1 -1
- package/front_end/panels/sensors/locationsSettingsTab.css +3 -3
- package/front_end/panels/settings/EditFileSystemView.ts +159 -104
- package/front_end/panels/settings/editFileSystemView.css +30 -4
- package/front_end/panels/settings/emulation/devicesSettingsTab.css +0 -52
- package/front_end/panels/settings/settingsScreen.css +0 -7
- package/front_end/panels/sources/CallStackSidebarPane.ts +339 -221
- package/front_end/panels/sources/NavigatorView.ts +95 -8
- package/front_end/panels/sources/ThreadsSidebarPane.ts +8 -4
- package/front_end/panels/sources/breakpointsView.css +1 -3
- package/front_end/panels/sources/callStackSidebarPane.css +4 -0
- package/front_end/panels/sources/components/HeadersView.ts +15 -2
- package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -1
- package/front_end/panels/timeline/CountersGraph.ts +0 -4
- package/front_end/panels/timeline/TimelineLoader.ts +16 -6
- package/front_end/panels/timeline/TimelinePanel.ts +20 -12
- package/front_end/panels/timeline/TimelineUIUtils.ts +1 -1
- package/front_end/panels/timeline/components/DetailsView.ts +2 -1
- package/front_end/panels/timeline/components/cwvMetrics.css +1 -1
- package/front_end/panels/timeline/components/metricCard.css +1 -1
- package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +4 -4
- package/front_end/panels/timeline/timelineFlameChartView.css +1 -1
- package/front_end/panels/webauthn/WebauthnPane.ts +13 -14
- package/front_end/panels/webauthn/webauthnPane.css +1 -1
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/ui/comments/CommentOverlayManager.ts +34 -18
- package/front_end/ui/components/icon_button/FileSourceIcon.ts +6 -0
- package/front_end/ui/components/input/textInput.css +1 -1
- package/front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css +6 -4
- package/front_end/ui/components/suggestion_input/suggestionInput.css +2 -2
- package/front_end/ui/components/text_editor/AiCodeGenerationTeaser.ts +14 -2
- package/front_end/ui/legacy/DockController.ts +17 -4
- package/front_end/ui/legacy/Treeoutline.ts +2 -2
- package/front_end/ui/legacy/UIUtils.ts +148 -10
- package/front_end/ui/legacy/components/inline_editor/bezierEditor.css +3 -2
- package/front_end/ui/legacy/components/perf_ui/chartViewport.css +2 -2
- package/front_end/ui/legacy/components/perf_ui/filmStripView.css +2 -2
- package/front_end/ui/legacy/components/perf_ui/pieChart.css +1 -1
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +5 -4
- package/front_end/ui/legacy/components/source_frame/imageView.css +1 -1
- package/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts +0 -3
- package/front_end/ui/legacy/components/utils/imagePreview.css +1 -1
- package/front_end/ui/legacy/inspectorCommon.css +1 -14
- package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +3 -2
- package/front_end/ui/legacy/listWidget.css +0 -18
- package/front_end/ui/legacy/theme_support/ThemeSupport.ts +44 -9
- package/front_end/ui/lit/strip-whitespace.ts +1 -1
- package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
- package/package.json +3 -3
- package/front_end/generated/Deprecation.ts +0 -471
- package/front_end/panels/accessibility/axBreadcrumbs.css +0 -155
- package/front_end/panels/network/requestHeadersTree.css +0 -226
- package/front_end/panels/recorder/startView.css +0 -38
- package/front_end/panels/security/ipProtectionView.css +0 -141
- package/front_end/ui/legacy/components/inline_editor/animationNameSwatch.css +0 -27
|
@@ -1,8 +1,6 @@
|
|
|
1
1
|
// Copyright 2021 The Chromium Authors
|
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
|
3
3
|
// found in the LICENSE file.
|
|
4
|
-
/* eslint-disable @devtools/no-imperative-dom-api */
|
|
5
|
-
/* eslint-disable @devtools/no-lit-render-outside-of-view */
|
|
6
4
|
|
|
7
5
|
/*
|
|
8
6
|
* Copyright (C) 2008 Apple Inc. All Rights Reserved.
|
|
@@ -29,6 +27,8 @@
|
|
|
29
27
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
30
28
|
*/
|
|
31
29
|
|
|
30
|
+
import '../../ui/kit/kit.js';
|
|
31
|
+
|
|
32
32
|
import * as Common from '../../core/common/common.js';
|
|
33
33
|
import * as Host from '../../core/host/host.js';
|
|
34
34
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
@@ -38,14 +38,16 @@ import * as Bindings from '../../models/bindings/bindings.js';
|
|
|
38
38
|
import * as Persistence from '../../models/persistence/persistence.js';
|
|
39
39
|
import * as StackTrace from '../../models/stack_trace/stack_trace.js';
|
|
40
40
|
import * as Workspace from '../../models/workspace/workspace.js';
|
|
41
|
-
import
|
|
41
|
+
import * as Input from '../../ui/components/input/input.js';
|
|
42
42
|
import * as UI from '../../ui/legacy/legacy.js';
|
|
43
|
-
import {Directives, html, render} from '../../ui/lit/lit.js';
|
|
43
|
+
import {Directives, html, type LitTemplate, nothing, render} from '../../ui/lit/lit.js';
|
|
44
44
|
import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
|
|
45
45
|
|
|
46
46
|
import callStackSidebarPaneStyles from './callStackSidebarPane.css.js';
|
|
47
47
|
import {QuickSourceView, SourcesPanel} from './SourcesPanel.js';
|
|
48
48
|
|
|
49
|
+
const {classMap, ifDefined} = Directives;
|
|
50
|
+
|
|
49
51
|
const UIStrings = {
|
|
50
52
|
/**
|
|
51
53
|
* @description Text in the call stack sidebar of the Sources panel
|
|
@@ -100,95 +102,182 @@ const UIStrings = {
|
|
|
100
102
|
const str_ = i18n.i18n.registerUIStrings('panels/sources/CallStackSidebarPane.ts', UIStrings);
|
|
101
103
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
102
104
|
|
|
103
|
-
|
|
105
|
+
export interface ViewInput {
|
|
106
|
+
showIgnoreListMessage: boolean;
|
|
107
|
+
showIgnoreListedChecked: boolean;
|
|
108
|
+
onIgnoreListCheckboxChange: (checked: boolean) => void;
|
|
109
|
+
notPaused: boolean;
|
|
110
|
+
warnings?: string;
|
|
111
|
+
items: Item[];
|
|
112
|
+
selectedItem: Item|null;
|
|
113
|
+
focusedItem: Item|null;
|
|
114
|
+
showIgnoreListed: boolean;
|
|
115
|
+
onItemClick: (item: Item) => void;
|
|
116
|
+
onItemActivate: (item: Item) => void;
|
|
117
|
+
onItemContextMenu: (item: Item, contextMenu: UI.ContextMenu.ContextMenu) => void;
|
|
118
|
+
onItemKeyDown: (item: Item, direction: 'ArrowUp'|'ArrowDown'|'Home'|'End') => void;
|
|
119
|
+
showMore: boolean;
|
|
120
|
+
onShowMore: () => void;
|
|
121
|
+
}
|
|
122
|
+
|
|
123
|
+
export type View = (input: ViewInput, output: undefined, target: HTMLElement|DocumentFragment) => void;
|
|
124
|
+
|
|
125
|
+
function getMissingDebugInfoTooltip(missingDebugInfo: StackTrace.StackTrace.MissingDebugInfo,
|
|
126
|
+
functionName: string|undefined): string {
|
|
127
|
+
const {resources, details} = convertMissingDebugInfo(missingDebugInfo, functionName);
|
|
128
|
+
const messages = resources.map(
|
|
129
|
+
r => i18nString(UIStrings.debugFileNotFound, {PH1: Common.ParsedURL.ParsedURL.extractName(r.resourceUrl)}));
|
|
130
|
+
return [details, ...messages].join('\n');
|
|
131
|
+
}
|
|
132
|
+
|
|
133
|
+
// clang-format off
|
|
134
|
+
export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement|DocumentFragment): void => {
|
|
135
|
+
const renderItem = (item: Item, index: number): LitTemplate => {
|
|
136
|
+
const isHidden = !input.showIgnoreListed && item.isIgnoreListed;
|
|
137
|
+
const isAsyncHeader = item.isAsyncHeader;
|
|
138
|
+
const isIgnoreListed = !isAsyncHeader && item.isIgnoreListed;
|
|
139
|
+
const hasFrame = Boolean(item.frame);
|
|
140
|
+
const isSelected = item === input.selectedItem;
|
|
141
|
+
const isFocused = item === input.focusedItem;
|
|
142
|
+
const missingDebugInfoTooltip = item.frame?.missingDebugInfo ?
|
|
143
|
+
getMissingDebugInfoTooltip(item.frame.missingDebugInfo, item.frame.sdkFrame.functionName) :
|
|
144
|
+
undefined;
|
|
145
|
+
|
|
146
|
+
const onKeyDown = (event: KeyboardEvent): void => {
|
|
147
|
+
if ((event.key === 'Enter' && !event.isComposing) || event.key === ' ') {
|
|
148
|
+
input.onItemActivate(item);
|
|
149
|
+
event.consume(true);
|
|
150
|
+
} else if (event.key === 'ArrowUp' || event.key === 'ArrowDown' || event.key === 'Home' || event.key === 'End') {
|
|
151
|
+
input.onItemKeyDown(item, event.key);
|
|
152
|
+
event.consume(true);
|
|
153
|
+
}
|
|
154
|
+
};
|
|
155
|
+
|
|
156
|
+
const onContextMenu = (event: Event): void => {
|
|
157
|
+
const contextMenu = new UI.ContextMenu.ContextMenu(event);
|
|
158
|
+
input.onItemContextMenu(item, contextMenu);
|
|
159
|
+
void contextMenu.show();
|
|
160
|
+
};
|
|
161
|
+
|
|
162
|
+
return html`
|
|
163
|
+
<div class=${classMap({
|
|
164
|
+
'call-frame-item': true,
|
|
165
|
+
'async-header': isAsyncHeader,
|
|
166
|
+
'ignore-listed-call-frame': isIgnoreListed,
|
|
167
|
+
selected: isSelected,
|
|
168
|
+
})}
|
|
169
|
+
role="option"
|
|
170
|
+
aria-setsize=${input.items.length}
|
|
171
|
+
aria-posinset=${index + 1}
|
|
172
|
+
aria-selected=${isSelected ? 'true' : 'false'}
|
|
173
|
+
aria-description=${ifDefined(isIgnoreListed ? i18nString(UIStrings.onIgnoreList) : undefined)}
|
|
174
|
+
aria-disabled=${ifDefined(!isAsyncHeader && !hasFrame ? 'true' : undefined)}
|
|
175
|
+
?hidden=${isHidden}
|
|
176
|
+
tabindex=${isFocused ? 0 : -1}
|
|
177
|
+
?autofocus=${isFocused && !isHidden}
|
|
178
|
+
jslog=${VisualLogging.item().track({
|
|
179
|
+
click: true,
|
|
180
|
+
resize: true,
|
|
181
|
+
keydown: 'ArrowUp|ArrowDown|PageUp|PageDown|Home|End|Enter|Space',
|
|
182
|
+
})}
|
|
183
|
+
@click=${() => input.onItemClick(item)}
|
|
184
|
+
@contextmenu=${onContextMenu}
|
|
185
|
+
@keydown=${onKeyDown}>
|
|
186
|
+
<div class="call-frame-item-title">
|
|
187
|
+
<div class="call-frame-title-text"
|
|
188
|
+
title=${ifDefined(!isAsyncHeader ? item.title : undefined)}>${item.title}</div>
|
|
189
|
+
</div>
|
|
190
|
+
${!isAsyncHeader ? html`
|
|
191
|
+
<div class="call-frame-location"
|
|
192
|
+
title=${item.linkText}>${Platform.StringUtilities.trimMiddle(item.linkText, 30)}</div>
|
|
193
|
+
` : nothing}
|
|
194
|
+
<devtools-icon .name=${'large-arrow-right-filled'} class="selected-call-frame-icon small"></devtools-icon>
|
|
195
|
+
${missingDebugInfoTooltip ? html`
|
|
196
|
+
<devtools-icon .name=${'warning-filled'} class="call-frame-warning-icon small"
|
|
197
|
+
title=${missingDebugInfoTooltip}></devtools-icon>
|
|
198
|
+
` : nothing}
|
|
199
|
+
</div>
|
|
200
|
+
`;
|
|
201
|
+
};
|
|
202
|
+
|
|
203
|
+
render(html`
|
|
204
|
+
<style>${Input.checkboxStyles}</style>
|
|
205
|
+
<style>${callStackSidebarPaneStyles}</style>
|
|
206
|
+
<div
|
|
207
|
+
class="ignore-listed-message"
|
|
208
|
+
?hidden=${!input.showIgnoreListMessage}>
|
|
209
|
+
<label class="ignore-listed-message-label">
|
|
210
|
+
<input type="checkbox" tabindex="0" class="ignore-listed-checkbox"
|
|
211
|
+
.checked=${input.showIgnoreListedChecked}
|
|
212
|
+
jslog=${VisualLogging.toggle('show-ignore-listed-frames').track({change: true})}
|
|
213
|
+
@change=${(e: Event) => {
|
|
214
|
+
if (e.target instanceof HTMLInputElement) {
|
|
215
|
+
input.onIgnoreListCheckboxChange(e.target.checked);
|
|
216
|
+
}
|
|
217
|
+
}} />
|
|
218
|
+
${i18nString(UIStrings.showIgnorelistedFrames)}
|
|
219
|
+
</label>
|
|
220
|
+
</div>
|
|
221
|
+
<div
|
|
222
|
+
class="gray-info-message"
|
|
223
|
+
?hidden=${!input.notPaused}
|
|
224
|
+
tabindex="-1">
|
|
225
|
+
${i18nString(UIStrings.notPaused)}
|
|
226
|
+
</div>
|
|
227
|
+
<div
|
|
228
|
+
class="call-frame-warnings-message"
|
|
229
|
+
?hidden=${!input.warnings}
|
|
230
|
+
tabindex="-1"
|
|
231
|
+
title=${ifDefined(input.warnings)}>
|
|
232
|
+
<devtools-icon .name=${'warning-filled'} class="call-frame-warning-icon small"></devtools-icon>
|
|
233
|
+
${i18nString(UIStrings.callFrameWarnings)}
|
|
234
|
+
</div>
|
|
235
|
+
<div class="call-frame-list"
|
|
236
|
+
role="listbox"
|
|
237
|
+
aria-label=${i18nString(UIStrings.callStack)}
|
|
238
|
+
tabindex="-1"
|
|
239
|
+
?hidden=${input.items.length === 0}>
|
|
240
|
+
${input.items.map((item, index) => renderItem(item, index))}
|
|
241
|
+
</div>
|
|
242
|
+
<div
|
|
243
|
+
class="show-more-message"
|
|
244
|
+
?hidden=${!input.showMore}>
|
|
245
|
+
<button class="link"
|
|
246
|
+
jslog=${VisualLogging.action('show-more').track({click: true})}
|
|
247
|
+
@click=${input.onShowMore}>${i18nString(UIStrings.showMore)}</button>
|
|
248
|
+
</div>
|
|
249
|
+
`, target, {container: {attributes: {jslog: `${VisualLogging.section('sources.callstack')}`}}});
|
|
250
|
+
};
|
|
251
|
+
// clang-format on
|
|
104
252
|
|
|
105
253
|
let callstackSidebarPaneInstance: CallStackSidebarPane;
|
|
106
254
|
|
|
107
|
-
export class CallStackSidebarPane extends UI.View.SimpleView implements
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
115
|
-
|
|
116
|
-
|
|
255
|
+
export class CallStackSidebarPane extends UI.View.SimpleView<DocumentFragment> implements
|
|
256
|
+
UI.ContextFlavorListener.ContextFlavorListener {
|
|
257
|
+
readonly #view: View;
|
|
258
|
+
|
|
259
|
+
#items: Item[] = [];
|
|
260
|
+
#focusedItem: Item|null = null;
|
|
261
|
+
#showIgnoreListed = false;
|
|
262
|
+
#showIgnoreListMessage = false;
|
|
263
|
+
#ignoreListCheckboxChecked = false;
|
|
264
|
+
#warnings?: string;
|
|
265
|
+
#hasMore = false;
|
|
117
266
|
private maxAsyncStackChainDepth = defaultMaxAsyncStackChainDepth;
|
|
118
|
-
private readonly updateItemThrottler = new Common.Throttler.Throttler(100);
|
|
119
|
-
private readonly scheduledForUpdateItems = new Set<Item>();
|
|
120
|
-
private muteActivateItem?: boolean;
|
|
121
267
|
|
|
122
268
|
#stackTrace: StackTrace.StackTrace.DebuggableStackTrace|null = null;
|
|
123
269
|
#flavorChangeId = 0;
|
|
124
270
|
|
|
125
|
-
|
|
126
|
-
|
|
127
|
-
|
|
271
|
+
constructor(
|
|
272
|
+
element?: HTMLElement,
|
|
273
|
+
view: View = DEFAULT_VIEW,
|
|
274
|
+
) {
|
|
275
|
+
super(element, {
|
|
128
276
|
title: i18nString(UIStrings.callStack),
|
|
129
277
|
viewId: 'sources.callstack',
|
|
130
|
-
useShadowDom:
|
|
131
|
-
});
|
|
132
|
-
|
|
133
|
-
const [ignoreListMessageRef, ignoreListCheckboxRef, notPausedRef, warningRef, showMoreRef] = [
|
|
134
|
-
createRef<HTMLElement>(),
|
|
135
|
-
createRef<HTMLInputElement>(),
|
|
136
|
-
createRef<HTMLElement>(),
|
|
137
|
-
createRef<HTMLElement>(),
|
|
138
|
-
createRef<HTMLElement>(),
|
|
139
|
-
];
|
|
140
|
-
const ignoreListCheckboxChanged = (): void => {
|
|
141
|
-
this.showIgnoreListed = Boolean(ignoreListCheckboxRef.value?.checked);
|
|
142
|
-
for (const item of this.items) {
|
|
143
|
-
this.refreshItem(item);
|
|
144
|
-
}
|
|
145
|
-
};
|
|
146
|
-
|
|
147
|
-
this.items = new UI.ListModel.ListModel();
|
|
148
|
-
this.list = new UI.ListControl.ListControl(this.items, this, UI.ListControl.ListMode.NonViewport);
|
|
149
|
-
this.list.element.addEventListener('contextmenu', this.onContextMenu.bind(this), false);
|
|
150
|
-
self.onInvokeElement(this.list.element, event => {
|
|
151
|
-
const item = this.list.itemForNode((event.target as Node | null));
|
|
152
|
-
if (item) {
|
|
153
|
-
this.activateItem(item);
|
|
154
|
-
event.consume(true);
|
|
155
|
-
}
|
|
278
|
+
useShadowDom: 'pure',
|
|
156
279
|
});
|
|
157
|
-
|
|
158
|
-
const onShowMoreClicked = (): void => {
|
|
159
|
-
this.maxAsyncStackChainDepth += defaultMaxAsyncStackChainDepth;
|
|
160
|
-
this.requestUpdate();
|
|
161
|
-
};
|
|
162
|
-
|
|
163
|
-
// clang-format off
|
|
164
|
-
render(html`
|
|
165
|
-
<style>${callStackSidebarPaneStyles}</style>
|
|
166
|
-
<div class='ignore-listed-message' ${ref(ignoreListMessageRef)}>
|
|
167
|
-
<label class='ignore-listed-message-label'>
|
|
168
|
-
<input type='checkbox' tabindex=0 class='ignore-listed-checkbox'
|
|
169
|
-
@change=${ignoreListCheckboxChanged} ${ref(ignoreListCheckboxRef)} />
|
|
170
|
-
${i18nString(UIStrings.showIgnorelistedFrames)}
|
|
171
|
-
</label>
|
|
172
|
-
</div>
|
|
173
|
-
<div class='gray-info-message' tabindex=-1 ${ref(notPausedRef)}>
|
|
174
|
-
${i18nString(UIStrings.notPaused)}
|
|
175
|
-
</div>
|
|
176
|
-
<div class='call-frame-warnings-message' tabindex=-1 ${ref(warningRef)}>
|
|
177
|
-
<devtools-icon .name=${'warning-filled'} class='call-frame-warning-icon small'></devtools-icon>
|
|
178
|
-
${i18nString(UIStrings.callFrameWarnings)}
|
|
179
|
-
</div>
|
|
180
|
-
${this.list.element}
|
|
181
|
-
<div class='show-more-message hidden' ${ref(showMoreRef)}>
|
|
182
|
-
<button class='link' @click=${onShowMoreClicked}>${i18nString(UIStrings.showMore)}</button>
|
|
183
|
-
</div>
|
|
184
|
-
`, this.contentElement);
|
|
185
|
-
// clang-format on
|
|
186
|
-
|
|
187
|
-
this.ignoreListMessageElement = ignoreListMessageRef.value as HTMLElement;
|
|
188
|
-
this.ignoreListCheckboxElement = ignoreListCheckboxRef.value as HTMLInputElement;
|
|
189
|
-
this.notPausedMessageElement = notPausedRef.value as HTMLElement;
|
|
190
|
-
this.callFrameWarningsElement = warningRef.value as HTMLElement;
|
|
191
|
-
this.showMoreMessageElement = showMoreRef.value as HTMLElement;
|
|
280
|
+
this.#view = view;
|
|
192
281
|
|
|
193
282
|
this.requestUpdate();
|
|
194
283
|
}
|
|
@@ -204,15 +293,43 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
204
293
|
return callstackSidebarPaneInstance;
|
|
205
294
|
}
|
|
206
295
|
|
|
296
|
+
override wasShown(): void {
|
|
297
|
+
super.wasShown();
|
|
298
|
+
this.requestUpdate();
|
|
299
|
+
}
|
|
300
|
+
|
|
301
|
+
#onIgnoreListCheckboxChanged(checked: boolean): void {
|
|
302
|
+
this.#ignoreListCheckboxChecked = checked;
|
|
303
|
+
this.#updateIgnoreListState();
|
|
304
|
+
if (!this.#isItemVisible(this.#focusedItem)) {
|
|
305
|
+
const activeItem = this.activeCallFrameItem();
|
|
306
|
+
this.#focusedItem = this.#isItemVisible(activeItem) ? activeItem : this.#firstVisibleItem();
|
|
307
|
+
}
|
|
308
|
+
this.requestUpdate();
|
|
309
|
+
}
|
|
310
|
+
|
|
311
|
+
#onShowMoreClicked(): void {
|
|
312
|
+
this.maxAsyncStackChainDepth += defaultMaxAsyncStackChainDepth;
|
|
313
|
+
this.#rebuildItems();
|
|
314
|
+
this.requestUpdate();
|
|
315
|
+
}
|
|
316
|
+
|
|
317
|
+
#onStackTraceUpdated(): void {
|
|
318
|
+
this.#rebuildItems();
|
|
319
|
+
this.requestUpdate();
|
|
320
|
+
}
|
|
321
|
+
|
|
207
322
|
async flavorChanged(details: SDK.DebuggerModel.DebuggerPausedDetails|null): Promise<void> {
|
|
208
323
|
const flavorChangeId = ++this.#flavorChangeId;
|
|
209
|
-
this
|
|
210
|
-
this
|
|
324
|
+
this.#showIgnoreListed = false;
|
|
325
|
+
this.#ignoreListCheckboxChecked = false;
|
|
326
|
+
this.#showIgnoreListMessage = false;
|
|
211
327
|
this.maxAsyncStackChainDepth = defaultMaxAsyncStackChainDepth;
|
|
212
328
|
|
|
213
329
|
if (this.#stackTrace) {
|
|
214
|
-
this.#stackTrace.removeEventListener(StackTrace.StackTrace.Events.UPDATED, this
|
|
330
|
+
this.#stackTrace.removeEventListener(StackTrace.StackTrace.Events.UPDATED, this.#onStackTraceUpdated, this);
|
|
215
331
|
this.#stackTrace = null;
|
|
332
|
+
this.#rebuildItems();
|
|
216
333
|
this.requestUpdate(); // In case creating the stack trace takes a while, we render an empty view first.
|
|
217
334
|
}
|
|
218
335
|
|
|
@@ -223,26 +340,24 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
223
340
|
return;
|
|
224
341
|
}
|
|
225
342
|
this.#stackTrace = stackTrace;
|
|
226
|
-
this.#stackTrace.addEventListener(StackTrace.StackTrace.Events.UPDATED, this
|
|
343
|
+
this.#stackTrace.addEventListener(StackTrace.StackTrace.Events.UPDATED, this.#onStackTraceUpdated, this);
|
|
344
|
+
this.#rebuildItems();
|
|
227
345
|
}
|
|
228
346
|
|
|
229
347
|
this.requestUpdate();
|
|
230
348
|
}
|
|
231
349
|
|
|
232
|
-
|
|
233
|
-
this.callFrameWarningsElement.classList.add('hidden');
|
|
234
|
-
|
|
350
|
+
#rebuildItems(): void {
|
|
235
351
|
if (!this.#stackTrace) {
|
|
236
|
-
this
|
|
237
|
-
this
|
|
238
|
-
this
|
|
239
|
-
this
|
|
352
|
+
this.#warnings = undefined;
|
|
353
|
+
this.#hasMore = false;
|
|
354
|
+
this.#showIgnoreListMessage = false;
|
|
355
|
+
this.#items = [];
|
|
356
|
+
this.#focusedItem = null;
|
|
240
357
|
UI.Context.Context.instance().setFlavor(StackTrace.StackTrace.DebuggableFrameFlavor, null);
|
|
241
358
|
return;
|
|
242
359
|
}
|
|
243
360
|
|
|
244
|
-
this.notPausedMessageElement.classList.add('hidden');
|
|
245
|
-
|
|
246
361
|
const items: Item[] = [];
|
|
247
362
|
const uniqueWarnings = new Set<string>();
|
|
248
363
|
for (const frame of this.#stackTrace.syncFragment.frames) {
|
|
@@ -252,10 +367,7 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
252
367
|
}
|
|
253
368
|
}
|
|
254
369
|
|
|
255
|
-
|
|
256
|
-
this.callFrameWarningsElement.classList.remove('hidden');
|
|
257
|
-
UI.Tooltip.Tooltip.install(this.callFrameWarningsElement, Array.from(uniqueWarnings).join('\n'));
|
|
258
|
-
}
|
|
370
|
+
this.#warnings = uniqueWarnings.size ? Array.from(uniqueWarnings).join('\n') : undefined;
|
|
259
371
|
|
|
260
372
|
let {maxAsyncStackChainDepth} = this;
|
|
261
373
|
let hasMore = false;
|
|
@@ -271,136 +383,102 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
271
383
|
}
|
|
272
384
|
}
|
|
273
385
|
|
|
274
|
-
this
|
|
275
|
-
this
|
|
276
|
-
|
|
277
|
-
|
|
278
|
-
}
|
|
386
|
+
this.#hasMore = hasMore;
|
|
387
|
+
this.#items = items;
|
|
388
|
+
this.#updateIgnoreListState();
|
|
389
|
+
|
|
279
390
|
if (this.maxAsyncStackChainDepth === defaultMaxAsyncStackChainDepth) {
|
|
280
|
-
this
|
|
281
|
-
|
|
282
|
-
if (selectedItem &&
|
|
391
|
+
this.#focusedItem = this.#firstVisibleItem() ?? (this.#items[0] ?? null);
|
|
392
|
+
if (this.#focusedItem &&
|
|
283
393
|
(UI.Context.Context.instance().flavor(QuickSourceView) ||
|
|
284
394
|
UI.Context.Context.instance().flavor(SourcesPanel))) {
|
|
285
|
-
this.activateItem(
|
|
395
|
+
this.activateItem(this.#focusedItem);
|
|
286
396
|
}
|
|
397
|
+
} else {
|
|
398
|
+
const activeItem = this.activeCallFrameItem();
|
|
399
|
+
this.#focusedItem =
|
|
400
|
+
this.#isItemVisible(activeItem) ? activeItem : (this.#firstVisibleItem() ?? (this.#items[0] ?? null));
|
|
287
401
|
}
|
|
288
|
-
this.updatedForTest();
|
|
289
402
|
}
|
|
290
403
|
|
|
291
|
-
|
|
404
|
+
#isItemVisible(item: Item|null): boolean {
|
|
405
|
+
if (!item || !this.#items.includes(item)) {
|
|
406
|
+
return false;
|
|
407
|
+
}
|
|
408
|
+
return this.#showIgnoreListed || !item.isIgnoreListed;
|
|
292
409
|
}
|
|
293
410
|
|
|
294
|
-
|
|
295
|
-
this.
|
|
296
|
-
void this.updateItemThrottler.schedule(async () => {
|
|
297
|
-
const items = Array.from(this.scheduledForUpdateItems);
|
|
298
|
-
this.scheduledForUpdateItems.clear();
|
|
299
|
-
|
|
300
|
-
this.muteActivateItem = true;
|
|
301
|
-
if (!this.showIgnoreListed && this.items.every(item => item.isIgnoreListed)) {
|
|
302
|
-
this.showIgnoreListed = true;
|
|
303
|
-
for (let i = 0; i < this.items.length; ++i) {
|
|
304
|
-
this.list.refreshItemByIndex(i);
|
|
305
|
-
}
|
|
306
|
-
this.ignoreListMessageElement.classList.toggle('hidden', true);
|
|
307
|
-
} else {
|
|
308
|
-
this.showIgnoreListed = this.ignoreListCheckboxElement.checked;
|
|
309
|
-
const itemsSet = new Set<Item>(items);
|
|
310
|
-
let hasIgnoreListed = false;
|
|
311
|
-
for (let i = 0; i < this.items.length; ++i) {
|
|
312
|
-
const item = this.items.at(i);
|
|
313
|
-
if (itemsSet.has(item)) {
|
|
314
|
-
this.list.refreshItemByIndex(i);
|
|
315
|
-
}
|
|
316
|
-
hasIgnoreListed = hasIgnoreListed || item.isIgnoreListed;
|
|
317
|
-
}
|
|
318
|
-
this.ignoreListMessageElement.classList.toggle('hidden', !hasIgnoreListed);
|
|
319
|
-
}
|
|
320
|
-
delete this.muteActivateItem;
|
|
321
|
-
});
|
|
411
|
+
#firstVisibleItem(): Item|null {
|
|
412
|
+
return this.#items.find(item => this.#showIgnoreListed || !item.isIgnoreListed) ?? null;
|
|
322
413
|
}
|
|
323
414
|
|
|
324
|
-
|
|
325
|
-
const
|
|
326
|
-
|
|
327
|
-
|
|
328
|
-
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
element.classList.add('async-header');
|
|
415
|
+
#updateIgnoreListState(): void {
|
|
416
|
+
const hasIgnoreListed = this.#items.some(item => item.isIgnoreListed);
|
|
417
|
+
const allIgnoreListed = this.#items.length > 0 && this.#items.every(item => item.isIgnoreListed);
|
|
418
|
+
|
|
419
|
+
if (allIgnoreListed) {
|
|
420
|
+
this.#showIgnoreListed = true;
|
|
421
|
+
this.#showIgnoreListMessage = false;
|
|
332
422
|
} else {
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
linkElement.textContent = Platform.StringUtilities.trimMiddle(item.linkText, 30);
|
|
336
|
-
UI.Tooltip.Tooltip.install(linkElement, item.linkText);
|
|
337
|
-
element.classList.toggle('ignore-listed-call-frame', item.isIgnoreListed);
|
|
338
|
-
if (item.isIgnoreListed) {
|
|
339
|
-
UI.ARIAUtils.setDescription(element, i18nString(UIStrings.onIgnoreList));
|
|
340
|
-
}
|
|
341
|
-
if (!item.frame) {
|
|
342
|
-
UI.ARIAUtils.setDisabled(element, true);
|
|
343
|
-
}
|
|
423
|
+
this.#showIgnoreListed = this.#ignoreListCheckboxChecked;
|
|
424
|
+
this.#showIgnoreListMessage = hasIgnoreListed;
|
|
344
425
|
}
|
|
345
|
-
const isSelected =
|
|
346
|
-
item.frame === UI.Context.Context.instance().flavor(StackTrace.StackTrace.DebuggableFrameFlavor)?.frame;
|
|
347
|
-
|
|
348
|
-
element.classList.toggle('selected', isSelected);
|
|
349
|
-
UI.ARIAUtils.setSelected(element, isSelected);
|
|
350
|
-
element.classList.toggle('hidden', !this.showIgnoreListed && item.isIgnoreListed);
|
|
351
|
-
const icon = new Icon();
|
|
352
|
-
icon.name = 'large-arrow-right-filled';
|
|
353
|
-
icon.classList.add('selected-call-frame-icon', 'small');
|
|
354
|
-
element.appendChild(icon);
|
|
355
|
-
element.tabIndex = item === this.list.selectedItem() ? 0 : -1;
|
|
356
|
-
|
|
357
|
-
if (item.frame?.missingDebugInfo) {
|
|
358
|
-
const icon = new Icon();
|
|
359
|
-
icon.name = 'warning-filled';
|
|
360
|
-
icon.classList.add('call-frame-warning-icon', 'small');
|
|
361
|
-
const {resources, details} =
|
|
362
|
-
convertMissingDebugInfo(item.frame.missingDebugInfo, item.frame.sdkFrame.functionName);
|
|
363
|
-
const messages = resources.map(
|
|
364
|
-
r => i18nString(UIStrings.debugFileNotFound, {PH1: Common.ParsedURL.ParsedURL.extractName(r.resourceUrl)}));
|
|
365
|
-
UI.Tooltip.Tooltip.install(icon, [details, ...messages].join('\n'));
|
|
366
|
-
element.appendChild(icon);
|
|
367
|
-
}
|
|
368
|
-
return element;
|
|
369
426
|
}
|
|
370
427
|
|
|
371
|
-
|
|
372
|
-
|
|
373
|
-
|
|
428
|
+
override performUpdate(): void {
|
|
429
|
+
const viewInput: ViewInput = {
|
|
430
|
+
showIgnoreListMessage: this.#showIgnoreListMessage,
|
|
431
|
+
showIgnoreListedChecked: this.#ignoreListCheckboxChecked,
|
|
432
|
+
onIgnoreListCheckboxChange: this.#onIgnoreListCheckboxChanged.bind(this),
|
|
433
|
+
notPaused: !this.#stackTrace,
|
|
434
|
+
warnings: this.#warnings,
|
|
435
|
+
items: this.#items,
|
|
436
|
+
selectedItem: this.activeCallFrameItem(),
|
|
437
|
+
focusedItem: this.#focusedItem,
|
|
438
|
+
showIgnoreListed: this.#showIgnoreListed,
|
|
439
|
+
onItemClick: this.#onItemClick.bind(this),
|
|
440
|
+
onItemActivate: this.#onItemActivate.bind(this),
|
|
441
|
+
onItemContextMenu: this.#onItemContextMenu.bind(this),
|
|
442
|
+
onItemKeyDown: this.#onItemKeyDown.bind(this),
|
|
443
|
+
showMore: this.#hasMore,
|
|
444
|
+
onShowMore: this.#onShowMoreClicked.bind(this),
|
|
445
|
+
};
|
|
446
|
+
|
|
447
|
+
this.#view(viewInput, undefined, this.contentElement);
|
|
448
|
+
|
|
449
|
+
if (this.#stackTrace) {
|
|
450
|
+
this.updatedForTest();
|
|
451
|
+
}
|
|
374
452
|
}
|
|
375
453
|
|
|
376
|
-
|
|
377
|
-
return true;
|
|
454
|
+
private updatedForTest(): void {
|
|
378
455
|
}
|
|
379
456
|
|
|
380
|
-
|
|
381
|
-
|
|
382
|
-
|
|
383
|
-
fromElement.tabIndex = -1;
|
|
457
|
+
#onItemClick(item: Item): void {
|
|
458
|
+
if (this.#items.includes(item)) {
|
|
459
|
+
this.#focusedItem = item;
|
|
384
460
|
}
|
|
385
|
-
if (
|
|
386
|
-
this.
|
|
387
|
-
toElement.tabIndex = 0;
|
|
388
|
-
if (this.hasFocus()) {
|
|
389
|
-
toElement.focus();
|
|
390
|
-
}
|
|
461
|
+
if (item.uiLocation) {
|
|
462
|
+
this.activateItem(item);
|
|
391
463
|
}
|
|
464
|
+
this.requestUpdate();
|
|
392
465
|
}
|
|
393
466
|
|
|
394
|
-
|
|
395
|
-
|
|
467
|
+
#onItemActivate(item: Item): void {
|
|
468
|
+
if (this.#items.includes(item)) {
|
|
469
|
+
this.#focusedItem = item;
|
|
470
|
+
}
|
|
471
|
+
if (item.uiLocation) {
|
|
472
|
+
this.activateItem(item);
|
|
473
|
+
}
|
|
474
|
+
this.requestUpdate();
|
|
396
475
|
}
|
|
397
476
|
|
|
398
|
-
|
|
399
|
-
|
|
400
|
-
|
|
401
|
-
|
|
477
|
+
#onItemContextMenu(item: Item, contextMenu: UI.ContextMenu.ContextMenu): void {
|
|
478
|
+
if (this.#items.includes(item)) {
|
|
479
|
+
this.#focusedItem = item;
|
|
480
|
+
this.requestUpdate();
|
|
402
481
|
}
|
|
403
|
-
const contextMenu = new UI.ContextMenu.ContextMenu(event);
|
|
404
482
|
const debuggerCallFrame = item.frame?.sdkFrame;
|
|
405
483
|
if (debuggerCallFrame) {
|
|
406
484
|
contextMenu.defaultSection().appendItem(i18nString(UIStrings.restartFrame), () => {
|
|
@@ -413,17 +491,63 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
413
491
|
if (item.uiLocation) {
|
|
414
492
|
this.appendIgnoreListURLContextMenuItems(contextMenu, item.uiLocation.uiSourceCode);
|
|
415
493
|
}
|
|
416
|
-
|
|
494
|
+
}
|
|
495
|
+
|
|
496
|
+
#onItemKeyDown(item: Item, direction: 'ArrowUp'|'ArrowDown'|'Home'|'End'): void {
|
|
497
|
+
const visibleItems = this.#items.filter(candidate => this.#showIgnoreListed || !candidate.isIgnoreListed);
|
|
498
|
+
if (visibleItems.length === 0) {
|
|
499
|
+
return;
|
|
500
|
+
}
|
|
501
|
+
|
|
502
|
+
let newItem: Item;
|
|
503
|
+
switch (direction) {
|
|
504
|
+
case 'Home':
|
|
505
|
+
newItem = visibleItems[0];
|
|
506
|
+
break;
|
|
507
|
+
case 'End':
|
|
508
|
+
newItem = visibleItems[visibleItems.length - 1];
|
|
509
|
+
break;
|
|
510
|
+
case 'ArrowDown': {
|
|
511
|
+
const currPos = visibleItems.indexOf(item);
|
|
512
|
+
const nextPos = currPos === -1 ? 0 : (currPos + 1) % visibleItems.length;
|
|
513
|
+
newItem = visibleItems[nextPos];
|
|
514
|
+
break;
|
|
515
|
+
}
|
|
516
|
+
case 'ArrowUp': {
|
|
517
|
+
const currPos = visibleItems.indexOf(item);
|
|
518
|
+
const prevPos =
|
|
519
|
+
currPos === -1 ? visibleItems.length - 1 : (currPos - 1 + visibleItems.length) % visibleItems.length;
|
|
520
|
+
newItem = visibleItems[prevPos];
|
|
521
|
+
break;
|
|
522
|
+
}
|
|
523
|
+
}
|
|
524
|
+
|
|
525
|
+
const targetItem = newItem;
|
|
526
|
+
this.#focusedItem = targetItem;
|
|
527
|
+
this.requestUpdate();
|
|
528
|
+
void this.updateComplete.then(() => {
|
|
529
|
+
const newIndex = this.#items.indexOf(targetItem);
|
|
530
|
+
if (newIndex === -1) {
|
|
531
|
+
return;
|
|
532
|
+
}
|
|
533
|
+
const elements = this.contentElement.querySelectorAll<HTMLElement>('.call-frame-item');
|
|
534
|
+
const targetEl = elements[newIndex];
|
|
535
|
+
if (targetEl) {
|
|
536
|
+
targetEl.focus();
|
|
537
|
+
targetEl.scrollIntoView({block: 'nearest'});
|
|
538
|
+
}
|
|
539
|
+
});
|
|
417
540
|
}
|
|
418
541
|
|
|
419
542
|
private activateItem(item: Item): void {
|
|
420
543
|
const uiLocation = item.uiLocation;
|
|
421
|
-
if (
|
|
544
|
+
if (!uiLocation) {
|
|
422
545
|
return;
|
|
423
546
|
}
|
|
424
|
-
this.
|
|
547
|
+
if (this.#items.includes(item)) {
|
|
548
|
+
this.#focusedItem = item;
|
|
549
|
+
}
|
|
425
550
|
const debuggerCallFrame = item.frame;
|
|
426
|
-
const oldItem = this.activeCallFrameItem();
|
|
427
551
|
if (debuggerCallFrame) {
|
|
428
552
|
debuggerCallFrame.sdkFrame.debuggerModel.setSelectedCallFrame(debuggerCallFrame.sdkFrame);
|
|
429
553
|
UI.Context.Context.instance().setFlavor(
|
|
@@ -432,18 +556,13 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
432
556
|
} else {
|
|
433
557
|
void Common.Revealer.reveal(uiLocation);
|
|
434
558
|
}
|
|
435
|
-
|
|
436
|
-
if (oldItem) {
|
|
437
|
-
this.refreshItem(oldItem);
|
|
438
|
-
}
|
|
439
|
-
this.refreshItem(item);
|
|
440
|
-
}
|
|
559
|
+
this.requestUpdate();
|
|
441
560
|
}
|
|
442
561
|
|
|
443
562
|
activeCallFrameItem(): Item|null {
|
|
444
563
|
const frameFlavor = UI.Context.Context.instance().flavor(StackTrace.StackTrace.DebuggableFrameFlavor);
|
|
445
564
|
if (frameFlavor) {
|
|
446
|
-
return this
|
|
565
|
+
return this.#items.find(callFrameItem => callFrameItem.frame === frameFlavor.frame) || null;
|
|
447
566
|
}
|
|
448
567
|
return null;
|
|
449
568
|
}
|
|
@@ -469,9 +588,9 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
469
588
|
|
|
470
589
|
selectNextCallFrameOnStack(): void {
|
|
471
590
|
const oldItem = this.activeCallFrameItem();
|
|
472
|
-
const startIndex = oldItem ? this
|
|
473
|
-
for (let i = startIndex; i < this
|
|
474
|
-
const newItem = this
|
|
591
|
+
const startIndex = oldItem ? this.#items.indexOf(oldItem) + 1 : 0;
|
|
592
|
+
for (let i = startIndex; i < this.#items.length; i++) {
|
|
593
|
+
const newItem = this.#items[i];
|
|
475
594
|
if (newItem.frame) {
|
|
476
595
|
this.activateItem(newItem);
|
|
477
596
|
break;
|
|
@@ -481,9 +600,9 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
481
600
|
|
|
482
601
|
selectPreviousCallFrameOnStack(): void {
|
|
483
602
|
const oldItem = this.activeCallFrameItem();
|
|
484
|
-
const startIndex = oldItem ? this
|
|
603
|
+
const startIndex = oldItem ? this.#items.indexOf(oldItem) - 1 : this.#items.length - 1;
|
|
485
604
|
for (let i = startIndex; i >= 0; i--) {
|
|
486
|
-
const newItem = this
|
|
605
|
+
const newItem = this.#items[i];
|
|
487
606
|
if (newItem.frame) {
|
|
488
607
|
this.activateItem(newItem);
|
|
489
608
|
break;
|
|
@@ -493,7 +612,7 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
493
612
|
|
|
494
613
|
private copyStackTrace(): void {
|
|
495
614
|
const text = [];
|
|
496
|
-
for (const item of this
|
|
615
|
+
for (const item of this.#items) {
|
|
497
616
|
let itemText = item.title;
|
|
498
617
|
if (item.uiLocation) {
|
|
499
618
|
itemText += ' (' + item.uiLocation.linkText(true /* skipTrim */) + ')';
|
|
@@ -504,7 +623,6 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
|
|
|
504
623
|
}
|
|
505
624
|
}
|
|
506
625
|
|
|
507
|
-
export const elementSymbol: unique symbol = Symbol('element');
|
|
508
626
|
export const defaultMaxAsyncStackChainDepth = 32;
|
|
509
627
|
|
|
510
628
|
export class ActionDelegate implements UI.ActionRegistration.ActionDelegate {
|