chrome-devtools-frontend 1.0.1733843 → 1.0.1736236

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (184) hide show
  1. package/.agents/rules/tests/test-view-and-presenter-isolation.md +4 -4
  2. package/.agents/rules/ui-and-widgets/ui-declarative-tree-and-prompt-patterns.md +61 -0
  3. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +11 -7
  4. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +13 -4
  5. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +31 -2
  6. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +23 -4
  7. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +34 -3
  8. package/.agents/skills/code-review/SKILL.md +27 -0
  9. package/.agents/skills/devtools-uistrings/SKILL.md +147 -0
  10. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -1
  11. package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +100 -0
  12. package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +16 -0
  13. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +13 -2
  14. package/.agents/skills/ui-widgets/SKILL.md +25 -25
  15. package/DIR_METADATA +8 -1
  16. package/docs/cookbook/localization.md +1 -1
  17. package/docs/ui_engineering.md +24 -0
  18. package/eslint.config.mjs +0 -1
  19. package/front_end/application_tokens.css +1 -1
  20. package/front_end/core/host/AidaClient.ts +147 -202
  21. package/front_end/core/host/AidaClientTypes.ts +9 -0
  22. package/front_end/core/host/AidaErrors.ts +416 -0
  23. package/front_end/core/host/AidaGcaTranslation.ts +11 -0
  24. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -2
  25. package/front_end/core/host/UserMetrics.ts +25 -0
  26. package/front_end/core/host/UserMetricsEnums.ts +25 -0
  27. package/front_end/core/host/host.ts +3 -1
  28. package/front_end/core/i18n/collect-ui-strings.js +20 -0
  29. package/front_end/core/root/Runtime.ts +12 -0
  30. package/front_end/core/sdk/CPUThrottlingManager.ts +3 -0
  31. package/front_end/core/sdk/EnhancedTracesParser.ts +8 -4
  32. package/front_end/core/sdk/NetworkManager.ts +0 -6
  33. package/front_end/core/sdk/OverlayModel.ts +0 -6
  34. package/front_end/core/sdk/PreloadingModel.ts +30 -13
  35. package/front_end/core/sdk/PrivateVerificationTokensModel.ts +0 -18
  36. package/front_end/core/sdk/RehydratingConnection.ts +5 -2
  37. package/front_end/core/sdk/ResourceTreeModel.ts +0 -42
  38. package/front_end/core/sdk/ScreenCaptureModel.ts +0 -84
  39. package/front_end/core/sdk/ServiceWorkerCacheModel.ts +0 -15
  40. package/front_end/core/sdk/StorageBucketsModel.ts +0 -15
  41. package/front_end/devtools_compatibility.js +57 -2
  42. package/front_end/entrypoints/formatter_worker/ScopeParser.ts +4 -2
  43. package/front_end/entrypoints/inspector_main/RenderingOptions.ts +203 -127
  44. package/front_end/entrypoints/inspector_main/renderingOptions.css +5 -0
  45. package/front_end/entrypoints/node_app/app/NodeMain.ts +0 -9
  46. package/front_end/entrypoints/node_app/app/nodeConnectionsPanel.css +0 -22
  47. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  48. package/front_end/generated/SupportedCSSProperties.ts +0 -136
  49. package/front_end/generated/protocol-proxy-api.d.ts +231 -231
  50. package/front_end/generated/protocol.ts +1 -0
  51. package/front_end/models/ai_assistance/AiAgent2.ts +4 -1
  52. package/front_end/models/ai_assistance/ChangeManager.ts +3 -1
  53. package/front_end/models/ai_assistance/DOMHelpers.ts +118 -3
  54. package/front_end/models/ai_assistance/ExtensionScope.ts +31 -24
  55. package/front_end/models/ai_assistance/agents/AiAgent.ts +6 -0
  56. package/front_end/models/ai_assistance/agents/PerformanceAgent.snapshot.txt +13 -13
  57. package/front_end/models/ai_assistance/agents/PerformanceAgent.ts +1 -1
  58. package/front_end/models/ai_assistance/ai_assistance.ts +2 -0
  59. package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt +18 -8
  60. package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.ts +2 -2
  61. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt +103 -81
  62. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +15 -203
  63. package/front_end/models/ai_assistance/injected.ts +6 -1
  64. package/front_end/models/ai_assistance/skills/lighthouse.md +1 -1
  65. package/front_end/models/ai_assistance/skills/styling.md +8 -10
  66. package/front_end/models/ai_assistance/tools/GetTraceEventByKey.ts +1 -1
  67. package/front_end/models/ai_assistance/tools/SetElementStyles.ts +288 -0
  68. package/front_end/models/ai_assistance/tools/Tool.ts +1 -0
  69. package/front_end/models/ai_assistance/tools/ToolRegistry.ts +3 -0
  70. package/front_end/models/bindings/ResourceScriptMapping.ts +64 -16
  71. package/front_end/models/comment_manager/CD4ABridge.ts +12 -2
  72. package/front_end/models/comment_manager/CommentManager.ts +24 -4
  73. package/front_end/models/javascript_metadata/NativeFunctions.ts +41 -1
  74. package/front_end/models/project_settings/ProjectSettingsModel.ts +1 -1
  75. package/front_end/models/trace/handlers/FlowsHandler.ts +10 -0
  76. package/front_end/models/trace/handlers/SamplesHandler.ts +3 -2
  77. package/front_end/models/trace/handlers/ScriptsHandler.ts +25 -26
  78. package/front_end/models/trace/helpers/TreeHelpers.ts +4 -0
  79. package/front_end/models/trace/insights/DuplicatedJavaScript.ts +1 -2
  80. package/front_end/models/trace/types/TraceEvents.ts +21 -22
  81. package/front_end/panels/ai_assistance/components/ChatMessage.ts +9 -1
  82. package/front_end/panels/ai_assistance/components/chatInput.css +4 -4
  83. package/front_end/panels/animation/AnimationTimeline.ts +3 -3
  84. package/front_end/panels/animation/animationTimeline.css +6 -4
  85. package/front_end/panels/application/IndexedDBModel.ts +0 -15
  86. package/front_end/panels/application/appManifestView.css +2 -5
  87. package/front_end/panels/application/components/backForwardCacheView.css +1 -5
  88. package/front_end/panels/application/components/serviceWorkerRouterView.css +2 -2
  89. package/front_end/panels/application/preloading/components/PreloadingString.ts +7 -0
  90. package/front_end/panels/comments/CommentsPane.ts +12 -7
  91. package/front_end/panels/comments/commentsPane.css +16 -2
  92. package/front_end/panels/common/CommentsOverlayWidget.ts +16 -10
  93. package/front_end/panels/common/CommentsStatusBarPill.ts +12 -5
  94. package/front_end/panels/common/commentsOverlay.css +7 -1
  95. package/front_end/panels/common/commentsStatusBarPill.css +30 -0
  96. package/front_end/panels/console/consolePrompt.css +0 -12
  97. package/front_end/panels/console/consoleView.css +2 -2
  98. package/front_end/panels/developer_resources/developerResourcesView.css +4 -3
  99. package/front_end/panels/elements/DOMTreeWidget.ts +29 -9
  100. package/front_end/panels/elements/StylePropertyTreeElement.ts +2 -1
  101. package/front_end/panels/elements/components/CSSHintDetailsView.ts +12 -5
  102. package/front_end/panels/elements/components/cssVariableValueView.css +1 -1
  103. package/front_end/panels/elements/components/elementsBreadcrumbs.css +2 -2
  104. package/front_end/panels/elements/domTreeWidget.css +6 -1
  105. package/front_end/panels/elements/elementsPanel.css +0 -6
  106. package/front_end/panels/elements/layoutPane.css +1 -1
  107. package/front_end/panels/elements/metricsSidebarPane.css +1 -1
  108. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  109. package/front_end/panels/elements/stylesSidebarPane.css +0 -10
  110. package/front_end/panels/emulation/deviceModeView.css +6 -7
  111. package/front_end/panels/explain/components/consoleInsight.css +4 -4
  112. package/front_end/panels/issues/issuesTree.css +1 -26
  113. package/front_end/panels/lighthouse/lighthouseStartView.css +2 -2
  114. package/front_end/panels/linear_memory_inspector/components/linearMemoryInspector.css +1 -1
  115. package/front_end/panels/media/TickingFlameChart.ts +20 -3
  116. package/front_end/panels/media/playerMessagesView.css +2 -2
  117. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +24 -5
  118. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +1 -6
  119. package/front_end/panels/network/networkLogView.css +2 -2
  120. package/front_end/panels/network/networkTimingTable.css +1 -1
  121. package/front_end/panels/performance_monitor/performanceMonitor.css +0 -4
  122. package/front_end/panels/protocol_monitor/JSONEditor.css +1 -1
  123. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -2
  124. package/front_end/panels/recorder/recorderPanel.css +3 -3
  125. package/front_end/panels/recorder/recordingListView.css +1 -1
  126. package/front_end/panels/screencast/screencastView.css +1 -1
  127. package/front_end/panels/search/searchResultsPane.css +1 -1
  128. package/front_end/panels/security/SecurityModel.ts +0 -6
  129. package/front_end/panels/security/SecurityPanel.ts +120 -108
  130. package/front_end/panels/security/originView.css +1 -1
  131. package/front_end/panels/sensors/locationsSettingsTab.css +3 -3
  132. package/front_end/panels/settings/EditFileSystemView.ts +159 -104
  133. package/front_end/panels/settings/editFileSystemView.css +30 -4
  134. package/front_end/panels/settings/emulation/devicesSettingsTab.css +0 -52
  135. package/front_end/panels/settings/settingsScreen.css +0 -7
  136. package/front_end/panels/sources/CallStackSidebarPane.ts +339 -221
  137. package/front_end/panels/sources/NavigatorView.ts +95 -8
  138. package/front_end/panels/sources/ThreadsSidebarPane.ts +8 -4
  139. package/front_end/panels/sources/breakpointsView.css +1 -3
  140. package/front_end/panels/sources/callStackSidebarPane.css +4 -0
  141. package/front_end/panels/sources/components/HeadersView.ts +15 -2
  142. package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -1
  143. package/front_end/panels/timeline/CountersGraph.ts +0 -4
  144. package/front_end/panels/timeline/TimelineLoader.ts +16 -6
  145. package/front_end/panels/timeline/TimelinePanel.ts +20 -12
  146. package/front_end/panels/timeline/TimelineUIUtils.ts +1 -1
  147. package/front_end/panels/timeline/components/DetailsView.ts +2 -1
  148. package/front_end/panels/timeline/components/cwvMetrics.css +1 -1
  149. package/front_end/panels/timeline/components/metricCard.css +1 -1
  150. package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +4 -4
  151. package/front_end/panels/timeline/timelineFlameChartView.css +1 -1
  152. package/front_end/panels/webauthn/WebauthnPane.ts +13 -14
  153. package/front_end/panels/webauthn/webauthnPane.css +1 -1
  154. package/front_end/third_party/chromium/README.chromium +1 -1
  155. package/front_end/ui/comments/CommentOverlayManager.ts +34 -18
  156. package/front_end/ui/components/icon_button/FileSourceIcon.ts +6 -0
  157. package/front_end/ui/components/input/textInput.css +1 -1
  158. package/front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css +6 -4
  159. package/front_end/ui/components/suggestion_input/suggestionInput.css +2 -2
  160. package/front_end/ui/components/text_editor/AiCodeGenerationTeaser.ts +14 -2
  161. package/front_end/ui/legacy/DockController.ts +17 -4
  162. package/front_end/ui/legacy/Treeoutline.ts +2 -2
  163. package/front_end/ui/legacy/UIUtils.ts +148 -10
  164. package/front_end/ui/legacy/components/inline_editor/bezierEditor.css +3 -2
  165. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +2 -2
  166. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +2 -2
  167. package/front_end/ui/legacy/components/perf_ui/pieChart.css +1 -1
  168. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +5 -4
  169. package/front_end/ui/legacy/components/source_frame/imageView.css +1 -1
  170. package/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts +0 -3
  171. package/front_end/ui/legacy/components/utils/imagePreview.css +1 -1
  172. package/front_end/ui/legacy/inspectorCommon.css +1 -14
  173. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +3 -2
  174. package/front_end/ui/legacy/listWidget.css +0 -18
  175. package/front_end/ui/legacy/theme_support/ThemeSupport.ts +44 -9
  176. package/front_end/ui/lit/strip-whitespace.ts +1 -1
  177. package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
  178. package/package.json +3 -3
  179. package/front_end/generated/Deprecation.ts +0 -471
  180. package/front_end/panels/accessibility/axBreadcrumbs.css +0 -155
  181. package/front_end/panels/network/requestHeadersTree.css +0 -226
  182. package/front_end/panels/recorder/startView.css +0 -38
  183. package/front_end/panels/security/ipProtectionView.css +0 -141
  184. package/front_end/ui/legacy/components/inline_editor/animationNameSwatch.css +0 -27
@@ -153,22 +153,6 @@ function findNetworkRequest(networkRequests: Types.Events.SyntheticNetworkReques
153
153
  return networkRequests.find(request => request.args.data.url === script.url) ?? null;
154
154
  }
155
155
 
156
- function computeMappingEndColumns(map: SDK.SourceMap.SourceMap): Map<SDK.SourceMap.SourceMapEntry, number> {
157
- const result = new Map<SDK.SourceMap.SourceMapEntry, number>();
158
-
159
- const mappings = map.mappings();
160
- for (let i = 0; i < mappings.length - 1; i++) {
161
- const mapping = mappings[i];
162
- const nextMapping = mappings[i + 1];
163
- if (mapping.lineNumber === nextMapping.lineNumber) {
164
- result.set(mapping, nextMapping.columnNumber);
165
- }
166
- }
167
-
168
- // Now, all but the last mapping on each line will have a value in this map.
169
- return result;
170
- }
171
-
172
156
  /**
173
157
  * Using a script's contents and source map, attribute every generated byte to an authored source file.
174
158
  */
@@ -180,18 +164,32 @@ function computeGeneratedFileSizes(script: Script): GeneratedFileSizes {
180
164
  const map = script.sourceMap;
181
165
  const content = script.content ?? '';
182
166
  const contentLength = content.length;
183
- const lines = content.split('\n');
167
+ // Scanning newline offsets with indexOf('\n') avoids allocating a substring per line with content.split('\n').
168
+ const lineLengths: number[] = [];
169
+ for (let start = 0;;) {
170
+ const newlineIndex = content.indexOf('\n', start);
171
+ if (newlineIndex === -1) {
172
+ lineLengths.push(contentLength - start);
173
+ break;
174
+ }
175
+ lineLengths.push(newlineIndex - start);
176
+ start = newlineIndex + 1;
177
+ }
184
178
  const files: Record<string, number> = {};
185
179
  const totalBytes = contentLength;
186
180
  let unmappedBytes = totalBytes;
187
181
 
188
- const mappingEndCols = computeMappingEndColumns(script.sourceMap);
189
-
190
- for (const mapping of map.mappings()) {
182
+ const mappings = map.mappings();
183
+ for (let i = 0; i < mappings.length; i++) {
184
+ const mapping = mappings[i];
191
185
  const source = mapping.sourceURL;
192
186
  const lineNum = mapping.lineNumber;
193
187
  const colNum = mapping.columnNumber;
194
- const lastColNum = mappingEndCols.get(mapping);
188
+ // map.mappings() is sorted by (lineNumber, columnNumber), so the end column on the same line is
189
+ // mappings[i + 1].columnNumber.
190
+ const nextMapping = mappings[i + 1];
191
+ const lastColNum =
192
+ nextMapping !== undefined && nextMapping.lineNumber === lineNum ? nextMapping.columnNumber : undefined;
195
193
 
196
194
  // Webpack sometimes emits null mappings.
197
195
  // https://github.com/mozilla/source-map/pull/303
@@ -201,27 +199,27 @@ function computeGeneratedFileSizes(script: Script): GeneratedFileSizes {
201
199
 
202
200
  // Lines and columns are zero-based indices. Visually, lines are shown as a 1-based index.
203
201
 
204
- const line = lines[lineNum];
205
- if (line === null || line === undefined) {
202
+ const lineLength = lineLengths[lineNum];
203
+ if (lineLength === undefined) {
206
204
  const errorMessage = `${map.url()} mapping for line out of bounds: ${lineNum + 1}`;
207
205
  return {errorMessage};
208
206
  }
209
207
 
210
- if (colNum > line.length) {
208
+ if (colNum > lineLength) {
211
209
  const errorMessage = `${map.url()} mapping for column out of bounds: ${lineNum + 1}:${colNum}`;
212
210
  return {errorMessage};
213
211
  }
214
212
 
215
213
  let mappingLength = 0;
216
214
  if (lastColNum !== undefined) {
217
- if (lastColNum > line.length) {
215
+ if (lastColNum > lineLength) {
218
216
  const errorMessage = `${map.url()} mapping for last column out of bounds: ${lineNum + 1}:${lastColNum}`;
219
217
  return {errorMessage};
220
218
  }
221
219
  mappingLength = lastColNum - colNum;
222
220
  } else {
223
221
  // Add +1 to account for the newline.
224
- mappingLength = line.length - colNum + 1;
222
+ mappingLength = lineLength - colNum + 1;
225
223
  }
226
224
  files[source] = (files[source] || 0) + mappingLength;
227
225
  unmappedBytes -= mappingLength;
@@ -282,6 +280,7 @@ function findCachedRawSourceMap(script: Script, options: Types.Configuration.Par
282
280
  }
283
281
 
284
282
  export async function finalize(options: FinalizeOptions): Promise<void> {
283
+ frameIdByIsolate = new Map();
285
284
  const meta = metaHandlerData();
286
285
  const networkRequests = [...networkRequestsHandlerData().byId.values()];
287
286
 
@@ -21,6 +21,10 @@ export const makeEmptyTraceEntryNode = (entry: Types.Events.Event, id: TraceEntr
21
21
  parent: null,
22
22
  children: [],
23
23
  depth: 0,
24
+ // selfTime is set on every node after creation. Declaring it here keeps it
25
+ // inside the object; adding it later makes V8 allocate a separate property
26
+ // store for every node.
27
+ selfTime: undefined,
24
28
  });
25
29
 
26
30
  export interface TraceEntryTree {
@@ -117,8 +117,7 @@ export function generateInsight(
117
117
  if (Types.Events.isSoftNavigationStart(context.navigation)) {
118
118
  mainDocumentUrl = context.navigation.args.context.URL;
119
119
  } else {
120
- mainDocumentUrl =
121
- context.navigation.args.data?.documentLoaderURL ?? context.navigation.args.data?.url ?? mainDocumentUrl;
120
+ mainDocumentUrl = context.navigation.args.data?.documentLoaderURL ?? mainDocumentUrl;
122
121
  }
123
122
  }
124
123
 
@@ -244,7 +244,8 @@ export interface SchedulePostMessage extends Instant {
244
244
  name: Name.SCHEDULE_POST_MESSAGE;
245
245
  args: Args&{
246
246
  data: {
247
- traceId: string,
247
+ /** Landed in Chrome M124 (Feb 2024, crrev.com/c/5297395); marked optional so the engine supports earlier traces. */
248
+ traceId?: string,
248
249
  stackTrace?: CallFrame[],
249
250
  sampleTraceId?: number,
250
251
  },
@@ -698,10 +699,6 @@ export interface NavigationStart extends Mark {
698
699
  * date that do not have this field present.
699
700
  */
700
701
  isOutermostMainFrame?: boolean,
701
- /**
702
- * @deprecated use documentLoaderURL for navigation events URLs
703
- */
704
- url?: string,
705
702
  },
706
703
  };
707
704
  }
@@ -797,10 +794,11 @@ export interface LargestContentfulPaintCandidate extends Mark {
797
794
  frame: string,
798
795
  data: {
799
796
  candidateIndex: number,
800
- isOutermostMainFrame: boolean,
801
797
  isMainFrame: boolean,
802
798
  navigationId: string,
803
799
  nodeId: Protocol.DOM.BackendNodeId,
800
+ /** Landed in Chrome M116 (May 2023, crrev.com/c/3625434); marked optional so the engine supports earlier traces. */
801
+ isOutermostMainFrame?: boolean,
804
802
  loadingAttr?: string,
805
803
  size?: number,
806
804
  type?: string,
@@ -816,10 +814,11 @@ export interface LargestContentfulPaintCandidateForSoftNavigation extends Mark {
816
814
  frame: string,
817
815
  data: {
818
816
  candidateIndex: number,
819
- isOutermostMainFrame: boolean,
820
817
  isMainFrame: boolean,
821
818
  nodeId: Protocol.DOM.BackendNodeId,
822
819
  performanceTimelineNavigationId: number,
820
+ /** Landed in Chrome M116 (May 2023, crrev.com/c/3625434); marked optional so the engine supports earlier traces. */
821
+ isOutermostMainFrame?: boolean,
823
822
  loadingAttr?: string,
824
823
  size?: number,
825
824
  type?: string,
@@ -904,7 +903,6 @@ export interface UpdateCounters extends Instant {
904
903
  documents?: number,
905
904
  jsEventListeners?: number,
906
905
  nodes?: number,
907
- gpuMemoryLimitKB?: number,
908
906
  },
909
907
  };
910
908
  }
@@ -1286,7 +1284,6 @@ export interface ScheduleStyleInvalidationTracking extends Instant {
1286
1284
  nodeId: Protocol.DOM.BackendNodeId,
1287
1285
  invalidationSet?: string,
1288
1286
  invalidatedSelectorId?: string,
1289
- reason?: LayoutInvalidationReason,
1290
1287
  changedClass?: string,
1291
1288
  changedAttribute?: string,
1292
1289
  changedId?: string,
@@ -1331,8 +1328,6 @@ export interface StyleInvalidatorInvalidationTracking extends Instant {
1331
1328
  reason: string,
1332
1329
  invalidationList: Array<{id: string, classes?: string[]}>,
1333
1330
  nodeName?: string,
1334
- extraData?: string,
1335
- stackTrace?: CallFrame[],
1336
1331
  // eslint-disable-next-line @typescript-eslint/naming-convention
1337
1332
  selectors?: Array<{selector: string, style_sheet_id: string}>,
1338
1333
  },
@@ -1374,9 +1369,9 @@ export type MetaCharsetDisposition = 'found-in-first-1024-bytes'|'found-after-fi
1374
1369
  export interface MetaCharsetCheck extends Instant {
1375
1370
  name: Name.META_CHARSET_CHECK;
1376
1371
  args: Args&{
1377
- data: {
1378
- frame: string,
1379
- disposition: MetaCharsetDisposition,
1372
+ data?: {
1373
+ frame?: string,
1374
+ disposition?: MetaCharsetDisposition,
1380
1375
  },
1381
1376
  };
1382
1377
  }
@@ -1405,9 +1400,6 @@ export interface ScheduleStyleRecalculation extends Instant {
1405
1400
  args: Args&{
1406
1401
  data: {
1407
1402
  frame: string,
1408
- reason?: StyleRecalcInvalidationReason,
1409
- subtree?: boolean,
1410
- nodeId?: Protocol.DOM.BackendNodeId,
1411
1403
  stackTrace?: CallFrame[],
1412
1404
  sampleTraceId?: number,
1413
1405
  },
@@ -2987,14 +2979,21 @@ export function isV8Compile(event: Event): event is V8Compile {
2987
2979
  export interface FunctionCall extends Complete {
2988
2980
  name: Name.FUNCTION_CALL;
2989
2981
  args: Args&{
2990
- data?: Partial<CallFrame>& {
2982
+ data?: {
2983
+ columnNumber?: number,
2991
2984
  frame?: string,
2985
+ functionName?: string,
2986
+ /** Changed from number to string in M142 (Sep 2025, crrev.com/c/6990800); see https://crbug.com/447654178. */
2992
2987
  isolate?: string|number,
2993
- // Blink C++ emits integer script IDs in internal locations, but the trace buffer serializer
2994
- // stringifies them with String::Number(location->ScriptId()), so trace events in the wild have string scriptId.
2995
- scriptId?: string,
2996
- // Always present in traces since M135 (Feb 2025, crrev.com/c/6300647); marked optional so the engine supports earlier traces.
2988
+ lineNumber?: number,
2989
+ /** Always present in traces since M135 (Feb 2025, crrev.com/c/6300647); marked optional so the engine supports earlier traces. */
2997
2990
  sampleTraceId?: number,
2991
+ /**
2992
+ * Blink C++ emits integer script IDs in internal locations, but the trace buffer serializer
2993
+ * stringifies them with String::Number(location->ScriptId()), so trace events in the wild have string scriptId.
2994
+ */
2995
+ scriptId?: string,
2996
+ url?: string,
2998
2997
  },
2999
2998
  };
3000
2999
  }
@@ -2376,10 +2376,18 @@ async function makeTimelineRangeSummaryWidget(widgetData: AiAssistanceModel.AiAg
2376
2376
  };
2377
2377
  }
2378
2378
 
2379
+ const networkTrackDataProviders =
2380
+ new WeakMap<AiAssistanceModel.AiAgent.NetworkTrackAiWidget,
2381
+ Timeline.TimelineFlameChartNetworkDataProvider.TimelineFlameChartNetworkDataProvider>();
2382
+
2379
2383
  async function makeNetworkTrackWidget(widgetData: AiAssistanceModel.AiAgent.NetworkTrackAiWidget):
2380
2384
  Promise<WidgetMakerResponse|null> {
2381
2385
  const {parsedTrace, bounds} = widgetData.data;
2382
- const dataProvider = new Timeline.TimelineFlameChartNetworkDataProvider.TimelineFlameChartNetworkDataProvider();
2386
+ let dataProvider = networkTrackDataProviders.get(widgetData);
2387
+ if (!dataProvider) {
2388
+ dataProvider = new Timeline.TimelineFlameChartNetworkDataProvider.TimelineFlameChartNetworkDataProvider();
2389
+ networkTrackDataProviders.set(widgetData, dataProvider);
2390
+ }
2383
2391
 
2384
2392
  // clang-format off
2385
2393
  const template = html`
@@ -152,11 +152,11 @@
152
152
  field-sizing: content;
153
153
  resize: none;
154
154
  width: 100%;
155
- max-height: 84px; /* 4 rows */
155
+ max-height: var(--sys-size-19);
156
156
  border: 0;
157
157
  border-radius: var(--sys-shape-corner-small);
158
158
  font: var(--sys-typescale-body4-regular);
159
- line-height: 18px;
159
+ line-height: var(--sys-typescale-body4-line-height);
160
160
  min-height: var(--sys-size-11);
161
161
  color: var(--sys-color-on-surface);
162
162
  background-color: var(--sys-color-cdt-base-container);
@@ -302,9 +302,9 @@
302
302
  height: var(--sys-size-4);
303
303
  border-radius: var(--sys-shape-corner-full);
304
304
  outline: var(--sys-size-1) solid var(--icon-gap-focus-selected);
305
- left: 11px;
305
+ left: var(--sys-size-6);
306
306
  position: absolute;
307
- top: 13px;
307
+ top: var(--sys-size-6);
308
308
  z-index: 1;
309
309
  background-color: var(--sys-color-purple-bright);
310
310
  }
@@ -1008,7 +1008,7 @@ export class AnimationTimeline extends UI.Widget.VBox implements
1008
1008
  let lastDraw: number|undefined = undefined;
1009
1009
  for (let time = 0; time < this.duration(); time += gridSize) {
1010
1010
  const line = UI.UIUtils.createSVGChild(this.#grid, 'rect', 'animation-timeline-grid-line');
1011
- line.setAttribute('x', (time * this.pixelTimeRatio() + 10).toString());
1011
+ line.setAttribute('x', (time * this.pixelTimeRatio() + 8).toString());
1012
1012
  line.setAttribute('y', '23');
1013
1013
  line.setAttribute('height', '100%');
1014
1014
  line.setAttribute('width', '1');
@@ -1019,7 +1019,7 @@ export class AnimationTimeline extends UI.Widget.VBox implements
1019
1019
  lastDraw = gridWidth;
1020
1020
  const label = UI.UIUtils.createSVGChild(this.#grid, 'text', 'animation-timeline-grid-label');
1021
1021
  label.textContent = isScrollDriven ? `${time.toFixed(0)}px` : i18n.TimeUtilities.millisToString(time);
1022
- label.setAttribute('x', (gridWidth + 12).toString());
1022
+ label.setAttribute('x', (gridWidth + 10).toString());
1023
1023
  label.setAttribute('y', '16');
1024
1024
  }
1025
1025
  }
@@ -1119,7 +1119,7 @@ export class AnimationTimeline extends UI.Widget.VBox implements
1119
1119
 
1120
1120
  // Seek to current mouse position.
1121
1121
  if (!this.#gridOffsetLeft) {
1122
- this.#gridOffsetLeft = this.#grid.getBoundingClientRect().left + 10;
1122
+ this.#gridOffsetLeft = this.#grid.getBoundingClientRect().left + 8;
1123
1123
  }
1124
1124
 
1125
1125
  const {x} = event;
@@ -190,7 +190,7 @@ circle.animation-keyframe-point:active {
190
190
  .animation-scrubber {
191
191
  opacity: 100%;
192
192
  position: absolute;
193
- left: 10px;
193
+ left: var(--sys-size-5);
194
194
  height: 100%;
195
195
  width: 100%;
196
196
  top: var(--sys-size-12);
@@ -231,8 +231,10 @@ circle.animation-keyframe-point:active {
231
231
 
232
232
  .grid-overflow-wrapper {
233
233
  position: absolute;
234
- left: calc(var(--timeline-controls-width) - 10px);
235
- top: 76px;
234
+ /* Offset left by the 8px scrubber origin inset (--sys-size-5) so t=0 aligns with --timeline-controls-width without clipping the scrubber head. */
235
+ left: calc(var(--timeline-controls-width) - var(--sys-size-5));
236
+ /* Position below the 28px top toolbar (--sys-size-12) + 48px animation group preview buffer (--sys-size-16) = 76px. */
237
+ top: calc(var(--sys-size-12) + var(--sys-size-16));
236
238
  z-index: 1;
237
239
  overflow: hidden;
238
240
  width: 100%;
@@ -296,7 +298,7 @@ svg.animation-ui path:focus-visible {
296
298
  }
297
299
 
298
300
  text.animation-timeline-grid-label {
299
- font-size: 10px;
301
+ font-size: var(--sys-typescale-body5-size);
300
302
  fill: var(--sys-color-token-subtle);
301
303
  text-anchor: middle;
302
304
  }
@@ -414,21 +414,6 @@ export class IndexedDBModel extends SDK.SDKModel.SDKModel<EventTypes> implements
414
414
  this.dispatchEventToListeners(Events.IndexedDBContentUpdated, {databaseId, objectStoreName, model: this});
415
415
  }
416
416
  }
417
-
418
- cacheStorageListUpdated(_event: Protocol.Storage.CacheStorageListUpdatedEvent): void {
419
- }
420
-
421
- cacheStorageContentUpdated(_event: Protocol.Storage.CacheStorageContentUpdatedEvent): void {
422
- }
423
-
424
- storageBucketCreatedOrUpdated(_event: Protocol.Storage.StorageBucketCreatedOrUpdatedEvent): void {
425
- }
426
-
427
- storageBucketDeleted(_event: Protocol.Storage.StorageBucketDeletedEvent): void {
428
- }
429
-
430
- privateVerificationTokensUpdated(): void {
431
- }
432
417
  }
433
418
 
434
419
  SDK.SDKModel.SDKModel.register(IndexedDBModel, {capabilities: SDK.Target.Capability.STORAGE, autostart: false});
@@ -3,9 +3,6 @@
3
3
  * Use of this source code is governed by a BSD-style license that can be
4
4
  * found in the LICENSE file.
5
5
  */
6
- .report-field-name {
7
- flex-basis: 152px;
8
- }
9
6
 
10
7
  :host {
11
8
  overflow: auto;
@@ -59,8 +56,8 @@ devtools-report .report-section {
59
56
 
60
57
  .image-wrapper,
61
58
  .image-wrapper img {
62
- max-width: 200px;
63
- max-height: 200px;
59
+ max-width: var(--sys-size-25);
60
+ max-height: var(--sys-size-25);
64
61
  display: block;
65
62
  object-fit: contain;
66
63
  }
@@ -18,7 +18,7 @@ devtools-report-value {
18
18
 
19
19
  .gray-text {
20
20
  color: var(--sys-color-token-subtle);
21
- margin: 0 0 5px var(--sys-size-17);
21
+ margin: 0 0 var(--sys-size-3) var(--sys-size-17);
22
22
  display: flex;
23
23
  flex-direction: row;
24
24
  align-items: center;
@@ -77,10 +77,6 @@ devtools-report-value:has(devtools-tree-outline) {
77
77
  outline: 0;
78
78
  }
79
79
 
80
- .tree-outline li .selection {
81
- margin-left: -5px;
82
- }
83
-
84
80
  @media (forced-colors: active) {
85
81
  .link,
86
82
  .devtools-link {
@@ -12,8 +12,8 @@
12
12
  .router-rules {
13
13
  border: var(--sys-size-1) solid var(--sys-color-divider);
14
14
  border-spacing: 0;
15
- padding-left: 10px;
16
- padding-right: 10px;
15
+ padding-left: var(--sys-size-6);
16
+ padding-right: var(--sys-size-6);
17
17
  line-height: initial;
18
18
  margin-top: 0;
19
19
  padding-bottom: var(--sys-size-6);
@@ -19,6 +19,11 @@ const UIStrings = {
19
19
  * @description Description text for prefetch status PrefetchFailedInvalidRedirect.
20
20
  */
21
21
  PrefetchFailedInvalidRedirect: 'The prefetch was redirected, but there was a problem with the redirect',
22
+ /**
23
+ * @description Description text for prerender status PrefetchFailedCrossOriginSubframe.
24
+ */
25
+ PrefetchFailedCrossOriginSubframe:
26
+ 'Cross-origin subframe navigation was deferred during prerendering because the parent frame was deferred or its response didn’t include the appropriate Supports-Loading-Mode header',
22
27
  /**
23
28
  * @description Description text for prefetch status PrefetchFailedMIMENotSupported.
24
29
  */
@@ -730,6 +735,8 @@ export function prerenderFailureReason(
730
735
  return i18nString(UIStrings.prerenderFinalStatusWindowClosed);
731
736
  case Protocol.Preload.PrerenderFinalStatus.BrowsingDataRemoved:
732
737
  return i18nString(UIStrings.prerenderFinalStatusBrowsingDataRemoved);
738
+ case Protocol.Preload.PrerenderFinalStatus.PrefetchFailedCrossOriginSubframe:
739
+ return i18nString(UIStrings.PrefetchFailedCrossOriginSubframe);
733
740
  case Protocol.Preload.PrerenderFinalStatus.SlowNetwork:
734
741
  case Protocol.Preload.PrerenderFinalStatus.OtherPrerenderedPageActivated:
735
742
  case Protocol.Preload.PrerenderFinalStatus.V8OptimizerDisabled:
@@ -16,7 +16,7 @@ import * as CommonPanels from '../common/common.js';
16
16
 
17
17
  import commentsPaneStyles from './commentsPane.css.js';
18
18
 
19
- const {html, render, i18nTemplate, Directives: {ref, repeat}} = Lit;
19
+ const {html, render, i18nTemplate, Directives: {classMap, ref, repeat}} = Lit;
20
20
  const {widget} = UI.Widget;
21
21
  const {computeCommentTitle, inputDisclaimer} = CommonPanels.CommentThreadWidget;
22
22
  type Title = CommonPanels.CommentThreadWidget.Title;
@@ -164,6 +164,7 @@ function renderThreadStatus(
164
164
  case 'RESOLVED':
165
165
  return html`
166
166
  <devtools-button
167
+ class="see-response-button"
167
168
  .data=${{
168
169
  variant: Buttons.Button.Variant.TEXT,
169
170
  jslogContext: 'comments-see-response',
@@ -247,7 +248,13 @@ export const DEFAULT_VIEW: View = (input: ViewInput, output: ViewOutput, target:
247
248
  }
248
249
  }}
249
250
  jslog=${VisualLogging.item('comment-thread').track({click: true})}>
250
- <div class="comment-pin-badge" aria-hidden="true"></div>
251
+ <div
252
+ class=${classMap({
253
+ 'comment-pin-badge': true,
254
+ resolved: item.thread.status === 'RESOLVED',
255
+ })}
256
+ aria-hidden="true">
257
+ </div>
251
258
  <span class="anchor-chip ${item.thread.isOrphaned ? 'orphaned' : ''}">
252
259
  ${'node' in item.title ?
253
260
  widget(CommonPanels.DOMLinkifier.DOMNodeLink, {
@@ -388,7 +395,7 @@ export class CommentsPane extends UI.Widget.Widget {
388
395
  readonly #view: View;
389
396
  readonly #commentManager: CommentManager.CommentManager.CommentManager;
390
397
 
391
- readonly #cachedTitles = new Map<string, Title>();
398
+ readonly #cachedTitles = new WeakMap<CommentManager.CommentManager.CommentThread, Title>();
392
399
  readonly #viewOutput: ViewOutput = {};
393
400
  #activeTab: Tab = 'queued';
394
401
  // Set while a tab click smoothly scrolls the list. Scroll events then don't
@@ -475,7 +482,6 @@ export class CommentsPane extends UI.Widget.Widget {
475
482
  };
476
483
 
477
484
  #handleClearAll = (): void => {
478
- this.#cachedTitles.clear();
479
485
  this.#commentManager.clear();
480
486
  this.requestUpdate();
481
487
  };
@@ -493,7 +499,6 @@ export class CommentsPane extends UI.Widget.Widget {
493
499
  };
494
500
 
495
501
  #handleDeleteThread = (threadId: string): void => {
496
- this.#cachedTitles.delete(threadId);
497
502
  this.#commentManager.removeCommentThread(threadId);
498
503
  this.requestUpdate();
499
504
  };
@@ -511,10 +516,10 @@ export class CommentsPane extends UI.Widget.Widget {
511
516
  };
512
517
 
513
518
  async #toViewData(thread: CommentManager.CommentManager.CommentThread): Promise<ThreadViewData> {
514
- let title = this.#cachedTitles.get(thread.id);
519
+ let title = this.#cachedTitles.get(thread);
515
520
  if (!title) {
516
521
  title = await computeCommentTitle(thread.anchor);
517
- this.#cachedTitles.set(thread.id, title);
522
+ this.#cachedTitles.set(thread, title);
518
523
  }
519
524
  return {
520
525
  thread,
@@ -164,17 +164,27 @@
164
164
  }
165
165
 
166
166
  .comment-pin-badge {
167
+ box-sizing: border-box;
167
168
  width: var(--sys-size-9);
168
169
  height: var(--sys-size-9);
169
170
  margin-right: var(--sys-size-2);
170
171
  border-radius: var(--sys-shape-corner-full) var(--sys-shape-corner-full) var(--sys-shape-corner-full) var(--sys-shape-corner-extra-small);
171
- background-color: var(--sys-color-primary);
172
+ border: var(--sys-size-2) solid var(--sys-color-primary);
173
+ background-color: var(--sys-color-cdt-base-container);
172
174
  flex-shrink: 0;
173
175
  }
174
176
 
177
+ .comment-pin-badge.resolved {
178
+ border: none;
179
+ background-color: var(--sys-color-primary);
180
+ }
181
+
175
182
  .comment-thread-item.orphaned .comment-pin-badge {
183
+ border-color: var(--sys-color-surface-variant);
184
+ }
185
+
186
+ .comment-thread-item.orphaned .comment-pin-badge.resolved {
176
187
  background-color: var(--sys-color-surface-variant);
177
- color: var(--sys-color-on-surface-subtle);
178
188
  }
179
189
 
180
190
  .anchor-chip {
@@ -257,6 +267,10 @@
257
267
  color: var(--sys-color-on-surface-subtle);
258
268
  }
259
269
 
270
+ .see-response-button {
271
+ margin-right: calc(-1 * var(--sys-size-6));
272
+ }
273
+
260
274
  .comments-empty-state {
261
275
  display: flex;
262
276
  flex-direction: column;
@@ -43,7 +43,7 @@ export interface ThreadActions {
43
43
  * `hoveredThread`.
44
44
  */
45
45
  export interface ViewInput extends ThreadActions {
46
- pins: Comments.CommentOverlayManager.PinPositionData[];
46
+ pins: Comments.CommentOverlayManager.PinData[];
47
47
  /**
48
48
  * Highlight of the currently open thread. Null when no thread is open, so
49
49
  * only pins are rendered.
@@ -64,7 +64,7 @@ export interface ViewInput extends ThreadActions {
64
64
  onPopupInteract: () => void;
65
65
  /** Thread opened by the user (pin click, drawer, or draft). */
66
66
  activeThread: CommentManager.CommentManager.CommentThread|null;
67
- activePin: Comments.CommentOverlayManager.PinPositionData|null;
67
+ activePin: Comments.CommentOverlayManager.PinData|null;
68
68
  fallbackPosition?: {left: number, top: number}|null;
69
69
  title: Title;
70
70
  /**
@@ -72,7 +72,7 @@ export interface ViewInput extends ThreadActions {
72
72
  * `activeThread`, and never the same thread.
73
73
  */
74
74
  hoveredThread: CommentManager.CommentManager.CommentThread|null;
75
- hoveredPin: Comments.CommentOverlayManager.PinPositionData|null;
75
+ hoveredPin: Comments.CommentOverlayManager.PinData|null;
76
76
  hoveredHighlight: Comments.CommentOverlayManager.HighlightRectData|null;
77
77
  hoveredTitle: Title;
78
78
  hoveredActions: ThreadActions;
@@ -186,7 +186,12 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target: HTMLEl
186
186
  @click=${() => input.onPinClick(p.id)}
187
187
  @mouseenter=${() => input.onPinMouseEnter(p.id)}
188
188
  @mouseleave=${input.onPinMouseLeave}>
189
- <div class="comment-cursor"></div>
189
+ <div
190
+ class=${classMap({
191
+ 'comment-cursor': true,
192
+ resolved: p.resolved,
193
+ })}>
194
+ </div>
190
195
  </div>
191
196
  `,
192
197
  )}
@@ -498,7 +503,8 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
498
503
  } else if (this.#activeThreadId && !this.#commentManager.getCommentThread(this.#activeThreadId)) {
499
504
  this.#setActiveThreadId(null);
500
505
  }
501
- if (this.#hoveredThreadId && !this.#commentManager.getCommentThread(this.#hoveredThreadId)) {
506
+ const hoveredThread = this.#getThread(this.#hoveredThreadId);
507
+ if (this.#hoveredThreadId && (!hoveredThread || hoveredThread.status === 'RESOLVED')) {
502
508
  this.#clearHover();
503
509
  }
504
510
  }
@@ -683,10 +689,10 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
683
689
  hoveredThread: CommentManager.CommentManager.CommentThread|null,
684
690
  hoveredTitle: Title,
685
691
  ): void {
686
- const pins = this.#commentOverlayManager.getPinPositions();
687
- const findPin =
688
- (thread: CommentManager.CommentManager.CommentThread|null): Comments.CommentOverlayManager.PinPositionData|
689
- null => thread ? pins.find(p => p.id === thread.id) ?? null : null;
692
+ const pins = this.#commentOverlayManager.getPinPositions().map(
693
+ pin => !pin.visible && pin.id === activeThread?.id ? {...pin, visible: true} : pin);
694
+ const findPin = (thread: CommentManager.CommentManager.CommentThread|null): Comments.CommentOverlayManager.PinData|
695
+ null => thread ? pins.find(p => p.id === thread.id) ?? null : null;
690
696
  const findHighlight =
691
697
  (thread: CommentManager.CommentManager.CommentThread|null): Comments.CommentOverlayManager.HighlightRectData|
692
698
  null => thread ? this.#commentOverlayManager.getHighlight(thread.id) ?? null : null;
@@ -787,7 +793,7 @@ export class ThreadRevealer implements Common.Revealer.Revealer<CommentManager.C
787
793
  async reveal({thread, position}: CommentManager.CommentThread.RevealableThread): Promise<void> {
788
794
  const panelId = Comments.CommentAnchorResolver.extractPanelId(thread.anchor.vePath);
789
795
  if (panelId && UI.InspectorView.InspectorView.instance().hasPanel(panelId)) {
790
- await UI.InspectorView.InspectorView.instance().showPanel(panelId);
796
+ await UI.ViewManager.ViewManager.instance().showView(panelId, true, true);
791
797
  }
792
798
 
793
799
  const element = Comments.CommentAnchorResolver.rematchCommentAnchor(thread);