chrome-devtools-frontend 1.0.1733843 → 1.0.1736236
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/rules/tests/test-view-and-presenter-isolation.md +4 -4
- package/.agents/rules/ui-and-widgets/ui-declarative-tree-and-prompt-patterns.md +61 -0
- package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +11 -7
- package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +13 -4
- package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +31 -2
- package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +23 -4
- package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +34 -3
- package/.agents/skills/code-review/SKILL.md +27 -0
- package/.agents/skills/devtools-uistrings/SKILL.md +147 -0
- package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -1
- package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +100 -0
- package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +16 -0
- package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +13 -2
- package/.agents/skills/ui-widgets/SKILL.md +25 -25
- package/DIR_METADATA +8 -1
- package/docs/cookbook/localization.md +1 -1
- package/docs/ui_engineering.md +24 -0
- package/eslint.config.mjs +0 -1
- package/front_end/application_tokens.css +1 -1
- package/front_end/core/host/AidaClient.ts +147 -202
- package/front_end/core/host/AidaClientTypes.ts +9 -0
- package/front_end/core/host/AidaErrors.ts +416 -0
- package/front_end/core/host/AidaGcaTranslation.ts +11 -0
- package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -2
- package/front_end/core/host/UserMetrics.ts +25 -0
- package/front_end/core/host/UserMetricsEnums.ts +25 -0
- package/front_end/core/host/host.ts +3 -1
- package/front_end/core/i18n/collect-ui-strings.js +20 -0
- package/front_end/core/root/Runtime.ts +12 -0
- package/front_end/core/sdk/CPUThrottlingManager.ts +3 -0
- package/front_end/core/sdk/EnhancedTracesParser.ts +8 -4
- package/front_end/core/sdk/NetworkManager.ts +0 -6
- package/front_end/core/sdk/OverlayModel.ts +0 -6
- package/front_end/core/sdk/PreloadingModel.ts +30 -13
- package/front_end/core/sdk/PrivateVerificationTokensModel.ts +0 -18
- package/front_end/core/sdk/RehydratingConnection.ts +5 -2
- package/front_end/core/sdk/ResourceTreeModel.ts +0 -42
- package/front_end/core/sdk/ScreenCaptureModel.ts +0 -84
- package/front_end/core/sdk/ServiceWorkerCacheModel.ts +0 -15
- package/front_end/core/sdk/StorageBucketsModel.ts +0 -15
- package/front_end/devtools_compatibility.js +57 -2
- package/front_end/entrypoints/formatter_worker/ScopeParser.ts +4 -2
- package/front_end/entrypoints/inspector_main/RenderingOptions.ts +203 -127
- package/front_end/entrypoints/inspector_main/renderingOptions.css +5 -0
- package/front_end/entrypoints/node_app/app/NodeMain.ts +0 -9
- package/front_end/entrypoints/node_app/app/nodeConnectionsPanel.css +0 -22
- package/front_end/generated/InspectorBackendCommands.ts +1 -1
- package/front_end/generated/SupportedCSSProperties.ts +0 -136
- package/front_end/generated/protocol-proxy-api.d.ts +231 -231
- package/front_end/generated/protocol.ts +1 -0
- package/front_end/models/ai_assistance/AiAgent2.ts +4 -1
- package/front_end/models/ai_assistance/ChangeManager.ts +3 -1
- package/front_end/models/ai_assistance/DOMHelpers.ts +118 -3
- package/front_end/models/ai_assistance/ExtensionScope.ts +31 -24
- package/front_end/models/ai_assistance/agents/AiAgent.ts +6 -0
- package/front_end/models/ai_assistance/agents/PerformanceAgent.snapshot.txt +13 -13
- package/front_end/models/ai_assistance/agents/PerformanceAgent.ts +1 -1
- package/front_end/models/ai_assistance/ai_assistance.ts +2 -0
- package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt +18 -8
- package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.ts +2 -2
- package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt +103 -81
- package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +15 -203
- package/front_end/models/ai_assistance/injected.ts +6 -1
- package/front_end/models/ai_assistance/skills/lighthouse.md +1 -1
- package/front_end/models/ai_assistance/skills/styling.md +8 -10
- package/front_end/models/ai_assistance/tools/GetTraceEventByKey.ts +1 -1
- package/front_end/models/ai_assistance/tools/SetElementStyles.ts +288 -0
- package/front_end/models/ai_assistance/tools/Tool.ts +1 -0
- package/front_end/models/ai_assistance/tools/ToolRegistry.ts +3 -0
- package/front_end/models/bindings/ResourceScriptMapping.ts +64 -16
- package/front_end/models/comment_manager/CD4ABridge.ts +12 -2
- package/front_end/models/comment_manager/CommentManager.ts +24 -4
- package/front_end/models/javascript_metadata/NativeFunctions.ts +41 -1
- package/front_end/models/project_settings/ProjectSettingsModel.ts +1 -1
- package/front_end/models/trace/handlers/FlowsHandler.ts +10 -0
- package/front_end/models/trace/handlers/SamplesHandler.ts +3 -2
- package/front_end/models/trace/handlers/ScriptsHandler.ts +25 -26
- package/front_end/models/trace/helpers/TreeHelpers.ts +4 -0
- package/front_end/models/trace/insights/DuplicatedJavaScript.ts +1 -2
- package/front_end/models/trace/types/TraceEvents.ts +21 -22
- package/front_end/panels/ai_assistance/components/ChatMessage.ts +9 -1
- package/front_end/panels/ai_assistance/components/chatInput.css +4 -4
- package/front_end/panels/animation/AnimationTimeline.ts +3 -3
- package/front_end/panels/animation/animationTimeline.css +6 -4
- package/front_end/panels/application/IndexedDBModel.ts +0 -15
- package/front_end/panels/application/appManifestView.css +2 -5
- package/front_end/panels/application/components/backForwardCacheView.css +1 -5
- package/front_end/panels/application/components/serviceWorkerRouterView.css +2 -2
- package/front_end/panels/application/preloading/components/PreloadingString.ts +7 -0
- package/front_end/panels/comments/CommentsPane.ts +12 -7
- package/front_end/panels/comments/commentsPane.css +16 -2
- package/front_end/panels/common/CommentsOverlayWidget.ts +16 -10
- package/front_end/panels/common/CommentsStatusBarPill.ts +12 -5
- package/front_end/panels/common/commentsOverlay.css +7 -1
- package/front_end/panels/common/commentsStatusBarPill.css +30 -0
- package/front_end/panels/console/consolePrompt.css +0 -12
- package/front_end/panels/console/consoleView.css +2 -2
- package/front_end/panels/developer_resources/developerResourcesView.css +4 -3
- package/front_end/panels/elements/DOMTreeWidget.ts +29 -9
- package/front_end/panels/elements/StylePropertyTreeElement.ts +2 -1
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +12 -5
- package/front_end/panels/elements/components/cssVariableValueView.css +1 -1
- package/front_end/panels/elements/components/elementsBreadcrumbs.css +2 -2
- package/front_end/panels/elements/domTreeWidget.css +6 -1
- package/front_end/panels/elements/elementsPanel.css +0 -6
- package/front_end/panels/elements/layoutPane.css +1 -1
- package/front_end/panels/elements/metricsSidebarPane.css +1 -1
- package/front_end/panels/elements/platformFontsWidget.css +1 -1
- package/front_end/panels/elements/stylesSidebarPane.css +0 -10
- package/front_end/panels/emulation/deviceModeView.css +6 -7
- package/front_end/panels/explain/components/consoleInsight.css +4 -4
- package/front_end/panels/issues/issuesTree.css +1 -26
- package/front_end/panels/lighthouse/lighthouseStartView.css +2 -2
- package/front_end/panels/linear_memory_inspector/components/linearMemoryInspector.css +1 -1
- package/front_end/panels/media/TickingFlameChart.ts +20 -3
- package/front_end/panels/media/playerMessagesView.css +2 -2
- package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +24 -5
- package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +1 -6
- package/front_end/panels/network/networkLogView.css +2 -2
- package/front_end/panels/network/networkTimingTable.css +1 -1
- package/front_end/panels/performance_monitor/performanceMonitor.css +0 -4
- package/front_end/panels/protocol_monitor/JSONEditor.css +1 -1
- package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -2
- package/front_end/panels/recorder/recorderPanel.css +3 -3
- package/front_end/panels/recorder/recordingListView.css +1 -1
- package/front_end/panels/screencast/screencastView.css +1 -1
- package/front_end/panels/search/searchResultsPane.css +1 -1
- package/front_end/panels/security/SecurityModel.ts +0 -6
- package/front_end/panels/security/SecurityPanel.ts +120 -108
- package/front_end/panels/security/originView.css +1 -1
- package/front_end/panels/sensors/locationsSettingsTab.css +3 -3
- package/front_end/panels/settings/EditFileSystemView.ts +159 -104
- package/front_end/panels/settings/editFileSystemView.css +30 -4
- package/front_end/panels/settings/emulation/devicesSettingsTab.css +0 -52
- package/front_end/panels/settings/settingsScreen.css +0 -7
- package/front_end/panels/sources/CallStackSidebarPane.ts +339 -221
- package/front_end/panels/sources/NavigatorView.ts +95 -8
- package/front_end/panels/sources/ThreadsSidebarPane.ts +8 -4
- package/front_end/panels/sources/breakpointsView.css +1 -3
- package/front_end/panels/sources/callStackSidebarPane.css +4 -0
- package/front_end/panels/sources/components/HeadersView.ts +15 -2
- package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -1
- package/front_end/panels/timeline/CountersGraph.ts +0 -4
- package/front_end/panels/timeline/TimelineLoader.ts +16 -6
- package/front_end/panels/timeline/TimelinePanel.ts +20 -12
- package/front_end/panels/timeline/TimelineUIUtils.ts +1 -1
- package/front_end/panels/timeline/components/DetailsView.ts +2 -1
- package/front_end/panels/timeline/components/cwvMetrics.css +1 -1
- package/front_end/panels/timeline/components/metricCard.css +1 -1
- package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +4 -4
- package/front_end/panels/timeline/timelineFlameChartView.css +1 -1
- package/front_end/panels/webauthn/WebauthnPane.ts +13 -14
- package/front_end/panels/webauthn/webauthnPane.css +1 -1
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/ui/comments/CommentOverlayManager.ts +34 -18
- package/front_end/ui/components/icon_button/FileSourceIcon.ts +6 -0
- package/front_end/ui/components/input/textInput.css +1 -1
- package/front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css +6 -4
- package/front_end/ui/components/suggestion_input/suggestionInput.css +2 -2
- package/front_end/ui/components/text_editor/AiCodeGenerationTeaser.ts +14 -2
- package/front_end/ui/legacy/DockController.ts +17 -4
- package/front_end/ui/legacy/Treeoutline.ts +2 -2
- package/front_end/ui/legacy/UIUtils.ts +148 -10
- package/front_end/ui/legacy/components/inline_editor/bezierEditor.css +3 -2
- package/front_end/ui/legacy/components/perf_ui/chartViewport.css +2 -2
- package/front_end/ui/legacy/components/perf_ui/filmStripView.css +2 -2
- package/front_end/ui/legacy/components/perf_ui/pieChart.css +1 -1
- package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +5 -4
- package/front_end/ui/legacy/components/source_frame/imageView.css +1 -1
- package/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts +0 -3
- package/front_end/ui/legacy/components/utils/imagePreview.css +1 -1
- package/front_end/ui/legacy/inspectorCommon.css +1 -14
- package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +3 -2
- package/front_end/ui/legacy/listWidget.css +0 -18
- package/front_end/ui/legacy/theme_support/ThemeSupport.ts +44 -9
- package/front_end/ui/lit/strip-whitespace.ts +1 -1
- package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
- package/package.json +3 -3
- package/front_end/generated/Deprecation.ts +0 -471
- package/front_end/panels/accessibility/axBreadcrumbs.css +0 -155
- package/front_end/panels/network/requestHeadersTree.css +0 -226
- package/front_end/panels/recorder/startView.css +0 -38
- package/front_end/panels/security/ipProtectionView.css +0 -141
- package/front_end/ui/legacy/components/inline_editor/animationNameSwatch.css +0 -27
|
@@ -8,17 +8,19 @@ import * as UI from '../../ui/legacy/legacy.js';
|
|
|
8
8
|
import * as Lit from '../../ui/lit/lit.js';
|
|
9
9
|
import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
|
|
10
10
|
|
|
11
|
+
import commentsStatusBarPillStyles from './commentsStatusBarPill.css.js';
|
|
12
|
+
|
|
11
13
|
const UIStrings = {
|
|
12
14
|
/**
|
|
13
15
|
* @description Button text for the comments status bar pill. Clicking it opens the Comments panel.
|
|
14
16
|
*/
|
|
15
|
-
|
|
17
|
+
viewComments: 'View comments',
|
|
16
18
|
/**
|
|
17
19
|
* @description Button text for the comments status bar pill when the AI agent has responded to some
|
|
18
20
|
* comments and the user has not seen these responses yet. Clicking it opens the Comments panel.
|
|
19
21
|
* @example {2} PH1
|
|
20
22
|
*/
|
|
21
|
-
|
|
23
|
+
viewCommentsWithCount: 'View comments ({PH1})',
|
|
22
24
|
} as const;
|
|
23
25
|
const str_ = i18n.i18n.registerUIStrings('panels/common/CommentsStatusBarPill.ts', UIStrings);
|
|
24
26
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
@@ -39,16 +41,21 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
39
41
|
const tooltip = input.threads.flatMap(thread => thread.comments.map(comment => comment.text)).join('\n');
|
|
40
42
|
// clang-format off
|
|
41
43
|
render(html`
|
|
44
|
+
<style>${commentsStatusBarPillStyles}</style>
|
|
42
45
|
${input.threads.length <= 0 ? Lit.nothing : html`
|
|
43
46
|
<button
|
|
44
47
|
class="devtools-pill"
|
|
45
48
|
title=${tooltip}
|
|
49
|
+
aria-label=${input.unseenResponseCount > 0 ?
|
|
50
|
+
i18nString(UIStrings.viewCommentsWithCount, {PH1: input.unseenResponseCount}) :
|
|
51
|
+
i18nString(UIStrings.viewComments)}
|
|
46
52
|
?disabled=${input.disabled}
|
|
47
53
|
@click=${input.onPillClick}
|
|
48
54
|
jslog=${VisualLogging.action('comments-status-bar-pill').track({click: true})}>
|
|
49
|
-
|
|
50
|
-
|
|
51
|
-
|
|
55
|
+
<span>${i18nString(UIStrings.viewComments)}</span>
|
|
56
|
+
${input.unseenResponseCount > 0 ? html`
|
|
57
|
+
<span class="comments-counter-badge">${input.unseenResponseCount}</span>
|
|
58
|
+
` : Lit.nothing}
|
|
52
59
|
</button>
|
|
53
60
|
`}
|
|
54
61
|
`, target);
|
|
@@ -40,11 +40,17 @@
|
|
|
40
40
|
flex-shrink: 0;
|
|
41
41
|
box-shadow: var(--sys-elevation-level2);
|
|
42
42
|
border-radius: 100px 100px 100px var(--sys-shape-corner-extra-small, 4px);
|
|
43
|
-
|
|
43
|
+
border: var(--sys-size-2) solid var(--sys-color-primary);
|
|
44
|
+
background: var(--sys-color-cdt-base-container);
|
|
44
45
|
transition: transform 0.1s ease;
|
|
45
46
|
transform-origin: center center;
|
|
46
47
|
}
|
|
47
48
|
|
|
49
|
+
.comment-cursor.resolved {
|
|
50
|
+
border: none;
|
|
51
|
+
background: var(--sys-color-primary);
|
|
52
|
+
}
|
|
53
|
+
|
|
48
54
|
.comment-anchor-highlight {
|
|
49
55
|
position: absolute;
|
|
50
56
|
top: 0;
|
|
@@ -0,0 +1,30 @@
|
|
|
1
|
+
/*
|
|
2
|
+
* Copyright 2026 The Chromium Authors
|
|
3
|
+
* Use of this source code is governed by a BSD-style license that can be
|
|
4
|
+
* found in the LICENSE file.
|
|
5
|
+
*/
|
|
6
|
+
|
|
7
|
+
@scope to (devtools-widget > *) {
|
|
8
|
+
.comments-counter-badge {
|
|
9
|
+
display: inline-flex;
|
|
10
|
+
align-items: center;
|
|
11
|
+
justify-content: center;
|
|
12
|
+
box-sizing: border-box;
|
|
13
|
+
height: var(--sys-size-7);
|
|
14
|
+
min-width: var(--sys-size-8);
|
|
15
|
+
width: fit-content;
|
|
16
|
+
padding: 0 var(--sys-size-3);
|
|
17
|
+
border-radius: var(--sys-shape-corner-full);
|
|
18
|
+
background-color: var(--sys-color-primary);
|
|
19
|
+
color: var(--sys-color-on-primary);
|
|
20
|
+
font-size: var(--sys-typescale-body5-size);
|
|
21
|
+
font-weight: var(--ref-typeface-weight-bold);
|
|
22
|
+
line-height: var(--sys-size-7);
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
.devtools-pill:disabled .comments-counter-badge,
|
|
26
|
+
.devtools-pill[aria-disabled="true"] .comments-counter-badge {
|
|
27
|
+
background-color: var(--sys-color-state-disabled-container);
|
|
28
|
+
color: var(--sys-color-state-disabled);
|
|
29
|
+
}
|
|
30
|
+
}
|
|
@@ -4,18 +4,6 @@
|
|
|
4
4
|
* found in the LICENSE file.
|
|
5
5
|
*/
|
|
6
6
|
|
|
7
|
-
#console-prompt .CodeMirror {
|
|
8
|
-
padding: 3px 0 1px;
|
|
9
|
-
}
|
|
10
|
-
|
|
11
|
-
#console-prompt .CodeMirror-line {
|
|
12
|
-
padding-top: 0;
|
|
13
|
-
}
|
|
14
|
-
|
|
15
|
-
#console-prompt .CodeMirror-lines {
|
|
16
|
-
padding-top: 0;
|
|
17
|
-
}
|
|
18
|
-
|
|
19
7
|
#console-prompt .console-prompt-icon {
|
|
20
8
|
position: absolute;
|
|
21
9
|
left: calc(-1 * var(--sys-size-6));
|
|
@@ -218,7 +218,7 @@
|
|
|
218
218
|
--console-color-lightgreen: #5f5;
|
|
219
219
|
--console-color-lightyellow: #ff5;
|
|
220
220
|
--console-color-lightblue: #55f;
|
|
221
|
-
--console-color-
|
|
221
|
+
--console-color-lightmagenta: #f5f;
|
|
222
222
|
--console-color-lightcyan: #5ff;
|
|
223
223
|
--console-color-white: #fff;
|
|
224
224
|
|
|
@@ -261,7 +261,7 @@
|
|
|
261
261
|
.console-message-wrapper:not(.console-error-level, .console-warning-level) {
|
|
262
262
|
& .console-message::before,
|
|
263
263
|
& .console-user-command::before {
|
|
264
|
-
width: calc(100% -
|
|
264
|
+
width: calc(100% - var(--sys-size-11));
|
|
265
265
|
content: "";
|
|
266
266
|
display: block;
|
|
267
267
|
position: absolute;
|
|
@@ -22,10 +22,11 @@
|
|
|
22
22
|
.developer-resource-view-toolbar-summary {
|
|
23
23
|
background-color: var(--sys-color-cdt-base-container);
|
|
24
24
|
border-top: var(--sys-size-1) solid var(--sys-color-divider);
|
|
25
|
-
padding-left:
|
|
26
|
-
|
|
25
|
+
padding-left: var(--sys-size-3);
|
|
26
|
+
/* 20px footer bar (--sys-size-9) minus 1px top border (--sys-size-1). */
|
|
27
|
+
flex: 0 0 calc(var(--sys-size-9) - var(--sys-size-1));
|
|
27
28
|
display: flex;
|
|
28
|
-
padding-right:
|
|
29
|
+
padding-right: var(--sys-size-3);
|
|
29
30
|
}
|
|
30
31
|
|
|
31
32
|
.developer-resource-view-toolbar-summary .developer-resource-view-message {
|
|
@@ -377,8 +377,10 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
377
377
|
const onShortcutExpand = (event: UI.TreeOutline.TreeViewElement.ExpandEvent): void => {
|
|
378
378
|
input.onToggleTopLayerShortcutExpanded(shortcut, event.detail.expanded);
|
|
379
379
|
};
|
|
380
|
-
const onShortcutSelect = (): void => {
|
|
381
|
-
|
|
380
|
+
const onShortcutSelect = (event: UI.TreeOutline.TreeViewElement.SelectEvent): void => {
|
|
381
|
+
if (event.detail?.selectedByUser) {
|
|
382
|
+
input.onSelectTopLayerShortcut(shortcut);
|
|
383
|
+
}
|
|
382
384
|
};
|
|
383
385
|
const onReveal = (event: Event): void => {
|
|
384
386
|
event.stopPropagation();
|
|
@@ -442,8 +444,10 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
442
444
|
const onTopLayerExpand = (event: UI.TreeOutline.TreeViewElement.ExpandEvent): void => {
|
|
443
445
|
input.onToggleTopLayerExpanded(doc, event.detail.expanded);
|
|
444
446
|
};
|
|
445
|
-
const onTopLayerSelect = (): void => {
|
|
446
|
-
|
|
447
|
+
const onTopLayerSelect = (event: UI.TreeOutline.TreeViewElement.SelectEvent): void => {
|
|
448
|
+
if (event.detail?.selectedByUser) {
|
|
449
|
+
input.onSelectTopLayerContainer(doc);
|
|
450
|
+
}
|
|
447
451
|
};
|
|
448
452
|
|
|
449
453
|
// clang-format off
|
|
@@ -472,8 +476,10 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
472
476
|
const onExpand = (event: UI.TreeOutline.TreeViewElement.ExpandEvent): void => {
|
|
473
477
|
input.onToggleAdoptedStyleSheetExpanded(sheet, event.detail.expanded);
|
|
474
478
|
};
|
|
475
|
-
const onSelect = (): void => {
|
|
476
|
-
|
|
479
|
+
const onSelect = (event: UI.TreeOutline.TreeViewElement.SelectEvent): void => {
|
|
480
|
+
if (event.detail?.selectedByUser) {
|
|
481
|
+
input.onSelectAdoptedStyleSheet(sheet);
|
|
482
|
+
}
|
|
477
483
|
};
|
|
478
484
|
|
|
479
485
|
// clang-format off
|
|
@@ -517,8 +523,10 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
517
523
|
const onExpand = (event: UI.TreeOutline.TreeViewElement.ExpandEvent): void => {
|
|
518
524
|
input.onToggleAdoptedStyleSheetsExpanded(node, event.detail.expanded);
|
|
519
525
|
};
|
|
520
|
-
const onSelect = (): void => {
|
|
521
|
-
|
|
526
|
+
const onSelect = (event: UI.TreeOutline.TreeViewElement.SelectEvent): void => {
|
|
527
|
+
if (event.detail?.selectedByUser) {
|
|
528
|
+
input.onSelectAdoptedStyleSheets(node);
|
|
529
|
+
}
|
|
522
530
|
};
|
|
523
531
|
|
|
524
532
|
// clang-format off
|
|
@@ -673,6 +681,8 @@ export const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target:
|
|
|
673
681
|
'in-clipboard': input.isNodeInClipboard(node),
|
|
674
682
|
'elements-drag-over': isDragOver,
|
|
675
683
|
'always-parent': !isCollapsible && !isEditingAsHTML,
|
|
684
|
+
// Draws the vertical guide line next to the shadow root children.
|
|
685
|
+
'shadow-root': node.isShadowRoot(),
|
|
676
686
|
});
|
|
677
687
|
|
|
678
688
|
// The opening and the closing tag are separate rows that report the
|
|
@@ -1498,10 +1508,10 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
1498
1508
|
if (!isSameNode) {
|
|
1499
1509
|
this.#notifySelectedNodeChanged(node, Boolean(focus));
|
|
1500
1510
|
}
|
|
1501
|
-
this.performUpdate();
|
|
1502
1511
|
if (focus) {
|
|
1503
1512
|
this.focus();
|
|
1504
1513
|
}
|
|
1514
|
+
this.performUpdate();
|
|
1505
1515
|
}
|
|
1506
1516
|
|
|
1507
1517
|
/** Raises the children limit of `ancestor` if `child` is paginated away. */
|
|
@@ -1545,6 +1555,15 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
1545
1555
|
return;
|
|
1546
1556
|
}
|
|
1547
1557
|
if (expanded) {
|
|
1558
|
+
// The tree outline dispatches an `expand` event for every node that is
|
|
1559
|
+
// rendered with the `open` attribute. After `expandRecursively()`, this
|
|
1560
|
+
// happens once per node in the subtree. Each event would otherwise
|
|
1561
|
+
// trigger a synchronous re-render of the whole tree, which is quadratic
|
|
1562
|
+
// in the number of expanded nodes. Skip the work when the node is
|
|
1563
|
+
// already expanded and its children are loaded.
|
|
1564
|
+
if (this.#expandedNodes.has(node) && node.children()) {
|
|
1565
|
+
return;
|
|
1566
|
+
}
|
|
1548
1567
|
this.#expandedNodes.add(node);
|
|
1549
1568
|
// Children that are not collapsible (e.g. the document element) render
|
|
1550
1569
|
// without an expand arrow, so their children must be fetched eagerly.
|
|
@@ -1623,6 +1642,7 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
1623
1642
|
};
|
|
1624
1643
|
await expand(node, 0);
|
|
1625
1644
|
this.performUpdate();
|
|
1645
|
+
this.onElementExpanded();
|
|
1626
1646
|
}
|
|
1627
1647
|
|
|
1628
1648
|
collapseChildren(node: SDK.DOMModel.DOMNode): void {
|
|
@@ -3236,7 +3236,8 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
|
|
|
3236
3236
|
hintIcon.setAttribute('aria-details', tooltipId);
|
|
3237
3237
|
const tooltip = new Tooltips.Tooltip.Tooltip(
|
|
3238
3238
|
{anchor: hintIcon, variant: 'rich', padding: 'large', id: tooltipId, jslogContext: 'elements.css-hint'});
|
|
3239
|
-
const hintDetailsView = new ElementsComponents.CSSHintDetailsView.CSSHintDetailsView(
|
|
3239
|
+
const hintDetailsView = new ElementsComponents.CSSHintDetailsView.CSSHintDetailsView();
|
|
3240
|
+
hintDetailsView.authoringHint = hint;
|
|
3240
3241
|
hintDetailsView.markAsRoot();
|
|
3241
3242
|
hintDetailsView.show(tooltip);
|
|
3242
3243
|
this.listItemElement.appendChild(tooltip);
|
|
@@ -18,7 +18,7 @@ const UIStrings = {
|
|
|
18
18
|
const str_ = i18n.i18n.registerUIStrings('panels/elements/components/CSSHintDetailsView.ts', UIStrings);
|
|
19
19
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
20
20
|
|
|
21
|
-
interface Hint {
|
|
21
|
+
export interface Hint {
|
|
22
22
|
getMessage(): LitTemplate|string;
|
|
23
23
|
getPossibleFixMessage(): LitTemplate|string|null;
|
|
24
24
|
getLearnMoreLink(): string|undefined;
|
|
@@ -63,14 +63,21 @@ export class CSSHintDetailsView extends UI.Widget.Widget {
|
|
|
63
63
|
#authoringHint?: Hint;
|
|
64
64
|
readonly #view: View;
|
|
65
65
|
|
|
66
|
-
constructor(
|
|
66
|
+
constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
|
|
67
67
|
super(element);
|
|
68
|
-
this.#authoringHint = authoringHint;
|
|
69
68
|
this.#view = view;
|
|
70
|
-
this.performUpdate();
|
|
71
69
|
}
|
|
72
70
|
|
|
73
|
-
|
|
71
|
+
override wasShown(): void {
|
|
72
|
+
super.wasShown();
|
|
73
|
+
this.requestUpdate();
|
|
74
|
+
}
|
|
75
|
+
|
|
76
|
+
get authoringHint(): Hint|undefined {
|
|
77
|
+
return this.#authoringHint;
|
|
78
|
+
}
|
|
79
|
+
|
|
80
|
+
set authoringHint(authoringHint: Hint|undefined) {
|
|
74
81
|
if (this.#authoringHint === authoringHint) {
|
|
75
82
|
return;
|
|
76
83
|
}
|
|
@@ -181,6 +181,7 @@ select {
|
|
|
181
181
|
/** Guide line */
|
|
182
182
|
|
|
183
183
|
li.hovered:not(.always-parent) + ol.children,
|
|
184
|
+
li.shadow-root + ol.children,
|
|
184
185
|
li.selected:not(.always-parent) + ol.children {
|
|
185
186
|
background: linear-gradient(to right, var(--override-indentation-level-border-color), var(--override-indentation-level-border-color) 0.5px, transparent 0);
|
|
186
187
|
background-position-x: 5px;
|
|
@@ -192,10 +193,14 @@ li.selected:not(.always-parent) + ol.children {
|
|
|
192
193
|
--override-indentation-level-border-color: var(--sys-color-divider) !important; /* stylelint-disable-line declaration-no-important */
|
|
193
194
|
}
|
|
194
195
|
|
|
195
|
-
li.hovered:not(.always-parent) + ol.children {
|
|
196
|
+
li.hovered:not(.always-parent, .shadow-root) + ol.children {
|
|
196
197
|
--override-indentation-level-border-color: color-mix(in srgb, var(--ref-palette-neutral0) 10%, transparent);
|
|
197
198
|
}
|
|
198
199
|
|
|
200
|
+
li.shadow-root + ol.children {
|
|
201
|
+
--override-indentation-level-border-color: var(--ref-palette-orange95);
|
|
202
|
+
}
|
|
203
|
+
|
|
199
204
|
@media (forced-colors: active) {
|
|
200
205
|
.elements-disclosure li.parent::before {
|
|
201
206
|
forced-color-adjust: none;
|
|
@@ -162,7 +162,6 @@
|
|
|
162
162
|
float: right;
|
|
163
163
|
padding: var(--sys-size-2) var(--sys-size-2) 0 var(--sys-size-8);
|
|
164
164
|
max-width: 100%;
|
|
165
|
-
height: 15px;
|
|
166
165
|
margin-bottom: calc(-1 * var(--sys-size-1));
|
|
167
166
|
}
|
|
168
167
|
|
|
@@ -255,15 +254,6 @@
|
|
|
255
254
|
overflow: hidden;
|
|
256
255
|
line-height: var(--sys-size-10);
|
|
257
256
|
|
|
258
|
-
> span.monospace {
|
|
259
|
-
max-width: 180px;
|
|
260
|
-
display: inline-block;
|
|
261
|
-
overflow: hidden;
|
|
262
|
-
text-overflow: ellipsis;
|
|
263
|
-
vertical-align: middle;
|
|
264
|
-
margin-left: var(--sys-size-2);
|
|
265
|
-
}
|
|
266
|
-
|
|
267
257
|
&.layer-separator {
|
|
268
258
|
display: flex;
|
|
269
259
|
align-items: baseline;
|
|
@@ -228,7 +228,6 @@ devtools-toolbar.device-mode-toolbar-options {
|
|
|
228
228
|
/* stylelint-disable-next-line custom-property-pattern */
|
|
229
229
|
content: var(--image-file-resizeHorizontal);
|
|
230
230
|
width: var(--sys-size-4);
|
|
231
|
-
height: 26px;
|
|
232
231
|
}
|
|
233
232
|
|
|
234
233
|
.device-mode-bottom-resizer > div {
|
|
@@ -250,10 +249,10 @@ devtools-toolbar.device-mode-toolbar-options {
|
|
|
250
249
|
|
|
251
250
|
.device-mode-bottom-left-resizer > div {
|
|
252
251
|
position: absolute;
|
|
253
|
-
bottom:
|
|
254
|
-
left:
|
|
255
|
-
width:
|
|
256
|
-
height:
|
|
252
|
+
bottom: var(--sys-size-3);
|
|
253
|
+
left: var(--sys-size-3);
|
|
254
|
+
width: var(--sys-size-6);
|
|
255
|
+
height: var(--sys-size-6);
|
|
257
256
|
/* stylelint-disable-next-line custom-property-pattern */
|
|
258
257
|
content: var(--image-file-resizeDiagonal);
|
|
259
258
|
transform: rotate(90deg);
|
|
@@ -328,7 +327,7 @@ devtools-toolbar.device-mode-toolbar-options {
|
|
|
328
327
|
|
|
329
328
|
.device-mode-ruler-top .device-mode-ruler-marker {
|
|
330
329
|
width: 0;
|
|
331
|
-
height:
|
|
330
|
+
height: var(--sys-size-3);
|
|
332
331
|
bottom: 0;
|
|
333
332
|
border-right: var(--sys-size-1) solid var(--sys-color-token-subtle);
|
|
334
333
|
margin-right: calc(-1 * var(--sys-size-1));
|
|
@@ -339,7 +338,7 @@ devtools-toolbar.device-mode-toolbar-options {
|
|
|
339
338
|
}
|
|
340
339
|
|
|
341
340
|
.device-mode-ruler-top .device-mode-ruler-marker.device-mode-ruler-marker-large {
|
|
342
|
-
height:
|
|
341
|
+
height: var(--sys-size-7);
|
|
343
342
|
}
|
|
344
343
|
|
|
345
344
|
.device-mode-ruler-left .device-mode-ruler-marker {
|
|
@@ -189,7 +189,7 @@
|
|
|
189
189
|
|
|
190
190
|
.buttons {
|
|
191
191
|
display: flex;
|
|
192
|
-
gap:
|
|
192
|
+
gap: var(--sys-size-3);
|
|
193
193
|
}
|
|
194
194
|
|
|
195
195
|
@media (width <= 500px) {
|
|
@@ -387,14 +387,14 @@
|
|
|
387
387
|
display: block;
|
|
388
388
|
}
|
|
389
389
|
|
|
390
|
-
ul {
|
|
390
|
+
:scope ul {
|
|
391
391
|
color: var(--sys-color-primary);
|
|
392
392
|
font-size: var(--sys-typescale-body4-size);
|
|
393
393
|
font-style: normal;
|
|
394
394
|
font-weight: 400;
|
|
395
|
-
line-height:
|
|
395
|
+
line-height: var(--sys-typescale-body4-line-height);
|
|
396
396
|
margin-top: var(--sys-size-6);
|
|
397
|
-
padding-
|
|
397
|
+
padding-inline-start: var(--sys-size-3);
|
|
398
398
|
}
|
|
399
399
|
|
|
400
400
|
li {
|
|
@@ -191,31 +191,6 @@ devtools-icon.leading-issue-icon {
|
|
|
191
191
|
margin: var(--sys-size-1) 0 calc(-1 * var(--sys-size-1)) calc(var(--sys-size-5) - var(--sys-size-1));
|
|
192
192
|
}
|
|
193
193
|
|
|
194
|
-
.message {
|
|
195
|
-
line-height: 18px;
|
|
196
|
-
font-size: var(--sys-typescale-body4-size);
|
|
197
|
-
color: var(--sys-color-token-subtle);
|
|
198
|
-
margin-bottom: var(--sys-size-3);
|
|
199
|
-
user-select: text;
|
|
200
|
-
}
|
|
201
|
-
|
|
202
|
-
.message p {
|
|
203
|
-
margin-bottom: var(--sys-size-8);
|
|
204
|
-
}
|
|
205
|
-
|
|
206
|
-
.message li {
|
|
207
|
-
margin-top: var(--sys-size-5);
|
|
208
|
-
}
|
|
209
|
-
|
|
210
|
-
.message code {
|
|
211
|
-
color: var(--sys-color-on-surface);
|
|
212
|
-
padding: 0 var(--sys-size-2);
|
|
213
|
-
font-size: var(--sys-typescale-body4-size);
|
|
214
|
-
user-select: text;
|
|
215
|
-
cursor: text;
|
|
216
|
-
background: var(--sys-color-surface2);
|
|
217
|
-
}
|
|
218
|
-
|
|
219
194
|
.separator::before {
|
|
220
195
|
content: "·";
|
|
221
196
|
padding-left: 1ex;
|
|
@@ -424,7 +399,7 @@ ul > li.plain-enum::before {
|
|
|
424
399
|
|
|
425
400
|
.affected-resources > .children.expanded {
|
|
426
401
|
background: var(--sys-color-cdt-base-container);
|
|
427
|
-
padding: var(--sys-size-4) 0
|
|
402
|
+
padding: var(--sys-size-4) 0 var(--sys-size-5) var(--sys-size-3);
|
|
428
403
|
}
|
|
429
404
|
|
|
430
405
|
.aggregated-issues-count {
|
|
@@ -376,9 +376,16 @@ export class TickingFlameChart extends UI.Widget.VBox {
|
|
|
376
376
|
this.updateRender();
|
|
377
377
|
}
|
|
378
378
|
|
|
379
|
+
readonly #onThemeChanged = (): void => {
|
|
380
|
+
this.dataProvider.updateGroupColors();
|
|
381
|
+
this.requestUpdate();
|
|
382
|
+
};
|
|
383
|
+
|
|
379
384
|
override willHide(): void {
|
|
380
385
|
super.willHide();
|
|
381
386
|
this.isShown = false;
|
|
387
|
+
ThemeSupport.ThemeSupport.instance().removeEventListener(ThemeSupport.ThemeChangeEvent.eventName,
|
|
388
|
+
this.#onThemeChanged);
|
|
382
389
|
if (this.ticking) {
|
|
383
390
|
this.stop();
|
|
384
391
|
}
|
|
@@ -387,6 +394,9 @@ export class TickingFlameChart extends UI.Widget.VBox {
|
|
|
387
394
|
override wasShown(): void {
|
|
388
395
|
super.wasShown();
|
|
389
396
|
this.isShown = true;
|
|
397
|
+
ThemeSupport.ThemeSupport.instance().addEventListener(ThemeSupport.ThemeChangeEvent.eventName,
|
|
398
|
+
this.#onThemeChanged);
|
|
399
|
+
this.#onThemeChanged();
|
|
390
400
|
if (this.#canTick && !this.ticking) {
|
|
391
401
|
this.start();
|
|
392
402
|
}
|
|
@@ -496,13 +506,20 @@ class TickingFlameChartDataProvider implements PerfUI.FlameChart.FlameChartDataP
|
|
|
496
506
|
track: null,
|
|
497
507
|
};
|
|
498
508
|
this.#timelineData.groups.push(newGroup);
|
|
499
|
-
ThemeSupport.ThemeSupport.instance().addEventListener(ThemeSupport.ThemeChangeEvent.eventName, () => {
|
|
500
|
-
newGroup.style.color = getGroupDefaultTextColor();
|
|
501
|
-
});
|
|
502
509
|
}
|
|
503
510
|
this.maxLevel += depth;
|
|
504
511
|
}
|
|
505
512
|
|
|
513
|
+
updateGroupColors(): void {
|
|
514
|
+
if (!this.#timelineData.groups) {
|
|
515
|
+
return;
|
|
516
|
+
}
|
|
517
|
+
const color = getGroupDefaultTextColor();
|
|
518
|
+
for (const group of this.#timelineData.groups) {
|
|
519
|
+
group.style.color = color;
|
|
520
|
+
}
|
|
521
|
+
}
|
|
522
|
+
|
|
506
523
|
/**
|
|
507
524
|
* Create an event which will be set to live by default.
|
|
508
525
|
*/
|
|
@@ -57,7 +57,7 @@
|
|
|
57
57
|
}
|
|
58
58
|
|
|
59
59
|
.media-message-error {
|
|
60
|
-
border-radius:
|
|
60
|
+
border-radius: var(--sys-shape-corner-extra-small);
|
|
61
61
|
background-color: var(--sys-color-surface-error);
|
|
62
62
|
color: var(--sys-color-on-surface-error);
|
|
63
63
|
}
|
|
@@ -73,7 +73,7 @@
|
|
|
73
73
|
.status-error-box {
|
|
74
74
|
font-family: var(--monospace-font-family);
|
|
75
75
|
border: var(--sys-size-1) solid var(--sys-color-error-outline);
|
|
76
|
-
border-radius:
|
|
76
|
+
border-radius: var(--sys-shape-corner-extra-small);
|
|
77
77
|
padding: var(--sys-size-3);
|
|
78
78
|
}
|
|
79
79
|
|