chrome-devtools-frontend 1.0.1733843 → 1.0.1736236

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (184) hide show
  1. package/.agents/rules/tests/test-view-and-presenter-isolation.md +4 -4
  2. package/.agents/rules/ui-and-widgets/ui-declarative-tree-and-prompt-patterns.md +61 -0
  3. package/.agents/rules/ui-and-widgets/ui-lit-declarative-templates-and-directives.md +11 -7
  4. package/.agents/rules/ui-and-widgets/ui-modern-component-and-encapsulation-standards.md +13 -4
  5. package/.agents/rules/ui-and-widgets/ui-pure-view-and-presenter-separation.md +31 -2
  6. package/.agents/rules/ui-and-widgets/ui-reactive-widget-update-lifecycle.md +23 -4
  7. package/.agents/rules/ui-and-widgets/ui-widget-dom-and-listener-lifecycle.md +34 -3
  8. package/.agents/skills/code-review/SKILL.md +27 -0
  9. package/.agents/skills/devtools-uistrings/SKILL.md +147 -0
  10. package/.agents/skills/ui-eng-vision-local-lit-renderer/SKILL.md +27 -1
  11. package/.agents/skills/ui-eng-vision-orchestrator/SKILL.md +100 -0
  12. package/.agents/skills/ui-eng-vision-test-scaffolder/SKILL.md +16 -0
  13. package/.agents/skills/ui-eng-vision-widget-promoter/SKILL.md +13 -2
  14. package/.agents/skills/ui-widgets/SKILL.md +25 -25
  15. package/DIR_METADATA +8 -1
  16. package/docs/cookbook/localization.md +1 -1
  17. package/docs/ui_engineering.md +24 -0
  18. package/eslint.config.mjs +0 -1
  19. package/front_end/application_tokens.css +1 -1
  20. package/front_end/core/host/AidaClient.ts +147 -202
  21. package/front_end/core/host/AidaClientTypes.ts +9 -0
  22. package/front_end/core/host/AidaErrors.ts +416 -0
  23. package/front_end/core/host/AidaGcaTranslation.ts +11 -0
  24. package/front_end/core/host/InspectorFrontendHostAPI.ts +9 -2
  25. package/front_end/core/host/UserMetrics.ts +25 -0
  26. package/front_end/core/host/UserMetricsEnums.ts +25 -0
  27. package/front_end/core/host/host.ts +3 -1
  28. package/front_end/core/i18n/collect-ui-strings.js +20 -0
  29. package/front_end/core/root/Runtime.ts +12 -0
  30. package/front_end/core/sdk/CPUThrottlingManager.ts +3 -0
  31. package/front_end/core/sdk/EnhancedTracesParser.ts +8 -4
  32. package/front_end/core/sdk/NetworkManager.ts +0 -6
  33. package/front_end/core/sdk/OverlayModel.ts +0 -6
  34. package/front_end/core/sdk/PreloadingModel.ts +30 -13
  35. package/front_end/core/sdk/PrivateVerificationTokensModel.ts +0 -18
  36. package/front_end/core/sdk/RehydratingConnection.ts +5 -2
  37. package/front_end/core/sdk/ResourceTreeModel.ts +0 -42
  38. package/front_end/core/sdk/ScreenCaptureModel.ts +0 -84
  39. package/front_end/core/sdk/ServiceWorkerCacheModel.ts +0 -15
  40. package/front_end/core/sdk/StorageBucketsModel.ts +0 -15
  41. package/front_end/devtools_compatibility.js +57 -2
  42. package/front_end/entrypoints/formatter_worker/ScopeParser.ts +4 -2
  43. package/front_end/entrypoints/inspector_main/RenderingOptions.ts +203 -127
  44. package/front_end/entrypoints/inspector_main/renderingOptions.css +5 -0
  45. package/front_end/entrypoints/node_app/app/NodeMain.ts +0 -9
  46. package/front_end/entrypoints/node_app/app/nodeConnectionsPanel.css +0 -22
  47. package/front_end/generated/InspectorBackendCommands.ts +1 -1
  48. package/front_end/generated/SupportedCSSProperties.ts +0 -136
  49. package/front_end/generated/protocol-proxy-api.d.ts +231 -231
  50. package/front_end/generated/protocol.ts +1 -0
  51. package/front_end/models/ai_assistance/AiAgent2.ts +4 -1
  52. package/front_end/models/ai_assistance/ChangeManager.ts +3 -1
  53. package/front_end/models/ai_assistance/DOMHelpers.ts +118 -3
  54. package/front_end/models/ai_assistance/ExtensionScope.ts +31 -24
  55. package/front_end/models/ai_assistance/agents/AiAgent.ts +6 -0
  56. package/front_end/models/ai_assistance/agents/PerformanceAgent.snapshot.txt +13 -13
  57. package/front_end/models/ai_assistance/agents/PerformanceAgent.ts +1 -1
  58. package/front_end/models/ai_assistance/ai_assistance.ts +2 -0
  59. package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt +18 -8
  60. package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.ts +2 -2
  61. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt +103 -81
  62. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts +15 -203
  63. package/front_end/models/ai_assistance/injected.ts +6 -1
  64. package/front_end/models/ai_assistance/skills/lighthouse.md +1 -1
  65. package/front_end/models/ai_assistance/skills/styling.md +8 -10
  66. package/front_end/models/ai_assistance/tools/GetTraceEventByKey.ts +1 -1
  67. package/front_end/models/ai_assistance/tools/SetElementStyles.ts +288 -0
  68. package/front_end/models/ai_assistance/tools/Tool.ts +1 -0
  69. package/front_end/models/ai_assistance/tools/ToolRegistry.ts +3 -0
  70. package/front_end/models/bindings/ResourceScriptMapping.ts +64 -16
  71. package/front_end/models/comment_manager/CD4ABridge.ts +12 -2
  72. package/front_end/models/comment_manager/CommentManager.ts +24 -4
  73. package/front_end/models/javascript_metadata/NativeFunctions.ts +41 -1
  74. package/front_end/models/project_settings/ProjectSettingsModel.ts +1 -1
  75. package/front_end/models/trace/handlers/FlowsHandler.ts +10 -0
  76. package/front_end/models/trace/handlers/SamplesHandler.ts +3 -2
  77. package/front_end/models/trace/handlers/ScriptsHandler.ts +25 -26
  78. package/front_end/models/trace/helpers/TreeHelpers.ts +4 -0
  79. package/front_end/models/trace/insights/DuplicatedJavaScript.ts +1 -2
  80. package/front_end/models/trace/types/TraceEvents.ts +21 -22
  81. package/front_end/panels/ai_assistance/components/ChatMessage.ts +9 -1
  82. package/front_end/panels/ai_assistance/components/chatInput.css +4 -4
  83. package/front_end/panels/animation/AnimationTimeline.ts +3 -3
  84. package/front_end/panels/animation/animationTimeline.css +6 -4
  85. package/front_end/panels/application/IndexedDBModel.ts +0 -15
  86. package/front_end/panels/application/appManifestView.css +2 -5
  87. package/front_end/panels/application/components/backForwardCacheView.css +1 -5
  88. package/front_end/panels/application/components/serviceWorkerRouterView.css +2 -2
  89. package/front_end/panels/application/preloading/components/PreloadingString.ts +7 -0
  90. package/front_end/panels/comments/CommentsPane.ts +12 -7
  91. package/front_end/panels/comments/commentsPane.css +16 -2
  92. package/front_end/panels/common/CommentsOverlayWidget.ts +16 -10
  93. package/front_end/panels/common/CommentsStatusBarPill.ts +12 -5
  94. package/front_end/panels/common/commentsOverlay.css +7 -1
  95. package/front_end/panels/common/commentsStatusBarPill.css +30 -0
  96. package/front_end/panels/console/consolePrompt.css +0 -12
  97. package/front_end/panels/console/consoleView.css +2 -2
  98. package/front_end/panels/developer_resources/developerResourcesView.css +4 -3
  99. package/front_end/panels/elements/DOMTreeWidget.ts +29 -9
  100. package/front_end/panels/elements/StylePropertyTreeElement.ts +2 -1
  101. package/front_end/panels/elements/components/CSSHintDetailsView.ts +12 -5
  102. package/front_end/panels/elements/components/cssVariableValueView.css +1 -1
  103. package/front_end/panels/elements/components/elementsBreadcrumbs.css +2 -2
  104. package/front_end/panels/elements/domTreeWidget.css +6 -1
  105. package/front_end/panels/elements/elementsPanel.css +0 -6
  106. package/front_end/panels/elements/layoutPane.css +1 -1
  107. package/front_end/panels/elements/metricsSidebarPane.css +1 -1
  108. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  109. package/front_end/panels/elements/stylesSidebarPane.css +0 -10
  110. package/front_end/panels/emulation/deviceModeView.css +6 -7
  111. package/front_end/panels/explain/components/consoleInsight.css +4 -4
  112. package/front_end/panels/issues/issuesTree.css +1 -26
  113. package/front_end/panels/lighthouse/lighthouseStartView.css +2 -2
  114. package/front_end/panels/linear_memory_inspector/components/linearMemoryInspector.css +1 -1
  115. package/front_end/panels/media/TickingFlameChart.ts +20 -3
  116. package/front_end/panels/media/playerMessagesView.css +2 -2
  117. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +24 -5
  118. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +1 -6
  119. package/front_end/panels/network/networkLogView.css +2 -2
  120. package/front_end/panels/network/networkTimingTable.css +1 -1
  121. package/front_end/panels/performance_monitor/performanceMonitor.css +0 -4
  122. package/front_end/panels/protocol_monitor/JSONEditor.css +1 -1
  123. package/front_end/panels/protocol_monitor/JSONEditor.ts +4 -2
  124. package/front_end/panels/recorder/recorderPanel.css +3 -3
  125. package/front_end/panels/recorder/recordingListView.css +1 -1
  126. package/front_end/panels/screencast/screencastView.css +1 -1
  127. package/front_end/panels/search/searchResultsPane.css +1 -1
  128. package/front_end/panels/security/SecurityModel.ts +0 -6
  129. package/front_end/panels/security/SecurityPanel.ts +120 -108
  130. package/front_end/panels/security/originView.css +1 -1
  131. package/front_end/panels/sensors/locationsSettingsTab.css +3 -3
  132. package/front_end/panels/settings/EditFileSystemView.ts +159 -104
  133. package/front_end/panels/settings/editFileSystemView.css +30 -4
  134. package/front_end/panels/settings/emulation/devicesSettingsTab.css +0 -52
  135. package/front_end/panels/settings/settingsScreen.css +0 -7
  136. package/front_end/panels/sources/CallStackSidebarPane.ts +339 -221
  137. package/front_end/panels/sources/NavigatorView.ts +95 -8
  138. package/front_end/panels/sources/ThreadsSidebarPane.ts +8 -4
  139. package/front_end/panels/sources/breakpointsView.css +1 -3
  140. package/front_end/panels/sources/callStackSidebarPane.css +4 -0
  141. package/front_end/panels/sources/components/HeadersView.ts +15 -2
  142. package/front_end/panels/sources/watchExpressionsSidebarPane.css +0 -1
  143. package/front_end/panels/timeline/CountersGraph.ts +0 -4
  144. package/front_end/panels/timeline/TimelineLoader.ts +16 -6
  145. package/front_end/panels/timeline/TimelinePanel.ts +20 -12
  146. package/front_end/panels/timeline/TimelineUIUtils.ts +1 -1
  147. package/front_end/panels/timeline/components/DetailsView.ts +2 -1
  148. package/front_end/panels/timeline/components/cwvMetrics.css +1 -1
  149. package/front_end/panels/timeline/components/metricCard.css +1 -1
  150. package/front_end/panels/timeline/components/sidebarAnnotationsTab.css +4 -4
  151. package/front_end/panels/timeline/timelineFlameChartView.css +1 -1
  152. package/front_end/panels/webauthn/WebauthnPane.ts +13 -14
  153. package/front_end/panels/webauthn/webauthnPane.css +1 -1
  154. package/front_end/third_party/chromium/README.chromium +1 -1
  155. package/front_end/ui/comments/CommentOverlayManager.ts +34 -18
  156. package/front_end/ui/components/icon_button/FileSourceIcon.ts +6 -0
  157. package/front_end/ui/components/input/textInput.css +1 -1
  158. package/front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css +6 -4
  159. package/front_end/ui/components/suggestion_input/suggestionInput.css +2 -2
  160. package/front_end/ui/components/text_editor/AiCodeGenerationTeaser.ts +14 -2
  161. package/front_end/ui/legacy/DockController.ts +17 -4
  162. package/front_end/ui/legacy/Treeoutline.ts +2 -2
  163. package/front_end/ui/legacy/UIUtils.ts +148 -10
  164. package/front_end/ui/legacy/components/inline_editor/bezierEditor.css +3 -2
  165. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +2 -2
  166. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +2 -2
  167. package/front_end/ui/legacy/components/perf_ui/pieChart.css +1 -1
  168. package/front_end/ui/legacy/components/quick_open/filteredListWidget.css +5 -4
  169. package/front_end/ui/legacy/components/source_frame/imageView.css +1 -1
  170. package/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts +0 -3
  171. package/front_end/ui/legacy/components/utils/imagePreview.css +1 -1
  172. package/front_end/ui/legacy/inspectorCommon.css +1 -14
  173. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +3 -2
  174. package/front_end/ui/legacy/listWidget.css +0 -18
  175. package/front_end/ui/legacy/theme_support/ThemeSupport.ts +44 -9
  176. package/front_end/ui/lit/strip-whitespace.ts +1 -1
  177. package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
  178. package/package.json +3 -3
  179. package/front_end/generated/Deprecation.ts +0 -471
  180. package/front_end/panels/accessibility/axBreadcrumbs.css +0 -155
  181. package/front_end/panels/network/requestHeadersTree.css +0 -226
  182. package/front_end/panels/recorder/startView.css +0 -38
  183. package/front_end/panels/security/ipProtectionView.css +0 -141
  184. package/front_end/ui/legacy/components/inline_editor/animationNameSwatch.css +0 -27
@@ -3,7 +3,6 @@
3
3
  // found in the LICENSE file.
4
4
 
5
5
  import type * as Platform from '../../../core/platform/platform.js';
6
- import * as SDK from '../../../core/sdk/sdk.js';
7
6
  import type * as Protocol from '../../../generated/protocol.js';
8
7
  import * as CrUXManager from '../../crux-manager/crux-manager.js';
9
8
  import type * as SourceMapScopes from '../../source_map_scopes/source_map_scopes.js';
@@ -16,105 +15,6 @@ import {NetworkRequestFormatter, sanitizeHeaders} from './NetworkRequestFormatte
16
15
  import {PerformanceInsightFormatter} from './PerformanceInsightFormatter.js';
17
16
  import {bytes, micros, millis} from './UnitFormatters.js';
18
17
 
19
- /**
20
- * Filters response headers to the 7 standard CORS-safelisted headers for
21
- * opaque cross-origin requests.
22
- *
23
- * Note: `NetworkRequestFormatter` (`allowHeader` / `sanitizeHeaders`) applies
24
- * a second, broader allowlist to redact sensitive header values (like
25
- * `set-cookie`) even on same-origin requests, but that list permits headers
26
- * such as `location`, `link`, `content-security-policy`, and `x-forwarded-host`
27
- * that must not be exposed for cross-origin requests.
28
- */
29
- function filterToCorsSafelistedHeaders(headers: Array<{name: string, value: string}>):
30
- Array<{name: string, value: string}> {
31
- return headers.filter(
32
- header => SDK.NetworkRequestAccess.CORS_SAFELISTED_RESPONSE_HEADERS.has(header.name.toLowerCase().trim()));
33
- }
34
-
35
- /**
36
- * Evaluates whether a traced network request is same-origin with the trace's
37
- * main frame origin across its entire redirect chain.
38
- *
39
- * Trace events record raw network activity from the renderer (including full
40
- * redirect chains, final post-redirect URLs, and all response headers), even
41
- * for cross-origin requests where the browser's Same-Origin Policy would hide
42
- * those details from the page.
43
- *
44
- * Unlike live `SDK.NetworkRequest.NetworkRequest` objects evaluated via
45
- * `SDK.NetworkRequestAccess.evaluateResponseAccessMode`, traced network
46
- * requests do not record request headers/cookies (needed to determine if a
47
- * request is credentialed when evaluating `Access-Control-Allow-Origin: *`),
48
- * Fetch request mode (`cors` vs `no-cors`), `corsErrorStatus`, or intermediate
49
- * redirect response headers. Consequently, all cross-origin traced requests
50
- * are treated as opaque (restricting headers to the CORS safelist and omitting
51
- * redirect chains).
52
- */
53
- function isSameOriginTraceRequest(
54
- request: Trace.Types.Events.SyntheticNetworkRequest,
55
- parsedTrace: Trace.TraceModel.ParsedTrace,
56
- ): boolean {
57
- const traceUrl = parsedTrace.data?.Meta?.mainFrameURL;
58
- const targetUrl = request.args.data.url;
59
- if (!traceUrl || !targetUrl) {
60
- return false;
61
- }
62
- const traceOrigin = SDK.SecurityOrigin.SecurityOrigin.create(traceUrl);
63
- if (traceOrigin.isOpaque()) {
64
- return false;
65
- }
66
- const redirects = request.args.data.redirects ?? [];
67
- for (const redirect of redirects) {
68
- if (!redirect.url || !traceOrigin.isSameOriginWith(SDK.SecurityOrigin.SecurityOrigin.create(redirect.url))) {
69
- return false;
70
- }
71
- }
72
- return traceOrigin.isSameOriginWith(SDK.SecurityOrigin.SecurityOrigin.create(targetUrl));
73
- }
74
-
75
- function filteredResponseHeaders(
76
- request: Trace.Types.Events.SyntheticNetworkRequest,
77
- parsedTrace: Trace.TraceModel.ParsedTrace,
78
- ): Array<{name: string, value: string}>|null {
79
- const headers = request.args.data.responseHeaders;
80
- if (!headers) {
81
- return headers;
82
- }
83
- if (isSameOriginTraceRequest(request, parsedTrace)) {
84
- return headers;
85
- }
86
- return filterToCorsSafelistedHeaders(headers);
87
- }
88
-
89
- function filteredRedirects(
90
- request: Trace.Types.Events.SyntheticNetworkRequest,
91
- parsedTrace: Trace.TraceModel.ParsedTrace,
92
- ): Trace.Types.Events.SyntheticNetworkRedirect[] {
93
- if (isSameOriginTraceRequest(request, parsedTrace)) {
94
- return request.args.data.redirects ?? [];
95
- }
96
- return [];
97
- }
98
-
99
- /**
100
- * Returns the URL safe to expose for a traced network request.
101
- *
102
- * `request.args.data.url` is the final post-redirect URL. For cross-origin
103
- * requests that redirected, the final URL (and any intermediate redirect hops)
104
- * is hidden from the page by the Same-Origin Policy, whereas `redirects[0].url`
105
- * is the initial pre-redirect URL that the page itself requested.
106
- */
107
- function filteredUrl(
108
- request: Trace.Types.Events.SyntheticNetworkRequest,
109
- parsedTrace: Trace.TraceModel.ParsedTrace,
110
- ): string {
111
- const redirects = request.args.data.redirects ?? [];
112
- if (redirects.length === 0 || isSameOriginTraceRequest(request, parsedTrace)) {
113
- return request.args.data.url;
114
- }
115
- return redirects[0].url || '<redacted cross-origin redirect destination>';
116
- }
117
-
118
18
  export interface NetworkRequestFormatOptions {
119
19
  verbose?: boolean;
120
20
  customTitle?: string;
@@ -571,37 +471,12 @@ export class PerformanceTraceFormatter {
571
471
  // number of related events. Mostly, insights probably don't have more than
572
472
  // 5.
573
473
  const eventsString =
574
- events.slice(0, 5).map(e => this.#safeNameForEntry(e) + ' ' + this.serializeEvent(e)).join(', ');
474
+ events.slice(0, 5).map(e => Trace.Name.forEntry(e) + ' ' + this.serializeEvent(e)).join(', ');
575
475
  results.push(`- ${insightKey}: ${eventsString}`);
576
476
  }
577
477
  return results.join('\n');
578
478
  }
579
479
 
580
- /**
581
- * Returns the display name for a trace event, replacing the final
582
- * post-redirect URL on cross-origin network requests with the initial
583
- * pre-redirect URL (`filteredUrl`) before delegating to `Trace.Name.forEntry`.
584
- */
585
- #safeNameForEntry(event: Trace.Types.Events.Event): string {
586
- if (Trace.Types.Events.isSyntheticNetworkRequest(event)) {
587
- const safeUrl = filteredUrl(event, this.#parsedTrace);
588
- if (safeUrl !== event.args.data.url) {
589
- const syntheticEvent: Trace.Types.Events.SyntheticNetworkRequest = {
590
- ...event,
591
- args: {
592
- ...event.args,
593
- data: {
594
- ...event.args.data,
595
- url: safeUrl,
596
- },
597
- },
598
- };
599
- return Trace.Name.forEntry(syntheticEvent);
600
- }
601
- }
602
- return Trace.Name.forEntry(event);
603
- }
604
-
605
480
  async formatMainThreadTrackSummary(bounds: Trace.Types.Timing.TraceWindowMicro): Promise<string> {
606
481
  if (!this.#parsedTrace.insights) {
607
482
  return 'No main thread activity found';
@@ -741,10 +616,6 @@ export class PerformanceTraceFormatter {
741
616
  return result;
742
617
  }
743
618
 
744
- formatRequestUrl(request: Trace.Types.Events.SyntheticNetworkRequest): string {
745
- return filteredUrl(request, this.#parsedTrace);
746
- }
747
-
748
619
  formatNetworkRequests(
749
620
  requests: readonly Trace.Types.Events.SyntheticNetworkRequest[], options?: NetworkRequestFormatOptions): string {
750
621
  if (requests.length === 0) {
@@ -810,20 +681,22 @@ export class PerformanceTraceFormatter {
810
681
  #networkRequestVerbosely(request: Trace.Types.Events.SyntheticNetworkRequest, options?: NetworkRequestFormatOptions):
811
682
  string {
812
683
  const {
684
+ url,
813
685
  statusCode,
814
686
  initialPriority,
815
687
  priority,
816
688
  fromServiceWorker,
817
689
  mimeType,
690
+ responseHeaders,
818
691
  syntheticData,
819
692
  protocol,
820
693
  } = request.args.data;
821
694
  const parsedTrace = this.#parsedTrace;
822
- const url = filteredUrl(request, parsedTrace);
823
- const responseHeaders = filteredResponseHeaders(request, parsedTrace);
824
695
 
825
696
  const titlePrefix = `## ${options?.customTitle ?? 'Network request'}`;
826
697
 
698
+ // Note: unlike other agents, we do have the ability to include
699
+ // cross-origins, hence why we do not sanitize the URLs here.
827
700
  const navigationForEvent = Trace.Helpers.Trace.getNavigationForTraceEvent(
828
701
  request,
829
702
  request.args.data.frame,
@@ -856,7 +729,7 @@ export class PerformanceTraceFormatter {
856
729
  priorityLines.push(`Final priority: ${priority}`);
857
730
  }
858
731
 
859
- const redirects = filteredRedirects(request, parsedTrace).map((redirect, index) => {
732
+ const redirects = request.args.data.redirects.map((redirect, index) => {
860
733
  const startTime = redirect.ts - baseTime;
861
734
  return `#### Redirect ${index + 1}: ${redirect.url}
862
735
  - Start time: ${micros(startTime)}
@@ -864,7 +737,7 @@ export class PerformanceTraceFormatter {
864
737
  });
865
738
 
866
739
  const initiators = this.#getInitiatorChain(parsedTrace, request);
867
- const initiatorUrls = initiators.map(initiator => filteredUrl(initiator, parsedTrace));
740
+ const initiatorUrls = initiators.map(initiator => initiator.args.data.url);
868
741
 
869
742
  const eventKey = this.#eventsSerializer.keyForEvent(request);
870
743
  const eventKeyLine = eventKey ? `eventKey: ${eventKey}\n` : '';
@@ -878,7 +751,7 @@ ${eventKeyLine}Timings:
878
751
  Durations:
879
752
  - Download time: ${micros(downloadTime)}
880
753
  - Main thread processing time: ${micros(mainThreadProcessingDuration)}
881
- - Total duration: ${micros(request.dur)}${initiator ? `\nInitiator: ${filteredUrl(initiator, parsedTrace)}` : ''}
754
+ - Total duration: ${micros(request.dur)}${initiator ? `\nInitiator: ${initiator.args.data.url}` : ''}
882
755
  Redirects:${redirects.length ? '\n' + redirects.join('\n') : ' no redirects'}
883
756
  Status code: ${statusCode}
884
757
  MIME Type: ${mimeType}
@@ -905,8 +778,7 @@ Network requests data:
905
778
  const urlIdToIndex = new Map<string, number>();
906
779
  const allRequestsText = requests
907
780
  .map(request => {
908
- const urlIndex =
909
- this.#getOrAssignUrlIndex(urlIdToIndex, filteredUrl(request, this.#parsedTrace));
781
+ const urlIndex = this.#getOrAssignUrlIndex(urlIdToIndex, request.args.data.url);
910
782
  return this.#networkRequestCompressedFormat(urlIndex, request, urlIdToIndex);
911
783
  })
912
784
  .join('\n');
@@ -997,11 +869,11 @@ The order of headers corresponds to an internal fixed list. If a header is not p
997
869
  priority,
998
870
  fromServiceWorker,
999
871
  mimeType,
872
+ responseHeaders,
1000
873
  syntheticData,
1001
874
  protocol,
1002
875
  } = request.args.data;
1003
876
  const parsedTrace = this.#parsedTrace;
1004
- const responseHeaders = filteredResponseHeaders(request, parsedTrace);
1005
877
 
1006
878
  const navigationForEvent = Trace.Helpers.Trace.getNavigationForTraceEvent(
1007
879
  request,
@@ -1025,7 +897,7 @@ The order of headers corresponds to an internal fixed list. If a header is not p
1025
897
  return `${header.name}: ${value}`;
1026
898
  })
1027
899
  .join('|');
1028
- const redirects = filteredRedirects(request, parsedTrace)
900
+ const redirects = request.args.data.redirects
1029
901
  .map(redirect => {
1030
902
  const urlIndex = this.#getOrAssignUrlIndex(urlIdToIndex, redirect.url);
1031
903
  const redirectStartTime = micros(redirect.ts - baseTime);
@@ -1036,7 +908,7 @@ The order of headers corresponds to an internal fixed list. If a header is not p
1036
908
 
1037
909
  const initiators = this.#getInitiatorChain(parsedTrace, request);
1038
910
  const initiatorUrlIndices =
1039
- initiators.map(initiator => this.#getOrAssignUrlIndex(urlIdToIndex, filteredUrl(initiator, parsedTrace)));
911
+ initiators.map(initiator => this.#getOrAssignUrlIndex(urlIdToIndex, initiator.args.data.url));
1040
912
 
1041
913
  const parts = [
1042
914
  urlIndex,
@@ -1167,93 +1039,33 @@ The order of headers corresponds to an internal fixed list. If a header is not p
1167
1039
  }
1168
1040
  }
1169
1041
 
1170
- function sanitizeSyntheticNetworkRequestEvent(
1171
- event: Trace.Types.Events.SyntheticNetworkRequest,
1172
- parsedTrace: Trace.TraceModel.ParsedTrace,
1173
- ): Trace.Types.Events.SyntheticNetworkRequest {
1174
- const safeUrl = filteredUrl(event, parsedTrace);
1175
- const headers = filteredResponseHeaders(event, parsedTrace);
1176
- const sanitizedEvent: Trace.Types.Events.SyntheticNetworkRequest = {
1177
- ...event,
1178
- args: {
1179
- ...event.args,
1180
- data: {
1181
- ...event.args.data,
1182
- url: safeUrl,
1183
- redirects: filteredRedirects(event, parsedTrace),
1184
- responseHeaders: headers ? sanitizeHeaders(headers) : null,
1185
- },
1186
- },
1187
- };
1188
- if (event.rawSourceEvent?.args?.data) {
1189
- sanitizedEvent.rawSourceEvent = {
1190
- ...event.rawSourceEvent,
1191
- args: {
1192
- ...event.rawSourceEvent.args,
1193
- data: {
1194
- ...event.rawSourceEvent.args.data,
1195
- url: safeUrl,
1196
- },
1197
- },
1198
- };
1199
- }
1200
- return sanitizedEvent;
1201
- }
1202
-
1203
1042
  /**
1204
1043
  * Serializes a trace event to a JSON string for AI consumption,
1205
1044
  * ensuring sensitive data (like headers and raw script source code)
1206
1045
  * is sanitized or redacted.
1207
1046
  */
1208
- export function formatEventForAI(
1209
- event: Trace.Types.Events.Event,
1210
- parsedTrace: Trace.TraceModel.ParsedTrace,
1211
- ): string {
1047
+ export function formatEventForAI(event: Trace.Types.Events.Event): string {
1212
1048
  if (Trace.Types.Events.isSyntheticNetworkRequest(event)) {
1213
- return JSON.stringify(sanitizeSyntheticNetworkRequestEvent(event, parsedTrace));
1214
- }
1215
-
1216
- if (Trace.Types.Events.isResourceSendRequest(event)) {
1217
- const syntheticRequest =
1218
- parsedTrace.data?.NetworkRequests?.byTime?.find(r => r.args.data.requestId === event.args.data.requestId);
1219
- let safeUrl = '<redacted cross-origin redirect destination>';
1220
- if (syntheticRequest) {
1221
- safeUrl = isSameOriginTraceRequest(syntheticRequest, parsedTrace) ? event.args.data.url :
1222
- filteredUrl(syntheticRequest, parsedTrace);
1223
- } else {
1224
- const traceUrl = parsedTrace.data?.Meta?.mainFrameURL;
1225
- const traceOrigin = traceUrl ? SDK.SecurityOrigin.SecurityOrigin.create(traceUrl) : null;
1226
- if (traceOrigin && !traceOrigin.isOpaque() &&
1227
- traceOrigin.isSameOriginWith(SDK.SecurityOrigin.SecurityOrigin.create(event.args.data.url))) {
1228
- safeUrl = event.args.data.url;
1229
- }
1230
- }
1231
1049
  return JSON.stringify({
1232
1050
  ...event,
1233
1051
  args: {
1234
1052
  ...event.args,
1235
1053
  data: {
1236
1054
  ...event.args.data,
1237
- url: safeUrl,
1055
+ responseHeaders: event.args.data.responseHeaders ? sanitizeHeaders(event.args.data.responseHeaders) : null,
1238
1056
  },
1239
1057
  },
1240
1058
  });
1241
1059
  }
1242
1060
 
1243
1061
  if (Trace.Types.Events.isResourceReceiveResponse(event)) {
1244
- const syntheticRequest =
1245
- parsedTrace.data?.NetworkRequests?.byTime?.find(r => r.args.data.requestId === event.args.data.requestId);
1246
- const isSameOrigin = Boolean(syntheticRequest && isSameOriginTraceRequest(syntheticRequest, parsedTrace));
1247
- const filteredHeaders = event.args.data.headers ?
1248
- (isSameOrigin ? event.args.data.headers : filterToCorsSafelistedHeaders(event.args.data.headers)) :
1249
- undefined;
1250
1062
  return JSON.stringify({
1251
1063
  ...event,
1252
1064
  args: {
1253
1065
  ...event.args,
1254
1066
  data: {
1255
1067
  ...event.args.data,
1256
- headers: filteredHeaders ? sanitizeHeaders(filteredHeaders) : undefined,
1068
+ headers: event.args.data.headers ? sanitizeHeaders(event.args.data.headers) : undefined,
1257
1069
  },
1258
1070
  },
1259
1071
  });
@@ -95,7 +95,12 @@ export const freestylerBinding: string = `(${String(freestylerBindingFunc)})('${
95
95
  export const PAGE_EXPOSED_FUNCTIONS: string[] = ['setElementStyles'];
96
96
 
97
97
  /**
98
- * Please see fileoverview
98
+ * Please see fileoverview.
99
+ *
100
+ * `SetElementStylesTool` (`tools/SetElementStyles.ts`) is the V2 SDK-based
101
+ * equivalent of this page-injected `setElementStyles` function and is designed
102
+ * to be behaviorally identical. Any functional changes here must stay in sync
103
+ * with `SetElementStylesTool` until V1 is removed (b/581814240).
99
104
  */
100
105
  const setupSetElementStyles = `function setupSetElementStyles(prefix) {
101
106
  const global = globalThis;
@@ -25,7 +25,7 @@ Your role is to evaluate websites using Lighthouse audits across performance, ac
25
25
  - Only pass `categoryId: 'agentic-browsing'` when the user explicitly asks for an agentic browsing audit, such as how ready the page is for AI agents to navigate and use it, or WebMCP checks. `'all'` does not include it, so never pick it for general audits, and never substitute another category (such as `'seo'`) when the user asks for it. Use `"navigation"` mode for `'agentic-browsing'` unless the user explicitly asks for another mode, because its WebMCP audits only run in `"navigation"` mode.
26
26
  - Execution mode:
27
27
  - Use `"navigation"` mode for full page-load audits (default for full site reviews).
28
- - Use `"snapshot"` mode to re-evaluate live in-page DOM/CSS modifications without reloading.
28
+ - Use `"snapshot"` mode (and recommend Snapshot mode rather than "Analyze page load" if instructing the user) to re-evaluate live in-page DOM/CSS modifications, because `"navigation"` mode reloads the page and wipes out temporary live changes.
29
29
  - Use `"timespan"` mode for user interaction flows.
30
30
  - Always honor explicit mode requests from the user.
31
31
  - **CRITICAL**: `runLighthouse` only records the report and returns `"Lighthouse audit completed"` without audit details. Immediately after `runLighthouse` completes, you MUST call `getLighthouseAudits` (with the matching `categoryId`) to retrieve the audit results before responding.
@@ -4,6 +4,7 @@ description: CSS, styling, layouts, positioning, computed styles, DOM tree struc
4
4
  allowed-tools:
5
5
  - executeJavaScript
6
6
  - getStyles
7
+ - setElementStyles
7
8
  ---
8
9
  You are an expert CSS, styling, and layout debugging assistant.
9
10
  The user selected a DOM element in DevTools and asks a query about the element or page styles.
@@ -15,8 +16,13 @@ The user selected a DOM element in DevTools and asks a query about the element o
15
16
  - You MUST provide a specific list of CSS property names (e.g. `['display', 'position', 'flex-direction', 'z-index']`). Do not use generic values like "all" or "*".
16
17
  - Always consider the CSS cascade, inheritance, and stacking contexts.
17
18
 
18
- 2. **Inspect Geometry, DOM Traversal, or Modify Styles (`executeJavaScript`)**:
19
- - Use `executeJavaScript` when you need to inspect computed geometry, bounding boxes, traverse related DOM nodes (`$0.parentElement`, `$0.children`), or modify styles on `$0`.
19
+ 2. **Modify Element Styles (`setElementStyles`)**:
20
+ - ALWAYS use the `setElementStyles` tool (and NEVER `executeJavaScript`) when modifying or fixing CSS styles on elements.
21
+ - `setElementStyles` takes `elements` (an array of numeric element `uid`s / backend node IDs, such as the selected element's `uid` or `uid`s discovered earlier) and `styleProperties` (an array of `{name, value}` CSS declaration objects in kebab-case, e.g. `[{name: 'display', value: 'flex'}, {name: 'justify-content', value: 'center'}]`).
22
+ - `setElementStyles` is an internal tool name; do not mention `setElementStyles` directly to the user.
23
+
24
+ 3. **Inspect Geometry or Traverse DOM (`executeJavaScript`)**:
25
+ - Use `executeJavaScript` ONLY when inspecting computed geometry (`getBoundingClientRect()`), traversing related DOM nodes (`$0.parentElement`, `$0.children`) to inspect their structure/attributes, or reading page state that `getStyles` cannot provide.
20
26
  - Geometry & layout inspection example:
21
27
  ```javascript
22
28
  const rect = $0.getBoundingClientRect();
@@ -28,14 +34,6 @@ The user selected a DOM element in DevTools and asks a query about the element o
28
34
  parentDisplay: parentStyle?.display ?? null,
29
35
  };
30
36
  ```
31
- - Style modification example (ALWAYS use `setElementStyles`):
32
- ```javascript
33
- await setElementStyles($0, {
34
- display: 'flex',
35
- justifyContent: 'center',
36
- });
37
- ```
38
- - `setElementStyles` is an internal mechanism for you; do not mention `setElementStyles` directly to the user.
39
37
 
40
38
  # Considerations
41
39
 
@@ -71,7 +71,7 @@ export class GetTraceEventByKeyTool implements
71
71
  return {error: `Could not find event with key "${params.eventKey}".`};
72
72
  }
73
73
 
74
- const details = formatEventForAI(event, focus.parsedTrace);
74
+ const details = formatEventForAI(event);
75
75
  return {
76
76
  result: details,
77
77
  widgets: [{