botframework-webchat-api 4.14.1 → 4.15.2-main.20220413.af6e8a3

package/src/utils/findLastIndex.spec.js

@@ -0,0 +1,31 @@
+/* eslint no-magic-numbers: "off" */
+
+import findLastIndex from './findLastIndex';
+
+describe('find last index', () => {
+  test('of an existing element should return the index of last occurrence', () => {
+    const actual = findLastIndex([1, 2, 3, 2, 1], value => value === 2);
+
+    expect(actual).toBe(3);
+  });
+
+  test('of a non-existing element should return -1', () => {
+    const actual = findLastIndex([1, 2, 3, 2, 1], value => value === 4);
+
+    expect(actual).toBe(-1);
+  });
+
+  test('of an empty array should return -1', () => {
+    const actual = findLastIndex([], value => value === 1);
+
+    expect(actual).toBe(-1);
+  });
+
+  test('without a predicate should throw', () => {
+    expect(() => findLastIndex([])).toThrowError('not a function');
+  });
+
+  test('without an array should throw', () => {
+    expect(() => findLastIndex(undefined, value => value === 1)).toThrowError();
+  });
+});

package/src/utils/findLastIndex.ts

@@ -0,0 +1,11 @@
+export default function findLastIndex<T>(array: readonly T[], predicate: (value: T, index: number) => boolean): number {
+  const index = [...array].reverse().findIndex(predicate);
+
+  if (~index) {
+    const { length } = array || [];
+
+    return length - index - 1;
+  }
+
+  return index;
+}

package/src/utils/mapMap.ts

@@ -1,9 +1,15 @@
+import { isForbiddenPropertyName } from 'botframework-webchat-core';
+
 export default function mapMap<T>(
   map: { [key: string]: T },
   mapper: (value: T, key: string) => T
 ): { [key: string]: T } {
   return Object.entries(map).reduce((result, [key, value]) => {
-    result[key] = mapper(value, key);
+    if (!isForbiddenPropertyName(key)) {
+      // Mitigation through denylisting.
+      // eslint-disable-next-line security/detect-object-injection
+      result[key] = mapper(value, key);
+    }
 
     return result;
   }, {});

package/src/utils/randomId.ts

@@ -2,6 +2,6 @@
 
 import random from 'math-random';
 
-export default function randomId(maxLength: number = 5): string {
+export default function randomId(maxLength = 5): string {
   return random().toString(36).substr(2, maxLength);
 }

package/.eslintignore

@@ -1 +0,0 @@
-/src/tsconfig.json