aw-ecc 1.4.21

package/scripts/ci/validate-install-manifests.js

@@ -0,0 +1,214 @@
+#!/usr/bin/env node
+/**
+ * Validate selective-install manifests and profile/module relationships.
+ * Module paths are curated repo paths only. Generated/imported skill roots
+ * (~/.claude/skills/learned, etc.) are never in manifests.
+ */
+
+const fs = require('fs');
+const path = require('path');
+const Ajv = require('ajv');
+
+const REPO_ROOT = path.join(__dirname, '../..');
+const MODULES_MANIFEST_PATH = path.join(REPO_ROOT, 'manifests/install-modules.json');
+const PROFILES_MANIFEST_PATH = path.join(REPO_ROOT, 'manifests/install-profiles.json');
+const COMPONENTS_MANIFEST_PATH = path.join(REPO_ROOT, 'manifests/install-components.json');
+const MODULES_SCHEMA_PATH = path.join(REPO_ROOT, 'schemas/install-modules.schema.json');
+const PROFILES_SCHEMA_PATH = path.join(REPO_ROOT, 'schemas/install-profiles.schema.json');
+const COMPONENTS_SCHEMA_PATH = path.join(REPO_ROOT, 'schemas/install-components.schema.json');
+const COMPONENT_FAMILY_PREFIXES = {
+  baseline: 'baseline:',
+  language: 'lang:',
+  framework: 'framework:',
+  capability: 'capability:',
+};
+
+function readJson(filePath, label) {
+  try {
+    return JSON.parse(fs.readFileSync(filePath, 'utf8'));
+  } catch (error) {
+    throw new Error(`Invalid JSON in ${label}: ${error.message}`);
+  }
+}
+
+function normalizeRelativePath(relativePath) {
+  return String(relativePath).replace(/\\/g, '/').replace(/\/+$/, '');
+}
+
+function validateSchema(ajv, schemaPath, data, label) {
+  const schema = readJson(schemaPath, `${label} schema`);
+  const validate = ajv.compile(schema);
+  const valid = validate(data);
+
+  if (!valid) {
+    for (const error of validate.errors) {
+      console.error(
+        `ERROR: ${label} schema: ${error.instancePath || '/'} ${error.message}`
+      );
+    }
+    return true;
+  }
+
+  return false;
+}
+
+function validateInstallManifests() {
+  if (!fs.existsSync(MODULES_MANIFEST_PATH) || !fs.existsSync(PROFILES_MANIFEST_PATH)) {
+    console.log('Install manifests not found, skipping validation');
+    process.exit(0);
+  }
+
+  let hasErrors = false;
+  let modulesData;
+  let profilesData;
+  let componentsData = { version: null, components: [] };
+
+  try {
+    modulesData = readJson(MODULES_MANIFEST_PATH, 'install-modules.json');
+    profilesData = readJson(PROFILES_MANIFEST_PATH, 'install-profiles.json');
+    if (fs.existsSync(COMPONENTS_MANIFEST_PATH)) {
+      componentsData = readJson(COMPONENTS_MANIFEST_PATH, 'install-components.json');
+    }
+  } catch (error) {
+    console.error(`ERROR: ${error.message}`);
+    process.exit(1);
+  }
+
+  const ajv = new Ajv({ allErrors: true });
+  hasErrors = validateSchema(ajv, MODULES_SCHEMA_PATH, modulesData, 'install-modules.json') || hasErrors;
+  hasErrors = validateSchema(ajv, PROFILES_SCHEMA_PATH, profilesData, 'install-profiles.json') || hasErrors;
+  if (fs.existsSync(COMPONENTS_MANIFEST_PATH)) {
+    hasErrors = validateSchema(ajv, COMPONENTS_SCHEMA_PATH, componentsData, 'install-components.json') || hasErrors;
+  }
+
+  if (hasErrors) {
+    process.exit(1);
+  }
+
+  const modules = Array.isArray(modulesData.modules) ? modulesData.modules : [];
+  const moduleIds = new Set();
+  const claimedPaths = new Map();
+
+  for (const module of modules) {
+    if (moduleIds.has(module.id)) {
+      console.error(`ERROR: Duplicate install module id: ${module.id}`);
+      hasErrors = true;
+    }
+    moduleIds.add(module.id);
+
+    for (const dependency of module.dependencies) {
+      if (!moduleIds.has(dependency) && !modules.some(candidate => candidate.id === dependency)) {
+        console.error(`ERROR: Module ${module.id} depends on unknown module ${dependency}`);
+        hasErrors = true;
+      }
+      if (dependency === module.id) {
+        console.error(`ERROR: Module ${module.id} cannot depend on itself`);
+        hasErrors = true;
+      }
+    }
+
+    for (const relativePath of module.paths) {
+      const normalizedPath = normalizeRelativePath(relativePath);
+      const absolutePath = path.join(REPO_ROOT, normalizedPath);
+
+      // All module paths must exist; no optional/generated paths in manifests
+      if (!fs.existsSync(absolutePath)) {
+        console.error(
+          `ERROR: Module ${module.id} references missing path: ${normalizedPath}`
+        );
+        hasErrors = true;
+      }
+
+      if (claimedPaths.has(normalizedPath)) {
+        console.error(
+          `ERROR: Install path ${normalizedPath} is claimed by both ${claimedPaths.get(normalizedPath)} and ${module.id}`
+        );
+        hasErrors = true;
+      } else {
+        claimedPaths.set(normalizedPath, module.id);
+      }
+    }
+  }
+
+  const profiles = profilesData.profiles || {};
+  const components = Array.isArray(componentsData.components) ? componentsData.components : [];
+  const expectedProfileIds = ['core', 'developer', 'security', 'research', 'full'];
+
+  for (const profileId of expectedProfileIds) {
+    if (!profiles[profileId]) {
+      console.error(`ERROR: Missing required install profile: ${profileId}`);
+      hasErrors = true;
+    }
+  }
+
+  for (const [profileId, profile] of Object.entries(profiles)) {
+    const seenModules = new Set();
+    for (const moduleId of profile.modules) {
+      if (!moduleIds.has(moduleId)) {
+        console.error(
+          `ERROR: Profile ${profileId} references unknown module ${moduleId}`
+        );
+        hasErrors = true;
+      }
+
+      if (seenModules.has(moduleId)) {
+        console.error(
+          `ERROR: Profile ${profileId} contains duplicate module ${moduleId}`
+        );
+        hasErrors = true;
+      }
+      seenModules.add(moduleId);
+    }
+  }
+
+  if (profiles.full) {
+    const fullModules = new Set(profiles.full.modules);
+    for (const moduleId of moduleIds) {
+      if (!fullModules.has(moduleId)) {
+        console.error(`ERROR: full profile is missing module ${moduleId}`);
+        hasErrors = true;
+      }
+    }
+  }
+
+  const componentIds = new Set();
+  for (const component of components) {
+    if (componentIds.has(component.id)) {
+      console.error(`ERROR: Duplicate install component id: ${component.id}`);
+      hasErrors = true;
+    }
+    componentIds.add(component.id);
+
+    const expectedPrefix = COMPONENT_FAMILY_PREFIXES[component.family];
+    if (expectedPrefix && !component.id.startsWith(expectedPrefix)) {
+      console.error(
+        `ERROR: Component ${component.id} does not match expected ${component.family} prefix ${expectedPrefix}`
+      );
+      hasErrors = true;
+    }
+
+    const seenModules = new Set();
+    for (const moduleId of component.modules) {
+      if (!moduleIds.has(moduleId)) {
+        console.error(`ERROR: Component ${component.id} references unknown module ${moduleId}`);
+        hasErrors = true;
+      }
+
+      if (seenModules.has(moduleId)) {
+        console.error(`ERROR: Component ${component.id} contains duplicate module ${moduleId}`);
+        hasErrors = true;
+      }
+      seenModules.add(moduleId);
+    }
+  }
+
+  if (hasErrors) {
+    process.exit(1);
+  }
+
+  console.log(
+    `Validated ${modules.length} install modules, ${components.length} install components, and ${Object.keys(profiles).length} profiles`
+  );
+}
+
+validateInstallManifests();

package/scripts/ci/validate-no-personal-paths.js

@@ -0,0 +1,63 @@
+#!/usr/bin/env node
+/**
+ * Prevent shipping user-specific absolute paths in public docs/skills/commands.
+ */
+
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+
+const ROOT = path.join(__dirname, '../..');
+const TARGETS = [
+  'README.md',
+  'skills',
+  'commands',
+  'agents',
+  'docs',
+  '.opencode/commands',
+];
+
+const BLOCK_PATTERNS = [
+  /\/Users\/affoon\b/g,
+  /C:\\Users\\affoon\b/gi,
+];
+
+function collectFiles(targetPath, out) {
+  if (!fs.existsSync(targetPath)) return;
+  const stat = fs.statSync(targetPath);
+  if (stat.isFile()) {
+    out.push(targetPath);
+    return;
+  }
+
+  for (const entry of fs.readdirSync(targetPath)) {
+    if (entry === 'node_modules' || entry === '.git') continue;
+    collectFiles(path.join(targetPath, entry), out);
+  }
+}
+
+const files = [];
+for (const target of TARGETS) {
+  collectFiles(path.join(ROOT, target), files);
+}
+
+let failures = 0;
+for (const file of files) {
+  if (!/\.(md|json|js|ts|sh|toml|yml|yaml)$/i.test(file)) continue;
+  const content = fs.readFileSync(file, 'utf8');
+  for (const pattern of BLOCK_PATTERNS) {
+    const match = content.match(pattern);
+    if (match) {
+      console.error(`ERROR: personal path detected in ${path.relative(ROOT, file)}`);
+      failures += match.length;
+      break;
+    }
+  }
+}
+
+if (failures > 0) {
+  process.exit(1);
+}
+
+console.log('Validated: no personal absolute paths in shipped docs/skills/commands');

package/scripts/ci/validate-rules.js

@@ -0,0 +1,81 @@
+#!/usr/bin/env node
+/**
+ * Validate rule markdown files
+ */
+
+const fs = require('fs');
+const path = require('path');
+
+const RULES_DIR = path.join(__dirname, '../../rules');
+
+/**
+ * Recursively collect markdown rule files.
+ * Uses explicit traversal for portability across Node versions.
+ * @param {string} dir - Directory to scan
+ * @returns {string[]} Relative file paths from RULES_DIR
+ */
+function collectRuleFiles(dir) {
+  const files = [];
+
+  let entries;
+  try {
+    entries = fs.readdirSync(dir, { withFileTypes: true });
+  } catch {
+    return files;
+  }
+
+  for (const entry of entries) {
+    const absolute = path.join(dir, entry.name);
+
+    if (entry.isDirectory()) {
+      files.push(...collectRuleFiles(absolute));
+      continue;
+    }
+
+    if (entry.name.endsWith('.md')) {
+      files.push(path.relative(RULES_DIR, absolute));
+    }
+
+    // Non-markdown files are ignored.
+  }
+
+  return files;
+}
+
+function validateRules() {
+  if (!fs.existsSync(RULES_DIR)) {
+    console.log('No rules directory found, skipping validation');
+    process.exit(0);
+  }
+
+  const files = collectRuleFiles(RULES_DIR);
+  let hasErrors = false;
+  let validatedCount = 0;
+
+  for (const file of files) {
+    const filePath = path.join(RULES_DIR, file);
+    try {
+      const stat = fs.statSync(filePath);
+      if (!stat.isFile()) continue;
+
+      const content = fs.readFileSync(filePath, 'utf-8');
+      if (content.trim().length === 0) {
+        console.error(`ERROR: ${file} - Empty rule file`);
+        hasErrors = true;
+        continue;
+      }
+      validatedCount++;
+    } catch (err) {
+      console.error(`ERROR: ${file} - ${err.message}`);
+      hasErrors = true;
+    }
+  }
+
+  if (hasErrors) {
+    process.exit(1);
+  }
+
+  console.log(`Validated ${validatedCount} rule files`);
+}
+
+validateRules();

package/scripts/ci/validate-skills.js

@@ -0,0 +1,56 @@
+#!/usr/bin/env node
+/**
+ * Validate curated skill directories (skills/ in repo).
+ * Scope: curated only. Learned/imported/evolved roots are out of scope.
+ * If skills/ does not exist, exit 0 (no curated skills to validate).
+ */
+
+const fs = require('fs');
+const path = require('path');
+
+const SKILLS_DIR = path.join(__dirname, '../../skills');
+
+function validateSkills() {
+  if (!fs.existsSync(SKILLS_DIR)) {
+    console.log('No curated skills directory (skills/), skipping');
+    process.exit(0);
+  }
+
+  const entries = fs.readdirSync(SKILLS_DIR, { withFileTypes: true });
+  const dirs = entries.filter(e => e.isDirectory()).map(e => e.name);
+  let hasErrors = false;
+  let validCount = 0;
+
+  for (const dir of dirs) {
+    const skillMd = path.join(SKILLS_DIR, dir, 'SKILL.md');
+    if (!fs.existsSync(skillMd)) {
+      console.error(`ERROR: ${dir}/ - Missing SKILL.md`);
+      hasErrors = true;
+      continue;
+    }
+
+    let content;
+    try {
+      content = fs.readFileSync(skillMd, 'utf-8');
+    } catch (err) {
+      console.error(`ERROR: ${dir}/SKILL.md - ${err.message}`);
+      hasErrors = true;
+      continue;
+    }
+    if (content.trim().length === 0) {
+      console.error(`ERROR: ${dir}/SKILL.md - Empty file`);
+      hasErrors = true;
+      continue;
+    }
+
+    validCount++;
+  }
+
+  if (hasErrors) {
+    process.exit(1);
+  }
+
+  console.log(`Validated ${validCount} skill directories`);
+}
+
+validateSkills();