aigroup-workflow 2.1.2 → 2.2.1

package/skills/laravel-specialist/references/testing.md

@@ -1,522 +0,0 @@
-# Testing
-
-## Feature Tests
-
-```php
-namespace Tests\Feature;
-
-use Tests\TestCase;
-use App\Models\{User, Post};
-use Illuminate\Foundation\Testing\RefreshDatabase;
-
-class PostTest extends TestCase
-{
-    use RefreshDatabase;
-
-    public function test_user_can_create_post(): void
-    {
-        $user = User::factory()->create();
-
-        $response = $this->actingAs($user)->post('/api/posts', [
-            'title' => 'Test Post',
-            'content' => 'This is a test post content.',
-        ]);
-
-        $response->assertStatus(201)
-            ->assertJson([
-                'data' => [
-                    'title' => 'Test Post',
-                ],
-            ]);
-
-        $this->assertDatabaseHas('posts', [
-            'title' => 'Test Post',
-            'user_id' => $user->id,
-        ]);
-    }
-
-    public function test_guest_cannot_create_post(): void
-    {
-        $response = $this->post('/api/posts', [
-            'title' => 'Test Post',
-            'content' => 'Content',
-        ]);
-
-        $response->assertStatus(401);
-    }
-
-    public function test_post_requires_valid_data(): void
-    {
-        $user = User::factory()->create();
-
-        $response = $this->actingAs($user)->post('/api/posts', [
-            'title' => 'AB', // Too short
-        ]);
-
-        $response->assertStatus(422)
-            ->assertJsonValidationErrors(['title', 'content']);
-    }
-
-    public function test_user_can_view_their_posts(): void
-    {
-        $user = User::factory()->create();
-        $posts = Post::factory()->count(3)->create(['user_id' => $user->id]);
-
-        $response = $this->actingAs($user)->get('/api/posts');
-
-        $response->assertStatus(200)
-            ->assertJsonCount(3, 'data')
-            ->assertJsonStructure([
-                'data' => [
-                    '*' => ['id', 'title', 'content', 'created_at'],
-                ],
-            ]);
-    }
-
-    public function test_user_can_update_own_post(): void
-    {
-        $user = User::factory()->create();
-        $post = Post::factory()->create(['user_id' => $user->id]);
-
-        $response = $this->actingAs($user)->put("/api/posts/{$post->id}", [
-            'title' => 'Updated Title',
-            'content' => $post->content,
-        ]);
-
-        $response->assertStatus(200);
-
-        $this->assertDatabaseHas('posts', [
-            'id' => $post->id,
-            'title' => 'Updated Title',
-        ]);
-    }
-
-    public function test_user_cannot_update_others_post(): void
-    {
-        $user = User::factory()->create();
-        $otherUser = User::factory()->create();
-        $post = Post::factory()->create(['user_id' => $otherUser->id]);
-
-        $response = $this->actingAs($user)->put("/api/posts/{$post->id}", [
-            'title' => 'Updated Title',
-        ]);
-
-        $response->assertStatus(403);
-    }
-}
-```
-
-## Unit Tests
-
-```php
-namespace Tests\Unit;
-
-use Tests\TestCase;
-use App\Models\Post;
-use App\Services\PostService;
-use Illuminate\Foundation\Testing\RefreshDatabase;
-
-class PostServiceTest extends TestCase
-{
-    use RefreshDatabase;
-
-    public function test_generates_unique_slug(): void
-    {
-        $service = new PostService();
-
-        $slug = $service->generateSlug('Test Post');
-
-        $this->assertEquals('test-post', $slug);
-    }
-
-    public function test_increments_slug_on_duplicate(): void
-    {
-        Post::factory()->create(['slug' => 'test-post']);
-
-        $service = new PostService();
-        $slug = $service->generateSlug('Test Post');
-
-        $this->assertEquals('test-post-1', $slug);
-    }
-
-    public function test_post_excerpt_returns_limited_content(): void
-    {
-        $post = new Post(['content' => str_repeat('a', 200)]);
-
-        $excerpt = $post->excerpt;
-
-        $this->assertLessThanOrEqual(100, strlen($excerpt));
-    }
-}
-```
-
-## Pest PHP
-
-```php
-<?php
-
-use App\Models\{User, Post};
-
-it('allows authenticated users to create posts', function () {
-    $user = User::factory()->create();
-
-    $this->actingAs($user)
-        ->post('/api/posts', [
-            'title' => 'Test Post',
-            'content' => 'Content',
-        ])
-        ->assertStatus(201);
-
-    expect(Post::count())->toBe(1);
-});
-
-it('prevents guests from creating posts', function () {
-    $this->post('/api/posts', [
-        'title' => 'Test Post',
-        'content' => 'Content',
-    ])->assertStatus(401);
-});
-
-test('post requires title and content', function () {
-    $user = User::factory()->create();
-
-    $this->actingAs($user)
-        ->post('/api/posts', [])
-        ->assertJsonValidationErrors(['title', 'content']);
-});
-
-// Datasets
-it('validates title length', function (string $title, bool $shouldPass) {
-    $user = User::factory()->create();
-
-    $response = $this->actingAs($user)->post('/api/posts', [
-        'title' => $title,
-        'content' => 'Content',
-    ]);
-
-    if ($shouldPass) {
-        $response->assertStatus(201);
-    } else {
-        $response->assertJsonValidationErrors(['title']);
-    }
-})->with([
-    ['AB', false],        // Too short
-    ['ABC', true],        // Minimum valid
-    [str_repeat('A', 255), true],  // Maximum valid
-    [str_repeat('A', 256), false], // Too long
-]);
-
-// Hooks
-beforeEach(function () {
-    $this->user = User::factory()->create();
-});
-
-afterEach(function () {
-    // Cleanup
-});
-```
-
-## Factories
-
-```php
-namespace Database\Factories;
-
-use App\Models\{User, Category};
-use Illuminate\Database\Eloquent\Factories\Factory;
-
-class PostFactory extends Factory
-{
-    public function definition(): array
-    {
-        return [
-            'title' => fake()->sentence(),
-            'slug' => fake()->slug(),
-            'content' => fake()->paragraphs(3, true),
-            'excerpt' => fake()->text(100),
-            'published_at' => fake()->dateTimeBetween('-1 year', 'now'),
-            'user_id' => User::factory(),
-            'category_id' => Category::factory(),
-        ];
-    }
-
-    public function unpublished(): static
-    {
-        return $this->state(fn (array $attributes) => [
-            'published_at' => null,
-        ]);
-    }
-
-    public function published(): static
-    {
-        return $this->state(fn (array $attributes) => [
-            'published_at' => now(),
-        ]);
-    }
-
-    public function forUser(User $user): static
-    {
-        return $this->state(fn (array $attributes) => [
-            'user_id' => $user->id,
-        ]);
-    }
-
-    public function configure(): static
-    {
-        return $this->afterCreating(function (Post $post) {
-            $post->tags()->attach(
-                Tag::factory()->count(3)->create()
-            );
-        });
-    }
-}
-
-// Usage
-$post = Post::factory()->create();
-$unpublished = Post::factory()->unpublished()->create();
-$posts = Post::factory()->count(10)->create();
-$userPosts = Post::factory()->forUser($user)->count(5)->create();
-
-// With relationships
-$post = Post::factory()
-    ->has(Comment::factory()->count(3))
-    ->create();
-
-// For relationship
-$posts = Post::factory()
-    ->count(3)
-    ->for($user)
-    ->create();
-```
-
-## Mocking
-
-```php
-use App\Services\ExternalApiService;
-use Illuminate\Support\Facades\Http;
-
-public function test_fetches_data_from_external_api(): void
-{
-    Http::fake([
-        'api.example.com/*' => Http::response([
-            'data' => ['id' => 1, 'name' => 'Test'],
-        ], 200),
-    ]);
-
-    $service = new ExternalApiService();
-    $result = $service->fetchData();
-
-    $this->assertEquals('Test', $result['name']);
-
-    Http::assertSent(function ($request) {
-        return $request->url() === 'https://api.example.com/data' &&
-               $request->hasHeader('Authorization');
-    });
-}
-
-// Mock events
-use Illuminate\Support\Facades\Event;
-
-Event::fake([PostCreated::class]);
-
-// Test code that dispatches events
-
-Event::assertDispatched(PostCreated::class, function ($event) {
-    return $event->post->id === 1;
-});
-
-// Mock queues
-use Illuminate\Support\Facades\Queue;
-
-Queue::fake();
-
-// Test code that dispatches jobs
-
-Queue::assertPushed(ProcessPost::class);
-Queue::assertPushed(ProcessPost::class, 2);
-Queue::assertPushed(ProcessPost::class, function ($job) {
-    return $job->post->id === 1;
-});
-
-// Mock notifications
-use Illuminate\Support\Facades\Notification;
-
-Notification::fake();
-
-// Test code that sends notifications
-
-Notification::assertSentTo($user, PostPublished::class);
-
-// Mock storage
-use Illuminate\Support\Facades\Storage;
-
-Storage::fake('public');
-
-// Test file upload
-
-Storage::disk('public')->assertExists('file.jpg');
-Storage::disk('public')->assertMissing('missing.jpg');
-```
-
-## Database Testing
-
-```php
-use Illuminate\Foundation\Testing\RefreshDatabase;
-use Illuminate\Foundation\Testing\DatabaseTransactions;
-
-class PostTest extends TestCase
-{
-    use RefreshDatabase; // Migrate database before each test
-
-    // Or use transactions
-    use DatabaseTransactions; // Rollback after each test
-
-    public function test_database_assertions(): void
-    {
-        $post = Post::factory()->create([
-            'title' => 'Test Post',
-        ]);
-
-        $this->assertDatabaseHas('posts', [
-            'title' => 'Test Post',
-        ]);
-
-        $post->delete();
-
-        $this->assertDatabaseMissing('posts', [
-            'id' => $post->id,
-        ]);
-
-        $this->assertSoftDeleted('posts', [
-            'id' => $post->id,
-        ]);
-    }
-
-    public function test_model_exists(): void
-    {
-        $post = Post::factory()->create();
-
-        $this->assertModelExists($post);
-
-        $post->delete();
-
-        $this->assertModelMissing($post);
-    }
-}
-```
-
-## API Testing
-
-```php
-public function test_api_returns_paginated_posts(): void
-{
-    Post::factory()->count(30)->create();
-
-    $response = $this->get('/api/posts');
-
-    $response->assertStatus(200)
-        ->assertJsonStructure([
-            'data' => [
-                '*' => ['id', 'title', 'content'],
-            ],
-            'meta' => ['total', 'current_page', 'last_page'],
-            'links' => ['first', 'last', 'prev', 'next'],
-        ])
-        ->assertJsonCount(15, 'data'); // Default per page
-}
-
-public function test_api_filters_posts_by_category(): void
-{
-    $category = Category::factory()->create();
-    Post::factory()->count(5)->create(['category_id' => $category->id]);
-    Post::factory()->count(5)->create();
-
-    $response = $this->get("/api/posts?category={$category->id}");
-
-    $response->assertJsonCount(5, 'data')
-        ->assertJson([
-            'data' => [
-                ['category_id' => $category->id],
-            ],
-        ]);
-}
-```
-
-## Authentication Testing
-
-```php
-use Laravel\Sanctum\Sanctum;
-
-public function test_authenticated_user_can_access_endpoint(): void
-{
-    $user = User::factory()->create();
-
-    Sanctum::actingAs($user, ['*']);
-
-    $response = $this->get('/api/user');
-
-    $response->assertStatus(200)
-        ->assertJson([
-            'data' => [
-                'id' => $user->id,
-                'email' => $user->email,
-            ],
-        ]);
-}
-
-public function test_user_with_wrong_ability_cannot_access(): void
-{
-    $user = User::factory()->create();
-
-    Sanctum::actingAs($user, ['view-posts']);
-
-    $response = $this->post('/api/posts', [
-        'title' => 'Test',
-        'content' => 'Content',
-    ]);
-
-    $response->assertStatus(403);
-}
-```
-
-## Running Tests
-
-```bash
-# Run all tests
-php artisan test
-
-# Run specific test
-php artisan test --filter=test_user_can_create_post
-
-# Run test file
-php artisan test tests/Feature/PostTest.php
-
-# Parallel testing
-php artisan test --parallel
-
-# With coverage
-php artisan test --coverage
-
-# Coverage minimum
-php artisan test --coverage --min=80
-
-# Stop on failure
-php artisan test --stop-on-failure
-
-# Pest specific
-./vendor/bin/pest
-./vendor/bin/pest --filter=PostTest
-./vendor/bin/pest --coverage
-```
-
-## Best Practices
-
-1. **Use RefreshDatabase** - Clean database for each test
-2. **Use factories** - Don't manually create test data
-3. **Test one thing** - Each test should verify one behavior
-4. **Use descriptive names** - test_user_can_create_post
-5. **AAA pattern** - Arrange, Act, Assert
-6. **Mock external services** - Don't make real API calls
-7. **Fake queues and events** - Test async code synchronously
-8. **Test edge cases** - Invalid data, permissions, etc.
-9. **Achieve >85% coverage** - Test critical paths
-10. **Run tests in CI/CD** - Automate test execution

package/skills/legacy-modernizer/SKILL.md

@@ -1,137 +0,0 @@
----
-name: legacy-modernizer
-description: Designs incremental migration strategies, identifies service boundaries, produces dependency maps and migration roadmaps, and generates API facade designs for aging codebases. Use when modernizing legacy systems, implementing strangler fig pattern or branch by abstraction, decomposing monoliths, upgrading frameworks or languages, or reducing technical debt without disrupting business operations.
-license: MIT
-metadata:
-  author: https://github.com/Jeffallan
-  version: "1.1.0"
-  domain: specialized
-  triggers: legacy modernization, strangler fig, incremental migration, technical debt, legacy refactoring, system migration, legacy system, modernize codebase
-  role: specialist
-  scope: architecture
-  output-format: code+analysis
-  related-skills: test-master, devops-engineer
----
-
-# Legacy Modernizer
-
-## Core Workflow
-
-1. **Assess system** — Analyze codebase, dependencies, risks, and business constraints. Produce a dependency map and risk register before proceeding.
-   - *Validation checkpoint:* Confirm all external integrations and data contracts are documented before moving to step 2.
-
-2. **Plan migration** — Design an incremental roadmap with explicit rollback strategies per phase. Reference `references/system-assessment.md` for code analysis templates.
-   - *Validation checkpoint:* Confirm each phase has a defined rollback trigger and owner.
-
-3. **Build safety net** — Create characterization tests and monitoring before touching production code. Target 80%+ coverage of existing behavior.
-   - *Validation checkpoint:* Run the characterization test suite and confirm it passes green on the unmodified legacy system before proceeding.
-
-4. **Migrate incrementally** — Apply strangler fig pattern with feature flags. Route traffic via a facade; shift load gradually.
-   - *Validation checkpoint:* Verify error rates and latency metrics remain within baseline thresholds after each traffic increment (e.g., 5% → 25% → 50% → 100%).
-
-5. **Validate & iterate** — Run full test suite, review monitoring dashboards, and confirm business behavior is preserved before retiring legacy code.
-   - *Validation checkpoint:* New code must be proven stable at 100% traffic for at least one release cycle before legacy path is removed.
-
-## Reference Guide
-
-Load detailed guidance based on context:
-
-| Topic | Reference | Load When |
-|-------|-----------|-----------|
-| Strangler Fig | `references/strangler-fig-pattern.md` | Incremental replacement, facade layer, routing |
-| Refactoring | `references/refactoring-patterns.md` | Extract service, branch by abstraction, adapters |
-| Migration | `references/migration-strategies.md` | Database, UI, API, framework migrations |
-| Testing | `references/legacy-testing.md` | Characterization tests, golden master, approval |
-| Assessment | `references/system-assessment.md` | Code analysis, dependency mapping, risk evaluation |
-
-## Code Examples
-
-### Strangler Fig Facade (Python)
-```python
-# facade.py — routes requests to legacy or new service based on a feature flag
-import os
-from legacy_service import LegacyOrderService
-from new_service import NewOrderService
-
-class OrderServiceFacade:
-    def __init__(self):
-        self._legacy = LegacyOrderService()
-        self._new = NewOrderService()
-
-    def get_order(self, order_id: str):
-        if os.getenv("USE_NEW_ORDER_SERVICE", "false").lower() == "true":
-            return self._new.fetch(order_id)
-        return self._legacy.get(order_id)
-```
-
-### Feature Flag Wrapper
-```python
-# feature_flags.py — thin wrapper around an environment or config-based flag store
-import os
-
-def flag_enabled(flag_name: str, default: bool = False) -> bool:
-    """Check whether a migration feature flag is active."""
-    return os.getenv(flag_name, str(default)).lower() == "true"
-
-# Usage
-if flag_enabled("USE_NEW_PAYMENT_GATEWAY"):
-    result = new_gateway.charge(order)
-else:
-    result = legacy_gateway.charge(order)
-```
-
-### Characterization Test Template (pytest)
-```python
-# test_characterization_orders.py
-# Captures existing legacy behavior as a golden-master safety net.
-import pytest
-from legacy_service import LegacyOrderService
-
-service = LegacyOrderService()
-
-@pytest.mark.parametrize("order_id,expected_status", [
-    ("ORD-001", "SHIPPED"),
-    ("ORD-002", "PENDING"),
-    ("ORD-003", "CANCELLED"),
-])
-def test_order_status_golden_master(order_id, expected_status):
-    """Fail loudly if legacy behavior changes unexpectedly."""
-    result = service.get(order_id)
-    assert result["status"] == expected_status, (
-        f"Characterization broken for {order_id}: "
-        f"expected {expected_status}, got {result['status']}"
-    )
-```
-
-## Constraints
-
-### MUST DO
-- Maintain zero production disruption during all migrations
-- Create comprehensive test coverage before refactoring (target 80%+)
-- Use feature flags for all incremental rollouts
-- Implement monitoring and rollback procedures
-- Document all migration decisions and rationale
-- Preserve existing business logic and behavior
-- Communicate progress and risks transparently
-
-### MUST NOT DO
-- Big bang rewrites or replacements
-- Skip testing legacy behavior before changes
-- Deploy without rollback capability
-- Break existing integrations or APIs
-- Ignore technical debt in new code
-- Rush migrations without proper validation
-- Remove legacy code before new code is proven
-
-## Output Templates
-
-When implementing modernization, provide:
-1. Assessment summary (risks, dependencies, approach)
-2. Migration plan (phases, rollback strategy, metrics)
-3. Implementation code (facades, adapters, new services)
-4. Test coverage (characterization, integration, e2e)
-5. Monitoring setup (metrics, alerts, dashboards)
-
-## Knowledge Reference
-
-Strangler fig pattern, branch by abstraction, characterization testing, incremental migration, feature flags, canary deployments, API versioning, database refactoring, microservices extraction, technical debt reduction, zero-downtime deployment