agent-bober 0.17.1 → 0.19.0

package/dist/orchestrator/security-auditor-agent.d.ts

@@ -0,0 +1,68 @@
+import type { BoberConfig } from "../config/schema.js";
+import type { SprintContract } from "../contracts/sprint-contract.js";
+import type { EvaluationRunResult } from "../evaluators/registry.js";
+import type { ReviewResult } from "./code-reviewer-agent.js";
+import type { SecurityAuditResult, SecurityFinding } from "./security-audit-types.js";
+import type { SecurityDiffProvider } from "./security-knowledge/diff-provider.js";
+import type { SecurityVerifier } from "./security-verifier-agent.js";
+/**
+ * Injectable dependencies for `runSecurityAudit`. `diffProvider` (sprint 6)
+ * and `verifier` (sprint 8) so tests never shell real git or spawn a second
+ * real LLM loop; both default to the real implementations. Appended so all
+ * existing positional callers stay byte-compatible.
+ */
+export interface SecurityAuditDeps {
+    diffProvider?: SecurityDiffProvider;
+    verifier?: SecurityVerifier;
+}
+/**
+ * Run the bober-security-auditor subagent for a stack-aware security audit.
+ *
+ * Mirrors runCodeReviewer's structure (prompt build → runAgenticLoop with
+ * read-only tools → parse → persist) but the parse is FAIL-CLOSED: an
+ * unparseable auditor response resolves with `parsed:false` and a forced
+ * `verdict:'blocked'` — it never silently degrades to a clean pass the way
+ * the advisory code reviewer's fallback does.
+ *
+ * Two distinct failure modes (per arch-20260712-security-audit-agent-team
+ * API contracts):
+ * - Provider/network/budget error → THROWS (propagates to the caller).
+ * - Unparseable auditor output → RESOLVES with `parsed:false`, `verdict:'blocked'`.
+ *
+ * @param contract    The sprint contract to audit.
+ * @param evaluation  The evaluation result when running in-pipeline (post-evaluation),
+ *                    or `null` for standalone mode — the evaluation-context section of
+ *                    the prompt is omitted entirely when null.
+ * @param projectRoot Absolute path to the project root.
+ * @param config      The resolved bober configuration (reads `config.security` and
+ *                    `config.project.stack`; both optional).
+ * @param priors      Deterministic scanner findings supplied directly by the caller.
+ *                    Combined with any findings produced internally by
+ *                    `runScannerPreFilter` when `config.security.scanners` is
+ *                    non-empty; the combined list is rendered into a "ground
+ *                    truth priors" prompt section when non-empty. Defaults to [].
+ * @param deps        Injectable dependencies — the diff provider (sprint 6,
+ *                    defaults to `securityDiffProvider`) and the verifier
+ *                    (sprint 8, defaults to `runSecurityVerifier`). Appended
+ *                    last so all existing positional callers stay byte-compatible.
+ * @returns A SecurityAuditResult, already persisted via saveSecurityAudit.
+ */
+export declare function runSecurityAudit(contract: SprintContract, evaluation: EvaluationRunResult | null, projectRoot: string, config: BoberConfig, priors?: SecurityFinding[], deps?: SecurityAuditDeps): Promise<SecurityAuditResult>;
+/**
+ * Parse the security auditor's response into a ReviewResult.
+ *
+ * Reuses the same resilient extraction ladder as
+ * code-reviewer-agent.ts:parseReviewResult (direct parse → markdown-fence →
+ * first-`{`-to-last-`}` slice), but INVERTS its fallback: on any parse
+ * failure (garbage text, truncated JSON, non-object shape), this returns
+ * `parsed:false` with an empty review — never a silently "clean" result.
+ * The caller forces `verdict:'blocked'` whenever `parsed` is false.
+ *
+ * A genuinely clean audit (empty critical, well-formed JSON) is
+ * `parsed:true` — distinguishable from the parse-failure case.
+ */
+export declare function parseSecurityAuditResult(text: string, contractId: string, specId: string): {
+    review: ReviewResult;
+    parsed: boolean;
+};
+//# sourceMappingURL=security-auditor-agent.d.ts.map

package/dist/orchestrator/security-auditor-agent.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"security-auditor-agent.d.ts","sourceRoot":"","sources":["../../src/orchestrator/security-auditor-agent.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AACvD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAC;AACtE,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,2BAA2B,CAAC;AACrE,OAAO,KAAK,EAAE,YAAY,EAAiB,MAAM,0BAA0B,CAAC;AAC5E,OAAO,KAAK,EAAE,mBAAmB,EAAE,eAAe,EAAa,MAAM,2BAA2B,CAAC;AAajG,OAAO,KAAK,EAAa,oBAAoB,EAAE,MAAM,uCAAuC,CAAC;AAG7F,OAAO,KAAK,EAAE,gBAAgB,EAAkB,MAAM,8BAA8B,CAAC;AAIrF;;;;;GAKG;AACH,MAAM,WAAW,iBAAiB;IAChC,YAAY,CAAC,EAAE,oBAAoB,CAAC;IACpC,QAAQ,CAAC,EAAE,gBAAgB,CAAC;CAC7B;AAeD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AACH,wBAAsB,gBAAgB,CACpC,QAAQ,EAAE,cAAc,EACxB,UAAU,EAAE,mBAAmB,GAAG,IAAI,EACtC,WAAW,EAAE,MAAM,EACnB,MAAM,EAAE,WAAW,EACnB,MAAM,GAAE,eAAe,EAAO,EAC9B,IAAI,GAAE,iBAAsB,GAC3B,OAAO,CAAC,mBAAmB,CAAC,CAmO9B;AAsKD;;;;;;;;;;;;GAYG;AACH,wBAAgB,wBAAwB,CACtC,IAAI,EAAE,MAAM,EACZ,UAAU,EAAE,MAAM,EAClB,MAAM,EAAE,MAAM,GACb;IAAE,MAAM,EAAE,YAAY,CAAC;IAAC,MAAM,EAAE,OAAO,CAAA;CAAE,CAuE3C"}

package/dist/orchestrator/security-auditor-agent.js

@@ -0,0 +1,482 @@
+import { deriveVerdict } from "./security-audit-types.js";
+import { createClient } from "../providers/factory.js";
+import { resolveModel } from "./model-resolver.js";
+import { assembleSystemPrompt } from "./agent-loader.js";
+import { resolveRoleTools, getGraphState, getGraphDeps } from "./tools/index.js";
+import { runAgenticLoop } from "./agentic-loop.js";
+import { budgetFromMaxUsd } from "./workflow/budget.js";
+import { saveSecurityAudit } from "../state/security-audit-state.js";
+import { ALL_VULN_CLASSES } from "./stack-knowledge.js";
+import { resolveStackSecurityContext } from "./security-knowledge/resolver.js";
+import { SecurityKnowledgeIndex } from "./security-knowledge/index.js";
+import { runScannerPreFilter, isNetworkScanner } from "./security-scanners.js";
+import { securityDiffProvider, extractDiffKeywords } from "./security-knowledge/diff-provider.js";
+import { inspectSupplyChain } from "./security-knowledge/supply-chain-inspector.js";
+import { runSecurityVerifier } from "./security-verifier-agent.js";
+import { logger } from "../utils/logger.js";
+// bober: one memoised index per process (ADR-7, no runtime invalidation) —
+// swap for an injectable dependency if per-request skill reloading is ever needed.
+let sharedSecurityKnowledgeIndex = null;
+function getSecurityKnowledgeIndex() {
+    if (!sharedSecurityKnowledgeIndex) {
+        sharedSecurityKnowledgeIndex = new SecurityKnowledgeIndex();
+    }
+    return sharedSecurityKnowledgeIndex;
+}
+// ── Main ───────────────────────────────────────────────────────────
+/**
+ * Run the bober-security-auditor subagent for a stack-aware security audit.
+ *
+ * Mirrors runCodeReviewer's structure (prompt build → runAgenticLoop with
+ * read-only tools → parse → persist) but the parse is FAIL-CLOSED: an
+ * unparseable auditor response resolves with `parsed:false` and a forced
+ * `verdict:'blocked'` — it never silently degrades to a clean pass the way
+ * the advisory code reviewer's fallback does.
+ *
+ * Two distinct failure modes (per arch-20260712-security-audit-agent-team
+ * API contracts):
+ * - Provider/network/budget error → THROWS (propagates to the caller).
+ * - Unparseable auditor output → RESOLVES with `parsed:false`, `verdict:'blocked'`.
+ *
+ * @param contract    The sprint contract to audit.
+ * @param evaluation  The evaluation result when running in-pipeline (post-evaluation),
+ *                    or `null` for standalone mode — the evaluation-context section of
+ *                    the prompt is omitted entirely when null.
+ * @param projectRoot Absolute path to the project root.
+ * @param config      The resolved bober configuration (reads `config.security` and
+ *                    `config.project.stack`; both optional).
+ * @param priors      Deterministic scanner findings supplied directly by the caller.
+ *                    Combined with any findings produced internally by
+ *                    `runScannerPreFilter` when `config.security.scanners` is
+ *                    non-empty; the combined list is rendered into a "ground
+ *                    truth priors" prompt section when non-empty. Defaults to [].
+ * @param deps        Injectable dependencies — the diff provider (sprint 6,
+ *                    defaults to `securityDiffProvider`) and the verifier
+ *                    (sprint 8, defaults to `runSecurityVerifier`). Appended
+ *                    last so all existing positional callers stay byte-compatible.
+ * @returns A SecurityAuditResult, already persisted via saveSecurityAudit.
+ */
+export async function runSecurityAudit(contract, evaluation, projectRoot, config, priors = [], deps = {}) {
+    const contractId = contract.contractId;
+    logger.sprint(contractId, `Security audit: ${contract.title}`);
+    const securityModel = config.security?.model ?? "opus";
+    const model = resolveModel(securityModel);
+    const maxTurns = config.security?.maxTurns ?? 20;
+    // Security auditor reuses the "curator" role's tool set — read-only,
+    // no execution (read_file, glob, grep). It never gets bash, write, or
+    // edit tools (nonGoals[3]): unlike the evaluator/code-reviewer roles,
+    // the auditor must not be able to run shell commands at all.
+    const graphState = getGraphState(config);
+    const graphDeps = graphState.engineHealth === "ready" ? getGraphDeps() : undefined;
+    const toolSet = resolveRoleTools("curator", projectRoot, graphState, graphDeps ?? undefined);
+    const systemPrompt = await assembleSystemPrompt("curator", "bober-security-auditor", projectRoot, graphState);
+    const client = createClient(config.security?.provider ?? null, config.security?.endpoint ?? null, config.security?.providerConfig, securityModel, "SecurityAuditor");
+    const knowledgeIndex = getSecurityKnowledgeIndex();
+    await knowledgeIndex.load();
+    // Sprint-6: compute the real diff ONCE (opt-in via config.security.diff.mode
+    // === 'git-diff'; default 'estimated-files' keeps today's exact behavior).
+    // The diff is read-only input to the resolver/selector/finder — git runs
+    // ONLY here, in orchestrator Node, never as an auditor tool (ADR-5).
+    let changedPaths = contract.estimatedFiles;
+    let diffKeywords = [];
+    let auditDiff;
+    if (config.security?.diff?.mode === "git-diff") {
+        const provider = deps.diffProvider ?? securityDiffProvider;
+        const diffAbort = new AbortController();
+        const diffTimer = setTimeout(() => diffAbort.abort(), config.security?.timeoutMs ?? 300_000);
+        try {
+            auditDiff = await provider.compute({
+                projectRoot,
+                baseRef: config.security.diff.baseRef,
+                expandWithGraph: config.security.diff.expandWithGraph,
+                signal: diffAbort.signal,
+                config,
+            });
+        }
+        finally {
+            clearTimeout(diffTimer);
+        }
+        // Empty diff (no changes / provider failure) falls back to estimatedFiles
+        // — no regression from today's behavior (sc-6-5).
+        const files = auditDiff.changedFiles.map((f) => f.path);
+        if (files.length > 0) {
+            changedPaths = files;
+            diffKeywords = extractDiffKeywords(auditDiff.changedFiles);
+        }
+    }
+    const ctx = await resolveStackSecurityContext({
+        stack: config.project.stack,
+        changedPaths,
+        diffKeywords,
+        index: knowledgeIndex,
+    });
+    // Sprint-5 seam: when scanners are configured, run the deterministic
+    // pre-filter INSIDE the audit path (under its own AbortController keyed to
+    // the same timeout the gate time-boxes the whole audit against — ADR-4)
+    // and fold its findings in as additional priors. Absent scanners config,
+    // this is a pure no-op: zero child processes spawned.
+    const configuredScanners = config.security?.scanners ?? [];
+    let effectivePriors = priors;
+    if (configuredScanners.length > 0) {
+        const scannerAbort = new AbortController();
+        const scannerTimer = setTimeout(() => scannerAbort.abort(), config.security?.timeoutMs ?? 300_000);
+        try {
+            const scannerPriors = await runScannerPreFilter({
+                scanners: configuredScanners,
+                projectRoot,
+                signal: scannerAbort.signal,
+            });
+            effectivePriors = [...priors, ...scannerPriors];
+        }
+        finally {
+            clearTimeout(scannerTimer);
+        }
+    }
+    // Sprint-7 seam (supply-chain axis, ADR-4): when supplyChain.enabled, fold
+    // both the (network-gated) scanner pre-filter and the always-available
+    // OFFLINE diff inspector into effectivePriors. Network-capable scanner
+    // kinds (npm-audit/osv-scanner) only run when egress.onlineResearch is
+    // explicitly true (default false); gitleaks and the offline inspector run
+    // regardless of egress — neither one touches the network. The offline
+    // inspector runs even when zero external scanners are configured; it is
+    // itself the "always-available" half of the axis.
+    const supplyChain = config.security?.supplyChain;
+    if (supplyChain?.enabled) {
+        const scAbort = new AbortController();
+        const scTimer = setTimeout(() => scAbort.abort(), config.security?.timeoutMs ?? 300_000);
+        try {
+            const onlineOk = config.security?.egress?.onlineResearch === true;
+            const scScanners = onlineOk
+                ? (supplyChain.scanners ?? [])
+                : (supplyChain.scanners ?? []).filter((s) => !isNetworkScanner(s));
+            const scannerPriors = scScanners.length > 0
+                ? await runScannerPreFilter({ scanners: scScanners, projectRoot, signal: scAbort.signal })
+                : [];
+            const inspectorPriors = auditDiff
+                ? await inspectSupplyChain({ projectRoot, diff: auditDiff, signal: scAbort.signal })
+                : [];
+            effectivePriors = [...effectivePriors, ...scannerPriors, ...inspectorPriors];
+        }
+        finally {
+            clearTimeout(scTimer);
+        }
+    }
+    const userMessage = buildUserMessage(contract, evaluation, projectRoot, ctx.stackLabel, ctx.skillName, ctx.promptFragment, effectivePriors, auditDiff);
+    logger.info(`Calling security auditor model (${securityModel} → ${model})...`);
+    const budget = budgetFromMaxUsd(config.security?.budget?.maxUsd);
+    const result = await runAgenticLoop({
+        client,
+        model,
+        systemPrompt,
+        userMessage,
+        tools: toolSet.schemas,
+        toolHandlers: toolSet.handlers,
+        maxTurns,
+        maxTokens: 16384,
+        ...(budget !== undefined ? { budget } : {}),
+        onToolUse: (name, input) => {
+            const inp = input;
+            const inputStr = JSON.stringify(inp).slice(0, 120);
+            logger.debug(`  [security-auditor] ${name}(${inputStr})`);
+        },
+    });
+    logger.debug(`Security auditor completed in ${result.turnsUsed} turns (${result.toolsCalled.length} tool calls)`);
+    const { review: finderReview, parsed } = parseSecurityAuditResult(result.finalText, contractId, contract.specId);
+    // Sprint-8 seam (adversarial finder->verifier stage, ADR-2/ADR-6
+    // default-off): when enabled, a SECOND read-only LLM pass in a fresh,
+    // contract-free context is fed ONLY finderReview.critical+important and
+    // told to disprove each one. It may only downgrade/drop — never promote.
+    // The verifier owns its OWN AbortController keyed to the same
+    // config.security.timeoutMs the rest of this audit's sub-stages use —
+    // that is the "shared time-box" in practice (both live inside the gate's
+    // own Promise.race). A parse-failure/error/abort in the verifier is
+    // fail-closed: `review` stays `finderReview`, criticals unchanged.
+    let review = finderReview;
+    if (parsed && config.security?.verifier?.enabled === true) {
+        const verifier = deps.verifier ?? runSecurityVerifier;
+        const verifierAbort = new AbortController();
+        const verifierTimer = setTimeout(() => verifierAbort.abort(), config.security?.timeoutMs ?? 300_000);
+        try {
+            const verifierResult = await verifier.verify({
+                findings: [...finderReview.critical, ...finderReview.important],
+                diff: auditDiff,
+                projectRoot,
+                config,
+                signal: verifierAbort.signal,
+            });
+            review = foldVerifierResult(finderReview, verifierResult);
+        }
+        finally {
+            clearTimeout(verifierTimer);
+        }
+    }
+    // THE inversion (sc-2-2): verdict is only ever derived from a genuinely
+    // parsed review. A parse failure forces 'blocked' — never a silent pass
+    // from an empty fallback review. Derived on the (possibly verifier-folded)
+    // review — deriveVerdict itself is UNCHANGED.
+    const verdict = parsed ? deriveVerdict(review) : "blocked";
+    const auditResult = {
+        review,
+        stack: ctx.stackLabel,
+        // True when scanners were configured (even if they all yielded [], the
+        // deterministic pre-filter genuinely ran) OR when the caller-supplied
+        // `priors` were non-empty (sprint-2 formula — priors passed directly with
+        // no scanners configured still counts as "a scanner ran" from the
+        // caller's perspective).
+        scannerRan: configuredScanners.length > 0 || effectivePriors.length > 0,
+        parsed,
+        verdict,
+    };
+    await saveSecurityAudit(projectRoot, contractId, auditResult);
+    logger.info(`Security audit complete: verdict=${verdict}, parsed=${parsed}, ${review.critical.length} critical finding(s)`);
+    return auditResult;
+}
+// ── Sprint-8: verifier fold (downgrade-only, fail-closed) ──────────
+/**
+ * Folds a `VerifierResult` into the finder's `ReviewResult`.
+ *
+ * Fail-closed: `v.ran === false` (parse-failure/error/refusal/abort) returns
+ * `finderReview` completely UNCHANGED — the finder's criticals are kept.
+ *
+ * Downgrade-only on success: `verified` findings stay at their original
+ * severity; `downgraded` findings move `critical`->`important`; `dropped`
+ * findings are removed from wherever they were (critical or important). The
+ * new `critical` set is therefore always a strict SUBSET of the finder's
+ * `critical` — nothing is ever promoted or added. `minor` and
+ * `approvedAreas` pass through byte-untouched: the verifier is never shown
+ * them, so an `approvedArea` can never be re-opened (sc-8-4).
+ *
+ * Matches by object identity: `verifier.verify` is fed and returns the SAME
+ * `SecurityFinding` object references it was given (see
+ * `security-verifier-agent.ts:resolveFindingRef`), so a `Set` membership
+ * check against `finderReview.critical`/`.important` is exact.
+ */
+function foldVerifierResult(finderReview, v) {
+    if (!v.ran)
+        return finderReview;
+    const dropped = new Set(v.dropped);
+    const downgraded = new Set(v.downgraded);
+    return {
+        ...finderReview,
+        critical: finderReview.critical.filter((c) => !dropped.has(c) && !downgraded.has(c)),
+        important: [
+            ...finderReview.important.filter((i) => !dropped.has(i)),
+            ...finderReview.critical.filter((c) => downgraded.has(c)),
+        ],
+        minor: finderReview.minor,
+        approvedAreas: finderReview.approvedAreas,
+    };
+}
+// ── Prompt assembly ────────────────────────────────────────────────
+/**
+ * Renders the "# Changed files (real diff)" section (Pattern D — empty
+ * string when there's no diff, so git-diff-mode-with-no-changes produces a
+ * prompt byte-identical to estimated-files mode, sc-6-5).
+ */
+function renderChangedFilesSection(auditDiff) {
+    if (!auditDiff || auditDiff.changedFiles.length === 0)
+        return "";
+    const filesText = auditDiff.changedFiles
+        .map((f) => {
+        const hunksText = f.hunks.length > 0 ? f.hunks.map((h) => h.content).join("\n\n") : "(no hunks captured)";
+        return `## ${f.path} (${f.status})\n\n${hunksText}`;
+    })
+        .join("\n\n");
+    const neighborhoodText = auditDiff.neighborhoodFiles.length > 0
+        ? `\n\nCall-graph neighborhood (files affected by the changes above):\n${auditDiff.neighborhoodFiles.join("\n")}`
+        : "";
+    const truncatedText = auditDiff.truncated
+        ? "\n\n(diff truncated — showing a bounded subset of changed files/hunks)"
+        : "";
+    return `# Changed files (real diff)\n\n${filesText}${neighborhoodText}${truncatedText}\n\n`;
+}
+function buildUserMessage(contract, evaluation, projectRoot, stackLabel, skillName, promptFragment, priors, auditDiff) {
+    const contractId = contract.contractId;
+    const contractJson = JSON.stringify(contract, null, 2);
+    // Standalone mode (evaluation === null) omits the evaluation-context
+    // section entirely — sc-2-5.
+    const evalSection = evaluation !== null
+        ? `# Evaluation Result (Already Passed)\n\n${JSON.stringify({
+            passed: evaluation.passed,
+            score: evaluation.score,
+            summary: evaluation.summary,
+            timestamp: evaluation.timestamp,
+        }, null, 2)}\n\n`
+        : "";
+    // Sprint-5 seam: deterministic scanner priors, rendered only when present.
+    const priorsSection = priors.length > 0
+        ? `# Deterministic scanner findings (ground truth priors)\n\n${JSON.stringify(priors, null, 2)}\n\n`
+        : "";
+    // Sprint-6 seam: real changed files/hunks, rendered only when present.
+    const changedFilesSection = renderChangedFilesSection(auditDiff);
+    const hasRealDiff = (auditDiff?.changedFiles.length ?? 0) > 0;
+    const scopeInstruction = hasRealDiff
+        ? 'Use the "# Changed files (real diff)" section above — it lists the ACTUAL changed files/hunks for ' +
+            "this sprint; Read each changed file in full for surrounding context, and ground findings in the " +
+            "real diff rather than guessing from `estimatedFiles`"
+        : "Use Glob to enumerate the in-scope files (the `estimatedFiles` patterns, or the relevant\n" +
+            "   project directories when that list is empty) and Read each one in full; there is no diff\n" +
+            "   available without Bash, so audit the CURRENT content of each in-scope file";
+    return `# Sprint Contract
+
+${contractJson}
+
+${evalSection}${priorsSection}${changedFilesSection}# Stack Security Context
+
+Stack: ${stackLabel}
+Skill: ${skillName ?? "none (generic taxonomy only)"}
+
+${promptFragment}
+
+# Project Root
+
+${projectRoot}
+
+# Context
+
+- Contract ID: ${contractId}
+- Spec ID: ${contract.specId}
+- Mode: ${evaluation === null ? "standalone (no prior evaluation context)" : "in-pipeline (post-evaluation)"}
+
+# Your Task
+
+Audit the sprint's changes for exploitable security vulnerabilities. You have Read/Grep/Glob
+only (no Bash, no git)${hasRealDiff ? ' — a real diff IS provided inline above ("# Changed files (real diff)" section)' : ""} — use them to:
+1. Read .bober/contracts/${contractId}.json for scope, including its \`estimatedFiles\` list
+2. ${scopeInstruction}
+3. Use Grep to search across the codebase for suspicious patterns (hardcoded secrets, unsafe
+   string interpolation into a query/shell/template, missing auth checks) that Read alone
+   might miss
+4. Review each file against the vulnerability taxonomy and stack-specific checklist above
+5. Produce a ReviewResult JSON, findings organised by VulnClass, cited with path+line+snippet
+
+Output ONLY a JSON object (no markdown fences, no surrounding prose):
+{
+  "reviewId": "security-audit-${contractId}-<ISO-timestamp>",
+  "contractId": "${contractId}",
+  "specId": "${contract.specId}",
+  "timestamp": "<ISO-8601>",
+  "summary": "<2-3 sentence overall assessment>",
+  "critical": [],
+  "important": [],
+  "minor": [],
+  "approvedAreas": []
+}`;
+}
+// ── Fail-closed JSON parser ────────────────────────────────────────
+/**
+ * Parse the security auditor's response into a ReviewResult.
+ *
+ * Reuses the same resilient extraction ladder as
+ * code-reviewer-agent.ts:parseReviewResult (direct parse → markdown-fence →
+ * first-`{`-to-last-`}` slice), but INVERTS its fallback: on any parse
+ * failure (garbage text, truncated JSON, non-object shape), this returns
+ * `parsed:false` with an empty review — never a silently "clean" result.
+ * The caller forces `verdict:'blocked'` whenever `parsed` is false.
+ *
+ * A genuinely clean audit (empty critical, well-formed JSON) is
+ * `parsed:true` — distinguishable from the parse-failure case.
+ */
+export function parseSecurityAuditResult(text, contractId, specId) {
+    const timestamp = new Date().toISOString();
+    let parsedJson;
+    // Try direct parse
+    try {
+        parsedJson = JSON.parse(text.trim());
+    }
+    catch {
+        // Try extracting from markdown fences
+        const fenceMatch = /```(?:json)?\s*\n?([\s\S]*?)\n?\s*```/.exec(text);
+        if (fenceMatch) {
+            try {
+                parsedJson = JSON.parse(fenceMatch[1].trim());
+            }
+            catch {
+                // Fall through
+            }
+        }
+        // Try finding { ... }
+        if (parsedJson === undefined) {
+            const braceStart = text.indexOf("{");
+            const braceEnd = text.lastIndexOf("}");
+            if (braceStart !== -1 && braceEnd > braceStart) {
+                try {
+                    parsedJson = JSON.parse(text.slice(braceStart, braceEnd + 1));
+                }
+                catch {
+                    // Fall through to fail-closed default below
+                }
+            }
+        }
+    }
+    // A JSON array is technically valid JSON but not a ReviewResult shape —
+    // treating it as "parsed" would manufacture a fake clean review out of the
+    // wrong shape. Fail-closed requires an actual object, never an array.
+    if (parsedJson && typeof parsedJson === "object" && !Array.isArray(parsedJson)) {
+        const obj = parsedJson;
+        const review = {
+            reviewId: typeof obj.reviewId === "string" ? obj.reviewId : `security-audit-${contractId}-${timestamp}`,
+            contractId: typeof obj.contractId === "string" ? obj.contractId : contractId,
+            specId: typeof obj.specId === "string" ? obj.specId : specId,
+            timestamp: typeof obj.timestamp === "string" ? obj.timestamp : timestamp,
+            summary: typeof obj.summary === "string" ? obj.summary : "No summary provided.",
+            critical: parseSecurityFindingArray(obj.critical),
+            important: parseSecurityFindingArray(obj.important),
+            minor: parseSecurityFindingArray(obj.minor),
+            approvedAreas: parseStringArray(obj.approvedAreas),
+        };
+        return { review, parsed: true };
+    }
+    // Fail-closed fallback — auditor ran but the response was NOT parseable.
+    // Unlike parseReviewResult's fallback, this is a signal the caller MUST
+    // act on: parsed:false forces verdict:'blocked', never a silent pass.
+    return {
+        review: {
+            reviewId: `security-audit-${contractId}-${timestamp}`,
+            contractId,
+            specId,
+            timestamp,
+            summary: "Security auditor output could not be parsed.",
+            critical: [],
+            important: [],
+            minor: [],
+            approvedAreas: [],
+        },
+        parsed: false,
+    };
+}
+function isVulnClass(value) {
+    return ALL_VULN_CLASSES.includes(value);
+}
+function parseSecurityFindingArray(raw) {
+    if (!Array.isArray(raw))
+        return [];
+    return raw
+        .filter((item) => typeof item === "object" && item !== null)
+        .map((item) => ({
+        description: typeof item.description === "string" ? item.description : "Unknown finding",
+        evidence: parseEvidenceArray(item.evidence),
+        ...(typeof item.antiPattern === "string" ? { antiPattern: item.antiPattern } : {}),
+        ...(typeof item.source === "string" ? { source: item.source } : {}),
+        ...(typeof item.vulnClass === "string" && isVulnClass(item.vulnClass)
+            ? { vulnClass: item.vulnClass }
+            : {}),
+    }));
+}
+function parseEvidenceArray(raw) {
+    if (!Array.isArray(raw))
+        return [];
+    return raw
+        .filter((item) => typeof item === "object" && item !== null)
+        .map((item) => ({
+        path: typeof item.path === "string" ? item.path : "unknown",
+        line: typeof item.line === "number" ? item.line : 0,
+        snippet: typeof item.snippet === "string" ? item.snippet : "",
+    }));
+}
+function parseStringArray(raw) {
+    if (!Array.isArray(raw))
+        return [];
+    return raw.filter((item) => typeof item === "string");
+}
+//# sourceMappingURL=security-auditor-agent.js.map

package/dist/orchestrator/security-auditor-agent.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"security-auditor-agent.js","sourceRoot":"","sources":["../../src/orchestrator/security-auditor-agent.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,aAAa,EAAE,MAAM,2BAA2B,CAAC;AAC1D,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AACvD,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AACnD,OAAO,EAAE,oBAAoB,EAAE,MAAM,mBAAmB,CAAC;AACzD,OAAO,EAAE,gBAAgB,EAAE,aAAa,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AACnD,OAAO,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,EAAE,iBAAiB,EAAE,MAAM,kCAAkC,CAAC;AACrE,OAAO,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,EAAE,2BAA2B,EAAE,MAAM,kCAAkC,CAAC;AAC/E,OAAO,EAAE,sBAAsB,EAAE,MAAM,+BAA+B,CAAC;AACvE,OAAO,EAAE,mBAAmB,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAE/E,OAAO,EAAE,oBAAoB,EAAE,mBAAmB,EAAE,MAAM,uCAAuC,CAAC;AAClG,OAAO,EAAE,kBAAkB,EAAE,MAAM,gDAAgD,CAAC;AAEpF,OAAO,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACnE,OAAO,EAAE,MAAM,EAAE,MAAM,oBAAoB,CAAC;AAa5C,2EAA2E;AAC3E,mFAAmF;AACnF,IAAI,4BAA4B,GAAkC,IAAI,CAAC;AAEvE,SAAS,yBAAyB;IAChC,IAAI,CAAC,4BAA4B,EAAE,CAAC;QAClC,4BAA4B,GAAG,IAAI,sBAAsB,EAAE,CAAC;IAC9D,CAAC;IACD,OAAO,4BAA4B,CAAC;AACtC,CAAC;AAED,sEAAsE;AAEtE;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AACH,MAAM,CAAC,KAAK,UAAU,gBAAgB,CACpC,QAAwB,EACxB,UAAsC,EACtC,WAAmB,EACnB,MAAmB,EACnB,SAA4B,EAAE,EAC9B,OAA0B,EAAE;IAE5B,MAAM,UAAU,GAAG,QAAQ,CAAC,UAAU,CAAC;IACvC,MAAM,CAAC,MAAM,CAAC,UAAU,EAAE,mBAAmB,QAAQ,CAAC,KAAK,EAAE,CAAC,CAAC;IAE/D,MAAM,aAAa,GAAG,MAAM,CAAC,QAAQ,EAAE,KAAK,IAAI,MAAM,CAAC;IACvD,MAAM,KAAK,GAAG,YAAY,CAAC,aAAa,CAAC,CAAC;IAC1C,MAAM,QAAQ,GAAG,MAAM,CAAC,QAAQ,EAAE,QAAQ,IAAI,EAAE,CAAC;IAEjD,qEAAqE;IACrE,sEAAsE;IACtE,sEAAsE;IACtE,6DAA6D;IAC7D,MAAM,UAAU,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC;IACzC,MAAM,SAAS,GAAG,UAAU,CAAC,YAAY,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;IACnF,MAAM,OAAO,GAAG,gBAAgB,CAAC,SAAS,EAAE,WAAW,EAAE,UAAU,EAAE,SAAS,IAAI,SAAS,CAAC,CAAC;IAC7F,MAAM,YAAY,GAAG,MAAM,oBAAoB,CAAC,SAAS,EAAE,wBAAwB,EAAE,WAAW,EAAE,UAAU,CAAC,CAAC;IAE9G,MAAM,MAAM,GAAG,YAAY,CACzB,MAAM,CAAC,QAAQ,EAAE,QAAQ,IAAI,IAAI,EACjC,MAAM,CAAC,QAAQ,EAAE,QAAQ,IAAI,IAAI,EACjC,MAAM,CAAC,QAAQ,EAAE,cAAc,EAC/B,aAAa,EACb,iBAAiB,CAClB,CAAC;IAEF,MAAM,cAAc,GAAG,yBAAyB,EAAE,CAAC;IACnD,MAAM,cAAc,CAAC,IAAI,EAAE,CAAC;IAE5B,6EAA6E;IAC7E,2EAA2E;IAC3E,yEAAyE;IACzE,qEAAqE;IACrE,IAAI,YAAY,GAAG,QAAQ,CAAC,cAAc,CAAC;IAC3C,IAAI,YAAY,GAAa,EAAE,CAAC;IAChC,IAAI,SAAgC,CAAC;IACrC,IAAI,MAAM,CAAC,QAAQ,EAAE,IAAI,EAAE,IAAI,KAAK,UAAU,EAAE,CAAC;QAC/C,MAAM,QAAQ,GAAG,IAAI,CAAC,YAAY,IAAI,oBAAoB,CAAC;QAC3D,MAAM,SAAS,GAAG,IAAI,eAAe,EAAE,CAAC;QACxC,MAAM,SAAS,GAAG,UAAU,CAAC,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,MAAM,CAAC,QAAQ,EAAE,SAAS,IAAI,OAAO,CAAC,CAAC;QAC7F,IAAI,CAAC;YACH,SAAS,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC;gBACjC,WAAW;gBACX,OAAO,EAAE,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO;gBACrC,eAAe,EAAE,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,eAAe;gBACrD,MAAM,EAAE,SAAS,CAAC,MAAM;gBACxB,MAAM;aACP,CAAC,CAAC;QACL,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,SAAS,CAAC,CAAC;QAC1B,CAAC;QAED,0EAA0E;QAC1E,kDAAkD;QAClD,MAAM,KAAK,GAAG,SAAS,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QACxD,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,YAAY,GAAG,KAAK,CAAC;YACrB,YAAY,GAAG,mBAAmB,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7D,CAAC;IACH,CAAC;IAED,MAAM,GAAG,GAAG,MAAM,2BAA2B,CAAC;QAC5C,KAAK,EAAE,MAAM,CAAC,OAAO,CAAC,KAAK;QAC3B,YAAY;QACZ,YAAY;QACZ,KAAK,EAAE,cAAc;KACtB,CAAC,CAAC;IAEH,qEAAqE;IACrE,2EAA2E;IAC3E,wEAAwE;IACxE,yEAAyE;IACzE,sDAAsD;IACtD,MAAM,kBAAkB,GAAG,MAAM,CAAC,QAAQ,EAAE,QAAQ,IAAI,EAAE,CAAC;IAC3D,IAAI,eAAe,GAAG,MAAM,CAAC;IAC7B,IAAI,kBAAkB,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAClC,MAAM,YAAY,GAAG,IAAI,eAAe,EAAE,CAAC;QAC3C,MAAM,YAAY,GAAG,UAAU,CAC7B,GAAG,EAAE,CAAC,YAAY,CAAC,KAAK,EAAE,EAC1B,MAAM,CAAC,QAAQ,EAAE,SAAS,IAAI,OAAO,CACtC,CAAC;QACF,IAAI,CAAC;YACH,MAAM,aAAa,GAAG,MAAM,mBAAmB,CAAC;gBAC9C,QAAQ,EAAE,kBAAkB;gBAC5B,WAAW;gBACX,MAAM,EAAE,YAAY,CAAC,MAAM;aAC5B,CAAC,CAAC;YACH,eAAe,GAAG,CAAC,GAAG,MAAM,EAAE,GAAG,aAAa,CAAC,CAAC;QAClD,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,YAAY,CAAC,CAAC;QAC7B,CAAC;IACH,CAAC;IAED,2EAA2E;IAC3E,uEAAuE;IACvE,uEAAuE;IACvE,uEAAuE;IACvE,0EAA0E;IAC1E,sEAAsE;IACtE,wEAAwE;IACxE,kDAAkD;IAClD,MAAM,WAAW,GAAG,MAAM,CAAC,QAAQ,EAAE,WAAW,CAAC;IACjD,IAAI,WAAW,EAAE,OAAO,EAAE,CAAC;QACzB,MAAM,OAAO,GAAG,IAAI,eAAe,EAAE,CAAC;QACtC,MAAM,OAAO,GAAG,UAAU,CACxB,GAAG,EAAE,CAAC,OAAO,CAAC,KAAK,EAAE,EACrB,MAAM,CAAC,QAAQ,EAAE,SAAS,IAAI,OAAO,CACtC,CAAC;QACF,IAAI,CAAC;YACH,MAAM,QAAQ,GAAG,MAAM,CAAC,QAAQ,EAAE,MAAM,EAAE,cAAc,KAAK,IAAI,CAAC;YAClE,MAAM,UAAU,GAAG,QAAQ;gBACzB,CAAC,CAAC,CAAC,WAAW,CAAC,QAAQ,IAAI,EAAE,CAAC;gBAC9B,CAAC,CAAC,CAAC,WAAW,CAAC,QAAQ,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,gBAAgB,CAAC,CAAC,CAAC,CAAC,CAAC;YAErE,MAAM,aAAa,GACjB,UAAU,CAAC,MAAM,GAAG,CAAC;gBACnB,CAAC,CAAC,MAAM,mBAAmB,CAAC,EAAE,QAAQ,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,EAAE,OAAO,CAAC,MAAM,EAAE,CAAC;gBAC1F,CAAC,CAAC,EAAE,CAAC;YAET,MAAM,eAAe,GAAG,SAAS;gBAC/B,CAAC,CAAC,MAAM,kBAAkB,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,SAAS,EAAE,MAAM,EAAE,OAAO,CAAC,MAAM,EAAE,CAAC;gBACpF,CAAC,CAAC,EAAE,CAAC;YAEP,eAAe,GAAG,CAAC,GAAG,eAAe,EAAE,GAAG,aAAa,EAAE,GAAG,eAAe,CAAC,CAAC;QAC/E,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,OAAO,CAAC,CAAC;QACxB,CAAC;IACH,CAAC;IAED,MAAM,WAAW,GAAG,gBAAgB,CAClC,QAAQ,EACR,UAAU,EACV,WAAW,EACX,GAAG,CAAC,UAAU,EACd,GAAG,CAAC,SAAS,EACb,GAAG,CAAC,cAAc,EAClB,eAAe,EACf,SAAS,CACV,CAAC;IAEF,MAAM,CAAC,IAAI,CAAC,mCAAmC,aAAa,MAAM,KAAK,MAAM,CAAC,CAAC;IAE/E,MAAM,MAAM,GAAG,gBAAgB,CAAC,MAAM,CAAC,QAAQ,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC;IAEjE,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC;QAClC,MAAM;QACN,KAAK;QACL,YAAY;QACZ,WAAW;QACX,KAAK,EAAE,OAAO,CAAC,OAAO;QACtB,YAAY,EAAE,OAAO,CAAC,QAAQ;QAC9B,QAAQ;QACR,SAAS,EAAE,KAAK;QAChB,GAAG,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAC3C,SAAS,EAAE,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE;YACzB,MAAM,GAAG,GAAG,KAAgC,CAAC;YAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;YACnD,MAAM,CAAC,KAAK,CAAC,wBAAwB,IAAI,IAAI,QAAQ,GAAG,CAAC,CAAC;QAC5D,CAAC;KACF,CAAC,CAAC;IAEH,MAAM,CAAC,KAAK,CACV,iCAAiC,MAAM,CAAC,SAAS,WAAW,MAAM,CAAC,WAAW,CAAC,MAAM,cAAc,CACpG,CAAC;IAEF,MAAM,EAAE,MAAM,EAAE,YAAY,EAAE,MAAM,EAAE,GAAG,wBAAwB,CAC/D,MAAM,CAAC,SAAS,EAChB,UAAU,EACV,QAAQ,CAAC,MAAM,CAChB,CAAC;IAEF,iEAAiE;IACjE,sEAAsE;IACtE,wEAAwE;IACxE,yEAAyE;IACzE,8DAA8D;IAC9D,sEAAsE;IACtE,yEAAyE;IACzE,oEAAoE;IACpE,mEAAmE;IACnE,IAAI,MAAM,GAAG,YAAY,CAAC;IAC1B,IAAI,MAAM,IAAI,MAAM,CAAC,QAAQ,EAAE,QAAQ,EAAE,OAAO,KAAK,IAAI,EAAE,CAAC;QAC1D,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,IAAI,mBAAmB,CAAC;QACtD,MAAM,aAAa,GAAG,IAAI,eAAe,EAAE,CAAC;QAC5C,MAAM,aAAa,GAAG,UAAU,CAC9B,GAAG,EAAE,CAAC,aAAa,CAAC,KAAK,EAAE,EAC3B,MAAM,CAAC,QAAQ,EAAE,SAAS,IAAI,OAAO,CACtC,CAAC;QACF,IAAI,CAAC;YACH,MAAM,cAAc,GAAG,MAAM,QAAQ,CAAC,MAAM,CAAC;gBAC3C,QAAQ,EAAE,CAAC,GAAG,YAAY,CAAC,QAAQ,EAAE,GAAG,YAAY,CAAC,SAAS,CAAC;gBAC/D,IAAI,EAAE,SAAS;gBACf,WAAW;gBACX,MAAM;gBACN,MAAM,EAAE,aAAa,CAAC,MAAM;aAC7B,CAAC,CAAC;YACH,MAAM,GAAG,kBAAkB,CAAC,YAAY,EAAE,cAAc,CAAC,CAAC;QAC5D,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,aAAa,CAAC,CAAC;QAC9B,CAAC;IACH,CAAC;IAED,wEAAwE;IACxE,wEAAwE;IACxE,2EAA2E;IAC3E,8CAA8C;IAC9C,MAAM,OAAO,GAAuB,MAAM,CAAC,CAAC,CAAC,aAAa,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAE/E,MAAM,WAAW,GAAwB;QACvC,MAAM;QACN,KAAK,EAAE,GAAG,CAAC,UAAU;QACrB,uEAAuE;QACvE,sEAAsE;QACtE,0EAA0E;QAC1E,kEAAkE;QAClE,yBAAyB;QACzB,UAAU,EAAE,kBAAkB,CAAC,MAAM,GAAG,CAAC,IAAI,eAAe,CAAC,MAAM,GAAG,CAAC;QACvE,MAAM;QACN,OAAO;KACR,CAAC;IAEF,MAAM,iBAAiB,CAAC,WAAW,EAAE,UAAU,EAAE,WAAW,CAAC,CAAC;IAE9D,MAAM,CAAC,IAAI,CACT,oCAAoC,OAAO,YAAY,MAAM,KAAK,MAAM,CAAC,QAAQ,CAAC,MAAM,sBAAsB,CAC/G,CAAC;IAEF,OAAO,WAAW,CAAC;AACrB,CAAC;AAED,sEAAsE;AAEtE;;;;;;;;;;;;;;;;;;GAkBG;AACH,SAAS,kBAAkB,CAAC,YAA0B,EAAE,CAAiB;IACvE,IAAI,CAAC,CAAC,CAAC,GAAG;QAAE,OAAO,YAAY,CAAC;IAEhC,MAAM,OAAO,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;IACnC,MAAM,UAAU,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;IAEzC,OAAO;QACL,GAAG,YAAY;QACf,QAAQ,EAAE,YAAY,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QACpF,SAAS,EAAE;YACT,GAAG,YAAY,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;YACxD,GAAG,YAAY,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;SAC1D;QACD,KAAK,EAAE,YAAY,CAAC,KAAK;QACzB,aAAa,EAAE,YAAY,CAAC,aAAa;KAC1C,CAAC;AACJ,CAAC;AAED,sEAAsE;AAEtE;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,SAAgC;IACjE,IAAI,CAAC,SAAS,IAAI,SAAS,CAAC,YAAY,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,CAAC;IAEjE,MAAM,SAAS,GAAG,SAAS,CAAC,YAAY;SACrC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE;QACT,MAAM,SAAS,GAAG,CAAC,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,qBAAqB,CAAC;QAC1G,OAAO,MAAM,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,MAAM,QAAQ,SAAS,EAAE,CAAC;IACtD,CAAC,CAAC;SACD,IAAI,CAAC,MAAM,CAAC,CAAC;IAEhB,MAAM,gBAAgB,GACpB,SAAS,CAAC,iBAAiB,CAAC,MAAM,GAAG,CAAC;QACpC,CAAC,CAAC,uEAAuE,SAAS,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;QACjH,CAAC,CAAC,EAAE,CAAC;IAET,MAAM,aAAa,GAAG,SAAS,CAAC,SAAS;QACvC,CAAC,CAAC,wEAAwE;QAC1E,CAAC,CAAC,EAAE,CAAC;IAEP,OAAO,kCAAkC,SAAS,GAAG,gBAAgB,GAAG,aAAa,MAAM,CAAC;AAC9F,CAAC;AAED,SAAS,gBAAgB,CACvB,QAAwB,EACxB,UAAsC,EACtC,WAAmB,EACnB,UAAkB,EAClB,SAAwB,EACxB,cAAsB,EACtB,MAAyB,EACzB,SAAqB;IAErB,MAAM,UAAU,GAAG,QAAQ,CAAC,UAAU,CAAC;IACvC,MAAM,YAAY,GAAG,IAAI,CAAC,SAAS,CAAC,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;IAEvD,qEAAqE;IACrE,6BAA6B;IAC7B,MAAM,WAAW,GACf,UAAU,KAAK,IAAI;QACjB,CAAC,CAAC,2CAA2C,IAAI,CAAC,SAAS,CACvD;YACE,MAAM,EAAE,UAAU,CAAC,MAAM;YACzB,KAAK,EAAE,UAAU,CAAC,KAAK;YACvB,OAAO,EAAE,UAAU,CAAC,OAAO;YAC3B,SAAS,EAAE,UAAU,CAAC,SAAS;SAChC,EACD,IAAI,EACJ,CAAC,CACF,MAAM;QACT,CAAC,CAAC,EAAE,CAAC;IAET,2EAA2E;IAC3E,MAAM,aAAa,GACjB,MAAM,CAAC,MAAM,GAAG,CAAC;QACf,CAAC,CAAC,6DAA6D,IAAI,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC,MAAM;QACpG,CAAC,CAAC,EAAE,CAAC;IAET,uEAAuE;IACvE,MAAM,mBAAmB,GAAG,yBAAyB,CAAC,SAAS,CAAC,CAAC;IACjE,MAAM,WAAW,GAAG,CAAC,SAAS,EAAE,YAAY,CAAC,MAAM,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;IAE9D,MAAM,gBAAgB,GAAG,WAAW;QAClC,CAAC,CAAC,oGAAoG;YACpG,kGAAkG;YAClG,sDAAsD;QACxD,CAAC,CAAC,4FAA4F;YAC5F,+FAA+F;YAC/F,+EAA+E,CAAC;IAEpF,OAAO;;EAEP,YAAY;;EAEZ,WAAW,GAAG,aAAa,GAAG,mBAAmB;;SAE1C,UAAU;SACV,SAAS,IAAI,8BAA8B;;EAElD,cAAc;;;;EAId,WAAW;;;;iBAII,UAAU;aACd,QAAQ,CAAC,MAAM;UAClB,UAAU,KAAK,IAAI,CAAC,CAAC,CAAC,0CAA0C,CAAC,CAAC,CAAC,+BAA+B;;;;;wBAKpF,WAAW,CAAC,CAAC,CAAC,iFAAiF,CAAC,CAAC,CAAC,EAAE;2BACjG,UAAU;KAChC,gBAAgB;;;;;;;;;gCASW,UAAU;mBACvB,UAAU;eACd,QAAQ,CAAC,MAAM;;;;;;;EAO5B,CAAC;AACH,CAAC;AAED,sEAAsE;AAEtE;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,wBAAwB,CACtC,IAAY,EACZ,UAAkB,EAClB,MAAc;IAEd,MAAM,SAAS,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;IAC3C,IAAI,UAAmB,CAAC;IAExB,mBAAmB;IACnB,IAAI,CAAC;QACH,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC;IACvC,CAAC;IAAC,MAAM,CAAC;QACP,sCAAsC;QACtC,MAAM,UAAU,GAAG,uCAAuC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtE,IAAI,UAAU,EAAE,CAAC;YACf,IAAI,CAAC;gBACH,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;YAChD,CAAC;YAAC,MAAM,CAAC;gBACP,eAAe;YACjB,CAAC;QACH,CAAC;QAED,sBAAsB;QACtB,IAAI,UAAU,KAAK,SAAS,EAAE,CAAC;YAC7B,MAAM,UAAU,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;YACrC,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;YACvC,IAAI,UAAU,KAAK,CAAC,CAAC,IAAI,QAAQ,GAAG,UAAU,EAAE,CAAC;gBAC/C,IAAI,CAAC;oBACH,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,EAAE,QAAQ,GAAG,CAAC,CAAC,CAAC,CAAC;gBAChE,CAAC;gBAAC,MAAM,CAAC;oBACP,4CAA4C;gBAC9C,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,wEAAwE;IACxE,2EAA2E;IAC3E,sEAAsE;IACtE,IAAI,UAAU,IAAI,OAAO,UAAU,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,EAAE,CAAC;QAC/E,MAAM,GAAG,GAAG,UAAqC,CAAC;QAElD,MAAM,MAAM,GAAiB;YAC3B,QAAQ,EACN,OAAO,GAAG,CAAC,QAAQ,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,kBAAkB,UAAU,IAAI,SAAS,EAAE;YAC/F,UAAU,EAAE,OAAO,GAAG,CAAC,UAAU,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU;YAC5E,MAAM,EAAE,OAAO,GAAG,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM;YAC5D,SAAS,EAAE,OAAO,GAAG,CAAC,SAAS,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS;YACxE,OAAO,EAAE,OAAO,GAAG,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,sBAAsB;YAC/E,QAAQ,EAAE,yBAAyB,CAAC,GAAG,CAAC,QAAQ,CAAC;YACjD,SAAS,EAAE,yBAAyB,CAAC,GAAG,CAAC,SAAS,CAAC;YACnD,KAAK,EAAE,yBAAyB,CAAC,GAAG,CAAC,KAAK,CAAC;YAC3C,aAAa,EAAE,gBAAgB,CAAC,GAAG,CAAC,aAAa,CAAC;SACnD,CAAC;QAEF,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;IAClC,CAAC;IAED,yEAAyE;IACzE,wEAAwE;IACxE,sEAAsE;IACtE,OAAO;QACL,MAAM,EAAE;YACN,QAAQ,EAAE,kBAAkB,UAAU,IAAI,SAAS,EAAE;YACrD,UAAU;YACV,MAAM;YACN,SAAS;YACT,OAAO,EAAE,8CAA8C;YACvD,QAAQ,EAAE,EAAE;YACZ,SAAS,EAAE,EAAE;YACb,KAAK,EAAE,EAAE;YACT,aAAa,EAAE,EAAE;SAClB;QACD,MAAM,EAAE,KAAK;KACd,CAAC;AACJ,CAAC;AAED,SAAS,WAAW,CAAC,KAAa;IAChC,OAAQ,gBAA6B,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC;AACxD,CAAC;AAED,SAAS,yBAAyB,CAAC,GAAY;IAC7C,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;QAAE,OAAO,EAAE,CAAC;IAEnC,OAAQ,GAAiB;SACtB,MAAM,CAAC,CAAC,IAAI,EAAmC,EAAE,CAAC,OAAO,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,IAAI,CAAC;SAC5F,GAAG,CAAC,CAAC,IAAI,EAAmB,EAAE,CAAC,CAAC;QAC/B,WAAW,EAAE,OAAO,IAAI,CAAC,WAAW,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,iBAAiB;QACxF,QAAQ,EAAE,kBAAkB,CAAC,IAAI,CAAC,QAAQ,CAAC;QAC3C,GAAG,CAAC,OAAO,IAAI,CAAC,WAAW,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAClF,GAAG,CAAC,OAAO,IAAI,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QACnE,GAAG,CAAC,OAAO,IAAI,CAAC,SAAS,KAAK,QAAQ,IAAI,WAAW,CAAC,IAAI,CAAC,SAAS,CAAC;YACnE,CAAC,CAAC,EAAE,SAAS,EAAE,IAAI,CAAC,SAAS,EAAE;YAC/B,CAAC,CAAC,EAAE,CAAC;KACR,CAAC,CAAC,CAAC;AACR,CAAC;AAED,SAAS,kBAAkB,CAAC,GAAY;IACtC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;QAAE,OAAO,EAAE,CAAC;IAEnC,OAAQ,GAAiB;SACtB,MAAM,CAAC,CAAC,IAAI,EAAmC,EAAE,CAAC,OAAO,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,IAAI,CAAC;SAC5F,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;QACd,IAAI,EAAE,OAAO,IAAI,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS;QAC3D,IAAI,EAAE,OAAO,IAAI,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACnD,OAAO,EAAE,OAAO,IAAI,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE;KAC9D,CAAC,CAAC,CAAC;AACR,CAAC;AAED,SAAS,gBAAgB,CAAC,GAAY;IACpC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;QAAE,OAAO,EAAE,CAAC;IACnC,OAAQ,GAAiB,CAAC,MAAM,CAAC,CAAC,IAAI,EAAkB,EAAE,CAAC,OAAO,IAAI,KAAK,QAAQ,CAAC,CAAC;AACvF,CAAC"}

package/dist/orchestrator/security-gate.d.ts

@@ -0,0 +1,73 @@
+/**
+ * The fail-closed SecurityAuditGate (spec-20260712-security-audit-agent-team,
+ * sprint 3, ADR-2).
+ *
+ * Thin wrapper over runSecurityAudit (sprint 2): the gate owns the
+ * Promise.race time-box, the rejection→'audit-error'/'timeout' mapping, the
+ * parsed:false→'audit-error' elevation, and the best-effort store guard
+ * (sc-3-6). It does NOT re-run or re-derive any auditor logic — the verdict
+ * comes straight from `result.verdict` (already computed via deriveVerdict
+ * inside runSecurityAudit).
+ *
+ * evaluateSecurityGate NEVER throws. Every failure mode (timeout, thrown
+ * audit error, unparseable output) resolves to `blocked:true` — an
+ * incomplete audit is never treated as clean (fail-closed).
+ *
+ * Sprint 6 additionally emits critical/important findings into the priority
+ * hub AFTER the verdict is computed and OUTSIDE the Promise.race time-box
+ * below, so a slow or failing hub ingest can never flip the verdict or
+ * manufacture a false timeout (see emitFindingsToHub).
+ */
+import type { BoberConfig } from "../config/schema.js";
+import type { SprintContract } from "../contracts/sprint-contract.js";
+import type { EvaluationRunResult } from "../evaluators/registry.js";
+import type { SecurityAuditResult } from "./security-audit-types.js";
+import type { SecurityFindingSink } from "./security-hub.js";
+export interface SecurityGateInput {
+    contract: SprintContract;
+    evaluation: EvaluationRunResult;
+    projectRoot: string;
+    config: BoberConfig;
+    /** Injected hub sink (tests only) — default binds ingestFinding to a real FactStore. */
+    findingSink?: SecurityFindingSink;
+}
+export type SecurityGateReason = "critical-finding" | "timeout" | "audit-error" | "clean" | "disabled";
+export interface SecurityGateVerdict {
+    blocked: boolean;
+    reason: SecurityGateReason;
+    result?: SecurityAuditResult;
+}
+/**
+ * Evaluate the security gate for a sprint that just passed evaluation.
+ *
+ * Never throws. Resolution mapping:
+ * - `config.security` absent or `enabled !== true` → `{blocked:false, reason:'disabled'}`
+ *   WITHOUT invoking the audit at all.
+ * - `runSecurityAudit` rejects (any error) → `{blocked:true, reason:'audit-error'}`.
+ * - The Promise.race timeout (`config.security.timeoutMs`) fires first →
+ *   `{blocked:true, reason:'timeout'}`.
+ * - `result.parsed === false` (unparseable auditor output) →
+ *   `{blocked:true, reason:'audit-error', result}` — checked BEFORE
+ *   `result.verdict` so a parse failure is never mistaken for a genuine
+ *   critical finding.
+ * - `result.verdict === 'blocked'` (a real critical finding) →
+ *   `{blocked:true, reason:'critical-finding', result}`.
+ * - Otherwise → `{blocked:false, reason:'clean', result}`.
+ *
+ * A `saveSecurityAudit` persistence failure is caught, logged, and never
+ * changes the already-computed verdict in either direction (sc-3-6).
+ */
+export declare function evaluateSecurityGate(input: SecurityGateInput): Promise<SecurityGateVerdict>;
+/**
+ * Render a blocked SecurityGateVerdict into feedback strings for the
+ * generator's next retry iteration (ADR-5), phrased for a fixer. Pure
+ * function — no side effects, no I/O.
+ *
+ * Returns `[]` for a non-blocked verdict. Returns a single generic message
+ * when there is no `result` to enumerate findings from (a `timeout` or a
+ * rejected `audit-error` never resolves a SecurityAuditResult). Otherwise
+ * returns a summary line followed by one line per critical finding, capped
+ * to MAX_RENDERED_FINDINGS.
+ */
+export declare function renderSecurityFeedback(verdict: SecurityGateVerdict): string[];
+//# sourceMappingURL=security-gate.d.ts.map