@woosh/meep-engine 3.14.1 → 3.14.3

package/src/shade/renderer/postprocess/taa/shader_taa.d.ts

@@ -1,6 +1,6 @@
 export const TAA_VELOCITY_IN_PIXELS_LIMIT: 128;
 /**
- * calculate confidence factor based on the velocity of current pixel, everything moving faster than FRAME_VELOCITY_IN_PIXELS_DIFF frame-to-frame will be marked as no-history
+ * calculate confidence factor based on the velocity of current pixel, everything moving faster than TAA_VELOCITY_IN_PIXELS_LIMIT output pixels frame-to-frame will be marked as no-history
  * @type {CodeChunk}
  */
 export const chunk_taa_velocity_confidence: CodeChunk;

package/src/shade/renderer/postprocess/taa/shader_taa.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"shader_taa.d.ts","sourceRoot":"","sources":["../../../../../../src/shade/renderer/postprocess/taa/shader_taa.js"],"names":[],"mappings":"AA4CA,+CAAgD;AAGhD;;;GAGG;AACH,4CAFU,SAAS,CASjB;AAEF;;;;GAIG;AACH,gDAFU,SAAS,CAgBjB;AA0KF,qCAaG;0BA9PuB,oCAAoC;4BAClC,6BAA6B"}
+{"version":3,"file":"shader_taa.d.ts","sourceRoot":"","sources":["../../../../../../src/shade/renderer/postprocess/taa/shader_taa.js"],"names":[],"mappings":"AAuCA,+CAAgD;AAGhD;;;GAGG;AACH,4CAFU,SAAS,CASjB;AAEF;;;;GAIG;AACH,gDAFU,SAAS,CAgBjB;AA6LF,qCAaG;0BA9QuB,oCAAoC;4BAClC,6BAA6B"}

package/src/shade/renderer/postprocess/taa/shader_taa.js

@@ -1,8 +1,6 @@
 import { f32, vec2f } from "../../shader/type/WEBGPU_WGSL_PRIMITIVE_TYPES.js";
 import { WebGPUStruct } from "../../shader/type/WebGPUStruct.js";
-import { CAMERA_UNIFORM_STRUCT } from "../../camera/CAMERA_UNIFORM_STRUCT.js";
 import { chunk_aabb3_normalized_dist } from "../../shader/chunk/geometry/aabb3/chunk_line_aabb3_clipping_distance.js";
-import { chunk_uv_to_texel_coordinate } from "../../shader/chunk/texture/chunk_uv_to_texel_coordinate.js";
 import {
     chunk_texture_sample_catmullrom_hardware_5tap_uv
 } from "../../shader/chunk/texture/sample/chunk_texture_sample_catmullrom_hardware_5tap_uv.js";
@@ -11,8 +9,8 @@ import { ImageShader } from "../../shader/ImageShader.js";
 import { ShaderResourceSetDescriptor } from "../../shader/resource/ShaderResourceSetDescriptor.js";
 import { ShaderDescriptor } from "../../shader/ShaderDescriptor.js";
 import { SAMPLER_LINEAR_UPSCALE } from "../../texture/SAMPLER_LINEAR_UPSCALE.js";
-import { chunk_taa_get_velocity } from "../velocity/chunk_taa_get_velocity.js";
 import { chunk_color_clip_to_aabb3 } from "./chunk_color_clip_to_aabb3.js";
+import { chunk_depth_clip_offset_codec } from "./chunk_depth_clip_offset_codec.js";
 import { chunk_taa_decode_color } from "./chunk_taa_decode_color.js";
 import { chunk_taa_encode_color } from "./chunk_taa_encode_color.js";
 import { chunk_taa_history_color_bounding_box_YCoCg } from "./chunk_taa_history_color_bounding_box_YCoCg.js";
@@ -27,17 +25,14 @@ const TAA_SETTINGS_STRUCT = WebGPUStruct.from({
 
 const resources = new ShaderResourceSetDescriptor();
 
-// per-pass, 16 bytes, read-only: immediate data rather than a uniform buffer. The two camera
-// uniforms beside it are scene state and stay bound.
+// per-pass, 16 bytes, read-only: immediate data rather than a uniform buffer.
 resources.setImmediate("settings", TAA_SETTINGS_STRUCT);
 resources.createGroup()
     .addSampler("sLinear", "filtering", SAMPLER_LINEAR_UPSCALE)
-    .addTexture("VelocityBuffer", "float") // velocities, in pixels, at internal resolution
+    .addTexture("VelocityBuffer", "float") // raw velocity, in internal pixels
     .addTexture("HistoryTexture", "float") // previous resolved frame, at output resolution.
     .addTexture("ColourTexture", "float") // incoming frame, drawn at internal resolution. Typically lower than output.
-    .addTexture("tOcclusion", "float") // disocclusion, at internal resolution
-    .addUniform("camera_current", CAMERA_UNIFORM_STRUCT)
-    .addUniform("camera_previous", CAMERA_UNIFORM_STRUCT)
+    .addTexture("tOcclusion", "float") // depth-clip pass output at internal resolution: r confidence, g nearest-depth offset
 ;
 
 
@@ -46,7 +41,7 @@ export const TAA_VELOCITY_IN_PIXELS_LIMIT = 128;
 
 
 /**
- * calculate confidence factor based on the velocity of current pixel, everything moving faster than FRAME_VELOCITY_IN_PIXELS_DIFF frame-to-frame will be marked as no-history
+ * calculate confidence factor based on the velocity of current pixel, everything moving faster than TAA_VELOCITY_IN_PIXELS_LIMIT output pixels frame-to-frame will be marked as no-history
  * @type {CodeChunk}
  */
 export const chunk_taa_velocity_confidence = CodeChunk.from(
@@ -111,24 +106,30 @@ fn main(
     let resolution_ratio = vec2<f32>(resolution_internal.xy) / vec2<f32>(resolution_output.xy);
     let upscale_ratio = f32(resolution_output.x) / f32(resolution_internal.x);
 
-    let internal_st = vec2<i32>( output_st.xy * resolution_ratio );
-    
-    // note, we're in reverse-z projection, so jitter is negative
+    // positive jitter shifts rendered content right/down by settings.jitter internal pixels (see
+    // GPUCameraContext), so the un-jittered content of this output pixel sits at uv + jitter / resolution
     let jittered_uv = uv + ( settings.jitter ) / vec2<f32>(resolution_internal);
     let internal_jittered_st = jittered_uv * vec2<f32>(resolution_internal);
+
+    // the internal texel the current colour comes from. Velocity and occlusion are read at the same
+    // texel, so all three describe one surface when the jitter crosses a texel boundary. Clamped:
+    // at the border the jitter can push the position just outside the texture.
+    let internal_st = clamp(vec2<i32>(floor(internal_jittered_st)), vec2(0), vec2<i32>(resolution_internal) - 1);
     
-    // get velocity
-    let velocity = taa_get_velocity( VelocityBuffer, internal_st ) / resolution_ratio;
+    // depth-clip pass output for this texel: r = history confidence, g = which of the 3x3 texels won
+    // its nearest-depth search. The raw velocity at that texel is exactly the velocity the confidence
+    // was computed for; dilating again here would move the reprojection away from what was validated.
+    let occlusion_confidence = textureLoad( tOcclusion, internal_st, 0 ).r;
+
+    // velocity in output pixels
+    let velocity = depth_clip_validated_velocity( tOcclusion, VelocityBuffer, internal_st ) / resolution_ratio;
     
-    // calculate confidence factor based on the velocity of current pixel, everything moving faster than FRAME_VELOCITY_IN_PIXELS_DIFF frame-to-frame will be marked as no-history
+    // calculate confidence factor based on the velocity of current pixel, everything moving faster than TAA_VELOCITY_IN_PIXELS_LIMIT output pixels frame-to-frame will be marked as no-history
     let velocityConfidenceFactor = taa_velocity_confidence(velocity.xy);
 
     // prev frame ST and UV
     let prevFrameScreenST = output_st.xy - velocity.xy;
     
-    // get depth confidence factor, larger then 0, assume the history is valid
-    let occlusion_confidence =  textureLoad(tOcclusion, internal_st, 0).r;
-
     // do we have a valid history?
     let uvWeight = uv_within_screen( prevFrameScreenST ) ;
     
@@ -168,13 +169,12 @@ fn main(
         // sample current colour 
         let color_current_YCoCg = taa_encode_color(color_current_raw);
 
-        // default incoming contribution
-        var blend = 0.05;
-                
-        let history_confidence = color_history_raw.a * velocityConfidenceFactor * occlusion_confidence;
-        
-        // blend less history if hitstory has low confidence or under motion
-        blend = mix(1.0, blend, history_confidence);
+        // accumulated-sample proxy carried in history alpha: n/(n+1) after n samples. Saturated because
+        // the Catmull-Rom taps overshoot across alpha steps.
+        let sample_confidence = saturate(color_history_raw.a);
+
+        // how far this frame trusts the history sample: accumulated count, motion, disocclusion
+        let history_confidence = sample_confidence * velocityConfidenceFactor * occlusion_confidence;
         
         var min_c: vec3<f32>;
         var max_c: vec3<f32>;
@@ -182,7 +182,7 @@ fn main(
         taa_history_color_bounding_box_YCoCg(
             ColourTexture,
             color_current_YCoCg,
-            vec2<i32>(internal_jittered_st),
+            internal_st,
             variance_scale,
             &min_c,
             &max_c,
@@ -196,17 +196,26 @@ fn main(
             max_c,
         );
         
-        // We detect when clamp would occur and dampen the incoming sample's contribution to counteract it. 
-        // see "High Quality Temporal Supersampling" by Brian Karis, EpicGames SIGGRAPH 2014
+        // Tension of the clipped history against the neighbourhood box on its tightest axis: 0 at
+        // the current colour, 1 on a wall, which is where a clipped history always lands.
         let t_clamp = saturate(aabb3_normalized_dist_from_center(
             color_current_YCoCg,
             clipped_history_YCoCg,
             min_c,
             max_c,
         ));
-        
-        blend *= mix(0.2, 1.0, t_clamp * t_clamp);
-        
+
+        // incoming contribution at full confidence. History near the clamp wall gets less of it, down
+        // to a quarter on the wall, which is where a clipped history lands: a clip is an impulse, and
+        // damping the sample that caused it keeps the next frame's clip from taking it straight back,
+        // which reads as flicker. "High Quality Temporal Supersampling" (Karis, SIGGRAPH 2014,
+        // slide 45); the same rule and constants as chunk_volumetrics_taa_resolve.
+        var blend = 0.05 * mix(1.0, 0.25, t_clamp * t_clamp);
+
+        // no confidence: take the current frame outright. Full confidence: the rate above. The
+        // dampening sits inside this mix so zero-confidence history can never reach the output.
+        blend = mix(1.0, blend, history_confidence);
+
         // prevent blending from going to 0
         blend = max(blend, 0.004);
         
@@ -214,7 +223,12 @@ fn main(
         
         var weight_history = (1.0 - blend);
                 
-        let confidence_new = saturate(  1.f  / (  2.0f  - history_confidence ) );
+        // next frame's sample count, from how much of the history this frame kept. At full confidence
+        // the count keeps growing as n/(n+1); a rejected or disoccluded history restarts at one sample
+        // (0.5), the value the no-history branch stores. Motion feeds back through this: under
+        // sustained motion the count settles below converged, so the blend sits above what the
+        // per-frame velocity confidence alone would give.
+        let confidence_new = 1.0 / (2.0 - history_confidence);
  
         let mixed_color = taa_decode_color( mix(color_current_YCoCg, clipped_history_YCoCg, weight_history));
 
@@ -224,8 +238,10 @@ fn main(
     
         // no valid history, or disocclusion
         
-        // initialize with full confidence
-        final_colour = vec4(color_current_raw, 1.0);
+        // one sample. Store the confidence the valid path gives a single sample (confidence_new at
+        // zero history confidence) so the 1/N ramp restarts here; anything higher makes the next
+        // frame treat this lone jittered sample as converged history.
+        final_colour = vec4(color_current_raw, 0.5);
         
     }
     
@@ -235,15 +251,13 @@ fn main(
 `, [
         chunk_taa_decode_color,
         chunk_taa_encode_color,
-        chunk_taa_get_velocity,
         chunk_taa_history_color_bounding_box_YCoCg,
         chunk_color_clip_to_aabb3,
+        chunk_depth_clip_offset_codec,
         chunk_taa_velocity_confidence,
         chunk_taa_velocity_variance_scale,
         chunk_aabb3_normalized_dist,
         chunk_texture_sample_catmullrom_hardware_5tap_uv,
-
-        chunk_uv_to_texel_coordinate,
     ]);
 
 

package/src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_brick4.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"chunk_forward_shade_standard_fragment_brick4.d.ts","sourceRoot":"","sources":["../../../../../../../src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_brick4.js"],"names":[],"mappings":"AA2BA,qEAuJC;0BA1JyB,uCAAuC"}
+{"version":3,"file":"chunk_forward_shade_standard_fragment_brick4.d.ts","sourceRoot":"","sources":["../../../../../../../src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_brick4.js"],"names":[],"mappings":"AA4BA,qEAwJC;0BA3JyB,uCAAuC"}

package/src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_brick4.js

@@ -1,4 +1,5 @@
 import { chunk_shade_standard_material_direct } from "../../../deferred/chunk_shade_standard_material_direct.js";
+import { chunk_decode_tangent_normal } from "../../../shader/chunk/geometry/normal/chunk_decode_tangent_normal.js";
 import { INDIRECT_LIGHT_INTENSITY } from "../../../deferred/INDIRECT_LIGHT_INTENSITY.js";
 import {
     chunk_brick4_sample_forward_indirect
@@ -34,7 +35,7 @@ fn forward_shade_standard_fragment(
 ) -> vec4f {
     let world_tangent_frame = build_orthonormal_matrix_nt(vert.normal, vert.tangent);
     
-    let t_normal = textureSample(texture_normal, texture_normal_sampler, vert.uv).rgb * 2.0 - 1.0;
+    let t_normal = decode_tangent_normal(textureSample(texture_normal, texture_normal_sampler, vert.uv));
     var world_shading_normal:vec3<f32> = normalize( world_tangent_frame * t_normal );
     
     // flip normal if fragment is back-facing, 
@@ -169,6 +170,7 @@ fn forward_shade_standard_fragment(
         chunk_dielectric_specular_color,
         chunk_F_Hauber,
         chunk_build_orthonormal_matrix_nt,
+        chunk_decode_tangent_normal,
         chunk_anti_alias_roughness_kaplanyan,
         chunk_shade_standard_material_direct,
         chunk_get_view_space_depth,

package/src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_ibl.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"chunk_forward_shade_standard_fragment_ibl.d.ts","sourceRoot":"","sources":["../../../../../../../src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_ibl.js"],"names":[],"mappings":"AA0BA;;;GAGG;AACH,kEA4IC;0BAnJyB,uCAAuC"}
+{"version":3,"file":"chunk_forward_shade_standard_fragment_ibl.d.ts","sourceRoot":"","sources":["../../../../../../../src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_ibl.js"],"names":[],"mappings":"AA2BA;;;GAGG;AACH,kEA6IC;0BApJyB,uCAAuC"}

package/src/shade/renderer/rasterize/native/oit/chunk_forward_shade_standard_fragment_ibl.js

@@ -1,4 +1,5 @@
 import { chunk_shade_standard_material_direct } from "../../../deferred/chunk_shade_standard_material_direct.js";
+import { chunk_decode_tangent_normal } from "../../../shader/chunk/geometry/normal/chunk_decode_tangent_normal.js";
 import { chunk_get_ibl_irradiance } from "../../../deferred/indirect/chunk_get_ibl_irradiance.js";
 import { chunk_get_ibl_radiance } from "../../../deferred/indirect/chunk_get_ibl_radiance.js";
 import { INDIRECT_LIGHT_INTENSITY } from "../../../deferred/INDIRECT_LIGHT_INTENSITY.js";
@@ -37,7 +38,7 @@ fn forward_shade_standard_fragment(
 ) -> vec4f {
     let world_tangent_frame = build_orthonormal_matrix_nt(vert.normal, vert.tangent);
     
-    let t_normal = textureSample(texture_normal, texture_normal_sampler, vert.uv).rgb * 2.0 - 1.0;
+    let t_normal = decode_tangent_normal(textureSample(texture_normal, texture_normal_sampler, vert.uv));
     var world_shading_normal:vec3<f32> = normalize( world_tangent_frame * t_normal );
     
     // flip normal if fragment is back-facing, 
@@ -160,6 +161,7 @@ fn forward_shade_standard_fragment(
         chunk_dielectric_specular_color,
         chunk_F_Hauber,
         chunk_build_orthonormal_matrix_nt,
+        chunk_decode_tangent_normal,
         chunk_anti_alias_roughness_kaplanyan,
         chunk_shade_standard_material_direct,
         chunk_get_view_space_depth,

package/src/shade/renderer/restir/di/chunk_restir_temporal_reuse.d.ts

@@ -6,8 +6,10 @@
  * reprojected location, following the RTXDI temporal pattern (combine each
  * finalized reservoir, then FinalizeResampling once).
  *
- * History validity reuses the existing depth-occlusion-clip confidence (the same
- * reprojection TAA gates on) plus a bounds check, so disocclusions don't ghost.
+ * History validity reuses the depth-occlusion-clip confidence plus a bounds check, so
+ * disocclusions don't ghost, and the reprojection uses the velocity that confidence was
+ * computed for: the depth-clip output's g channel names the nearest-depth texel, and
+ * depth_clip_validated_velocity fetches the raw velocity there, exactly as TAA does.
  * The previous sample's target function is recomputed at the CURRENT surface
  * (never reuse the stored targetPdf), and the previous M is clamped so stale
  * history can't dominate — both are required for an unbiased, lag-bounded result.

package/src/shade/renderer/restir/di/chunk_restir_temporal_reuse.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"chunk_restir_temporal_reuse.d.ts","sourceRoot":"","sources":["../../../../../../src/shade/renderer/restir/di/chunk_restir_temporal_reuse.js"],"names":[],"mappings":"AAcA;;;;;;;;;;;;;;;;;;GAkBG;AACH,0CAFU,SAAS,CA8EjB;0BArGwB,oCAAoC"}
+{"version":3,"file":"chunk_restir_temporal_reuse.d.ts","sourceRoot":"","sources":["../../../../../../src/shade/renderer/restir/di/chunk_restir_temporal_reuse.js"],"names":[],"mappings":"AAcA;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,0CAFU,SAAS,CA+EjB;0BAxGwB,oCAAoC"}

package/src/shade/renderer/restir/di/chunk_restir_temporal_reuse.js

@@ -4,8 +4,8 @@ import { chunk_rtxdi_unpack_reservoir } from "../reservoir/chunk_rtxdi_unpack_re
 import { RTXDI_Reservoir } from "../reservoir/RTXDI_Reservoir.js";
 import { GEOMETRIC_SHADING_INFO_STRUCT } from "../../shader/chunk/material/GEOMETRIC_SHADING_INFO_STRUCT.js";
 import { MATERIAL_SHADING_INFO_STRUCT } from "../../shader/chunk/material/MATERIAL_SHADING_INFO_STRUCT.js";
+import { chunk_depth_clip_offset_codec } from "../../postprocess/taa/chunk_depth_clip_offset_codec.js";
 import { chunk_random } from "../../shader/chunk/random/chunk_random.js";
-import { chunk_taa_get_velocity } from "../../postprocess/velocity/chunk_taa_get_velocity.js";
 import { CodeChunk } from "../../shader/compiler/CodeChunk.js";
 import { chunk_restir_get_light_info } from "./chunk_restir_get_light_info.js";
 import { chunk_restir_light_ref } from "./chunk_restir_light_ref.js";
@@ -20,8 +20,10 @@ import { chunk_restir_target_function } from "./chunk_restir_target_function.js"
  * reprojected location, following the RTXDI temporal pattern (combine each
  * finalized reservoir, then FinalizeResampling once).
  *
- * History validity reuses the existing depth-occlusion-clip confidence (the same
- * reprojection TAA gates on) plus a bounds check, so disocclusions don't ghost.
+ * History validity reuses the depth-occlusion-clip confidence plus a bounds check, so
+ * disocclusions don't ghost, and the reprojection uses the velocity that confidence was
+ * computed for: the depth-clip output's g channel names the nearest-depth texel, and
+ * depth_clip_validated_velocity fetches the raw velocity there, exactly as TAA does.
  * The previous sample's target function is recomputed at the CURRENT surface
  * (never reuse the stored targetPdf), and the previous M is clamped so stale
  * history can't dominate — both are required for an unbiased, lag-bounded result.
@@ -59,8 +61,9 @@ fn restir_temporal_reuse(
     // a static camera) into a full +/-1 pixel read error, which shows up as the
     // reservoir field crawling/scrolling across surfaces. + 0.5 then floor is
     // round-to-nearest and is stable for sub-pixel motion (matches the engine's
-    // pixel-centre minus velocity reprojection convention, e.g. GTAO/TAA).
-    let velocity = taa_get_velocity(VelocityBuffer, vec2<i32>(i_coord));
+    // pixel-centre minus velocity reprojection convention, e.g. GTAO/TAA). The velocity is the
+    // one the depth-clip confidence below was evaluated with, so the two cannot disagree.
+    let velocity = depth_clip_validated_velocity(tOcclusionClip, VelocityBuffer, vec2<i32>(i_coord));
     let prev_coord = vec2<i32>(floor(vec2<f32>(i_coord) + vec2<f32>(0.5) - velocity));
 
     // History validity: disocclusion confidence at the current pixel + bounds.
@@ -98,7 +101,7 @@ fn restir_temporal_reuse(
         chunk_rtxdi_combine_reservoirs,
         chunk_rtxdi_finalize_resampling,
         chunk_rtxdi_unpack_reservoir,
-        chunk_taa_get_velocity,
+        chunk_depth_clip_offset_codec,
         chunk_restir_get_light_info,
         chunk_restir_light_ref,
         chunk_restir_reservoir_address,

package/src/shade/renderer/scene/optimization/deduplicate_images.js

@@ -1,94 +1,94 @@
-import { sampler2d_build_mipmap_chain } from "./sampler2d_build_mipmap_chain.js";
-import { sampler2d_compare } from "./sampler2d_compare.js";
-import { source_to_sampler2d } from "./source_to_sampler2d.js";
-
-/**
- *
- * @param {Object[]} lookup_input
- * @returns {Object[][]}
- */
-export function deduplicate_images(lookup_input) {
-
-    /**
-     *
-     * @type {Map<Object, Sampler2D[]>}
-     */
-    const sampler_2d_lookup = new Map();
-
-    for (const source of lookup_input) {
-
-        const sampler_2d = source_to_sampler2d(source);
-
-        if (sampler_2d === null) {
-            // not applicable, skip
-            continue;
-        }
-
-        const mipmap = sampler2d_build_mipmap_chain(sampler_2d);
-
-        sampler_2d_lookup.set(source, mipmap);
-    }
-
-    const SIMILARITY_THRESHOLD = 0.99;
-    /**
-     * How many mips from the source down to. 0 would compare the original image.
-     * @type {number}
-     */
-    const SIMILARITY_MIP_OFFSET = 1;
-
-    const comparable_set = Array.from(new Set(sampler_2d_lookup.keys()));
-
-    const duplicate_pairs = [];
-
-    for (let i = 0; i < comparable_set.length; i++) {
-        loop_b: for (let j = i + 1; j < comparable_set.length; j++) {
-
-            const source_a = comparable_set[i];
-            const source_b = comparable_set[j];
-
-            if (source_a === source_b) {
-                continue;
-            }
-
-            const mipmap_a = sampler_2d_lookup.get(source_a);
-            const mipmap_b = sampler_2d_lookup.get(source_b);
-
-            if (mipmap_b.length !== mipmap_a.length) {
-                continue;
-            }
-
-            let lowest_mip_level = 0;
-
-            if(mipmap_b.length < 3 + SIMILARITY_MIP_OFFSET){
-                // image is too small, comparing mips would introduce too much error
-                lowest_mip_level = 0;
-            }else{
-                lowest_mip_level = SIMILARITY_MIP_OFFSET;
-            }
-
-            // accelerate comparrison via mipmaps, can reject much faster and at worst we do 33% more work
-            for (let k = mipmap_a.length - 1; k >= lowest_mip_level; k--) {
-
-                const sampler_a = mipmap_a[k];
-                const sampler_b = mipmap_b[k];
-
-                const similarity = sampler2d_compare(sampler_a, sampler_b);
-
-                if (similarity < SIMILARITY_THRESHOLD) {
-                    continue loop_b;
-                }
-
-            }
-
-
-            // same
-
-            duplicate_pairs.push([
-                source_b, // <- discard
-                source_a // <- master record
-            ]);
-        }
-    }
-
-    return duplicate_pairs;
+import { sampler2d_build_mipmap_chain } from "./sampler2d_build_mipmap_chain.js";
+import { sampler2d_compare } from "../../../../engine/graphics/texture/sampler/compare/sampler2d_compare.js";
+import { source_to_sampler2d } from "./source_to_sampler2d.js";
+
+/**
+ *
+ * @param {Object[]} lookup_input
+ * @returns {Object[][]}
+ */
+export function deduplicate_images(lookup_input) {
+
+    /**
+     *
+     * @type {Map<Object, Sampler2D[]>}
+     */
+    const sampler_2d_lookup = new Map();
+
+    for (const source of lookup_input) {
+
+        const sampler_2d = source_to_sampler2d(source);
+
+        if (sampler_2d === null) {
+            // not applicable, skip
+            continue;
+        }
+
+        const mipmap = sampler2d_build_mipmap_chain(sampler_2d);
+
+        sampler_2d_lookup.set(source, mipmap);
+    }
+
+    const SIMILARITY_THRESHOLD = 0.99;
+    /**
+     * How many mips from the source down to. 0 would compare the original image.
+     * @type {number}
+     */
+    const SIMILARITY_MIP_OFFSET = 1;
+
+    const comparable_set = Array.from(new Set(sampler_2d_lookup.keys()));
+
+    const duplicate_pairs = [];
+
+    for (let i = 0; i < comparable_set.length; i++) {
+        loop_b: for (let j = i + 1; j < comparable_set.length; j++) {
+
+            const source_a = comparable_set[i];
+            const source_b = comparable_set[j];
+
+            if (source_a === source_b) {
+                continue;
+            }
+
+            const mipmap_a = sampler_2d_lookup.get(source_a);
+            const mipmap_b = sampler_2d_lookup.get(source_b);
+
+            if (mipmap_b.length !== mipmap_a.length) {
+                continue;
+            }
+
+            let lowest_mip_level = 0;
+
+            if(mipmap_b.length < 3 + SIMILARITY_MIP_OFFSET){
+                // image is too small, comparing mips would introduce too much error
+                lowest_mip_level = 0;
+            }else{
+                lowest_mip_level = SIMILARITY_MIP_OFFSET;
+            }
+
+            // accelerate comparrison via mipmaps, can reject much faster and at worst we do 33% more work
+            for (let k = mipmap_a.length - 1; k >= lowest_mip_level; k--) {
+
+                const sampler_a = mipmap_a[k];
+                const sampler_b = mipmap_b[k];
+
+                const similarity = sampler2d_compare(sampler_a, sampler_b);
+
+                if (similarity < SIMILARITY_THRESHOLD) {
+                    continue loop_b;
+                }
+
+            }
+
+
+            // same
+
+            duplicate_pairs.push([
+                source_b, // <- discard
+                source_a // <- master record
+            ]);
+        }
+    }
+
+    return duplicate_pairs;
 }