@woosh/meep-engine 2.56.1 → 2.58.0

package/src/engine/intelligence/behavior/composite/ParallelBehavior.spec.js

@@ -1,8 +1,9 @@
-import { ParallelBehavior, ParallelBehaviorPolicy } from "./ParallelBehavior.js";
-import { SucceedingBehavior } from "../primitive/SucceedingBehavior.js";
-import { BehaviorStatus } from "../BehaviorStatus.js";
-import { FailingBehavior } from "../primitive/FailingBehavior.js";
-import { jest } from '@jest/globals';
+import {ParallelBehavior, ParallelBehaviorPolicy} from "./ParallelBehavior.js";
+import {SucceedingBehavior} from "../primitive/SucceedingBehavior.js";
+import {BehaviorStatus} from "../BehaviorStatus.js";
+import {FailingBehavior} from "../primitive/FailingBehavior.js";
+import {jest} from '@jest/globals';
+import {RepeatBehavior} from "../decorator/RepeatBehavior.js";
 
 test("constructor doesn't throw", () => {
     new ParallelBehavior(ParallelBehaviorPolicy.RequireAll, ParallelBehaviorPolicy.RequireAll);
@@ -33,11 +34,11 @@ test("1 succeeding child", () => {
 test("1 succeeding child, 1 tick delay", () => {
     const p = new ParallelBehavior(ParallelBehaviorPolicy.RequireAll, ParallelBehaviorPolicy.RequireOne);
 
-    const b = new SucceedingBehavior(1);
+    const b = RepeatBehavior.from(SucceedingBehavior.INSTANCE, 2);
 
-    b.tick = jest.fn(b.tick);
-    b.initialize = jest.fn(b.initialize);
-    b.finalize = jest.fn(b.finalize);
+    b.tick = jest.fn(b.tick.bind(b));
+    b.initialize = jest.fn(b.initialize.bind(b));
+    b.finalize = jest.fn(b.finalize.bind(b));
 
     p.addChild(b);
 
@@ -105,7 +106,7 @@ test("policy success-One, failure-One. Succeeding", () => {
 
     p.addChild(a);
 
-    const b = new SucceedingBehavior(1);
+    const b = RepeatBehavior.from(SucceedingBehavior.INSTANCE, 2);
 
     p.addChild(b);
 
@@ -121,7 +122,7 @@ test("policy success-All, failure-One. Succeeding", () => {
 
     p.addChild(a);
 
-    const b = new SucceedingBehavior(1);
+    const b = RepeatBehavior.from(SucceedingBehavior.INSTANCE, 2);
 
     p.addChild(b);
 
@@ -138,7 +139,7 @@ test("policy success-One, failure-One. Failing", () => {
 
     p.addChild(a);
 
-    const b = new SucceedingBehavior(1);
+    const b = RepeatBehavior.from(SucceedingBehavior.INSTANCE, 2);
 
     p.addChild(b);
 

package/src/engine/navigation/ecs/components/Path.js

@@ -14,7 +14,7 @@ import { RowFirstTable } from "../../../../core/collection/table/RowFirstTable.j
 import { min2 } from "../../../../core/math/min2.js";
 import { computeNonuniformCatmullRomSplineSample } from "./computeNonuniformCatmullRomSplineSample.js";
 import { InterpolationType } from "./InterpolationType.js";
-import { v3_distance } from "../../../../core/geom/v3_distance.js";
+import { v3_distance } from "../../../../core/geom/vec3/v3_distance.js";
 import {
     line3_computeSegmentPointDistance_sqr
 } from "../../../../core/geom/3d/line/line3_computeSegmentPointDistance_sqr.js";

package/src/engine/physics/fluid/prototype.js

@@ -1,6 +1,6 @@
 import { EngineHarness } from "../../EngineHarness.js";
 import GUIElementSystem from "../../ecs/gui/GUIElementSystem.js";
-import EntityBuilder from "../../ecs/EntityBuilder.js";
+import Entity from "../../ecs/Entity.js";
 import GUIElement from "../../ecs/gui/GUIElement.js";
 import { BehaviorComponent } from "../../intelligence/behavior/ecs/BehaviorComponent.js";
 import { BehaviorSystem } from "../../intelligence/behavior/ecs/BehaviorSystem.js";
@@ -58,7 +58,7 @@ function main(engine) {
     slice_view.setData(field.buffer, field.resolution);
 
 
-    new EntityBuilder()
+    new Entity()
         .add(BehaviorComponent.looping_function(time_delta => {
 
             const t0 = performance.now();
@@ -82,7 +82,7 @@ function main(engine) {
         return `${m}: ${metric_stats}`;
     }).join('\n')).start()
 
-    new EntityBuilder()
+    new Entity()
         .add(GUIElement.fromView(slice_view))
         .build(ecd);
 

package/src/engine/physics/mls-mpm/MLS_MPM.js

@@ -1,105 +1,10 @@
 import { clamp } from "../../../core/math/clamp.js";
-
-/**
- *
- * @param {number[]} a 2d matrix
- * @returns {number}
- */
-function determinant(a) {
-    return a[0] * a[3] - a[1] * a[2]
-}
-
-/**
- *
- * @param {number[]} r
- * @param {number[]} a
- * @param {number[]} b
- */
-function m2_multiply(r, a, b) {
-    const v0 = a[0] * b[0] + a[1] * b[2];
-    const v1 = a[0] * b[1] + a[1] * b[3];
-    const v2 = a[2] * b[0] + a[3] * b[2];
-    const v3 = a[2] * b[1] + a[3] * b[3];
-
-    r[0] = v0;
-    r[1] = v1;
-    r[2] = v2;
-    r[3] = v3;
-}
-
-/**
- * Second argument will be transposed before multiplication
- * @param {number[]} r
- * @param {number[]} a
- * @param {number[]} b
- */
-function m2_multiply_t(r, a, b) {
-    const v0 = a[0] * b[0] + a[1] * b[1];
-    const v1 = a[0] * b[2] + a[1] * b[3];
-    const v2 = a[2] * b[0] + a[3] * b[1];
-    const v3 = a[2] * b[2] + a[3] * b[3];
-
-    r[0] = v0;
-    r[1] = v1;
-    r[2] = v2;
-    r[3] = v3;
-}
-
-/**
- *
- * @param {number[]} r
- * @param {number[]} a
- * @param {number} s
- */
-function m2_multiply_scalar(r, a, s) {
-
-    const v0 = a[0] * s;
-    const v1 = a[1] * s;
-    const v2 = a[2] * s;
-    const v3 = a[3] * s;
-
-    r[0] = v0;
-    r[1] = v1;
-    r[2] = v2;
-    r[3] = v3;
-}
-
-/**
- *
- * @param {number[]} r
- * @param {number[]} a
- * @param {number[]} b
- */
-function m2_add(r, a, b) {
-    const v0 = a[0] + b[0];
-    const v1 = a[1] + b[1];
-    const v2 = a[2] + b[2];
-    const v3 = a[3] + b[3];
-
-    r[0] = v0;
-    r[1] = v1;
-    r[2] = v2;
-    r[3] = v3;
-}
-
-
-/**
- * Trasposes second matrix before subtraction
- * @param {number[]} r
- * @param {number[]} a
- * @param {number[]} b
- */
-function m2_sub_ta(r, a, b) {
-    const v0 = a[0] - b[0];
-    const v1 = a[2] - b[1];
-    const v2 = a[1] - b[2];
-    const v3 = a[3] - b[3];
-
-    r[0] = v0;
-    r[1] = v1;
-    r[2] = v2;
-    r[3] = v3;
-}
+import { m2_multiply } from "../../../core/geom/mat2/m2_multiply.js";
+import { m2_multiply_transposed } from "../../../core/geom/mat2/m2_multiply_transposed.js";
+import { m2_determinant } from "../../../core/geom/mat2/m2_determinant.js";
+import { m2_multiply_scalar } from "../../../core/geom/mat2/m2_multiply_scalar.js";
+import { m2_add } from "../../../core/geom/mat2/m2_add.js";
+import { m2_sub_transposed } from "../../../core/geom/mat2/m2_sub_transposed.js";
 
 
 /**
@@ -354,14 +259,14 @@ export class MLS_MPMSolver {
             // Cauchy stress times dt and inv_dx
             // original taichi: stress = -4*inv_dx*inv_dx*dt*vol*( 2*mu*(p.F-r)*transposed(p.F) + lambda*(J-1)*J )
             // (in taichi matrices are coded transposed)
-            const J = determinant(p.F); // Current volume
+            const J = m2_determinant(p.F); // Current volume
             polar_decomp_noS(r, p.F); // Polar decomp. for fixed corotated model
             const k1 = -4 * inv_dx * inv_dx * dt * vol;
             const k2 = lambda * (J - 1) * J;
 
 
             //compute stress
-            m2_sub_ta(m2_temp0, p.F, r);
+            m2_sub_transposed(m2_temp0, p.F, r);
 
             m2_multiply(m2_temp0, m2_temp0, p.F);
 
@@ -571,11 +476,11 @@ export class MLS_MPMSolver {
                 sig[i + 2 * i] = clamp(sig[i + 2 * i], 1.0 - 2.5e-2, 1.0 + 7.5e-3);
             }
 
-            const oldJ = determinant(F);
+            const oldJ = m2_determinant(F);
             // original taichi: F = svd_u * sig * transposed(svd_v)
             m2_multiply(m2_temp0, svd_u, sig);
-            m2_multiply_t(p.F, m2_temp0, svd_v);
-            const Jp_new = clamp(p.Jp * oldJ / determinant(p.F), 0.6, 20.0);
+            m2_multiply_transposed(p.F, m2_temp0, svd_v);
+            const Jp_new = clamp(p.Jp * oldJ / m2_determinant(p.F), 0.6, 20.0);
             p.Jp = Jp_new;
         }
     }

package/src/engine/reference/v2/Reference.js

@@ -13,7 +13,7 @@ export class Reference {
     #onReleased = new Signal();
 
     /**
-     *
+     * Actual value being held
      * @type {T}
      * @private
      */
@@ -27,7 +27,7 @@ export class Reference {
      */
     #is_bound = false;
 
-    get bound(){
+    get bound() {
         return this.#is_bound;
     }
 
@@ -65,6 +65,10 @@ export class Reference {
         return this.#value;
     }
 
+    /**
+     * Release value being referenced. After this the held value is set to null
+     * This method is idempotent, calling it multiple times is safe
+     */
     release() {
         if (!this.#is_bound) {
             // not bound

package/src/engine/save/storage/JsonStringCodec.js

@@ -3,8 +3,8 @@
  */
 
 
-import { byteArrayToString } from "../../../core/binary/ByteArrayTools.js";
 import { stringify } from "../../../core/json/JsonUtils.js";
+import {byteArrayToString} from "../../../core/binary/byteArrayToString.js";
 
 function JsonStringCodec() {
 }

package/src/engine/save/storage/LocalStorage.js

@@ -6,8 +6,9 @@
 import MsgPackCodec from './MsgPackCodec.js';
 
 import Storage from '../Storage.js';
-import { byteArrayToString, stringToByteArray } from "../../../core/binary/ByteArrayTools.js";
 import { InMemoryLocalStorage } from "./InMemoryLocalStorage.js";
+import {stringToByteArray} from "../../../core/binary/stringToByteArray.js";
+import {byteArrayToString} from "../../../core/binary/byteArrayToString.js";
 
 
 class LocalStorage extends Storage {

package/src/engine/sound/ecs/emitter/SoundEmitter.js

@@ -21,7 +21,7 @@ import { computeStringHash } from "../../../../core/primitives/strings/computeSt
 import { computeHashIntegerArray } from "../../../../core/collection/array/computeHashIntegerArray.js";
 import { computeHashFloat } from "../../../../core/primitives/numbers/computeHashFloat.js";
 import { compareStrings } from "../../../../core/primitives/strings/compareStrings.js";
-import { compareNumbers } from "../../../../core/primitives/numbers/compareNumbers.js";
+import { number_compare_ascending } from "../../../../core/primitives/numbers/number_compare_ascending.js";
 
 /**
  * Convert decibel to percentage volume
@@ -159,36 +159,36 @@ export class SoundEmitter {
             return channel;
         }
 
-        const distanceMin = compareNumbers(this.__distanceMin, other.__distanceMin);
+        const distanceMin = number_compare_ascending(this.__distanceMin, other.__distanceMin);
 
         if (distanceMin !== 0) {
             return distanceMin;
         }
-        const distanceMax = compareNumbers(this.__distanceMax, other.__distanceMax);
+        const distanceMax = number_compare_ascending(this.__distanceMax, other.__distanceMax);
 
         if (distanceMax !== 0) {
             return distanceMax;
         }
 
-        const panningModel = compareNumbers(this.panningModel, other.panningModel);
+        const panningModel = number_compare_ascending(this.panningModel, other.panningModel);
 
         if (panningModel !== 0) {
             return panningModel;
         }
 
-        const attenuation = compareNumbers(this.attenuation, other.attenuation);
+        const attenuation = number_compare_ascending(this.attenuation, other.attenuation);
 
         if (attenuation !== 0) {
             return attenuation;
         }
 
-        const flags = compareNumbers(this.flags, other.flags);
+        const flags = number_compare_ascending(this.flags, other.flags);
 
         if (flags !== 0) {
             return flags;
         }
 
-        const volume = compareNumbers(this.volume.getValue(), other.volume.getValue());
+        const volume = number_compare_ascending(this.volume.getValue(), other.volume.getValue());
 
         if (volume !== 0) {
             return volume;

package/src/engine/sound/ecs/emitter/SoundTrack.js

@@ -5,7 +5,7 @@ import { computeStringHash } from "../../../../core/primitives/strings/computeSt
 import { computeHashIntegerArray } from "../../../../core/collection/array/computeHashIntegerArray.js";
 import { computeHashFloat } from "../../../../core/primitives/numbers/computeHashFloat.js";
 import { compareStrings } from "../../../../core/primitives/strings/compareStrings.js";
-import { compareNumbers } from "../../../../core/primitives/numbers/compareNumbers.js";
+import { number_compare_ascending } from "../../../../core/primitives/numbers/number_compare_ascending.js";
 
 const DEFAULT_FLAGS = SoundTrackFlags.StartWhenReady;
 
@@ -120,8 +120,8 @@ export class SoundTrack {
         // Make the sound source use the buffer and start playing it.
         nodes.source.buffer = this.#buffer;
 
-        nodes.source.onended = ()=> {
-            if(!looping){
+        nodes.source.onended = () => {
+            if (!looping) {
                 this.clearFlag(SoundTrackFlags.Playing);
                 this.on.ended.send1(this);
             }
@@ -167,7 +167,7 @@ export class SoundTrack {
             return url;
         }
 
-        const time = compareNumbers(this.time, other.time);
+        const time = number_compare_ascending(this.time, other.time);
 
         if (time !== 0) {
             return time;
@@ -179,13 +179,13 @@ export class SoundTrack {
             return channel;
         }
 
-        const volume = compareNumbers(this.__volume, other.__volume);
+        const volume = number_compare_ascending(this.__volume, other.__volume);
 
         if (volume !== 0) {
             return volume;
         }
 
-        const flags = compareNumbers(this.flags, other.flags);
+        const flags = number_compare_ascending(this.flags, other.flags);
 
         if (flags !== 0) {
             return flags;

package/src/engine/ui/GUIEngine.js

@@ -9,7 +9,7 @@ import { playTrackRealTime } from "../animation/playTrackRealTime.js";
 import GUIElement from '../ecs/gui/GUIElement.js';
 import ViewportPosition from '../ecs/gui/position/ViewportPosition.js';
 
-import EntityBuilder from '../ecs/EntityBuilder.js';
+import Entity from '../ecs/Entity.js';
 
 import ConfirmationDialogView from '../../view/elements/ConfirmationDialogView.js';
 import SimpleWindowView from '../../view/elements/SimpleWindow.js';
@@ -127,10 +127,10 @@ function GUIEngine() {
  * @param {View} content
  * @param {string} title
  * @param {View} [wrapper]
- * @returns {EntityBuilder}
+ * @returns {Entity}
  */
 GUIEngine.prototype.openWindow = function ({ closeable, content, title, wrapper }) {
-    const entityBuilder = new EntityBuilder();
+    const entityBuilder = new Entity();
 
     function closeAction() {
         entityBuilder.destroy();
@@ -219,7 +219,7 @@ GUIEngine.prototype.createModal = function ({ content, title, priority = 0 }) {
             lifecycle.makeDestroyed();
         });
 
-        const builder = new EntityBuilder();
+        const builder = new Entity();
 
         builder.add(SerializationMetadata.Transient);
         builder.add(GUIElement.fromView(overlay));

package/src/engine/ui/notification/NotificationManager.js

@@ -2,7 +2,7 @@ import NotificationLog from "../../notify/NotificationLog.js";
 import { assert } from "../../../core/assert.js";
 import { noop } from "../../../core/function/Functions.js";
 import List from "../../../core/collection/list/List.js";
-import EntityBuilder from "../../ecs/EntityBuilder.js";
+import Entity from "../../ecs/Entity.js";
 import GUIElement from "../../ecs/gui/GUIElement.js";
 import { SerializationMetadata } from "../../ecs/components/SerializationMetadata.js";
 import { EventType } from "../../ecs/EntityManager.js";
@@ -148,7 +148,7 @@ export class NotificationManager {
     addEmitterDisplay(channel, viewEmitter, grouping = null) {
         /**
          *
-         * @type {Map<View, EntityBuilder>}
+         * @type {Map<View, Entity>}
          */
         const views = new Map();
 
@@ -196,7 +196,7 @@ export class NotificationManager {
 
                 view.addClass(managedNotificationChannelClass);
 
-                const eb = new EntityBuilder();
+                const eb = new Entity();
 
                 //prevent serialization of the notification
                 eb.add(SerializationMetadata.Transient);

package/src/generation/filtering/numeric/complex/CellFilterAngleToNormal.js

@@ -1,7 +1,7 @@
 import { CellFilter } from "../../CellFilter.js";
 import Vector3 from "../../../../core/geom/Vector3.js";
 import { assert } from "../../../../core/assert.js";
-import { v3_angle_between } from "../../../../core/geom/v3_angle_between.js";
+import { v3_angle_between } from "../../../../core/geom/vec3/v3_angle_between.js";
 
 /**
  * Distance from the reference point where support points will be sampled to compute derivative

package/src/generation/grid/generation/road/GridTaskGenerateRoads.js

@@ -1,5 +1,3 @@
-import { inverseLerp } from "../../../../core/math/inverseLerp.js";
-import { lerp } from "../../../../core/math/lerp.js";
 import { seededRandom } from "../../../../core/math/random/seededRandom.js";
 import { GridTaskGenerator } from "../../GridTaskGenerator.js";
 import TaskGroup from "../../../../core/process/task/TaskGroup.js";
@@ -24,6 +22,7 @@ import { MirGridLayers } from "../../../../../samples/generation/grid/MirGridLay
 import { actionTask } from "../../../../core/process/task/util/actionTask.js";
 import { countTask } from "../../../../core/process/task/util/countTask.js";
 import { groupArrayBy } from "../../../../core/collection/array/groupArrayBy.js";
+import { remap } from "../../../../core/math/remap.js";
 
 const NODE_TYPE_ROAD_CONNECTOR = 'Road Connector';
 
@@ -427,8 +426,7 @@ function drawPath(path, actions, traversable, grid) {
     for (let i = 0; i < n; i++) {
         const index = pathIndices[i];
 
-        const f = inverseLerp(0, n, i);
-        const thickness = lerp(sourceThickness, targetThickness, f);
+        const thickness = remap(0, n, sourceThickness, targetThickness, i);
 
         const thickness_0 = Math.floor(thickness / 2);
         const thickness_1 = Math.ceil(thickness / 2);

package/src/generation/markers/debug/visualizeMarkers.js

@@ -8,7 +8,7 @@ import {
     MeshLambertMaterial,
     TetrahedronBufferGeometry
 } from "three";
-import EntityBuilder from "../../../engine/ecs/EntityBuilder.js";
+import Entity from "../../../engine/ecs/Entity.js";
 import Renderable from "../../../engine/ecs/renderable/Renderable.js";
 import { Transform } from "../../../engine/ecs/transform/Transform.js";
 import LabelView from "../../../view/common/LabelView.js";
@@ -140,7 +140,7 @@ export function visualizeMarkers({
 
         g.add(mark_size);
 
-        const entityBuilder = new EntityBuilder();
+        const entityBuilder = new Entity();
 
         const renderable = new Renderable(g);
         renderable.computeBoundsFromObject();

package/src/generation/markers/prototypeGridCellActionPlaceMarker.js

@@ -1,7 +1,7 @@
 import { EngineHarness } from "../../engine/EngineHarness.js";
 import { GridCellActionPlaceMarker } from "./GridCellActionPlaceMarker.js";
 import { GridData } from "../grid/GridData.js";
-import EntityBuilder from "../../engine/ecs/EntityBuilder.js";
+import Entity from "../../engine/ecs/Entity.js";
 import Mesh from "../../engine/graphics/ecs/mesh/Mesh.js";
 import { MeshSystem } from "../../engine/graphics/ecs/mesh/MeshSystem.js";
 import { GameAssetType } from "../../engine/asset/GameAssetType.js";
@@ -166,7 +166,7 @@ async function main(engine) {
 
     function build_node(node, url) {
 
-        new EntityBuilder()
+        new Entity()
             .add(node.transform)
             .add(Mesh.fromJSON({
 

package/src/generation/placement/action/random/weighted/CellActionSelectWeightedRandom.js

@@ -1,8 +1,8 @@
 import { seededRandom } from "../../../../../core/math/random/seededRandom.js";
 import { GridCellAction } from "../../GridCellAction.js";
-import { compareNumbers } from "../../../../../core/primitives/numbers/compareNumbers.js";
 import { assert } from "../../../../../core/assert.js";
 import { binarySearchHighIndex } from "../../../../../core/collection/array/binarySearchHighIndex.js";
+import { number_compare_ascending } from "../../../../../core/primitives/numbers/number_compare_ascending.js";
 
 /**
  *
@@ -111,7 +111,7 @@ export class CellActionSelectWeightedRandom extends GridCellAction {
 
         const targetWeight = this.__random() * totalWeight;
 
-        const index = binarySearchHighIndex(evaluatedWeights, targetWeight, compareNumbers, 0, n - 1);
+        const index = binarySearchHighIndex(evaluatedWeights, targetWeight, number_compare_ascending, 0, n - 1);
 
         const targetElement = elements[index];
 

package/src/generation/theme/ThemeEngine.js

@@ -5,7 +5,6 @@ import { TerrainLayerRuleAggregator } from "./TerrainLayerRuleAggregator.js";
 import { Sampler2D } from "../../engine/graphics/texture/sampler/Sampler2D.js";
 import Task from "../../core/process/task/Task.js";
 import { TaskSignal } from "../../core/process/task/TaskSignal.js";
-import { compareNumbers } from "../../core/primitives/numbers/compareNumbers.js";
 import TaskGroup from "../../core/process/task/TaskGroup.js";
 import Future from "../../core/process/Future.js";
 import { optimizeIndividualMeshesEntitiesToInstances } from "../../engine/ecs/foliage/ecs/InstancedMeshUtils.js";
@@ -20,6 +19,7 @@ import { actionTask } from "../../core/process/task/util/actionTask.js";
 import { countTask } from "../../core/process/task/util/countTask.js";
 import { emptyTask } from "../../core/process/task/util/emptyTask.js";
 import { futureTask } from "../../core/process/task/util/futureTask.js";
+import { number_compare_ascending } from "../../core/primitives/numbers/number_compare_ascending.js";
 
 /**
  *
@@ -431,7 +431,7 @@ export class ThemeEngine {
             //select a theme
             const t = randomFloatBetween(random, 0, influenceSum);
 
-            const themeIndex = binarySearchLowIndex(themeInfluence, t, compareNumbers);
+            const themeIndex = binarySearchLowIndex(themeInfluence, t, number_compare_ascending);
 
             const themeArea = themeAreas[themeIndex];
 

package/src/generation/theme/ThemeEngine.spec.js

@@ -0,0 +1,7 @@
+import { ThemeEngine } from "./ThemeEngine.js";
+
+test("constructor does not throw", () => {
+
+    new ThemeEngine();
+
+});

package/src/view/View.js

@@ -10,7 +10,8 @@ import Signal from "../core/events/signal/Signal.js";
 import { SignalBinding } from "../core/events/signal/SignalBinding.js";
 import { assert } from "../core/assert.js";
 import Vector1 from "../core/geom/Vector1.js";
-import { m3_cm_compose_transform } from "./m3_cm_compose_transform.js";
+
+import { m3_cm_compose_transform } from "../core/geom/mat3/m3_cm_compose_transform.js";
 
 
 const scratch_m3_0 = new Float32Array(9);
@@ -362,10 +363,10 @@ class View {
      * @returns {View}
      */
     addChild(child) {
-        assert.notEqual(child, undefined, 'child is undefined');
-        assert.notEqual(child, null, 'child is null');
-        assert.ok(typeof child, 'object', `child must be an object, isntead was '${typeof child}'`);
-        assert.ok(child instanceof View, 'child is not an instance of View');
+        assert.defined(child, 'child');
+        assert.notNull(child, 'child');
+        assert.isInstanceOf(child, View, 'child');
+        assert.equal(child.isLinked, false, 'child is already linked somewhere');
 
         child.parent = this;
 
@@ -425,18 +426,25 @@ class View {
     /**
      *
      * @param {View} child
+     * @returns {boolean}
      */
     removeChild(child) {
-        const i = this.children.indexOf(child);
-        if (i !== -1) {
-            this.children.splice(i, 1);
-            this.el.removeChild(child.el);
-            child.unlink();
+        const children = this.children;
 
-            child.parent = null;
-        } else {
-            console.warn('Child not found. this:', this, 'child:', child);
+        const i = children.indexOf(child);
+
+        if (i === -1) {
+            //console.warn('Child not found. this:', this, 'child:', child);
+            return false;
         }
+
+        children.splice(i, 1);
+        this.el.removeChild(child.el);
+        child.unlink();
+
+        child.parent = null;
+
+        return true;
     }
 
     /**

package/src/view/elements/ColorPickerView.js

@@ -2,8 +2,8 @@ import GuiControl from "../controller/controls/GuiControl.js";
 import { GaugeView } from "../../../editor/view/ecs/components/color/GaugeView.js";
 import Vector1 from "../../core/geom/Vector1.js";
 import { drawCheckers } from "../../../editor/view/ecs/components/particles/ColorParameterLUTController.js";
-import { hsv2rgb } from "../../core/color/hsv2rgb.js";
-import { rgb2hsv } from "../../core/color/rgb2hsv.js";
+import { hsv2rgb } from "../../core/color/hsv/hsv2rgb.js";
+import { rgb2hsv } from "../../core/color/hsv/rgb2hsv.js";
 
 
 export class ColorPickerView extends GuiControl {