@vellumai/assistant 0.8.6 → 0.8.7-dev.202606052118.34cd356

package/src/__tests__/openai-provider.test.ts

@@ -105,7 +105,10 @@ mock.module("openai", () => ({
 import { FireworksProvider } from "../providers/fireworks/client.js";
 import { MinimaxProvider } from "../providers/minimax/client.js";
 import { OllamaProvider } from "../providers/ollama/client.js";
-import { OpenAIChatCompletionsProvider } from "../providers/openai/chat-completions-provider.js";
+import {
+  EMPTY_ASSISTANT_TURN_PLACEHOLDER,
+  OpenAIChatCompletionsProvider,
+} from "../providers/openai/chat-completions-provider.js";
 import { OpenAIProvider } from "../providers/openai/client.js";
 import { OpenRouterProvider } from "../providers/openrouter/client.js";
 
@@ -379,8 +382,6 @@ describe("OpenAIProvider", () => {
     const events: ProviderEvent[] = [];
     await provider.sendMessage(
       [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-      undefined,
-      undefined,
       { onEvent: (e) => events.push(e) },
     );
 
@@ -422,7 +423,7 @@ describe("OpenAIProvider", () => {
     ];
 
     const events: ProviderEvent[] = [];
-    await provider.sendMessage([userMsg("Hi")], undefined, undefined, {
+    await provider.sendMessage([userMsg("Hi")], {
       onEvent: (e) => events.push(e),
     });
 
@@ -470,14 +471,9 @@ describe("OpenAIProvider", () => {
     ];
 
     const events: ProviderEvent[] = [];
-    const result = await provider.sendMessage(
-      [userMsg("Hi")],
-      undefined,
-      undefined,
-      {
-        onEvent: (e) => events.push(e),
-      },
-    );
+    const result = await provider.sendMessage([userMsg("Hi")], {
+      onEvent: (e) => events.push(e),
+    });
 
     expect(result.content).toHaveLength(2);
     expect(result.content[0]).toEqual({
@@ -504,14 +500,9 @@ describe("OpenAIProvider", () => {
     ];
 
     const events: ProviderEvent[] = [];
-    const result = await provider.sendMessage(
-      [userMsg("Hi")],
-      undefined,
-      undefined,
-      {
-        onEvent: (e) => events.push(e),
-      },
-    );
+    const result = await provider.sendMessage([userMsg("Hi")], {
+      onEvent: (e) => events.push(e),
+    });
 
     expect(result.content).toHaveLength(2);
     expect(result.content[0]).toEqual({
@@ -544,8 +535,7 @@ describe("OpenAIProvider", () => {
 
     await provider.sendMessage(
       [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-      undefined,
-      "You are a helpful assistant.",
+      { systemPrompt: "You are a helpful assistant." },
     );
 
     const messages = lastCreateParams!.messages as Array<
@@ -578,7 +568,7 @@ describe("OpenAIProvider", () => {
 
     await provider.sendMessage(
       [{ role: "user", content: [{ type: "text", text: "Read /tmp/test" }] }],
-      tools,
+      { tools: tools },
     );
 
     const sentTools = lastCreateParams!.tools as Array<Record<string, unknown>>;
@@ -903,8 +893,6 @@ describe("OpenAIProvider", () => {
 
     await provider.sendMessage(
       [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-      undefined,
-      undefined,
       { config: { max_tokens: 64000 } },
     );
 
@@ -947,8 +935,6 @@ describe("OpenAIProvider", () => {
 
     await provider.sendMessage(
       [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-      undefined,
-      undefined,
       { signal: controller.signal },
     );
 
@@ -967,8 +953,6 @@ describe("OpenAIProvider", () => {
 
     await provider.sendMessage(
       [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-      undefined,
-      undefined,
       { signal: controller.signal },
     );
 
@@ -1024,8 +1008,6 @@ describe("OpenAIProvider", () => {
     try {
       await provider.sendMessage(
         [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-        undefined,
-        undefined,
         { signal: controller.signal },
       );
       expect(true).toBe(false); // should not reach
@@ -1044,8 +1026,6 @@ describe("OpenAIProvider", () => {
     try {
       await provider.sendMessage(
         [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-        undefined,
-        undefined,
         { signal: controller.signal },
       );
       expect(true).toBe(false);
@@ -1063,8 +1043,6 @@ describe("OpenAIProvider", () => {
     try {
       await provider.sendMessage(
         [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
-        undefined,
-        undefined,
         { signal: controller.signal },
       );
       expect(true).toBe(false);
@@ -1412,7 +1390,7 @@ describe("effort config passthrough", () => {
   ): Provider {
     return {
       name,
-      async sendMessage(_messages, _tools, _systemPrompt, options) {
+      async sendMessage(_messages: Message[], options?: SendMessageOptions) {
         onCall(options);
         return makeResponse();
       },
@@ -1426,7 +1404,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: { effort: "high" },
     });
 
@@ -1441,7 +1419,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: { effort: "medium" },
     });
 
@@ -1456,7 +1434,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: { effort: "low" },
     });
 
@@ -1471,7 +1449,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: { effort: "high" },
     });
 
@@ -1486,7 +1464,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: { effort: "high" },
     });
 
@@ -1501,7 +1479,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: {
         thinking: { enabled: true, budgetTokens: 10000 },
         effort: "high",
@@ -1520,7 +1498,7 @@ describe("effort config passthrough", () => {
     });
     const retry = new RetryProvider(inner);
 
-    await retry.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await retry.sendMessage(DUMMY_MESSAGES, {
       config: {
         thinking: { type: "adaptive" },
       },
@@ -1546,7 +1524,7 @@ describe("OpenRouterProvider reasoning", () => {
 
   test("sends reasoning.enabled=true with default detailed summary when thinking config is present", async () => {
     const provider = new OpenRouterProvider("or-key", "x-ai/grok-4");
-    await provider.sendMessage([userMsg("hi")], undefined, undefined, {
+    await provider.sendMessage([userMsg("hi")], {
       config: { thinking: { type: "adaptive" } },
     });
 
@@ -1559,7 +1537,7 @@ describe("OpenRouterProvider reasoning", () => {
 
   test("omits reasoning when thinking is explicitly disabled", async () => {
     const provider = new OpenRouterProvider("or-key", "x-ai/grok-4");
-    await provider.sendMessage([userMsg("hi")], undefined, undefined, {
+    await provider.sendMessage([userMsg("hi")], {
       config: { thinking: { type: "disabled" } },
     });
 
@@ -1569,7 +1547,7 @@ describe("OpenRouterProvider reasoning", () => {
 
   test("omits reasoning when thinking config is absent", async () => {
     const provider = new OpenRouterProvider("or-key", "x-ai/grok-4");
-    await provider.sendMessage([userMsg("hi")], undefined, undefined, {
+    await provider.sendMessage([userMsg("hi")], {
       config: {},
     });
 
@@ -1587,7 +1565,7 @@ describe("OpenRouterProvider reasoning", () => {
 
   test("sends OpenRouter app-attribution headers on OpenAI-compatible requests", async () => {
     const provider = new OpenRouterProvider("or-key", "x-ai/grok-4");
-    await provider.sendMessage([userMsg("hi")], undefined, undefined, {
+    await provider.sendMessage([userMsg("hi")], {
       config: {
         usageAttributionHeaders: {
           "Vellum-Organization-Id": "org-123",
@@ -1609,12 +1587,39 @@ describe("OpenRouterProvider reasoning", () => {
     expect(lastCreateParams).not.toHaveProperty("usageAttributionHeaders");
   });
 
+  test("backfills placeholder content for a reasoning-only assistant turn", async () => {
+    const provider = new OpenRouterProvider("or-key", "deepseek/deepseek-chat");
+    await provider.sendMessage([
+      userMsg("question"),
+      {
+        role: "assistant",
+        content: [
+          { type: "thinking", thinking: "truncated reasoning", signature: "" },
+        ],
+      },
+    ]);
+
+    const sent = lastCreateParams!.messages as Array<{
+      role: string;
+      content: string | null;
+      reasoning?: string;
+      tool_calls?: unknown;
+    }>;
+    const assistantMsg = sent.find((m) => m.role === "assistant")!;
+    // DeepSeek via OpenRouter rejects an assistant message with neither content
+    // nor tool_calls, so the reasoning-only turn is backfilled with the sentinel
+    // while the reasoning itself travels in the separate `reasoning` field.
+    expect(assistantMsg.content).toBe(EMPTY_ASSISTANT_TURN_PLACEHOLDER);
+    expect(assistantMsg.tool_calls).toBeUndefined();
+    expect(assistantMsg.reasoning).toBe("truncated reasoning");
+  });
+
   test("RetryProvider + OpenRouterProvider enables thinking end-to-end", async () => {
     const provider = new OpenRouterProvider("or-key", "x-ai/grok-4");
     const retry = new RetryProvider(provider);
 
     // thinking enabled at loop-level → config.thinking set
-    await retry.sendMessage([userMsg("hi")], undefined, undefined, {
+    await retry.sendMessage([userMsg("hi")], {
       config: { thinking: { type: "adaptive" } },
     });
     expect(lastCreateParams!.reasoning).toEqual({
@@ -1627,7 +1632,7 @@ describe("OpenRouterProvider reasoning", () => {
     const provider = new OpenRouterProvider("or-key", "x-ai/grok-4");
     const retry = new RetryProvider(provider);
 
-    await retry.sendMessage([userMsg("hi")], undefined, undefined, {
+    await retry.sendMessage([userMsg("hi")], {
       config: { thinking: { type: "disabled" } },
     });
     expect(lastCreateParams!.reasoning).toBeUndefined();
@@ -1635,7 +1640,7 @@ describe("OpenRouterProvider reasoning", () => {
 
   test("nests effort under reasoning and omits top-level reasoning_effort", async () => {
     const provider = new OpenRouterProvider("or-key", "moonshotai/kimi-k2.6");
-    await provider.sendMessage([userMsg("hi")], undefined, undefined, {
+    await provider.sendMessage([userMsg("hi")], {
       config: { thinking: { enabled: true }, effort: "max" },
     });
 
@@ -1709,7 +1714,8 @@ describe("OpenAIProvider reasoning_effort", () => {
   });
 
   test('effort: "low" maps to reasoning_effort: "low"', async () => {
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "low" },
     });
     expect(lastCreateParams).toBeTruthy();
@@ -1717,35 +1723,40 @@ describe("OpenAIProvider reasoning_effort", () => {
   });
 
   test('effort: "medium" maps to reasoning_effort: "medium"', async () => {
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "medium" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("medium");
   });
 
   test('effort: "high" maps to reasoning_effort: "high"', async () => {
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "high" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("high");
   });
 
   test('effort: "max" maps to reasoning_effort: "xhigh"', async () => {
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "max" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("xhigh");
   });
 
   test('effort: "xhigh" maps to reasoning_effort: "xhigh"', async () => {
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "xhigh" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("xhigh");
   });
 
   test("no effort config means no reasoning_effort in params", async () => {
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: {},
     });
     expect(lastCreateParams).toBeTruthy();
@@ -1756,7 +1767,8 @@ describe("OpenAIProvider reasoning_effort", () => {
     // OpenAI defaults `reasoning_effort` to "medium" when the field is
     // omitted, so the user's opt-out is only honored when we send the
     // explicit "none" value on the wire.
-    await provider.sendMessage([userMsg("hi")], undefined, "system", {
+    await provider.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "none" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("none");
@@ -1766,7 +1778,8 @@ describe("OpenAIProvider reasoning_effort", () => {
     const providerWithExtra = new OpenAIProvider("test-key", "gpt-5", {
       extraCreateParams: { reasoning_effort: "medium" },
     });
-    await providerWithExtra.sendMessage([userMsg("hi")], undefined, "system", {
+    await providerWithExtra.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: {},
     });
     expect(lastCreateParams!.reasoning_effort).toBe("medium");
@@ -1776,15 +1789,18 @@ describe("OpenAIProvider reasoning_effort", () => {
     const capped = new OpenAIProvider("test-key", "gpt-5", {
       maxReasoningEffort: "high",
     });
-    await capped.sendMessage([userMsg("hi")], undefined, "system", {
+    await capped.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "xhigh" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("high");
-    await capped.sendMessage([userMsg("hi")], undefined, "system", {
+    await capped.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "max" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("high");
-    await capped.sendMessage([userMsg("hi")], undefined, "system", {
+    await capped.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "medium" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("medium");
@@ -1794,11 +1810,13 @@ describe("OpenAIProvider reasoning_effort", () => {
     const uncapped = new OpenAIProvider("test-key", "gpt-5", {
       maxReasoningEffort: "max",
     });
-    await uncapped.sendMessage([userMsg("hi")], undefined, "system", {
+    await uncapped.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "max" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("max");
-    await uncapped.sendMessage([userMsg("hi")], undefined, "system", {
+    await uncapped.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "xhigh" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("xhigh");
@@ -1816,7 +1834,8 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/deepseek-v4-pro",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "max" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("max");
@@ -1827,7 +1846,8 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/deepseek-v4-pro",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "xhigh" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("xhigh");
@@ -1838,11 +1858,13 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/kimi-k2p6",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "xhigh" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("high");
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "max" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("high");
@@ -1853,7 +1875,8 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/some-future-model",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "max" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("high");
@@ -1864,7 +1887,8 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/deepseek-v4-pro",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "medium" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("medium");
@@ -1875,7 +1899,8 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/kimi-k2p6",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: { effort: "none" },
     });
     expect(lastCreateParams!.reasoning_effort).toBe("none");
@@ -1886,7 +1911,8 @@ describe("FireworksProvider reasoning_effort ceiling", () => {
       "fw-key",
       "accounts/fireworks/models/kimi-k2p6",
     );
-    await fw.sendMessage([userMsg("hi")], undefined, "system", {
+    await fw.sendMessage([userMsg("hi")], {
+      systemPrompt: "system",
       config: {
         effort: "max",
         model: "accounts/fireworks/models/deepseek-v4-pro",