@vellumai/assistant 0.8.6 → 0.8.7-dev.202606052118.34cd356

package/src/messaging/style-analyzer.ts

@@ -49,7 +49,7 @@ Also identify recurring contacts (people appearing in 3+ messages) and note how
 
 You MUST respond using the \`store_style_analysis\` tool. Do not respond with text.`;
 
-const storeStyleAnalysisTool: ToolDefinition = {
+const storeStyleAnalysisTool = {
   name: "store_style_analysis",
   description:
     "Store extracted writing style patterns and relationship observations",
@@ -94,7 +94,7 @@ const storeStyleAnalysisTool: ToolDefinition = {
     },
     required: ["style_patterns"],
   },
-};
+} satisfies ToolDefinition;
 
 /**
  * Build a text corpus from provider messages for LLM analysis.
@@ -143,15 +143,12 @@ export async function extractStylePatterns(
     },
   ];
 
-  const response = await provider.sendMessage(
-    promptMessages,
-    [storeStyleAnalysisTool],
-    STYLE_EXTRACTION_SYSTEM_PROMPT,
-    {
-      signal: AbortSignal.timeout(30_000),
-      config: { callSite: "styleAnalyzer" },
-    },
-  );
+  const response = await provider.sendMessage(promptMessages, {
+    tools: [storeStyleAnalysisTool],
+    systemPrompt: STYLE_EXTRACTION_SYSTEM_PROMPT,
+    signal: AbortSignal.timeout(30_000),
+    config: { callSite: "styleAnalyzer" },
+  });
 
   const toolBlock = response.content.find((b) => b.type === "tool_use");
   if (!toolBlock || toolBlock.type !== "tool_use") {

package/src/notifications/conversation-pairing.ts

@@ -119,14 +119,14 @@ export async function pairDeliveryWithConversation(
     // Passive vellum notifications surface via the home feed alone and link
     // back to the originating conversation via `signal.sourceContextId`.
     // Materializing a fresh per-notification conversation just to host the
-    // seed message leaves a graveyard entry in the sidebar; skip it unless
-    // the producer opted in via `requiresConversation` or the decision engine
-    // requested explicit reuse of a target conversation.
-    if (
-      strategy === "start_new_conversation" &&
-      !signal.requiresConversation &&
-      conversationAction?.action !== "reuse_existing"
-    ) {
+    // seed message leaves a graveyard entry in the sidebar; skip it
+    // unconditionally when the producer did not opt in via
+    // `requiresConversation`. The decision engine's `reuse_existing` hint is
+    // also ignored here: even a successful reuse would append a seed message
+    // to a conversation that the user didn't ask for, and a failed reuse
+    // (stale target / source mismatch) falls through to `createConversation`
+    // — producing exactly the graveyard entry we want to avoid.
+    if (strategy === "start_new_conversation" && !signal.requiresConversation) {
       return {
         conversationId: null,
         messageId: null,
@@ -166,7 +166,6 @@ export async function pairDeliveryWithConversation(
           existing.id,
           "assistant",
           messageContent,
-          undefined,
           { skipIndexing: true },
         );
 
@@ -225,7 +224,6 @@ export async function pairDeliveryWithConversation(
         conversation.id,
         "assistant",
         messageContent,
-        undefined,
         { skipIndexing: true },
       );
 
@@ -283,7 +281,6 @@ export async function pairDeliveryWithConversation(
             inboundConversation.id,
             "assistant",
             messageContent,
-            undefined,
             { skipIndexing: true },
           );
 
@@ -332,7 +329,6 @@ export async function pairDeliveryWithConversation(
             boundConversation.id,
             "assistant",
             messageContent,
-            undefined,
             { skipIndexing: true },
           );
 
@@ -396,7 +392,6 @@ export async function pairDeliveryWithConversation(
       conversation.id,
       "assistant",
       messageContent,
-      undefined,
       { skipIndexing: true },
     );
 

package/src/notifications/decision-engine.ts

@@ -149,8 +149,8 @@ function buildSystemPrompt(
     `  - Avoid meta-send phrasing (e.g. "I'd like to send a notification", "May I go ahead with that?"). Write the recipient-facing message directly.`,
     `  - Avoid intermediary-instruction phrasing like "consider telling the guardian", "ask the recipient to", or "the assistant should remind them". Rewrite it as final copy the recipient can act on directly.`,
     `  - For telegram: 1-2 concise sentences.`,
-    `- \`conversationSeedMessage\` is the opening message in the internal notification conversation — it can be richer and more contextual.`,
-    `  - For vellum (desktop): 2-4 short sentences with useful context and clear next step if action is required.`,
+    `- \`conversationSeedMessage\` is the opening message in the internal notification conversation and also the expanded detail shown in the home feed. It should be richer and more contextual than the popup body.`,
+    `  - For vellum (desktop): use structured markdown for readability. Break content into bullet points, numbered lists, or short sections with **bold** labels. Avoid long unbroken paragraphs — scan-friendly formatting is preferred.`,
     `  - Never dump raw JSON. Include only human-readable context.`,
     ``,
     `Conversation reuse guidelines:`,
@@ -838,7 +838,10 @@ export async function evaluateSignal(
       selectedChannels,
       reasoningSummary: "assistant_tool pass-through",
       renderedCopy: Object.fromEntries(
-        availableChannels.map((ch) => [ch, { title, body }]),
+        availableChannels.map((ch) => [
+          ch,
+          { title, body, conversationSeedMessage: body },
+        ]),
       ) as NotificationDecision["renderedCopy"],
       conversationActions: Object.fromEntries(
         availableChannels.map((ch) => [ch, { action: "start_new" as const }]),
@@ -957,22 +960,19 @@ async function classifyWithLLM(
   const tool = buildDecisionTool(availableChannels);
 
   try {
-    const response = await provider.sendMessage(
-      [userMessage(prompt)],
-      [tool],
+    const response = await provider.sendMessage([userMessage(prompt)], {
+      tools: [tool],
       systemPrompt,
-      {
-        config: {
-          callSite: "notificationDecision",
-          max_tokens: 2048,
-          tool_choice: {
-            type: "tool" as const,
-            name: "record_notification_decision",
-          },
+      config: {
+        callSite: "notificationDecision",
+        max_tokens: 2048,
+        tool_choice: {
+          type: "tool" as const,
+          name: "record_notification_decision",
         },
-        signal: abortSignal,
       },
-    );
+      signal: abortSignal,
+    });
     cleanup();
 
     const toolBlock = extractToolUse(response);

package/src/notifications/home-feed-side-effect.ts

@@ -21,6 +21,7 @@ import { appendFeedItem } from "../home/feed-writer.js";
 import { getConversation } from "../memory/conversation-crud.js";
 import { isBackgroundConversationType } from "../memory/conversation-types.js";
 import { getLogger } from "../util/logger.js";
+import { isConversationSeedSane } from "./conversation-seed-composer.js";
 import type { NotificationSignal } from "./signal.js";
 import type { NotificationDecision, RenderedChannelCopy } from "./types.js";
 
@@ -77,8 +78,18 @@ export async function writeHomeFeedItemForSignal(
   // against `summary` in the row. Leave undefined when absent; renderers
   // fall back to `summary`.
   const resolvedTitle = payloadTitle?.trim() || undefined;
+  // Prefer conversationSeedMessage over body for the home feed: the seed
+  // message is richer and may contain structured markdown (lists, headers,
+  // bold) that the detail panel renders. The popup-oriented `body` is
+  // intentionally short (≤ 2 sentences) and loses formatting.
+  const seedCandidate = renderedCopy?.conversationSeedMessage;
   const resolvedSummary =
-    renderedCopy?.body?.trim() || payloadBody?.trim() || "";
+    (isConversationSeedSane(seedCandidate)
+      ? seedCandidate.trim()
+      : undefined) ||
+    renderedCopy?.body?.trim() ||
+    payloadBody?.trim() ||
+    "";
   if (!resolvedSummary) {
     log.warn(
       { signalId: signal.signalId, sourceEventName: signal.sourceEventName },

package/src/notifications/preference-extractor.ts

@@ -148,22 +148,19 @@ export async function extractPreferences(
   const { signal, cleanup } = createTimeout(EXTRACTION_TIMEOUT_MS);
 
   try {
-    const response = await provider.sendMessage(
-      [userMessage(message)],
-      [EXTRACTION_TOOL],
-      SYSTEM_PROMPT,
-      {
-        config: {
-          callSite: "preferenceExtraction",
-          max_tokens: 1024,
-          tool_choice: {
-            type: "tool" as const,
-            name: "extract_notification_preferences",
-          },
+    const response = await provider.sendMessage([userMessage(message)], {
+      tools: [EXTRACTION_TOOL],
+      systemPrompt: SYSTEM_PROMPT,
+      config: {
+        callSite: "preferenceExtraction",
+        max_tokens: 1024,
+        tool_choice: {
+          type: "tool" as const,
+          name: "extract_notification_preferences",
         },
-        signal,
       },
-    );
+      signal,
+    });
     cleanup();
 
     const toolBlock = extractToolUse(response);

package/src/permissions/prompter.ts

@@ -104,27 +104,31 @@ export class PermissionPrompter {
       pendingInteractions.register(requestId, {
         conversationId: conversationId ?? "",
         kind: "confirmation",
-          confirmationDetails: {
-            toolName,
-            input: redactSensitiveFields(input),
-            riskLevel,
-            executionTarget,
-            allowlistOptions: allowlistOptions.map((o) => ({
-              label: o.label,
-              description: o.description,
-              pattern: o.pattern,
-            })),
-            scopeOptions: scopeOptions.map((o) => ({
-              label: o.label,
-              scope: o.scope,
-            })),
-            persistentDecisionsAllowed: persistentDecisionsAllowed ?? true,
-          },
-          rpcResolve: resolve as (value: unknown) => void,
-          rpcReject: reject,
-          timer,
-          toolUseId,
-        });
+        confirmationDetails: {
+          toolName,
+          input: redactSensitiveFields(input),
+          riskLevel,
+          executionTarget,
+          allowlistOptions: allowlistOptions.map((o) => ({
+            label: o.label,
+            description: o.description,
+            pattern: o.pattern,
+          })),
+          scopeOptions: scopeOptions.map((o) => ({
+            label: o.label,
+            scope: o.scope,
+          })),
+          directoryScopeOptions: directoryScopeOptions?.map((o) => ({
+            label: o.label,
+            scope: o.scope,
+          })),
+          persistentDecisionsAllowed: persistentDecisionsAllowed ?? true,
+        },
+        rpcResolve: resolve as (value: unknown) => void,
+        rpcReject: reject,
+        timer,
+        toolUseId,
+      });
       this.ownedIds.add(requestId);
 
       if (signal) {
@@ -156,7 +160,10 @@ export class PermissionPrompter {
           scope: o.scope,
         })),
         directoryScopeOptions: directoryScopeOptions
-          ? directoryScopeOptions.map((o) => ({ scope: o.scope, label: o.label }))
+          ? directoryScopeOptions.map((o) => ({
+              scope: o.scope,
+              label: o.label,
+            }))
           : undefined,
         diff,
         conversationId,
@@ -186,9 +193,11 @@ export class PermissionPrompter {
   resolveConfirmation(
     requestId: string,
     decision: UserDecision,
-    selectedPattern?: string,
-    selectedScope?: string,
-    decisionContext?: string,
+    options?: {
+      selectedPattern?: string;
+      selectedScope?: string;
+      decisionContext?: string;
+    },
   ): void {
     if (!this.ownedIds.has(requestId)) {
       log.warn({ requestId }, "No pending prompt for confirmation response");
@@ -201,9 +210,12 @@ export class PermissionPrompter {
       decision === "allow" ? "approved" : "rejected",
     );
     this.ownedIds.delete(requestId);
-    (interaction?.rpcResolve as ((v: ConfirmResult) => void) | undefined)?.(
-      { decision, selectedPattern, selectedScope, decisionContext },
-    );
+    (interaction?.rpcResolve as ((v: ConfirmResult) => void) | undefined)?.({
+      decision,
+      selectedPattern: options?.selectedPattern,
+      selectedScope: options?.selectedScope,
+      decisionContext: options?.decisionContext,
+    });
   }
 
   /**
@@ -215,14 +227,12 @@ export class PermissionPrompter {
     for (const requestId of [...this.ownedIds]) {
       const interaction = pendingInteractions.resolve(requestId, "superseded");
       this.ownedIds.delete(requestId);
-      (interaction?.rpcResolve as ((v: ConfirmResult) => void) | undefined)?.(
-        {
-          decision: "deny",
-          wasSystemCancel: true,
-          decisionContext:
-            "The user sent a new message instead of responding to this permission prompt. Stop what you are doing and respond to the user's new message. Do NOT retry this tool or request permission again until the user asks you to.",
-        },
-      );
+      (interaction?.rpcResolve as ((v: ConfirmResult) => void) | undefined)?.({
+        decision: "deny",
+        wasSystemCancel: true,
+        decisionContext:
+          "The user sent a new message instead of responding to this permission prompt. Stop what you are doing and respond to the user's new message. Do NOT retry this tool or request permission again until the user asks you to.",
+      });
     }
   }
 

package/src/permissions/question-prompter.test.ts

@@ -1,9 +1,7 @@
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import type {
-  QuestionRequest,
-  ServerMessage,
-} from "../daemon/message-protocol.js";
+import type { QuestionRequestEvent } from "../api/events/question-request.js";
+import type { ServerMessage } from "../daemon/message-protocol.js";
 import type {
   QuestionBatchSubmission,
   QuestionPromptResult,
@@ -13,7 +11,12 @@ import type {
 const mockConfig = {
   timeouts: { permissionTimeoutSec: 0.05 },
 };
+// Preserve every other export from the real config/loader so other
+// tests in the same `bun test` run (which share module-level mocks)
+// don't lose access to e.g. `setNestedValue`.
+const realConfigLoader = await import("../config/loader.js");
 mock.module("../config/loader.js", () => ({
+  ...realConfigLoader,
   getConfig: () => mockConfig,
   loadConfig: () => mockConfig,
   invalidateConfigCache: () => {},
@@ -63,17 +66,26 @@ mock.module("../runtime/pending-interactions.js", () => ({
   clear: () => _piStore.clear(),
 }));
 
-const {
-  QuestionPrompter,
-  QuestionBatchValidationError,
-  buildBatchEntries,
-} = await import("./question-prompter.js");
+// `QuestionPrompter` imports `broadcastMessage` directly from
+// assistant-event-hub now (the constructor-injection seam was removed).
+// Intercept that one export so each test instance can observe what the
+// prompter would have broadcast — but preserve every other export from
+// the real module so other tests in the same `bun test` run (which
+// share module-level mocks) still see e.g. `assistantEventHub`.
+let _sentBuffer: ServerMessage[] = [];
+const realEventHub = await import("../runtime/assistant-event-hub.js");
+mock.module("../runtime/assistant-event-hub.js", () => ({
+  ...realEventHub,
+  broadcastMessage: (msg: ServerMessage) => _sentBuffer.push(msg),
+}));
+
+const { QuestionPrompter, QuestionBatchValidationError, buildBatchEntries } =
+  await import("./question-prompter.js");
 
 function makePrompter() {
   const sent: ServerMessage[] = [];
-  const prompter = new QuestionPrompter({
-    broadcastMessage: (msg) => sent.push(msg),
-  });
+  _sentBuffer = sent;
+  const prompter = new QuestionPrompter();
   return { prompter, sent };
 }
 
@@ -176,7 +188,7 @@ describe("QuestionPrompter", () => {
     const promise = prompter.prompt(singleQuestionParams);
 
     expect(sent).toHaveLength(1);
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
     expect(req.type).toBe("question_request");
     expect(req.questions).toHaveLength(1);
     expect(req.questions[0]?.id).toBe("q1");
@@ -207,7 +219,7 @@ describe("QuestionPrompter", () => {
       ],
     });
 
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
     expect(req.freeTextPlaceholder).toBe("Type a fruit");
     expect(req.questions[0]?.freeTextPlaceholder).toBe("Type a fruit");
 
@@ -228,7 +240,7 @@ describe("QuestionPrompter", () => {
     void prompter.prompt(threeQuestionParams);
 
     expect(sent).toHaveLength(1);
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
     expect(req.questions.map((q) => q.id)).toEqual(["q1", "q2", "q3"]);
     // Flat fields mirror the first entry for backwards compat.
     expect(req.question).toBe("Q1?");
@@ -239,7 +251,7 @@ describe("QuestionPrompter", () => {
     const { prompter, sent } = makePrompter();
 
     const promise = prompter.prompt(threeQuestionParams);
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
 
     resolveBatch(req.requestId, [
       { questionId: "q2", kind: "option", optionId: "y" },
@@ -262,7 +274,7 @@ describe("QuestionPrompter", () => {
     const { prompter, sent } = makePrompter();
 
     const promise = prompter.prompt(threeQuestionParams);
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
 
     resolveBatch(req.requestId, [
       { questionId: "q1", kind: "skip" },
@@ -279,7 +291,7 @@ describe("QuestionPrompter", () => {
     const { prompter, sent } = makePrompter();
 
     const promise = prompter.prompt(threeQuestionParams);
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
 
     closeBatch(req.requestId);
 
@@ -294,12 +306,9 @@ describe("QuestionPrompter", () => {
 
   test("buildBatchEntries rejects unknown questionId", () => {
     expect(() =>
-      buildBatchEntries(
-        ["q1"],
-        () => true,
-        new Set(["q1"]),
-        [{ questionId: "qX", kind: "option", optionId: "a" }],
-      ),
+      buildBatchEntries(["q1"], () => true, new Set(["q1"]), [
+        { questionId: "qX", kind: "option", optionId: "a" },
+      ]),
     ).toThrow(QuestionBatchValidationError);
   });
 
@@ -347,7 +356,7 @@ describe("QuestionPrompter", () => {
       ...threeQuestionParams,
       signal: ac.signal,
     });
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
     expect(_piStore.has(req.requestId)).toBe(true);
 
     ac.abort();
@@ -377,7 +386,7 @@ describe("QuestionPrompter", () => {
       ...threeQuestionParams,
       signal: ac.signal,
     });
-    const req = sent[0] as QuestionRequest;
+    const req = sent[0] as QuestionRequestEvent;
     expect(_piStore.has(req.requestId)).toBe(true);
 
     // Simulate `removeByConversation` clearing the registry entry before

package/src/permissions/question-prompter.ts

@@ -1,11 +1,11 @@
 import { v4 as uuid } from "uuid";
 
-import { getConfig } from "../config/loader.js";
 import type {
   QuestionOption,
-  QuestionRequest,
-  ServerMessage,
-} from "../daemon/message-protocol.js";
+  QuestionRequestEvent,
+} from "../api/events/question-request.js";
+import { getConfig } from "../config/loader.js";
+import { broadcastMessage } from "../runtime/assistant-event-hub.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 import { AssistantError, ErrorCode } from "../util/errors.js";
 import { getLogger } from "../util/logger.js";
@@ -161,10 +161,6 @@ export interface QuestionBatchMetadata {
  * secret prompts, so they share the same idle-timeout knob.
  */
 export class QuestionPrompter {
-  constructor(
-    private deps: { broadcastMessage(msg: ServerMessage): void },
-  ) {}
-
   async prompt(params: QuestionPromptParams): Promise<QuestionPromptResult> {
     const { conversationId, questions, toolUseId, signal } = params;
 
@@ -279,7 +275,7 @@ export class QuestionPrompter {
       // batched payload, and the flat fields mirror `questions[0]` for
       // backwards compat with clients that haven't adopted `questions[]`.
       const head = entries[0]!;
-      const msg: QuestionRequest = {
+      const msg: QuestionRequestEvent = {
         type: "question_request",
         requestId,
         questions: entries,
@@ -291,7 +287,7 @@ export class QuestionPrompter {
         toolUseId,
       };
 
-      this.deps.broadcastMessage(msg);
+      broadcastMessage(msg);
     });
   }
 }

package/src/plugin-api/constants.ts

@@ -20,6 +20,10 @@ export const HOOKS = {
   SHUTDOWN: "shutdown",
   /** Fires once per user turn, immediately before the agent loop receives `runMessages`. */
   USER_PROMPT_SUBMIT: "user-prompt-submit",
+  /** Fires once per tool result, after the tool returns and before the result is sent to the provider. */
+  POST_TOOL_USE: "post-tool-use",
+  /** Fires when the model yields a response with no tool calls — the run's stop boundary. Decides whether to stop or continue with a follow-up turn. */
+  STOP: "stop",
 } as const;
 
 /** Union of every hook name declared in {@link HOOKS}. */

package/src/plugin-api/index.ts

@@ -24,13 +24,18 @@
  * - {@link PluginShutdownContext} — passed to `shutdown` hook at teardown
  * - {@link UserPromptSubmitContext} — passed to `user-prompt-submit` hook,
  *   fired immediately before the agent loop receives a user's prompt
+ * - {@link PostToolUseContext} — passed to `post-tool-use` hook, fired once
+ *   per tool result before it joins the provider-bound history
+ * - {@link StopContext} — passed to `stop` hook, fired when the model yields
+ *   a response with no tool calls
+ * - {@link PluginHookFn} — signature every lifecycle hook implements
  * - {@link PluginLogger} — pino-compatible logger shape on the contexts
  * - {@link ToolDefinition} — author-facing tool spec (default-export shape
  *   for both plugin tool files and workspace tool files)
  * - {@link ToolContext} — passed to a plugin tool's `execute` method
  * - {@link ToolExecutionResult} — return shape of a plugin tool's `execute`
  *
- * Pipeline-argument types (`LLMCallArgs`, `MemoryArgs`, etc.) currently
+ * Pipeline-argument types (`MemoryArgs`, `CompactionArgs`, etc.) currently
  * live in `assistant/src/plugins/types.ts` and have not yet migrated into
  * this package. A follow-up PR will move them into this surface as the
  * per-pipeline schemas stabilize.
@@ -39,9 +44,13 @@
 export type { HookName } from "./constants.js";
 export { HOOKS } from "./constants.js";
 export type {
+  PluginHookFn,
   PluginInitContext,
   PluginLogger,
   PluginShutdownContext,
+  PostToolUseContext,
+  StopContext,
+  StopDecision,
   ToolContext,
   ToolDefinition,
   ToolExecutionResult,