@vellumai/assistant 0.8.6 → 0.8.7-dev.202606052118.34cd356

package/src/__tests__/first-greeting.test.ts

@@ -8,6 +8,7 @@ const {
   isWakeUpGreeting,
   getCannedFirstGreeting,
   buildScanFirstMessage,
+  buildSelfIntroMessage,
   CANNED_FIRST_GREETING,
 } = await import("../daemon/first-greeting.js");
 import type { OnboardingGreetingContext } from "../daemon/first-greeting.js";
@@ -96,7 +97,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll learn from it fast. Best head start you can give me.",
       );
     });
 
@@ -108,7 +109,7 @@ describe("first-greeting", () => {
         assistantName: "Remy",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Remy. Good to meet you.\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. If you have context or workflows from another assistant or harness, bring them over early and I can help port them.",
+        "Hey Alice, I'm Remy. Good to meet you.\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. And you don't have to start me from scratch — if there's a ChatGPT or Claude that already knows you, bring it over and I'll get up to speed fast. Honestly, it's the best head start you could give me.",
       );
     });
 
@@ -119,7 +120,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey, I'm Pax. Let's see what you've got.\n\nWe can jump straight into whatever you've got, or take a few minutes to just talk first. If you've got context or workflows from another assistant or harness, bring them over early and I'll port them with you. What sounds right?",
+        "Hey, I'm Pax. Let's see what you've got.\n\nWe can jump straight into whatever you've got, or take a few minutes to just talk first. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll get up to speed fast. Best head start you can give me — want to start there?",
       );
     });
 
@@ -131,7 +132,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Pax.\n\nWe can start with whatever's in front of you, or just talk for a bit first. Either way. If there's old context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "Hey Alice, I'm Pax.\n\nWe can start with whatever's in front of you, or just talk for a bit first. Either way. And you don't have to start me from nothing — if there's a ChatGPT or Claude that already knows you, bring it over and I'll learn from it. The best head start you could give me.",
       );
     });
 
@@ -142,7 +143,7 @@ describe("first-greeting", () => {
         userName: "Alice",
       });
       expect(greeting).toBe(
-        "Hey Alice,\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "Hey Alice,\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll learn from it fast. Best head start you can give me.",
       );
     });
 
@@ -153,7 +154,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "Hey, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll learn from it fast. Best head start you can give me.",
       );
     });
 
@@ -173,7 +174,7 @@ describe("first-greeting", () => {
         tone: "warm",
       });
       expect(greeting).toBe(
-        "Hey,\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. If you have context or workflows from another assistant or harness, bring them over early and I can help port them.",
+        "Hey,\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. And you don't have to start me from scratch — if there's a ChatGPT or Claude that already knows you, bring it over and I'll get up to speed fast. Honestly, it's the best head start you could give me.",
       );
     });
 
@@ -204,7 +205,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll learn from it fast. Best head start you can give me.",
       );
     });
 
@@ -234,7 +235,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax.");
       expect(invite).toBe(
-        "We can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "We can get into whatever you've got, or just talk first — that tends to go better. Up to you. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll learn from it fast. Best head start you can give me.",
       );
     });
 
@@ -243,7 +244,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax. Good to meet you.");
       expect(invite).toBe(
-        "We can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. If you have context or workflows from another assistant or harness, bring them over early and I can help port them.",
+        "We can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. And you don't have to start me from scratch — if there's a ChatGPT or Claude that already knows you, bring it over and I'll get up to speed fast. Honestly, it's the best head start you could give me.",
       );
     });
 
@@ -252,7 +253,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax. Let's see what you've got.");
       expect(invite).toBe(
-        "We can jump straight into whatever you've got, or take a few minutes to just talk first. If you've got context or workflows from another assistant or harness, bring them over early and I'll port them with you. What sounds right?",
+        "We can jump straight into whatever you've got, or take a few minutes to just talk first. And you don't have to start me from scratch — if you've built up a ChatGPT or Claude, bring it over and I'll get up to speed fast. Best head start you can give me — want to start there?",
       );
     });
 
@@ -261,7 +262,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax.");
       expect(invite).toBe(
-        "We can start with whatever's in front of you, or just talk for a bit first. Either way. If there's old context or workflows from another assistant or harness, bring them over early and I'll help port them.",
+        "We can start with whatever's in front of you, or just talk for a bit first. Either way. And you don't have to start me from nothing — if there's a ChatGPT or Claude that already knows you, bring it over and I'll learn from it. The best head start you could give me.",
       );
     });
 
@@ -286,7 +287,7 @@ describe("first-greeting", () => {
   });
 
   describe("migration offer is present in every variant", () => {
-    const MIGRATION_MARKER = "bring them over early";
+    const MIGRATION_MARKER = "head start";
 
     it("no-onboarding greeting includes the migration offer", () => {
       expect(getCannedFirstGreeting(undefined)).toContain(MIGRATION_MARKER);
@@ -309,7 +310,7 @@ describe("first-greeting", () => {
           assistantName: "Pax",
         });
         expect(greeting).toContain(MIGRATION_MARKER);
-        expect(greeting).toContain("port them");
+        expect(greeting).toContain("ChatGPT or Claude");
       }
     });
 
@@ -375,4 +376,44 @@ describe("first-greeting", () => {
       expect(greeting).not.toContain("personal");
     });
   });
+
+  describe("buildSelfIntroMessage", () => {
+    const ctx = (
+      over: Partial<OnboardingGreetingContext> = {},
+    ): OnboardingGreetingContext => ({
+      tools: [],
+      tasks: [],
+      tone: "grounded",
+      ...over,
+    });
+
+    it("uses both names when present", () => {
+      expect(
+        buildSelfIntroMessage(ctx({ assistantName: "Vela", userName: "alex" })),
+      ).toBe("Hi Vela, I'm alex. Nice to meet you.");
+    });
+
+    it("drops the missing user name", () => {
+      expect(buildSelfIntroMessage(ctx({ assistantName: "Vela" }))).toBe(
+        "Hi Vela. Nice to meet you.",
+      );
+    });
+
+    it("drops the missing assistant name", () => {
+      expect(buildSelfIntroMessage(ctx({ userName: "alex" }))).toBe(
+        "Hi, I'm alex. Nice to meet you.",
+      );
+    });
+
+    it("treats whitespace-only names as missing", () => {
+      expect(
+        buildSelfIntroMessage(ctx({ assistantName: "  ", userName: "  " })),
+      ).toBeUndefined();
+    });
+
+    it("returns undefined when neither name is known (caller keeps canned greeting)", () => {
+      expect(buildSelfIntroMessage(ctx())).toBeUndefined();
+      expect(buildSelfIntroMessage(undefined)).toBeUndefined();
+    });
+  });
 });

package/src/__tests__/gemini-image-service.test.ts

@@ -287,6 +287,19 @@ describe("mapGeminiError", () => {
     expect(msg).toContain("Rate limit");
   });
 
+  test("maps 402 status to a non-retryable out-of-credits message", () => {
+    const msg = mapGeminiError(new FakeApiError(402, "payment required"));
+    expect(msg).toContain("out of credits");
+    expect(msg).not.toContain("Please try again");
+  });
+
+  test("maps a managed-proxy 402 failure (plain Error) to out-of-credits message", () => {
+    const msg = mapGeminiError(
+      new Error("Managed proxy request failed (402): insufficient credits"),
+    );
+    expect(msg).toContain("out of credits");
+  });
+
   test("maps 500 status to server error message", () => {
     const msg = mapGeminiError(new FakeApiError(500, "internal"));
     expect(msg).toContain("temporarily unavailable");

package/src/__tests__/gemini-inline-media.test.ts

@@ -0,0 +1,78 @@
+import { describe, expect, test } from "bun:test";
+
+import {
+  base64ByteLength,
+  estimateGeminiAudioTokens,
+  GEMINI_MAX_INLINE_AUDIO_BYTES,
+  normalizeGeminiAudioMime,
+} from "../providers/gemini/inline-media.js";
+
+describe("normalizeGeminiAudioMime", () => {
+  test("maps audio/mpeg onto Gemini's audio/mp3 spelling", () => {
+    expect(normalizeGeminiAudioMime("audio/mpeg")).toBe("audio/mp3");
+  });
+
+  test("passes supported audio types through unchanged", () => {
+    for (const mime of [
+      "audio/wav",
+      "audio/mp3",
+      "audio/aiff",
+      "audio/aac",
+      "audio/ogg",
+      "audio/flac",
+    ]) {
+      expect(normalizeGeminiAudioMime(mime)).toBe(mime);
+    }
+  });
+
+  test("is case-insensitive and strips parameters", () => {
+    expect(normalizeGeminiAudioMime("AUDIO/MPEG")).toBe("audio/mp3");
+    expect(normalizeGeminiAudioMime("audio/ogg; codecs=opus")).toBe(
+      "audio/ogg",
+    );
+  });
+
+  test("returns null for types Gemini cannot take inline", () => {
+    for (const mime of [
+      "audio/x-m4a",
+      "audio/mp4",
+      "audio/opus",
+      "application/pdf",
+      "image/png",
+      "",
+    ]) {
+      expect(normalizeGeminiAudioMime(mime)).toBeNull();
+    }
+  });
+});
+
+describe("base64ByteLength", () => {
+  test("approximates raw bytes from base64 length", () => {
+    // 8 base64 chars → 6 raw bytes
+    expect(base64ByteLength("QUJDREVG")).toBe(6);
+    expect(base64ByteLength("")).toBe(0);
+  });
+});
+
+describe("estimateGeminiAudioTokens", () => {
+  test("scales with payload size and stays far below the base64-as-text count", () => {
+    // ~3 MB of base64 ≈ ~2.25 MB raw ≈ ~140s at 16 KB/s ≈ ~4.5k tokens.
+    const data = "A".repeat(3 * 1024 * 1024);
+    const tokens = estimateGeminiAudioTokens(data);
+    expect(tokens).toBeGreaterThan(1_000);
+    // Must be a small fraction of the naive base64-length/4 estimate (~786k).
+    expect(tokens).toBeLessThan(data.length / 40);
+  });
+
+  test("returns zero for empty data", () => {
+    expect(estimateGeminiAudioTokens("")).toBe(0);
+  });
+});
+
+test("inline audio cap leaves headroom under Gemini's 20 MB request limit", () => {
+  expect(GEMINI_MAX_INLINE_AUDIO_BYTES).toBe(12 * 1024 * 1024);
+  // Base64 of the cap (~16 MB) must stay under the 20 MB wire limit.
+  expect(GEMINI_MAX_INLINE_AUDIO_BYTES * (4 / 3)).toBeLessThan(
+    20 * 1024 * 1024,
+  );
+});