@vellumai/assistant 0.8.6 → 0.8.7-dev.202606052118.34cd356

package/src/daemon/host-cu-proxy.ts

@@ -23,7 +23,11 @@ import {
   assistantEventHub,
   broadcastMessage,
 } from "../runtime/assistant-event-hub.js";
-import { enforceSameActorOrErrorResult } from "../runtime/auth/same-actor.js";
+import {
+  ambiguousSameUserError,
+  enforceSameActorOrErrorResult,
+  pickSameUserAutoResolve,
+} from "../runtime/auth/same-actor.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 import type { ToolExecutionResult } from "../tools/types.js";
 import { AssistantError, ErrorCode } from "../util/errors.js";
@@ -156,33 +160,48 @@ export class HostCuProxy {
       });
     }
 
-    // Existence + capability validation for explicit targets. Mirrors
-    // HostFileProxy's resolver-side guard so that the proxy is safe even
-    // when called outside the conversation-surfaces dispatch (which has
-    // its own validation layer).
-    if (targetClientId != null) {
-      const client = assistantEventHub.getClientById(targetClientId);
+    let resolvedTargetClientId = targetClientId;
+    if (resolvedTargetClientId == null) {
+      const resolved = pickSameUserAutoResolve({
+        hub: assistantEventHub,
+        capability: "host_cu",
+        sourceActorPrincipalId,
+      });
+      if (resolved.kind === "ambiguous") {
+        return Promise.resolve(ambiguousSameUserError("host_cu"));
+      }
+      if (resolved.kind === "match") {
+        resolvedTargetClientId = resolved.clientId;
+      } else if (
+        assistantEventHub.listClientsByCapability("host_cu").length > 0
+      ) {
+        return Promise.resolve({
+          content:
+            "Computer use is not available for the current actor. Connect a host_cu-capable client as the same user.",
+          isError: true,
+        });
+      }
+    }
+
+    if (resolvedTargetClientId != null) {
+      const client = assistantEventHub.getClientById(resolvedTargetClientId);
       if (!client) {
         return Promise.resolve({
-          content: `No connected client with id '${targetClientId}' supports host_cu. Run \`assistant clients list --capability host_cu\` to see available clients.`,
+          content: `No connected client with id '${resolvedTargetClientId}' supports host_cu. Run \`assistant clients list --capability host_cu\` to see available clients.`,
           isError: true,
         });
       }
       if (!client.capabilities.includes("host_cu")) {
         return Promise.resolve({
-          content: `Client '${targetClientId}' does not support host_cu. Run \`assistant clients list --capability host_cu\` to see available clients.`,
+          content: `Client '${resolvedTargetClientId}' does not support host_cu. Run \`assistant clients list --capability host_cu\` to see available clients.`,
           isError: true,
         });
       }
 
-      // Same-user enforcement: targeted CU dispatch must be owned by the
-      // same actor on both sides. This is the authoritative gate — the
-      // dispatch layer (conversation-surfaces.ts) skips its own check
-      // and relies on the proxy.
       const rejection = enforceSameActorOrErrorResult({
         hub: assistantEventHub,
         sourceActorPrincipalId,
-        targetClientId,
+        targetClientId: resolvedTargetClientId,
         op: "host_cu",
       });
       if (rejection) return Promise.resolve(rejection);
@@ -214,10 +233,12 @@ export class HostCuProxy {
                   type: "host_cu_cancel",
                   requestId,
                   conversationId,
-                  ...(targetClientId != null ? { targetClientId } : {}),
+                  ...(resolvedTargetClientId != null
+                    ? { targetClientId: resolvedTargetClientId }
+                    : {}),
                 },
                 conversationId,
-                { targetClientId },
+                { targetClientId: resolvedTargetClientId },
               );
             } catch {
               // Best-effort cancel notification
@@ -234,10 +255,12 @@ export class HostCuProxy {
       pendingInteractions.register(requestId, {
         conversationId,
         kind: "host_cu",
-        targetClientId,
+        targetClientId: resolvedTargetClientId,
         targetActorPrincipalId:
-          targetClientId != null
-            ? assistantEventHub.getActorPrincipalIdForClient(targetClientId)
+          resolvedTargetClientId != null
+            ? assistantEventHub.getActorPrincipalIdForClient(
+                resolvedTargetClientId,
+              )
             : undefined,
         rpcResolve: resolve as (v: unknown) => void,
         rpcReject: reject,
@@ -255,11 +278,12 @@ export class HostCuProxy {
             input,
             stepNumber,
             reasoning,
-            // Include in body so receiving client can verify targeted endpoint.
-            ...(targetClientId != null ? { targetClientId } : {}),
+            ...(resolvedTargetClientId != null
+              ? { targetClientId: resolvedTargetClientId }
+              : {}),
           },
           conversationId,
-          { targetClientId },
+          { targetClientId: resolvedTargetClientId },
         );
       } catch (err) {
         this._ownedRequests.delete(requestId);

package/src/daemon/host-file-proxy.ts

@@ -10,6 +10,7 @@ import {
   pickSameUserAutoResolve,
 } from "../runtime/auth/same-actor.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
+import { readAudioBase64 } from "../tools/shared/filesystem/audio-read.js";
 import { readImageBase64 } from "../tools/shared/filesystem/image-read.js";
 import type { ToolExecutionResult } from "../tools/types.js";
 import { AssistantError, ErrorCode } from "../util/errors.js";
@@ -225,7 +226,13 @@ export class HostFileProxy {
    */
   resolve(
     requestId: string,
-    response: { content: string; isError: boolean; imageData?: string },
+    response: {
+      content: string;
+      isError: boolean;
+      imageData?: string;
+      audioData?: string;
+      audioMimeType?: string;
+    },
   ): void {
     const interaction = pendingInteractions.resolve(requestId, "answered");
     if (!interaction?.rpcResolve) {
@@ -244,6 +251,23 @@ export class HostFileProxy {
       );
       return;
     }
+    if (
+      meta.operation === "read" &&
+      !response.isError &&
+      typeof response.audioData === "string" &&
+      response.audioData.length > 0 &&
+      typeof response.audioMimeType === "string" &&
+      response.audioMimeType.length > 0
+    ) {
+      interaction.rpcResolve(
+        readAudioBase64(
+          response.audioData,
+          meta.path as string,
+          response.audioMimeType,
+        ),
+      );
+      return;
+    }
     interaction.rpcResolve({
       content: response.content,
       isError: response.isError,

package/src/daemon/host-proxy-preactivation.ts

@@ -102,6 +102,7 @@ export const HOST_PROXY_SKILL_PREACTIVATIONS: ReadonlyArray<{
 export function evaluateHostProxyAttachment(
   capability: HostProxyCapability,
   sourceInterface: InterfaceId | undefined,
+  sourceActorPrincipalId?: string,
 ): HostProxyAttachmentDecision {
   if (!sourceInterface) {
     return { shouldAttach: false, reason: "denied_no_interface" };
@@ -112,10 +113,18 @@ export function evaluateHostProxyAttachment(
   if (sourceInterface === "chrome-extension") {
     return { shouldAttach: false, reason: "denied_chrome_extension" };
   }
-  const clientCount =
-    assistantEventHub.listClientsByCapability(capability).length;
-  if (clientCount > 0) {
-    return { shouldAttach: true, reason: "cross_client", clientCount };
+  if (sourceActorPrincipalId == null) {
+    return { shouldAttach: false, reason: "denied_no_clients", clientCount: 0 };
+  }
+  const sameActorClients = assistantEventHub
+    .listClientsByCapability(capability)
+    .filter((c) => c.actorPrincipalId === sourceActorPrincipalId);
+  if (sameActorClients.length > 0) {
+    return {
+      shouldAttach: true,
+      reason: "cross_client",
+      clientCount: sameActorClients.length,
+    };
   }
   return { shouldAttach: false, reason: "denied_no_clients", clientCount: 0 };
 }
@@ -128,8 +137,13 @@ export function evaluateHostProxyAttachment(
 export function shouldAttachHostProxyForCapability(
   capability: HostProxyCapability,
   sourceInterface: InterfaceId | undefined,
+  sourceActorPrincipalId?: string,
 ): boolean {
-  return evaluateHostProxyAttachment(capability, sourceInterface).shouldAttach;
+  return evaluateHostProxyAttachment(
+    capability,
+    sourceInterface,
+    sourceActorPrincipalId,
+  ).shouldAttach;
 }
 
 /**
@@ -148,12 +162,17 @@ export function shouldAttachHostProxyForCapability(
 export function preactivateHostProxySkills(
   conversation: HostProxyPreactivationTarget,
   sourceInterface: InterfaceId | undefined,
+  sourceActorPrincipalId?: string,
 ): void {
   const decisions: Record<string, HostProxyAttachmentDecision> = {};
   const preactivatedSkillIds: string[] = [];
 
   for (const { capability, skillId } of HOST_PROXY_SKILL_PREACTIVATIONS) {
-    const decision = evaluateHostProxyAttachment(capability, sourceInterface);
+    const decision = evaluateHostProxyAttachment(
+      capability,
+      sourceInterface,
+      sourceActorPrincipalId,
+    );
     decisions[capability] = decision;
     if (decision.shouldAttach) {
       conversation.addPreactivatedSkillId(skillId);

package/src/daemon/lifecycle.ts

@@ -60,8 +60,6 @@ import { sweepConceptPageFrontmatter } from "../memory/v2/frontmatter-sweep.js";
 import { emitNotificationSignal } from "../notifications/emit-signal.js";
 import { backfillManualTokenConnections } from "../oauth/manual-token-connection.js";
 import { seedOAuthProviders } from "../oauth/seed-providers.js";
-import { installPluginRuntime } from "../plugins/external-api.js";
-import { loadUserPlugins } from "../plugins/user-loader.js";
 import { backfillGuardIfNeeded } from "../proactive-artifact/index.js";
 import { ensurePromptFiles } from "../prompts/system-prompt.js";
 import { runProviderConnectionsBackfill } from "../providers/inference/backfill.js";
@@ -100,6 +98,7 @@ import {
   updateWorkItem,
 } from "../work-items/work-item-store.js";
 import { WorkspaceHeartbeatService } from "../workspace/heartbeat-service.js";
+import { repairAdaptiveThinkingOnManagedProfiles } from "../workspace/migrations/097-enable-adaptive-thinking-managed-profiles.js";
 import { WORKSPACE_MIGRATIONS } from "../workspace/migrations/registry.js";
 import { runWorkspaceMigrations } from "../workspace/migrations/runner.js";
 import {
@@ -112,13 +111,14 @@ import {
   startDiskPressureGuard,
   stopDiskPressureGuard,
 } from "./disk-pressure-guard.js";
-import { bootstrapPlugins } from "./external-plugins-bootstrap.js";
+import { initializePlugins } from "./external-plugins-bootstrap.js";
 import { backfillSlackInjectionTemplates } from "./handlers/config-slack-channel.js";
 import { installAssistantSymlink } from "./install-symlink.js";
 import {
   maybeRebuildMemoryV2Concepts,
   rebuildBm25CorpusStatsAndReseedSkills,
 } from "./memory-v2-startup.js";
+import { startOrphanReaper, stopOrphanReaper } from "./orphan-reaper.js";
 import { processMessage } from "./process-message.js";
 import { runProfilerSweep } from "./profiler-run-store.js";
 import {
@@ -590,6 +590,26 @@ export async function runDaemon(): Promise<void> {
       );
     }
 
+    // Re-run the adaptive thinking repair after overlay merge + profile seeding.
+    // Workspace migration 097 enables adaptive thinking on managed profiles, but
+    // it runs before mergeDefaultWorkspaceConfig() which can overwrite the fix
+    // with overlay profiles that have thinking disabled or absent. On-platform
+    // instances where the overlay supplies "balanced" / "quality-optimized"
+    // profiles without thinking enabled would be stuck permanently because the
+    // migration is already checkpointed as completed. This idempotent repair
+    // ensures thinking is enabled regardless of overlay ordering.
+    if (defaultConfigMerge.hadOverlay) {
+      try {
+        repairAdaptiveThinkingOnManagedProfiles(getWorkspaceDir());
+        log.info("Post-overlay adaptive thinking repair complete");
+      } catch (err) {
+        log.warn(
+          { err },
+          "Post-overlay adaptive thinking repair failed — continuing startup",
+        );
+      }
+    }
+
     log.info("Daemon startup: loading config");
     const config = loadConfig();
 
@@ -710,38 +730,12 @@ export async function runDaemon(): Promise<void> {
       });
     }
 
-    // Install the `globalThis.__vellumPluginRuntime` bridge before scanning
-    // for user plugins. Plugins that touch the bridge from their module body
-    // would throw without this — see `plugins/external-api.ts` for the
-    // rationale (compiled-binary module identity).
-    installPluginRuntime();
-
-    // Populate the registry with user plugins from `<workspaceDir>/plugins/*`
-    // AFTER first-party plugins have already registered via their static
-    // side-effect imports. User plugins may fail to load individually; a
-    // failing user plugin is logged and skipped so one bad install can't
-    // prevent the daemon from starting. Ordering is load-bearing:
-    //   first-party registrations → user registrations → bootstrap (init).
-    // Both groups are fully registered before any `init()` runs so plugins
-    // that depend on each other's registration observably see a stable
-    // registry at init time.
-    await loadUserPlugins();
-
-    // Bootstrap registered plugins. Runs after the plugin registry is
-    // populated (first-party static side-effect imports + user plugins
-    // loaded above) and before the DaemonServer starts handling
-    // conversations. Credential resolution + per-plugin storage directory
-    // creation happen here. Wrapped in try/catch so a failing plugin can't
-    // block daemon startup — bootstrapPlugins internally tears down any
-    // partially-initialized plugins before throwing.
-    try {
-      await bootstrapPlugins({ config, assistantVersion: APP_VERSION });
-    } catch (err) {
-      log.warn(
-        { err },
-        "Plugin bootstrap failed — continuing startup with degraded plugin functionality",
-      );
-    }
+    // Bring up the plugin layer: install the runtime bridge, register the
+    // first-party defaults, load user plugins, and run every plugin's
+    // `init()`. Ordering is load-bearing (defaults register ahead of user
+    // plugins so they compose innermost) and plugin failures are contained so
+    // they can't block daemon startup.
+    await initializePlugins();
 
     // Start the DaemonServer (conversation manager) before Qdrant so HTTP
     // routes can begin accepting requests while Qdrant initializes.
@@ -756,6 +750,7 @@ export async function runDaemon(): Promise<void> {
     await server.start();
     log.info("Daemon startup: DaemonServer started");
     startDiskPressureGuardForLifecycle();
+    startOrphanReaper();
 
     // Kick off the update bulletin background job AFTER `server.start()`
     // resolves. The conversation store must be initialized before wake
@@ -952,7 +947,6 @@ export async function runDaemon(): Promise<void> {
         await processMessage(
           conversationId,
           message,
-          undefined,
           options
             ? {
                 ...(options.trustClass
@@ -1135,25 +1129,27 @@ export async function runDaemon(): Promise<void> {
 
             let agentLoopError: string | undefined;
             let generatedText = "";
-            await conversation.runAgentLoop(instruction, messageId, (msg) => {
-              if (
-                "type" in msg &&
-                msg.type === "assistant_text_delta" &&
-                "text" in msg
-              ) {
-                generatedText += (msg as { text: string }).text;
-              }
-              if (
-                "type" in msg &&
-                (msg.type === "error" || msg.type === "conversation_error")
-              ) {
-                agentLoopError =
-                  "message" in msg
-                    ? (msg as { message: string }).message
-                    : "userMessage" in msg
-                      ? (msg as { userMessage: string }).userMessage
-                      : "Agent loop failed";
-              }
+            await conversation.runAgentLoop(instruction, messageId, {
+              onEvent: (msg) => {
+                if (
+                  "type" in msg &&
+                  msg.type === "assistant_text_delta" &&
+                  "text" in msg
+                ) {
+                  generatedText += (msg as { text: string }).text;
+                }
+                if (
+                  "type" in msg &&
+                  (msg.type === "error" || msg.type === "conversation_error")
+                ) {
+                  agentLoopError =
+                    "message" in msg
+                      ? (msg as { message: string }).message
+                      : "userMessage" in msg
+                        ? (msg as { userMessage: string }).userMessage
+                        : "Agent loop failed";
+                }
+              },
             });
 
             // Identify messages created during this run by diffing against
@@ -1351,6 +1347,7 @@ export async function runDaemon(): Promise<void> {
       cleanupPidFile: () => {
         stopGatewayFlagListener();
         stopDiskPressureGuardForLifecycle();
+        stopOrphanReaper();
         cleanupPidFile();
       },
     });
@@ -1365,6 +1362,7 @@ export async function runDaemon(): Promise<void> {
   } catch (err) {
     log.error({ err }, "Daemon startup failed — cleaning up");
     stopDiskPressureGuardForLifecycle();
+    stopOrphanReaper();
     cleanupPidFileIfOwner(process.pid);
     throw err;
   }

package/src/daemon/message-protocol.ts

@@ -21,7 +21,6 @@ export * from "./message-types/computer-use.js";
 export * from "./message-types/contacts.js";
 export * from "./message-types/conversations.js";
 export * from "./message-types/diagnostics.js";
-export * from "./message-types/disk-pressure.js";
 export * from "./message-types/document-comments.js";
 export * from "./message-types/documents.js";
 export * from "./message-types/guardian-actions.js";
@@ -51,6 +50,7 @@ export * from "./message-types/work-items.js";
 export * from "./message-types/workspace.js";
 
 // Import domain-level union aliases for composition
+import type { DiskPressureStatusChangedEvent } from "../api/events/disk-pressure-status-changed.js";
 import type { _AcpServerMessages } from "./message-types/acp.js";
 import type {
   _AppsClientMessages,
@@ -77,7 +77,6 @@ import type {
   _DiagnosticsClientMessages,
   _DiagnosticsServerMessages,
 } from "./message-types/diagnostics.js";
-import type { _DiskPressureServerMessages } from "./message-types/disk-pressure.js";
 import type { _DocumentCommentsServerMessages } from "./message-types/document-comments.js";
 import type {
   _DocumentsClientMessages,
@@ -216,7 +215,7 @@ export type ServerMessage =
   | _UpgradesServerMessages
   | _AcpServerMessages
   | _BookmarksServerMessages
-  | _DiskPressureServerMessages
+  | DiskPressureStatusChangedEvent
   | SubagentEvent;
 
 // === Contract schema ===

package/src/daemon/message-provenance.ts

@@ -0,0 +1,49 @@
+/**
+ * Provenance-based message trust filtering.
+ *
+ * Each persisted message row records the trust class of the actor that
+ * produced it under `metadata.provenanceTrustClass`. Untrusted actors
+ * (unknown / trusted_contact viewers) must never see content that
+ * originated from the guardian, so any view assembled for an untrusted
+ * actor filters the history down to rows whose provenance is itself
+ * non-guardian.
+ *
+ * This lives in its own low-dependency module (types only) so both the
+ * conversation lifecycle (history load) and the context compactor (image
+ * manifest) can apply the identical filter without creating an import
+ * cycle through `conversation-lifecycle` ↔ `window-manager` ↔ `compactor`.
+ */
+import type { MessageRow } from "../memory/conversation-crud.js";
+import type { TrustClass } from "../runtime/actor-trust-resolver.js";
+
+export function parseProvenanceTrustClass(
+  metadata: string | null,
+): TrustClass | undefined {
+  if (!metadata) return undefined;
+  try {
+    const parsed = JSON.parse(metadata) as { provenanceTrustClass?: unknown };
+    const trustClass = parsed?.provenanceTrustClass;
+    if (
+      trustClass === "guardian" ||
+      trustClass === "trusted_contact" ||
+      trustClass === "unknown"
+    ) {
+      return trustClass;
+    }
+  } catch {
+    // Ignore malformed metadata and treat as unknown provenance.
+  }
+  return undefined;
+}
+
+export function filterMessagesForUntrustedActor(
+  messages: MessageRow[],
+): MessageRow[] {
+  return messages.filter((m) => {
+    const provenanceTrustClass = parseProvenanceTrustClass(m.metadata);
+    return (
+      provenanceTrustClass === "trusted_contact" ||
+      provenanceTrustClass === "unknown"
+    );
+  });
+}

package/src/daemon/message-types/apps.ts

@@ -1,6 +1,4 @@
-// App management, gallery, publishing, and sharing types.
-
-import type { GalleryManifest } from "../../gallery/gallery-manifest.js";
+// App management, publishing, and sharing types.
 
 // === Client → Server ===
 
@@ -81,15 +79,6 @@ export interface GetSigningIdentityResponse {
   error?: string;
 }
 
-export interface GalleryListRequest {
-  type: "gallery_list";
-}
-
-export interface GalleryInstallRequest {
-  type: "gallery_install";
-  galleryAppId: string;
-}
-
 export interface AppHistoryRequest {
   type: "app_history_request";
   appId: string;
@@ -271,19 +260,6 @@ export interface ShareAppCloudResponse {
   error?: string;
 }
 
-export interface GalleryListResponse {
-  type: "gallery_list_response";
-  gallery: GalleryManifest;
-}
-
-export interface GalleryInstallResponse {
-  type: "gallery_install_response";
-  success: boolean;
-  appId?: string;
-  name?: string;
-  error?: string;
-}
-
 export interface AppHistoryResponse {
   type: "app_history_response";
   appId: string;
@@ -347,8 +323,6 @@ export type _AppsClientMessages =
   | OpenBundleRequest
   | SignBundlePayloadResponse
   | GetSigningIdentityResponse
-  | GalleryListRequest
-  | GalleryInstallRequest
   | AppHistoryRequest
   | AppDiffRequest
   | AppFileAtVersionRequest
@@ -371,8 +345,6 @@ export type _AppsServerMessages =
   | SignBundlePayloadRequest
   | GetSigningIdentityRequest
   | ShareAppCloudResponse
-  | GalleryListResponse
-  | GalleryInstallResponse
   | AppHistoryResponse
   | AppDiffResponse
   | AppFileAtVersionResponse

package/src/daemon/message-types/contacts.ts

@@ -1,5 +1,7 @@
 // Contact management: list, get, update channel status, and delete.
 
+import type { ContactRequestEvent } from "../../api/events/contact-request.js";
+
 // === Client → Server ===
 
 export interface ContactsRequest {
@@ -36,25 +38,6 @@ export interface ContactsChanged {
   type: "contacts_changed";
 }
 
-/**
- * Server → Client prompt requesting the user to enter a contact channel address.
- * Emitted by the `contacts/prompt` IPC route.
- */
-export interface ContactRequest {
-  type: "contact_request";
-  requestId: string;
-  /** Suggested channel type (e.g. "phone", "email") — used as a hint, not enforced. */
-  channel?: string;
-  /** Placeholder text for the address input field. */
-  placeholder?: string;
-  /** Display label shown above the input field. */
-  label?: string;
-  /** Longer description shown below the label. */
-  description?: string;
-  /** Suggested role for the new contact (guardian / trusted-contact / unknown). */
-  role?: string;
-}
-
 export interface ContactPayload {
   id: string;
   displayName: string;
@@ -90,4 +73,4 @@ export type _ContactsClientMessages = ContactsRequest;
 export type _ContactsServerMessages =
   | ContactsResponse
   | ContactsChanged
-  | ContactRequest;
+  | ContactRequestEvent;