@vellumai/assistant 0.10.2-dev.202606250318.5e7cfb0 → 0.10.2

package/src/runtime/routes/__tests__/contact-routes.test.ts

@@ -1,212 +0,0 @@
-/**
- * Unit tests for the contacts read API.
- *
- * `handleListContacts`, `handleGetContact`, and the `search_contacts`
- * no-filter case relay to the gateway rich read (`contacts_list_rich` /
- * `contacts_get_rich`), which is the source of truth for the ACL fields
- * (`role`/`status`/`policy`/`verifiedAt`/`interactionCount`/`lastInteraction`).
- * These tests assert the serialized response shape is gateway-sourced and
- * unchanged for the web client, that no read path falls back to the assistant
- * DB, and that a relay failure fails closed (surfaces an error) instead of
- * reading local ACL.
- */
-
-import { beforeEach, describe, expect, mock, test } from "bun:test";
-
-import { IpcCallError } from "@vellumai/gateway-client/ipc-client";
-
-let ipcCalls: { method: string; params?: Record<string, unknown> }[] = [];
-let ipcResult: unknown = {};
-let ipcError: Error | undefined;
-
-const ipcCallPersistentMock = mock(
-  async (method: string, params?: Record<string, unknown>) => {
-    ipcCalls.push({ method, params });
-    if (ipcError) throw ipcError;
-    return ipcResult;
-  },
-);
-
-const actualGatewayClient = await import("../../../ipc/gateway-client.js");
-
-mock.module("../../../ipc/gateway-client.js", () => ({
-  ...actualGatewayClient,
-  ipcCallPersistent: ipcCallPersistentMock,
-}));
-
-// Guard: fail loudly if any read path falls back to the assistant DB for ACL
-// fields. The relay read paths must source role/status/stats from the gateway.
-const actualContactStore = await import("../../../contacts/contact-store.js");
-
-const contactStoreReadGuard = mock(() => {
-  throw new Error(
-    "assistant contact-store read must not happen on the gateway relay path",
-  );
-});
-
-mock.module("../../../contacts/contact-store.js", () => ({
-  ...actualContactStore,
-  getContact: contactStoreReadGuard,
-  listContacts: contactStoreReadGuard,
-  getAssistantContactMetadata: contactStoreReadGuard,
-}));
-
-const { handleListContacts, handleGetContact, ROUTES } = await import(
-  "../contact-routes.js"
-);
-
-const gatewayChannel = {
-  id: "ch_1",
-  contactId: "ct_1",
-  type: "sms",
-  address: "+15550100",
-  isPrimary: true,
-  externalUserId: null,
-  status: "active",
-  policy: "allow",
-  verifiedAt: 1700,
-  verifiedVia: "invite",
-  lastSeenAt: 1800,
-  interactionCount: 7,
-  lastInteraction: 1900,
-  revokedReason: null,
-  blockedReason: null,
-};
-
-const gatewayContact = {
-  id: "ct_1",
-  displayName: "Alice",
-  role: "member",
-  notes: "a note",
-  contactType: "human",
-  lastInteraction: 1900,
-  interactionCount: 7,
-  createdAt: 1000,
-  updatedAt: 1500,
-  channels: [gatewayChannel],
-};
-
-describe("contacts read API relays from the gateway", () => {
-  beforeEach(() => {
-    ipcCalls = [];
-    ipcResult = {};
-    ipcError = undefined;
-    ipcCallPersistentMock.mockClear();
-    contactStoreReadGuard.mockClear();
-  });
-
-  test("list relays to contacts_list_rich and serializes the gateway ACL fields", async () => {
-    ipcResult = { ok: true, contacts: [gatewayContact] };
-
-    const result = await handleListContacts({ limit: "50" });
-
-    expect(ipcCalls).toEqual([
-      { method: "contacts_list_rich", params: { limit: 50 } },
-    ]);
-    expect(result.ok).toBe(true);
-    expect(result.contacts).toHaveLength(1);
-
-    const [contact] = result.contacts;
-    // ACL fields are gateway-sourced and reach the web client unchanged.
-    expect(contact.role).toBe("member");
-    expect(contact.interactionCount).toBe(7);
-    expect(contact.lastInteraction).toBe(1900);
-    const channel = contact.channels[0] as Record<string, unknown>;
-    expect(channel.status).toBe("active");
-    expect(channel.policy).toBe("allow");
-    expect(channel.verifiedAt).toBe(1700);
-    expect(channel.interactionCount).toBe(7);
-    expect(channel.lastInteraction).toBe(1900);
-    // Channel compat echoes address into externalUserId for older clients.
-    expect(channel.externalUserId).toBe("+15550100");
-
-    expect(contactStoreReadGuard).not.toHaveBeenCalled();
-  });
-
-  test("list forwards the role filter to the gateway", async () => {
-    ipcResult = { ok: true, contacts: [] };
-
-    await handleListContacts({ limit: "10", role: "guardian" });
-
-    expect(ipcCalls).toEqual([
-      {
-        method: "contacts_list_rich",
-        params: { limit: 10, role: "guardian" },
-      },
-    ]);
-  });
-
-  test("list fails closed when the gateway relay is unavailable", async () => {
-    ipcError = new IpcCallError("gateway down", {
-      statusCode: 503,
-      errorCode: "UNAVAILABLE",
-    });
-
-    await expect(handleListContacts({ limit: "50" })).rejects.toMatchObject({
-      message: "gateway down",
-      statusCode: 503,
-    });
-    // No assistant-DB fallback read.
-    expect(contactStoreReadGuard).not.toHaveBeenCalled();
-  });
-
-  test("get relays to contacts_get_rich and serializes the gateway ACL fields", async () => {
-    ipcResult = { ok: true, contact: gatewayContact };
-
-    const result = await handleGetContact("ct_1");
-
-    expect(ipcCalls).toEqual([
-      { method: "contacts_get_rich", params: { contactId: "ct_1" } },
-    ]);
-    expect(result.ok).toBe(true);
-    expect(result.contact.role).toBe("member");
-    expect(result.contact.interactionCount).toBe(7);
-    const channel = result.contact.channels[0] as Record<string, unknown>;
-    expect(channel.status).toBe("active");
-    expect(channel.externalUserId).toBe("+15550100");
-    expect(contactStoreReadGuard).not.toHaveBeenCalled();
-  });
-
-  test("get surfaces a clean gateway not-found as a 404", async () => {
-    ipcResult = { ok: true };
-
-    await expect(handleGetContact("missing")).rejects.toMatchObject({
-      statusCode: 404,
-    });
-    expect(contactStoreReadGuard).not.toHaveBeenCalled();
-  });
-
-  test("get fails closed on a relay failure (no assistant-DB fallback)", async () => {
-    ipcError = new IpcCallError("gateway down", {
-      statusCode: 503,
-      errorCode: "UNAVAILABLE",
-    });
-
-    await expect(handleGetContact("ct_1")).rejects.toMatchObject({
-      message: "gateway down",
-      statusCode: 503,
-    });
-    expect(contactStoreReadGuard).not.toHaveBeenCalled();
-  });
-
-  test("search no-filter relays to the gateway list read", async () => {
-    ipcResult = { ok: true, contacts: [gatewayContact] };
-
-    const route = ROUTES.find((r) => r.operationId === "search_contacts");
-    expect(route).toBeDefined();
-
-    const contacts = (await route!.handler({ body: {} })) as Array<{
-      role: string;
-      interactionCount: number;
-      channels: { status: string }[];
-    }>;
-
-    expect(ipcCalls).toEqual([
-      { method: "contacts_list_rich", params: { limit: 50 } },
-    ]);
-    expect(contacts[0].role).toBe("member");
-    expect(contacts[0].interactionCount).toBe(7);
-    expect(contacts[0].channels[0].status).toBe("active");
-    expect(contactStoreReadGuard).not.toHaveBeenCalled();
-  });
-});

package/src/runtime/routes/__tests__/global-search-routes.test.ts

@@ -1,93 +0,0 @@
-/**
- * Unit tests for the global-search contacts ordering source.
- *
- * Recency ordering for contacts surfaces `contacts.updatedAt`, never the
- * channel-derived `lastInteraction` column. Daemon-native contact search
- * carries no gateway-relayed ContactRead, so `updatedAt` is the deterministic
- * ordering key.
- */
-
-import { afterEach, describe, expect, mock, test } from "bun:test";
-
-import type { ContactWithChannels } from "../../../contacts/types.js";
-
-let searchContactsResult: ContactWithChannels[] = [];
-
-const searchContactsMock = mock(() => searchContactsResult);
-
-const actualContactStore = await import("../../../contacts/contact-store.js");
-
-mock.module("../../../contacts/contact-store.js", () => ({
-  ...actualContactStore,
-  searchContacts: searchContactsMock,
-}));
-
-const { ROUTES } = await import("../global-search-routes.js");
-
-const handler = ROUTES.find((r) => r.operationId === "search_global")!.handler;
-
-function makeContact(
-  overrides: Partial<ContactWithChannels>,
-): ContactWithChannels {
-  return {
-    id: "ct_1",
-    displayName: "Alice",
-    notes: null,
-    lastInteraction: null,
-    interactionCount: 0,
-    createdAt: 1,
-    updatedAt: 1,
-    role: "contact",
-    contactType: "human",
-    principalId: null,
-    userFile: null,
-    channels: [],
-    ...overrides,
-  };
-}
-
-afterEach(() => {
-  searchContactsResult = [];
-  searchContactsMock.mockClear();
-});
-
-describe("global-search contacts recency source", () => {
-  test("surfaces contacts.updatedAt as lastInteraction, not the channel column", async () => {
-    searchContactsResult = [
-      makeContact({
-        id: "ct_1",
-        displayName: "Alice",
-        updatedAt: 5000,
-        lastInteraction: 9999,
-      }),
-    ];
-
-    const result = (await handler({
-      queryParams: { q: "ali", categories: "contacts" },
-    })) as { results: { contacts: { id: string; lastInteraction: number }[] } };
-
-    expect(result.results.contacts).toHaveLength(1);
-    expect(result.results.contacts[0].lastInteraction).toBe(5000);
-  });
-
-  test("preserves searchContacts ordering deterministically", async () => {
-    searchContactsResult = [
-      makeContact({ id: "ct_a", displayName: "A", updatedAt: 300 }),
-      makeContact({ id: "ct_b", displayName: "B", updatedAt: 200 }),
-      makeContact({ id: "ct_c", displayName: "C", updatedAt: 100 }),
-    ];
-
-    const result = (await handler({
-      queryParams: { q: "x", categories: "contacts" },
-    })) as { results: { contacts: { id: string; lastInteraction: number }[] } };
-
-    expect(result.results.contacts.map((c) => c.id)).toEqual([
-      "ct_a",
-      "ct_b",
-      "ct_c",
-    ]);
-    expect(result.results.contacts.map((c) => c.lastInteraction)).toEqual([
-      300, 200, 100,
-    ]);
-  });
-});

package/src/runtime/routes/onboarding-checkin-routes.ts

@@ -1,86 +0,0 @@
-/**
- * Route for programmatically scheduling the onboarding "Day 2 Check-in".
- *
- * POST /v1/onboarding/checkin — resolve the user's Google Calendar, find the
- * first open 15-minute slot tomorrow afternoon, and book the check-in event.
- *
- * Called by the web `/onboarding/research` flow the moment Google Calendar
- * OAuth lands. Best-effort by contract: a missing/insufficient calendar
- * connection returns `{ scheduled: false }` rather than an error.
- */
-
-import { z } from "zod";
-
-import { scheduleOnboardingCheckin } from "../../onboarding/schedule-checkin.js";
-import { getLogger } from "../../util/logger.js";
-import { ACTOR_PRINCIPALS } from "../auth/route-policy.js";
-import { BadRequestError } from "./errors.js";
-import type { RouteDefinition, RouteHandlerArgs } from "./types.js";
-
-const log = getLogger("onboarding-checkin-routes");
-
-function asOptionalString(value: unknown, field: string): string | undefined {
-  if (value === undefined || value === null) return undefined;
-  if (typeof value !== "string") {
-    throw new BadRequestError(`${field} must be a string`);
-  }
-  const trimmed = value.trim();
-  return trimmed.length > 0 ? trimmed : undefined;
-}
-
-async function handleScheduleOnboardingCheckin({
-  body = {},
-}: RouteHandlerArgs) {
-  // The shared route adapter does not runtime-validate the body against the
-  // Zod requestBody (codegen-only), so guard types before use.
-  const userName = asOptionalString(body.userName, "userName");
-  const assistantName = asOptionalString(body.assistantName, "assistantName");
-  const timeZone = asOptionalString(body.timezone, "timezone");
-
-  const result = await scheduleOnboardingCheckin({
-    userName,
-    assistantName,
-    timeZone,
-  });
-
-  if (!result.scheduled) {
-    log.info({ reason: result.reason }, "Onboarding check-in not scheduled");
-  }
-  return result;
-}
-
-const RESPONSE_SCHEMA = z.object({
-  scheduled: z.boolean(),
-  reason: z.string().optional(),
-  eventId: z.string().optional(),
-  htmlLink: z.string().nullable().optional(),
-  start: z.string().optional(),
-  end: z.string().optional(),
-  timeZone: z.string().optional(),
-});
-
-export const ROUTES: RouteDefinition[] = [
-  {
-    operationId: "scheduleOnboardingCheckin",
-    endpoint: "onboarding/checkin",
-    method: "POST",
-    policy: {
-      requiredScopes: ["chat.write"],
-      allowedPrincipalTypes: ACTOR_PRINCIPALS,
-    },
-    summary: "Schedule the onboarding Day 2 check-in",
-    description:
-      "Find the first open 15-minute slot between 12pm and 5pm tomorrow " +
-      "(widening to 8am–8pm if booked) on the user's Google Calendar and " +
-      "create the Day 2 Check-in event. Best-effort: returns scheduled=false " +
-      "when no calendar is connected or the calendar scope wasn't granted.",
-    tags: ["onboarding"],
-    requestBody: z.object({
-      userName: z.string().optional(),
-      assistantName: z.string().optional(),
-      timezone: z.string().optional(),
-    }),
-    responseBody: RESPONSE_SCHEMA,
-    handler: handleScheduleOnboardingCheckin,
-  },
-];