@vellumai/assistant 0.10.2-dev.202606250318.5e7cfb0 → 0.10.2

package/scripts/test.sh

@@ -169,7 +169,6 @@ printf '%s\n' "${test_files[@]}" | xargs -P "${WORKERS}" -I {} bash -c '
 
   safe_name="$(echo "${test_file}" | tr "/" "_")"
   out_file="${results_dir}/${safe_name}.out"
-  base="$(basename "${test_file}")"
 
   coverage_args=""
   if [[ "${coverage_enabled}" == "true" ]]; then
@@ -186,48 +185,28 @@ printf '%s\n' "${test_files[@]}" | xargs -P "${WORKERS}" -I {} bash -c '
     timeout_cmd="gtimeout"
   fi
 
-  # Run the test file in its own bun process. Wrapped in a function so a
-  # transient infrastructure crash can be retried without duplicating the
-  # four-way (timeout × experimental-filter) invocation.
-  run_bun_test() {
-    if [[ -n "${timeout_cmd}" ]]; then
-      if [[ "${exclude_exp}" == "true" ]]; then
-        "${timeout_cmd}" -k 10 "${per_test_timeout}" bun test ${coverage_args} --test-name-pattern "^(?!.*\\[experimental\\])" "${test_file}" > "${out_file}" 2>&1
-      else
-        "${timeout_cmd}" -k 10 "${per_test_timeout}" bun test ${coverage_args} "${test_file}" > "${out_file}" 2>&1
-      fi
-    else
-      if [[ "${exclude_exp}" == "true" ]]; then
-        bun test ${coverage_args} --test-name-pattern "^(?!.*\\[experimental\\])" "${test_file}" > "${out_file}" 2>&1
-      else
-        bun test ${coverage_args} "${test_file}" > "${out_file}" 2>&1
-      fi
-    fi
-  }
-
   start_ms=$(perl -MTime::HiRes=time -e "printf \"%d\", time*1000")
 
-  run_bun_test
-  exit_code=$?
-
-  # Retry once on a transient bun loader/runtime crash. Bun occasionally aborts
-  # a worker before its tests run — e.g. "# Unhandled error between tests" with
-  # "error: ENOENT reading <corrupted path>" — failing the whole job even though
-  # the file is green on a clean process. Such a crash truncates the run before
-  # any assertion executes, so it prints no "(fail)" line; genuine assertion
-  # failures do, and are reported immediately without a retry (fast feedback, no
-  # masking of intermittent real failures). Timeouts (124/137) are handled by the
-  # hang branch below, not here.
-  if [[ ${exit_code} -ne 0 && ${exit_code} -ne 124 && ${exit_code} -ne 137 ]] \
-     && ! grep -q "^(fail)" "${out_file}" 2>/dev/null; then
-    echo "  ↻ ${base} (transient crash, exit ${exit_code} — retrying once)"
-    run_bun_test
-    exit_code=$?
+  if [[ -n "${timeout_cmd}" ]]; then
+    if [[ "${exclude_exp}" == "true" ]]; then
+      "${timeout_cmd}" -k 10 "${per_test_timeout}" bun test ${coverage_args} --test-name-pattern "^(?!.*\\[experimental\\])" "${test_file}" > "${out_file}" 2>&1
+    else
+      "${timeout_cmd}" -k 10 "${per_test_timeout}" bun test ${coverage_args} "${test_file}" > "${out_file}" 2>&1
+    fi
+  else
+    if [[ "${exclude_exp}" == "true" ]]; then
+      bun test ${coverage_args} --test-name-pattern "^(?!.*\\[experimental\\])" "${test_file}" > "${out_file}" 2>&1
+    else
+      bun test ${coverage_args} "${test_file}" > "${out_file}" 2>&1
+    fi
   fi
+  exit_code=$?
 
   end_ms=$(perl -MTime::HiRes=time -e "printf \"%d\", time*1000")
   elapsed=$(( end_ms - start_ms ))
 
+  base="$(basename "${test_file}")"
+
   # Record duration for longest-first scheduling in future runs.
   # Write the repo-relative path (not the basename) so the lookup in future
   # runs disambiguates files that share a basename across directories.

package/src/__tests__/actor-token-service.test.ts

@@ -29,17 +29,6 @@ mock.module("../config/env.js", () => ({
   checkUnrecognizedEnvVars: () => {},
 }));
 
-// No gateway in tests: force the reader to miss so resolution exercises the
-// local-store bootstrap fallback deterministically.
-let fakeGuardianDelivery: { principalId?: string | null } | null = null;
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () =>
-    fakeGuardianDelivery ? [fakeGuardianDelivery] : null,
-  guardianForChannel: (list: { principalId?: string | null }[]) => list[0],
-  invalidateGuardianDeliveryCache: () => {},
-  onContactChange: () => {},
-}));
-
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { resetExternalAssistantIdCache } from "../runtime/auth/external-assistant-id.js";
@@ -62,7 +51,6 @@ await initializeDb();
 beforeEach(async () => {
   initAuthSigningKey(TEST_KEY);
   resetExternalAssistantIdCache();
-  fakeGuardianDelivery = null;
   resetDbForTesting();
   await initializeDb();
 });
@@ -72,8 +60,8 @@ beforeEach(async () => {
 // ---------------------------------------------------------------------------
 
 describe("resolveLocalTrustContext", () => {
-  test("falls back to minimal trust context when no vellum binding exists", async () => {
-    const ctx = await resolveLocalTrustContext();
+  test("falls back to minimal trust context when no vellum binding exists", () => {
+    const ctx = resolveLocalTrustContext();
     expect(ctx.sourceChannel).toBe("vellum");
   });
 });
@@ -83,48 +71,38 @@ describe("resolveLocalTrustContext", () => {
 // ---------------------------------------------------------------------------
 
 describe("resolveLocalAuthContext", () => {
-  test("returns AuthContext with local principal type", async () => {
-    const ctx = await resolveLocalAuthContext("session-123");
+  test("returns AuthContext with local principal type", () => {
+    const ctx = resolveLocalAuthContext("session-123");
     expect(ctx.principalType).toBe("local");
   });
 
-  test("subject follows local:self:<conversationId> pattern", async () => {
-    const ctx = await resolveLocalAuthContext("session-abc");
+  test("subject follows local:self:<conversationId> pattern", () => {
+    const ctx = resolveLocalAuthContext("session-abc");
     expect(ctx.subject).toBe("local:self:session-abc");
   });
 
-  test("assistantId is always self", async () => {
-    const ctx = await resolveLocalAuthContext("session-123");
+  test("assistantId is always self", () => {
+    const ctx = resolveLocalAuthContext("session-123");
     expect(ctx.assistantId).toBe("self");
   });
 
-  test("uses local_v1 scope profile with local.all scope", async () => {
-    const ctx = await resolveLocalAuthContext("session-123");
+  test("uses local_v1 scope profile with local.all scope", () => {
+    const ctx = resolveLocalAuthContext("session-123");
     expect(ctx.scopeProfile).toBe("local_v1");
     expect(ctx.scopes.has("local.all")).toBe(true);
   });
 
-  test("actorPrincipalId is undefined when no vellum binding exists", async () => {
+  test("actorPrincipalId is undefined when no vellum binding exists", () => {
     const db = getDb();
     db.run("DELETE FROM contact_channels");
     db.run("DELETE FROM contacts");
 
-    const ctx = await resolveLocalAuthContext("session-123");
+    const ctx = resolveLocalAuthContext("session-123");
     expect(ctx.actorPrincipalId).toBeUndefined();
   });
 
-  test("resolves the guardian principal from the gateway when available", async () => {
-    const db = getDb();
-    db.run("DELETE FROM contact_channels");
-    db.run("DELETE FROM contacts");
-    fakeGuardianDelivery = { principalId: "gateway-guardian-id" };
-
-    const ctx = await resolveLocalAuthContext("session-123");
-    expect(ctx.actorPrincipalId).toBe("gateway-guardian-id");
-  });
-
-  test("conversationId matches the provided argument", async () => {
-    const ctx = await resolveLocalAuthContext("my-session");
+  test("conversationId matches the provided argument", () => {
+    const ctx = resolveLocalAuthContext("my-session");
     expect(ctx.conversationId).toBe("my-session");
   });
 });

package/src/__tests__/agent-loop-override-profile.test.ts

@@ -384,7 +384,6 @@ describe("SubagentManager.spawn — overrideProfile inheritance", () => {
 // inheritance chain breaks at the second nesting level.
 
 mock.module("../memory/conversation-crud.js", () => ({
-  setConversationProcessingStartedAt: () => {},
   // Always return undefined for the row read so the test fails fast unless
   // executeSubagentSpawn reads from context.overrideProfile first.
   getConversationOverrideProfile: () => undefined,

package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts

@@ -21,8 +21,6 @@ import type {
 import type { Message } from "../providers/types.js";
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   getConversationOverrideProfile: () => undefined,
 }));
 

package/src/__tests__/agent-wake-override-profile.test.ts

@@ -31,8 +31,6 @@ import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 let mockOverrideProfile: string | undefined = undefined;
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   getConversationOverrideProfile: (_id: string) => mockOverrideProfile,
   reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));

package/src/__tests__/annotate-activity-metadata.test.ts

@@ -55,8 +55,6 @@ let mockedRowContent = "";
 const updates: Array<{ id: string; content: string }> = [];
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: () => ({ id: "mock-msg-id" }),
   getMessageById: (id: string) =>
     mockedRowContent ? { id, content: mockedRowContent } : null,

package/src/__tests__/annotate-risk-options.test.ts

@@ -50,8 +50,6 @@ let mockedRowContent = "";
 const updates: Array<{ id: string; content: string }> = [];
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: () => ({ id: "mock-msg-id" }),
   getMessageById: (id: string) =>
     mockedRowContent ? { id, content: mockedRowContent } : null,

package/src/__tests__/approval-cascade.test.ts

@@ -121,8 +121,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},

package/src/__tests__/assistant-attachments.test.ts

@@ -373,48 +373,6 @@ describe("extractVellumLinks", () => {
     expect(result.directiveRequests[1].path).toBe("/tmp/b.pdf");
   });
 
-  test("decodes URL-encoded spaces in workspace paths", () => {
-    const text =
-      "[file with spaces.txt](vellum://workspace/scratch/file%20with%20spaces.txt)";
-    const result = extractVellumLinks(text);
-
-    expect(result.directiveRequests).toHaveLength(1);
-    expect(result.directiveRequests[0].source).toBe("sandbox");
-    expect(result.directiveRequests[0].path).toBe(
-      "scratch/file with spaces.txt",
-    );
-  });
-
-  test("decodes URL-encoded spaces in host paths", () => {
-    const text =
-      "[my file.pdf](vellum://host/Users/me/my%20file.pdf)";
-    const result = extractVellumLinks(text);
-
-    expect(result.directiveRequests).toHaveLength(1);
-    expect(result.directiveRequests[0].source).toBe("host");
-    expect(result.directiveRequests[0].path).toBe("/Users/me/my file.pdf");
-  });
-
-  test("warns on malformed percent-encoding instead of throwing", () => {
-    const text =
-      "[100% complete.txt](vellum://workspace/scratch/100%25complete.txt)";
-    const result = extractVellumLinks(text);
-
-    // %25 decodes to %, so this should succeed
-    expect(result.directiveRequests).toHaveLength(1);
-    expect(result.directiveRequests[0].path).toBe("scratch/100%complete.txt");
-  });
-
-  test("warns on malformed percent-encoding and skips the link", () => {
-    const text =
-      "[bad file](vellum://workspace/scratch/100%complete.txt)";
-    const result = extractVellumLinks(text);
-
-    expect(result.directiveRequests).toHaveLength(0);
-    expect(result.parseWarnings).toHaveLength(1);
-    expect(result.parseWarnings[0]).toContain("malformed percent-encoding");
-  });
-
   test("warns on empty workspace path", () => {
     const text = "[file](vellum://workspace/)";
     const result = extractVellumLinks(text);

package/src/__tests__/background-workers-disk-pressure.test.ts

@@ -100,8 +100,6 @@ mock.module("../daemon/process-message.js", () => ({
 
 const createdConversations: Array<{ conversationType: string }> = [];
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: mock(() => ({ id: "msg-1" })),
   archiveConversation: mock(() => true),
   batchSetDisplayOrders: mock(() => {}),

package/src/__tests__/btw-routes.test.ts

@@ -43,8 +43,6 @@ mock.module("../memory/conversation-key-store.js", () => ({
 const mockAddMessage = mock(() => {});
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: mockAddMessage,
   reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));

package/src/__tests__/build-persisted-content.test.ts

@@ -41,8 +41,6 @@ mock.module("../config/loader.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: () => ({ id: "mock-msg-id" }),
   getMessageById: () => null,
   updateMessageContent: () => {},

package/src/__tests__/call-controller.test.ts

@@ -168,25 +168,6 @@ mock.module("../notifications/emit-signal.js", () => ({
   }),
 }));
 
-// Guardian principalId is resolved from the gateway binding reader. Mirror the
-// vellum binding seeded by resetTables so guardian dispatch can resolve it.
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () => [
-    {
-      channelType: "vellum",
-      contactId: "guardian-vellum",
-      principalId: "test-principal-id",
-      address: "local",
-      status: "active",
-    },
-  ],
-  guardianForChannel: (
-    list: Array<{ channelType: string; status: string }>,
-    channelType: string,
-  ) => list.find((g) => g.channelType === channelType && g.status === "active"),
-  anyGuardian: (list: unknown[]) => list[0],
-}));
-
 mock.module("../calls/voice-session-bridge.js", () => {
   mockStartVoiceTurn = mock(createMockVoiceTurn(["Hello", " there"]));
   return {