@vellumai/assistant 0.10.2-dev.202606250318.5e7cfb0 → 0.10.2

package/src/__tests__/runtime-attachment-metadata.test.ts

@@ -272,6 +272,7 @@ describe("WhatsApp channel ingress attachment resolution", () => {
     const trustVerdict = resolveLocalTrustVerdict({
       channelType: "whatsapp",
       actorExternalId: WHATSAPP_USER_ID,
+      externalChatId: "whatsapp-chat-1",
     });
     return {
       sourceChannel: "whatsapp",

package/src/__tests__/secret-ingress-http.test.ts

@@ -96,8 +96,6 @@ const addMessageMock = mock(
 );
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: (
     conversationId: string,
     role: string,
@@ -129,18 +127,6 @@ mock.module("../runtime/trust-context-resolver.js", () => ({
   }),
 }));
 
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () => [
-    {
-      channelType: "vellum",
-      contactId: "guardian-contact",
-      principalId: "test-user",
-      address: "test-user",
-      status: "active",
-    },
-  ],
-}));
-
 mock.module("../runtime/guardian-reply-router.js", () => ({
   routeGuardianReply: async () => ({
     consumed: false,

package/src/__tests__/send-endpoint-busy.test.ts

@@ -109,38 +109,17 @@ mock.module("../daemon/approval-generators.js", () => ({
   createApprovalConversationGenerator: () => _approvalGenerator,
 }));
 
-// Dev-bypass resolves the real guardian principal, then runs the real
-// local-principal trust mapper against the gateway delivery read.
+// Mock local-actor-identity to return a stable guardian context that uses
+// the same principal as the canonical requests created in tests.
 mock.module("../runtime/local-actor-identity.js", () => ({
-  findLocalGuardianPrincipalId: async () => "test-principal-id",
-}));
-
-// Mock the IPC transport rather than local-principal-trust.js so the sibling
-// resolver unit test (which mocks guardian-delivery-reader, not ipcCall) isn't
-// shadowed when both files run in one Bun process. resolve_guardian_delivery
-// returns a single active vellum guardian whose principal matches the
-// dev-bypass-resolved id; any other method throws so unexpected IPC surfaces.
-mock.module("../ipc/gateway-client.js", () => ({
-  ipcCall: async (method: string) => {
-    if (method === "resolve_guardian_delivery") {
-      return {
-        guardians: [
-          {
-            channelType: "vellum",
-            contactId: "test-contact-id",
-            principalId: "test-principal-id",
-            address: "test-principal-id",
-            externalChatId: "test-principal-id",
-            status: "active",
-          },
-        ],
-      };
-    }
-    throw new Error(`Unexpected ipcCall in test: ${method}`);
-  },
+  resolveLocalTrustContext: () => ({
+    sourceChannel: "vellum",
+    trustClass: "guardian",
+    guardianPrincipalId: "test-principal-id",
+    guardianExternalUserId: "test-principal-id",
+  }),
 }));
 
-import { __resetGuardianDeliveryCacheForTest } from "../contacts/guardian-delivery-reader.js";
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import type { AssistantEvent } from "../runtime/assistant-event.js";
@@ -364,7 +343,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     db.run("DELETE FROM contact_channels");
     db.run("DELETE FROM contacts");
     pendingInteractions.clear();
-    __resetGuardianDeliveryCacheForTest();
 
     createGuardianBinding({
       channel: "vellum",

package/src/__tests__/skills.test.ts

@@ -351,50 +351,6 @@ describe("plugin-resident skills", () => {
     expect(skill).toBeUndefined();
   });
 
-  test("warns when a plugin directory is missing package.json", () => {
-    const warnings: unknown[][] = [];
-    const originalWarn = noopLogger.warn;
-    noopLogger.warn = (...args: unknown[]) => {
-      warnings.push(args);
-    };
-    try {
-      writePluginSkill(
-        "the-force",
-        "software-engineering",
-        "Software Engineering",
-        "Engineering workflow",
-        "body",
-        { withPackageJson: false },
-      );
-
-      const skill = loadSkillCatalog().find(
-        (s) => s.id === "software-engineering",
-      );
-      expect(skill).toBeUndefined();
-
-      const warnedForDir = warnings.some(
-        (args) =>
-          typeof args[0] === "object" &&
-          args[0] !== null &&
-          "pluginDir" in args[0] &&
-          (args[0] as { pluginDir: string }).pluginDir.endsWith("the-force") &&
-          typeof args[1] === "string" &&
-          args[1].includes("missing package.json"),
-      );
-      expect(warnedForDir).toBe(true);
-    } finally {
-      noopLogger.warn = originalWarn;
-    }
-  });
-
-  test("does not load resident skills from a plugin disabled via .disabled", () => {
-    writePluginSkill("caveman", "caveman", "Caveman", "Terse mode");
-    writeFileSync(join(pluginsDir, "caveman", ".disabled"), "");
-
-    const skill = loadSkillCatalog().find((s) => s.id === "caveman");
-    expect(skill).toBeUndefined();
-  });
-
   test("workspace skill overrides a plugin-resident skill with the same id", () => {
     const WORKSPACE_DIR = join(
       tmpdir(),

package/src/__tests__/slack-inbound-verification.test.ts

@@ -55,35 +55,6 @@ mock.module("../runtime/gateway-client.js", () => ({
   },
 }));
 
-// Guardian identity resolves via the gateway delivery reader, not the local
-// contacts DB. Seed it to mirror the createGuardianBinding calls below.
-interface GatewayGuardian {
-  channelType: string;
-  contactId: string;
-  principalId?: string | null;
-  displayName?: string | null;
-  address: string;
-  externalChatId?: string | null;
-  status: string;
-  verifiedAt?: number | null;
-}
-let gatewayGuardians: GatewayGuardian[] = [];
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () => gatewayGuardians,
-  guardianForChannel: (list: GatewayGuardian[], channelType: string) =>
-    list.find((g) => g.channelType === channelType && g.status === "active"),
-}));
-
-function seedGatewayGuardian(
-  g: Partial<GatewayGuardian> & { channelType: string; address: string },
-): void {
-  gatewayGuardians.push({
-    contactId: `c-${g.channelType}`,
-    status: "active",
-    ...g,
-  });
-}
-
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { findActiveSession } from "../runtime/channel-verification-service.js";
@@ -109,16 +80,7 @@ function resetState(): void {
   db.run("DELETE FROM canonical_guardian_deliveries");
   db.run("DELETE FROM contact_channels");
   db.run("DELETE FROM contacts");
-  gatewayGuardians = [];
-  // Seed the vellum guardian binding (gateway does this at startup in
-  // production). The gateway list is the source of truth for guardian
-  // resolution; the DB write mirrors it for any local INFO reads.
-  seedGatewayGuardian({
-    channelType: "vellum",
-    address: "guardian-principal",
-    principalId: "guardian-principal",
-    displayName: "guardian-principal",
-  });
+  // Seed the vellum guardian binding (gateway does this at startup in production)
   createGuardianBinding({
     channel: "vellum",
     guardianExternalUserId: "guardian-principal",
@@ -200,14 +162,7 @@ describe("Slack inbound trusted contact verification", () => {
   });
 
   test("guardian is notified of the access attempt alongside verification", async () => {
-    // Set up a guardian binding so the notification can target it. The gateway
-    // list resolves guardian identity; the DB write mirrors it.
-    seedGatewayGuardian({
-      channelType: "slack",
-      address: "U_GUARDIAN",
-      externalChatId: "D_GUARDIAN_DM",
-      principalId: "guardian-principal",
-    });
+    // Set up a guardian binding so the notification can target it
     createGuardianBinding({
       channel: "slack",
       guardianExternalUserId: "U_GUARDIAN",

package/src/__tests__/stt-hints.test.ts

@@ -13,15 +13,6 @@ let mockRecentContacts: ContactWithChannels[] = [];
 let mockFindContactByAddressThrows = false;
 let mockListContactsThrows = false;
 
-// Guardian deliveries returned by the mocked gateway reader. resolveGuardianName
-// is mocked to echo mockGuardianName, so the displayName here is captured below.
-let mockGuardianDelivery: Array<{
-  channelType: string;
-  status: string;
-  displayName: string | null;
-}> | null = null;
-let lastGuardianDisplayNameSeen: string | null | undefined;
-
 const logWarnFn = mock(() => {});
 
 // ---------------------------------------------------------------------------
@@ -34,10 +25,7 @@ mock.module("../daemon/identity-helpers.js", () => ({
 
 mock.module("../prompts/user-reference.js", () => ({
   DEFAULT_USER_REFERENCE: "my human",
-  resolveGuardianName: (displayName?: string | null) => {
-    lastGuardianDisplayNameSeen = displayName;
-    return mockGuardianName;
-  },
+  resolveGuardianName: () => mockGuardianName,
 }));
 
 mock.module("../contacts/contact-store.js", () => ({
@@ -47,6 +35,8 @@ mock.module("../contacts/contact-store.js", () => ({
     }
     return mockTargetContact;
   },
+  findGuardianForChannel: () => null,
+  listGuardianChannels: () => null,
   listContacts: (_limit?: number) => {
     if (mockListContactsThrows) {
       throw new Error("DB error: listContacts");
@@ -55,15 +45,6 @@ mock.module("../contacts/contact-store.js", () => ({
   },
 }));
 
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () => mockGuardianDelivery,
-  guardianForChannel: (
-    list: Array<{ channelType: string; status: string }>,
-    channelType: string,
-  ) => list.find((g) => g.channelType === channelType && g.status === "active"),
-  anyGuardian: (list: unknown[]) => list[0],
-}));
-
 // Bun's mock.module for "../util/logger.js" doesn't intercept the transitive
 // import in stt-hints.ts due to a Bun limitation. Mocking pino at the package
 // level works because getLogger uses a Proxy that lazily creates a pino child
@@ -338,22 +319,10 @@ describe("resolveCallHints", () => {
     mockRecentContacts = [];
     mockFindContactByAddressThrows = false;
     mockListContactsThrows = false;
-    mockGuardianDelivery = null;
-    lastGuardianDisplayNameSeen = undefined;
     logWarnFn.mockClear();
   });
 
-  test("guardian displayName for hints comes from the gateway binding", async () => {
-    mockGuardianDelivery = [
-      { channelType: "phone", status: "active", displayName: "GatewayGuardian" },
-    ];
-
-    await resolveCallHints(null, []);
-
-    expect(lastGuardianDisplayNameSeen).toBe("GatewayGuardian");
-  });
-
-  test("happy path wires all sources correctly", async () => {
+  test("happy path wires all sources correctly", () => {
     mockTargetContact = makeContact("Alice");
     mockRecentContacts = [makeContact("Bob"), makeContact("Charlie")];
 
@@ -366,7 +335,7 @@ describe("resolveCallHints", () => {
       inviteGuardianName: "Eve",
     };
 
-    const result = await resolveCallHints(session, ["StaticHint"]);
+    const result = resolveCallHints(session, ["StaticHint"]);
     const parts = result.split(",");
 
     expect(parts).toContain("StaticHint");
@@ -382,7 +351,7 @@ describe("resolveCallHints", () => {
     expect(logWarnFn).not.toHaveBeenCalled();
   });
 
-  test("findContactByAddress failure is caught and logged without throwing", async () => {
+  test("findContactByAddress failure is caught and logged without throwing", () => {
     mockFindContactByAddressThrows = true;
     mockRecentContacts = [makeContact("Bob")];
 
@@ -396,7 +365,7 @@ describe("resolveCallHints", () => {
     };
 
     // Should not throw
-    const result = await resolveCallHints(session, []);
+    const result = resolveCallHints(session, []);
     const parts = result.split(",");
 
     // Target contact should be absent (lookup failed)
@@ -407,7 +376,7 @@ describe("resolveCallHints", () => {
     expect(logWarnFn).toHaveBeenCalled();
   });
 
-  test("listContacts failure is caught and logged without throwing", async () => {
+  test("listContacts failure is caught and logged without throwing", () => {
     mockListContactsThrows = true;
     mockTargetContact = makeContact("Alice");
 
@@ -421,7 +390,7 @@ describe("resolveCallHints", () => {
     };
 
     // Should not throw
-    const result = await resolveCallHints(session, []);
+    const result = resolveCallHints(session, []);
     const parts = result.split(",");
 
     // Recent contacts should be absent (listing failed)
@@ -432,7 +401,7 @@ describe("resolveCallHints", () => {
     expect(logWarnFn).toHaveBeenCalled();
   });
 
-  test("inbound call resolves caller contact from fromNumber", async () => {
+  test("inbound call resolves caller contact from fromNumber", () => {
     mockTargetContact = makeContact("Alice");
     mockRecentContacts = [makeContact("Bob")];
 
@@ -445,7 +414,7 @@ describe("resolveCallHints", () => {
       inviteGuardianName: null,
     };
 
-    const result = await resolveCallHints(session, []);
+    const result = resolveCallHints(session, []);
     const parts = result.split(",");
 
     // For inbound, the contact found via fromNumber should appear as caller, not target
@@ -456,10 +425,10 @@ describe("resolveCallHints", () => {
     expect(logWarnFn).not.toHaveBeenCalled();
   });
 
-  test("null session produces hints from assistant name, guardian name, and recent contacts", async () => {
+  test("null session produces hints from assistant name, guardian name, and recent contacts", () => {
     mockRecentContacts = [makeContact("RecentOne"), makeContact("RecentTwo")];
 
-    const result = await resolveCallHints(null, ["Static"]);
+    const result = resolveCallHints(null, ["Static"]);
     const parts = result.split(",");
 
     expect(parts).toContain("Static");

package/src/__tests__/subagent-detail.test.ts

@@ -130,33 +130,6 @@ describe("parseSubagentMessages", () => {
     expect(result.objective).toBe("Research vampire lore");
   });
 
-  test("emits toolUseId and raw input on tool_use, toolUseId on tool_result", () => {
-    const messages = [
-      msg("user", [{ type: "text", text: "Do something" }]),
-      msg("assistant", [
-        {
-          type: "tool_use",
-          id: "t-abc",
-          name: "bash",
-          input: { command: "ls -la" },
-        },
-      ]),
-      msg("user", [
-        { type: "tool_result", tool_use_id: "t-abc", content: "total 0" },
-      ]),
-    ];
-
-    const result = parseSubagentMessages("sub-1", messages);
-    const toolUse = result.events.find((e) => e.type === "tool_use");
-    expect(toolUse).toBeDefined();
-    expect(toolUse!.toolUseId).toBe("t-abc");
-    expect(toolUse!.input).toEqual({ command: "ls -la" });
-
-    const toolResult = result.events.find((e) => e.type === "tool_result");
-    expect(toolResult).toBeDefined();
-    expect(toolResult!.toolUseId).toBe("t-abc");
-  });
-
   test("includes messageId on text events from assistant messages", () => {
     const messages = [
       msg("user", [{ type: "text", text: "Do something" }]),

package/src/__tests__/subagent-disposal.test.ts

@@ -326,68 +326,3 @@ describe("SubagentManager terminal disposal", () => {
     asInternals(manager).stopSweep();
   });
 });
-
-describe("SubagentManager.abort usage", () => {
-  test("emits the conversation's latest usage on abort, not zeros", () => {
-    const manager = new SubagentManager();
-    const sent: ServerMessage[] = [];
-    const sender = (msg: ServerMessage) => sent.push(msg);
-
-    const subagentId = "sa-abort-usage";
-    // state.usage starts at {0,0,0}; the live (fake) conversation has accrued
-    // usage (makeFakeConversation → {100, 50, 0.005}). Wire `sender` as the
-    // stored parent sender so `setStatus` routes the terminal event through it.
-    injectFakeSubagent(manager, subagentId, makeState(subagentId), sender);
-
-    const aborted = manager.abort(subagentId, sender, undefined, {
-      suppressNotification: true,
-    });
-    expect(aborted).toBe(true);
-
-    const statusMsg = sent.find(
-      (m): m is Extract<ServerMessage, { type: "subagent_status_changed" }> =>
-        m.type === "subagent_status_changed",
-    );
-    expect(statusMsg).toBeDefined();
-    expect(statusMsg!.status).toBe("aborted");
-    // The emitted usage is the conversation's accrued total — NOT the {0,0,0}
-    // init — so the client doesn't flush the token panel to zero on stop.
-    expect(statusMsg!.usage).toEqual({
-      inputTokens: 100,
-      outputTokens: 50,
-      estimatedCost: 0.005,
-    });
-
-    asInternals(manager).stopSweep();
-  });
-
-  test("keeps the last-known state.usage when the conversation was already released", () => {
-    const manager = new SubagentManager();
-    const sent: ServerMessage[] = [];
-    const sender = (msg: ServerMessage) => sent.push(msg);
-
-    const subagentId = "sa-abort-no-conv";
-    // No live conversation (released), but state carries a last-known usage —
-    // the abort must surface that, not overwrite it.
-    const state = makeState(subagentId, {
-      usage: { inputTokens: 320, outputTokens: 80, estimatedCost: 0.004 },
-    });
-    injectFakeSubagent(manager, subagentId, state, sender, null);
-
-    manager.abort(subagentId, sender, undefined, {
-      suppressNotification: true,
-    });
-
-    const statusMsg = sent.find(
-      (m): m is Extract<ServerMessage, { type: "subagent_status_changed" }> =>
-        m.type === "subagent_status_changed",
-    );
-    expect(statusMsg!.usage).toEqual({
-      inputTokens: 320,
-      outputTokens: 80,
-      estimatedCost: 0.004,
-    });
-
-    asInternals(manager).stopSweep();
-  });
-});

package/src/__tests__/subagent-notify-parent.test.ts

@@ -4,8 +4,6 @@ import { describe, expect, mock, test } from "bun:test";
 
 // Mock conversation-crud before importing tool executors that depend on it.
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},

package/src/__tests__/subagent-role-registry.test.ts

@@ -70,11 +70,8 @@ describe("SUBAGENT_ROLE_REGISTRY", () => {
     expect(SUBAGENT_ROLE_REGISTRY.planner.allowedTools!).toContain("recall");
   });
 
-  test("investigator is shell-free and uses code_search for code/log investigation", () => {
-    const tools = SUBAGENT_ROLE_REGISTRY.investigator.allowedTools!;
-    expect(tools).not.toContain("bash");
-    expect(tools).not.toContain("host_bash");
-    expect(tools).toContain("code_search");
+  test('investigator includes "bash" for grep/find-based code and log investigation', () => {
+    expect(SUBAGENT_ROLE_REGISTRY.investigator.allowedTools!).toContain("bash");
   });
 
   test("investigator excludes file write tools (read-only investigation)", () => {
@@ -88,8 +85,6 @@ describe("SUBAGENT_ROLE_REGISTRY", () => {
     expect(preamble).toContain("Root cause");
     expect(preamble).toContain("Evidence");
     expect(preamble).toContain("notify_parent");
-    expect(preamble).not.toContain("shell access");
-    expect(preamble).toContain("code_search");
   });
 
   test("no role references the old memory_recall tool name", () => {

package/src/__tests__/subagent-spawn-tool-fork.test.ts

@@ -3,8 +3,6 @@ import { mock } from "bun:test";
 
 // Mock conversation-crud before importing tool executors that depend on it.
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},

package/src/__tests__/subagent-tools.test.ts

@@ -29,8 +29,6 @@ mock.module("../config/loader.js", () => ({
   }),
 }));
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},

package/src/__tests__/suggestion-routes.test.ts

@@ -50,8 +50,6 @@ const mockGetMessages = mock((_conversationId: string) => [
 ]);
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   getMessages: mockGetMessages,
   getConversation: (_id: string) => null,
   reserveMessage: mock(async () => ({ id: "msg-reserve" })),

package/src/__tests__/title-generate-hook.test.ts

@@ -64,8 +64,6 @@ const mockGetConversation = mock(
     },
 );
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   getConversation: mockGetConversation,
 }));
 

package/src/__tests__/tool-executor-lifecycle-events.test.ts

@@ -78,8 +78,6 @@ mock.module("../permissions/checker.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   createConversation: (title: string) => ({ id: "conversation-1", title }),
   reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));

package/src/__tests__/tool-executor.test.ts

@@ -17,7 +17,6 @@ const mockConfig = {
     shellDefaultTimeoutSec: 120,
     shellMaxTimeoutSec: 600,
     permissionTimeoutSec: 300,
-    questionResponseTimeoutSec: 1800,
   },
   sandbox: {
     enabled: false,
@@ -1301,31 +1300,27 @@ describe("ToolExecutionResult includes risk metadata from classifier assessment"
 
 describe("computePerToolTimeoutMs ask_question budget", () => {
   // Regression guard: ask_question blocks on user input inside execute() via
-  // QuestionPrompter, which waits up to questionResponseTimeoutSec. The
-  // executor's generic toolExecutionTimeoutSec wrapper must give ask_question a
-  // budget strictly larger than that prompt timeout — otherwise the wrapper
-  // fires first and orphans the still-pending prompt behind the confusing "may
+  // QuestionPrompter, which waits up to permissionTimeoutSec. The executor's
+  // generic toolExecutionTimeoutSec wrapper must give ask_question a budget
+  // strictly larger than that prompt timeout — otherwise the wrapper fires
+  // first and orphans the still-pending prompt behind the confusing "may
   // still be running in the background" error. These assertions fail if the
-  // special case is removed and ask_question falls back to the generic budget,
-  // or if the executor budget and the prompter timeout drift onto different
-  // config knobs.
-  test("execution-timeout budget exceeds the prompt's own questionResponseTimeoutSec", () => {
-    const { questionResponseTimeoutSec } = mockConfig.timeouts;
+  // special case is removed and ask_question falls back to the generic budget.
+  test("execution-timeout budget exceeds the prompt's own permissionTimeoutSec", () => {
+    const { permissionTimeoutSec } = mockConfig.timeouts;
     const askQuestionBudgetMs = computePerToolTimeoutMs("ask_question", {});
 
-    expect(askQuestionBudgetMs).toBeGreaterThan(
-      questionResponseTimeoutSec * 1000,
-    );
-    expect(askQuestionBudgetMs).toBe((questionResponseTimeoutSec + 5) * 1000);
+    expect(askQuestionBudgetMs).toBeGreaterThan(permissionTimeoutSec * 1000);
+    expect(askQuestionBudgetMs).toBe((permissionTimeoutSec + 5) * 1000);
   });
 
   test("the generic budget that would otherwise apply is shorter than the prompt timeout", () => {
-    const { questionResponseTimeoutSec } = mockConfig.timeouts;
+    const { permissionTimeoutSec } = mockConfig.timeouts;
     const genericBudgetMs = computePerToolTimeoutMs("some_other_tool", {});
 
     // This is the collision the ask_question special case fixes: the generic
     // execution-timeout budget is shorter than the prompter's own wait, so
     // without the special case the wrapper trips first.
-    expect(genericBudgetMs).toBeLessThan(questionResponseTimeoutSec * 1000);
+    expect(genericBudgetMs).toBeLessThan(permissionTimeoutSec * 1000);
   });
 });

package/src/__tests__/tool-preview-lifecycle.test.ts

@@ -60,8 +60,6 @@ const reserveMessageMock = mock(
 const updateMessageContentMock = mock((_id: string, _content: string) => {});
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   getConversation: () => null,
   getMessageById: () => null,
   updateMessageContent: updateMessageContentMock,

package/src/__tests__/tool-result-metadata-plumbing.test.ts

@@ -40,8 +40,6 @@ mock.module("../config/loader.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: () => ({ id: "mock-msg-id" }),
   getMessageById: () => null,
   updateMessageContent: () => {},

package/src/__tests__/tool-start-timestamp.test.ts

@@ -43,8 +43,6 @@ let mockedRowContent = "";
 const updates: Array<{ id: string; content: string }> = [];
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: () => ({ id: "mock-msg-id" }),
   getMessageById: (id: string) =>
     mockedRowContent ? { id, content: mockedRowContent } : null,